summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-06-14Avoid duplicated attribute names in RID_ATTR_NAMESZolnai Tamás
It causes trouble to localiztation tools and also makes hard to distinguish these items on the UI. e.g. Edit -> Find & Replace -> Other options -> Attributes. Change-Id: Ie7a17e02947200a570b5e6209c8a99d1883a6860
2015-06-14Fix insertion and deletion in IndexedPropertyValuesContainerMatthew J. Francis
The cases for iterating to an element from the end (used for elements in the second half of the underlying array) had an off by one error causing the wrong elements to be inserted/removed Change-Id: Idcbf158cc31afaf02fce3f1975509edf6239d3ae Reviewed-on: https://gerrit.libreoffice.org/16073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-06-14Resolves: tdf#91393 autotext (etc) not fully drawnCaolán McNamara
the paint timer is activating after we ask gtk to size the window but before we/gtk get the ConfigureNotify that updates gtk knowledge of the size. So the gtk drawing calls are clipped to the previous ConfigureNotify size. So, lets try postponing paints if we have set a size but not received a configure notify yet I'll also revert e6a1956034c98204e30b0ca40330249d6f6f8155 in favour of this attempt Change-Id: If5e993f8e0e65053b59234fce0785398b93c1c46
2015-06-14surely we only care if *our* window is shown hereCaolán McNamara
Change-Id: Ia5bca11c0c24ed7ca301dbe15eca3dc684153ea8
2015-06-14cppcheck: redundantCondition [part2]Julien Nabet
Change-Id: I23e8a4834fa7858adb292ce0a4dfa5dab1ab5f00
2015-06-14cppcheck: redundantCondition [part1]Julien Nabet
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-14cppcheck: postfixOperatorJulien Nabet
Change-Id: Ia17bdf6e8f871d64add358822ea383236ecd6405
2015-06-14Typo: pyhton->pythonJulien Nabet
Change-Id: I16d99991b8b88753c593a5a1ab9e32a8e0264514
2015-06-13It's E_BEFORECLOSE not E_CLOSINGJulien Nabet
Change-Id: Ia53f9aa8bb3c7fd1dd5c0190624a667b65996ca2
2015-06-13Typo: E_HARDEXCETIONS->E_HARDEXCEPTIONSJulien Nabet
Change-Id: I482d8fdb549d2a9c79bb68bd910e761f61337fb6
2015-06-13Typo: corected->correctedJulien Nabet
Change-Id: I9a41d801b8807ed122a6737a924ba6792b449c45
2015-06-13TyposJulien Nabet
Change-Id: I0e74d800593245fa00013035c9498b77988b072b
2015-06-13tdf#91960 presentation causes Impress crashNoel Grandin
The SystenChildWindow in question is owned by ViewMediaShape Fixed ViewMediaShape to dispose the vcl objects it creates correctly. Also fix another crash in MediaWindowImpl child window correctly disposing its children. Change-Id: If4aebcb6e5824266c154416f7246d73c6cb3509c Reviewed-on: https://gerrit.libreoffice.org/16230 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-13Remove comment filenameAndrea Gelmini
This file was rm/mv on commit 47692bfc1275bfa24a7fb2627cc263142549d29d Change-Id: I141794aee5c57e345334af42fcea4eaa71709f1b Reviewed-on: https://gerrit.libreoffice.org/16259 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-06-13Fix typosAndrea Gelmini
Change-Id: Ifaa52b49b717d893846fc1e7ae4ac50735f824ac Reviewed-on: https://gerrit.libreoffice.org/16260 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-06-13do not access token data after token has been destroyedEike Rathke
Change-Id: I624e64745fd3874be3e1bd3df6bac18dfb17aebb
2015-06-13BASIC: Don't use SbiStringPool to pass SbiParser.Arnaud Versini
Change-Id: I15949e604285d804de1554d36acf36e8a407ebd9 Reviewed-on: https://gerrit.libreoffice.org/16137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2015-06-13no need to check for pShape hereAndras Timar
Change-Id: I6de2da7d2f17a14ddbe7e70651a416a01f49164b
2015-06-13amend commentAndras Timar
Change-Id: I45a452a7dbab35ab96c04336b35857f58a0af0c5
2015-06-13remove unused codeAndras Timar
Change-Id: If9b7870673a47b78457f6e22ee0cfa7e3a68372a
2015-06-13tdf#92000 save rectangle to DrawingML as a preset shapeAndras Timar
Change-Id: I8b39a210490759e9f548c195e516a26b94a8b3cb
2015-06-13Catch funny line-ends in pre-commit hook.Thorsten Behrens
Change-Id: I38836a9b3c9fb8ab7b71e157bba8a803eb4d3905
2015-06-13use VclPtr<>::CreateDavid Tardon
Change-Id: I4b3abbd390e7b6cb449ccd7f0fb956266fd0b5c8
2015-06-13Fix funny line-ends.Thorsten Behrens
Change-Id: I693d78854544b3f3bb441b17b0a062c738cda039
2015-06-13tdf#92036 - work around writer spelling issueMichael Meeks
Issue exposed by fix for tdf#91727. Change-Id: Ia1eafbd4db28bcfa6c90e0d58735e232c7449f83 Reviewed-on: https://gerrit.libreoffice.org/16252 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-13TyposJulien Nabet
Change-Id: I21c352a63d668c174eef212dbfbe6346c678ce4d
2015-06-13tdf#75256 - New icons insertendnote and trackchangesMatthias Freund
Change-Id: I13039f0999cac3ec5ffabd6a0d75f23065bc446b Reviewed-on: https://gerrit.libreoffice.org/16254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-06-13sw: overloading in C++ fail episode 6234Michael Stahl
Change-Id: Ida670ac9c6687314d8b425c3ac1f9896f54f2a15
2015-06-12Added test for redline with as-char frameVarun
fixed by commits 4dd2e61 and fae87e0 Change-Id: Ib6ca689af61187b32283753f80abaed96406f409 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-12Typo: Adapater->AdapterJulien Nabet
Change-Id: I696c0693dc7a69dc3a4b8df0c4e8571414d5b9a6
2015-06-12vcl: loplugin:pointertoboolMiklos Vajna
Change-Id: I0a84cce306d92c9358ae7a2a4d76f455e44f312b
2015-06-12do not adjust RPN named expressions relative references, tdf#91842 follow-upEike Rathke
Change-Id: I5a991d3b86fec0a3800d8243f73eb764789c8c69
2015-06-12Make SwFrameControlManager an EditWin ptr member to reduce re-compiles.Michael Meeks
Change-Id: Ic2491948aa555fa71f9e14af554bdf204c12247d Reviewed-on: https://gerrit.libreoffice.org/16236 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-12New VclPtr clang plugin to catch potential problems.Noel Grandin
Change-Id: I2571c4384e4c2dbe411e171325e10d57a0afe5a0 Reviewed-on: https://gerrit.libreoffice.org/16235 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-12Writer FrameControl lifecycle and management cleanup.Michael Meeks
We can't derive from a VclPtr base-class, and also another base, and then use boost::shared_ptr for that; re-factor to use a boost_ptr to hold a VclPtr<> for now. Also fix leaking envelope dialog. Change-Id: I2e1efbfaee3b6051e38ff7a14903a83ccd75136b Reviewed-on: https://gerrit.libreoffice.org/16160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-12tdf#91228: need to check the format's IsLockModified(), not the node'sMichael Stahl
commit 9f01951b858453684f2622541af0eb85d4544fc6 also did the extra Remove/Add for Draw fly objects, and it turns out that that's actually wrong because SwTextFlyCnt::SetAnchor() will set the anchor without locking anything if it's a Draw object. Replace it with a different hack in SetAnchor() that applies only if it calls LockModify(). Thanks to Varun Dhall for creating a reproducer document. Not sure if the LockModify() could be replaced completely, perhaps it's just an optimization to avoid re-creating layout frames for the fly. Change-Id: Ib3236f289c2c4202d48ac378a53ce02130d4ce2c
2015-06-12spellingAntoine Cœur
Change-Id: I5ccbb5a2b31192cea96fbb0f4ab926af86e94c9d Reviewed-on: https://gerrit.libreoffice.org/16223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Philippe Jung <phil.jung@free.fr>
2015-06-12std::list for SchedulerJuergen Funk
Re-factor the scheduler to use std::list Because - ImplSchedulerData - remove: mbInScheduler, mnUpdateTime, mnUpdateStack that is scheduler stuff - this struct is only a container for the scheduler-list - UpdateMinPeriod - the scheduler is the pure-virtual-class then the idle-class must override this method - ImplDeInitScheduler(bool All=true) - this patch 2e29a518b04250b5f9cc9d0d77da3df076834d60 remove all scheduler tasks and the scheduler, but after that, the scheduler is using, then crash. With this fix, only delete the scheduler-list, but not the scheduler The next steps - split the scheduler from the scheduler-list-handling the scheduler-list-handling need a static class - remove the scheduler from the timer-handling staff Change-Id: I8d4d4f27b2bc9684a48c2afafd0b3edd0716c71d Reviewed-on: https://gerrit.libreoffice.org/16148 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-06-12tdf#61908:XLSX formula cell range is not exported for MMULT.yogesh.bharate001
Problem Description: - Matrix multiplication cell formula range is not exported after roundtrip. XML Difference: Original : <f t="array" ref="G5:G6">MMULT(A1:C2,E1:E3)</f> Roundtrip : <f aca="false">MMULT(A1:C2,E1:E3)</f> Solution : Added formula cell range support for matrix multiplication. Change-Id: Ic871f064a98a324bc16a4253b633c97417c3f900 Reviewed-on: https://gerrit.libreoffice.org/16033 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-06-12mysqlcppconn library ends up in an extension, not in layer NONEStephan Bergmann
(so fix its Linux RPATH from "$ORIGIN/../Library" to none) Change-Id: Ie58e8e07cb08cdf12546f8bb7b92aa9e83815748
2015-06-12For Clang -fsanitize=vptr use -fvisibility-ms-compat, not -fvisibility=hiddenStephan Bergmann
...same as f0aa1a78fb209310e8baef53c02f365fca518d11 Change-Id: I35c1e6928dd4b29ef0ab448a181a5af7fb0640ab
2015-06-12Fix RHEL5 buildMiklos Vajna
Change-Id: I9a71ee85d2d28aed5bd3f4d1f6e91261a9228d04
2015-06-12tdf#91301: Don't cache incomplete tabs.Jan Holesovsky
After introduction of the Idle processing, something has changed so that the underlying GetGdkWindow() does not update its size fast enough; even though the gtk_window_resize() is called before the Window::Erase() (that actually paints the background) etc. The consequence of the not-yet-updated gdkDrawable is that we cache something that has the correct background in the top left 200x200 pixels, but the rest is just copied from the screen. Let's for now just not cache when the GetGdkWindow() is smaller than what we actually paint; TODO find the root cause. Change-Id: Ib6092668eb4613899f665bb0f12fc1eb15484e13
2015-06-12make it easier to find missing sidebar componentsMarkus Mohrhard
Change-Id: Id962fbc20d12db59818dfca421843c674755e36c Reviewed-on: https://gerrit.libreoffice.org/16101 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-06-12get rid of a few thousand unnecessary OpenGL callsMarkus Mohrhard
For each iteration of the (gtk) main loop we are dropping the yield mutext which results in calling OpenGLContext::clearCurrent. That method calls OpenGLContext::ReleaseFramebuffers which would call in the end glBindFramebuffer for each framebuffer related to that context. This would easily grow into the thousand OpenGL calls without doing any work. Change-Id: I209cc534fe58a5e11ef7df7f850a787916b8bd43 Reviewed-on: https://gerrit.libreoffice.org/16241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-06-12that case can't happen anymoreMarkus Mohrhard
Change-Id: If488a6aa6769ad45f08ad78de35402f676abe784 Reviewed-on: https://gerrit.libreoffice.org/16240 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-06-12Revert "Fix LibreOffice running with SAL_ENABLEGL=1"Markus Mohrhard
This reverts commit 6bf39b2f4ea4e880d8414b04269405e6b48efe23. Change-Id: I97619740f34cf0046f89352553dba73723f35a6f Reviewed-on: https://gerrit.libreoffice.org/16239 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-06-12lokdocview: Create LOK context inside of lok_doc_view_newPranav Kant
Change-Id: I675192d6bd6d10e6c7974a5de6f488f9a087ac32
2015-06-12lokdocview: Make this GObject class introspectablePranav Kant
... so that this widget can be used from other languages. Change-Id: Icd7d6df6aa587ffdb018af0b911300dc81ec6560
2015-06-12lokdocview: Change parent class to GtkDrawingAreaPranav Kant
It is not the job of the widget to provide the scroll bars. Change-Id: Iafc5724ed5b21717d711bb8f7e1a076dd1288b76