summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-03-25tdf#130334: Firebird deal with array fieldsJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=130334#c11 See https://firebirdsql.org/file/documentation/reference_manuals/fblangref25-en/html/fblangref25-datatypes-bnrytypes.html#fblangref25-datatypes-array Change-Id: I27c53b9c771fcdb3b89e66af325a8234c7de08bb Change-Id: I7b9d27f78e351eda611d13f5a07ef3c80ff00e3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90239 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 2ede753a8b7adecbf6ca78745e43e23c7498e289) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90042 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-25tdf#123268 fix lost chart if all legend entries are hiddenTünde Tóth
See also commit 19b2ed4dee1ec33ad55473d43bfcd0bfa194cbee (related tdf#51671, add UI options for new "hide legend entry" feature) Change-Id: If20ab167d867d2845fa414ba0bbc490bed09f61c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89123 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 300e65cc47f3d6ae1563350757dbfadc080d7452) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90387 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-25ofz#21168 sw,writerfilter: limit writerfilter hack to writerfilterCaolán McNamara
The problem is that at the end of WW8 import, a delete redline is inserted that ends up calling DeleteAndJoin from inside AppendRedline(). A fly is anchored AT_CHAR at (node 46, offset 0) and the deletion goes from (node 46, offset 0) to (node 48, offset 13) hence the special case check in IsDestroyFrameAnchoredAtChar() for the IsInReading() prevents it from being deleted, and then its anchor is still registered at the node 46 when it gets deleted. So try to restrict the WriterfilterHack to writerfilter, so it won't affect WW8 import. Unfortunately this is far less obvious than expected, because import can happen for creating a new file, in which case it's all done via UNO in writerfilter, or when inserting into an existing file, in which case SwReader::Read() is used. The SwDocShell's pMedium can't be used becuse in insert file case it will be the loaded file, not the inserted file. There isn't any obvious alternative to adding a silly UNO property for the writerfilter to use. Change-Id: Ia7fdc9bb1925202f6692ebee6e4b6b1fe50e5345 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c4dab726caaa73be9f9c731312080143b0a0b89d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90951
2020-03-25tdf#131273: fix crash when pasting quotes with fixed widthJulien Nabet
See bt https://bugs.documentfoundation.org/show_bug.cgi?id=131273#c2 Change-Id: I78f592bb2ee59b50e7301fe4e6f282e53c4eeb7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90438 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit cf3fec9e7cadd0a6c4f42a4015df429d9e32b7e8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90398 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-25tdf#130348: Add special case for ChartDeck, tooTor Lillqvist
Change-Id: Idf6cc1469f074debfc4351a58826a3a7411391ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89722 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 6a031edca26cadd5917a94de2d3b6a706197a8fc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89783 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-03-24Breeze, Colibre, elementary, Karasa Jaga :Fix for tdf#131509Rizal Muttaqin
Change italic in Spanish to K from C Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90966 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 70b9775af71b0e1a4b4d0760d2884631184db5ae) Change-Id: Ie82625f8a605de67c036a76ce438de1e883203f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90949 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-24Fix build with boost < 1.68Rico Tzschichholz
Follow-up fix for 73cac1031131021819a0fbd4d60554196aea230c "tdf130839: Corrects second level left margin in Smartart" Change-Id: Ie194062ba33cf505ad33fbfdc73c2f764b61d0aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90770 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-24icu: add patch to fix CVE-2020-10531Michael Stahl
Change-Id: I0aca4af1bd79f28bf1c920a4d05e80948106aaac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90971 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 002d1152dc418f7d624409e76cd9d4ac0b42c7f8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90975 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-24python3: upgrade to release 3.7.7Michael Stahl
Fixes CVE-2020-8315; this only affects Windows 7 and is a regression in Python 3.6. Change-Id: Ic1706e064a1b03ca1de6361794ed4586a89821d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90916 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 74c811da0dedb205976eae69d8589fd91bbaefa2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90824 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-24Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-6-4' to d0b2687510429e3f329f5f6beaeabb0e966df450 - update translations for 6.4.3 rc1 and force-fix errors using pocheck Change-Id: I91472b8a05d87407a754370f592224d85d0770d9
2020-03-24tdf#131434 ensure expander icon column is createdCaolán McNamara
which the normal ::insert case does, but the bulk insert omitted Change-Id: I9b236e5f0e91292539164d39f0f90e109a1b503e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90825 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-23tdf#130746: avoid nullptr dereferenceJustin Luth
Change-Id: I32979a23caffea844f1c8eac9f408b18f0768b62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90661 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit 81588ff2f0eb55576a5288778be2dfb5b4bc5e81) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90632 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-22tdf#131464: fix create an index of Writer in Japanese localeJulien Nabet
in i18npool/source/collator/collator_unicode.cxx, we got: 177 // replace algorithm name to implementation name. 178 if (rAlgorithm == "phonetic (alphanumeric first)") 179 aBuf.append("phonetic_alphanumeric_first"); 180 else if (rAlgorithm == "phonetic (alphanumeric last)") 181 aBuf.append("phonetic_alphanumeric_last"); 182 else 183 aBuf.append(rAlgorithm); So don't add extra ja_ before "phonetic..." Also we already add "ja" in buffer with line: 158 aBuf.append("get_").append(rLocale.Language).append("_"); so right functions from ICU will be retrieved Change-Id: I163c3ca4bb4dcfa1e5d29313190c5ba3e6396c4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90877 Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90889 Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-22Colibre: fix for tdf#131454, Wrong icons for Valid SignatureRizal Muttaqin
Change-Id: I16790b6f668823be346a6d8b51de4a98ac3eb5d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90874 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 8fe403c536234ff84ac2301e67e0f5483ba99b5b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90819
2020-03-21Missing test dependenciesStephan Bergmann
`make clean && make CppunitTest_sw_xhtmlexport` SIGABRT'ed with [...] > warn:vcl.builder:649768:649768:vcl/source/window/builder.cxx:462: DBG_UNHANDLED_EXCEPTION in VclBuilder::VclBuilder(vcl::Window *, const rtl::OUString &, const rtl::OUString &, const rtl::OString &, const css::uno::Reference<css::frame::XFrame> &, bool, const NotebookBarAddonsItem *) > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebarstylespanel.ui > warn:sfx.sidebar:649768:649768:sfx2/source/sidebar/SidebarController.cxx:976: Cannot create panel private:resource/toolpanel/SvxPanelFactory/StylesPropertyPanel com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebarstylespanel.ui > warn:vcl.builder:649768:649768:vcl/source/window/builder.cxx:462: DBG_UNHANDLED_EXCEPTION in VclBuilder::VclBuilder(vcl::Window *, const rtl::OUString &, const rtl::OUString &, const rtl::OString &, const css::uno::Reference<css::frame::XFrame> &, bool, const NotebookBarAddonsItem *) > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebartextpanel.ui > warn:sfx.sidebar:649768:649768:sfx2/source/sidebar/SidebarController.cxx:976: Cannot create panel private:resource/toolpanel/SvxPanelFactory/TextPropertyPanel com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebartextpanel.ui > warn:vcl.builder:649768:649768:vcl/source/window/builder.cxx:462: DBG_UNHANDLED_EXCEPTION in VclBuilder::VclBuilder(vcl::Window *, const rtl::OUString &, const rtl::OUString &, const rtl::OString &, const css::uno::Reference<css::frame::XFrame> &, bool, const NotebookBarAddonsItem *) > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebarparagraph.ui > warn:legacy.osl:649768:649768:vcl/source/window/window.cxx:269: Window ( 7Control()) with live children destroyed: 7VclVBox() > Window ( 7Control()) with live children destroyed: 7VclVBox() and then still failed with [...] > I/O warning : failed to load external entity "file:///.../instdir/share/xslt/export/xhtml/opendoc2xhtml.xsl" > error > xsltParseStylesheetFile : cannot parse file:///.../instdir/share/xslt/export/xhtml/opendoc2xhtml.xsl > warn:filter.xslt:662169:662186:filter/source/xsltfilter/XSLTFilter.cxx:234: XSLTFilter::error was called: com.sun.star.uno.Exception message: failed to load external entity "file:///.../instdir/share/xslt/export/xhtml/opendoc2xhtml.xsl" > > warn:xmloff:662169:662169:xmloff/source/core/xmlerror.cxx:169: An error or a warning has occurred during XML import/export! > Error-Id: 0x60040004 > Flags: 6 ERROR SEVERE > Class: 4 API > Number: 4 > Parameters: > Exception-Message: com.sun.star.uno.RuntimeException: "" > > warn:sfx.doc:662169:662169:sfx2/source/doc/sfxbasemodel.cxx:3096: Storing has failed, no error is set! > image-mimetype.odt: > unknown:0:testImageEmbedding::Import_Export > An uncaught exception of type com.sun.star.io.IOException > - SfxBaseModel::impl_store <file:///TMPDIR/libtest_sw_xhtmlexport.sozwb87q.tmp> failed: 0xc10(Error Area:Io Class:Write Code:16) and then still failed with [...] > I/O warning : failed to load external entity "file:///.../instdir/share/xslt/export/common/styles/style_collector.xsl" > compilation error: file file:///.../instdir/share/xslt/export/xhtml/opendoc2xhtml.xsl line 55 element include > xsl:include : unable to load file:///.../instdir/share/xslt/export/common/styles/style_collector.xsl > I/O warning : failed to load external entity "file:///.../instdir/share/xslt/export/common/styles/style_mapping_css.xsl" > compilation error: file file:///.../instdir/share/xslt/export/xhtml/opendoc2xhtml.xsl line 58 element include > xsl:include : unable to load file:///.../instdir/share/xslt/export/common/styles/style_mapping_css.xsl > I/O warning : failed to load external entity "file:///.../instdir/share/xslt/common/measure_conversion.xsl" > compilation error: file file:///.../instdir/share/xslt/export/xhtml/body.xsl line 28 element import > xsl:import : unable to load file:///.../instdir/share/xslt/common/measure_conversion.xsl > I/O warning : failed to load external entity "file:///.../instdir/share/xslt/export/common/body.xsl" > compilation error: file file:///.../instdir/share/xslt/export/xhtml/body.xsl line 31 element import > xsl:import : unable to load file:///.../instdir/share/xslt/export/common/body.xsl > I/O warning : failed to load external entity "file:///.../instdir/share/xslt/export/common/table/table.xsl" > compilation error: file file:///.../instdir/share/xslt/export/xhtml/body.xsl line 34 element import > xsl:import : unable to load file:///.../instdir/share/xslt/export/common/table/table.xsl > warn:filter.xslt:662890:662907:filter/source/xsltfilter/XSLTFilter.cxx:234: XSLTFilter::error was called: com.sun.star.uno.Exception message: failed to load external entity "file:///.../instdir/share/xslt/export/common/table/table.xsl" > > warn:xmloff:662890:662890:xmloff/source/core/xmlerror.cxx:169: An error or a warning has occurred during XML import/export! > Error-Id: 0x60040004 > Flags: 6 ERROR SEVERE > Class: 4 API > Number: 4 > Parameters: > Exception-Message: com.sun.star.uno.RuntimeException: "" > > warn:sfx.doc:662890:662890:sfx2/source/doc/sfxbasemodel.cxx:3096: Storing has failed, no error is set! > image-mimetype.odt: > unknown:0:testImageEmbedding::Import_Export > An uncaught exception of type com.sun.star.io.IOException > - SfxBaseModel::impl_store <file:///TMPDIR/libtest_sw_xhtmlexport.sozwmx0q.tmp> failed: 0xc10(Error Area:Io Class:Write Code:16) Change-Id: I295222448be208582003c62e3d610f6fe743af3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90772 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit f7efe5a7fe8ade48fe376eb817017b26892f95b3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90812
2020-03-21tdf#61274 sd PDF export: fix links ending up on wrong pages with hidden slidesMiklos Vajna
SdPage::IsExcluded() decides if a slide is hidden, SdXImpressDocument::render() checks for this and returns early if needed. In that case PDFExport::ExportSelection() detects that the produced metafile has no actions and avoids creating a PDF page. Then Impress links are created using the vcl::PDFExtOutDevData::CreateLink() call in drawinglayer::processor2d::VclMetafileProcessor2D::processTextHierarchyFieldPrimitive2D(), not specifying the PDF page number explicitly. This means the link is created on the "current" page number, set in vcl::PDFExtOutDevData::SetCurrentPageNumber(), called by PDFExport::ExportSelection(), but that filter/ code can't know about hidden slides in sd/. Fix the problem by setting the page number again in SdXImpressDocument::render(), that way the link created by drawinglayer will end on the correct page. (cherry picked from commit 01dbb38680aa39a4d3bc7afd05d44a4b2c9bc6ab) Conflicts: vcl/qa/cppunit/pdfexport/pdfexport.cxx Change-Id: Ic29e345d45bc7c944d65e6e450f1d742dd0e9f8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90551 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-21tdf#100706: get blink cursor delay for MacOSJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=100706#c1 Change-Id: I2e471f093ce18c8716108c4ba793c2124e489295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-21Missing test dependencyStephan Bergmann
`make clean && make CppunitTest_sw_apitests` SIGABRT'ed with [...] > warn:vcl.builder:2929395:2929395:vcl/source/window/builder.cxx:462: DBG_UNHANDLED_EXCEPTION in VclBuilder::VclBuilder(vcl::Window*, const rtl::OUString&, const rtl::OUString&, const rtl::OString&, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame>&, bool, const NotebookBarAddonsItem*) > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebarstylespanel.ui > warn:sfx.sidebar:2929395:2929395:sfx2/source/sidebar/SidebarController.cxx:976: Cannot create panel private:resource/toolpanel/SvxPanelFactory/StylesPropertyPanel com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebarstylespanel.ui > warn:vcl.builder:2929395:2929395:vcl/source/window/builder.cxx:462: DBG_UNHANDLED_EXCEPTION in VclBuilder::VclBuilder(vcl::Window*, const rtl::OUString&, const rtl::OUString&, const rtl::OString&, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame>&, bool, const NotebookBarAddonsItem*) > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebartextpanel.ui > warn:sfx.sidebar:2929395:2929395:sfx2/source/sidebar/SidebarController.cxx:976: Cannot create panel private:resource/toolpanel/SvxPanelFactory/TextPropertyPanel com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebartextpanel.ui > warn:vcl.builder:2929395:2929395:vcl/source/window/builder.cxx:462: DBG_UNHANDLED_EXCEPTION in VclBuilder::VclBuilder(vcl::Window*, const rtl::OUString&, const rtl::OUString&, const rtl::OString&, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame>&, bool, const NotebookBarAddonsItem*) > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebarparagraph.ui > warn:legacy.osl:2929395:2929395:vcl/source/window/window.cxx:269: Window ( 7Control()) with live children destroyed: 7VclVBox() > Window ( 7Control()) with live children destroyed: 7VclVBox() Change-Id: I89b6365bdabfea75e53a2bce7f8639061390e038 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90754 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 61d8d991a27c3bfe70e3b8d3b4ce4d8a41d18d2d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90644
2020-03-21fix CppunitTest_sw_accessible_relation_set dependencyLuboš Luňák
warn:sal.osl:4733:4733:sal/osl/unx/module.cxx:162: dlopen(/home/seli/build/suse/l1/instdir/program/libacclo.so, 1): /home/seli/build/suse/l1/instdir/program/libacclo.so: cannot open shared object file: No such file or directory warn:legacy.osl:4733:4733:toolkit/source/helper/accessibilityclient.cxx:183: AccessibilityClient::ensureInitialized: could not load the library, or not retrieve the needed symbol! Change-Id: I72ea338ae69ffabe2187f4725ec13deea9a2afd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90789 Tested-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 6bc2b598d6b748a130b84d4a7e07f3b3c34fe3e1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90810 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-21fix test dependenciesLuboš Luňák
I'm not sure if this is the right dependency, but this test is paired in Module_dbaccess.mk with CppunitTest_dbaccess_hsqldb_test and that one uses this too, and it makes the dependencies work. Change-Id: Ib7d1dff99ed5e6f91f11d6a583475323a3307ad6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90835 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 5ef77a5af1ffa8f83fa6d803494bc0afe3742375) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90817
2020-03-20make: map slowcheck to gbuild's build and slowcheckMiklos Vajna
This is meant to to fix the Jenkins Windows/macOS buildbots after they started to run 'make unitcheck slowcheck'. (cherry picked from commit 4054a30e2b2fa254dfb20718ce757ceb2f638fd5) Change-Id: I128448ca3a190969c0cc0f02d2c27bc0a373129b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90793 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-20tdf#130208 use TableCellBackgroundColor instead of BackgroundColorandreas kainz
Change-Id: I2f1d5fdf976f9e787d64098a091022182156e401 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90408 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 2a5dfda892ca444eca2a0fcba2b28b9c9fd2915e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90403 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-19Adapt o3tl::span to removal of std::span::cbegin et alStephan Bergmann
<https://cplusplus.github.io/LWG/issue3320> "span::cbegin/cend methods produce different results than std::[ranges::]cbegin/cend", as implemented now in <https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;a=commit; h=247f410b83797a1840573840cc2a539ef9d7f96b> "libstdc++: Remove std::span::cbegin and std::span::cend (LWG 3320)". Turns out we only used the removed member functions in o3tl/qa/test-span.cxx. Change-Id: I6c73797594b4e0e753a88840033d54961e271df5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89261 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 6fbfad6b00e8c35346ee59cd32a0d7ccc0d8c19c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90634 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-18tdf#131118 VML import: fix size of non-autosize shapes containing textMiklos Vajna
Regression from commit b92293b3943423324064a8513c2e114d18817179 (tdf#103983 VML import: handle <v:textbox style="mso-fit-shape-to-text:t">, 2020-01-20), the problem was that in case we disable autosize too late, then the size will be already set during adding text to the shape. Do it before adding text, this way adding text won't change the shape size, so it'll be correct at the end of the import. (cherry picked from commit 4ee7ee1c4a515479bc174543af4dbc400035c0ba) Change-Id: I9410fc695c3edfa5089d845864bf237e71c533c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90602 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-18Update git submodulesAndras Timar
* Update dictionaries from branch 'libreoffice-6-4' to 390a74603cd452dc35b34bc956927d519953bcab - tdf#130999 fix registration of Greek dictionary Change-Id: I7b85d588c67c9b05f3856d92544fb0a0348594ea Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/90626 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-18tdf#131069 always produce utf-8 from gettextCaolán McNamara
Change-Id: I311e647f08b4d541825e7790d971b98b5b5bfe40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90631 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-17tdf#128281 Increase a checkbox height in Windows installerRoman Kuznetsov
Change-Id: Ic0bc2af1dd565dc9c24a74de8900da771f052a95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90402 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit e6d008f131c7ca532a9e8410b424b3323d581978) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90404 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-17tdf#131337: fix range for "Surface angle" (tab "Shading" in "3D Effects")Julien Nabet
Should be to 90° max instead of 1000° Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=11d0c28601dc89c48e67a7b39ba82dd52e660334 author Caolán McNamara <caolanm@redhat.com> 2014-12-28 16:30:18 +0000 committer Caolán McNamara <caolanm@redhat.com> 2014-12-30 15:43:39 +0000 commit 11d0c28601dc89c48e67a7b39ba82dd52e660334 (patch) tree 75e0e9d83694637de1e3b95a25c66de911d381bc parent 04299dba24d04b08d54f4f5945d340d7abfa73e4 (diff) convert RID_SVXFLOAT_3D docking window to .ui This is an epic dialog with lots of moving parts Change-Id: I867723f65273bf46b0693910d88e11a9197384c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90397 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-17tdf#125520 create a persist correctly for OLEArmin Le Grand
If the D&D-Start described as in the task is an OLE object we need to create a Persist-object to copy the included EmbeddedObjectContainer Change-Id: Ib8b9677bbc3e6c5b3895abc55e6da5b0a96e33d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90263 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90336
2020-03-17Set Firebird creation option experimentalJulien Nabet
See: http://document-foundation-mail-archive.969070.n3.nabble.com/About-putting-Firebird-creation-option-experimental-tt4274028.html http://document-foundation-mail-archive.969070.n3.nabble.com/ESC-meeting-minutes-2020-02-20-tt4274082.html for rationale Change-Id: I73d1563575252ebbcfb764753294bceb29e9bf12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89167 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit dc3c6e64650f0347648598dae0fa67c296ad36f5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89132 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-17tdf#131076 allow 'return' in GtkComboBox to activate default widgetCaolán McNamara
typically ok and accept the dialog. alt+down is documented as the default menu-activate key binding, space will also work to popup the menu from a combobox. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89950 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7a078207fbfd71b33cb51c38b3886351fedcde8d) Change-Id: I7bec880670cc006b288996d6f59a88fe9a9fb8cc tdf#131223 let return deactive active popup Change-Id: Ib116a1eb047aa9f1a5ca7a2ec9333a793addd304 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90188 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0d81a613ef5af22253e51d9917c5d5c94d764456) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90381 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-17Resolves: tdf#126366 revert use of SfxDispatcher::LockCaolán McNamara
Revert "tdf#121607 defer other requests until password dialog is dismissed" This reverts commit 205aeffda1a29865576fb865f23dfb6761ebfab1 as far as I can see the original problem doesn't reappear anyway Change-Id: If5fd3383f3473662bc87a367fad2c1febe1c6a23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90388 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-17mysterious greyed out native toggle buttons when in foregroundCaolán McNamara
and flipping to normal mode when in background. Change-Id: I100efb651515b044d56a8c3838569cf717b37d51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90279 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-17tdf#130150 Improve clipping in PDF exportArmin.Le.Grand (CIB)
For more info and discusson please have a look at the task. It reverts the change from tdf#99680 which did a wrong paradigm change in how clip in Region(s) is defined and tries to fix the underlying error in a more correct way. This includes problems noted in tdf#44388 and tdf#113449. This is a decent improvement, but - due to dealing with numerical problems - not yet the whole healing. Still thinking about how to solve this for good. Adapted PdfExportTest::testTdf99680() and PdfExportTest::testTdf99680_2() as needed, empty clip regions are allowed again. Added comments, too. Had to change solvePolygonOperationAnd to work on ranges if both inputs *are* ranges. The AND-case is then completely solvable. Also increased geometry for transformations of clip geometries - may help later. Change-Id: I2370447597faa6efb81d58ee31c63654e304262e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89874 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 6dff631f8f4b964b48aadde52a1e1b8b04b9ba53) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89923 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-16tdf#126742 Don't change visible area while retrieving itSamuel Mehrbrodt
This leads to funny size changes in embedded calc docs Change-Id: I2c4a0fbebb782faae7508e7d61c8da9d440a5916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90247 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit c185263f45a556e6c695c766476e67fbd2ea3593) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90386 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-16Resolves: tdf#129985 OOXML import: do not force a fixed-locale number formatEike Rathke
... instead of system locale. Change-Id: Ie7b4c6a560468f142df6916f50bfda9daaf7c379 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90538 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 5b88a664b1ad2b5761a4672678845cc77be6cd4d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90399 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-16tdf#131291: Add UItestXisco Fauli
Change-Id: I65aede1899d2c509fd52f8db0657ec3a5791f681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90430 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90390
2020-03-12tdf#131185 Prevent unnecessary SwapIn calls.Gülşah Köse
When the http response is 404 or something like that we shouldn't retry the download embeded image constantly. This causes libreoffice to short freezes. Change-Id: I7381d04f12e9fbea961dd0e3333ea0d39aa93d14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90102 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90045 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-11update creditsChristian Lohmaier
Change-Id: I90fba19d96f0fce6ca0e63c83e6dd45087f81c0a (cherry picked from commit 1a3d18ecaabec6f7b8f0f615df2222a6687d2224)
2020-03-11tdf#130986 Chart OOXML export: fix number format of custom labelBalazs Varga
Export correct sourceLinked attribute in c:dLbls/c:dLbl/c:numFmt, as in c:dLbls/c:numFmt. Change-Id: I0e52720b3cb2c99550a779763f01ba12f762050d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89638 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89947 Tested-by: Jenkins
2020-03-11Resolves: tdf#130400 reserve ctrl+page_up and ctrl+page_down for notebooksCaolán McNamara
Change-Id: I627298cb844967eeb1e166720e3951be732a4dc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89016 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89481 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-11tdf#131184 Allow comparing text ranges in table with body textSamuel Mehrbrodt
Change-Id: I191d8778d362cd28474eea6d18bfe40044887e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90038 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-11Resolves: tdf#131248 a11y crash when closing SQL Edit QueryCaolán McNamara
Change-Id: I39db7b352dd460f46092a054bfa89f5acdda54c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90273 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-11Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-6-4' to 27997432892d8cb1f8f8226194d0a637851ad13d - update translations for 6.4.2 rc2 and force-fix errors using pocheck Change-Id: I0462e8a1db3c2d1df87ac6eaec555f91b4e680c1
2020-03-11tdf#131088 Automatic Control Focus not workingNoel Grandin
regression from commit a361231b1363d072d737e9b1d411b71aa9550d84 Date: Fri May 10 10:13:12 2019 +0200 fix wrong SET/QUERY flags passed to uno::Reference Change-Id: Id0dd46c3d40f8acab980147c4c7f64911bc30d22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90293 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 17c467a66d799bda88d6cdb84b7fecbbd7d1fdf5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90276
2020-03-11tdf#131146 Linked Calc: changes are lost in last edited cellSerge Krot
Change-Id: I768ccc1d98a0785806986a6ffc70de057991e08a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90009 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit a91e19e30833c2743c1c2ce010a2d0f06aad7706) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90039
2020-03-10sw: DOCX export: fix bookmark inside sdtDropDownMichael Stahl
Word refuses to open a document that has a w:bookmarkEnd inside w:sdtContent but with no text content following it. It turns out that the bookmark position is wrong anyway, it should end before the text according to Writer's model. It shouldn't make a difference whether the end is inside the sdtContent or preceding the SDT, so write the text content of the SDT from the EndField_Impl(). Another idea would be to move the writing of bookmarks in EndRun() before the StartField_Impl() but who knows what that would break. (regression from d55b26a093bdbced08985dbc7113190b52a8bc66) Change-Id: I476c0829814b061d80811cc6817923ee06013a26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90100 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 1f5af453b5994c9e8ccd0756882b98715c75114b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90030 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-10tdf#128880 sw btlr: fix SwFrame::GetPaintArea() for the row span caseMiklos Vajna
To be specific, this focuses on the case where a single cell has btlr direction, but the containing row does not, and there is a row span. The old code that took the logical right of the cell frame served two purposes, it seems to me: - in the rare case where the 1st row is wider then a subsequent row, we make sure that as the cell frame is expanded downwards, we're still inside the table polygon - in the tb-rl ("Japanese") case, the logical right maps to physical bottom, and this way the cell frame is OK to render not only into its own row frame, but can expand also downwards. Given that btlr maps left to bottom, this mechanism is broken there. Be consistent with the working tbrl case, so just expand towards the logical left in the btlr case. The rest of the changes just make sure that SwAttrHandler::FontChg() calls SwFont::SetVertical() with the correct bVertLayoutLRBT parameter, which instantly fixes the actual position of the text. (cherry picked from commit 74f0105a2c140d078932576b457a327f3d2490a6) Conflicts: sw/qa/core/layout/layout.cxx Change-Id: I9032e7c6de72cec704843f3aae3c7848e139ebfa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90251 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-10tdf#131208 Don't try to set cursor focus after style applyJim Raykowski
It seems after a style is applied, the outliner view pointer points to an OutlinerView that has been removed. This results in a crash when trying to access OutlinerView functions to set cursor focus to the document. Avoid this by checking if a style has just been applied. Change-Id: Idda11567506fcc60a830dce70b86e12e2079c7a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90198 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit b39c08773db9bea776001c6ccf043684c2dfe08d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90266 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10Delete google_breakpad::ExceptionHandler before calling _exit()Mike Kaganski
While debugging tdf#129712 on Windows, I saw this sequence: 1. nullptr was dereferenced (the reason for tdf#129712). 2. ExceptionHandler::HandleException was called (in workdir/UnpackedTarball/breakpad/src/client/windows/handler/exception_handler.cc). 3. It called ExceptionHandler::WriteMinidumpOnHandlerThread. 4. Minidump was created in ExceptionHandler::ExceptionHandlerThreadMain. 5. Document Recovery dialog was shown in Desktop::Exception (in desktop/source/app/app.cxx). 6. After closing dialog, _exit() was called in Desktop::Exception. 7. All threads except main were terminated. 8. Another access violation was thrown in the "minimal CRT cleanup". 9. ExceptionHandler::HandleException called again. 10. ExceptionHandler::WriteMinidumpOnHandlerThread hung on WaitForSingleObject because handler thread that should release the semaphore was terminated already at step 7. The process had to be killed manually. This change destroys the breakpad handler at the start of Desktop::Exception, which de-registers itself (on Windows it uses SetUnhandledExceptionFilter). Other than preventing the hang, the rationale also is that keeping the handler after first minidump creation is wrong: even if the second minidump creation succeeded, uploading it to crashdump server would give not the actual problem, but some unrelated stack. Change-Id: If12d0c7db519693f733b5ab3b8a288cef800a149 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86104 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 12b5892cf9c78dd917f2e50672cd250478e6c7d6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89861 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>