summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-09-03Parent reference should be const in VCL builder entry pointsMike Kaganski
Change-Id: I2331e19f5e23e0dde8edd22befc7287515adf37e Reviewed-on: https://gerrit.libreoffice.org/78536 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-03Resolves: tdf#126911 make structure box expandableCaolán McNamara
Change-Id: Iaf0676b4889dc643d468af758ca0be9b609618c3 Reviewed-on: https://gerrit.libreoffice.org/78537 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-09-03loplugin:constmethod in svxNoel Grandin
Change-Id: I6ae7c04479e3ea8ecd7535c33224a5e7095b64bb Reviewed-on: https://gerrit.libreoffice.org/78396 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-03Fix typosAndrea Gelmini
Change-Id: I71bacf86938af2b89a706c435c4f72a194ec8343 Reviewed-on: https://gerrit.libreoffice.org/78417 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-03Fix typosAndrea Gelmini
Change-Id: I7eacff7dd5bf1e8ae70d2bca0bc852b8a45eeeec Reviewed-on: https://gerrit.libreoffice.org/78428 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-03Resolves: tdf#126935 a11y for hosted EditEngineCaolán McNamara
move it to svx so we can reuse the a11y code in svx for EditEngines hosted in shapes to provide a11y for EditEngines hosted in a native widget Change-Id: I4068c413cdb8ddb0d0ef899774fbe9f65e1bdc60 Reviewed-on: https://gerrit.libreoffice.org/78407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-03tdf#39593 Drop OToolBoxWindowItem::isWindowItemArkadiy Illarionov
Replace with comphelper::getUnoTunnelImplementation. Also use isUnoTunnelId(). Change-Id: I1cf42a483a5c2c9734e4c1f8dd3ba76fd9c7f5e6 Reviewed-on: https://gerrit.libreoffice.org/78429 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-03Extract code to get GetCustomMakeWidget address into a separate functionMike Kaganski
... to simplify the logic Change-Id: I45a23f17e10d634aeb322ac5797adc175006f5eb Reviewed-on: https://gerrit.libreoffice.org/78424 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-02Fix platform-specific library nameStephan Bergmann
Change-Id: I3a626260d7e48daef7b6f78b814730849135b4e2 Reviewed-on: https://gerrit.libreoffice.org/78419 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-02assert on selecting text from end to start in shape with a11y enabledCaolán McNamara
Change-Id: I0a135236cf5e5f291b6289cc76228290a6f77e98 Reviewed-on: https://gerrit.libreoffice.org/78406 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-02Adapt CppunitTest_dbaccess_dialogs_test to .ui file removalStephan Bergmann
...in 0e944350e92810adfcf080ae1d98ad7bc4bd578d "[API CHANGE] remove MacroMigrationWizard" Change-Id: Id57a74b779b74125223f471fe067cb5f3b92987c Reviewed-on: https://gerrit.libreoffice.org/78416 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-02loplugin:constmethod in editengNoel Grandin
Change-Id: I07e22d880940ea6df928565942dac268f4b94fea Reviewed-on: https://gerrit.libreoffice.org/78399 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-02lok: Don't change mouse pointer when hovering over table bordersTamás Zolnai
Change-Id: If6cc3698e6e7229a01d3147d79a587ead65f9b5e Reviewed-on: https://gerrit.libreoffice.org/78411 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-09-02tdf#127258: Fix ViewEventHandlerWeakPtrWrapperStephan Bergmann
...which had been introduced with 042e30a3dc057aef4a02d95960e4dd4fb8d083ae "Avoid adding a function template declaration to namespace std" but without taking the ListenerOperations<std::weak_ptr<ListenerTargetT>> partial specialization (in slideshow/source/inc/listenercontainer.hxx) into account, so that commit had made some confused changes to the mpImpl->maViewHandlers.applyAll calls (that can now be reverted). Change-Id: Iaaafc560dfd34940f1708027808ab4f9b8db7764 Reviewed-on: https://gerrit.libreoffice.org/78405 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-02Add -latomic to the end of Linux C++ linker command linesStephan Bergmann
b11763dbaa0c7f427ea47abe9b98995cb49a8595 "link with -latomic on mips(el), armel, powerpc, m68k" had added -latomic to the linker command lines of just some Linux platforms (which apparently happened to actually require it). But there were three issues with that: * The -latomic came too early on the command line, so that it wasn't used to satisfy dependencies of .o files that came later. See the discussion at <https://gerrit.libreoffice.org/#/c/78319/> "set -Wl,--no-as-needed for -latomic". * There is presumably no need to include -latomic on C linker command lines. * <https://gcc.gnu.org/onlinedocs/gcc-7.3.0/libstdc++/manual/manual/using.html #manual.intro.using.flags> (matching our Linux libstdc++ 7.3.0 baseline as per README.md) states: "Linking to libatomic is required for some uses of ISO C++11 <atomic>." So we should better include -latomic on every Linux C++ linker command line that uses libstdc++. (This patch assumes that we always use libstdc++ on Linux.) Ideally we could rely on -latomic always being available with our baseline libstdc++ 7.3.0, but when using Red Hat Developer Toolset 7 that appears not to be the case, as reported by a Jenkins build for an older version of this change (see below), so use ATOMIC_LIB from the preceding commit <https://gerrit.libreoffice.org/#/c/78336/> "add -latomic configure check...". <https://ci.libreoffice.org/job/gerrit_linux_gcc_release/40298/console>: > [build LNK] Executable/unoapploader > /opt/rh/devtoolset-7/root/usr/libexec/gcc/x86_64-redhat-linux/7/ld: cannot find -latomic > collect2: error: ld returned 1 exit status > /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/solenv/gbuild/LinkTarget.mk:636: recipe for target '/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/LinkTarget/Executable/idxdict' failed This patch adds -latomic only on Linux. Similar changes can be made for other platforms if need be. Change-Id: I75df5410677f4c31c796d7ba85532bcdb47eb111 Reviewed-on: https://gerrit.libreoffice.org/78380 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-02add -latomic configure check...Rene Engelhard
...in preparation for <https://gerrit.libreoffice.org/#/c/78380/> "Add -latomic to the end of Linux C++ linker command lines" (copied from https://github.com/zelcash/zelcash/blob/master/build-aux/m4/l_atomic.m4) Change-Id: I8879a72d730cc08a72c2d8b132ff9f5d2efe7b9f Reviewed-on: https://gerrit.libreoffice.org/78336 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-02Related: tdf#126935 rearrange spell dialog for expected tab traversalCaolán McNamara
so tabbing through goes in visual left to right top to bottom direction Change-Id: I6ad13b7989464af805aa5ed8a080effe04b9b4c0 Reviewed-on: https://gerrit.libreoffice.org/78389 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-02we only need an OutputDevice here, not a WindowCaolán McNamara
Change-Id: I2ba8f61b8dc8570677f3a8f955e3a2cd9bfcd98c Reviewed-on: https://gerrit.libreoffice.org/78391 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-02Unnecessary to convert Locale to LanguageTag twiceEike Rathke
Change-Id: Ie2de1a8c5555ac1f8a46cacd052efc1a03e6f2ac Reviewed-on: https://gerrit.libreoffice.org/78395 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-09-02loplugin:constmethod in ooxNoel Grandin
Change-Id: Ie6c9c60288accf7096288aa67d091548e43687cd Reviewed-on: https://gerrit.libreoffice.org/78397 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-02configure.ac: Fix '--enable-kde5' compatibility switchMichael Weghorn
The 'kde5' VCL plugin was renamed to 'kf5' in commit d3c6ac6d0f23df56644008ccb6aa2c8fa37ab1b5 ("tdf#125922 rename kde5 to kf5 + plasma5). Fix the (temporary) compatibility switch, so that '--enable-kde5' actually enables the build of the 'kf5' VCL plugin and doesn't just set 'test_kf5' to 'yes' once again... Change-Id: I7871b5fc1dc36758a3e3d558da44ae24fd47de41 Reviewed-on: https://gerrit.libreoffice.org/78393 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-09-02tdf#55436 - Add SYMBOL_CHICAGO numbering scheme (for footnotes)Tim Bartlett
Includes adding SYMBOL_CHICAGO translations to .docx import/export filters Change-Id: I5212739d7d04ab400a3d2aa549cb7cfd8531a4b8 Reviewed-on: https://gerrit.libreoffice.org/78114 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-09-02Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Reword help page on set image background Change-Id: Iaf7ccb576a8881aa7b4eb42819a78b51b884ca4c Reviewed-on: https://gerrit.libreoffice.org/78376 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-09-02Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Reword sentence on save background image Change-Id: I381d8394b5c58851b5eaf59223a98994494dfb40 Reviewed-on: https://gerrit.libreoffice.org/78375 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-09-02SmartArt edit UI: add new nodeGrzegorz Araminowicz
First approach to adding new node. Currently it's possible only to add top-level node to the end of diagram. Change-Id: Icd9530ab2fb8987a1690ffc96c244cc845b72eba Reviewed-on: https://gerrit.libreoffice.org/78286 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-09-02Resolves: tdf#126042 measure text width with the bold font it will render withCaolán McNamara
Change-Id: I81cc0351e652c632bd85efa6dacb36be66fcfb3c Reviewed-on: https://gerrit.libreoffice.org/78385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-02Resolves: tdf#127198 assert on dialog from db wizardCaolán McNamara
Change-Id: Ibc431b4f27d1bb5c848122ef0430b13c6a9dc45b Reviewed-on: https://gerrit.libreoffice.org/78384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-02unused suppressionsCaolán McNamara
Change-Id: I81b5cd9174e195457a7f29b2010d355cf2971fa1 Reviewed-on: https://gerrit.libreoffice.org/78381 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-02avoid gtk 'widget not within a GtkWindow' warningCaolán McNamara
Change-Id: I6fcbb28b5dcb7c4787de3eb1c2932836822cccfa Reviewed-on: https://gerrit.libreoffice.org/78374 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-02drop unnecessary includesCaolán McNamara
Change-Id: I3e71a9eda34dd836c29af02f7b0adc8acccd1244 Reviewed-on: https://gerrit.libreoffice.org/78373 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-02weld cluster of database form wizardsCaolán McNamara
Change-Id: If40eec5ec00ad96088c0dda96c4733d2a1134f68 Reviewed-on: https://gerrit.libreoffice.org/78368 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-02tdf#124491 DOCX: import tracked changes of empty paragraphsLászló Németh
Formatting changes of empty paragraphs weren't imported. Change-Id: Ife7c83d52549563ab4c3a00a3daff4d8f4fa8386 Reviewed-on: https://gerrit.libreoffice.org/78233 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-09-01Fix typosAndrea Gelmini
Change-Id: I00d678ce942401fa3e53e5c0e159c747a4be6b0b Reviewed-on: https://gerrit.libreoffice.org/78367 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-01add explicit parent to forms wizardsCaolán McNamara
Change-Id: I2737a43e9c8129163699c922e556c92af566fa55 Reviewed-on: https://gerrit.libreoffice.org/78370 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-01loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I53194699cf82a1b8d69680da092a44c73a690e96 Reviewed-on: https://gerrit.libreoffice.org/78371 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-01loplugin:unusedfieldsNoel Grandin
Change-Id: I73e94fe2bcf6e206ae8f78380abf2a399aa6dc01 Reviewed-on: https://gerrit.libreoffice.org/78365 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-01Resolves: ofz#16898 Direct-leak in rtl_uString_ImplAllocCaolán McNamara
Change-Id: I7bc11108790f8d87396bad3a2c5c2280f8f7d59a Reviewed-on: https://gerrit.libreoffice.org/78369 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-01loplugin:unusedmethodsNoel Grandin
Change-Id: Ifaf3860a31fc151bb7052db1b87962b8aba27c37 Reviewed-on: https://gerrit.libreoffice.org/78366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-01Add icons to New Document desktop file actionsNicolas Fella
This allows KDE Plasma's start menu and task manager to display an icon together with the action Change-Id: I78a6912809d643046d143690785e30b052573d8a Reviewed-on: https://gerrit.libreoffice.org/78364 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-09-01Fix '..'Andrea Gelmini
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for ".." instead of "..." between words. It passed "make check" on Linux. Change-Id: I144d8061fca9f545c762941551e59dffdd3650e8 Reviewed-on: https://gerrit.libreoffice.org/78357 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-09-01Fix '..'Andrea Gelmini
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for lines ending with ".." instead of "..." It passed "make check" on Linux. Change-Id: I07fa7b2e30ba9ea17a1f9a5e21c57216ba958efe Reviewed-on: https://gerrit.libreoffice.org/78356 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-09-01Fix typosAndrea Gelmini
Change-Id: I425988a6d99f81574ddec832852873971a03e9e7 Reviewed-on: https://gerrit.libreoffice.org/78362 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-01Fix typoAndrea Gelmini
I guess this is in French. Change-Id: I2b68ecc41a08fb10ae0d237864fbbef3c8983461 Reviewed-on: https://gerrit.libreoffice.org/78363 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-01Correct typos in fr AutotextLaurent BP
Change-Id: I07672cffdb33dfa75e609277df721d4c71d88bc5 Reviewed-on: https://gerrit.libreoffice.org/78352 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-09-01makes RTFSprms::set clearerAdrien Ollier
Change-Id: Ic1aab40c8a4abdd73c616b2faaf95ef183fa2e38 Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/77556 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-01tdf#127240 Increase a height of checkbox's text in win installerRoman Kuznetsov
Change-Id: I0df5dc4cebb065c509df77b00f16597a28566345 Reviewed-on: https://gerrit.libreoffice.org/78355 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2019-09-01Simplify Sequence iterations in ioArkadiy Illarionov
Use comphelper::findValue and initializer lists. Change-Id: I4ebaf556a21b263e48b82a7290093eb8a832d9da Reviewed-on: https://gerrit.libreoffice.org/78351 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-08-31dbaccess: delete old paste autoincrement logicTamas Bunth
Change-Id: I6a4392c9e93842838022370fe6c54908adcc627b Reviewed-on: https://gerrit.libreoffice.org/78358 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-08-31tdf#127093, tdf#127092 Fix pasting autoincrementedTamas Bunth
Fix copy/paste functionality when trying to paste a table with auto incremental column in it. In that case we should let the DBMS handle the values in that column. Change-Id: Ia40a0056402ec540f469b94694629dd6db7d4e71 Reviewed-on: https://gerrit.libreoffice.org/78298 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-08-31Query MySQL schema name when pasting tableTamas Bunth
In case of a MySQL direct connection the current schema in use cannot be queried with the getUserName() method of the DatabaseMetadata interface, because the user name and the schema name can (and usually do) differ. Instead, we can always query for the current schema with the DATABASE() SQL function. Change-Id: Ibb026519e1a63e29c5a7c9b04ab64901faec0f85 Reviewed-on: https://gerrit.libreoffice.org/78297 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>