summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-06-17cppuhelper: fix use-after-free race in OWeakConnectionPointMichael Stahl
OWeakObject::m_pWeakConnectionPoint is returned from OWeakObject::queryAdapter(), and stored in OWeakRefListener::m_xWeakConnectionPoint. This is cleared in OWeakRefListener::dispose(), called from OWeakConnectionPoint::dispose(), called from OWeakObject::disposeWeakConnectionPoint(), but it can happen that another thread is in WeakReferenceHelper::get() and has copied m_xWeakConnectionPoint onto the stack before the OWeakObject is released and deleted, then calls OWeakConnectionPoint::queryAdapted() after it is released, accessing the dead m_pObject. Change-Id: I7782e6fb7e07f5a48cf7064115217376714ba8e8
2016-06-17Simplify OPropertyContainerHelper::registerPropertyNoMember's _pInitialValueStephan Bergmann
Change-Id: Ibfb27b3eded45e2646dada37ce3663f427985ae9
2016-06-17LOK: change type of view ids to uintptr_tMiklos Vajna
This fixes the following problem: - createView() = 1 - createView() = 2 - destroyView(1) and then view #2 was renumbered to 1. Instead expose the pointer address of the SfxViewShell as the ID, which is not changing in such a situation. Note that the SfxViewShell <-> ID mapping is an implementation detail of SfxLokHelper, and only pointers are converted to IDs, user-supplied IDs are never converted back to pointers. Change-Id: If79ef8b99ba391011b5d82b219ad13447d44cd5a Reviewed-on: https://gerrit.libreoffice.org/26423 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-17Resolves: tdf#90579 swap_single_to_multi_blocks seems brokenCaolán McNamara
when there is associated data in the src. Its copies those pointers into the block that will appear in the destination. Then can destroy the source block, which deletes the contents of those pointers, and then inserts the new block which has dangling pointers to the deleted data. https://gitlab.com/mdds/mdds/merge_requests/2 Change-Id: Id9614d95652c8032b03cb5748a284917043d8d21
2016-06-17add NETWORKDAYS_EXCEL2003 test caseZdeněk Crhonek
Change-Id: Ib56c08f916cdae74c54bc13d4ef7ced46a227520 Reviewed-on: https://gerrit.libreoffice.org/26384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-17add NETWORDAYS.INTL test caseZdeněk Crhonek
Change-Id: Ia78f9d29025e593dfa4202af67c95bdb5432d15c Reviewed-on: https://gerrit.libreoffice.org/26383 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-17tdf#100453 – bin/unpack-sources needs to be executableChristian Lohmaier
otherwise building from source-tarballs fails when it tries to extract fetched submodule tarballs Change-Id: I75bcd6821e244ca2a3375ec2916ee7c38ec9844e
2016-06-17cui: fix loplugin:passstuffbyref warningsMiklos Vajna
Change-Id: Ic756db3decb4b4bfde345bc0adc092907622287e
2016-06-17update mdds README for new homeCaolán McNamara
Change-Id: I2641abe8e049361d5eb92e19b9ed57b8e7209386
2016-06-17tdf#83830: Page Header Panel & Page Footer PanelSusobhan Ghosh
Change-Id: Ic927bd52949f1bd196bec0efd3d49f9bb2841bd6 Reviewed-on: https://gerrit.libreoffice.org/25781 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-17loplugin:refcountingStephan Bergmann
Change-Id: I39fbc89cffe25e85b8cd1f2e36f0a20c07e33497
2016-06-17loplugin:passstuffbyrefStephan Bergmann
Change-Id: I2fb13854a6da3f114dba386169e5aef7f741b922
2016-06-17tdf#91781 Move bookmark and cross-reference to root insert menuYousuf Philips
Change-Id: I06485c07e6c6fd3621fdfc99b7176107bb0ee999 Reviewed-on: https://gerrit.libreoffice.org/26418 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-06-17cppuhelper: WeakReference isn't thread-safeMichael Stahl
... but its documentation claims that it is, which is partially misleading, so fix both the documentation and the data race in WeakReferenceHelper::clear(). This actually crashed in clear() in the multi-threaded ZipPackage code on exporting the bugdoc from tdf#94212, presumably because clear() races against OWeakRefListener::dispose(). Change-Id: I85665c11b8157e90d15e8263758e24e66efeb86c
2016-06-17Reduce duplicate code and remove DBG_ASSERTRishabh Kumar
Change-Id: I2abf050bd6627cda993ff03bdf1d1867e209bda5 Reviewed-on: https://gerrit.libreoffice.org/26392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-17comphelper lok: remove the g_bViewCallback globalMiklos Vajna
Its purpose was to allow incrementally migrate all callers of SdrModel::libreOfficeKitCallback() to use SfxViewShell::libreOfficeKitViewCallback() (which allows notifying only the currently active or all views) instead. That is done by now, so it can go. Change-Id: I521bbbe5c638dfd844ebf025153459a37362d3c3 Reviewed-on: https://gerrit.libreoffice.org/26413 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-17Revert "fdo#38913: Prevent invalid parameter handler crashes"Stephan Bergmann
This reverts commit a82e532ce006c54b2740de74d1da5d11307da7c1. That hack should no longer be necessary now that the root cause for tdf#38913 has probably been found and fixed with b5876bfcb69a65c87d602bae687b3c0634c0a1e7 "passing a NULL pointer to fileno is not allowed". Conflicts: sal/osl/w32/salinit.cxx Change-Id: Id3a3d3163945acc9b5d5e74a8d357dfa2ce63f37 Reviewed-on: https://gerrit.libreoffice.org/26411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-17GSoC Table Styles, Add TableStyle propertiesJakub Trzebiatowski
Added properties for the following odf attributes: table:first-row-end-column table:first-row-start-column table:last-row-end-column table:last-row-start-column Change-Id: Iac140e00a3439740623649ea234504f08146aaf3 Reviewed-on: https://gerrit.libreoffice.org/26359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-17sw: speed up the navigatorMichael Stahl
The call to SwTextBoxHelper::findTextBoxes() in SwDoc::GetFlyNum() made this so unbelievably slow that in a dbgutil build opening the navigator on the bugdoc of tdf#94212 the UI freezes because getting all the fly frames takes longer than the 1 second timeout. Lets's not retrieve the flys one by one but instead all at once, which makes it usable again. Change-Id: Ic41c1648a82dcc3f758ae1b08bac6058f541f25e
2016-06-17loplugin:override: No more need to request dtor be marked 'virtual'Stephan Bergmann
...rather than 'override', cf. <https://gerrit.libreoffice.org/#/c/26347/> "loplugin:override: No more need for the "MSVC dtor override" workaround". Change-Id: Ib528938ed4be248117bb7114f34d4e9421bc3275
2016-06-17loplugin:overrideStephan Bergmann
Change-Id: I2c33f5f91f16c465cb329204529b76e1c6165535
2016-06-17Resolves: tdf#91365 use underlying numeric value if available [API CHANGE]Eike Rathke
... at least for setting the cell content. There are more places where the numeric value could be transported but all Data Pilot pivot stuff is based on text strings :-/ This appends a double Value member to com::sun::star::sheet::MemberResult Change-Id: Ia9e8ac47d0877bd4a59a69d5921ce4ea082e8a69
2016-06-17SaveToolbarController: back to using XStorableMaxim Monastirsky
See 747a0fdda2a7723c2f8a8a022b468bcf29c700e3 ("SaveToolbarController: Better support of readonly docs") for the background. However this doesn't work, because the save slot is disabled in other cases too, not just for r/o docs (e.g. locked UI during file save, or when cond. formatting window open in Calc). Until a better solution is found, at least make sure that the button is disabled, instead of going into the normal save mode, which doesn't work. Change-Id: If6e1b91b7c780fffac22cdb25c82bbd0a8520dc4
2016-06-17Add MS binary format validator support in test fixtureVasily Melenchuk
bffvalidator (Microsoft Office Binary File Format Validator) can now be used for verification of MS binary export tests Change-Id: Ibc65e64726a454cdd33946006b36427b9cc6fbd2 Reviewed-on: https://gerrit.libreoffice.org/26405 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-17tdf#79198 START CENTER: Close button doesn't reappear after being clickedAkshay Deep
Change-Id: I23e3aed71eec85e8b8f0aceac125809fd56be4d5 Reviewed-on: https://gerrit.libreoffice.org/26399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-17tdf#75369 Start Center: Non-installed applications aren't greyed outAkshay Deep
Change-Id: I52de5d7062bebe816e90ba39f559cd57dfc1067c Reviewed-on: https://gerrit.libreoffice.org/26406 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-17CppunitTest_sal_rtl_cipher: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: I94e79ae616d5cb9287e69544e283ce4d288a19ef Reviewed-on: https://gerrit.libreoffice.org/26401 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-17GSoC: Mapping legacy sax parser and XFastParserMohammed Abdul Azeem
This implements legacy parser interface using XFastParser, and unit test is also added. Change-Id: Ia2eb7d517d80a3f7ec0cf26ffa2e5747ad22b186 Reviewed-on: https://gerrit.libreoffice.org/26229 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-06-17Resolves: tdf#100421, don't crash on deleting particular tableCaolán McNamara
Change-Id: I52a4cf0732240aa26147313ae6a52c4fd8d8933c
2016-06-17Related: tdf#100421 crash in a11y on load of source odtCaolán McNamara
stldebug assert because end is before start and we can'g get to start from end in a std::set Change-Id: I0471220d3940e08b564f88841703a539aaf369d6
2016-06-17tdf#89329: use shared_ptr for pImpl in helpoptXisco Fauli
Change-Id: I9d3fa64405f70cfa942935eaae6cc520f172d70d Reviewed-on: https://gerrit.libreoffice.org/26281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-17Updated coreAdolfo Jayme Barrientos
Project: help fe617af636ad6b2a9b0b45d290a7d23604624733 tdf#100445 Fix name of style applied on Ctrl+0 Change-Id: I38bb9fb7c6d79f19b22391feab08ddaa18ccc29a
2016-06-17use assert, this time correctlyDavid Tardon
Change-Id: I845d9a8e49ca3ecbd7052875783519d18596dd52
2016-06-17Updated coreAdolfo Jayme Barrientos
Project: help 2b3576acb7553a05ff5935dcd346306be8488b3a Checkbox renamed to “Enable cursor” Change-Id: I0b73868c51d6d6637fa933f6ba37f897f1429f3b
2016-06-17use assertDavid Tardon
Change-Id: I12113ddefbba9120427aeed6d1246ff12c92188a
2016-06-17Resolves: tdf#96251 address wizard crash when run from start centerCaolán McNamara
Change-Id: I20de1fbdd3ca609a1818dfe8f81ba66b1cb15281
2016-06-17tdf#90577 Start Center: Clear List item should more accessibleAkshay Deep
Change-Id: Id7179ec32f2f9306fde98e1b7449861c809111f8 Reviewed-on: https://gerrit.libreoffice.org/26404 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-17Remove the "using namespace std" from filterMark Page
Change-Id: Ied355374a0bf662a9be70d83615446cbac9ee0b2 Reviewed-on: https://gerrit.libreoffice.org/26373 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-17GSoC Table Styles, TableStyle isInUse, isUserDefined, mutex fixesJakub Trzebiatowski
Also added: + SwXTextCellStyle::IsInUse() + check_styles.py SwXTextTableStyle::isUserDefined() tests Change-Id: I76cb166107f186098599c4a8da6f94f7c40cc545 Reviewed-on: https://gerrit.libreoffice.org/26366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-17add WEEKNUM test caseZdeněk Crhonek
Change-Id: Id9d104f7d1a2ed429444769d560bd4caf17694a4 Reviewed-on: https://gerrit.libreoffice.org/26387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-17tdf#100423 Template Manager: ctrl + A and del should work correctlyAkshay Deep
Change-Id: Ibe0326827e6dacb670bb948ca4f6e9797ab7edeb Reviewed-on: https://gerrit.libreoffice.org/26374 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-17More efficient OUString concatanation in LineNumberingDialogMuhammet Kara
According to https://goo.gl/jsVAwy: All the other alternatives, like explicit OUStringBuffer and repeated append() should be now worse in all possible aspects. In fact, this should result in just one OUString allocation, one data copy for anything and at most one length computation, so it should possibly beat even strcpy+strcat, while at the same time looking good. Change-Id: I23bf5b5a0b8d79b2d8995700eefc20ab3fb6f79c Reviewed-on: https://gerrit.libreoffice.org/26386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-17sw: fix crash on pasting from an already closed documentMiklos Vajna
As pointed out by <http://crashreport.libreoffice.org/stats/signature/%60anonymous%20namespace'::lcl_checkClassification%28SwDoc%20*,SwDoc%20*%29+0x0>. Thanks to Michael Stahl for figuring out the list of steps to reproduce this bug: 1) Create a new Writer document 2) Type some text 3) Select all 4) Copy it 5) Close the document 6) Create a second Writer document 7) Paste -> crash Change-Id: I8cfcad465803e37ec9d01d035428c5ca953adf14 Reviewed-on: https://gerrit.libreoffice.org/26380 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-17tdf#89329: use shared_ptr for pImpl in dynamicmenuoptionsXisco Fauli
Change-Id: I66bdeeee7f70e6ca16a39e8804aaf8a5f0d08205 Reviewed-on: https://gerrit.libreoffice.org/26327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-17Clean up uses of Any::getValue() in chart2Stephan Bergmann
Change-Id: I53224053ea05c715f5e359a4c68e1ae5efbfe792
2016-06-17convert DBG_ASSERT in xmloffNoel Grandin
Change-Id: I2f4bbbef451026fc34638e17fa29b6db2c14d850 Reviewed-on: https://gerrit.libreoffice.org/26191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-17convert DBG_ASSERT in vclNoel Grandin
Change-Id: I732fb1a789f90ca7a7f393cc41a6afe84fecf3d3 Reviewed-on: https://gerrit.libreoffice.org/26200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16Ensure updated accessible names in SwSortDlg ctorMuhammet Kara
Set accessible names after the conditional block because text of m_pColLbl may be changed Change-Id: I2902fd346384be2c9ffa471c71ad94cacede7d14 Reviewed-on: https://gerrit.libreoffice.org/26352 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-16Resolves: tdf#100327 gtk3 fpicker yes/no dialog modal troubleCaolán McNamara
not sure why we ever hid the file dialog when putting up the yes/no dialog. So lets just do the more apparently sensible thing on the gtk3 path and leave gtk2 alone. Probably fallout from using window groups Change-Id: I4d0e8fae9568b050b674cf6ef4d8c88e65dd2ca1
2016-06-16[GSoC] Member function to identify PatternRishabh Kumar
Change-Id: I72ca21204248bfe279445f01ab247f19ec958fb1 Reviewed-on: https://gerrit.libreoffice.org/26361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
generated by cgit (git 2.34.1) at 2025-02-03 00:05:32 +0000