summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-06-15vcl: outdevmap.hxx -> rendercontext/ImplMapRes.hxxChris Sherlock
Change-Id: I96e191999e43e1a4203d548eeacd386ed883cd8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115368 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-15Remove some unused includesMiklos Vajna
See tdf#42949 for motivation. Change-Id: I559eb3b41a5a0fdb37db6c45d73211ca223384fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117193 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-15Revert "tdf#142832: a blind fix - calculate rectangle size properly"Mike Kaganski
This reverts commit 57d122258437c0a14b303a8d961aa5e8f6f67f57. Reason for revert: As mentioned in https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getwindowrect, > In conformance with conventions for the RECT structure, the bottom- > right coordinates of the returned rectangle are exclusive. In other > words, the pixel at (right, bottom) lies immediately outside the > rectangle. So it was incorrect change. Change-Id: I2b29871a5d9b944ce2f9119edb2e87c53d9ae298 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117212 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-15Fewer array reference calls make the code more readable and more efficient.Todor Balabanov
Change-Id: I7416633a735078a4e0e857f050ea7bfaadba310c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117158 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2021-06-14Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 693c6bf5faf43f8ae9a0eb72ee9ae7244161b363 - Add SF services to the Help tree Change-Id: Ifbd98abbfde88ea293bd920cbcd0f12c8b399a91 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117131 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-14sw_core_accessibilitycheck: remove duplicated createDoc methodXisco Fauli
Change-Id: Icdd1cded776544b5d2f4b7c3335f235aca490726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117187 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-14sw_uiwriter: use createSwDocXisco Fauli
Change-Id: I0fbdf08400850c647e8af1dc5fc689f85cd02311 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117192 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-14Fix Exception from PutProperties in unotoolsJulien Nabet
Launch Impress, click on "Animation" icon and check/uncheck "Automatic Preview" checkbox (at bottom right) Close Impress and notice this twice: warn:unotools.config:9155:9155:unotools/source/config/configitem.cxx:487: Exception from PutProperties com.sun.star.lang.IllegalArgumentException message: configmgr inappropriate property value /home/julien/lo/libreoffice/configmgr/source/access.cxx:1497 ArgumentPosition: -1 Investigating a bit, I noticed: officecfg/registry/schema/org/openoffice/Office/Impress.xcs 673 <prop oor:name="Width" oor:type="xs:int" oor:nillable="false"> 680 <prop oor:name="Height" oor:type="xs:int" oor:nillable="false"> officecfg/registry/schema/org/openoffice/Office/Draw.xcs 429 <prop oor:name="Width" oor:type="xs:int" oor:nillable="false"> 436 <prop oor:name="Height" oor:type="xs:int" oor:nillable="false"> sd/source/ui/app/optsitem.cxx:479: "DefaultObjectSize/Width", sd/source/ui/app/optsitem.cxx:480: "DefaultObjectSize/Height", Change-Id: I608b882cdff03e464fdb9886d5ba28dd33bfe229 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117095 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-14sw_uiwriter4: Unify code and use createSwDoc everywhereXisco Fauli
While at it, use 'reload' instead of 'save' + 'loadURL' Change-Id: Ib8ecdade1384f7ab17cb85cedd5d5d563ae217db Change-Id: Id51ea2dd0d2078d3fc114b6af90c3aa092542215 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117186 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-14tdf#142832: a blind fix - calculate rectangle size properlyMike Kaganski
The size was calculated wrong - it needed a "+1". But a rectangle constructor taking L, T, R, and B is actually simpler. Change-Id: I4152f9b43f0ae8f1829038645fcf83bae156c618 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117129 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-14we don't put images into these checkboxes anymoreCaolán McNamara
Change-Id: I9bf0ba8dabdd6bbff2a88191f87452a213b39178 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117182 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14remove unexplained caps_lock_warning/shadow_type ComboBox Entry propertiesCaolán McNamara
Change-Id: Id1b0ff8845c03d95651aece905459609edfa090b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117181 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14gtk4: create separators on menu import by appending a new sectionCaolán McNamara
where we have established that we always have a section in a menu to close when opening a new one Change-Id: I8af90dd89281dd0f10bcec5665d96412108cb5d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14gtk4: supporting hiding menu items by moving actions out of actiongroupCaolán McNamara
and using hidden-when of action-missing and keep the hidden items in a different actiongroup Change-Id: Idaa4f1762c4df2700827fd45527027cc48415548 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117178 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14gtk4: add hidden-when of action-missing to menu itemsCaolán McNamara
Change-Id: I054f3573c8a251c605ab1f3a426f6a905a908851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117177 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14gtk4: connect to underlying ToggleButton "toggle" of MenuButtonCaolán McNamara
e.g. writer, tools, autotext, autotext menubutton Change-Id: Ie29078eee4daff032421f8838ed2215101eb21e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117171 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14gtk4: reenable a cluster of working dialogsCaolán McNamara
Change-Id: I11c86ab60354259c8dc98c974d313efe8f8d5acc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117170 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14remove double-buffered propertiesCaolán McNamara
these are all fat fingered in somehow or another Change-Id: I0864a5622a244d5e60b368ddc425fc5a9b019060 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117176 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 2f5c748e452e2eeb45a71bc7d8b42e7a50ced70f - tdf#136435 Update Outline Folding commmand name Change Ooutline Content Visibility to Outline Folding Change-Id: I89a9223466d1091386e78218b61a248447099791 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117185 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-14sw_uiwriter2: Unify code and use createSwDoc everywhereXisco Fauli
Change-Id: Idde2bc4141f33f08ba94cc7498b107e4028f29a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117136 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-14Use FontList::GetFirstFontMetric instead of custom iteration codeMike Kaganski
Besides code deduplication, this takes care of case-insensitive search. Also fall back to a default font in case of no match in doc_renderFont*. Change-Id: Ica45ca10c374cf6581ba2f6b60563d6a1447232a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117121 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-14global-buffer-overflowStephan Bergmann
...down in svl::detail::CountRanges during e.g. CppunitTest_sd_tiledrendering, after 8aaa28ed43978a9a4a20d62368410a57ec05c23f "Assert on valid order of which ids in ranges on SfxItemSet creation" and 90cb57eb53e28ecb983001bf8f018577abb6d145 "Workaround internal compiler error on tb77" Change-Id: I8ff49384a86676a97ec876ef08426b978e39f6d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117168 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-14Update git submodulesChristian Lohmaier
* Update helpcontent2 from branch 'master' to 6b43e4b646206385e20c9d2c6d7a0d80be54d0ad - remove duplicate makefile line erroneously introduced with 9fffc3e breaks the help packaging on windows when creating the msi packages Change-Id: Ie3c54b4a2ee2cc1168af584c82aabac804f0fee5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117175 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-06-14Elide trivial TypeDescriptor_Init_Impl::getMutexStephan Bergmann
...after 859978445daeb848d033f64736709503ec44a7bb "flatten TypeDescriptor_Init_Impl data-structure" Change-Id: I6a7484dbbb93e7097edfb01db4f41d37fc4dc4b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-14Resolves: tdf#142767 cannot use itemid of 0 in ValueSetsCaolán McNamara
Change-Id: I2c2b655b512e4e7869fe3784f1b073ecdbd0dac9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117166 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14stack-use-after-scopeStephan Bergmann
(Graphic::GetGfxLink returns a temporary GfxLink object---whose lifetime thus ends at the end of the full expression---and GfxLink::getDataContainer returns a reference into that temporary object---which thus became dangling at the end of the full expression.) Change-Id: I1b84088a74c8c9efb5502f3b3917252858c01557 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117159 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-14tdf#142393 crash on filter by color dropdownlist (gen)Noel Grandin
the frame/window can become disposed during the early stages of this method Change-Id: I974cbeefa75a3b5274e397a6da70db8b7cf73528 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117157 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 910495baeaf7e845102bc896dc4848f750384244 - Fix link between Help pages Change-Id: Ib2c75038c3eb06e9643821705252fe162d95badd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117167 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-14Only look for semicolon if colon is foundMike Kaganski
Change-Id: Iddc7dc11fe6633b6e7134c5b2e20fc522d0fc0cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117120 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-14Revert "no need to init this on-demand"Noel Grandin
This reverts commit c71520d7e7d8e9c669411d6a1beb788e1cba43a1. Reason for revert: to fix AddressSanitizer: initialization-order-fiasco Change-Id: I637dfdca4fc51415000f31e658d79a4ec8c17677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117117 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-14We only support ICU version 4.6 or newer, so drop these checksMike Kaganski
The minimal ICU version check is in configure.ac. Change-Id: Ib6480cd3290dabb45d87c6dcbcc9b5513d172e21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117119 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-14Adapt compilerplugins to LLVM 13 APSInt::toString changeStephan Bergmann
<https://github.com/llvm/llvm-project/commit/61cdaf66fe22be2b5942ddee4f46a998b4f3ee29> "[ADT] Remove APInt/APSInt toString() std::string variants". TODO: While most uses of compat::toString should be harmless performance-wise, as they are either in error reporting code or in plugins that are not run by default, some calls like the one in compilerplugins/clang/staticconstfield.cxx might benefit from moving them away from using std::string. Change-Id: Icfac7d6d4a0a4a4edeb5c8bdcdbc13b73e20a5e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117152 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-14Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 0f05f0f82791941177326fdc3867595f1bf82039 - tdf#132643 Translate German section IDs Change-Id: I068f2ae0cb5507c1e324df6d02d49f05269db508 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117087 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-14Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 0d763a3b6f9f9f2c665901143f7bc66ea9f8ed34 - tdf#132643 Translate German section IDs Change-Id: I652383b613ae36d29ecbc2ebe72d14a7a4ba6541 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117093 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-14Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 117eb798aa2b07b2c89714fcdcda65af1c96aca9 - tdf#132643 Translate German section IDs Change-Id: Ieb84ed0f835b11102e9519cbe348244ef2a89a5a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117091 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-14Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to eccd279e155c167293ae87b098fa1fef0623fb5d - tdf#132643 Translate German section IDs Change-Id: I318584f815048b10c244cd637e741a76d1c37f54 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117092 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-14Add ClipRegion cppunit test to vclpanoskorovesis
The test creates multiple ClipRegions with different shapes and tests their attributes. Makefile was edited to support basegfx::B2DPolyPolygon Change-Id: Iabdf744e1749627b2bc4cbc0c8e933b38552e785 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116959 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-14Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 3fe720f7bf761debfe798510728661b4eccfe150 - tdf#132643 Translate German section IDs Change-Id: I369080b47e506a890d2a750606cc9c3f95139938 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117090 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-14Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to bef511309c6bc73660737a5efbe95480f0e70de1 - tdf#132643 Translate German section IDs Change-Id: I69149458178c9f99328a5414ec119664c4f0ac24 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117089 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-14Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 015d40f2bba6e8cd417c6e9a8c3aff0fab25d2f0 - tdf#132643 Translate German section IDs Improve earlier translations. Change-Id: I79749cb0aaf0c352c9b493d65558e22b27463a50 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117088 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-14Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to f6ae0a84932e5a73ad576fc54a288ec29fb4cf17 - tdf#132643 Translate German section IDs Change-Id: Ifec93507b6ecce1ffe18daaa5edf0ab0d9e598ff Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117086 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-14tdf#59323: ooxml import: hasNonInheritedShapePropertiesSarper Akdemir
Introduces hasNonInheritedShapeProperties helper to PPTShape. If the shape has something imported from it's spPr tag mbHasNoninheritedShapeProperties set to true. Change-Id: I0529f1def8d2c32d5bf06172ce44facdde92893c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117003 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-14sw XHTML/reqif export, OLE data for transparent images: avoid black backgroundMiklos Vajna
Once a semi-transparent images is exported to reqif in OLE mode, the native data is 24bit BMP. This needs some solid color as a background for the transparent pixels. The OLE presentation data had white, the OLE native data had black, so this was inconsistent. Fix the problem by going with white for the native data as well. Change-Id: I1b5e9ed37369b541425cfcd7f690e1b0bba97ddc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117144 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-14sw: prefix members of HTMLAttrContext_SaveDoc, SvxCSS1Parser, ...Miklos Vajna
... SwHTMLImageWatcher and SwWriteTableCell See tdf#94879 for motivation. Change-Id: Ib5810ac4de8e8f71410d6800e08755f38d80ee8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117108 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-14enforce RadioButton active within group consistencyCaolán McNamara
make group leader (the one without a group set) always active and make the group followers always not active Change-Id: I8a9ec45e93bf0786ab2895278521027b428c8403 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117143 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14only one of the radiobuttons in a group should be activeCaolán McNamara
Change-Id: I0475bdd0633b54a644e205628577fac18a3af974 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117142 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14if active is set group shouldn't be setCaolán McNamara
Change-Id: I26db5a96f176df7bd2ef6ef83c40150856845383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117141 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14group leader should be activeCaolán McNamara
Change-Id: I79cc2032c8641288ec6def4aaee32cb67e2da915 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117140 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14set the active button as group leaderCaolán McNamara
Change-Id: Ia3c99d03a9affec493e445bc7edf83be4d333677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117139 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14move comment to the line above the referenced lineCaolán McNamara
so pretty-printing doesn't afterwards change this file Change-Id: Id581d837013973045a0984484deea22a27db09a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117138 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>