summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-11-21tdf#123936 Formatting files in module canvas with clang-formatPhilipp Hofer
Change-Id: Ifcdecb0a60f5a4b09acc83ed38b6d1ec46765ba6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105649 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2020-11-21Avoid unused parameter 'pImpl'Tor Lillqvist
Change-Id: I8dd30ed3ffffa0e5340b32ce4399dd05cc57e2b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105962 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106258 Tested-by: Tor Lillqvist <tml@collabora.com>
2020-11-21Tentative fix for crash in the iOS appTor Lillqvist
See https://github.com/CollaboraOnline/online/issues/403 . It seems that perhaps we can just bypass the whole ImplHandlePaintHdl handler function on iOS. Not sure whether this has any unintended side-effects. Testing will show. (Sure, if this is the right fix, it would make more sense to not create that idle paint thing at all. Feel free.) As discussed in the issue, there is a problem on Linux, too, that might have the same root cause, that can be reproduced in a simple "make run" scenario. It is possible that to fix that, the ImplHandlePaintHdl function should simply return right away if comphelper::LibreOfficeKit::isActive() is true. (And if that is done, the #ifndef added here can be dropped.) But I am even less convinced that such a change doesn't have any ill side-effects, and the symptom is perhaps less serious than on iOS, so I will leave that to others to investigate, for now. Change-Id: Ie4c1c70c65746961fa0730cae348ecc9bcdccf1d Signed-off-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104918 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106257
2020-11-21callnk: Replace needless SwClientNotifyCall with CallSwClientNotifyBjoern Michaelsen
Change-Id: Ie34f2b227e5986c1fc72c3d0ba84dae98b51b4c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106081 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-21Colibre icon theme css support for connectorsandreas kainz
Change-Id: I4339088f3250305cd85266fcb214f0d2d64657ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106296 Tested-by: Andreas Kainz <kainz.a@gmail.com> Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-21Colibre icon theme css support for shapesandreas kainz
Change-Id: Ibe00c677ee1e00862ccd74b48058c9c7b1661b46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106276 Tested-by: Andreas Kainz <kainz.a@gmail.com> Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-21Changes to the color classdante
Before colors could be only converted to string rrggbb. Now also supports RRGGBB. It can also be converted back into a color. Change-Id: Ifb89d554b434c243c4f0956ee680ec23de823339 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106224 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-21fastparser in XMLEventsImportContextNoel Grandin
Change-Id: Ifeeb2220ec6dfe6ec91f238137796d7d9e517465 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106261 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-21tdf#138210 check if CustomShapeGeometry exist first.Mark Hung
CustomShapeGeometry does not exist for a text frame. Getting the property throws an Exception and cause a general IO error. Change-Id: I0e31780292d45211bfd1250d0d359c72def50583 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105834 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2020-11-21check-missing-unittests: add drawingmlXisco Fauli
Change-Id: If469d6400fc04c816e4748cbea65014a284eeb93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106272 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-21tdf#127811: chart2_import: Add unittestXisco Fauli
Change-Id: I071192dbb19c1c5851fb81f67f514ff003bd5c64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106259 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-20Colibre icons remove wrong iconandreas kainz
Change-Id: I9f94868e81a78a7dbae387d2c2858cdcb8d0824f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106273 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-20tdf#137684 sw ChangesInMargin: fix Undo of charactersLászló Németh
Undo of tracked deletions in the same position was reversed to avoid changing the ranges of the remaining hidden redlines. Now the ranges are corrected after the Undo (at least for the multiple characters deleted by pressing Delete). Clean-up of commit fe1fc9615511994ac128e52f9ad1cda4e86188f5 (tdf#137684 sw ChangesInMargin: fix crash on Undo of characters). Change-Id: If10bba5232d7b5084a2770efd9df229ae7509eb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106266 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-20tdf#137185 sw: move shape text on adding textboxAttila Bakos (NISZ)
The original text of the shape is moved to the new (text frame of the) text box instead of overlapping the text content added later. Change-Id: I2ad8865cdbe3c424c70985737ecda3ac9315cabc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104942 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-20Colibre icon theme css supportandreas kainz
Change-Id: If973e8e4511fd538ccc8da0a97098f45572e2407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106262 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-20Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to a3d7af3041f516c5185e103b62ad7093ab93cd77 - Refactor register-true definition and usage Remove excess of embeds, notable embeds inside a paragraph. Change-Id: Id0424ddae929b43127ad5fdeb4f573114f903fe5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106294 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-20move RadioButton to be toolkit onlyCaolán McNamara
Change-Id: Ie548ad3c471745297242a390fd2e500fa699de19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105836 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-20weld TabBarCaolán McNamara
Change-Id: I698f4dfc64bfa9bc4896111757616b4051b10293 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105797 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-20If we grab focus to a GtkToolbar then focus a GtkToolbarItem childCaolán McNamara
and consider focus in a GtkToolbar child as focus the GtkToolbar has focus Change-Id: Id3299dd9246da22b21b3e1a347faff8bc867c438 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106270 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-20check expander label for focus and grab focus to that labelCaolán McNamara
Change-Id: I91f3b012605416afd53e5d445ec10d683e8c1641 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106269 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-20GtkWindow case is similar to GtkPopover caseCaolán McNamara
Change-Id: Ie7417efd4113851615ee1c17a1297017a49a992d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106268 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-20SvStream::{Tell,TellEnd,remainingSize} all return sal_uInt64Stephan Bergmann
...so use that type where appropriate here Change-Id: I3e419457bc04b5908128bad04eb16c72052d2ebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106267 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-20fastparser in XMLEnhancedCustomShapeContextNoel Grandin
Change-Id: Id5f6466fd62e15b354b2dc11a0dc610cbfb75c27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106250 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-20fastparser in SdXMLLayerContextNoel Grandin
Change-Id: I1912d8d5a5f3ea6865d7425be8edb4f24b27e61f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-20fastparser in SdXMLLayerContextNoel Grandin
Change-Id: I807c9028fa197079da79270f8d7ad9339d7bedf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106228 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-20fastparser in SdXMLEventsContextNoel Grandin
Change-Id: I7c9a43c0323c1f278f329c51f14d9c273d334741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106227 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-20tdf#41845 sc: delete row/column with validation circlesTibor Nagy
Red validation circles around the cells were left after deleting their rows or columns, showing invalid data on the next valid or not-validated cells. Co-authored-by: Attila Szűcs (NISZ) Change-Id: I0dcef9225696b76eda78f0ee8831a83c20f53b0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105527 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-20sc: Add unittest to check size of commentsXisco Fauli
Change-Id: I267f85a2d3394e4b97e294c25cd7a16e28bf8b7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106223 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-20Remove unused installation variable GNOME_MIME_THEMEChris Mayo
Not used since: cf9994a4de40 ("do not conflict with GNOME MIME icons (fdo#36551)", 2011-05-06) Change-Id: Ie172bc0814a7de661c16891a2a87caba6c10f632 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105959 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-11-20lok: minor cleanup of ViewCallback in tiledrendering testsAshod Nakashian
Change-Id: I39b964a7aa7d181083a153283f38c1a5bc64de58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99973 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106222 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-20sfx2: lok: refactor notifications and const correctnessAshod Nakashian
This reduces the stringification and reuses the notificaiton helpers to reduce code duplication. Change-Id: Icf9f9c50f3eeee61a0ded741d39fed37cfcc8da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99972 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106221 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-20tdf#127086 PPT export: fix lost bitmap fill for OOXML custom shapesMiklos Vajna
PPT can't store an OOXML custom shape with fill bitmap, PowerPoint generates a fallback bitmap when saving to PPT. We used to keep the bitmap and loose the custom shape geometry, but that was changed with commit f4ba484183a1e7b9824f10580d633466c266828f (ooxml import: supprt cropping to shape, 2019-05-13). Fix the regression by going back to keeping the bitmap, a full fallback bitmap (ala PowerPoint), would be more work, taking e.g. blurry shadows (changing the shape position and size) into account. Change-Id: I7192f912077f2de026573855dbebbdf576e39ebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106219 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-11-20fastparser in SdXMLEventContextNoel Grandin
Change-Id: I52eb0ef77c54386a9774f746caba4b05785937aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-20Lengths passed into the SvxMSDffManager::Get*Data functions are all sal_uInt32Stephan Bergmann
(i.e., rLength obtained from SvxMSDffManager::ReadCommonRecordHeader) Change-Id: I04b51cb7e6cb771d89d07a86c00ee9fdaa72aaa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106176 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-20tools::Polygon::Clip() is broken with bezier curves (tdf#137068)Luboš Luňák
It preserves the points, but not the flags. Work this around by temporarily converting to B2DPolygon, where it works. Change-Id: I120264fbc4c7c508386f23a06435891199565aae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106188 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-20Adapt ScfProgressBar to SfxProgress::SetState taking sal_uInt32Stephan Bergmann
...since 5a6ab81651a98dd726ab7d40101dc81f62895fd4 "tdf#75280 Cleaning up of sal_uIntPtr usage #2". mnSysProgressScale had been introduced with 2a7add76241d8a3de05e3d26689a2d16d8b92913 "INTEGRATION: CWS dr20", which mentions "2004/06/17 14:58:21 dr 1.3.320.2: #i27407# handle limit of SfxProgress (ULONG_MAX/100)" though the referenced <https://bz.apache.org/ooo/show_bug.cgi?id=27407> "Save default row format to decrease Excel file size" does not appear to directly mention any reason for this particular change. However, prior to dbdc29e499abf125b6d6f66de668bc60c88fe599 "INTEGRATION: CWS toolbars2" SfxProgress::SetState did contain code that multiplied the passed-in value (back then of type ULONG) by 100, so it appears mnSysProgressScale was meant to mitigate that. So even if the original motivation for mnSysProgressScale is gone, repurpose it to address the mismatch between std::size_t (as meanwhile used throughout ScfProgressBar) and sal_uInt32 (as meanwhile used throughout SfxProgress). Change-Id: I1448bcd7521c87079bc4e9afc5f2d9951fc67aee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106216 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-20Colibre icon theme css support update shapesandreas kainz
Change-Id: Ib145303b4e455e029d281618be6b19a26f042ae0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106191 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-20tdf#113163: sd_import: Add unittestXisco Fauli
Change-Id: Ib1e6c003fbebf83e601e611e5eb23b8ee0cfd8a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106163 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2020-11-20tdf#138108 terminate on uncaught exception in a11y callbackCaolán McNamara
#1 0x00007ffff5d3fafe in accessibility::AccessibleContextBase::ThrowIfDisposed() (this=0x85de440) at editeng/source/accessibility/AccessibleContextBase.cxx:513 #2 0x00007ffff5d3fbee in accessibility::AccessibleContextBase::getAccessibleParent() (this=0x85de440) at editeng/source/accessibility/AccessibleContextBase.cxx:203 #3 0x00007fff999cad24 in SwAccessibleMap::DoInvalidateShapeSelection(bool) (this=0x687e610, bInvalidateFocusMode=false) at sw/source/core/access/accmap.cxx:1647 #4 0x00007fff999cc5a5 in SwAccessibleMap::InvalidateShapeSelection() (this=0x687e610) at sw/source/core/access/accmap.cxx:1152 #5 0x00007fff999d78b0 in SwAccessibleMap::InvalidateCursorPosition(SwFrame const*) (this=0x687e610, pFrame=0x5a3faa0) at sw/source/core/access/accmap.cxx:2744 #6 0x00007fff9aae5c32 in SwViewShellImp::InvalidateAccessibleCursorPosition(SwFrame const*) (this=0x6594330, pFrame=0x5a3faa0) at sw/source/core/view/viewimp.cxx:345 #7 0x00007fff99b01fcd in SwCursorShell::UpdateCursor(unsigned short, bool) (this=0x6594840, eFlags=7, bIdleEnd=false) at sw/source/core/crsr/crsrsh.cxx:2020 #8 0x00007fff99b02db4 in SwCursorShell::EndAction(bool, bool) (this=0x6594840, bIdleEnd=false, DoSetPosX=false) at sw/source/core/crsr/crsrsh.cxx:279 #9 0x00007fff9a2249b2 in SwFEShell::SelectObj(Point const&, unsigned char, SdrObject*) (this=0x6594840, rPt=Point = {...}, nFlag=0 '\000', pObj=0x0) at sw/source/core/frmedt/feshview.cxx:323 #10 0x00007fff9b30eacb in SwWrtShell::UnSelectFrame() (this=0x6594840) at sw/source/uibase/wrtsh/select.cxx:326 Change-Id: I122d087b67c3615afb0c34aa714bc1066946c8c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106190 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-20Clarify that SvxIconChoiceCtrl_Impl::GetPredecessorGrid returns GridIdStephan Bergmann
Change-Id: Iddd781b1acfb3d0fd8352cb50566fbebea4b3024 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106217 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-20Replace matrix translate with object MoveRegina Henschel
TR*BaseGeometry is faulty for SdrMeasureObj, fixing these methods is a larger effort and Move is simpler anyway. So I replace the translation using matrices with the Move methods for objects. Backup and restore of the geometry values in state HiddenAsZero is now done with SdrObjGeoData. That is known to work from use in Undo methods. Change-Id: Ic32e8dbc5ae5f1a2f80e428448abc4b4a530b76b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106189 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-11-20Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 15e0e4742d13a76837daf5dd666b7d57b4651a92 - Resolves: tdf#73398 and tdf#107192 help for printing range of pages ( swriter/guide/print_selection ) new guide page for how to print page ranges and selections ( shared/01/01130000.html ) ( File > Print ) + add <embed> for new page under Text Documents * update to <h1>,<h2> - comment out "More Options" control, which was removed with tdf#137506 ( source/auxiliary/swriter.tree ) + add as <topic> under Printing Change-Id: I68c97522facddfb78c81ee845e5385b3eb236e8c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106133 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2020-11-20Remove unused defineGabor Kelemen
Last use of this was removed in 2017 with: commit 832c1f16ddbdc626c6ae11900038e1a88f94b8e4 sw: remove temporary debug code in txttab that no longer builds anyway Change-Id: I25cc60e3e31badc91b208c24acc8308e6ba7f04c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106181 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-20pdfium: add a signature wrapper classMiklos Vajna
It just hides the underlying FPDF_SIGNATURE, no real member functions yet. Change-Id: I37d27c26d6f05b1f8c697a5afe682c795e5d4d1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106184 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-20ScrollBar::GetThumbPos returns tools::LongStephan Bergmann
Change-Id: I493e241e590325306a59fda89a30f1c97410c373 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106180 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-20This presumably wants to be Size(-1, -1)Stephan Bergmann
The code had been introduced with bd837fcbae7662bd127cb214f1497e4bf750cab0 "#92085# GetRulerState(): setting of SID_RULER_LR_MIN_MAX corrected" (where the referenced bug is apparently from the lost Sun-internal bug tracker), at a time when Size was presumably based on signed long, so ULONG_MAX presumably already effectively meant -1 back then. I don't understand what this code does, but when using a Size(std::numeric_limits<::tools::Long>::max(), std::numeric_limits<::tools::Long>::max()) instead, in a 64-bit Linux UBSan build I got > include/tools/gen.hxx:527:37: runtime error: signed integer overflow: 11767 + 9223372036854775806 cannot be represented in type 'long' > #0 in tools::Rectangle::Rectangle(Point const&, Size const&) at include/tools/gen.hxx:527:37 > #1 in sd::DrawViewShell::GetRulerState(SfxItemSet&) at sd/source/ui/view/drviews3.cxx:915:28 > #2 in SfxStubGraphicViewShellGetRulerState(SfxShell*, SfxItemSet&) at workdir/SdiTarget/sd/sdi/sdgslots.hxx:1540:1 > #3 in SfxShell::CallState(void (*)(SfxShell*, SfxItemSet&), SfxItemSet&) at include/sfx2/shell.hxx:199:35 > #4 in SfxDispatcher::FillState_(SfxSlotServer const&, SfxItemSet&, SfxSlot const*) at sfx2/source/control/dispatch.cxx:1657:14 > #5 in SfxBindings::Update_Impl(SfxStateCache&) at sfx2/source/control/bindings.cxx:260:22 > #6 in SfxBindings::NextJob_Impl(Timer const*) at sfx2/source/control/bindings.cxx:1274:17 > #7 in SfxBindings::NextJob(Timer*) at sfx2/source/control/bindings.cxx:1219:5 > #8 in SfxBindings::LinkStubNextJob(void*, Timer*) at sfx2/source/control/bindings.cxx:1217:1 > #9 in Link<Timer*, void>::Call(Timer*) const at include/tools/link.hxx:111:45 > #10 in Timer::Invoke() at vcl/source/app/timer.cxx:75:21 > #11 in Scheduler::ProcessTaskScheduling() at vcl/source/app/scheduler.cxx:486:20 > #12 in Scheduler::CallbackTaskScheduling() at vcl/source/app/scheduler.cxx:288:5 > #13 in SalTimer::CallCallback() at vcl/inc/saltimer.hxx:54:13 when creating a rectangle in Draw and clicking around in it. Whereas with Size(-1, -1) things appear to work fine. Change-Id: I7368b510113a34fec5c1cabfc35a369cac2fcda1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106187 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-20Use signed tools::Long return type for calcDistSquareStephan Bergmann
...for consistency with its internal workings of computing a value from other tools::Long values, even if the result can never be negative. (And where the additional bit for the unsigned type's magnitude probably doesn't make a difference here.) Change-Id: I1c6bcd2b8bdb70b9cd553758246af776b28500fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106178 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-20simplify CreateTableContextNoel
Change-Id: I1700d17d6f3aa29fcc4a1ea33d8d797e67c301d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106168 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-20fix tdf#138335 guard sidebar uno methods with SolarMutexThorsten Behrens
Wasn't threadsafe before; using vcl/gui code, so we need the SolarMutex. Change-Id: I3d4407f095837d03ad492fcdf9a08746cf911d25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106169 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-11-20Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 48807862eb87e3c1b874e25eb3b48f04deb224c8 - We’re stuck with these unfortunately Change-Id: Ic6350bf8490a88dec55d453de849c3eb697ad9db
generated by cgit (git 2.34.1) at 2025-02-21 07:52:27 +0000