summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-01-19loplugin:useuniqueptr in idlNoel Grandin
Change-Id: I3681d119dda85400dbb33c96fab736c262f7ce8a
2018-01-19tdf#115065: nullptr dereferenceMike Kaganski
Change-Id: Iafaaafdabf9fb7947fa0b03cd38d3b4a567a41b9 Reviewed-on: https://gerrit.libreoffice.org/48110 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-18Fix reg from 4cb3e1c05a16af3dad03db9d789dc7ea061b33cfJulien Nabet
Change-Id: I853a949e68d192c48a90321a8b3b75a5d443638b Reviewed-on: https://gerrit.libreoffice.org/48111 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-18xSheetDoc cannot be null hereStephan Bergmann
...as the UNO_QUERY_THROW above would already have caused an exception Change-Id: Ie0453b67716c64ddaddfa6becd498952a497be63 Reviewed-on: https://gerrit.libreoffice.org/48106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-18tdf#114720: Fix subtotal crashAhmed GHANMI
A condition was added in order to not make subtotal functions if category was not checked. Change-Id: I56f11330fa16bf0d3199576ce2545cbc8d13e864 Reviewed-on: https://gerrit.libreoffice.org/48099 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-01-18update copyright yearsRene Engelhard
Change-Id: I634c1132265295f90f624a53b93dddb2b18eabd5
2018-01-18deb#887593 apparmor: allow soffice.bin reading .mozilla/firefox and .gnupgRene Engelhard
Change-Id: I74b57cd510b1babbb4a537d307a6ffc9ee1d9ce5
2018-01-18deb#887593 add gpg and gpgsm to soffice.bin apparmor profileRene Engelhard
Change-Id: I4b37be72ebec86b9360ea2594b26815ddaab60cd
2018-01-18deb#887593 add #include <abstractions/X> to oosplash apparmor profileRene Engelhard
Change-Id: Ib9595b1e0fe888a6698c3c508a24390d3798b3e4
2018-01-18Include android/compatibility.hxx from ubiquitous sal/config.hStephan Bergmann
...instead of having to add it to more and more individual .cxx files, as the need arises. Change-Id: If1e893c79abf1c1bb7fb7b89dcb9bd423a7f1b94 Reviewed-on: https://gerrit.libreoffice.org/48108 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-18Resolves: rhbz#1535541 fdo#88004 mimetypes are .macroEnabled not .macroenabledCaolán McNamara
Change-Id: If7942ec9d4cd40f29fae2b9a8f76df1ef08bfc17 Reviewed-on: https://gerrit.libreoffice.org/48120 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-01-18adjust path to generated apk to new defaultsChristian Lohmaier
current android-gradle plugin creates the apk in dimension/flavor/variant (whatever you want to call it) specific directory Change-Id: I5514fe53c5c8c556d194a0f06ad6167b0b1cc98e
2018-01-18ofz#5471 Null-dereference READCaolán McNamara
Change-Id: I5af76b87c3793c7ec7ac41ab25bb4de5d81fc3cf Reviewed-on: https://gerrit.libreoffice.org/48123 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-18Don't let testSpreadsheetViewSettingsProperties interfere with existing testsStephan Bergmann
...by giving each test its own mxComponent. At least my Windows builds started to fail CppunitTest_sc_tabviewobj with > C:/lo/core/test/source/sheet/xviewsplitable.cxx:36:sc_apitest::ScTabViewObj::testSplit > equality assertion failed > - Expected: 1 > - Actual : 0 > - Wrong column after 95307f2ca73480176634e5cc46d96a19b735e87b "tdf#45904 Move _SpreadsheetViewSettings Java tests to C++" added the call to testSpreadsheetViewSettingsProperties ahead of the call to testSplit. (And allowing multiple tests to work on shared state and interfere like they apparently do here seems rather brittle in general.) Change-Id: I73a60ae3c703e59852c8e16b09f5897849f5bdf4 Reviewed-on: https://gerrit.libreoffice.org/48070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-18Don't allow tearoff under WaylandMaxim Monastirsky
as floating toolbars aren't movable there. Change-Id: I543344946f02d5a336ff738b4d6d9f9b21c595e9 Reviewed-on: https://gerrit.libreoffice.org/48096 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-01-18Move toolbars to the border window tearoff mechanismMaxim Monastirsky
and remove the one from ImplPopupFloatWin. Implemented using the FloatWinTitleType::TearOff case, which was unused otherwise. Change-Id: I82a86e5f5897ce1f2e76a2404bb382cbc007700c Reviewed-on: https://gerrit.libreoffice.org/48095 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-01-18tdf#115057 Never use ImplPopupFloatWin for anything except ToolBoxMaxim Monastirsky
ImplPopupFloatWin draws the window title and frame directly on the client window, which is incompatible with .ui layouts, as they try to occupy the whole available space. Instead just use a plain FloatingWindow whenever possible, and change the border window code to mimic the behavior of ImplPopupFloatWin, wrt removing part of the frame of toolbar popups w/o a title. Change-Id: If72ea89e31f913470faad7fcb8083f9b9787c9a8 Reviewed-on: https://gerrit.libreoffice.org/48094 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-01-18crashtesting: multiple export failuresCaolán McNamara
since... commit 84392651d2731cce91c3b2e144bed4ac07e4ddf1 Date: Wed Jan 3 23:27:16 2018 +0100 tdf#114173 Preserve size of chart legend during xlsx export Change-Id: Iebc936a0f490d6b707dfee0343732753f56728e7 Reviewed-on: https://gerrit.libreoffice.org/48147 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-18sw lokit: add page syles to header & footerHenry Castro
Change-Id: I3c0b0603d1e03f1cc19af4324dd2b909320d9d4a Reviewed-on: https://gerrit.libreoffice.org/47687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-01-18pass context as parameter instead of risk of leaking memoryChristian Lohmaier
Also adjust to dynamic permissions after bumping target-SDK. There still is some confusion about the concept of "external storage" in the code. LocalDocuments already is "external storage" - clean that up a little and use AppCompat function instead of using a legacy class for ExternalDocuments provider. Doesn't help for broken ROMs though, that would need guessing pathname for a mounted SD (in addition to separate storage partition of builtin storage). Also c6e8c96d50fc2082a3c4b9553196a42bbdd6df37 incorrectly changed the conditional around, making the whole ExternalDocumentsProvider useless/a copy of the Local one (i.e. the primary, first returned by the system). Real fix for tdf#99539 likely was 66be4feef7e0d3661f01fbb2372700de5eeea070 Change-Id: I88ca7742c0f2e89d63c338c8852ad88be0a46e4b Reviewed-on: https://gerrit.libreoffice.org/45572 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-01-18enable c++17 for android again after boost auto_ptr has a workaroundChristian Lohmaier
see 90d2155912bcee40377620d4836726041a72d537 for boost fix and see effe6b3d84302afce3d5095e4f376e7e3bf669e0 for bridges fix for mac Change-Id: Ic6209ce0927dafd39763ef0b2fabbcaa7abf743f Reviewed-on: https://gerrit.libreoffice.org/46002 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-18Updated coreAndrea Gelmini
Project: help c4a18626d14426cbd8884d1028eb248fe3b21c44 Fix typos Change-Id: Idcdc1e802dcca33aa2ed2499d4c5c4d15767026f Reviewed-on: https://gerrit.libreoffice.org/48138 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2018-01-18Updated coreAndrea Gelmini
Project: help 45e20af8857f8bcd5afa30113eea40ceef7aa3a8 Fix typo Change-Id: If3ae78fab316a0eaab5b0aeecd41824665a4d498 Reviewed-on: https://gerrit.libreoffice.org/48139 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2018-01-18ofz#4754 sw: HTML import: fix invalid tables being createdMichael Stahl
This 75-byte horror creates 2 nested tables, where one SwTableBox is in the SwTableLine of the inner SwTable but in the SwSortBoxes of the outer table, which is of course invalid. The root cause is that in SwHTMLParser::SplitAttrTab(), we move the m_pPam backward once and forward twice, moving it ouside the inner table. Change-Id: I63f6508afe1270ccdeb05da6f222b0aba5259889
2018-01-18Fix typosAndrea Gelmini
Change-Id: I633e4921042809c628e55825b70c540767eba1d3 Reviewed-on: https://gerrit.libreoffice.org/48140 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-18Fix typoAndrea Gelmini
Change-Id: I2e60032c1a306742cd73aef8579a0f082fe1a366 Reviewed-on: https://gerrit.libreoffice.org/48141 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-18No need for an 'if' when the body is empty.Jan Holesovsky
Change-Id: I69e3f2145f95424e7c524127492fd7f8a03ed3ca Reviewed-on: https://gerrit.libreoffice.org/48091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18lokdialog: Convert the Format -> ... -> Area... to async exec.Jan Holesovsky
Change-Id: I3756bd472b4e54db1d1c9da382d5d655f472bdb7 Reviewed-on: https://gerrit.libreoffice.org/48080 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18lokdialog: Convert the Format -> ... -> Line... to async exec.Jan Holesovsky
Change-Id: Ieaf440abf819d503d388a8b060dbf7fe6548db9e Reviewed-on: https://gerrit.libreoffice.org/48073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18lokdialog: Convert the Format -> ... -> Position and Size... to async exec.Jan Holesovsky
Change-Id: Idcdbfb1366db61e247c31eab5cb27a39978b0fd9 Reviewed-on: https://gerrit.libreoffice.org/48055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18lokdialog: Convert the Format -> Page... dialog to async exec.Jan Holesovsky
This actually also converts the Style -> Edit Style... at the same time. Change-Id: I4c09fcdfd7a543cce613eaa3620d0b623540d7e8 Reviewed-on: https://gerrit.libreoffice.org/48043 Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18sw: Cleanup various unused return values.Jan Holesovsky
Change-Id: Ic0e0c6cfd4b6d79f7c3807ac4300f30343269dea Reviewed-on: https://gerrit.libreoffice.org/48042 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18android: use unified headers and llvm-c++ STL (x86) with NDK 16Christian Lohmaier
gnustl (and others) are to be removed in future versions of the ndk also bump gradle and build-tools to current versions along with it arm unfortunately crashes with llvm-c++, so keep with gnustl for now/fix that later Change-Id: Ic794c3293b599b77ec48096bf3283a99c09cbb79 Reviewed-on: https://gerrit.libreoffice.org/45163 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-01-18lokdialog: No modal mode in LOKPranav Kant
... otherwise the cursor in the document goes invisible as soon as the dialog is launched. Change-Id: I77bc30879550b354e1a9593db3c2db7ad3c68193 Reviewed-on: https://gerrit.libreoffice.org/48126 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-01-18ofz#5462 Direct-leakCaolán McNamara
Change-Id: Ic2b7d139ebb6e88fac5cf9f4cf8dbec26905bcdc Reviewed-on: https://gerrit.libreoffice.org/48097 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-18use string-resource with placeholder instead of hardcoded concatenationChristian Lohmaier
as this is more l10n/translation friendly Change-Id: I1050fb24e0d6e94a2f1ad1605003a9c7010ca7cb
2018-01-18CheckLinkFormulaNeedingCheck() for .xls cell formulasEike Rathke
Change-Id: I2587fbc4fec39b6f2c8e733331815a2953dee308
2018-01-18iOS, readded function declaration.jan Iversen
Function declaration got lost in the different gerrit patches Change-Id: Iec2b0449c0c6e41fb1b5568d6f5651b697a2daa5
2018-01-18Revert "lok dialog: enable MessageDialog tunneling"Miklos Vajna
This reverts the translations submodule change of commit 072e3ce1cfea5bb61cc5f3001c288df6deb45613, which was not intentional. Change-Id: Icdeefe17e2d70b62221b61419b45e18e1317fb9a
2018-01-18iOS, directory creation as part of setupjan Iversen
Corrected sequence for creating directories Change-Id: I7a148b5568694c67e382e75a2e1629d3e23bf197
2018-01-18iOS: add a temporarily exposed function that calls ↵Jon Nermut
CallbackFlushHandler::Invoke in order to manually flush the callback queue. To be reverted once the callback problem is solved. Change-Id: I95273b8a01eec62f639edd6767f69e02a294d8aa Reviewed-on: https://gerrit.libreoffice.org/48101 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2018-01-18iOS, avoid racing conflict in dependenciesjan Iversen
WORDIR might be deleted, but generated kept, situation solved Change-Id: I5847d590affa7f80ef734bf314dbee9a6fc81669
2018-01-18Typo: rDesciprtor->rDescriptorJulien Nabet
Change-Id: I71987a989e204c9b4039c8a046e55a0857ad8889 Reviewed-on: https://gerrit.libreoffice.org/48092 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-18Revert part of 970b76816a03be0f57f35a790bea57bf299e344bJulien Nabet
Change-Id: If75ec666c0872875ab4e84e70424e540d44bc360 Reviewed-on: https://gerrit.libreoffice.org/48104 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-01-18iOS: keep track of the keyboard, and scroll the next search result into ↵Jon Nermut
view. Reimplement RenderCache (+2 squashed commits) Squashed commits: [3c3f36f] iOS: quieten warnings [8eae946] iOS: display search results in an overlay view Change-Id: I04a38943d5a22b8e6a52ae854e65f01bf43fda7b Reviewed-on: https://gerrit.libreoffice.org/48100 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2018-01-18lok dialog: enable MessageDialog tunnelingHenry Castro
Change-Id: I05b270a19e29c5ed3a2482fd8163e61e66bfdf74 Reviewed-on: https://gerrit.libreoffice.org/47772 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-01-18android: fix some layout issues with new-document buttonsChristian Lohmaier
functionality to create new documents was added for tdf#106325 with commit 1503769fe15c122ff2bb8f6f7e7b4ab72656ddc2 However the commit had some issues, most notably clipping of the shadow effect and alignment issues to to scaling down (via the animation effect, took me quite a while until I looked at that) with having a centered pivot. I think it was due to those alignment issues that the label was set to a fixed with - which is a problem for future translation. This commit: * changes the animation to not scale down the initial views * changes the FABs' setting to use compatPadding - this not only ensures enough room for the shadow, but also allows for consistent look across android versions. Side effect is that it needs more height, so * the effect was adjusted accordingly, to shrink to/expand from the lower-right corner of the parent view, instead of "mid-air" * the labels were given a proper background drawable with rounded corners and some padding for a (much more9 polished look * formatting of the labels was split out to a style, for ease of tweaking the looks * add tools:visibility statement to see the elements in layout editor * fixed the strings for the labels (and ID) to some less awkward ones Change-Id: Ifd2d90ec8d23e40603edff19c9af9e0b32090c9f Reviewed-on: https://gerrit.libreoffice.org/42033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-01-18tdf#112140 fix some NPEs re touch/zoom while doucment is not readyChristian Lohmaier
touching the screen or trying to zoom were trying to get/adjust zoom factor despite not ready yet, similarily swiping from the left to show the parts view would crash as well in case the document is not ready yet. Most likely to see this with a debug build (where loading is slower to begin with), or with long documents like the license text. Change-Id: Iea5e8c07a9b0973ce50f90114eb015e8e896e390 Reviewed-on: https://gerrit.libreoffice.org/46848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-01-18tdf#76817 ooxmlexport: only use stylename for Outline listJustin Luth
In LibreOffice, the special, built-in, Outline numbering style ("Chapter Numbering") is connected via the paragraph style to control the numbering. Thus, only the ParaStyleName should be written to the paragraph properties, and not the direct numbering properties. Both MSO and LO get confused when there are multiple definitions for outline numbering. Change-Id: I1af54fdea164d68e5e156c256b478e518daa5e99 Reviewed-on: https://gerrit.libreoffice.org/47828 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-18Fix typosAndrea Gelmini
Change-Id: I7aa101a5e1e47118ab94527eb37269dd7e544cf4 Reviewed-on: https://gerrit.libreoffice.org/48093 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-01-30 20:06:51 +0000