summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-08-12Fix typosAndrea Gelmini
Change-Id: Ib6b4f091e56e047968b2ad9b575aff2c81558635 Reviewed-on: https://gerrit.libreoffice.org/77254 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I4bd004af206813b9dc01c50ab20f2e8b954b8dca Reviewed-on: https://gerrit.libreoffice.org/77323 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12tdf#126769 Sidebar can't be collapsed clicking on the hide arrowSamuel Mehrbrodt
Change-Id: I72ab41fb6c98ab548a1b3cfce837ab9312c7df66 Reviewed-on: https://gerrit.libreoffice.org/77156 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-11Fixed "OfficeDocument"Matthias Seidel
(cherry picked from commit 856d28801b59d45cf4d32602adc57a08cd618b6d) Change-Id: Ie915588bda5930dc51a1484f20d0bbd9d955ec29 Reviewed-on: https://gerrit.libreoffice.org/77269 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-11Use standard algorithms instead of custom copy functionMike Kaganski
Change-Id: If0e3233590b31558dd0f28ff361461f2c5de5697 Reviewed-on: https://gerrit.libreoffice.org/77270 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-11Fixed typoMatthias Seidel
(cherry picked from commit 1f21ba2f2a1bc287cd869b0a03eac6e8a90eb21f) Change-Id: I286d0e6b04d6505f0728d6f84d34239be060dc27 Reviewed-on: https://gerrit.libreoffice.org/77268 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-11cid#1448422 Division or modulo by zeroCaolán McNamara
Change-Id: Id4bd62b13ed5c797274915f5b1fa44fa3bc46c1c Reviewed-on: https://gerrit.libreoffice.org/77267 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-11cid#1242793 make fuzzing tabsize check compile time instead of runtimeCaolán McNamara
Change-Id: I9f5190e903a7e645712210b3e3aa5f2ad42c0d72 Reviewed-on: https://gerrit.libreoffice.org/77266 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-11revert some consts to placate coverity Uncaught exceptionsCaolán McNamara
Change-Id: I4d8cccd98a60efd928409514944d60d6ee5532d1 Reviewed-on: https://gerrit.libreoffice.org/77251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-10Combine MacSpellChecker p/xPropHelperStephan Bergmann
Change-Id: Ie5b5ea4863ce39f53ab4ebe2e02dc7ed141627ba Reviewed-on: https://gerrit.libreoffice.org/77248 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-10cid#1448392 silence Dereference before null checkCaolán McNamara
Change-Id: I9c9d24217cad66c06df3d0e54df6254f54238798 Reviewed-on: https://gerrit.libreoffice.org/77244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-10cid#1401328 Uncaught exceptionCaolán McNamara
Change-Id: I6e0c7090fc1548d7d2fa41e8c65225c64c6398d3 Reviewed-on: https://gerrit.libreoffice.org/77243 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-10cid#1452268 Uninitialized scalar variableCaolán McNamara
Change-Id: I8b9d8f80bbf3d7d9c060d2da4675ae832966c085 Reviewed-on: https://gerrit.libreoffice.org/77242 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-10Silence -Werror,-Wimplicit-int-float-conversionStephan Bergmann
> vcl/opengl/gdiimpl.cxx:2237:45: error: implicit conversion from 'int' to 'float' changes value from 2147483647 to 2147483648 [-Werror,-Wimplicit-int-float-conversion] > glClearColor(static_cast<float>(rand())/RAND_MAX, static_cast<float>(rand())/RAND_MAX, > ~^~~~~~~~ etc. with Clang 10, by doing the division with double precision. Change-Id: Ide74d29eb07ea24ea7fb318bba7a2892251a40f7 Reviewed-on: https://gerrit.libreoffice.org/77240 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-10loplugin:stringconstant (macOS)Stephan Bergmann
Change-Id: Icb9d9e1cd21e2506e36fe40a3b93b6a2521a868c Reviewed-on: https://gerrit.libreoffice.org/77239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-10aTime.tm_wday gets overwritten anywayCaolán McNamara
so drop the first write in favor of the second Change-Id: Iac906d806a66e010e8352139b555aef6078bda02 Reviewed-on: https://gerrit.libreoffice.org/77235 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-10Silence -Werror,-Wimplicit-int-float-conversionStephan Bergmann
> vcl/source/window/window2.cxx:588:20: error: implicit conversion from 'long' to 'double' changes value from -9223372036854775807 to -9223372036854775808 [-Werror,-Wimplicit-int-float-conversion] > if ( nN == -LONG_MAX ) > ~~ ^~~~~~~~~ etc. with Clang 10 Change-Id: I272e8fc373a91630f1c48a2b0ad7a265c5370bcf Reviewed-on: https://gerrit.libreoffice.org/77241 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-10loplugin:referencecasting (macOS)Stephan Bergmann
Change-Id: I81f5de54c6657f7f8e5ffbd8c4a7c1b7f3cb70c2 Reviewed-on: https://gerrit.libreoffice.org/77238 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-10loplugin:staticconstfieldStephan Bergmann
(no idea why that only started to show now; Clang 10 on macOS here) Change-Id: Ie9115e7c2396378f31f85ae592841711e58c6b1d Reviewed-on: https://gerrit.libreoffice.org/77237 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-10assertDocument is only defined for HAVE_FEATURE_GPGVERIFYStephan Bergmann
Change-Id: I2dbe5da48d1114703481fffcc310f775308df007 Reviewed-on: https://gerrit.libreoffice.org/77236 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-10NFC cleanup writerfilter: reuse existing variableJustin Luth
Change-Id: Ib44d5296c7879fe872c33357ee0bf24d27c143af Reviewed-on: https://gerrit.libreoffice.org/77228 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-08-10tdf#118936 writerfilter: MultiPropertySet retry on exceptionJustin Luth
Applying the same logic as in PropertyMap - if the efficient multipropertyset fails, then re-apply each property one at a time. This effectively reverts 9a19a1235c301f2699157ab44049bdfd54955e8a The "assert" idea of identifying and fixing invalid properties failed spectacularly with RTF - where paragraph properties seem to be routinely applied to character styles. No docx examples were found - unless they were the novell examples which I don't have access to. Change-Id: I4b733d52de93dfb6beb1da35e0813fd1b0396da7 Reviewed-on: https://gerrit.libreoffice.org/77221 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-10sw: fix ~SwIndexReg asserts on ODF export of ooo83072-1.odtMichael Stahl
It is now possible that the stupid redline-moving code deletes the first node in the document, and there are 2 SwPaM that point to it, Writer::m_pCurrentPam and local pPam in SwWriter::Write(). So i thought it should be quite trivial to just use SwUnoCursors in these cases, but it required a bit more keyboard bashing than expected. (regression from beec1594587d0bf1ea2268f9a435c948b5580278, which i didn't really intend to push and am not sure if it's really a good idea but whatever...) Change-Id: Ia5c18d67af8760664517a4b7ee62ef3e4a417686 Reviewed-on: https://gerrit.libreoffice.org/77225 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-10tdf#126512 make handle of ooxml-shapes usable in odpRegina Henschel
The error was that handles in OOXML shapes can be used in LibreOffice as long as you work in OOXML format, but not anymore when you convert the file to ODF. Handles in OOXML reference the adjustment values by name, e.g. 'RefX = adj5'. ODF has no way to save this, so this information is lost. The patch reconstructs this information from the shape definition of the preset shape. It gets the preset shape name 'foo' from the shape type 'ooxml-foo'. This means that it only works with our own naming convention. Still, I think it's an improvement for our users. Change-Id: Iebd9f36a5c36356a12c8687e961c7802111cbd85 Reviewed-on: https://gerrit.libreoffice.org/76887 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-08-10Fix typosAndrea Gelmini
Change-Id: Ic2f53e1bacaf49727347df5378f0e11443d57bf6 Reviewed-on: https://gerrit.libreoffice.org/77226 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-10Change FR to US language for external URLAndrea Gelmini
Change-Id: I78358348bf29cd4d63ec8bdad0d3e3ead5136c9e Reviewed-on: https://gerrit.libreoffice.org/77227 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-10Fix typosAndrea Gelmini
Information is always singular Change-Id: I55275d7c2fd76c3ec0ae4a98aa952777feb90460 Reviewed-on: https://gerrit.libreoffice.org/75645 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-09tdf#126746 Fix exporting closed Polylines to PPTXBartosz Kosiorek
In previous implementation the closed shapes was imported as a polylines without closing joint. As a result the joint style was not applied. This patch fixes that, and allow proper PPTX export. TODO The same issue needs to be fixed for PPT export Change-Id: I557daac1ba02330d8923f7eda3476e67d8711384 Reviewed-on: https://gerrit.libreoffice.org/77179 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-08-09sw qa: fix typos in rtfimport/export testsMiklos Vajna
This doesn't matter in practice, since both tests inherit from the local "Test" class, which has the correct filter name; it was just misleading. Change-Id: Ie5f2e0a89a31b56abc200a1270b4b65e870fb459 Reviewed-on: https://gerrit.libreoffice.org/77198 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-09sw: remove unnecessary boost includeMichael Stahl
Change-Id: I38698992ee829ab1055e6f1da0f61ce35164a92f Reviewed-on: https://gerrit.libreoffice.org/77213 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-09tdf#118699 sw_redlinehide: need some more changes to use the last nodeMichael Stahl
... as property node for the merged frame. This would assert in SwContentNode::DelFrames() during tdf#126627 and also in crashtesting, e.g. fdo66302-1.odt. (regression from fa5eb82b398e29ae033f7b7c8c8195dfc10cf5b0) Change-Id: Ia6d52287ed42f41d16ebf12bc61d7f4a6d7c5b03 Reviewed-on: https://gerrit.libreoffice.org/77212 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-09tdf#126627 sw_redlinehide: fix corner case in SwUndoDelete::UndoImpl()Michael Stahl
The assumption that the merge by the moved nodes would be sufficient to handle the end node's frames is wrong: the MakeFrames() uses FrameMode::New, so the frames on the end node are not deleted, even if a previous node is merged with the end node, so the end node has 2 frames in the same layout, which will cause all sorts of problems. Ensure that the ::MakeFrames() that is called from SwUndoDelete will *once* use FrameMode::Existing, which will delete the existing frames on the end node *iff* it is merged. Subsequent SwTextNode::MakeFrames() calls on the nodes must use FrameMode::New of course, to prevent deleting the newly created frames immediately. Hopefully the SwUndoDelete is the only caller of MakeFrames() that will run into this corner case, as the others typically operate on a nodes-array section... (regression from 723728cd358693b8f4bc9d913541aa4479f2bd48) Change-Id: I829c1e7a92434f93d56e3c88a4ba4a55bab818d4 Reviewed-on: https://gerrit.libreoffice.org/77211 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-09Fix typosAndrea Gelmini
Change-Id: Ie63c7b2d8bf9579b7b41d7bae515818c8d5706dc Reviewed-on: https://gerrit.libreoffice.org/77217 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-09Related: tdf#122358 consistent transformation of damageCaolán McNamara
try to consistently transform our damaged regions. Quite possibly on the wrong track there, in which case just reverting to taking a cowardly grow(1) will probably suffice Change-Id: I251aec54e9df6c0f229f0c246332a1624a8b68d8 Reviewed-on: https://gerrit.libreoffice.org/77210 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-09Resolves: tdf#122358 ensure right/bottom borders are included in damage regionCaolán McNamara
a simple safely backportable expand of damage region by one pixel Change-Id: If4d226d8546d55b00172d826c8816b09b55d54ef Reviewed-on: https://gerrit.libreoffice.org/77206 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-09Resolves: tdf#126766 fix rounding correction at start of negative valuesEike Rathke
doubleToString() is entered with an inaccuracy afflicted fValue=-9999.9999999999927 for which the rounding into the next magnitude incremented the '-' character to '.' instead of appending a '1' (and '0' and then "000") thus yielded ".0000" instead of "-10000" This seems to have been always the case. Change-Id: I66170defa71fec40ca0b85f68affde8eff0d5ccb Reviewed-on: https://gerrit.libreoffice.org/77208 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-08-09tdf#126626 sw: fix duplicate SwUndoInsLayFormat in single-node CopyMichael Stahl
Fly Undo created later in SwUndoInserts::SetInsertRange(); suppress it in DocumentContentOperationsManager::CopyImpl(). (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5) Change-Id: I3b8756c20a7472029748d9e64a941320fc10b19f Reviewed-on: https://gerrit.libreoffice.org/77190 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-09Simplify Sequence iterations in scArkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: I047fb2e6ec9591166339b9748c5013a32185f14b Reviewed-on: https://gerrit.libreoffice.org/76912 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-08-09Access2Base - Python module - Basic sideJean-Pierre Ledure
Insert Python wrappers for object properties and methods Insert Python helper functions Change-Id: I9717c46ff8d3ab0d143c5861b928cbb57233812e
2019-08-09Access2Base - Mention Python.xba in script.xlbJean-Pierre Ledure
Change-Id: If96e8768d32d63d98b74dac92d42692243a5f531
2019-08-09Access2Base - Rename Compatible.xbaJean-Pierre Ledure
... into Python.xba to host Python wrappers Change-Id: Ic6824db883c6592067e482446258f60473ef4638
2019-08-09Fix typosAndrea Gelmini
"its really" Change-Id: Ic0b41597c83be6c1c66b9cdf6ccbf80b0c2bc9ef Reviewed-on: https://gerrit.libreoffice.org/77204 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-09Fix typosAndrea Gelmini
Change-Id: I76fe3da0ab62afa1cc07dafcd97c3cd06a7a23a1 Reviewed-on: https://gerrit.libreoffice.org/77205 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-09tdf#126722 Deleted svxcommands.hSzabolcs Toth
Change-Id: Ife8296ba74ad0f3016f65e69a488b9166d86e07b Reviewed-on: https://gerrit.libreoffice.org/77150 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-09tdf#126768 DOCX import: fix absolute hyperlinks to documentsTünde Tóth
file:///absolute\\path\\to\\file didn't work in Writer. Change-Id: I61135668e47bc1d67afb4ed6bec6a90744d295cf Reviewed-on: https://gerrit.libreoffice.org/77184 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-09tdf#126723 writerfilter::finishParagraph - me, not previousJustin Luth
In LO 6.2 commit 480ac84f2f5049fb4337b36f12fd6796e005761b the existing m_xPreviousParagraph was conveniently used to apply the changed properties. I never did like that choice, but despite looking at it, I failed to see that it is set in an inside loop, which means that it was NOT NECESSARILY reset to the current paragaph. So I'm happy to have proof that we should not use m_xPreviousParagraph. Change-Id: I5c7f1b0f097711d65ae0d0be1f0fbc40c8b96e9d Reviewed-on: https://gerrit.libreoffice.org/77185 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-09Resolves: tdf#126790 use TopLevelWindowLocker in welded help pathCaolán McNamara
Change-Id: I4340d021b63609189d3179a7bcff7fac4fcef69d Reviewed-on: https://gerrit.libreoffice.org/77195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-09Resolves: tdf#126736 change range on change of unitCaolán McNamara
and make the max % 800 instead of 500 while we're at it (0.15cm is considered 100% FWIW) when flipping from measurement unit to % Change-Id: Ia1b15559f3db0d1e11d4563ad7c6aacc3f9ba32d Reviewed-on: https://gerrit.libreoffice.org/77192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-09Update git submodulesVipul Gupta
* Update helpcontent2 from branch 'master' - tdf#76535 Clarify hyperlink button edition. Change-Id: I268cfd36f15bea462265b2f3d28488f873cfb662 Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/77197 Tested-by: Jenkins
2019-08-09Resolves: tdf#126732 don't abort on IOException, just reportCaolán McNamara
Change-Id: Ia68b6e1e603fbc6397645abdf0ea7131a547ad42 Reviewed-on: https://gerrit.libreoffice.org/77186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-02 13:42:41 +0000