summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-11-30Resolves: tdf#97086 Allow "unlimited" password length for OOXML encryptionEike Rathke
Change-Id: I51175424e19ad02b81120c3fdea22732cd481a8d Reviewed-on: https://gerrit.libreoffice.org/84097 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-11-29missing includeStephan Bergmann
Change-Id: Ie122f39f8fd3c8613eea7c9dc17e2c63d4b45823 Reviewed-on: https://gerrit.libreoffice.org/84091 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-29missing include (for close)Stephan Bergmann
Change-Id: I0795ba6df244c2b2f2bde210dbfb2f4a5181995d Reviewed-on: https://gerrit.libreoffice.org/84092 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-29Make loplugin:unnecessaryparen treat member expressions consistentlyStephan Bergmann
Stumbled across a warning starting to get emitted for some !(p->x) when I temporarily changed x from boost::optional (which has a member operator!) to std::optional (which instead implicitly uses a member conversion operator to bool). (That is, for the new static int foo3(Foo2 & foo) { (void) !(foo.p); (void) !(foo.b); (void) !(foo.n); return (foo.p) ? 1 : 0; } test, the first, third, and fourth body lines never warned, while the second one erroneously warned without this fix.) Change-Id: I60f6941aaa3a73db0f1373c954e47aa68d703170 Reviewed-on: https://gerrit.libreoffice.org/84079 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-29Enable O[U]String move ctor/assignment for WinMike Kaganski
Change-Id: If7ad38a7a802732e84db9352a475644327769d62 Reviewed-on: https://gerrit.libreoffice.org/84043 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-29tdf#129007: fix autocompletionMike Kaganski
Using EditView::SelectCurrentWord in arbitrary selection positions is not a correct approach. When cursor is after "_" in "=_+FUNC", the method will select "=_+", i.e. the substring that cannot start any Calc identifier (and actually ending *after* current cursor). When matching identifiers like "bb.bbb" in "=bb.bb", the end result will be "=bb.bb.bbb", etc. So instead of trying to match words and hack around problems, let's simply find longest match in the string starting from beginning of the line, and ending at current cursor position. Testing trailing parts of that string of decreasing length, the first found match is the longest, which is what we need. This also avoids multiple calls to expensive EditEngine methods. Change-Id: Ia3470cc85a4ba9f9ab34cbe9db3250bf28e93350 Reviewed-on: https://gerrit.libreoffice.org/84087 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-29tdf#129098: parameters mixed in OPT_PROB_INMONEY (scaddins)Julien Nabet
Here's getOptProbInMoney signature according to XPricingFunctions.idl: 66 /// OPT_PROB_INMONEY(), probability of ending up in-the-money. 67 double getOptProbInMoney( [in] double spot, [in] double vol, 68 [in] double mu, [in] double maturity, 69 [in] double barrierLow, [in] double barrierUp, 70 [in] any strike, [in] any putCall ) 71 raises( com::sun::star::lang::IllegalArgumentException ); So "putCall" should be at the end. It's been like this since initial commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=e9f31eaa49f9494113e72deaf0fe079701844ea4 Change-Id: I186348fe7470633abd32598954b7032102770a8a Reviewed-on: https://gerrit.libreoffice.org/84078 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-29tdf#118947 writerfilter: remove obsolete tablestyle fontsize hackJustin Luth
LO 6.5 commit 6bced3c6a1bf8d4652dd6ba75e41b128ce1bfc5c obsoletes this old hack. The default paragraph style has (almost) nothing to do with table styles. *Any* specified (non-inherited) paragraph style property should override a table style, including the default paratyle. One exception is the default occurance of the not-yet-supported word/settings.xml compat option overrideTableStyleFontSizeAndJustification = false. The default case should cause the table-style font to override a size 11 or 12 default-paragraph-style font. So that is actually double-reason to remove this old hack which threw out the table-style size altogether. Change-Id: Id1687f32b8431b6fa8770b01c344e75e0ffb344f Reviewed-on: https://gerrit.libreoffice.org/84044 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-11-29WIN enable NoAuthority testJan-Marek Glogowski
Change-Id: I5e8214efbf32a5bc43f002ef244826b9b899c692 Reviewed-on: https://gerrit.libreoffice.org/84071 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-11-29Related tdf#128974: Really deal with "default" and "default-release" profilesJulien Nabet
See https://support.mozilla.org/gl/questions/1264072 for some background info. Change-Id: I4939a0c9a8ad09753de4a152f464c647ec637f31 Reviewed-on: https://gerrit.libreoffice.org/84077 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-29jsdialogs: send fill transparency type updatesSzymon Kłos
Change-Id: I3381968a7afe1f4db09401a0e6ead93b0b22f258 Reviewed-on: https://gerrit.libreoffice.org/84073 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-29unnecessary virtualCaolán McNamara
Change-Id: I918a8c51e55919555108c075d396b04b4dcafbd1 Reviewed-on: https://gerrit.libreoffice.org/84061 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-29Fix some -Werror=deprecated-copy-dtorStephan Bergmann
...which would be found by GCC 10 trunk when explicitly enabling -Wdeprecated-copy-dtor (warning about cases where the non-deleted definition of an implicit copy ctor or assignment op is deprecated because of a user-provided dtor; looks like breaking it out into its own option, which, unlike -Wdeprecated-copy, isn't enabled by -Wextra, isn't all too helpful going forward, see discussion at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88136> "-Wdeprecated-copy is draconian and shouldn't be in -Wall"). Using =delete instead of =default in cases that would otherwise cause Clang -Wdefaulted-function-deleted, cf. 3db830d354de80b319fb818a0373365a1e647264 "Silence new Clang trunk -Wdefaulted-function-deleted". Change-Id: If50214ad8ac4e9ff12127eb3e07f610deabeca8a Reviewed-on: https://gerrit.libreoffice.org/84056 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-29tdf#123206 Import/Export chart custom label textTamas Bunth
OOX import supports custom label texts in chart diagrams (produced by e.g. double clicking on a data label, and write custom text), but - since embedded objects are exported and imported to odf right after migration - it is not displayed in case of a Writer document. In order to make it work, we have to support custom label text in the odf structure. This commit only allows the import/export of pure text, it should be improved to store and load formatted string. A new XML token is added, which currently refers to an attribute of the chart:data-point tag. If we want to store formatted string, something more clever has to be done. Change-Id: I80c4a3a0dbcf59f1dc732d795fb716da318411cb Reviewed-on: https://gerrit.libreoffice.org/80156 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-11-29jsdialog: migrate left/right margin to generic items dumpSzymon Kłos
Change-Id: Ie687393ae4b9a7f8350eea07c1d417c11fc532bd Reviewed-on: https://gerrit.libreoffice.org/84002 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-29libGLX.so.0 no longer needs to be whitelistedStephan Bergmann
...after a17f70004447c8809331a90e7e5ea6a89edf0322 "do not explicitly link to libGLX" drops it from the skia library (for which it had been added to the whitelist with 90d09fbcdf013f1d366e7881353d703e4b352639 "Adapt check-elf-dynamic-objects to new skia library") Change-Id: I6ac97baf782f91fe76a896994666d01cfa3f2493 Reviewed-on: https://gerrit.libreoffice.org/84057 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-29tdf#118639: store ODF encryption data for autorecoveryMike Kaganski
When saving autorecovery information, ODF is used. If the original document is password-protected, its autorecovery is also generated password-protected (since ef87ff6680f79362a431db6e7ef2f40cfc576219). But when the stored encryption data for non-ODF document does not contain "PackageSHA256UTF8EncryptionKey" value, following ZipPackage::GetEncryptionKey fails, so the whole save fails. So just generate and append ODF encryption keys where we still have user password. Change-Id: I776e28de784489521e4941d1075690f90c056014 Reviewed-on: https://gerrit.libreoffice.org/84052 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-29jsdialog: migrate after/before spacing to generic items dumpSzymon Kłos
Change-Id: I18f0596baa8e1136f4546a943eafab9a13929c06 Reviewed-on: https://gerrit.libreoffice.org/83999 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-29make some function symbols module privateNoel Grandin
improve the script to filter out more noise generated by library symbols Change-Id: I22bf6037d56bc4015001825c3fb3b21a39d85e07 Reviewed-on: https://gerrit.libreoffice.org/84022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-29Fix build with USE_AVMEDIA_DUMMY (iOS, at least)Tor Lillqvist
We need boost headers also for avmedia/source/avmediadummy.cxx now. Change-Id: Ib1fd2c19aaf62beb759bfee5ec51f167d0966df4 Reviewed-on: https://gerrit.libreoffice.org/84011 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 8d8a3f66e57aefd7cf7d3bb6cb62059de5beded2)
2019-11-29jsdialog: rename duplicated ui object settransparencySzymon Kłos
We had two elements with the same name (one in the area, one in a graphic context) - that caused bottom panel in online not work correctly. Change-Id: I41b9604522157e2c31e68e40c49e42ff2ccdb280 Reviewed-on: https://gerrit.libreoffice.org/83976 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-29skia: fix --disable-gui buildLuboš Luňák
Change-Id: Ibfcc936e6292148f0e2ef2a810915d17a9bc7be1
2019-11-29do not completely disable a test for !OpenGL if OpenGL may be brokenLuboš Luňák
The code comes from f062b89b277a0830f038cafdd13bd074b5188455 and is more like patching things up. A proper fix should be elsewhere, but at least patch this up more to be less wrong. Change-Id: Ic9b24680688d104028b1e1bf6fccc16e6f786aa8 Reviewed-on: https://gerrit.libreoffice.org/83880 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-11-29do not explicitly link to libGLXLuboš Luňák
Apparently it doesn't exist on some old distros, and libGL links to libGLX anyway. Change-Id: I71ed5aef9e2309b34f9fed6fd1825c1cdb6b1afb
2019-11-29lokdocview: Add notify_property when the document is initializedCorentin Noël
The property "is-initialized" was updated under the hood but no notification was sent to the user preventing to use features like g_object_bind_property Change-Id: If5fab557fbd2b3ae2b2531799548907404d79a33 Reviewed-on: https://gerrit.libreoffice.org/82472 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-29lokdocview: Add support for HiDPI renderingCorentin Noël
Change-Id: I3c6b8c958dec78de1457d06ceb81e56b9ae36ce9 Reviewed-on: https://gerrit.libreoffice.org/82714 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-11-29tdf#128974: TB Addressbook not available directly as existing database (Win)Julien Nabet
When Seamonkey has been removed with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=4e3086da3e9873f53b5b9e1d5e511f9f77aaf62f "Remove Seamonkey based address book driver" mork driver was erroneously skipped. + deal with "default" and "default-release" profiles See https://support.mozilla.org/gl/questions/1264072 for some background info. Change-Id: I85822b58b12f2f2ea5233426791ed73698e67276 Reviewed-on: https://gerrit.libreoffice.org/83710 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-29Disable skia for onlineSamuel Mehrbrodt
Change-Id: Ia4ae44be19d21e6ec2c1ac6d7d9b2d0933bbb97e Reviewed-on: https://gerrit.libreoffice.org/84033 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-29Revert "tdf#128655 LibO Basic For loops variations"Mike Kaganski
This reverts commit 1dd1b76bc1c6ca249bd2b3c605de642f0761072d. Change-Id: I20fbf8d3f0e719b466dc7a1d9cab23d23197de6a Reviewed-on: https://gerrit.libreoffice.org/84032 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-29Revert "StarDesktop libO Basic UNO object"Mike Kaganski
This reverts commit 5b10c314517b78b70fc4eda6b20630ed3944d4e0. Change-Id: Iea8af818f697b5f9dac9e6b49752f9f7288edd8e Reviewed-on: https://gerrit.libreoffice.org/84031 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-29tdf#128655 LibO Basic For loops variationsLibreOfficiant
2 variations of FOR loops exist. 1st form is missing in local/online help. This test case seems necessary prior to update help doc. Change-Id: Ic4ba8a7dc0e1ce5ad1e62dfcf2ce570016f7e117 Reviewed-on: https://gerrit.libreoffice.org/83931 Reviewed-by: LibreOfficiant <LibreOfficiant@sfr.fr> Reviewed-by: <andreas.heinisch@yahoo.de> Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-28Resolves: tdf#129082 insert sheet from file failsCaolán McNamara
since... tdf#127958 crash adding 2 or more files into writer master document commit 8f6f9e4217d03d874fb1ce391730a1c893ab6844 Date: Mon Oct 7 09:40:41 2019 +0200 used the SfxItemSet copy ctor to make a copy of the itemset, but the orig itemset was a SfxAllItemSet not a SfxItemSet. an SfxAllItemSet allows all items to be added but a plain SfxItemSet only allows items in certain ranges to be inserted. Upshot is that later on the filename property cannot be set in the itemset, so file can't be opened. since... tdf#128898 import text from file with text-decode failed commit cc4dbe473b0b68dbe120065c1d6a64a087f41ba2 Date: Wed Nov 27 11:47:57 2019 +0200 tdf#128898 import text from file with text-decode failed these are std::shared_ptr so we can return to passing in the original SfxAllItemSet again to fix the problem Change-Id: I63a4230a96f9dae7726d854297ebb2b51df4868d Reviewed-on: https://gerrit.libreoffice.org/84024 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-28Drop unnecessarily user-provided ~SalLayoutGlyphsImplStephan Bergmann
...thereby avoiding -Wdeprecated-copy-dtor when the implicitly-declared copy assignment op is used, but whose non-deleted definition was deprecated because of the user-provided dtor Change-Id: I9c4adc4b9ad0634c0afe5a4a707cc3697dbfae32 Reviewed-on: https://gerrit.libreoffice.org/84020 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-28Related: tdf#129082 set explicit parent for warning dialogCaolán McNamara
Change-Id: I600be635fef3f9c0d60a799af210e2c6b11b7c10 Reviewed-on: https://gerrit.libreoffice.org/84014 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-28Removed executable permission on fileAndrea Gelmini
Change-Id: I9bb45358d4f3ff0d069042e64721b8a5c8ad64a1 Reviewed-on: https://gerrit.libreoffice.org/84021 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-28fix a few places using SCROW/SCCOL datatypes incorrectlyNoel Grandin
Found while looking for problems in another patch. This will become more important with "jumbo sheets" when using the wrong datatype can mean overflow Change-Id: I7370ffd8a6edc33a5e613242735e4c7b9eaf830d Reviewed-on: https://gerrit.libreoffice.org/83991 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-28merge LOTUS_ROOT into LotusContextNoel Grandin
since they are serving the same purpose. In the process getting rid of a duplicate ScDocument* that was sometimes set and sometimes not, causing trouble for me in another patch Change-Id: I2ceeb6d6e34b62616065bf4840a87bd87d2c3844 Reviewed-on: https://gerrit.libreoffice.org/83990 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-28Blind additional fix of the Android TB build errorJan-Marek Glogowski
Change-Id: I8dd4beedb5d1d5a555af2bb9c513878c0651e3d8
2019-11-28NFC tdf#120412 cleanup: use DFLT_ESC_* moreJustin Luth
and all of the comment references to 14400% are no longer accurate, so they were removed. Change-Id: Ic958cc240e4898e914958fc32d09e2bb9478f197 Reviewed-on: https://gerrit.libreoffice.org/83845 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-11-28StarDesktop libO Basic UNO objectLibreOfficiant
Change-Id: I83c0d0cd846ffbdf15bd22353c96713218397f6c Reviewed-on: https://gerrit.libreoffice.org/83691 Tested-by: Jenkins Reviewed-by: LibreOfficiant <LibreOfficiant@sfr.fr> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-28check crcs when fuzzing after allCaolán McNamara
I end up with something that fails in the fuzzing setup but which cannot be used as a testcase in a normal build Change-Id: I20c73aa009fdc289d95d34a8adf8ddd5882f6694 Reviewed-on: https://gerrit.libreoffice.org/84013 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-28Blind fix of the Android TB build errorJan-Marek Glogowski
Change-Id: I02f8eaff7e44197743c071a1b4c90b314c0e6b4c
2019-11-28ModuleToGroupNameMap_Impl: Use OUStringLiteral instead of OUStringMichael Weghorn
This reduces load-time initialization. Thanks to Mike Kaganski and Stephan Bergmann for pointing this out in https://gerrit.libreoffice.org/#/c/83488/ . Change-Id: I1e2001a324d96fb96f7d4db52f61dcdb20100cc4 Reviewed-on: https://gerrit.libreoffice.org/83960 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-28sw: fix asserts from SwSubFont::GetTextSize_() on ooo54042-1.docMichael Stahl
The function gets passed a single CH_TXT_ATR_FIELDSTART but it looks like this is a problem in SwTextNode::GetMinMaxSize(). That one should just skip over the CH_TXT_ATR_FIELD* basically, since it's only interested in the text; also CH_TXT_ATR_INPUTFIELD* while at it. Also adapt the SwTextFrame::GetScalingOfSelectedText(), as indicated by the comment. Change-Id: Idf24e84f000406d265e73441de643b022c0b3cff Reviewed-on: https://gerrit.libreoffice.org/83997 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-28Adapt check-elf-dynamic-objects to new skia libraryStephan Bergmann
As reported by <https://ci.libreoffice.org/job/lo_daily_update_gandalf/773/>, instdir/program/libskialo.so needs: libGL.so.1 libGLX.so.0 libX11.so.6 libX11-xcb.so.1 Change-Id: I9ab99334176dd3871d1471bb14e4b68bef046f8d Reviewed-on: https://gerrit.libreoffice.org/83972 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2019-11-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#128969 Fix Impress Interaction Help page + some extra refactoring. Impress menu Help page is WIP Change-Id: I872d35405238b8d5379f922801afccf1d1e94ddd Reviewed-on: https://gerrit.libreoffice.org/83956 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-28ofz#13513 infinite loop with negative value for \binCaolán McNamara
Change-Id: Ia2960598a837b3d0c48125980137171aa7944adb Reviewed-on: https://gerrit.libreoffice.org/83986 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-28tdf#128659 Cannot add AutoCorrect entriesNoel Grandin
regression from commit 77dec7588c9141b03f8ec0139eb96c298b26f261 tdf#109158 improve sorting when loading large autocorrect file The insert operation in the maSortedVector case had the "check for duplicates" operation the wrong way around Change-Id: Id8a9d044c661668e74f01eb15635c35ca70da540 Reviewed-on: https://gerrit.libreoffice.org/83344 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-28jsdialog: dump Sfx_Int__Items to JSONSzymon Kłos
Change-Id: I6a1d2847251b90f86457b552e5354f5e179e1627 Reviewed-on: https://gerrit.libreoffice.org/83977 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-28Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - related topics section title miss + related topics legibility improvement in compatible.xhp Change-Id: I59ce332560d99b949f180cd37cfd61c40d9ff3f9 Reviewed-on: https://gerrit.libreoffice.org/83981 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>