summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-11-25Use sal_Int32 to print SbxLONG valueStephan Bergmann
(The "%ld" format specifier had now caused -Werror,-Wformat with clang-cl for a Windows 64-bit build.) Change-Id: I741a3e3526a63162dbd75c018dfe7157f06819f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106575 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-25Silence false loplugin:stringviewparam in conditional code (clang-cl)Stephan Bergmann
Change-Id: Iaa6d36a316f2c474965651e286cff37990f2e817 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-25fastparser in XMLTextListItemContextNoel Grandin
Change-Id: I08f7bc47e7c2e4e7d587d4c766eb2bba6c610adf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106552 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-25crashtesting: null deref on load of ooo72915-2.odtCaolán McNamara
since... commit aacaa2aa91f705d64b929b5cff2872f160021b9f Date: Tue Nov 3 22:11:59 2020 +0100 sw_fieldmarkhide: let CheckParaRedlineMerge() hide fieldmarks HideIterator finds the next delete redline or fieldmark, whichever is closer. Change-Id: Ibe4373255356d9fe235f787c5672e72ae7032f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106578 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-11-25ScriptForge - (SF_Utils) Increment version numberJean-Pierre Ledure
Start 7.2 Change-Id: Ic09246b985038730a96c870226e2d4ce25ff24d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106530 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2020-11-25tdf#42949 Fix new IWYU warnings in directory svxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If578c5119b85f991825e91df37c42e28f16e9de5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100555 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-25Remove unused OleComponent::SetHostName aContName parameterStephan Bergmann
Unused ever since the code was introduced in 5ea5c0afebd272d5f44e6524c0f67b5317639919 "#112923# embedded object for MS OLE". (The accompanying // TODO: use aContName and aEmbDocName in m_pOleObject->SetHostNames() comment was removed when a307ad7ae029a0a62404996a63954e7026001ce3 "OLE: show title of parent document in MSO" started to use the aEmbDocName parameter, which had previously been unused too.) Change-Id: I0fbb20dbf526a3fdbdc4a3e76e64fa80e8460480 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106571 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-11-25Update git submodulesAyhan Yalçınsoy
* Update helpcontent2 from branch 'master' to 7b4dc63ec204f64a80f181ba1ff005a78791f60c - tdf#138203: removed '...' characters from the menu etnires on help page Change-Id: Ie699ceb22cf0f83a8df08eb66e5414e5ac5cda82 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106519 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-11-25lok: Don't even iterate through the redlines when they are disabled.Jan Holesovsky
It is not necessary, when we are not issuing any output anyway. Change-Id: Id952549befb1bef04a2dd9237d286922939eaae2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106509 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 8f44a939ad09d0365607ae8960e2abfe77e3fe72) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106517 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-11-25loplugin:stringviewparam (clang-cl)Stephan Bergmann
Change-Id: Id93a1c48cd0cc1aa8370498ce239035fc5c01730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106570 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-25loplugin:stringview (clang-cl)Stephan Bergmann
Change-Id: I47b44c80b2a5e3c9d84f5d7257efe17f138a1067 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106563 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-25Better handling of Java filesStephan Bergmann
Change-Id: Ifa662be39ac7d35241ee31956e2556b7ba3b5a02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106558 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-25tdf#138425 vcl/gtk activate main menu in UpdateFullThomas Viehmann
VCL GTK (in contrast to X11 and apparently Windows) pre-activates popup menus in GtkSalMenu::UpdateFull by calling GtkSalMenu::ActivateAllSubmenus. Before this patch, this, called on the main menu, would not activate the main menu itself (which does get activated in X11 eventually). This patch changes the logic to also activate the main menu. This patch deals only with gtk3. A followup patch would do the analogous change in the VCL Qt5 plugin in Qt5Menu::DoFullMenuUpdate. I haven't discovered yet where this type of functionality is currently tested, so sadly I don't have an idea how to test this and so didn't include a test case. Change-Id: I6cd9929acfd3b3af731bbc62d649d643044ca692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106454 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-25tdf#131441 Disable "UNDOCKTOOLBAR" when toolbar is lockeddiwanshu885
Change-Id: I3a7fdf2fbde55a8ac4083f1fa8cd76e55718b2e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106476 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-11-25fastparser in XMLTextListBlockContextNoel Grandin
Change-Id: I0225bf1196fa951909fefbaf14b3b840605fd5ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106551 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-25fastparser in XMLIndexTemplateContextNoel Grandin
Change-Id: I652ae8e960965c3bfd6183888c039e0e467e030a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106550 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-25center the button for narrower Colibre theme iconCaolán McNamara
Change-Id: I7feb62abf4e4f4b635c0e3096ff67f698d8de6b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106538 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-25tdf#137894 separate associated character propertiesMark Hung
in ww8filter/RtfAttributeOutput and treat \dbch as CJK and \hich Western in order to roundtrip the RTF document. ww8filter mix all the associated style, including properties for CJK and CTL scripts. Both RtfAttributeOutput::CharFontCJK and RtfAttributeOutput::CharFontCTL output \dbch, that result in incorrect assocation. CharFontCTL should use \rtlch, but it was already in RtfAttributeOutput::MoveCharacterProperties. To make the order correct, I separate the associated character properties that were stored in m_aSyltesAssoc into m_aSyltesAssocRtlch, and m_aSyltesAssocDbch by their script types. Note that it is not clear what associated character properties that we should adopt for \hich and \ltrch. In theory RTL scripts can output high ANSI chars too, so \hich may get properties from either Western or CTL scripts. However, examining Hebrew RTF documents, I didn't see any sign that \hich is used in that way. Use RTL as CTL might be a problem for Mongolian, Manchu and Xibe. They are CTL but top-to-bottom (aka LTR) . But I don't think they will be expressed as high ANSI chars either. Change-Id: I214edbb00a67c2ffe19c5a37254c8988a0828f40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106355 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-25pdfium: add sig getters: ByteRange, DocMDPPermission, Contents and SubFilterMiklos Vajna
Change-Id: Ieab577de92898568e27a879af1ca1bda170a307d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106554 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-25Update git submodulesAyhan Yalçınsoy
* Update helpcontent2 from branch 'master' to cc9d63e60d848b0560778b4de098581923bbc6a2 - tdf#138203: fixed identical menu on help pages Change-Id: I97ded684de5025e2747f8b30a9ec4bb0e2278e29 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106439 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-11-25Move SalInstanceTreeView decl to header fileSzymon Kłos
Change-Id: Ie49f4113332de5c4fa825f93dde46bb408187fe4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106536 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-25jsdialog: dump treelistviewSzymon Kłos
Change-Id: Id6152a1b96a92a8ee863e1426d458b9f81605065 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106535 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-25fastparser in XMLIndexTOCStylesContextNoel Grandin
Change-Id: I59f6a044da134fe1ce6ffe415df518dce9272b53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106549 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-25fastparser in text indexNoel Grandin
Change-Id: Ia1811b6e913aabcb9f1fb138ab440f5cee8a9d74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106548 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-25loplugin:stringviewparamStephan Bergmann
Change-Id: Ieddc3cc1913e57f51d270cead97b1eadaa81fc6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106507 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-25fastparser in TOCNoel Grandin
Change-Id: Ia46d61e202292c957299e77e133c7f7a9f6eb0ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106547 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-25tdf#138326 impress template thumbnails are blurredNoel Grandin
regression from commit 548d77d0c06f7088dd3eb408797aa1fc1d7eb277 Author: Noel <noelgrandin@gmail.com> Date: Fri Nov 13 10:23:36 2020 +0200 tools::Long->sal_uInt16 in ImpErrorQuad Change-Id: I29403afcb7d88dee27f1565793ffbd7ad4c53a17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106545 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-25use string_view for the parsing in sax utilsNoel
Change-Id: Ifd7430501318684f9999c90dd36c1ca965373947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-25Fix --disable-pch build on WindowsMike Kaganski
Restore inclusion of <unotools/transliterationwrapper.hxx>, added in 63f7efe613f4f7436eddd90933c1916d2e689648 to fix exactly the same problem that reappeared now after removing it in commit fe88ffb661053f8fff9bd77affdf4de820c43ca8. This partially reverts fe88ffb661053f8fff9bd77affdf4de820c43ca8, making the inclusion conditional. Change-Id: Iab6893549377e1b8f2f96150b09b7294c9476fa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106555 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-25Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to bb3b17ed7577aca011955a97e40edfd795e70cd3 - tdf#138458 add explanation of "Save Preview Image..." in File > Properties-General Change-Id: I08f7d94c61262d51f3deb128becb4544a4fa7064 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106518 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-11-24sw tiled rendering: fix paint->invalidation loop when paint is started by vclMiklos Vajna
SwViewShell::PaintTile() already calls comphelper::LibreOfficeKit::setTiledPainting(), so by the time it would rearch SwViewShell::Paint(), callbacks (e.g. invalidations) are ignored during paint. Do the same for SwEditWin::Paint(), where we processed invalidations during paint, potentially leading to paint->invalidation loops. Change-Id: I8280f5c2571beeae6c0f2986d275dde3c2d33161 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106542 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-11-24ofz#27817 null derefCaolán McNamara
Change-Id: I16da6f6f78dfd0a4bc17017275a6644d6e4340c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106533 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24open_more.png is narrower than other icons in Colibre themeCaolán McNamara
so use a different one to measure desired width of tabbar Change-Id: Iace4b46d77d5cb52b2faaf6bb035be50fd556d12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106534 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24sw: fix SwXTextRange::createEnumeration() inside table cellMichael Stahl
This would set CursorType::SelectionInTable but leave m_pOwnTable and m_pOwnStartNode uninitialised, causing sw/source/core/unocore/unoobj2.cxx:399: SwXParagraphEnumeration: table type but no start node or table and then the enumeration would return the table it's in as the first element, which is quite annoying. Refactor the creation of SwXParagraphEnumeration to prevent this. Change-Id: I4e9e3456bdf66b9822d19ad985a20b094e6bbba4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106532 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-24loplugin:stringviewparamStephan Bergmann
Change-Id: I6fc8b3b550c113b7b0f807bedbfc0e02b59cd719 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106506 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-24tdf#138428: sc_uicalc: Add unittestXisco Fauli
Change-Id: I8379ced4d04efcfaf355734d50a784bf29636140 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106455 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-24jsdialog: use separate content and notificator windowsSzymon Kłos
Change-Id: I42208dd69bc790d136637253d7f1ae39a6306820 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106503 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24tdf#124176: Use pragma once instead of include guardsBayram Çiçek
Change-Id: I8df8d454ff1b65a5df2f1920b4d01f0925cbce33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106489 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-24Don't show tooltip for formula bar in onlineSzymon Kłos
Change-Id: Ib7608bb31222234ea08c99e76dcd341570d3685b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104861 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106419 Tested-by: Jenkins
2020-11-24notebookbar: don't hide elements for onlineSzymon Kłos
Change-Id: If0c48c6ab674ac282c23beac9cc115b0b404b0a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106504 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24lok: Log save errors and avoid infinite loopSzymon Kłos
Don't create synchronous dialogs on errors which were causing infinite loops. Just send error for logging purposes. Change-Id: I88e57ae34502a6f82e44051033c91ca41c1a7b8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104579 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106418 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24notebookbar: don't block init in calcSzymon Kłos
Change-Id: I7fdebcf317c8ebd3e322c1f73d9a4e7df30ecd27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105240 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106420 Tested-by: Jenkins
2020-11-24Update git submodulesOlivier Hallot
* Update dictionaries from branch 'master' to 2bfbaa38e1acd6984a3745c1668ad78096c3fa00 - tdf#138368 bump pt_BR dict version to 3.2.14 * version increased to hold changes on file conversions to UTF-8 * convert hyphenation to UTF-8 * cleaned README file Change-Id: I72f20f495d7b93445145ba804d27f10492465fcb Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/106508 Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-24fix crash in loading ooo57731-1.odtNoel
This fixes bugs in the following commits, where we need to also process unknown elements, in order to maintain compatibility with the preceding code. commit 0c48c46d3ed5db39a0c0e6d0b35aab7506fb8772 Date: Thu Nov 19 13:16:17 2020 +0200 fastparser in DomBuilderContext commit bb124fe673d69f8a79478bf25329978a452b82da Author: Noel <noelgrandin@gmail.com> Date: Thu Nov 19 11:52:50 2020 +0200 fastparser in DomBuilderContext commit cf13e985a6112a18e4d405b807a2064092c01b2d Date: Thu Nov 19 14:17:54 2020 +0200 fastparser in TokenContext commit 39d8ee8f91f4c571030b53febdcba07ea55ca7de Date: Thu Nov 19 13:51:21 2020 +0200 fastparser in TokenContext Change-Id: I9e4eddfedc6d13db72066f0d5bf436fc237bf3e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106490 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-24Use std::vector in SbiBufferMike Kaganski
This removes memory management from the class; unifies the types used throughout the code using it; and simplifies it all greatly. Also this changes errors handling. Prevoiusly setting errors to parser didn't handle case when no parser was passed to SbiBuffer ctor, as BufferTransformer did, and could dereference nullptr. Change-Id: I068eb1b3e9a616a5744fc8233781c4dd4403c84d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106452 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-24add set_buildable_name to enable distinguishing different instancesCaolán McNamara
of widgets loaded from the same .ui snippet in the same dialog so ui-testing can identify the right one Change-Id: I2ecc7fd60ab891ae9f94971a3035585d4500f694 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106500 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24loplugin:stringview (macOS)Stephan Bergmann
Change-Id: I20e4bdefdf8f05bbe1ac547a16e8d5e06e3303eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106501 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-24CVE-2020-25713 raptor2: malformed input file can lead to a segfaultCaolán McNamara
due to an out of bounds array access in raptor_xml_writer_start_element_common use a better fix than the initial suggestion See: https: //bugs.mageia.org/show_bug.cgi?id=27605 https: //www.openwall.com/lists/oss-security/2020/11/13/1 Change-Id: I9203904755b0e4ac98ae1e39942fd6f616c1efff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106488 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24tdf#42949 Fix new IWYU warnings in directory swGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4bb84c3f401aba8a3dede9cec3a7f2187a2ba02a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106473 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-24Remove unused parameter (flagged now by loplugin:stringview)Stephan Bergmann
Change-Id: I474fbadfa9ab356829077d428cbd18a61a7ea919 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106487 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-06 21:39:04 +0000