summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-11-26weld DataSourceTabPageCaolán McNamara
Change-Id: I99b7c2ec397829c2f7ceb7ec18ae24195b9781e2 Reviewed-on: https://gerrit.libreoffice.org/61800 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26remove unused enum value SvTLEntryFlags::IN_USENoel Grandin
Change-Id: Ieb09d4d28cc2084da4660165a96561ee57d2420d Reviewed-on: https://gerrit.libreoffice.org/64029 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26sfx2: show partial signatures even if cert validation failsMiklos Vajna
Change-Id: I6060b7130827346ac5d6955bf38ebe3b476819fd Reviewed-on: https://gerrit.libreoffice.org/64022 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-26remove unused enum value TrackingEventFlags::DontCallHdlNoel Grandin
Change-Id: I75b28d20e2e0954fbd2fee396b8e06e9bb7d7073 Reviewed-on: https://gerrit.libreoffice.org/64028 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26remove unused ShowFlags::NoParentUpdateNoel Grandin
Change-Id: Id63e1d73643a18d823dfcb35479f0f8eb3e20b15 Reviewed-on: https://gerrit.libreoffice.org/63972 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26tdf#42949 Fix IWYU warnings in chart2/source/view/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9ee3318c79d3b59f272a2a5f89c38b26afa05974 Reviewed-on: https://gerrit.libreoffice.org/63775 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-26Use -filelist with macOS linkerAlyssa Ross
macOS's linker can take a -filelist argument, in place of taking the list of object files to link on the command line. This is a more limited version of "response files" as used elsewhere in the code base, and by using it we make it far less likely that a linker invocation will hit ARG_MAX. A standard LibreOffice build probably won't hit ARG_MAX on macOS just yet, but it's not far off - some LDFLAGS are enough to tip it over the edge, which is what prompted me to fix the issue. If not fixed, a few more object files will probably break LibreOffice builds on macOS! An example of another large program that has encountered this issue is Thunderbird, which implemented the same fix[1]. The changes I've made to use -filelist are adapted from the code elsewhere in gbuild that creates response files, but this is slightly different because -filelist files are a bit different - they can only contain object files, as opposed to arbitrary linker arguments, and arguments are separated by newlines rather than spaces. [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=837618 Change-Id: I01b9126aad95056c3dc82f941dea4fd43f95d0f2 Reviewed-on: https://gerrit.libreoffice.org/64010 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-11-26Fix menu insertion to specified positionAleksei Nikiforov
Change-Id: I61f870010003fae98d792f95d7fdac0e59d4305c Reviewed-on: https://gerrit.libreoffice.org/63885 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-26weld SfxCmisVersionsDialogCaolán McNamara
Change-Id: I73fc8ba88021f3d1450d10a75970e1fd58f26c3f Reviewed-on: https://gerrit.libreoffice.org/64002 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26remove some unused enum values in xmloffNoel Grandin
(*) also make it more obvious what XMLShapeExportFlags::SIZE represents Change-Id: Ie63edf0f2827f171542037b819ebe7d55e090275 Reviewed-on: https://gerrit.libreoffice.org/63948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26NB tabbed impress: add shortcuts and Right2Left supportandreas kainz
Change-Id: Ic333dd44c980ace2f52057d795c29930515965f1 Reviewed-on: https://gerrit.libreoffice.org/64006 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-26NB tabbed draw: add shortcuts and Right2Left supportandreas kainz
Change-Id: I4531a32f38ecfc1cd26b092d84ec9da442a71ea9 Reviewed-on: https://gerrit.libreoffice.org/64005 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-26NB tabbed calc: add shortcuts and Right2Left supportandreas kainz
Change-Id: I96d760063bf1684cf893e7765f10b0695b2e16ed Reviewed-on: https://gerrit.libreoffice.org/64004 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-26file param is used in DEBUG modeNoel Grandin
regression from commit 4c19552052083b9b10d581f1a93f6ddecf241bcd remove some unused enum values and defines in soltools Change-Id: I897a75a65ab31068dbb9c51b111c81ab848506c9 Reviewed-on: https://gerrit.libreoffice.org/64018 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26drop unnecessary includesCaolán McNamara
Change-Id: I5305722d88ed947cbaf8015fc85d6b52900b7b75 Reviewed-on: https://gerrit.libreoffice.org/64003 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26weld SfxVersionDialogCaolán McNamara
Change-Id: I0b69192a6eab9dadac892968a4a2d4fa3d9febde Reviewed-on: https://gerrit.libreoffice.org/64001 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26drop some unnecessary includesCaolán McNamara
Change-Id: I4a45110e69fc76ff5b12e014586a0684c3737dfe Reviewed-on: https://gerrit.libreoffice.org/64000 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26Put text label outside of the pie if..Tamas Bunth
performLabelBestFitInnerPlacement fails. Change-Id: Ic84e8b42e02da2023b22a9406c44d462170c5305 Reviewed-on: https://gerrit.libreoffice.org/64015 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-11-26remove unused StartTrackingFlags enum valuesNoel Grandin
Change-Id: Ib72e4d5e3e1c65bc4d44756f98392393c79dab0e Reviewed-on: https://gerrit.libreoffice.org/63971 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26remove unused DrawFlags enum valuesNoel Grandin
Change-Id: I3f313dfa085612d805ea54352793a3fb0356b986 Reviewed-on: https://gerrit.libreoffice.org/63970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I1ac4c52ea51503373644bc58dcd4395c69f1a675 Reviewed-on: https://gerrit.libreoffice.org/64007 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-26partial revert tdf79435 doc: round-trip legacy input formfieldsJustin Luth
Apparently import isn't always properly reading some of these strings, so it is just garbage being round-tripped in some cases. Let's just avoid that until such time as import might be fixed. I couldn't readily identify the import problem. It even happens with version eWW8 files and also TestBeltAndBraces() didn't seem to prevent the problem. These crashes are due to reading garbage: /srv/crashtestdata/files/doc/ooo78311-1.doc -DISTRICT_COURSE_OUTLINE_TEMPLATE.doc /srv/crashtestdata/files/doc/kde79024-2.doc -Ü2_Blanko.doc /srv/crashtestdata/files/doc/ooo24395-1.doc -stateapp-emp.doc /srv/crashtestdata/files/doc/abi9921-1.doc /srv/crashtestdata/files/doc/ooo59101-1.doc -Hovedblankett.DOC /srv/crashtestdata/files/doc/fdo48097-1.doc -BR1010.doc Change-Id: Iceaa53760867f06c73ab900c57f197dbc0fb8e65 Reviewed-on: https://gerrit.libreoffice.org/63938 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-11-26Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Fix typo Change-Id: Ic224fbb099b86942afb651e5c10c6a91d2dac020 Reviewed-on: https://gerrit.libreoffice.org/63978 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-26tdf#108027, add external ref string items to the data arrayMarkus Mohrhard
Change-Id: Iaf607fca6d7e88f2c529ab4a374f34164813331a Reviewed-on: https://gerrit.libreoffice.org/64009 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-26add dumpAsXml methods to more pool itemsMarkus Mohrhard
Change-Id: Ia33ac2dfa23bdc4e2990e6d028d1bae7fedfe4f5 Reviewed-on: https://gerrit.libreoffice.org/63853 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-25Revert "Enabling Developer Toolset 7 for Jenkins' lo_callgrind_linux"Stephan Bergmann
This reverts commit 74d6476a045ff2cad36deac51228712d992fb98b. Developer Toolset 7 has apparently not yet been installed on vm139 (the node exclusively executing this job), see <https://ci.libreoffice.org/job/lo_callgrind_linux/6525/console>: > checking for gcc... /opt/rh/devtoolset-7/root/usr/bin/gcc > checking whether the C compiler works... no > configure: error: in `/home/buildslave/lode/jenkins/workspace/lo_callgrind_linux': > configure: error: C compiler cannot create executables > See `config.log' for more details > Error running configure at /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/autogen.sh line 296.
2018-11-25tdf#120703 PVS: (nArse == 0x2225) condition was maskedMike Kaganski
... since initial commit d791366863cf9659a01b171ce0e727bfe2f28cdf V560 A part of conditional expression is always false: (nArse == 0x2225). Change-Id: I4afb30f0c6c067d0e42e3fa15e5c2b2c1caa73b3 Reviewed-on: https://gerrit.libreoffice.org/63996 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25Fix typoAndrea Gelmini
Change-Id: I994a7a6c98d2e6ba32d5e005e204e9ec1f8be44b Reviewed-on: https://gerrit.libreoffice.org/63999 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-25Missing test dependencyStephan Bergmann
> warn:vcl.layout:29309:29309:vcl/source/window/builder.cxx:446: DBG_UNHANDLED_EXCEPTION in VclBuilder::VclBuilder(vcl::Window*, const rtl::OUString&, const rtl::OUString&, const rtl::OString&, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame>&, bool) > when: Unable to read .ui file > type: com.sun.star.container.NoSuchElementException > message: file:///.../core/instdir/share/config/soffice.cfg/vcl/ui/printprogressdialog.ui Change-Id: Ie275f5dbee52c5928276c06f65a5401a5fe1ae29 Reviewed-on: https://gerrit.libreoffice.org/63995 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-25tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I2ae298f49ceba8059cd7236431db9a4d9a46b125 Reviewed-on: https://gerrit.libreoffice.org/63992 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25seems we need to include algorithm hereNoel Grandin
commit 260002b16f18634a7e1d10d4160378beb0cc0c5f Simplify containers iterations in svgio, svl, svtoolsHEADmaster Change-Id: Ie97dd4276753e5b1b3a4382cf0060132caf6bd1b Reviewed-on: https://gerrit.libreoffice.org/63980 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-25remove unused PresentationFlags enum valuesNoel Grandin
Change-Id: I502ff07467bbfa7117131e2a3e56c45b005512d8 Reviewed-on: https://gerrit.libreoffice.org/63949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-25pretty up assign events dialogCaolán McNamara
Change-Id: I80ffba5d456e8b41613e0b8df577c614ce23adab Reviewed-on: https://gerrit.libreoffice.org/63983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25colibre icons: add and update icons for NBandreas kainz
Change-Id: Ia96c0bbb030e6404a18e08556c33ecb40378f843 Reviewed-on: https://gerrit.libreoffice.org/63968 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-25Enabling Developer Toolset 7 for Jenkins' lo_callgrind_linuxStephan Bergmann
...aka "Callgrind Linux", <https://ci.libreoffice.org/job/lo_callgrind_linux/> Change-Id: I518e579ec4ca7b36f700ed412d86feef37c3e203
2018-11-25Revert "Enabling Developer Toolset 7 for Jenkins' lo_tb_random_config_linux"Stephan Bergmann
This reverts commit 4d72f292cb8adf7529ec1d9ab8fb6728e9717543. Developer Toolset 7 has apparently not yet been installed on gandalf (the node exclusively executing this job), see <https://ci.libreoffice.org/job/lo_tb_random_config_linux/1623/console>: > checking for gcc... /opt/rh/devtoolset-7/root/usr/bin/gcc > checking whether the C compiler works... no > configure: error: in `/lo/home/tdf/lode/jenkins/workspace/lo_tb_random_config_linux': > configure: error: C compiler cannot create executables > See `config.log' for more details > Error running configure at ./autogen.sh line 296.
2018-11-25Enabling Developer Toolset 7 for Jenkins' lo_tb_random_config_linuxStephan Bergmann
...aka "Random Config Linux builder", <https://ci.libreoffice.org/job/lo_tb_random_config_linux/> Change-Id: I5a22526b8dcbed8e6fc9cd1fcc7db90774afb0ff
2018-11-25Enabling Developer Toolset 7 for Jenkins' lo_tb_master_linux_dbgStephan Bergmann
...aka "Tinderbox on Master for Linux-DbgUtil", <https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/> Change-Id: Icf99063e7aaf620cb13dd6ba869f98660f2de82a Reviewed-on: https://gerrit.libreoffice.org/63982 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-25Better way of enabling Developer Toolset 7 for Jenkins' linux_gcc_release_64Stephan Bergmann
Enabling it in the relevant distro-configs/Jenkins/* file is more intuitive than enabling it in autogen.sh (and avoids issues like d057e61cb5aae15ea37ce9ac824647cd2060e331 "Restrict Developer Toolset to Config=linux_gcc_release_64"), and will also be used for other Jenkins jobs like <https://gerrit.libreoffice.org/#/c/63982/> "Enabling Developer Toolset 7 for Jenkins' lo_tb_master_linux_dbg". Change-Id: If633044a90c35a12a73d60335839af0a106aa20f Reviewed-on: https://gerrit.libreoffice.org/63989 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-25tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I8d98aa7dd77fbd79611b8a4aba77e8c378fd1cae Reviewed-on: https://gerrit.libreoffice.org/63981 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25Blind fix for pre-C++14 std::equal, for nowStephan Bergmann
...which plagues some builders that haven't been updated to full C++17 support yet, let <https://ci.libreoffice.org/job/lo_tb_master_linux/31969/> Change-Id: I93ea997b9f7a85b370681103f64c791b2f28e4f2
2018-11-25Generally set CCACHE_CPP2 for --enable-werror GCCStephan Bergmann
This obsoletes <https://gerrit.libreoffice.org/plugins/gitiles/lode/+/ b82e0a9d26ef4c81046c053ff831dccfc84c56be%5E!> "For linux_gcc_release_64, don't let ccache strip comments" and fixes ccache for all builds using (recent) GCC. Change-Id: I5fd20b2565f57073c545fe5d3a9639c2c0583a74 Reviewed-on: https://gerrit.libreoffice.org/63979 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-25drop unnecessary vcl/window.hxx includes in writerCaolán McNamara
Change-Id: I9bf20f2b4a20444f910738e42789b219efcf51fd Reviewed-on: https://gerrit.libreoffice.org/63977 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25weld SfxMacroAssignDlgCaolán McNamara
Change-Id: I80045f1d1ca189fc490dc88b3471d68782df6f1c Reviewed-on: https://gerrit.libreoffice.org/63976 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25SfxStyleDialog is now unusedCaolán McNamara
Change-Id: I2aa33c6bb53577b84373f7f920f7c6db22cd7cca Reviewed-on: https://gerrit.libreoffice.org/63975 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25AbstractApplyTabDialog_Impl is now unusedCaolán McNamara
Change-Id: I6c0ab3ee8cadfd5eeb0aa6bd7828715401568e2b Reviewed-on: https://gerrit.libreoffice.org/63974 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25SwTemplateDlg is now unusedCaolán McNamara
Change-Id: If7de6baf5d2770d18926ee744a5c0fc6283c0195 Reviewed-on: https://gerrit.libreoffice.org/63973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25weld SwFrameDlgCaolán McNamara
and now can remove... commit 5d84af7e83404f22d3c9cd0b0bb88fb84d0550e7 Date: Tue Dec 4 22:43:46 2012 +0100 fdo#57553: Picture dialog Macro tab page: lazily init ... because JVM startup is annoying, so delay it until really activating Macro tab. This patch is sort of lame but with the change in bd2c14ec78a7549d4a19738154cdd5ea890f61c4 what can you do... and description is revealed to be a text_view not an entry Change-Id: Ibc92cf11870d4349ddc728ec17c846e4158e82ac Reviewed-on: https://gerrit.libreoffice.org/63916 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25Simplify containers iterations in svgio, svl, svtoolsArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I98a3e55a14c8ac00188c5003f84194c2cc6795fb Reviewed-on: https://gerrit.libreoffice.org/63959 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-25tdf#121401 add shortcuts and Left2Right supportandreas kainz
Change-Id: If2be67b9c20d887b7c8ead500daabfd3d224a2f1 Reviewed-on: https://gerrit.libreoffice.org/63965 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>