summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-01-29Related tdf#115273: Set NULLJulien Nabet
instead of "Set null" to explicit the fact that NULL is a keyword Change-Id: Iab393ffc1af07d027ef93168c8de58f3635af11c Reviewed-on: https://gerrit.libreoffice.org/48817 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-29Improve code checking for a valid port numberStephan Bergmann
Change-Id: If827ffaee9a2aa861a0746353bdbfd5df1049303 Reviewed-on: https://gerrit.libreoffice.org/48716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-29sw: prefix members of SwExtUserField, SwFileNameField and SwFileNameFieldTypeMiklos Vajna
Change-Id: I0722417149c9fbcd2aee3491c841c036a5677c8d Reviewed-on: https://gerrit.libreoffice.org/48807 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-29xmloff: add a comment tooMichael Stahl
Change-Id: Ic23c36250938009b17f4b916f0d13a097d018a0c
2018-01-29BorderlineFix: Corrected wrong indexing in Array initializationArmin Le Grand
Change-Id: I4222ef1c82620a05cea9f6db1a0664196cfb3bd4
2018-01-29BorderlineFix: Use svx::frame::Array tooling in Draw/ImpressArmin Le Grand
For creating the needed BorderPrimitives for TableCells for the Tables used in Draw/Impress, adapt the ViewContactOfTableObj doing this to use svx::frame::Array tooling now. This will correct the error for not taking the neighboured connects for merged cells into account and unify one more space to the same tooling. Change-Id: I2e6f732985e9b963359f156628bd29ddfec1a80c
2018-01-29BorderlineFix: Corrected Draw/Impress TableStyle accessesArmin Le Grand
In Draw/Impress the indices for accessing the correct neighbouring TableStyles were wrong and thus created wrong visualizations, corrected that. Change-Id: Iebc5f294adb62fa4c6358e2f8c27d29cc3163fbc
2018-01-29BorderlineFix: Fix WriterPaint if scrolling CellTableBordersArmin Le Grand
Similar to CalcBorders in Writer the overlap regions for FrameBorders have to be taken into account when repainting the CellBordes of WriterTables Change-Id: I488ba158e1de579bfb06b9c8353adaa2cac706c6
2018-01-29BorderlineFix: Fixed visual updates when scrollingArmin Le Grand
For Cells with DoubleLine the connections to perpendicular DoubleLine-Styles may have to be displayed in a Cell which is 'around' the orig cell in a Cell-Border of one. To represent that and to avoid repaint errors when scrolling in, the preparation of Primitives has to take accordingly more neighbour cells into account. Tested this change with the usages in Calc, UI (Dialogs) and Calc exports Print/PrintPreview/PDF. This does not affect Tables in Writer and/or Draw/Impress. Change-Id: I3bcc68cdf7b4fc1825a87a9773892c359421024e
2018-01-29BorderlineFix: Corrected handling for 'rotated' CellBordersArmin Le Grand
CellBorders can be rotated (including their Text) and need special visualization that is based on an own sheared/rotated coordinate system. Currently only possible for single cells (not merged ones) and needs to handle all borders (also bottom-right directly in the rotated cell, not in the neighboured ones to have the geometry, plus avoiding these in the non-rotated neighbour cells. Also corrected adding CellRotation data to svx::frame::Array in calc using SetCellRotations() which now gets called in the ScOutputData constructor to ensure it gets called in all places where it is used. Change-Id: I47bdfc29ba5ca76bbc07d98cb64733f867b1ee20
2018-01-29BorderlineFix: Avoid BorderLines to be too prolongedArmin Le Grand
For MergedCells there was an effect that the BorderLines were painted too far in PrintPreview/Print/PDF visualization, found reason and changed. Checked (hopefully) all usages, looks good. Change-Id: I0acf8dcb20548a98533f3ab317ac72c0d0f0a947
2018-01-29BorderlineFix: Corrected missing borders in printArmin Le Grand
In Print/PDF/PrintPreview border lines were missing, this happened for merged cells. It has to do with access to the involved Styles and/or 'Clip' set (to avoid creating everything). Thus a 'mixed' usage of cell and merged-cell stuff was needed. As it turns out support for this is already there, need to use it. Change-Id: Ic16085b97eef5c79a4501279432f43491bca350e
2018-01-29BorderlineFix: Need to redesign Borderline paint for CalcArmin Le Grand
To fix some errors, need to change svx::frame::Array conversion to Primitives, especially regarding handling of merged cells. These make problems in the currtent form where the full extended merged cell tries to be converted. This is bad for cropped stuff and also wrong for double-line stuff attaching to a merged cell. The solution is to handle cells single and merge created primitives which is more expensive but will work. This will involve special handling for X-Ed (crossed) and 'roated' Cells. Also need to be very careful since all this is used in the meantime for all visualizations of Tables in multiple apps/situations. Change-Id: If0652a3ba97a6f27dd5d782ea22b1514303f3710
2018-01-29tdf#106780 Fix for invalid attribute in impress ODFAbhishek Shrivastava
This patch fixes the invalid ODF generated in impress. In tables now the attribute is shown as table:name="default" instead of "text:style-name". For strict XML version we only set table:name="default" For Extended/Compatibility XML we set both text:style-name and table:name Change-Id: I894fd31f5f0eed3f77b216b3114b5da53acf1f9f Reviewed-on: https://gerrit.libreoffice.org/48373 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-29ofz#2976 TimeoutCaolán McNamara
Change-Id: Iff085d6bdbbfc7f2c821fdcef8e412aa91152d93 Reviewed-on: https://gerrit.libreoffice.org/48804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-29tdf#114677 Correct title in Base formsSzymon Kłos
Change-Id: I07bdb46cce88e876583e1d4217dff3f77f2f3814 Reviewed-on: https://gerrit.libreoffice.org/48801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-01-29Values need not be bounded by sal_uInt16, it appearsStephan Bergmann
since ESelection's nStart/EndPos have been changed to sal_Int32 with 3cbfcee36dd16e451d76c561eaaaee0ff29b01a5 "xub_StrLen and tools/string.hxx final straw". Change-Id: Icc96355ff71d07cac5d6037c81b2523156384077 Reviewed-on: https://gerrit.libreoffice.org/48773 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-29inline SvxBulletItem::SetDefaultFont_Impl and SetDefaults_ImplJochen Nitschke
use initializer lists in constructors Change-Id: Ib3b836ba96046a5f3bca12ea7702247afe8eac3b Reviewed-on: https://gerrit.libreoffice.org/48803 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29clang-tidy modernize-use-equals-default in drawinglayerJochen Nitschke
Change-Id: I2fbcac7a22a881681bc8b84274e7d39f1cec18bf Reviewed-on: https://gerrit.libreoffice.org/48800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29remove redundant initializationJochen Nitschke
Change-Id: I6b6021b8b89c6fdac570432386bdb11b752c66aa Reviewed-on: https://gerrit.libreoffice.org/48798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29osl: document osl_File_E_NETWORK enumChris Sherlock
Change-Id: I4c16ba13820b5cdec03c21a460d3d0ecc7dd86d5 Reviewed-on: https://gerrit.libreoffice.org/48791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in SfxMedium_ImplNoel Grandin
Change-Id: Iccd03ce2af58c4c3c90add9fc08c27502b5fface Reviewed-on: https://gerrit.libreoffice.org/48742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in SfxChildWindowNoel Grandin
Change-Id: I6c9db4cd4f46790295f37c620e2efea4f61870bf Reviewed-on: https://gerrit.libreoffice.org/48741 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in OCatalogNoel Grandin
Change-Id: Ie06456ac8971494f64711cd70fd2b32a4dce719d Reviewed-on: https://gerrit.libreoffice.org/48740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in SpellCheckerDispatcherNoel Grandin
the call to ClearSvcList() was also unnecessary, the map will get cleared by the destructor anyway Change-Id: I24a077143c0cd57b0cfef721169c62f5b283b9c9 Reviewed-on: https://gerrit.libreoffice.org/48739 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29make memory management more explicit in BaseContextNoel Grandin
Change-Id: I3afdfd7b461c6eccc57c23314f992900d14bd7d8 Reviewed-on: https://gerrit.libreoffice.org/48708 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in BaseContentNoel Grandin
Change-Id: I03a6942e883b75e86f4ee4e7d01198dada70238f Reviewed-on: https://gerrit.libreoffice.org/48707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in DataSupplier_ImplNoel Grandin
Change-Id: Iaa25aee42d59b481a6b6edf015fe57dbd81cfa3e Reviewed-on: https://gerrit.libreoffice.org/48706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in ResultSetBaseNoel Grandin
Change-Id: If1fca43f953acaa4d16ef6094b6e0e218e5f6307 Reviewed-on: https://gerrit.libreoffice.org/48705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in FTPContentProviderNoel Grandin
Change-Id: I3b5a53e274a75078534d0b7f783a7d7d107043d8 Reviewed-on: https://gerrit.libreoffice.org/48704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in XResultSet_implNoel Grandin
Change-Id: I2f333d0d0784fc76f6a3b7a6a9e61b82b856afa0 Reviewed-on: https://gerrit.libreoffice.org/48703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in ModelData_ImplNoel Grandin
Change-Id: I66866ed1698fafe59ba31f99df09fb792da410e3 Reviewed-on: https://gerrit.libreoffice.org/48702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in SfxShell_ImplNoel Grandin
Change-Id: If59142c2d55da5f3ccf2de101dbd9f18a8bda84c Reviewed-on: https://gerrit.libreoffice.org/48701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29Modernize a bit vcl (part2)Julien Nabet
by using for-range loops + use returned iterator by erase method + avoid some iterators calculus by using plain loop Change-Id: I196a52c3c7d0e2705d5ab0e3ea06bd4a4b83bb67 Reviewed-on: https://gerrit.libreoffice.org/48805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-28Remove various more obsolete sal_uInt16 restrictionsStephan Bergmann
...similar to bf7ea94632d33eb3ed3eae26bca36906eda15257 "SvxAccessibleTextIndex::mnEEIndex need not be bounded sal_uInt16" Change-Id: I88d107ae1eb16c8fc3322f1c6318df62c079cf23 Reviewed-on: https://gerrit.libreoffice.org/48775 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-28USHRT_MAX -> SAL_MAX_UINT16Stephan Bergmann
Change-Id: I9909d8e125a16f9494ce431b62baf5d2507ad80d Reviewed-on: https://gerrit.libreoffice.org/48774 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-28Remove useless checks against SAL_MAX_INT32Stephan Bergmann
...changed from checks against USHRT_MAX in 2af1f5691e8d64afd5246d245d7876b5a2cd5cd8 "resolved fdo#35756 import more than 64k HTML table cells" Change-Id: I32c0e1216d5ba6b1a899540dddade06b17ad0103 Reviewed-on: https://gerrit.libreoffice.org/48772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-28AccessibleImageBullet::GetParagraphCount no longer restricted to sal_uIn16,Stephan Bergmann
after 2af1f5691e8d64afd5246d245d7876b5a2cd5cd8 "resolved fdo#35756 import more than 64k HTML table cells" Change-Id: Ie8fa2810c27ba36a032c6b5e125dc2aeddd63b44 Reviewed-on: https://gerrit.libreoffice.org/48771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-28AccessibleEditableTextPara::GetParagraphCount no longer restrictedStephan Bergmann
...to sal_uInt16, after 2af1f5691e8d64afd5246d245d7876b5a2cd5cd8 "resolved fdo#35756 import more than 64k HTML table cells". Some checks against USHRT_MAX had not been removed at all, while others had been changed to useless checks against SAL_MAX_INT32. Change-Id: If21d10426ee392ba3f0586dde766e3f7da99d214 Reviewed-on: https://gerrit.libreoffice.org/48769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-28Remove useless check against SAL_MAX_INT32Stephan Bergmann
...changed from a check against USHRT_MAX in 3cbfcee36dd16e451d76c561eaaaee0ff29b01a5 "xub_StrLen and tools/string.hxx final straw" Change-Id: I8311803f9b5d1a78d8039d4810b0ae3cfdd27c53 Reviewed-on: https://gerrit.libreoffice.org/48770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-28nStart/EndEEIndex nned not be bounded by sal_uInt16Stephan Bergmann
...it appears, since ESelection's nStart/EndPos have been changed to sal_Int32 with 3cbfcee36dd16e451d76c561eaaaee0ff29b01a5 "xub_StrLen and tools/string.hxx final straw". Change-Id: I3f3d77d6efeabef9f05b3a5233e0e5590b1ed365 Reviewed-on: https://gerrit.libreoffice.org/48767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-28fix cut'n'waste errorRene Engelhard
Change-Id: Iedb387bd783bfa097a961fc55a14bc8d042d3c38
2018-01-28Unit test for tdf#105910, tdf#115276, tdf#115278Mike Kaganski
Change-Id: Id64041090a0be4df847f2962e32011ef2500de0e Reviewed-on: https://gerrit.libreoffice.org/48760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-28chart2/Library_chartopengl.mk also needs -DGLM_ENABLE_EXPERIMENTALRene Engelhard
Change-Id: I49852a541545cef587318a8bec38bfa7b9ba8fb0
2018-01-28fix build with glm 0.9.9Rene Engelhard
In file included from /usr/include/glm/gtx/norm.hpp:18:0, from /data/rene/git/LibreOffice/master/vcl/inc/opengl/VertexUti ls.hxx:16, from /data/rene/git/LibreOffice/master/vcl/inc/opengl/LineRende rUtils.hxx:14, from /data/rene/git/LibreOffice/master/vcl/opengl/LineRenderUti ls.cxx:11: /usr/include/glm/gtx/quaternion.hpp:23:3: error: #error "GLM: GLM_GTX_quaternion is an experimental extension and may change in the future. Use #define GLM_ENABLE_EXPERIMENTAL before including it, if you really want to use it." # error "GLM: GLM_GTX_quaternion is an experimental extension and may change in the future. Use #define GLM_ENABLE_EXPERIMENTAL before including it, if you really want to use it." ^~~~~ so just define it. Change-Id: I981bfb5fd944f32a3774b3f9b183989773bf235f
2018-01-28tdf#115278: an empty entry in color table is auto colorMike Kaganski
A unit test will come in a separate commit Change-Id: I89dd9cae6e099509d21398e29ccf6412791accc2 Reviewed-on: https://gerrit.libreoffice.org/48781 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-28Modernize a bit vcl (part1)Julien Nabet
by using for-range loops + remove useless vars + avoid some iterators calculus by using plain loop Change-Id: I94572bfd56ad9ac76c9899cf68d5ba831009fa7b Reviewed-on: https://gerrit.libreoffice.org/48777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-28Updated coreDmitri Kharchev
Project: help eeb16287e60c9699997e5a32a81da41a7d8c7013 tdf#92069 help page for ENCODEURL() function Change-Id: I8ec52dd918a21a9944b8fc2b2db8f0d7156678ad Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/48779
2018-01-28tdf#111837 removed lag in navigator selection updateKshitij Pathania
Change-Id: I0d15f8352ab1d8846df3b03334bda20550d117d2 Reviewed-on: https://gerrit.libreoffice.org/48717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-01-28ofz#5621 Integer-overflowCaolán McNamara
Change-Id: Ie0a7c29428e686e5c480997b84b8d12e5be4539f Reviewed-on: https://gerrit.libreoffice.org/48790 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-24 05:15:24 +0000