summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-12-18weld basctl popup menusCaolán McNamara
Change-Id: I28b18df7a27cd65e81f9e2e6f1ab96b5f1938e6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107975 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-18tdf#138953: use original (cropped, but unrotated) object size in spPrMike Kaganski
This not only fixes the regression from b226383a83e41bbced9fc2a02dc09a449401ec97, but also makes the written size more correct than before, when it was slightly larger compared to original object size. Corrected unit test for tdf#116371 reflect that: the object in ODT is 241.78 mm x 240.61 mm. It previously was exported as 241.88 x 240.70; now the exported size is closer: 241.79 x 240.63. Change-Id: Ibfe85c7cd98c089e58af8d7f3848990af8e1100f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-18add a return to EditView::Command to indicate if the command was consumedCaolán McNamara
Change-Id: I971fcfb77d93d7d1146443a8ec30d9159746bd89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107960 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-18use the OutputDevice viewCaolán McNamara
Change-Id: I017c7a8a39068263a9b3dc74714300abd3cb6159 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107959 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-18Delete Category dialog includes '~' text in the titlebarCaolán McNamara
Change-Id: I8581e5219ffc690e686a0d563463c19b682ea04b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107967 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-18fix incorrect array access after a removed enum (tdf#138973)Luboš Luňák
c521e614359d236405754134a54e8a05bdb1c44c removed some enum values but didn't remove them from the conversion array. Change-Id: Idf4837c5929feefb11b400fcd1036370534ed26a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107961 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-18Bin unnecessary forward declarationTor Lillqvist
Change-Id: I351635064b73145975b421879450f3e8ee64e983 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107963 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-18lok: check if the tree list box model has changedHenry Castro
It is necessary to know when the tree list model has changed to notify client side changes. Change-Id: I188a97223e06520d0b34cd9272eff6449a14d60e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107892 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-18lok: add parameter "MacroExecMode"Henry Castro
It is required to execute VBA scripts. Change-Id: Ibaafc62ecedcefcd0596c701728039783b5a0de7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107891 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-18lok: add "ondemand" property to dump the TreeView propertyHenry Castro
The "SalInstanceTreeView" instance does not use the flag "CHILDREN_ON_DEMAND", but instead it creates a "<dummy>" child. However the client side requires "on demand" information to request and trigger the "On Expanding" event. Change-Id: I4d8667fc83dae2c5f1d477fefa9c9917a5e6c90d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107576 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-18lok: run async the Macro Selector DialogHenry Castro
Required to be called by the client side Change-Id: I9c9d22dd249839009bdc6a701553f3b9d776347a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107246 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-18lok: jsdialog: fix possible nullptr dereferenceHenry Castro
p = nullptr; if (p) { } p->Somenthing(); Change-Id: I2a46d6a8e7eae96928210c8941ec71eed88bf631 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107245 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-18lok: jsbuilder: avoid sending early id to client sideHenry Castro
In the case of Macro Selector Dialog it is not required to send the id too early when the dialog is created and it is not initialized yet. Change-Id: I22fb05bd9ecff49b3e9eda19737750379a61dd69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107244 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-18lok: use JSDialog Builder to create a Macro Selector DialogHenry Castro
The Macro Selector Dialog should be created for desktop too. The JS Builder has an implementation to send "jsdialog: " data to the client side. Change-Id: If29660467e494323ac26605e704ee9bf15725fd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107243 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-18Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 0e196f08f250f652ff087de7ab9ca6e0caafcdd7 - tdf#137084 update and link some command names in Styles menu * update command labels "Update Style" --> "Update Selected Style" "New Style" --> "New Style from Selection" + add <link> to "Load Styles" * update to <h1>,<h2>,<tip> Change-Id: Id8f168cb248ff271d3a9557b50c73863ddd37c25 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107909 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-12-18add GetOutputDevice to EditViewCaolán McNamara
Change-Id: I8b2555669106096b9ab37e0cc89267f5759efa3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107958 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-18lok: jsbuilder: fix disable dialog tunnelingHenry Castro
When a client side issue command to show the Macro Selector Dialog to the server side, it is not necessary the dialog sends window invalidate. I guess the dialog tunneling progressively will be deprecated in favor of JSDialog, that it will send JSON data to client side, then it will be constructed to html element using a javascript dialog builder. (I am wondering why sending JSON?, the server side can just send the HTML string, and no need for javascript dialog builder). Change-Id: Ia88f431ed9a860bb9bb30caaaf0f7f889d765115 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107240 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-18lok: initialize to dispatch ".uno:RunMacro" commandHenry Castro
The ".uno:RunMacro" command it is needed for client side to show the Macro Selector Dialog. Change-Id: I8f01b9f5cc985119c9215734a6484ed7a0e30080 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107886 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-18cross-compilation targets really do need all AC_CONFIG_FILESChristian Lohmaier
Build doesn't fail after just a make clean, but do fail with a completely fresh checkout regression from https://gerrit.libreoffice.org/c/core/+/107655 Change-Id: Id05f747548729449fbda6306fc27e35377b80569
2020-12-18tdf#138865 don't set ColumnToggleType::CheckJan-Marek Glogowski
We don't want any hidden, magic checkbox for this table, as the user explicitly has to toggle the desired replacement modes, which isn't in any way related to a row selection. Change-Id: I3f9a73d41cc8727aa6380172221ea07068ef74c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107920 Reviewed-by: Attila Szűcs <szucs.attila3@nisz.hu> Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org>
2020-12-18Partially resolves: tdf#139017 update labels in Create Style dialogSeth Chaiklin
Changes name of dialog to correspond to command name. Changes label of entry box to Action verb and colon because it has a buddy control. Change-Id: Ib34b859ad2e25fbb70a46af7459c910e9bbe0ec1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107903 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-18tdf#126460: libtest_filter_tiff: Add unittestXisco Fauli
Change-Id: I60ad27828df684d1886c21a50247dd5fa59e933c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107942 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-18add OStringBuffer::append(std::string_view)Noel
so we don't need to construct an OString when appending from a view Change-Id: I8105d916b43215e312857e9d9d00a38c3d833861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-18vcl: move nShift closer into scope where it is usedChris Sherlock
Change-Id: If85e013269b39e1d8d34653a1348d080d34eba99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107851 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-18sw: document how the first page frame is createdMiklos Vajna
I can't remember if the boolean order is left/right and then first/nonfirst or the other way around. Change-Id: Id39d81f8501da690ce179546e9aa3d4b54f39fcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107937 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-18tdf#115863: libtest_filter_tiff: Add unittestXisco Fauli
Change-Id: I4877005287181189c4210052ab57ada876ae2e90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107926 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-18tdf#138897 sw: avoid creating SwUndoResetAttr in CopyImplImpl()Michael Stahl
The problem is that SwTextNode::CopyCollFormat() both creates the SwTextFormatColl with undo and applies it with undo. The first is desirable, the second causes a problem because it necessarily happens after SplitNode() and currently happens before copying the non-start/end nodes, so the node-index may not match in Undo, regardless if it runs before or after SwUndoCpyDoc. But SwUndoInserts restores the SwTextFormatColl on the node itself, so it can just be suppressed, which looks easier than refactoring this to call SplitNode() with Undo enabled. (regression from b4365b985178e1866c74afd757a104aad1d405a9) Change-Id: I4d15fb88cd5ae4cc53d9afb3397dec8fcf7635fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107921 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-12-18use more string_view in IsXMLTokenNoel
Change-Id: Ib84e2e7db4b4e6e2486dd024d60057d9d42ff4b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107932 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-18fix buildStephan Bergmann
...after 177792660697f85763b39f455d7ebff0f83084fd "pgsql-sdbc: use libpq's custom free()..." Change-Id: I44f86470707eea850742130caf7ec243d850ad51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107933 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-18pdfium: add PDFiumPage::hasLinks() wrapperMiklos Vajna
Reduces the amount of raw pdfium includes in CppunitTest_vcl_pdfexport. Change-Id: I61bcc7ef11932cc5129be8123dba0e8b06e8f324 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107925 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-18pgsql-sdbc: use libpq's custom free()...Lionel Elie Mamane
... for stuff allocated by libpq Their documentation says this is important on Microsoft Windows: It is particularly important that this function, rather than free(), be used on Microsoft Windows. This is because allocating memory in a DLL and releasing it in the application works only if multithreaded/single-threaded, release/debug, and static/dynamic flags are the same for the DLL and the application. Also use const unique_ptr since we don't need the value to survive the scope in any way. Change-Id: If4637ea0cd1c05125d63e2f3d37dbeaf716973f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105967 Tested-by: Lionel Mamane <lionel@mamane.lu> Reviewed-by: Lionel Mamane <lionel@mamane.lu>
2020-12-18pgsql-sdbc small optimisationLionel Elie Mamane
1) use const unique_ptr since we don't need the value to survive the scope in any way. 2) put the custom deleter function (PQconninfoFree) in the ptr class rather than at runtime. Saves one pointer in the ptr class and reduces the ptr class overhead... Change-Id: I914baa0d8ae0426322fd343f5163d09f43c4c41c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105968 Tested-by: Jenkins Reviewed-by: Lionel Mamane <lionel@mamane.lu>
2020-12-18use more string_view in convertEnumNoel
Change-Id: I859de4b908672722e1873c5b41cb456b42258ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107885 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-18throw exception in SvStream when reading past end of fileNoel
to avoid chasing weird problems where we read past the end of file, which leads to random data in the variable we read into. I expect a couple of possible regressions from this change (1) memory leaks caused by non-exception-safe memory handling. Of which there should not be much because we're pretty good about using smart pointer classes these days. (2) Broken files which used to load, will no longer do so. These will have to be debugged by putting a breakpoint on the SvStreamEOFException constructor, and examining the backtrace to see where we should be catching and ignoring the exception to make the code continue to handle such broken files. Change-Id: I351be031bb083a3484a9a1b650a58892700e6fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-18Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to f5ff6097a41055bb91d73a9c9fa847f03212431c - tdf#107229 repair links to standard_template Change-Id: Ic71e11d69ae13ee5b391460c3125240f83883438 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107905 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2020-12-18Check intermediate for not to be rounded value, tdf#138360 follow-upEike Rathke
Change-Id: I98cc25267e7a10c34179bab50d19f49436e1c48c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107929 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-12-18Replace log2() call with parts.exponent-1023, tdf#138360 follow-upEike Rathke
... to save some cycles as we anyway need only the integer value of the exponent and even exactly this value for the number of possible decimals. Change-Id: I8d462f53cadde6a95d57d1342d8487fbfa001ae9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107928 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-12-18Add sal_uInt64 fields to sal_math_DoubleEike Rathke
We may need them later, and at least don't have a confusing inf_parts or nan_parts struct name but just parts as well. Change-Id: Ife0cf279c47d2815aa2a1483223397b147e9d776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107924 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-12-18Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 421d76024ce554072d3e062345eeaa32e735f3c6 - tdf#130170 - add related topic to Create Style ( shared/01/05140100.xhp ) + add <relatedtopics> section + add <embed> to guide page "Updating Styles from Selection" ( swriter/guide/stylist_update.xhp ) * update to <h1>,<h2>,<h3> ( swriter/guide/stylist_update.xhp ) + add sys-switch for F11/Cmd+T * update to <h1> Change-Id: I9981d46d44f3cb3af490deb0f2b8f976fa111892 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107902 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2020-12-17tdf#137729: sd: Add UItestXisco Fauli
Change-Id: I936ac8a526c8b3013f9ca37dda572cb6a2c7e3f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107890 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-17Various minor loplugin fixes (macOS ARM64), reduxStephan Bergmann
Change-Id: I720dde70c6f6ca6c25d7b430f117ea578a25f34e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107922 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-17tdf#135580 remove Euro Conversion wizard from menuChristian Lohmaier
it is considered deprecated/scheduled for removal in next version This change only removes it from the default menu, but leaves it available in the set of available commands/doesn't remove the actual conversion wizard Change-Id: Ib7a37b55a0d6f09d90da66f89c0a2b1b80d0071a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107919 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-12-17weld editview menuCaolán McNamara
Change-Id: I26bd2d011b5665f198f18d35b8433becca904991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107572 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-17add Menu::get_sensitiveCaolán McNamara
Change-Id: I242ace497d7f049d9908cc6461b7eefc6d4a2b87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107889 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-17drop dumping intermediate popup menu and go straight to boost::property_treeCaolán McNamara
Change-Id: I1209cf14cd23adee9ecf01b73bfcc95b80dea07a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107887 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-17Fixes to branding imagesHeiko Tietze
High-res splash screen image uses Vegur Vegur font in logo.svg converted to path Change-Id: Id0873329caf230c8b5bc1bde34e558955bb6959c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107918 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-12-17tdf#125449: sd: Add UItestXisco Fauli
Change-Id: I33a70d6a789d51b33c663ddbacd9ce4c35b89460 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107917 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-17sw ChangesInMargin: fix crash at Undo of deletion of paragraph breakLászló Németh
Deletion of the paragraph break by pressing Delete results an empty hidden redline, too, which caused a problem during Undo (if there were other tracked redlines, too). Change-Id: I64968688688be72d4e501631244b4c57ab634585 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107830 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-17prefetch graphics also for page before and after in slidesorterLuboš Luňák
The idea is that this will make them preloaded for when the user scrolls e.g. using PageDown. Change-Id: Icac9b6e88b25e9b0434c5ab7a152f47866dfadc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107823 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-17tdf#137729 sd UI: unique hatch names in slide/page area dlgJustin Luth
A custom hatch on a page background was not getting a name, so it was exported referring to an empty string, which was implemented as using the first available hatch. Ensuring that a name exists causes the hatch to be exported in the styles, and thus can be referred to in content.xml All praise goes to Katarina since this just copies her similar fix for grandients in tdf#125449. Too bad it took me a whole day to find that. Unfortunately, Katarina didn't provide any unit tests for me to copycat as well. Change-Id: If2be0830b521946fb1b88b247319a7e6c2c61c3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107258 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
generated by cgit (git 2.34.1) at 2025-01-09 09:05:18 +0000