summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-11-07ButtonDialog is only inherited fromCaolán McNamara
Change-Id: Icc827ba76432e6ed454acf12dc18c83c6908487b Reviewed-on: https://gerrit.libreoffice.org/82197 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-07rename FloatingWindow::ImplInit so no need for using directiveCaolán McNamara
Change-Id: I55babcf716292fa9fac3e9cb4ba66a2038a1d80b Reviewed-on: https://gerrit.libreoffice.org/82203 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-07tdf#109219 Allow files with spaces in name as MM data sourceMichael Weghorn
The filter needs to be the unescaped file name. Change-Id: I2b5337c184c1ce75595e129d5a87ed4d189ec1e7 Reviewed-on: https://gerrit.libreoffice.org/82201 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-07rename Dialog::ImplInit so no need for using directiveCaolán McNamara
Change-Id: I01a8591def7a559d3152e9c4875c6785940331f7 Reviewed-on: https://gerrit.libreoffice.org/82202 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-07tdf#125778 docxexport: handle pageBreak before TOXJustin Luth
The pagebreak before the TOX was lost in docx (but not in .doc or .rtf). Change-Id: I280b0bd19a73db180b65a0937bd0fe809e5dfc6f Reviewed-on: https://gerrit.libreoffice.org/81979 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Mute L10n in some Basic code lines Change-Id: Idbaf2b44d4c7a6220aea66d75c00f36053a22f31 Reviewed-on: https://gerrit.libreoffice.org/82193 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-07tdf#128603 sw textbox: restore shape+frame pair on undoMiklos Vajna
Undo of cut + paste restored both the shape and the frame, but the shape's content pointed to an invalid node index. Later this resulted in a crash. Make sure that in case the content of shape+frame don't match by the time the frame format pointer is set, we sync the draw format to the fly format. Change-Id: I233a504ca52698d1c514769d16c256408c29ae30 Reviewed-on: https://gerrit.libreoffice.org/82192 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-07lok: disable text spacing for now.Michael Meeks
Change-Id: I87229ab2bc1b72987d43ce685a03627111951ce3 Reviewed-on: https://gerrit.libreoffice.org/82178 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-07tdf#42949 Fix IWYU warnings in linguistic/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ida2903087ae5752a65c0ce099449645d91a83f29 Reviewed-on: https://gerrit.libreoffice.org/81971 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-07Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - Misc. typo fixing and removal of pointless tags Change-Id: I7ecffd0417b7e88b76f44e64911c3d8a2f935104
2019-11-07Fix typo in codeAndrea Gelmini
Change-Id: I05657a97092a3d119d4a18535ba0f43d096530ca Reviewed-on: https://gerrit.libreoffice.org/82190 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-11-07Removed duplicated includeAndrea Gelmini
Change-Id: Ic1fa4455449bab3c83528c5474d478fbe5ce220b Reviewed-on: https://gerrit.libreoffice.org/82055 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-07Fix typoAndrea Gelmini
Change-Id: I627e094a8c8565f29fa20cca288adb81b5a4fbd0 Reviewed-on: https://gerrit.libreoffice.org/82189 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-07Chapter Numbering Dialog width for numbering definedandreas kainz
Change-Id: I55b61de4476bad237c21b5472882924c69a47e61 Reviewed-on: https://gerrit.libreoffice.org/82187 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-07Linenumbering Dialog update for smaler widgetsandreas kainz
Change-Id: I7c483f95252e99cb4385801348ea3757703e8dac Reviewed-on: https://gerrit.libreoffice.org/82188 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-07loplugin:unusedmethodsNoel Grandin
Change-Id: I65354c7476dfaede1a607441d7c1b0c7ad038df4 Reviewed-on: https://gerrit.libreoffice.org/82186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-07sw: convert remaining uses of DECLARE_RTFIMPORT_TEST()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Icef8d75ac759480e841363142c474b95544bcf0e Reviewed-on: https://gerrit.libreoffice.org/82176 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-07android: ODR fix of RID_PAGEFORMATPANEL_MARGINS_CM.Jan Holesovsky
Without this, we get a linking error that RID_PAGEFORMATPANEL_MARGINS_CM is defined twice. Change-Id: Ib9c07adcb0a8def991d1e39429c1bb4947cd7d32 Reviewed-on: https://gerrit.libreoffice.org/82159 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-11-07Chapter Numbering Dialog updateandreas kainz
Change-Id: Id82145528ac7a9d991ca8e01d87081afea9981e7 Reviewed-on: https://gerrit.libreoffice.org/82184 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-07loplugin:unusedfieldsNoel Grandin
Change-Id: Ic1c0a2144f39373f93384bccbfc74356cac65ba0 Reviewed-on: https://gerrit.libreoffice.org/82185 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-07tdf#124270 : unit-tests for spurious Err:522 fixesDennis Francis
Change-Id: I44818c61611a6cdbcef3b71e151f7899795b3fa2 Reviewed-on: https://gerrit.libreoffice.org/82075 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-11-07tdf#124270 : improve formula-group cycle detectionDennis Francis
When a cycle of formula-groups is detected, do not conclude that there is a circular dependency of cells. Only mark the cells with Err:522 when all formula-groups in the cycle have cleanly backed off from the dependency evaluation mode. This commit also fixes places where we overlooked to back-off from dependency evaluation mode on detection of a cycle of formula-groups. Additionally mark formula-groups with self references as "part of cycle" by setting mbPartOfCycle. Unit tests for all these fixes are in a follow-up commit. Change-Id: I57a88bbc88adf177d49768a5d4585b3e53729aea Reviewed-on: https://gerrit.libreoffice.org/82074 Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Tested-by: Dennis Francis <dennis.francis@collabora.com>
2019-11-07tdf#38199 Readonly mode tab key: Don't scroll if no hyperlink foundJim Raykowski
When viewing a document in readonly mode the action of the tab key is to move among Graphic, Frame, Ole, DrawObject, or DbForm if one these is already selected. If the cursor is inside an input field and has no multi selection then move among InputFields. Finally if neither the previous two cases apply then move among Hyperlinks which causes cursor position to move to top or bottom of the document when no Hyperlink is found. When no Hyperlink is found this patch restores the cursor position to the position before search and does not scroll to it on EndAction. Change-Id: I94ac882e7be124d2ddb6f86daac03a9389117cc5 Reviewed-on: https://gerrit.libreoffice.org/81955 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-11-07Linenumbering Dialog updateandreas kainz
Change-Id: Icbfdcc293bd9dd3a73b40330e359ac141f08f998 Reviewed-on: https://gerrit.libreoffice.org/82183 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-07Footnote/Endnote Settings Dialog update and sync between each otherandreas kainz
Change-Id: Ie04c9046ce8d00015ff020a7419a47c101f18430 Reviewed-on: https://gerrit.libreoffice.org/82182 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-06Insertfootnote Dialog alignment updateandreas kainz
Change-Id: I1a07821e22fd96ddf1f8b57a59173889e47aec35 Reviewed-on: https://gerrit.libreoffice.org/82181 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-06crashtesting: null deref on import of lp482242-3.rtfCaolán McNamara
since... commit a991ad93dcd6807d0eacd11a50c2ae43a2cfb882 Date: Tue Oct 22 12:24:43 2019 +0200 tdf#121441 improve DOCX footnote import Change-Id: I0c6b83bd1ff61b9fa3621896d59f126384530270 Reviewed-on: https://gerrit.libreoffice.org/82045 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-06tdf#127791 write events at the end of groups instead of the startCaolán McNamara
because the group shape import applies the events over the children it has when it reads the events, so putting it before exportShapes means it get applied over 0 children Change-Id: If7d09865a7a34d8d13440eb559ec97580792bd4e Reviewed-on: https://gerrit.libreoffice.org/82160 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-06Resolves: tdf#128631 dispatch active ole asyncCaolán McNamara
like we do for the other things that might create dialogs Change-Id: I31ca267526ddeac8d0c7163af45c11be7750cb4c Reviewed-on: https://gerrit.libreoffice.org/82143 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-06tdf#125688 removing XWeak support from SvXMLImportContextNoel Grandin
shaves 2% off the load time Change-Id: Icac00389dfcc3339fe4faf1731e9eeb3ff8d0f0c Reviewed-on: https://gerrit.libreoffice.org/82139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Ibffbd0f5d30ec14cace3638b2bb47c91a583711c Reviewed-on: https://gerrit.libreoffice.org/82171 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06Avoid OUString::createFromAscii, use OUStringLiteral insteadStephan Bergmann
Change-Id: Ib337b9678f68d41319dda30f0ca7edba5dc7e7b0 Reviewed-on: https://gerrit.libreoffice.org/82155 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-06tdf#120412 better unit testJustin Luth
The previous unit test OUGHT to have reported exactly 100% escapement, and the patch's purpose was to support greater than 100% escapement. Depending on a number of patches (related to bug 99602), this unit test verifies that 400% works. Change-Id: I1ee36d1570c34d86dbfb0a03ee3c2026b9645b63 Reviewed-on: https://gerrit.libreoffice.org/80220 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-11-06jsdialogs: .uno:Color with string argument in CalcSzymon Kłos
Change-Id: I93ac635fc16a74cfc7a956be6d6529b4d692101b Reviewed-on: https://gerrit.libreoffice.org/82152 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-06vcl PDF export: fix re-exporting PDF images with page-level rotationMiklos Vajna
PDF images are effectively 1 page PDF documents. The page object may have a /Rotate key, which was simply ignored before. We turn page objects into form XObjects on PDF export, such rotation can be expressed with a /Matrix key. Add support for the 90 degrees rotation case, this can be generalized later if wanted. Change-Id: I55a4f63e0b986637ccdeba0b783f1db9a85c4d93 Reviewed-on: https://gerrit.libreoffice.org/82154 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-06Base/Firebird fix column creationJulien Nabet
Avoid these logs when saving a brand new table in embedded Firebird: warn:legacy.osl:6038:6038:comphelper/source/property/propertycontainerhelper.cxx:181: OPropertyContainerHelper::implPushBackProperty: name already exists! warn:legacy.osl:6038:6038:comphelper/source/property/propertycontainerhelper.cxx:182: OPropertyContainerHelper::implPushBackProperty: handle already exists! ... Change-Id: I305791ad14d0bd18b3a527b848c031e02d661dbb Reviewed-on: https://gerrit.libreoffice.org/81926 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-06Fix typosAndrea Gelmini
Change-Id: I0b0d5cf589959aa0f93f57cf6f310177394562c7 Reviewed-on: https://gerrit.libreoffice.org/82040 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-06tdf#42949 Fix IWYU warnings in canvas/*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie1f6fe98f4e8bc792f5eae1ccdd697c997707004 Reviewed-on: https://gerrit.libreoffice.org/81930 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-06convert SwXMLSectionList to FastParserNoel Grandin
Change-Id: I6bffd6891a4a90f986513a5385ef30c38f1a48c4 Reviewed-on: https://gerrit.libreoffice.org/82127 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06fix --disable-gui build on 32bit (missing -ldl)Rene Engelhard
Change-Id: I66cd04efe5486459d9cc777a532925d25fbd1e86 Reviewed-on: https://gerrit.libreoffice.org/82118 Tested-by: Jenkins Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2019-11-06erase matching container if notebook page removedCaolán McNamara
Change-Id: I15c1bb40f301684e58adcf7d366d7fa1bd171b04 Reviewed-on: https://gerrit.libreoffice.org/82136 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-06set mpCloseButton to null after it is destroyedCaolán McNamara
Change-Id: If1a0bec30d2bcfdf6846712a67efbe2dcfbbec5c Reviewed-on: https://gerrit.libreoffice.org/82133 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-06revert some module-private changesNoel Grandin
see comments at https://gerrit.libreoffice.org/#/c/82062 Change-Id: Ie128f2de770ca7c3156f63c6d4e981575a580668 Reviewed-on: https://gerrit.libreoffice.org/82135 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06tdf#121661 Add testSamuel Mehrbrodt
Change-Id: I0da9ab59bbfdb5d7dfb717ac2bcff3ac74686907 Reviewed-on: https://gerrit.libreoffice.org/82130 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-06convert ImportStoredChapterNumberingRules to XFastParserNoel Grandin
Change-Id: I80ceed4bf2e767b86aedd1dd7bf4f892e3077138 Reviewed-on: https://gerrit.libreoffice.org/82132 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06tdf#128593 fix crash on setting table background colorSzymon Kłos
Change-Id: I9596cd9817d63590f07ffd2068e79b2df5806aeb Reviewed-on: https://gerrit.libreoffice.org/82128 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-06ofz#12553 TimeoutCaolán McNamara
before: real 1m37.479s user 1m30.682s sys 0m0.261s after: real 0m44.166s user 0m44.010s sys 0m0.056s Change-Id: I9832a2aac0278120fb62fe4a6a3e4507fc80e36f Reviewed-on: https://gerrit.libreoffice.org/82129 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-06tdf#99602 writerfilter: import subscript into character styleJustin Luth
and superscripts (aka escapements, but who knows that term). This isn't perfect, but I just fixed about 4 subscript bugs under much simpler conditions. Doing this completely compatibly with MS Word would be several magnitudes of order more difficult, since WORD works in absolute amounts (much easier to deal with) and LO works in relative percentages. Normally, the default auto settings make subscripts look the best anyway, so this should be a pretty good solution. Change-Id: Iefdc8ad55988d96ddbbba4701795a4f7a61b1521 Reviewed-on: https://gerrit.libreoffice.org/80219 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-06loplugin:unusedvariablecheck tweak to find more stuffNoel Grandin
but leave the tweak commented out, since it generates false positives Change-Id: Iaf3f92414d2618f8780561f98765e33e282afe0c Reviewed-on: https://gerrit.libreoffice.org/82121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06Impress Options Dialog Print updateandreas kainz
Change-Id: I401562e96c05a6c2af0bbe928bd92f7e611cced6 Reviewed-on: https://gerrit.libreoffice.org/82111 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
generated by cgit (git 2.34.1) at 2024-07-17 22:17:22 +0000