summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-29Remove unused typedef B2DPolyPolygonList (filter/svg)Julien Nabet
Change-Id: I9bd4fecabdd1cfa90648b285d659d6b491e544c8 Reviewed-on: https://gerrit.libreoffice.org/45439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-29Remove stray SAL_DEBUG.Michael Meeks
Change-Id: I5961f5fec6fa757e21184ee15e8ef78eeb2ed459
2017-11-29Tile the writer surround rendering to avoid large image scaling.Michael Meeks
This also fixes a potentially large memory leak depending on zoom, and particularly with non-paginated rendering. Change-Id: Ia24e0b7baea725020f000a369708b0be3fc20c95 Reviewed-on: https://gerrit.libreoffice.org/45414 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-28Do as the FIXME suggestedTor Lillqvist
Not exactly, though. The FIXME said "Make this a comparison operator at the TokenArray?" but I think that would be misleading as the code in question specifically does not check the TokenArrays for being completely identical; it intentionally ignores the RPN part. So make it a member function 'EqualTokens' instead. Change-Id: I15d840c422844fa144415a76c1f8fcbd6cae3c83 Reviewed-on: https://gerrit.libreoffice.org/45404 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-11-28Add comment to translators of "Grammar By" text entry boxLászló Németh
Change-Id: Ifea74df8f113967c9df9703cf6582360ffdfa78d Reviewed-on: https://gerrit.libreoffice.org/45410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28Avoid C++17 mode for Coverity ScanStephan Bergmann
...see mail sub-thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-November/078966.html> "Re: New Defects reported by Coverity Scan for LibreOffice" about cid#1424266 et al; lets see if this makes Coverity happy again... Change-Id: If488b9f61f084f2286b35326917741051ec8d5ce Reviewed-on: https://gerrit.libreoffice.org/45403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28not used with disable-dynloadingCaolán McNamara
Change-Id: Idad8a7b9b984147b7a64caf7527d8ad21bdd55a2 Reviewed-on: https://gerrit.libreoffice.org/45433 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28ofz#4412 bail on failure in Formulacell tooCaolán McNamara
Change-Id: Ie7f9e4309ae8468947dce12355201d038e7e63fa Reviewed-on: https://gerrit.libreoffice.org/45428 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28tdf#113271 Fix order of color's attributes import.Bartosz Kosiorek
The order of import color is very important in case of more than one color attributes was provided. This order (theme -> rgb -> indexed -> auto) is not documented and was gathered experimentally based on MS Excel 2013. Information about <fonts>: https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.fonts(v=office.14).aspx Information about font: https://msdn.microsoft.com/en-us/library/ff531892(v=office.12).aspx https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.font(v=office.14).aspx More information about color class: https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.color(v=office.14).aspx https://msdn.microsoft.com/en-us/library/ff532831(v=office.12).aspx Example: With indexed auto, colour, rgb and them, <color auto="1" theme="1" rgb="FFFFFF" indexed="62" /> The priority is as follows: 1. theme 2. rgb 3. indexed 4. auto Change-Id: I7bb5ab7d7b7a52091f0130fd6f21bac44eca7408 Reviewed-on: https://gerrit.libreoffice.org/45266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-28ODF export: expose font style and weight of embedded fontsMiklos Vajna
We don't need this info ourselves, but when converting the flat ODF output to other formats, this information is hard to find out, so state them explicitly. Names correspond to existing CSS ones, where it's necessary to state these explicitly. The EPUB export will make use of these attributes. (It is unclear why the test fails on the windows_msc_dbgutil_32 slave, it works for me locally.) Change-Id: I05030b6a14aca842e5a740786f3743e9ae838293 Reviewed-on: https://gerrit.libreoffice.org/45384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-28external/libcmis: Falling back to C++03 is too drasticStephan Bergmann
e.g. when compiling against system libxml2, which in turn includes system ICU include files, which may use C++11 chart16_t. So assume that -std=gnu++14 is acceptable for any GCC version for which at least on of -std=gnu++17, -std=gnu++1z, -std=c++17, -std=c++1z is acceptable, and just fall back to C++14. Change-Id: Id9f07ab4f419e5683f4fb9c9b2d3bdda251cdd1b Reviewed-on: https://gerrit.libreoffice.org/45409 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-28Fix typoAndrea Gelmini
Change-Id: I4de461692ac261600c1b0b760ffb94156893fa0d Reviewed-on: https://gerrit.libreoffice.org/45429 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-28add xlsx support to fftesterCaolán McNamara
Change-Id: I07198f24a3e096fab67333cf6a98185d5b40fffc Reviewed-on: https://gerrit.libreoffice.org/45399 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28ofz#4471 check sprm boundsCaolán McNamara
and don't reuse results of previous search Change-Id: I15d55aba260377f2f43627d775adf1a01370ae3e Reviewed-on: https://gerrit.libreoffice.org/45406 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28ofz: ensure aCoordList has required elementsCaolán McNamara
Change-Id: I6687f7e499907f2f44ade2b05b35e40570dabc6b Reviewed-on: https://gerrit.libreoffice.org/45389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28Revert loplugin:unnecessaryparen warning around integer literalsStephan Bergmann
...as those may be used to silence Clang -Werror,-Wunreachable-code (as happens in sal/osl/unx/file_volume.cxx for Android, where OSL_detail_STATFS(...) always expands to (1)). Change-Id: I85d280c1315b4447362255d17f13f437d3c4af92
2017-11-28update Coverity configCaolán McNamara
Change-Id: I0c7fd5d88e11bfa3dd55e7ef1a8514475a0d844a Reviewed-on: https://gerrit.libreoffice.org/45424 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28coverity#1421075 Uncaught exceptionCaolán McNamara
Change-Id: I23463d4610f886d5c817f3682e08c0f683c8de98 Reviewed-on: https://gerrit.libreoffice.org/45395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28coverity#1421124 Uncaught exceptionCaolán McNamara
Change-Id: I23a9174bda0bddc258c9591bddc5108f62d64c2e Reviewed-on: https://gerrit.libreoffice.org/45394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28ofz#4461 Integer-overflowCaolán McNamara
Change-Id: Iae41823164c09352ef8ffa97dc3361476c03add8 Reviewed-on: https://gerrit.libreoffice.org/45396 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28DBus permissions missing from LO flatpakStephan Bergmann
...after 243d743dae127fe11ecd7f807121da8815af8f01 "solenv/flatpak-manifest.in: incorporate upstream sandboxing improvements", causing <https://github.com/flathub/org.libreoffice.LibreOffice/issues/3> "Doesn't open files in network shares". Change-Id: I15d7a170b3ffaf6092ff4d2fe4e93b1dcfd32b0b
2017-11-28Updated coreOlivier Hallot
Project: help 840ceaafbe4f723661c10539ed2915298cf77c5f Fix hid2file.js Change-Id: I976801b1e84defd3f8588a3423acc4254098c237 Reviewed-on: https://gerrit.libreoffice.org/45411 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-11-28tdf#104035 RTF export: fix handling of absolute tab positionsMiklos Vajna
RtfAttributeOutput::ParaTabStop() assumed that they are always absolute, but WW8AttributeOutput::ParaTabStop() points out what compat setting decides if they are absolute or relative. Change-Id: Iafe8f6bb8733cae38a89f6c407763b0327e894e8
2017-11-28Add back UnusedMethods::TraverseCXXDeductionGuideDecl, properly ifdef'edStephan Bergmann
...as is already done in 65d6c642590bd5f51c04228d941608322a85f1ac "loplugin:casttovoid". (This reverts 5eec6db4addd7cc665222e1a4d05c35b13719847 "fix loplugin unusedmethods".) Change-Id: Ibe6a7d9ce58aa70707538854ac64ad07022ea7b6 Reviewed-on: https://gerrit.libreoffice.org/45388 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-28sc, sd: rework UI Text Language "More" button, tdf#113911Henry Castro
Calc and Impress handle different uno command to set language Change-Id: Ic0ffef6a8fee5078b29873934001819a384c8f3a Reviewed-on: https://gerrit.libreoffice.org/45366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-11-28tdf#83877 Unit test for OOXML SignatureLine RoundtripSamuel Mehrbrodt
Change-Id: I40c116f28c0e8efe81e33e48fa05098d1dd76731 Reviewed-on: https://gerrit.libreoffice.org/45152 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-28tdf#114000 always use user-selected charsetDavid Tardon
Change-Id: I45b9632724f46deb97bc79e364bf775aaaf0b85f
2017-11-28tdf#109202: Convert images to desired format in (f)odt filterKatarina Behrens
Pass down mimetype to SvXMLGraphicHelper Change-Id: I9c81c06d2a1d6168704440094081e99d0bcbbff9 Reviewed-on: https://gerrit.libreoffice.org/41893 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-28Add wrongly formatted new file to blacklistStephan Bergmann
Change-Id: Ib4fd5372adac12b2effd30342a5f7af395b9aceb
2017-11-28icu: don't skip building the data just because tools were disabledChristian Lohmaier
building for e.g. android disables the tests and requests data in a static library, but icu completely skips building the data directory in case --disable-tools was specified: icu/source/Makefile.in @TOOLS_TRUE@DATASUBDIR = data will become #DATASUBDIR = data and then SUBDIRS = stubdata common i18n $(LAYOUTEX) $(ICUIO) $(TOOLS) $(DATASUBDIR) $(EXTRA) $(SAMPLE) $(TEST) will not have the data dir and make will ignore it. Add it back by specifying it when invoking make and all is fine. Change-Id: I0af693f22938ebabdc189a97f1cfc3f8b1c042ee Reviewed-on: https://gerrit.libreoffice.org/45107 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-28add docx fuzzerCaolán McNamara
Change-Id: Ib9a3d8a97fbb6281e8ac3ac2cf6c52cf6819304d Reviewed-on: https://gerrit.libreoffice.org/45216 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28Fix typosEike Rathke
Change-Id: I01f0ca82f1350b74ea2d3205948c032918049c02
2017-11-28tdf#113455 follow-up: clear spin buttons when disabled in ResetMike Kaganski
otherwise they show "1" in disabled state, unlike after being enabled and then disabled again manually (see ToggleHdl) Change-Id: I4ff4d0ef006b7530bb20d9b830dc5e2f5732530d Reviewed-on: https://gerrit.libreoffice.org/45383 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-28ofz: fix mem leakCaolán McNamara
Change-Id: I97b6ad9b0e873ac75a8791c731a1a8a862ef01af Reviewed-on: https://gerrit.libreoffice.org/45364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28loplugin:countusersofdefaultparams in sfx2..svtoolsNoel Grandin
Change-Id: I65ae5305f9cec14069fd7aef6613e981dbbed846 Reviewed-on: https://gerrit.libreoffice.org/45382 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-28fix loplugin unusedmethodsNoel Grandin
VisitCXXDeductionGuide is not part of our baseline clang Change-Id: I354a992456949975384d8ae1a81a07de9e886061
2017-11-28tdf#41650 DOCX export: insert empty header/footerTamas Bunth
Insert an empty header (or footer) to section which follows a section with a header in it. It is needed, because in case a section does not contain a header definition, Word will use the preceding section's rule. It causes problem if a document contains two page styles: one has header (or footer), the other does not. In that case after saving to docx it will end up in two sections. (only if it's not a plausable title page) Change-Id: I5add284d0cf1544923885e7205d9a2ac4e3cc9af Reviewed-on: https://gerrit.libreoffice.org/44832 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-11-28drop executable bit from test filesDavid Tardon
Change-Id: I72329d6ce5aac146a3e7014ad4a8bf7c20472b2f
2017-11-28Don't copy the stringMike Kaganski
Change-Id: If50d952acfea0be86d36bc5b23a0f087eff520c8 Reviewed-on: https://gerrit.libreoffice.org/45325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-28upload libwps 0.4.8David Tardon
Change-Id: Ib285c227cd935987311be40df3745316943a54e0 Reviewed-on: https://gerrit.libreoffice.org/45331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-11-28Factor out a code snippet copy-pasted four timesTor Lillqvist
Change-Id: I29fb16ea51873b396c4f884f6acf454ce2b229e6 Reviewed-on: https://gerrit.libreoffice.org/45363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-28The aStrNmsp[12] fields can be constTor Lillqvist
Change-Id: I257b2be52b13c8ce76dbcc06e080e348af9e1b68 Reviewed-on: https://gerrit.libreoffice.org/45359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-28Use Executable_cpp instead of default gcc as preprocessor for windresStephan Bergmann
...to avoid having GCC as yet another prerequisite on Windows. Cygwin 'man windres' states: "The default preprocessor argument is 'gcc -E -xc-header -DRC_INVOKED'." Of those arguments, -E and -xc-header are not relevant for Executable_cpp, so only -DRC_INVOKED is kept. Additional arguments that turned out to be necessary are: -I$(ATL_INCLUDE) So that #include <afxres.h> in workdir/UnpackedTarball/libgpg-error/src/versioninfo.rc is found. (Not sure how the original code using gcc found this.) -+ So that using a C++ style comment in #include "winres.h" // extract from windows header in afxres.h does not cause a "Syntax error in #include" from Executable_cpp. $(SOLARINC) So that #include "winres.h" // extract from windows header in afxres.h is found. (Not sure how the original code using gcc found this.) -DWINAPI_FAMILY=0 Because dlgs.h (included indirectly from afxres.h) contains #if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP) [...] typedef struct tagCRGB { BYTE bRed; BYTE bGreen; BYTE bBlue; BYTE bExtra; } CRGB; /* RGB Color */ and the WINAPI_FAMILY_PARTITION conditional (defined in winapifamily.h) would be true, causing the output to contain those "typedef struct tagCRGB ..." tokens that windres apparently doesn't expect (failing with "windres: can't open file `tagCRGB': No such file or directory"). (Not sure how the original code using gcc avoided this.) Change-Id: Ic2d031c72025f2e9dbde26c774215d2d2d0a43a9 Reviewed-on: https://gerrit.libreoffice.org/45334 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-28tdf#83877 OOXML Roundtrip of SignatureLine propertiesSamuel Mehrbrodt
Change-Id: I521e5f35663c5ab3c2702f1416fcec872f2f5e3f Reviewed-on: https://gerrit.libreoffice.org/44683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-28loplugin:unusedmethods ignore recursive callsNoel Grandin
Change-Id: I651a7bf0c705acc5580af8b7742d2d035ec64388
2017-11-28loplugin:countusersofdefaultparams in svxNoel Grandin
Change-Id: I2c9ea6c38b75dcafeb36931b6c2e94489819144f Reviewed-on: https://gerrit.libreoffice.org/45336 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-28Simplify methodSamuel Mehrbrodt
Change-Id: I4de0c0fc0127b454f19ecf154d8ce58f189852cf Reviewed-on: https://gerrit.libreoffice.org/45164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-28Set correct file permissionsJens Carl
Change-Id: I3667d1feda74aad160bbfd79e6baafc42e3cf83d Reviewed-on: https://gerrit.libreoffice.org/45302 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-27loplugin:useuniqueptr (clang-cl)Stephan Bergmann
Change-Id: Id9020bef2ce0fa9a7a70f48d27fb57735c6f57ca Reviewed-on: https://gerrit.libreoffice.org/45340 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27Pass $(MAKE) into external/gpgmeppStephan Bergmann
...similar to e8e5bd65d31a60712afcab17d2e5f77c3322f86f "Pass $(MAKE) into external/libassuan" Change-Id: Icb90eb0831e74270a2600ab8ea9a6b0ac88a7e5f Reviewed-on: https://gerrit.libreoffice.org/45345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-18 03:24:56 +0000