summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-04-13loplugin:passstuffbyref in codemakerNoel Grandin
Change-Id: Ib6a3342fdeeb7eb566e12eb599022b99c5f54b7e
2016-04-13loplugin:passstuffbyref in canvasNoel Grandin
Change-Id: Idde288ab4bb7935e5da2a84190fd4b398961d358
2016-04-13loplugin:passstuffbyref in basicNoel Grandin
Change-Id: Ie93b33502325f00ba95ab168a445a347148f9edd
2016-04-13loplugin:passstuffbyref in basegfxNoel Grandin
Change-Id: Ia7fc22152af2facf3134d9e0975cfb9608b2e931
2016-04-13update loplugin passstuffbyref to check return typesNoel Grandin
of methods like Foo getFoo() const { return m_foo; } where we can rather do const Foo& getFoo() const { return m_foo; } and let the client code decide if it wants copy Foo. Inspired by a performance problem where we were unwittingly copy constructing a large struct repeatedly just so client code could interrogate the members of the struct. When all of the changes this plugin finds are applied, I find that 'perf stat make check' shows on average a 1.7% reduction in CPU cycles. Change-Id: Ic27b4f817aa98f2a2a009f2d4e4a962cbe9c613e
2016-04-13tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13remove dead stuff from Windows SalDataNoel Grandin
- drop mbInTimerProc field - drop mnSageStatus,mpSageEnableProc fields i.e. SAGE.DLL (System Agent) workaround, which died out with Win95/98 - convert some TRUE/FALSE constants to true/false where the field is a bool - drop maDwmLib, mpDwmIsCompositionEnabled fields Change-Id: I7b773f915dbc329eb0262bc8fee2ea7c72d25c66 Reviewed-on: https://gerrit.libreoffice.org/24047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13remove Windows95 MouseWheel supportNoel Grandin
since we no longer support Windows95 Change-Id: I6b2fe5fdb2cde3c69fc0d18bcaac25afccbffc16 Reviewed-on: https://gerrit.libreoffice.org/24049 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13tdf#99165 always provide control points for beziersArmin Le Grand
Some graphic sub systems cannot handle cases where control points of bezier curves are not set and produce wrong geometry for fat line drawing when MITER or similar LineCap and/or LineJoin is used. To avoid that, provide the mathematically correct fallback control points instead. Change-Id: Iabc724e51fb89e702f858db820c920f7b5b7d302 Reviewed-on: https://gerrit.libreoffice.org/24031 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-04-13Use UNO service constructorsStephan Bergmann
Change-Id: I8ac2621a4594b2d8a7cf8fdafd2191f3bf52579b
2016-04-13tdf#97087 Give comprehensible names to timersMuhammet Kara
Timers and idles should have programmer comprehensible, unique names Change-Id: I837d1890c687936f8a31278c0102391e6f87212d Reviewed-on: https://gerrit.libreoffice.org/23917 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-13Upgrade libxmlsec to 1.2.20Miklos Vajna
Obsoletes xmlsec1-update-config.guess.patch.1. Also update xmlsec1-ooxml.patch.1 as it was upstreamed at the end (with improved error checks, etc), which wasn't possible before without loads of conflicts. Change-Id: I6fee428f73f8908289d87cc262ad323ec62e65cf Reviewed-on: https://gerrit.libreoffice.org/24032 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-04-13Related tdf#99089: avoid second crashJulien Nabet
Second bt quoted in https://cgit.freedesktop.org/libreoffice/core/commit/?id=43109b751bf5fd36318de56b2fb686acc724673f wasn't solved, try to fix it now. Change-Id: I68484f9417ff0bf747306ac8774cad5fdf84b924 Reviewed-on: https://gerrit.libreoffice.org/24042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-13Fix non-OpenCL buildsStephan Bergmann
...after ec53ac63e342d9d00e1aed4372a903630b6a191b "Move clew/clew.h into external, too" Change-Id: I33e9f839f9bcc86f009b90ed9579e61197657e1b
2016-04-13Stop assigning null to intrusive_ptrTakeshi Abe
which added at f6d61562d41b8a49449d881da66a3d8fa519487f. But they seems unnecessay because, even without them, soon the intrusive_ptr goes out of scope then its dtor decrements refcount. Change-Id: I6e35ecb7d5a0b5ccaef6ea9b7507300dcb589801 Reviewed-on: https://gerrit.libreoffice.org/24013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-04-13tdf#98395 : Remote File dialog showing wrong details in columnsSzymon Kłos
Before patch: - File type in the Size column (only first launch) After patch: - File type is not visible Change-Id: Ia2e3775f49dd9bfcc77a985812e040f70201f45c Reviewed-on: https://gerrit.libreoffice.org/22921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-04-13remove unused m_xFrame in CheckXTitle unit testAkash Jain
Change-Id: I1b654b308b79d13d23a1b9a935fd2eaf84836d91 Reviewed-on: https://gerrit.libreoffice.org/24044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-13update creditsChristian Lohmaier
Change-Id: I5525fcf891f5dae6d6972e045f4d3d7c6084b955
2016-04-13tdf#84258 Link icons and use new commands in menu/toolbarsMaxim Monastirsky
Change-Id: Ia034fd91926ec6729346274f524d3751d59fcf35
2016-04-13Tooltip/bits should also depend on state changeMaxim Monastirsky
Change-Id: I18093e42dd2fc54483e620759e4ba00c988ce9db
2016-04-12lp#1569589: a more honest attempt at disposing SvtFileView_ImplBjoern Michaelsen
Dunno yet if that completely fixes the story -- the reference here are quite messy: ownership isnt exactly obvious. Change-Id: I54d71ac724590e85549bd152c963fdc8de46746e Reviewed-on: https://gerrit.libreoffice.org/24040 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-12move xls export code from shared xls + xlsx part of codeMarkus Mohrhard
Change-Id: I016b8981c4399959e76fd5089ab8014b25a31bbe Reviewed-on: https://gerrit.libreoffice.org/24030 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-12lp#1560328: clear cache before disposing rest of VCLBjoern Michaelsen
Change-Id: Iac325cf934953c61cb4dbbb67cfbab1777dc45cc Reviewed-on: https://gerrit.libreoffice.org/24038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-12SVG: Add unittest for tdf#47446 and tdf#98599Xisco Fauli
Change-Id: I86bec5694eb0c85596d2573111ddb355bd3ae09e Reviewed-on: https://gerrit.libreoffice.org/24011 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-04-12Skip intermediate _LITTLE/BIG_ENDIAN when determining OSL_LIT/BIGENDIANStephan Bergmann
Change-Id: I1e3247a15eef62455e48229732418e7c824bb0b4 Reviewed-on: https://gerrit.libreoffice.org/24036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-12Move clew/clew.h into external, tooStephan Bergmann
For consistency with what 38cd1d9a5f00dc69ba0d60e2fe6957090c7a26d1 "clew: move this foreign code to external/clew" did for clew.c. Library_scfilt depends on clew/clew.h, simply make it depend on the full clew external. Change-Id: Idcbf56a69084e108832c8970507ebea0f7ff400b Reviewed-on: https://gerrit.libreoffice.org/24035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-12SVG: Check that masking-path-07-b.svg doesn't hangXisco Fauli
Change-Id: If8b9a0dd955611f8ebb2859fa9b10a61bfb2230b Reviewed-on: https://gerrit.libreoffice.org/24010 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-04-12tdf#99104 Checkbox in User Data page isn’t aligned to anything in the sectionAdolfo Jayme Barrientos
See comment 6. Change-Id: I492b8fa9a0e018ded46a6ebe290088898bdfe3d9
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I487dea681421cdc72e9491ec19247c8e6437b16b
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: Idaa3059658fa0e8942b7b9b7be3198aeda8205e4
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: Iadc182d2531f7c01d2dd122559be26588a96bc20
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: Ib4249b97f2c30559f483782ed3ab52e38e6f3080
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I578a5ec6a839fddecb372ed78ca7425548e3ae8b
2016-04-12Fold elementimport_impl.hxx into elementimport.hxxStephan Bergmann
Change-Id: I5e71078ddf98d389b0dd9fcf4252417ddd74ffec
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: Id2c34c5515ca72bba98ff618171b94a6d2da3620
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I9d36c79e73d061689b6f9b9ddc5f5a99f8a2d2ab
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: Ieb94e82b102673fd3c916d09d8390e6528b37c11
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I2e632b1e3f6f8725b184918c2205c3772bb37e32
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: Ie881d77774ea05b5683850c113cf3f6b1d6f2ca7
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I5c166398df5a16c5c9123ce3c046cbf6d64b9fa4
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: Ic59b23de2c11e8a0a86c3711a4507cd76e07896f
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I8590b2c145a536872d692afcaa50279c99b3f974
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I7d5eec4c8bcfc79edb3c0ea37cf73b4249f44f46
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I15609fb6b11606d865d8817f4a63ba8816f7384e
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I2c9d6a750f3a7d1ce29f3e9fe315defc63c46e46
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I10be69e36c79c15d2e02457558e37ec3efbf80c1
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: Icaf083db79b2ceb88e9b0e9e4e2a131cf6ba498b
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: Ia3a9d2edb9ce7bcf9450dd10589d823383210269
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: Ie86787cdcf96453c94e6859e66b158d9188f3491
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: Ifc47504370a2ebc8119a60091fdf1ced4b532aa3