summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-02-27Add missing modelines to .l filesStephan Bergmann
...and change connectivity/source/parse/sqlflex.l license header from using (unusual, anyway) // comments to using /* */ comment, so that it can go before Flex's opening %{ Change-Id: I371890e937cc5055405c17226dd87ba1694688aa Reviewed-on: https://gerrit.libreoffice.org/68433 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27lok: sc: clicking on individual chart elements doesn't select objectMarco Cecchetti
Exporting to svg a selected object of a chart does not work. In the chart case the selected object for the current document is always the chart itself, not an internal chart object. Moreover the exporting action cause the exported object to be selected again. So you try to selected the chart legend and you end up with the whole chart selected again. Change-Id: Ib4aa91afd592909ad354ca373dc03298547f9fb5 Reviewed-on: https://gerrit.libreoffice.org/68347 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-02-27openssl: upgrade to release 1.0.2rMichael Stahl
Fixes CVE-2019-1559, plus a couple low-severity CVEs. Change-Id: Icb6849ca5f33cb1169ce303505b2e32636e3b25b Reviewed-on: https://gerrit.libreoffice.org/68430 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-02-27Resolves: tdf#123711 measure scrollbar for optimal widthCaolán McNamara
Change-Id: I30225124e44e8a6290270ecba5024f36508817d3 Reviewed-on: https://gerrit.libreoffice.org/68428 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27Simplify condition whether to return array of references or matrixEike Rathke
Now that we have ParamClass::ReferenceOrRefArray and supporting functions use it as parameter classification and it is set at the called function in array/matrix context, use it as indicator when to return the reference list array and when to return the result matrix. Change-Id: I1fd6001f51530b0d1cfd61320f1cd58521c4fa40 Reviewed-on: https://gerrit.libreoffice.org/68426 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-02-27Fix GenericSolarThreadExecutor<...,void> specializationStephan Bergmann
Change-Id: I4468a3a8d036ca4894ba7977f6654244552464aa Reviewed-on: https://gerrit.libreoffice.org/68423 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27Fix apparent temporary debugging leftoverStephan Bergmann
Change-Id: I3277a341137b1b404ad9839431b5cc39a88fcbe1 Reviewed-on: https://gerrit.libreoffice.org/68425 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27tdf#42949 Fix IWYU warnings in sc/source/ui/d*/*cxxGabor Kelemen
Also additions were needed in include/sfx2/msg.hxx to avoid build breakage Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I259ff10aaa5d044d4b11f9041174765d5a5f7dc7 Reviewed-on: https://gerrit.libreoffice.org/68364 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-27tdf#123557 PPTX: Export timenode condition targets.Mark Hung
Refactor the code and reuse WriteAnimationTarget to export the target element for the condition element in stCondLst and endCondLst. Add testTdf123557 to make sure import-export-import works. As SdOOXMLExportTest2::testTdf90627 no longer produce corupt pptx that has endCondLst without Cond element, make the xpath more specific about what is testing. Update schema because drawooo:enhanced-path incluced in the test case. Change-Id: If5d64f5c23aa2652cfa72471f9f7886c7dd956eb Reviewed-on: https://gerrit.libreoffice.org/68211 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-02-27Unit test for array formula and OFFSET() non-ReferenceOrRefArray, tdf#123477Eike Rathke
Change-Id: I1ffe56ada6caed305fd2dbd5fb838e6a7ab3c2e2 Reviewed-on: https://gerrit.libreoffice.org/68408 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-02-27Fix commentStephan Bergmann
...after ce2792eda318b2760d24d2a744fc89e6a1d87138 "use C++11 exception rethrowing" Change-Id: I7a5cf53daa833cd398e520f67bf4bc5f36b21989 Reviewed-on: https://gerrit.libreoffice.org/68422 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27convert more Start timer methods from sal_uLong->sal_uInt64Noel Grandin
Change-Id: I1ed43bab00a5bc456032410ccf32b3fd64cc970c Reviewed-on: https://gerrit.libreoffice.org/68419 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27Add missing XNameContainer tests to ScDataPilotFieldGroupsObjJens Carl
Change-Id: Ia59b2a6136e2e56bf6c43a84e3cb6268471278a5 Reviewed-on: https://gerrit.libreoffice.org/68410 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-02-27loplugin:unnecessaryoverride look for more patternsNoel Grandin
like bool Foo::bar() { b = Super::bar(); return b; } Change-Id: I5e4c8005a3da7d7487c9039c35dcbb1d17e65bd7 Reviewed-on: https://gerrit.libreoffice.org/68418 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27writerfilter: make RTFDrawingObject members privateMiklos Vajna
Change-Id: I72085b130dede835f3fc75cb1335eb3b0c0d9b2e Reviewed-on: https://gerrit.libreoffice.org/68409 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-27Don't leave a stray a.out behindStephan Bergmann
Change-Id: I20acdccd1faa7b8edf7a5786be124ae063ebca67 Reviewed-on: https://gerrit.libreoffice.org/68405 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27UNO SwXCellRange: uso SvtListener instead of SwClientBjoern Michaelsen
Change-Id: Id4fbe6e16bb63e3df2768ce38161847ea6ff7eec Reviewed-on: https://gerrit.libreoffice.org/68406 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-02-27uitest Chart Data labels dialogZdeněk Crhonek
Change-Id: I94420e19a6ef12aee78f83ea7b1ac54433be0160 Reviewed-on: https://gerrit.libreoffice.org/68399 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-02-27Remove redundant conditionArkadiy Illarionov
Change-Id: I21385a37a5e2107069919250dd35812ac5972422 Reviewed-on: https://gerrit.libreoffice.org/68411 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27make cursor images part of the themeNoel Grandin
This first step only affects GTK3, later we will extend the support to other platforms. Note that these images are derived from the OSX PNG files, not the header-file encoded data we currently use for gtk/gtk3. Also rename the files to more useful names. Change-Id: Ia13a3f2ac35b06672aff724f4cf5bdcd823f6342 Reviewed-on: https://gerrit.libreoffice.org/67528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27loplugin:unusedfields fix read/write when dealing with r<<= and >>=Noel Grandin
Change-Id: I103bcc2f21741d0a52a0bdf053fdbddf5a3e9ea0 Reviewed-on: https://gerrit.libreoffice.org/68387 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27m_bShowAllShapes in SdPageObjsTLV is deadNoel Grandin
since commit c4a91f1409fc21d92f207718f29377c2862e381f Date: Mon Feb 11 17:32:44 2019 +0000 weld SdInsertPagesObjsDlg Change-Id: I9644c492d02e930592fd568c15f2f87d12f4f038 Reviewed-on: https://gerrit.libreoffice.org/68386 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27loplugin:simplifybool improve search for negated operatorNoel Grandin
Change-Id: Id6ac35fefa5c3e1f64c222713791e849b3cb4d34 Reviewed-on: https://gerrit.libreoffice.org/68379 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27loplugin:unusedfields look for classes where we can make all the..Noel Grandin
fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27Fix typoAndrea Gelmini
Change-Id: Ida6deb31f393d9c7457e41f2047ee364aa95ad2e Reviewed-on: https://gerrit.libreoffice.org/68415 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-27tdf#123406 KDE5: Use delayed frame destructionAleksei Nikiforov
Destroy Qt5Frame after all events are received. Update Qt5Object to use delayed destruction too. Change-Id: I07c7251e097ad56f3616f325fdc394d00fec4f4f Reviewed-on: https://gerrit.libreoffice.org/68316 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-27tdf#119720 KDE5: Don't show hidden windows on modality changeAleksei Nikiforov
This change fixes clipping and drawing issues for document recovery window and other modal windows. Change-Id: I005254d4cd2598f4f2d02ba7e7bbf7388affe36c Reviewed-on: https://gerrit.libreoffice.org/68307 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-27simplify lcl_SendChartEvent messBjoern Michaelsen
Change-Id: I2476cbabbb3625ab0d562218102fbbcfbb08f4e6 Reviewed-on: https://gerrit.libreoffice.org/68404 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-02-26parentclass set_size_request is sufficientCaolán McNamara
Change-Id: I872fdb2d6d4c6279b6d4dc8f38e1153fcd919f22 Reviewed-on: https://gerrit.libreoffice.org/68395 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-26tdf#120736: For Calc shared documents also check the original document URLStephan Bergmann
...as instead of the original shared document, a temporary copy (with a file URL denoting a temporary directory, like <file:///tmp/lulmhoxl.tmp/0.ods>) is opened in that case. Change-Id: I415f5a0ec44ee06f7ca98495f0e8f032ba93e05c Reviewed-on: https://gerrit.libreoffice.org/68391 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-26loplugin:indentation (clang-cl)Stephan Bergmann
Change-Id: I94689e4eed290b4505d2caba2d9802ef7fb6cffd Reviewed-on: https://gerrit.libreoffice.org/68378 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-26oox smartart, picture strip: fix lack of spacing around the picture listMiklos Vajna
The snake algorithm in PowerPoint seem to interpret spacing as follows: if you have N elements, then there should be the requested amount of spacing between the elements, and also double amount of spacing around the actual list of elements. With this, the SmartArt and the title shape in the bugdoc no longer overlaps. Change-Id: I5d6885b434bfaff9de9aac595a298a5346524e19 Reviewed-on: https://gerrit.libreoffice.org/68397 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-26tdf#116404 RTF: check locale if BiDi inherits EnvironmentJustin Luth
RTF is a bit simplistic compared to the others, but at least we can handle the Environment situation similarly. Change-Id: I87bc389373275d19f1229e11ffd742836a0fd498 Reviewed-on: https://gerrit.libreoffice.org/66966 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-02-26UNO redline: uno SvtListener instead of SwClientBjoern Michaelsen
Change-Id: Ic580df179c6aa1dedc866cf0882c124d5b13fcb3 Reviewed-on: https://gerrit.libreoffice.org/68360 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-02-26UNO redlines: uno SvtListener instead of SwClientBjoern Michaelsen
Change-Id: Ie07147c9d6af469ed1088148dd8b9bdb64ae8590 Reviewed-on: https://gerrit.libreoffice.org/68362 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-02-26uitest Chart Titles dialogZdeněk Crhonek
Change-Id: I41a48893d007cf9226f8fd9491af36a4d24a3661 Reviewed-on: https://gerrit.libreoffice.org/68393 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-02-26tdf#120824 KDE5: fix visible/enabled state for menuAleksei Nikiforov
Change-Id: I003703f0bc2e1697124e068a68bfb2e24c33cd1a Reviewed-on: https://gerrit.libreoffice.org/68351 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-26loplugin:simplifybool (clang-cl)Stephan Bergmann
Change-Id: Ia10e08c04fb6dfc18597fcfba3fe52cf0ba7184c Reviewed-on: https://gerrit.libreoffice.org/68377 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-26these are modal dialogsCaolán McNamara
Change-Id: I28fe2ba99c4a17cab781d95ef9da8b2774667baa Reviewed-on: https://gerrit.libreoffice.org/68383 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-26update creditsChristian Lohmaier
Change-Id: Ia47dbe8d0b8caf835fef50bc8e046d5a05f30b7d
2019-02-26PropertyValue needs to be a complete type here (Windows, --disable-pch)Stephan Bergmann
...when implicit special member functions are defined for FWE_DLLPUBLIC MergeMenuInstruction etc. Change-Id: Ida796edaea73cf2c918feee1ee961e2065f25ee8 Reviewed-on: https://gerrit.libreoffice.org/68376 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-26Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Mute Pootle complain on reserved words Change-Id: I8e0832a8be6a5118aa1d8b306a250a87434088ca Reviewed-on: https://gerrit.libreoffice.org/68252 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-26Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - Name tag updates in links Change-Id: I88cdf6ea514ba98d45d90d59bc170f4c59938df6 Reviewed-on: https://gerrit.libreoffice.org/68382 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-26Removed executable permission on ODS fileAndrea Gelmini
Change-Id: I0d2318ea4176b301ec8e814e3de8816729bb6a51 Reviewed-on: https://gerrit.libreoffice.org/68381 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-26Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Removed executable permission on SVG file Change-Id: I6ff78e12c6d547f18e1808c79d32ef2d6ffa0037 Reviewed-on: https://gerrit.libreoffice.org/68380 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-26Fix typoAndrea Gelmini
Change-Id: If74c831e763b0067cc1e98d6bd3c8d2699d9891e Reviewed-on: https://gerrit.libreoffice.org/68366 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-26fix android build (2)Noel Grandin
after commit 589ce33041df5ca1c3f6d914d5d33d0fffb69f8f Date: Mon Feb 25 14:38:21 2019 +0200 sal_uIntPtr->sal_uInt64 in SalTimer::Start Change-Id: I0fe5d972d2acf90a98f6e0203c51e509a60920c1
2019-02-26Translate German variable namesJohnny_M
As in f2afa2af10d9d30d7160e73881ca6fe5a409f35a Change-Id: I617544ff00128ec3ff4bc4cff523db55f49c493a Reviewed-on: https://gerrit.libreoffice.org/68246 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-02-26oox smartart, picture strip: fix too many columns with aspect ratio requestMiklos Vajna
The bugdoc has 3 items in the picture strip and PowerPoint laid this out as a single column with 3 rows (as a snake algorithm). We used to put the first two items to the first row and the third item to the second row. Improve out layout by taking into account what aspect ratio the child algorithms request: this way it's obvious that we should use a single column in case we have a large enough aspect ratio and few enough items. (PowerPoint also uses multiple columns without the aspect ratio request.) Change-Id: I9f1158c04c665fc6a2c85e4ac3a1ed363b1c75fb Reviewed-on: https://gerrit.libreoffice.org/68370 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-26svdtrans: nPi -> M_PI; nPi180 -> F_PI18000 to remove duplicatesMike Kaganski
Change-Id: Ia2c103a5b530d007f750e4a034b253b3ec5406ec Reviewed-on: https://gerrit.libreoffice.org/68368 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>