summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-08Simplify some uses of dynamic_castStephan Bergmann
(SdrCaptionObj is derived from SdrTextObj, and SdrTextObj::SetVerticalWriting isn't shadowed anywhere along the derivation path to SdrCaptionObj, so dropping the dynamic_cast to SdrTextObj in the last block is fine.) Change-Id: I914a13cbdbeb4ba58f642c9696ef4ad456bc3322 Reviewed-on: https://gerrit.libreoffice.org/80451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-08tdf#125289 Use default colors from the new standard paletteGabor Kelemen
These look quite similar to the previous ones and we have translatable strings for them Change-Id: Ib40f4087830098341dcd32ce81673f6f187fe685 Reviewed-on: https://gerrit.libreoffice.org/77074 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-08Resolves tdf#127903 - Allow customization with equal keyHeiko Tietze
Change-Id: Ie5e1fc23412d13a868e021addb0de47d9e84f80b Reviewed-on: https://gerrit.libreoffice.org/80436 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-08implement gtk dialog screenshottingCaolán McNamara
Change-Id: If4e570f775bd1e29dfb75cb7e5dd9d9dfc35e654 Reviewed-on: https://gerrit.libreoffice.org/80416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-08tdf#124391 Fix doubled menu in global menuSamuel Mehrbrodt
Regression from 3bedbfd9b3cee5a8d2da6ee0486859bd725979ba Change-Id: I56473a2b0620f90f23b1bcde3ae1290801021038 Reviewed-on: https://gerrit.libreoffice.org/80367 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-08Fix CXX_BASE for clang-cl builds on WindowsStephan Bergmann
...where the configure messages confusingly mentioned cl.exe instead of clang.exe (but the actual checks correctly used $CXX being clang) Change-Id: I9e0c6e1ab8ba64c45f752b413c3e6c22182506ac Reviewed-on: https://gerrit.libreoffice.org/80442 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-08use cppu::WeakImplHelper in UniversalContentBrokerNoel Grandin
Change-Id: Iaeb88801faab2c9e45b19751ab44c0f800d3c5ec Reviewed-on: https://gerrit.libreoffice.org/80424 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08vcl: avoid downscale && upscale in DrawTransformedBitmapEx()Miklos Vajna
If we rotate a bitmap and put it to a metafile, we'll create a MetaBmpExScaleAction. But just because we need to store a transformed bitmap for rotation purposes, it doesn't mean we also need to scale it. This helps in case later the metafile is upscaled and the downscaled bitmap would look blurry. Change-Id: I7d64a88af460e80dffde8052186888eddbb440fe Reviewed-on: https://gerrit.libreoffice.org/80426 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-08tdf#128009: Allow spaces in AutoText suggestionsMike Kaganski
Currently autotext entries with long names starting with spaces, or containing spaces after first or second character, would never be suggested when SvxAutoCorrCfg::IsAutoTextTip() gives true (set in Tools -> AutoCorrect -> [x] Display remainder of name as suggestion while typing), because only a single word no less than 3 chars long left to cursor is considered a candidate for the name matching. This change allows to consider multiple chunks of text left to the cursor as the candidates for name matching. The chunks are 3-9 characters long, may start only between words, and have spaces, including leading. Thus, AutoText entries with long names like " Dr Foo" will now be suggested for an entry like "lorem dr f". Change-Id: If91c957341a4f4b281acb0e4ada558706ea2f8c1 Reviewed-on: https://gerrit.libreoffice.org/80392 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-08use cppu::WeakImplHelper in CommandProcessorInfoNoel Grandin
Change-Id: Ifbb2d50b1d88f0bceed38bddd23858a54b8527dc Reviewed-on: https://gerrit.libreoffice.org/80403 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in CachedDynamicResultSetStubFactoryNoel Grandin
Change-Id: Ide129bb5de11f967aa42d46704a0d00487fc5419 Reviewed-on: https://gerrit.libreoffice.org/80423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in ResultSetNoel Grandin
Change-Id: I9d6feef38532b0057e16fc3f25b0f285d3dfcb99 Reviewed-on: https://gerrit.libreoffice.org/80407 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in fileaccess::BaseContentNoel Grandin
Change-Id: I1a677ce5c3eed773c04709808d0d019a2f59585d Reviewed-on: https://gerrit.libreoffice.org/80425 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08New loplugin:classmemaccessStephan Bergmann
...to complement and improve upon GCC's -Wclass-memaccess. See the comment at the head of compilerplugins/clang/classmemaccess.cxx for details. (It is not yet clear to me whether we would want to get this upstreamed into Clang.) 35d21e4bf6f66b3bbc7a44fcf184cb721b524a94 "Remove redundant memsets" was a case that benefited from looking through toplevel casts to void*. (Though the code in include/basic/sbxvar.hxx needs a slightly more verbose way to deliberately silence the warning now.) d03041e19215592f21ba1222d3cfa29e1f94260a "Drop bogus memsets" is one example of various cases that GCC -Wclass-memaccess failed to catch due to the use of array instead of pointer types. Change-Id: I6a9bfc34e3536834af35fdf4fb7ceeb31f31f8c0 Reviewed-on: https://gerrit.libreoffice.org/80421 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-08More generated files to take care ofStephan Bergmann
Change-Id: I4a150389e42959bb8e522dbf488eda24ac934f00 Reviewed-on: https://gerrit.libreoffice.org/80422 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-08Tip of the day randomizedHeiko Tietze
Necessary because of serial presentation after I69b72b80d6d6afa25a1c4f01fa05bc60b5741db8 Change-Id: I26d2a08442b91c11ec7d9c4addaaad764e7f3ba9 Reviewed-on: https://gerrit.libreoffice.org/80371 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-08update help text of --disable-guiAndras Timar
Change-Id: Idd01b11acee3683bbc3d81d0c2ccf8be6c4fbb69 Reviewed-on: https://gerrit.libreoffice.org/80428 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2019-10-08remove leftover debug output in configureLuboš Luňák
Change-Id: If2b1d7ca89f30544c4e8750119927701f9df5264
2019-10-08tdf#127825 DOCX import: fix handling for tbrl, auto-height and rel size shapesMiklos Vajna
Regression from commit ff17478e069cc82681df62514876c06365dd5cd6 (sw btlr writing mode: implement DOCX shape import for tbrl, 2019-04-25), there were two problems here: 1) Relative size currently only works properly for the lrtb direction, so disable that during import till sw core is improved. 2) When SwFlyFrame::Format() auto-grows a text frame which is the textbox of a shape, it needs to notify the shape about the physical size of the frame, not the logical one. So going via the SwRectFnSet abstraction is not correct in this case. Change-Id: Ie185c7415d90594434eac8f459630d6a3212328a Reviewed-on: https://gerrit.libreoffice.org/80398 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-08cleanups in xmlreaderNoel Grandin
(*) fix order of headers (*) include the right headers in span.hxx (*) use std::memcmp instead of memcmp (*) clear entries from cache when the namespaces array is resized Change-Id: I04319bbaa84369e5470799578fadcda66a591c9f Reviewed-on: https://gerrit.libreoffice.org/80347 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in CachedDynamicResultSetFactoryNoel Grandin
Change-Id: Ia13306a3059678ef306835b8641a26200f9ae420 Reviewed-on: https://gerrit.libreoffice.org/80414 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in CachedContentResultSetStubFactoryNoel Grandin
Change-Id: Ic0fb9aa44fefc9377ead2d815be0f522eaf8cb33 Reviewed-on: https://gerrit.libreoffice.org/80413 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in CachedContentResultSetFactoryNoel Grandin
Change-Id: I1575e051fe963a4bf73453a7e6b89c9c891d1ff9 Reviewed-on: https://gerrit.libreoffice.org/80412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in ScDataPilotDescriptorBaseNoel Grandin
Change-Id: I16f7ba16f08c186bbdb32af5206089c497e1c8c1 Reviewed-on: https://gerrit.libreoffice.org/80411 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in ScCellRangesBaseNoel Grandin
Change-Id: Ic1f380ef1ace1e3d57853e070e00c91a19d831db Reviewed-on: https://gerrit.libreoffice.org/80410 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in ResultSetMetaDataNoel Grandin
Change-Id: I28df6cd28ca099bb1a07c18a35eebd5529e094e9 Reviewed-on: https://gerrit.libreoffice.org/80409 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in ResultSetImplHelperNoel Grandin
Change-Id: If82ae3f5cee0ae893fd32ecafe3c7baf7ec00ed4 Reviewed-on: https://gerrit.libreoffice.org/80408 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in ContentProviderImplHelperNoel Grandin
Change-Id: I1b2c4a296de6d1d6769f9e82380d1b45d506daca Reviewed-on: https://gerrit.libreoffice.org/80406 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in PropertyValueSetNoel Grandin
Change-Id: I48b0292207a88234290ffc9a3ca5585ee9b924e3 Reviewed-on: https://gerrit.libreoffice.org/80405 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in InteractionRequestNoel Grandin
Change-Id: I5f79ac795d17158c3e74aa76baf8483892cec920 Reviewed-on: https://gerrit.libreoffice.org/80404 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08loplugin:redundantpointerops simplify *p.get()Noel Grandin
Change-Id: I12517651fb3f777fd08e384992bb3e84b340ad85 Reviewed-on: https://gerrit.libreoffice.org/80382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in PropertySetInfoNoel Grandin
Change-Id: I4da5d73ee7b531927066a1a4d4d7561ef9648483 Reviewed-on: https://gerrit.libreoffice.org/80402 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in ContentIdentifierNoel Grandin
Change-Id: Id9c0d5d1f69c516efdf45b070982bdf341e86ce8 Reviewed-on: https://gerrit.libreoffice.org/80401 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in VCLXRegionNoel Grandin
Change-Id: I93bb52b35b4c15dc93d7638d7fc1e00652a2a1e7 Reviewed-on: https://gerrit.libreoffice.org/80400 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08use cppu::WeakImplHelper in VCLXBitmapNoel Grandin
Change-Id: I789646591caca8ee164d32e07b050b862f627973 Reviewed-on: https://gerrit.libreoffice.org/80385 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-08Let WW8_TCell zero-initialize its membersStephan Bergmann
...which removes the need for WW8TabBandDesc::setcelldefaults and its dubious memset operating on a non-trivial type (as WW8_TCell has WW8_BRCVer9 data members, which in turn has a user-provided default ctor) Change-Id: Iabb02e353387f4fc2a002578b1b2b116d2f7313c Reviewed-on: https://gerrit.libreoffice.org/80394 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-08Add some doc and fix comment in eppt (sd)Julien Nabet
See https://docs.microsoft.com/en-us/openspecs/office_file_formats/ms-ppt/6be79dde-33c1-4c1b-8ccc-4b2301c08662 " 2.6.1: A - fAutoAdvance (1 bit): A bit that specifies whether to automatically advance to the next slide during a slide show based on timing information on the slide. B - fWillSkipBuilds (1 bit): A bit that specifies whether to display animations during a slide show. C - fUseSlideRange (1 bit): A bit that specifies whether to display only the slide range specified by the startSlide and endSlide fields during a slide show. D - fDocUseNamedShow (1 bit): A bit that specifies whether the slides shown during a slide show are from the named show identified by namedShow. It MUST be ignored if fUseSlideRange is TRUE. E - fBrowseMode (1 bit): A bit that specifies whether the slide show is presented in a way optimized for browsing. If fBrowseMode is TRUE, fKioskMode MUST be FALSE. F - fKioskMode (1 bit): A bit that specifies whether the slide show is presented in a way optimized to run at a kiosk. If fKioskMode is TRUE, fBrowseMode MUST be FALSE. G - fWillSkipNarration (1 bit): A bit that specifies whether to play slide audio narrations during a slide show. H - fLoopContinuously (1 bit): A bit that specifies whether to restart the slide show at the beginning after advancing from the last slide. I - fHideScrollBar (1 bit): A bit that specifies whether to display the navigational scroll bar during a slide show. " So yes, "IsEndless" corresponds to "fLoopContinuously" Document "Skip narration" + "show scrollbar" corresponds to Bit 8 (the contrary of "fHideScrollBar") so since this the Bit 8 of nFlags isn't set, it's always to 0, so we always show scrollbar Change-Id: Ifb4f62a9f52cdafac9f788f4d6d1deb0cf1b8efa Reviewed-on: https://gerrit.libreoffice.org/80415 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-08Simplify if/else and remove useless assert in undoobj.cxx (sw)Julien Nabet
791 else if( pEndNdIdx || !pTextNd ) corresponds to the negation of the if condition: 767 if (!pEndNdIdx && pTextNd) So remove existing "else" block and replace "else if" by "else" Change-Id: I9681f97fdbaece7495d4765617a2634b0cc8f2e3 Reviewed-on: https://gerrit.libreoffice.org/80399 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-08tdf#126589: only consider text to the left of cursor as AutoText short nameMike Kaganski
Given a text "This is a dtfoo bar", and cursor inside "dtfoo" between "t" and "f", invoking AutoText function (F3) currently considers the whole word "dtfoo" as autotext short name. This changes it to only consider the part of the word to the left of cursor, i.e. only "dt" in the example. This removes the requirement to have a word boundary after the autotext short name. Change-Id: I6ba28e63fe25664131b7e03dda39ae997dffa464 Reviewed-on: https://gerrit.libreoffice.org/80419 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-07Add a SAL_INFO for SwVbaDocument::SaveAs2000()Tor Lillqvist
Change-Id: Ic91b9c3a832d68ca3ccc61ccb19b0e29b488abc0 (cherry picked from commit 6412701313a875aff199dbf862e250faf6861cd0) Reviewed-on: https://gerrit.libreoffice.org/79256 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 30f25672a86494625d525086d0a81513db119917) Reviewed-on: https://gerrit.libreoffice.org/80377 Tested-by: Jenkins
2019-10-07Add a SAL_INFO for SwVbaDocuments::Open()Tor Lillqvist
Change-Id: I0c62864f3efa53dde0dc78482d8e9c7ffc35b6ee (cherry picked from commit 0993ccb56eba6e52d5b3b00f60ea069571f2554a) Reviewed-on: https://gerrit.libreoffice.org/79255 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 3df903c1e572cf010b71ff6cce8acc3d6174a0b9) Reviewed-on: https://gerrit.libreoffice.org/80376 Tested-by: Jenkins
2019-10-07use cppu::WeakImplHelper in VCLXGraphicsNoel Grandin
Change-Id: If862818ef3eb534493ac61d5071ec1adf590ebf2 Reviewed-on: https://gerrit.libreoffice.org/80388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-07hidpi cursors for macOSNoel Grandin
Change-Id: I39bdc93048733627a54c4f7b4b2e7df4f073ef25 Reviewed-on: https://gerrit.libreoffice.org/67424 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-07make the clang plugins configure check fasterLuboš Luňák
Use a header which is not so expensive to parse/compile. Change-Id: I4197fb16938b19c18fed541dbf94bf2c97a60e66 Reviewed-on: https://gerrit.libreoffice.org/80301 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-07try to autodetect flags needed to build Clang pluginsLuboš Luňák
Instead of having a lot of it hardcoded, which brings problems like: - Clang-to-be-10 has switched to -std=c++14, so our hardcoded c++11 makes the build fail - I cannot compile with my openSUSE-shipped clang, because it ships only libclang-cpp and not the other libClangSomething libs The possibility to explicitly set the necessary variables is still there. Change-Id: I58d401d4584fa064f1c1351a8a06ff4e29643063 Reviewed-on: https://gerrit.libreoffice.org/80300 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-07fix various warnings in compilerpluginsLuboš Luňák
These are triggered when using llvm-config --cxxflags for building, and sometimes there's -Werror. The warnings were mostly unused variables because of being used only in assert(), or default case in switch that covers all enums (it's better to not handle default to get warning if a case is not handled). Change-Id: I0ecdd1f27390aadf033852b0d1ee0ca424ae3c37 Reviewed-on: https://gerrit.libreoffice.org/80317 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-07generate make dependencies also for clang.pchLuboš Luňák
Change-Id: Id05f2741763ef0d9e87d9804339d29aee6bc068f Reviewed-on: https://gerrit.libreoffice.org/80380 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-07handle more -arch: options when avoiding D9025Luboš Luňák
Change-Id: I97ff0418e25aeaea4cae349f2d228fb35219b5c2 Reviewed-on: https://gerrit.libreoffice.org/80374 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-07use FileDialogHelper which is able to set parent easilyCaolán McNamara
Change-Id: I0389311323175fbbc58ee0b9fbb6353061b21e2f Reviewed-on: https://gerrit.libreoffice.org/80395 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07use FastParser in linguisticNoel Grandin
Change-Id: Iee2254dc13ccc31d266009ba1eb00f2517484cc7 Reviewed-on: https://gerrit.libreoffice.org/79814 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-18 02:24:52 +0000