summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-06-01desktop: fix misformatted makefile lineMichael Stahl
(regression from 99b7c4f57d7fe3cac772cce38e2dd6879e128315) Change-Id: I2c3c0478a12e86d78074a8e1b25818de32d4b091
2017-06-01sw RTF export: remove redundant virtual keywordsMiklos Vajna
Change-Id: Iabc62f8166cb4f2013fc6c2908c8172f9acb0336 Reviewed-on: https://gerrit.libreoffice.org/38294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-01remove overly large loplugin result fileNoel Grandin
should not have been committed in the first place, was an accident Change-Id: Ie38cc77624bae5b3f9cc110085d0fe19b26c75c6
2017-06-01tdf#108024 Keep original selection during DrawViewShell::FuTemporary()Takeshi Abe
Otherwise it was disposed in the middle of its own mouse event handler FuSelection::MouseButtonUp(). Change-Id: I0d96048526dece7232e5a777364ad4da1d64c904 Reviewed-on: https://gerrit.libreoffice.org/37976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-01Fix typosAndrea Gelmini
Change-Id: I3cd50e374c45bc1c400b24c8fffd6d8f5cd1de56 Reviewed-on: https://gerrit.libreoffice.org/38208 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-01Fix typosAndrea Gelmini
Change-Id: Ic7fbd750321e4cfde1cfb0e04ffb545bb1f66d9c Reviewed-on: https://gerrit.libreoffice.org/37921 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-01Avoid "default initialization ... without ... default constructor" errorStephan Bergmann
Change-Id: Ic336b33bd747cd55955231cbe0b5a9d474adf3ab
2017-06-01writerfilter: remove unused variable pFontTableJustin Luth
Change-Id: If48795746adecf6762a5f1173171c62faf1ac345 Reviewed-on: https://gerrit.libreoffice.org/38290 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-01clang-tidy misc-string-compareNoel Grandin
Change-Id: Ic5250563b7dc9c19771d3f728d2087ef335ceb46 Reviewed-on: https://gerrit.libreoffice.org/38279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-01tdf#99680 modified clipping for PDF exportVasily Melenchuk
If clipping is requested, but no clipping region is defined, clipping is ignored. Change-Id: I793c1de1f4f6b0203727c0ff6aa8adecc43ad413 Reviewed-on: https://gerrit.libreoffice.org/38021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-05-31Remove some unnecessary scaffolding around SAL_WARN callsStephan Bergmann
Change-Id: Iaec105d85a283ad15fdca6ffc5cf3d2ec5acac18
2017-05-31Add some loplugin:redundantcast testsStephan Bergmann
Change-Id: I5c39a745b70655f92953ec785d01a3a52d9ec42b
2017-05-31tdf#36019: Fix tooltipMuhammet Kara
Change-Id: I8c1a01fa54addfdf78eaff45952e306de812e954 Reviewed-on: https://gerrit.libreoffice.org/38128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Tested-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-05-31Resolves: tdf#108225 there are *two* possible .ui files for change trackingCaolán McNamara
the change-tracking side bar in experimental mode as well as the usual dialog Change-Id: Ic4d652d0d125b883bef0d91e4ab3cee4a9f84284
2017-05-31basegfx: remove global IdentityMatrix thread safety hazardMichael Stahl
ASAN reports this about JunitTest_chart2_unoapi ==27381==ERROR: AddressSanitizer: heap-use-after-free on address 0x6060005bd218 at pc 0x7ff229755271 bp 0x7fffb52c6c30 sp 0x7fffb52c6c28 READ of size 8 at 0x6060005bd218 thread T0 #0 0x7ff229755270 in o3tl::UnsafeRefCountingPolicy::decrementCount(unsigned long&) include/o3tl/cow_wrapper.hxx:41:68 #1 0x7ff2297551bf in o3tl::cow_wrapper<basegfx::Impl2DHomMatrix, o3tl::UnsafeRefCountingPolicy>::release() include/o3tl/cow_wrapper.hxx:203:29 #2 0x7ff2297515f0 in o3tl::cow_wrapper<basegfx::Impl2DHomMatrix, o3tl::UnsafeRefCountingPolicy>::~cow_wrapper() include/o3tl/cow_wrapper.hxx:248:13 #3 0x7ff242ef440f in __run_exit_handlers (/lib64/libc.so.6+0x3a40f) #4 0x7ff242ef4469 in __GI_exit (/lib64/libc.so.6+0x3a469) The reason appears to be the UnsafeRefCountingPolicy on the global IdentityMatrix, so every B2DHomMatrix that is created on any thread will manipulate the refcount of that global without synchronisation. Let's just remove the global and hope the extra allocations don't matter. Change-Id: I4962ab2e622286f29b912a57448f3f1a53eeb592
2017-05-31macro warning dialog grew an extra Cancel buttonCaolán McNamara
since... commit bcad173faaffd3a3c1e6737d94d2108cf590338d Date: Wed Feb 8 11:12:00 2017 +0200 Reapply "create ErrorHandlerFlags scoped enum for error handling flags"" This effectively reverts commit 32cae6a2eaa41568888df9c8fc5605debd8d704a. Change-Id: Ice41023bc741af46db3018bbb0eb08b4a339987e
2017-05-31tdf#76446 GSoC: incorrect rotation of VML shapesGrzegorz Araminowicz
* support poorly documented 'fd' suffix in rotation attribute * allow non-integer rotation Change-Id: I3d72f2a708e6585597db09366c00c50038abc9c1 Reviewed-on: https://gerrit.libreoffice.org/38207 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-05-31disambiguate dual use of toolbar idsCaolán McNamara
for toolbar title string resource and identifier (for config) Change-Id: I2657c3cbb586a62d8075db7cb43cc064b2030f28 Reviewed-on: https://gerrit.libreoffice.org/38274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-31tdf#108072: match sprmTFCantSplit with its correct idAron Budea
The behavior was adjusted with 72ef0d88e916b320de85fe2ebf08cb7aea28ca08 , but the ids for sprmTFCantSplit90 and sprmTFCantSplit remained mixed up. Change-Id: Ic97224a3af39e5df707a6dba59b785580c17b739 Reviewed-on: https://gerrit.libreoffice.org/38117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-05-31tdf#108259 Enable autofilter with many different valuesJean-Sebastien Bevilacqua
When you create an autofilter on a column which contains many different values, you will have problems. First of all, if you exceed 65535 values, you will enter in an infinite loop because a uint16 is incremented for each value, and after 65535, you restart to 0. Secondly, the algorithm executes a double loop in O(n2) to determine checked values, it's too long. Instead of that, all checked values can be determined before. This patch is graciously offered by Linagora. Change-Id: Idc4500f6a496ae789aae11eb0e183aee157daa20 Reviewed-on: https://gerrit.libreoffice.org/38269 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-31Updated coreGabor Kelemen
Project: help ca78b4f149dd82723a3b53a93063c881096fa71f Fix bookmarks and ahelps on Chinese Conversion dialog page Add missing bookmarks Remove unnecessary ahelps Sync label spelling with UI Change-Id: I5240d1386ef3abd716c6e6647b50c96a21555a65 Reviewed-on: https://gerrit.libreoffice.org/38244 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-05-31Updated coreGabor Kelemen
Project: help 78472fa975bce0b4bb26bce0cad6c15c910e8361 tdf#107299 Fix reference to File - Templates menu item Change-Id: Iae0120954fc7ac7a1748ece724eb4c6ddd3321b7 Reviewed-on: https://gerrit.libreoffice.org/38243 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-05-31Updated coreGabor Kelemen
Project: help 5cb25526e443e7492414ec27254843826de194cd Fix bookmarks and ahelps on 3D-Settings toolbar page Remove duplicate bookmarks Remove unnecessary ahelps Change-Id: I986b3e8dfc5aa9c00c5414ab41845060ff43d709 Reviewed-on: https://gerrit.libreoffice.org/38242 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-05-31xmlsecurity: try to appease --as-needed default ldMichael Stahl
Change-Id: I11a7894cb71732e613ae430c128ce06becb4defb
2017-05-31lok: impress: add support for undoing comment editingMarco Cecchetti
Conflicts: sd/source/ui/annotations/annotationmanager.cxx Change-Id: I735dd68d658f007ddd44d6acf692ee9b4555eb53 Reviewed-on: https://gerrit.libreoffice.org/37816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-05-31lok: impress: undoing comment deletion doesn't workMarco Cecchetti
Change-Id: I3399ea4131acde42bdd307a8438a9129a83817f2 Reviewed-on: https://gerrit.libreoffice.org/37815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-05-31The updated values of t1, t2 are unusedStephan Bergmann
...since f1bbda1c26dc16642038ea70288eec60b43520b6 "loplugin:cstylecast: deal with remaining pointer casts" Change-Id: Idecc702344c674e6f39051e4f8c2114017e317cb
2017-05-31tdf#104219 Don't export color information when color is automaticBartosz Kosiorek
In LibreOffice and MS Office, there are two types of colors: - Automatic (which is taken from settings) and Fixed (which is set by RGB value). OOXML is setting automatic color by default, by not providing any RGB color. To preserve automatic color we need to not export RGB color during OOXML export. Change-Id: I8895230c4fffc9d8741f3eff37e64c4823d71da8 Reviewed-on: https://gerrit.libreoffice.org/37970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-31Updated coreAdolfo Jayme Barrientos
Project: help 67fbb19423c95a5d0d4439db96bc740036a33200 Grammar (is → are) Change-Id: I16042693a842430ecc7a880118321205f8aed732
2017-05-31writerfilter : remove dead code with m_sFootnoteFontNameJustin Luth
The string variable is never initialized or set, and the only use is if it is not empty. In 2007, author Oliver Specht 2007-06-12 04:41:16 in range fe8e4e774087465a10ecd8f366b7f0c272d8319a introduced m_sFootnoteFontName in a pair of commits. The call to SetFootnoteFontname() was removed in 2008 with commit 009e3f4841378f13a2764a2c84e147e401b70525 The SetFootnoteFontName() function was removed as unused in commit 6ea66657ebca5b3ec63f93b496b812888e0d53c9 Since the footnote name is never set, it is always empty, and thus this code is useless. Change-Id: I64898ce9fa6673fbef0106054b5aa5a817c145d5 Reviewed-on: https://gerrit.libreoffice.org/38257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-31Avoid implementation-defined behavior when mapping non-ASCII charactersStephan Bergmann
...into the basic source character set (translation phase 1) and then into the execution character set (translation phase 5). Change-Id: I3d40bb9c2a64bc62c04db0fbe09408b1911893c8
2017-05-31No need for additional pDlg variableStephan Bergmann
Change-Id: I161b49ee5c72c13372ca95ce9f9cc87d886354ae
2017-05-31Guard against ScopedVclPtr "self assignment" (just in case)Stephan Bergmann
Change-Id: I12bbfbc6701e4e666d30dcf89c17be8f1a5d6858
2017-05-31DataRecursionQueue was only introduced in Clang 3.8Stephan Bergmann
(r253948 "Use data recursion in RecursiveASTVisitor when traversing Stmt and Expr nodes") Change-Id: I393474048ecbe0f6b7f19f00c2f830f495b2b6f0
2017-05-31sw RTF export: fix indentationMiklos Vajna
This file had a consistent style before, let's keep it that way. Change-Id: I3330123f8887bc17ed96518b21d748fc3f2fc958
2017-05-31tdf#86776 Digitally sign soffice.bin on WindowsAndras Timar
Change-Id: I79e223f7ac8367a22668c015afddafe1c8b8cd42 Reviewed-on: https://gerrit.libreoffice.org/38246 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-05-31libxmlsec: drop no longer needed xmlsec1-nssdisablecallbacks.patch.1Miklos Vajna
Before the gbuild conversion in commit ec6af4194e80f5f0b2e46ca59802ff397a2a4a24 (convert libxmlsec to gbuild, 2012-11-29) the makefile.mk had a comment for this patch: "Disable use of smime3 so don't need to package it". Today smime3 is packaged (see external/nss/ExternalPackage_nss.mk), so patching xmlsec is no longer needed. Change-Id: I73ec13ee92a1860f5dc3cbeed0e51d42a0320baa Reviewed-on: https://gerrit.libreoffice.org/38239 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-05-31clang-tidy readability-redundant-string-cstrNoel Grandin
and readability-redundant-string-init Change-Id: I7b25659ace9e1d5be042ec5e179f01191693334e Reviewed-on: https://gerrit.libreoffice.org/38225 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-31clang-tidy readability-redundant-control-flowNoel Grandin
Change-Id: I832f7ef0f1bd55e365db7e49823fe8bc30390c04 Reviewed-on: https://gerrit.libreoffice.org/38215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-31simplify OSQLScanner::SQLyyerrorNoel Grandin
...buffer management Change-Id: I649a93ed5bd9bd7d4ac8ec73fc956eb8532eac89 Reviewed-on: https://gerrit.libreoffice.org/38206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-31tdf#107797 select all entries in the dropdownSzymon Kłos
Change-Id: I3ee33040744eab35f841d3622cb8981b49d04333 Reviewed-on: https://gerrit.libreoffice.org/38091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-05-30Related: tdf#107961 ensure notifyhdl is unset after disposeCaolán McNamara
Change-Id: I69790c8d3cfffc09ee6d6c165e17823223c5058a Reviewed-on: https://gerrit.libreoffice.org/38205 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-30tdf#106950 sw: support CharShadingValue property on paragraph stylesMiklos Vajna
Regression from commit 26d40686128e70916a636e20f5ccc5763bbb6cc8 (fdo65400: fix for Character Shading being lost, 2013-06-23), though much more visible since commit a9e029ace41562e28e9242d63230ad1ca275f5d3 (tdf#104744 RTF import: fix unexpected zero para left margin wrt style dedup, 2017-01-03), when I fixed the RTF filter to not duplicate the "align paragraph to center" paragraph style property as a direct formatting as well. The problem was that the CharShadingValue property was not added as a paragraph style property, while in general all character properties are also allowed on paragraphs and paragraph styles as well. Change-Id: If1bdad96e45adc545a81a1f550ab7ccb3591c4f6 Reviewed-on: https://gerrit.libreoffice.org/38210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-05-30remove duplicate 'using namespace'Jochen Nitschke
Change-Id: I7f8828f677cfb588135ff75c03ffb75895773440 Reviewed-on: https://gerrit.libreoffice.org/38201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30sal,external: remove checks for obsolete VCVER=120Michael Stahl
Change-Id: I4d32b7c4b2e545a8d979bc516f64cfcbf66ecd07
2017-05-30python3: remove obsolete python-3.3.3-msvc2012-winxp.patch.1Michael Stahl
...and python-3.3.0-msvc2012.patch etc. They were actually never applied to Python 3.5. Change-Id: I5beb5a81d55ab1921411d2351bdb397ff02ba75c
2017-05-30openssl: remove Windows XP patchMichael Stahl
Change-Id: I6e80c33d134100235ac1007154ca7f6151b59c2f
2017-05-30nss: remove obsolete nss-winXP-sdk.patch.1Michael Stahl
Change-Id: I044be3b53134081bcbdbfd6fd252d6851d3dba41
2017-05-30curl: remove curl-xp.patch.1Michael Stahl
Change-Id: I329289c97b857370852c982a8b74b739b9ac3d78
2017-05-30gbuild: stop defining _USING_V110_SDK71_Michael Stahl
Change-Id: Ic8eee967269b3666b15795f20ee62817dadfb0ff