summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-04-04loplugin:redundantcast (clang-cl)Stephan Bergmann
Change-Id: Ie096d75c1bc774e77c589845f61276d1478234ef Reviewed-on: https://gerrit.libreoffice.org/36065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04loplugin:loopvartoosmall (clang-cl)Stephan Bergmann
Change-Id: Ibdfdc5c66cf1e81d9e43c94df31120c476a78572 Reviewed-on: https://gerrit.libreoffice.org/36064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04loplugin:redundantinline (clang-cl)Stephan Bergmann
Change-Id: I03a19b599005f6ef25040889a1e1802445ebf430 Reviewed-on: https://gerrit.libreoffice.org/36063 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04cid#1403658: Let ImplGetLocale return empty Optional for bad inputStephan Bergmann
...like non-ASCII or too-long env var content on Linux Change-Id: Ic2c536fa92b88108e96a0fc1a657180bc1906f01 Reviewed-on: https://gerrit.libreoffice.org/36067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04ofz: guard against bogus sprm lenCaolán McNamara
Change-Id: I9b4074e1024753549f468f427afbfdf9cd01b674
2017-04-04coverity#1403732 Mixing enum typesCaolán McNamara
and coverity#1403735 Mixing enum types coverity#1403737 Mixing enum types Change-Id: I278b7d5116d4157e6aa4483d8eef42325e4bc03b
2017-04-04just use one try/catch levelCaolán McNamara
Change-Id: I298f84df5431f0f77144db95bf2305f49e7f9302
2017-04-04Resolves: ofz#727 don't allow negative sizes or indexesCaolán McNamara
remove extra size in favour of vector size and don't resize and memcpy data, just use vector::insert Change-Id: I8efb91a8c11fbd862c0458042554cf7e94b813cd Reviewed-on: https://gerrit.libreoffice.org/34891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-04ofz#820 oom terminateCaolán McNamara
comments claim return is len of data, but negative numbers for compressed data errors are returned. Make things return the amount of successful data read and turn into unsigned size_t to match ofz#727 Change-Id: Iadddfae67bb5d4960ddf82e169fc2592ded85950 Reviewed-on: https://gerrit.libreoffice.org/35077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-04tdf#106938 TSA Dialog: Improve Dialog LayoutThomas Beck
Moved Label above the content area Change-Id: I0a23af5540bedc849c83fd342ac43538827e6b4a Reviewed-on: https://gerrit.libreoffice.org/36071 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-04tdf#105162: Need to call epoxy_handle_external_wglMakeCurrent()Tor Lillqvist
Somewhere, in time before calling epoxy-wrapper OpenGL functions. This seems to be a good place. Educated guess based on debugging, turned out to work. Change-Id: Id3f1dfb0c5a9dbfb166c47ea81db902af1a4fc08
2017-04-04Revert "tdf#105162: Need to call epoxy_handle_external_wglMakeCurrent()"Tor Lillqvist
It worked (for the specific case in the bug report), but for a more generic fix that covers also other similar cases (where VCL code gets called in threads that epoxy doesn't know about, or something), it's better to call epoxy_handle_external_wglMakeCurrent() in vcl, instead of all over the place in thread callbacks. This reverts commit 78c67c6bbba0eaa418c573637858828b274b3c72. Change-Id: Iaad7b3d1191847b9d3f1e74c3339de9f16194aed
2017-04-04tdf#106690 DOCX import: fix automatic spacing before/after numbered para blockMiklos Vajna
The context is text nodes with automatic before/after spacing and numbering rules set, like: A * B * C * D E The correct behavior seems to be (though I haven't found this explicitly written in the OOXML spec) to drop spacing between B and C and C and D, but not before B and not after D. Originally no spacing was dropped, then commit c486e875de7c8e845594f5043a37ee8800865782 (tdf#95031 DOCX import: auto spacing inside numbering means no spacing, 2016-10-18) removed spacing around all B/C/D. Fix the problem by checking the numbering rules and automatic after spacing of the previous paragraph, so spacing before B and after D is not removed. Change-Id: Icbdb36e31057ab0e8ac033888cf5cc7c52dad5d0 Reviewed-on: https://gerrit.libreoffice.org/36062 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-04tdf#105162: Need to call epoxy_handle_external_wglMakeCurrent()Tor Lillqvist
... in SourceContext::fire_dragDropEnd, it seems, because it runs in a thread in its own. Educated guess based on debugging, turned out to work. Change-Id: I084a1af30b1f7e157aafdb2d95866d767fc0f8d6
2017-04-04oox: -Werror=formatMichael Stahl
Change-Id: I9036335c812992946e3164e517cbe7296b98759b
2017-04-04typo fixAndras Timar
Change-Id: Ic8a62b0e241f740d3f1352fe48c8405570bfc61a
2017-04-04ofz: check anldPap sprm for valid ANLD payload lenCaolán McNamara
Change-Id: Ie034e3b37e01c29cf19fe8ad78b1121f6eadecb2 Reviewed-on: https://gerrit.libreoffice.org/36053 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-04Adding other spec-files to READMEdennisroczek
Change-Id: If6e28474a234dc1ca01d927a2a6c1f1a51f430c7 Reviewed-on: https://gerrit.libreoffice.org/36044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-04sw: indentation fixesMiklos Vajna
Nested namespaces were always declared in new lines in these files, let's keep the consistency. Change-Id: I1dcfdd2b1f54ec56b3554f3c0095513cec33e49c
2017-04-04Fix buildStephan Bergmann
Change-Id: Ic6644d03a7d6dd41422731d0b4015df831752087
2017-04-04loplugin:unusedmethodsNoel Grandin
Change-Id: I30f9b6e68a7aa73782c980749e34f8f8d40ae57b Reviewed-on: https://gerrit.libreoffice.org/36047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04make UNO enums scoped for internal LO codeNoel Grandin
this modifies codemaker so that, for an UNO enum, we generate code that effectively looks like: #ifdef LIBO_INTERNAL_ONLY && HAVE_CX11_CONSTEXPR enum class XXX { ONE = 1 }; constexpr auto ONE = XXX_ONE; #else ...the old normal way.. #endif which means that for LO internal code, the enums are scoped. The "constexpr auto" trick acts like an alias so we don't have to use scoped naming everywhere. Change-Id: I3054ecb230e8666ce98b4a9cb87b384df5f64fb4 Reviewed-on: https://gerrit.libreoffice.org/34546 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04starmath: Simplify code parsing nospaceTakeshi Abe
This also comes with its unit test. Change-Id: I1478bf48c5522691978e3534c9c8a9c0ddfc1e59 Reviewed-on: https://gerrit.libreoffice.org/35985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-03tdf#39468 Translate German commentsJens Carl
Translate German comments and terms in sc/source Change-Id: I8d1fa7c2d07512376ad186c55a13322b6219237f Reviewed-on: https://gerrit.libreoffice.org/36015 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-03ofz#721 use vector::at to check indexCaolán McNamara
Change-Id: I786b5d6fb10afe3ebb8482f999115fe72ffe2d4c Reviewed-on: https://gerrit.libreoffice.org/34851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-03ofz: check anlv text boundsCaolán McNamara
Change-Id: I6288aae2d439cde6a2b95c005a2090f73e21bb7a
2017-04-03ofz: avoid oomCaolán McNamara
Change-Id: Icbd4b98e8a0a4aff967bae22f3f59248ed40598a Reviewed-on: https://gerrit.libreoffice.org/36049 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-03tdf#39468 Translate German commentsJens Carl
Translate German comments and terms in UnoControls/, editeng/, filter/, odk/, reportdesign/, sd/, sfx2/, starmath/, svl/, svtools/, toolkit/, tools/, writerfilter/, and xmloff/. Change-Id: Ibc401a425ddfdf41e4e4a78600f3fbce8cfaa2b1 Reviewed-on: https://gerrit.libreoffice.org/35992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-03Remove DBG_ASSERT since it's always wrongJulien Nabet
Indeed EditHTMLParser constructor calls HTMLParser constructor, the last one calls "SetSrcEncoding(RTL_TEXTENCODING_UTF8);" Change-Id: If749674c3d4f2b9f9fccbf0b99f1e7d62fd0450d Reviewed-on: https://gerrit.libreoffice.org/36011 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-03sw: [loplugin:sallogareas]Michael Stahl
Change-Id: I94c552e4b2ae95f57b0c667f6072664eab570042
2017-04-03More integer clean-upStephan Bergmann
...after dbaab58c1442e7f62ef0732376fe5a49840e9fd6 "loplugin:loopvartoosmall". Looks like SwLayHelper::nIndex only needs to be initialized to a very large value (so that 'nIndex < pImpl->size()' will be false), not USHRT_MAX exactly. Change-Id: I209faa00894783c468db1440f5663ea9e8ad3e19
2017-04-03vcl: avoid divide by zero in PDFExtOutDevData::HasAdequateCompression()Miklos Vajna
My stub graphic import filter created a graphic with 0 data size, don't crash on that. Change-Id: Ie9b93fce1bcae04d555a0610f674603c6945a54a Reviewed-on: https://gerrit.libreoffice.org/36048 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-03only convert used part of bufferCaolán McNamara
Change-Id: I133a02ae1cbdb4fb32f81db7214d27c66ccd0a8b
2017-04-03don't check on every loopCaolán McNamara
Change-Id: I000a887925db63b5717cc0d062d9da623415f7cc
2017-04-03loplugin:unreffunStephan Bergmann
Change-Id: I7a4fe7240e43faaae3482a084b466fa87e67b6b8
2017-04-03flush writer fontcache after TestImportDOCCaolán McNamara
to get around leak sanitizer Change-Id: I45f0caefc14c35476e92887058031dddd92afb81
2017-04-03iOS update for Rectanglejan Iversen
Updated Rectangle to tools::Rectangle Change-Id: I1577dffe8d51ac3a33bbc2e0771b338d5fdd0220
2017-04-03these are file urls, so don't need ucbCaolán McNamara
Change-Id: I25beaeab002db1de34be3b5f4a774bd15b71f5d3 Reviewed-on: https://gerrit.libreoffice.org/36045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-03loplugin:loopvartoosmallStephan Bergmann
Change-Id: Ief96de6eb6f6276681130a6d16c767ab8ceaa3f1
2017-04-03loplugin:sallogareasStephan Bergmann
Change-Id: Idd4f44b66e67d938a1ba2b9c7ff4be0b0009ff53
2017-04-03tdf#106237 sw: do some basic sanity checking on layout-cacheMichael Stahl
The bugdoc, with claimed generator AOO4.1.1 on Windows, contains a bogus layout-cache: debug:26706:1: nType P nIndex 29 2147483647 debug:26706:1: nType P nIndex 66 2147483647 debug:26706:1: nType P nIndex 105 2147483647 debug:26706:1: nType P nIndex 142 2147483647 debug:26706:1: nType P nIndex 178 2147483647 debug:26706:1: nType P nIndex 205 2147483647 debug:26706:1: nType P nIndex 229 2147483647 debug:26706:1: nType T nIndex 314 65535 Due to a loop-control this causes incorrect pagination if CalcLayout() is called only once. It should look like this: debug:26765:1: nType T nIndex 382 65535 debug:26765:1: nType T nIndex 790 65535 In this case we can easily detect that the indexes and types in the layout-cache are bogus by checking against the node types, so do that in SwLayHelper::SwLayHelper(). Change-Id: I7091af49a8c29bf0a11ceff0be9ba84b1f710fdb
2017-04-03ofz: fix leakCaolán McNamara
Change-Id: I93a7b2f77713db5c51734263b78ffc69c899987b
2017-04-03iOS update to allow iOS SDK 10.3jan Iversen
added 10.3 SDK to configure.ac Change-Id: I2bd287cada37e595ee25a5a1bfc535daeeb247a9
2017-04-03use actual UNO enums in vcl..xmlsecurityNoel Grandin
Change-Id: Id862544f27ebcbe8363f93dc83192d0f0cddb5cc Reviewed-on: https://gerrit.libreoffice.org/36041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03use actual UNO enums in test..vbahelperNoel Grandin
Change-Id: I2e38462045efedc31903589a3fa4e6f62d74d8de Reviewed-on: https://gerrit.libreoffice.org/36042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03use actual UNO enums in reportdesign..svtoolsNoel Grandin
Change-Id: Idcd916382b87f8542dc6b5cdcb5ecb01d6947203 Reviewed-on: https://gerrit.libreoffice.org/36043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03coverity#440972 Dereference before null checkCaolán McNamara
Change-Id: If4a1da1859dbdf19a7084341003fd6c41700971f Reviewed-on: https://gerrit.libreoffice.org/36040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-03coverity#1403734 Mixing enum typesCaolán McNamara
Change-Id: I46a9a85e7f70502f703ee9fb0f94abd83952d120
2017-04-03coverity#1403731 Explicit null dereferencedCaolán McNamara
Change-Id: I6025e6d4307aa8a6e4b6338d62bc597dace0ac9e
2017-04-03coverity#1403736 Unintentional integer overflowCaolán McNamara
Change-Id: I3902dda8f7b420ea3f5e7e8c5d50a47b7e762918
generated by cgit (git 2.34.1) at 2024-07-29 20:36:09 +0000