summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-12-14lok: remove undefined behaviour warningSzymon Kłos
Change-Id: I74d015bdf2c30b85c8e9eb8271780c9999ea1f15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144169 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-12-14lok: hide 'View PDF after export' checkbox in PDF export dialogAndras Timar
Change-Id: I866e4765ba88ca6c93375c9fecd51f22b79ce72e
2022-12-14lok: hide customization in EPUB export dialogSzymon Kłos
Change-Id: I531aba2eb52e74904b6cba82add769d35a8a28c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144150 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-12-14lok: hide signatures in PDF export dialogSzymon Kłos
Change-Id: Idd67e7ffe4dffc89555d75773501908165cbdd7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144149 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-12-14lok: export PDF/EPUB with extensionSzymon Kłos
Change-Id: Ib266814d88a4f121959cb21f40293d671f242448 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143989 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-12-14Async PDFExport dialog and parent methodsNickWingate
Filter dialogs are all called generically from guisaveas.cxx in GUIStoreModel() Signed-off-by: NickWingate <nick.wingate@collabora.com> Change-Id: Idfbe85c09f84d4a7cf3f00b9704d5af94868a051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140403 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-12-14Make EPUB Export dialog asyncSzymon Kłos
Change-Id: Iead5b4ff6064395fd5abbcdea73db38415dbb37c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143877 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-12-14jsdialog: enter/leave tab page handlersSzymon Kłos
Change-Id: I2cbc0fc18f716bf214db61f0729d666a1d2d172c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143741 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
2022-12-14tdf#151548 ContentControls: improve GetSelectedListItemJustin Luth
Before there was only an option to get the temporarily selected list item that had not yet been committed to text. Add a function that checks whether there is a valid selected item, regardless of whether it has been written out or not. Change-Id: I1199bdccd2e665089750eefa5c3a445d56935556 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143420 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144012 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-13tdf#151755 fix export of borders of contentless cellsAttila Szűcs
Change-Id: I650aeebb4d021911c1f14d4867c5beee84020155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143431 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-12-13sw: track content node with a11y issues, so the number is correctTomaž Vajngerl
Track all content node with a11y issues and handle when they are deleted (with WeakContentNodeContainer). At update, recount the number of a11y issues that are contained in the content nodes and update the overall number. Change-Id: I254c62aba0d73a365f011b1609bcddec4dd71615 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141785 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit ca03ea5c1ce7f1fa0702c004068a2592a723e669) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143704 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-13xlsx: Import table column attribute XML_totalsRowFunctionofftkp
Import table column attribute totalsRowFunction and also export it, which fixes a warning when roundtripped on a different office suite. Change-Id: Icc76fc310aef3bd51bcefebece57f962a56b7cca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142843 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit e54b39c82e88a296af1d2c7ddbf6f20513ffacf5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143444 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-13tdf#151548 ContentControls: Add Invalidate()Justin Luth
Squashed commit. Up until now, all changes made to a content control have been triggered by the UI. However, VBA makes changes by code, and those property changes were just being ignored until the control received the focus. Change-Id: Ife865dd493f7eae4d4e95096071f05b8c27d51db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143194 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> tdf#151548 ContentControls: improve Invalidation This addresses some hack concerns that Miklos raised in his review. Change-Id: Ic6d906e9eb1d23700fb743e179ba87899ce2f4a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143412 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144011 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-12tdf#151548 vba ContentControls: Add word::XContentControlListEntryJustin Luth
make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba Squashed commit containing various cleanups. This now allows MS Word's modern content control list boxes (combobox and dropbox) to be controlled by VBA basic. -allows getting and setting the selected list entry -allows adding/deleting/renaming/moving list entries If .DropdownListEntries.Count <> 3 Then GoTo errorhandler: .DropdownListEntries.Item(2).Select .DropdownListEntries.Item(2).Delete If .DropdownListEntries.Item(2).Text <> "infinity" If .DropdownListEntries.Item(2).Value <> "infinity and beyond" 'With .DropdownListEntries.Add("third", "3rd", 2) Dim LE As ContentControlListEntry Set LE = .DropdownListEntries.Add("third", "3rd", 2) With LE If LE.Index <> 2 Then GoTo errorhandler: If LE.Value <> "3rd" Then GoTo errorhandler: .MoveUp .MoveUp .MoveUp If .Index <> 1 Then GoTo errorhandler: .MoveDown .MoveDown If .Index <> 3 Then GoTo errorhandler: End With 'LE If .DropdownListEntries.Item(3).Text <> "third" Then GoTo errorhandler: End With 'Item 1 runOnceDropDown: With ActiveDocument.ContentControls.Item(4) If .Type <> wdContentControlComboBox Then GoTo errorhandler: .DropdownListEntries.Clear End With Change-Id: Iffebb2bd69abec1cbcfaed05b58f940664852eae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143082 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Fix typo Change-Id: I2f93357f2291312e91002fe3b104261a6aee8734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143318 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Fix typo Change-Id: Ief6a37b977f464c50888291ec9764c7b05cba297 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143320 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> tdf#151548 ContentControls: improve ListEntry::setValue The LO implementation pulls the display text from the value in case there is no display text provided. This is the opposite from VBA. So when we set the Value, make sure that we aren't unintentionally changing the display as well. Change-Id: I699bfc1c2e9fbab6574a3c1363fe1dc21c7354e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143416 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143421 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-12-12sw: Run a11y check for all content nodesTomaž Vajngerl
Change-Id: Icc3ff1be31a01b22242c48dec6d830e645ecb310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141784 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit fad326833699293e5f4e3254881cb56889a220c0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143703 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-12sw: add accessibility check statusbar controlTomaž Vajngerl
A11y check statusbar control, which reports the current status of the online a11y check. Change-Id: I07528f39ed84136f99bc1ce07c10aa6163649305 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141605 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit e340b81d9d75d3aacfa941df4b531c6a9f5aaffa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143702 Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2022-12-12sw: add online accessibility check implementationTomaž Vajngerl
Change-Id: Ic68aa91b1cbf23ac305ad4e361c56b91556757ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141604 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 0b96a1747fc3f96ca70fd159594fe1a478369da0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143701 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-11Related: tdf#152425 Use ww::sti enum instead of respective number literalsMike Kaganski
Simplifies reading and checking its correctness greatly. Change-Id: I16253f324cbafac6cb526ab195a7257530abe0a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143827 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 960207c72aedaf8569b880a7c000c10d0baabb70) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143923 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-09tdf#151548 vba ContentControls: Add basic word::XContentControlJustin Luth
squashed patch, including Stephan's cleanup patch 090fafaaaa1d8ccf5f7b17b7b6f2a85b3fafa0c5 This adds basic VBA macro support for accessing the modern content controls used for creating forms. I ran out of time to make it fully functional. TODO -Invalidation: the screen isn't updating the modified results until interaction from the user (mouse click, etc.) -Unlike FormFields, content controls really depend on having Range working. I didn't have time to look into that. -I was hoping to check that my approach could accommodate the other methods that create a filtered ContentControls object: * Document.SelectLinkedControls, * Document.SelectUnlinkedControls * Range.ContentControls. I guess it will be left up to whoever needs these to add the bits that will create an appropriate collection for these limited sets. -setType: changing one type to another - both LO and Word allow limited use of this - depending on the text contents fitting the new type. What works: -getByIndex - which probably is the "normal" way to do it, since the UI doesn't provide a name/ID; just got via msgbox .ID. -full checkbox support (minus the visual invalidation) -VBA accepts almost all properties/methods that are requested. make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba If Not ActiveDocument.ContentControls(1).Checked If ActiveDocument.ContentControls(2).Checked 'If ActiveDocument.ContentControls(2).Range.Text <> "$" ActiveDocument.SelectContentControlsByTag("checkboxes").Item(1).Checked = ActiveDocument.SelectContentControlsByTag("checkboxes").Item(2).Checked ActiveDocument.SelectContentControlsByTag("checkboxes") .Item(2).SetUncheckedSymbol (8364) '€ With ActiveDocument.SelectContentControlsByTitle("listbox").Item(1) If Not .ShowingPlaceholderText 'If .Range.Text <> "Choose an item." If .Type <> wdContentControlDropdownList End With With ActiveDocument.ContentControls.Item(5) 'If Not .Temporary Then GoTo errorhandler: If .Temporary <> False Then GoTo errorhandler: If .Tag <> "" Then GoTo errorhandler: If .Title <> "" Then GoTo errorhandler: End With With ActiveDocument.ContentControls.Item(6) If .Type <> wdContentControlText If .MultiLine Then GoTo errorhandler: If ActiveDocument.ContentControls.Count <> 7 .Delete 'Doesn't actually Delete in LO yet - unsafe ' If ActiveDocument.ContentControls.Count <> 6 End With ' Change to 6 when delete is working safely With ActiveDocument.ContentControls.Item(7) If .Type <> wdContentControlDate Then GoTo errorhandler: .Color = wdColorBlueGray 'unknown to Word 2010 If .Color <> wdColorBlueGray Then GoTo errorhandler: If .DateDisplayFormat <> "mm/yy/dd" Then GoTo errorhandler: If .DateCalendarType <> wdCalendarWestern Then GoTo errorhandler: If .LockContents <> False Then GoTo errorhandler: End With Change-Id: I1c636f671de81e0283c040a578838a0433ef1f5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143080 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Fix typos Change-Id: I9d22e4a2140f5195d3829e6289ddf3d2f79b632e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143281 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> cid#1517059 disentangle Improper use of negative value Change-Id: I907f54cd93d78fe3638e407c70253b94f849eac3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143351 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143419 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-12-08jsdialog: fix validation error dialog in CalcSzymon Kłos
Change-Id: Ie6551e386cd53f6b4bf4cceb6d7bd6170a2072ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143599 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2022-12-08sw: refactor to make a11y check for nodes independentTomaž Vajngerl
Add checkNodes, which will only check the current node for a11y issues. This prepares for online a11y check. Change-Id: I069cd200ceb58223b05baaafb7d796148e28398b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141603 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 6e66b5d75b4cda0314b64f4d12ef9e4350751470) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143700 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-08[cp] Revert "Explicitly build external/freetype --without-png"Andras Timar
This reverts commit b48cb69dae4118fe4a471921510281bbd16f5c4f. Reason: there is no support for color emojis without libpng. I checked our use case and this revert seems to be safe, because we build without system libpng. In this case we have the LIBPNG_CFLAGS and LIBPNG_LIBS variables defined in config_host.mk and those point to the internal libpng headers and static libs in workdir. These variables are used by configure script of freetype, and freetype will link our internal libpng statically. The link problem with libpdfium is also addressed. Change-Id: I565832e8a32597dde6eb9fb64c522c62233c3097 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143799 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-12-08sw, lok: implement a getCommandValues(Bookmarks)Miklos Vajna
There was no LOK API to get a list of all bookmarks where the name matches a certain prefix. This is useful in case the API client wants to know what previously inserted bookmarks were deleted by the user as part of deleting text content. Add a new getCommandValues(".uno:Bookmarks") that returns the names of matching bookmarks. Do not return the bookmark text, assuming that would be updated by the API client anyway. In practice this is needed by Zotero in case it wants to model its citations with bookmarks. (cherry picked from commit e0bf2712aa9e240748534e3a7498d41c8eeeb9d7) Change-Id: I42a544c3c64496519eec6826b58a310ec86dee74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143790 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-08sw: split out some of the LOK parts of SwXTextDocument into a separate fileMiklos Vajna
Because this has little to do with UNO. (cherry picked from commit c2bcbd36d1913dc1d5ca4bb64fa30740f17bf326) Conflicts: sw/source/uibase/uno/unotxdoc.cxx Change-Id: I683832d0704086f259a29bc1eefae77fd62f26e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143789 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-07lok: vcl: introduce set_cursor_data methodHenry Castro
The ScEditWindow requires to assign a cursor, so the child widget can send cursor invalidation to client side. Change-Id: I429d484a311f217f2419e38d50f8d9a422640221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130446 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136829 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140983
2022-12-07Related: tdf#54053 PDF export: add UNO API to customize the watermark rotationMiklos Vajna
The watermark direction is currently either 0 degrees for landscape pages or 270 degrees for portrait pages. The problem is many people expect 45 degrees rotation angle or some custom angle in general, and we provide no way to control it. Fix the problem by adding a new "WatermarkRotateAngle" PDF export filter option to specify the rotation angle explicitly. Note that the watermark text is still centered, and the text size is decreased to still fit the page boundaries. To keep things simple, do this shrinking by going with a size that matches the shorter dimension of the page, instead of some more complex iterative approach. Example cmdline usage: soffice --convert-to pdf:writer_pdf_Export:'{"Watermark":{"type":"string","value":"draft"}, "WatermarkRotateAngle":{"type":"long","value":"450"}}' test.odt (cherry picked from commit 574db5efa9a2ab6d70faedf538be77a1eb8c597b) Conflicts: filter/CppunitTest_filter_pdf.mk filter/qa/pdf.cxx filter/source/pdf/pdfexport.cxx Change-Id: I1fee14c333e68c92cf4c65ec100e04dcf024f907 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143712 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-07Related: tdf#54053 PDF export: add UNO API to customize the watermark font nameMiklos Vajna
The font name of the watermark text is currently hardwired to Helvetica, a sans-serif font. The problem is that this looks bad in case your document uses serif or monospace fonts. Or perhaps your document uses a single font and you want to make sure that the watermark uses exactly the same font. Fix the problem by adding a new "WatermarkFontName" PDF export filter option to specify the font name explicitly. Example cmdline usage: soffice --convert-to pdf:writer_pdf_Export:'{"Watermark":{"type":"string","value":"draft"}, "WatermarkFontName":{"type":"string","value":"Times"}}' test.odt (cherry picked from commit d1dd9b9733511ff451e264169537c08fa14c574f) Conflicts: filter/qa/pdf.cxx Change-Id: I2f065e1517236695b0a95369bdcd803125018587 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143711 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-07Related: tdf#54053 PDF export: add UNO API to customize the watermark font sizeMiklos Vajna
The font height of the watermark text is currently automatic: we start with a value based on the page size and then decrease it till the text fits. The problem is that sometimes you want a smaller value, but specifying this was not possible. Fix the problem by adding a new "WatermarkFontHeight" PDF export filter option to specify the font size explicitly. Example cmdline usage: soffice --convert-to pdf:writer_pdf_Export:'{"Watermark":{"type":"string","value":"draft"}, "WatermarkFontHeight":{"type":"long","value":"100"}}' test.odt (cherry picked from commit 175e514c93b3696faa8c331c8b8f56e832ceb4c1) Conflicts: filter/qa/pdf.cxx Change-Id: Iceab943b7a995badfcdc6b12ecc9264e39e4a3a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143710 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-07Related: tdf#54053 PDF export: add UNO API to customize the watermark colorMiklos Vajna
PDF export has a watermark feature, but its color is hardcoded to light green, which won't fit all documents. On the other hand, the input from Heiko in <https://bugs.documentfoundation.org/show_bug.cgi?id=54053#c12> is to keep the dialog clean, so adding one more UI option is not great. Fix the problem by only adding the option at an UNO API level for now, this relaxes the hardcoded color without cluttering the UI. Also available on the cmdline for e.g. 0xff0000 / red color: soffice --convert-to pdf:writer_pdf_Export:'{"Watermark":{"type":"string","value":"draft"}, "WatermarkColor":{"type":"long","value":"16711680"}}' test.odt (cherry picked from commit 21c4749d0205d1ba90494edc2527ff9d11f86f87) Conflicts: filter/qa/pdf.cxx Change-Id: I38a3650df86fd34dfc09e3a5643511baa371aa83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143709 Tested-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-06sfx2: add log information to catch the exceptionHenry Castro
Add log information for data analysis if the ExportTo fails due to an exception. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I888545da14f413a970faf50b3ce60d12966f3f9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142201 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-06tdf#150940: Store frame reference in the panelMike Kaganski
It is needed to properly dispatch the commands in case of embedded objects, otherwise they are dispatched to the top-level frame. Change-Id: Ia5fadf7c35bded75f1ca20a682dc6c9f14548990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143693 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 834f49b7e30ec9cc9bd050079b23995ad514b40c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143714 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-06sfx2: extend .uno:SetDocumentProperties to update custom doc propsMiklos Vajna
Scripting clients (like the LOK API) had a way to get all custom properties where the name matches a certain prefix, but setting such properties was not possible. .uno:SetDocumentProperties can already show a dialog to edit properties interactively and had a parameter to set some properties in a non-interactive way, but there doesn't seem to be a way to influence custom properties there without using the internal API. Fix the problem by adding a new UpdatedProperties parameter that allows removing all old custom properties matching the prefix and adding new ones with a single UNO command dispatch. This is meant to be the write side of the reading commit 5e8f6dcb8ce00d2d5e35b3cf5654187b3068276c (sw lok, .uno:SetDocumentProperties: expose value of custom document properties, 2022-11-29). (cherry picked from commit afb362c60a18243621834dcf2b30672be6eed76f) Change-Id: Ib7450d4d21285d9a73758e1c172543521fc07cef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143708 Tested-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-06sw: Move getGrammarContact function into GrammarContact and renameTomaž Vajngerl
Change-Id: Id89d7eabb465f047188f8f74bd823cfb3b2f2aff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141433 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 8e2deed1457e3ab712df2820331136d531927522) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143658 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-06sw: rename IGrammarContact*, SwGrammarContact* to GrammarContact*Tomaž Vajngerl
Change-Id: Ifa9effa5aa8eb014ebf120768893bc982ce73fd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141432 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit dba424efc15aa2915c38721c27edf0cc1d716bd1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143657 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-06sw: combine IGrammarContact and SwGrammarContactTomaž Vajngerl
Change-Id: I4b9ab45ff8e21fa5091894f2cd5e3c7de57df425 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141431 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit c7bcf51d3efe30047667fe026cbcd3cb87bdece3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143656 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-06sw: modify NumberingCheck to work independent of node orderTomaž Vajngerl
Previosuly the NumberingCheck assumed we iterated throught nodes and remembered the previous text node. This changes how the check works so that the we find the next text node and check is with the current node. Change-Id: I043da74ae90b6387bff273f62eb2589faa2d1d31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141430 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit d4c4e3053ce59dba96d7531fc4c1828c1366f419) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143655 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-06sw: refactor SwParaIdleData - rename, lifecycle, move to headerTomaž Vajngerl
This renames SwParaIdleData to sw::ParagraphIdleData, moves it to the header file and changes from a raw pointer initialized at the SwTextNode construction and deleted at SwTextNode destruction to a pure member variable (which has the same lifecycle). A it is not a pointer anymore, there is no need to check if it is nullptr or not, which simplifies the code. Change-Id: I74413eef2cfd3666cf75177a6ea080219eee0ac0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140681 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit e051b3a6d59ed925e1cddfa72696c9a740830808) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143654 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-06sw: use enum class IdleJobArea instead of a bool (bVisAreaOnly)Tomaž Vajngerl
It's more clear what the parameter means - either ALL or only the VISIBLE area. Change-Id: Ib9769da55e29feecab3aad81363429b333fa9d7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140680 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 822e5aba1b40c69591b5fa6cf94819011adc8455) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143653 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-06sw: convert IdleJobType enum to enum classTomaž Vajngerl
Change-Id: Ib1843830836b8d0d03d85c82979bae2f26851259 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140679 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 9b7e904f2f115f22827e4ae3b8da51610ad0c609) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143652 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-06sw: move the check to determine if job is enabled to own methodTomaž Vajngerl
Change-Id: Idf681b59f127a6aa1c6496ad7db39f3dd367b99c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140678 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 01396925b76011ffccb6eea40956a22d58de6f17) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143651 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-12-05Disallow linking files as Writer sections in OnlineAndras Timar
Change-Id: I9e4971c72db44ca8216ac468240dd52d46e0b680 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143225 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-12-05jsdialogs: fix generic color label nameSzymon Kłos
update event was triggering other widget change: when opened calc and selected shape first time we saw color text next to other color label Change-Id: I71670ac1273ce96fafc8d20126d9f32151e96d89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143471 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
2022-12-05sw: prefer view's redline author name...Dennis Francis
to expand SwAuthorFieldType. Redline author name is set in SwXTextDocument::initializeForTiledRendering each time a new view is created. Change-Id: I316e0cae4399796682949de14b6d4b924833eb04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134608 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143649
2022-12-05libreofficekit: add a way to invoke getCommandValues()Miklos Vajna
- add a new button to the toolbar to invoke the getCommandValues() LOK API with user-provided command name (and parameters) - log the result using g_info(), which is visible on the console if gtktiledviewer is started with G_MESSAGES_DEBUG=all - change some labels to tooltip texts that actually show up on mouse hover so you can understand what button does what - tweak the icons, so the question mark icon is the getter and the info icon is the setter (cherry picked from commit 2c149dc9983317bce9116649270c3513adc35514) Change-Id: If6984d2dde3d669b42aafcc3f58a0ca757ccaaff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143494 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-05sw lok, .uno:SetDocumentProperties: expose value of custom document propertiesMiklos Vajna
LOK API clients currently have no knowledge about document properties. Clients like Zotero that want to store custom properties on documents need a way to read and write such properties. This commit focuses on the reading side. Add a getter for .uno:SetDocumentProperties that allows filtering for a certain prefix, this way the returned value can contain only the relevant information. Rework doc_getCommandValues() and SwXTextDocument::getCommandValues() a bit, so adding new getters require less duplication. (cherry picked from commit 5e8f6dcb8ce00d2d5e35b3cf5654187b3068276c) Conflicts: desktop/source/lib/init.cxx sw/qa/uibase/uno/uno.cxx sw/source/uibase/uno/unotxdoc.cxx Change-Id: I0c52cd2efcc8b1ea7307763c8252dd1e8ffdea2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143493 Tested-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-05[cp] resolution of osxdndinstall.png must be 72dpiAndras Timar
Change-Id: Ib0a020fcbd855c97fc2294287e517b9f440c552a
2022-12-05[cp] fix multi-language DMG on macOSAndras Timar
Change-Id: I56ec73fab321f7740accd14f956dfd1230fd9e01
2022-12-04docx: export symbol characters correctlySzymon Kłos
Previously we had: after save: <w:t></w:t> original content: <w:sym w:font="Wingdings" w:char="F0E0"/> This patch checks if paragraph has symbol font used and exports content using w:sym mark in that case Change-Id: I74f4bb0d249cbf5dfc930e931f7d91bd0d2e9821 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143455 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-12-04it is not possible to install color palette extensions in Online or mobile appsAndras Timar
Change-Id: Ibb2e9bfcf4b8e8681f96e6863fd900181c278adf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143309 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-12-02htmlexport: close li mark not only in xhtmlSzymon Kłos
As commented in sw/source/filter/html/htmlatr.cxx:766 "// OutHTML_NumberBulletListEnd() will end a list item" We have to do it also in HTML not only XHTML so node will be closed and we get correct structure. This is followup for: commit 2466b9fcf20ee61f6fc621298011c0efaa55e7c6 Author: Miklos Vajna <vmiklos@collabora.com> Date: Mon Feb 21 16:38:51 2022 +0100 sw HTML export, XHTML mode: fix lost </li> when last list item is not numbered Change-Id: I99baa59b437572b157df8057445cf6c741f936b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143508 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
generated by cgit (git 2.34.1) at 2024-07-12 13:49:14 +0000