summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-05-10fix OSX and Windows buildsNoel Grandin
after my "Convert SALEVENT to scoped enum" commit Change-Id: Ib4a3f0e18fa5d8160446d5b5cd505bae651da7d5
2016-05-10loplugin:rangedforcopyTor Lillqvist
Loop variable passed by value, pass by reference instead. Change-Id: I12d1cb639cbe7a5686a1854168362b85322fa2e5
2016-05-10Check if we have an OpenGL context before using API that requires itTor Lillqvist
Avoid GL errors when glDisable() is called without a context. Change-Id: Ie9eae498c207a82934228ad2f74b7096308f5530
2016-05-10sc lok: Extend the spreadsheet area when we are "close enough" to the end.Jan Holesovsky
We can tweak later what the "close enough" means - for the moment it is 10 columns and 25 rows. Change-Id: I92127a71aa6683c03692e96b9e0da7827942c94b
2016-05-10sc lok: Move the handling of the area back to GetTiledRenderingArea().Jan Holesovsky
Change-Id: I4dbfc090ab43065c719f83b5355cd9832ee4d1e3
2016-05-10fix OSX buildNoel Grandin
after my "Convert SALEVENT to scoped enum" commit Change-Id: I1b91997fdadfd70cb2a00a33ec00f2f51727656a
2016-05-10sc lok: set a limit for tiled column and rowHenry Castro
In the tiled rendering case, not all column and row are rendered, so it was set a limit for tiled column and row. However, when a client request to move the cursor beyond the limit, the tiled column and row is updated and they are rendered later. Change-Id: Id0de533ebf7b3c6e0343f9dc15336150729299fa Reviewed-on: https://gerrit.libreoffice.org/24777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2016-05-10Convert TOOLBOX_MENUTYPE_ to scoped enumNoel Grandin
Change-Id: I8eb25fc274b45b8add04dfc03e4b52f130ad04de Reviewed-on: https://gerrit.libreoffice.org/24827 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Convert StatusBarItemBits to scoped enumNoel Grandin
Change-Id: Ic979d1470052039c4b966edd1d896af31ef55668 Reviewed-on: https://gerrit.libreoffice.org/24826 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10fix Windows and OSX buildNoel Grandin
after my "Convert SAL_EVENT to scoped enum" commit Change-Id: I1a52a1e3428c9b68d67bd521a3136f3a529392f5
2016-05-10remove STATIC_ARRAY_END and usagesJochen Nitschke
used in loops, rewrite to range based loop oox/source/drawingml/color.cxx has some mappings in plain arrays make them arrays of pairs which can be used in range based loops Change-Id: Ib6693197d890f595c27ca24b9f9b4e0763747f4c Reviewed-on: https://gerrit.libreoffice.org/24809 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-05-10remove usages of STATIC_ARRAY_END in scJochen Nitschke
if used in loops, rewrite to range based loop, else replace STATIC_ARRAY_END( ) with std::end( ) Change-Id: Ib05063eb78f82c8af967bc82e9759af2a58258c8 Reviewed-on: https://gerrit.libreoffice.org/24808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-05-10fix OSX buildNoel Grandin
after my "WindowStateState scoped enum" conversion. WorkWindow::IsMinimized needs to check the return code of SalFrame::GetWindowState, or it can end up reading uninitialised memory. So mark the member as SAL_WARN_UNUSED_RESULT. Change-Id: Iaeb132ed2fbf08162dbd7ec2e126dfa679cbda6c
2016-05-10Convert SAL_EVENT to scoped enumNoel Grandin
Change-Id: I4e605e7acfe9d4fe409d32f20880b4c0e85a0ea7
2016-05-10EXTTEXTINPUT_CURSOR_INVISIBLE is set on the wrong fieldCaolán McNamara
Change-Id: I6d92c86035dd321eb6df46bcd01aed7a0113b0a4
2016-05-10Missing break in switchStephan Bergmann
Forgotten in 4f1f8b8e993b98095bf50c9e432fb0400d318b1f "pivot: new pivot table layout dialog" (as clarified on IRC). Change-Id: If35e1a9616e596b16bcb007f6ea172b634c11b85
2016-05-10Updated coreAdolfo Jayme Barrientos
Project: help 50ae47d7856c77dd682d0e7007acc70ee34fb5b5 tdf#99739 tdf#91945 Margins and edges aren’t the same thing Change-Id: I6809b79bdde36fd5ee86f0eeb54c29871f54c19c
2016-05-10rtf: m_aStates can be empty in the inner conditionCaolán McNamara
Change-Id: Id262a3019a693f236630b798579f360c9462d12e
2016-05-10Missing break in switchStephan Bergmann
Apparently forgotten when introducing the case PROPERTY_ID_GENERATEVBAEVENTS in 4fae740db79d4e7cc97440e2bab8d1ef612d9b51 "Disable fake VBA events for the old-style form controls." Change-Id: Id2783fd4f087669bd200a9c33eaad2bb6b7b50cd
2016-05-10Avoid non--async-signal-safe functions in child after forkStephan Bergmann
Posix requires that a process forked from a multi-threaded process only calls async-signal-safe functions between fork and exec. This has been observed to cause trouble at least in an ASan build, where a forked sub-process (that wants to proceed to exec java from getJavaProps, jvmfwk/plugins/sunmajor/pluginlib/util.cxx) hangs in __sanitizer::BlockingMutex::Lock from within ASan's operator new replacement, from within the SAL_INFO in SvpSalInstance::CloseWakeupPipe, from within the atfork_child handler established with pthread_atfork. The rest of the calls in SvpSalInstance::Create-/CloseWakupPipe appear to be async-signal-safe. This pthread_atfork handler got introduced with dbced8e8584b631524dacf607f752ebb734901db "Don't share the wakeup pipe with child processes". It is irrelevant when the child process will proceed to call exec. And if the child process does not proceed to call exec (which is the intented use case why it got added), the above-mentioned Posix requirement makes it look unlikely that the child will operate properly (i.e., not call any async-signal- safe functions), unless the parent process was single-threaded. Change-Id: I9ecaf98597b396e0db83fe98fb11a7df7686e1d6
2016-05-10Remove default outline indent, fixes tdf#95576Luke Deller
The default document outline style has indents set appropriately for numbered headings. However numbering was disabled in the default outline style 20 years ago (!) so update the indents accordingly. Also revert commit 05fd8cb848ecba425124d61cd76e2f9418d5378c which attempted to work around this issue by explicitly setting a zero indent on the default paragraph styles "Heading 1", "Heading 2", etc, as this is no longer required. This change fixes a DOC import issue tdf#95576 (!) Reference: see this old German comment https://cgit.freedesktop.org/libreoffice/core/tree/sw/source/core/doc/number.cxx?id=84a3db80#%6E647 Change-Id: Id289143ed859861f2584e21969f16f348e215f6f Reviewed-on: https://gerrit.libreoffice.org/24806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-10fix Windows build (second attempt)Noel Grandin
Change-Id: I5aa3bcf16cbcda984a74ec85a49a354087f5044e
2016-05-10tdf#99207: Fix incorrect RGB ordering in Graphite DWrite pathTim Eves
Direct 2D accepts colours specified as UINT32 ARGB values or floats. However GDI presents colours as COLOREFS which are 32 bit FBGR (F is a flag not an alpha) values. Passing a COLORREF to D2D1:ColorF swaps the red and blue channels. This patch converts the COLORREF into RGB float triples using the GDI colour macros. Change-Id: Iee5c00bfb10fa8771a2a1019976f70633cca4094 Reviewed-on: https://gerrit.libreoffice.org/24819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2016-05-10fix Windows buildNoel Grandin
Change-Id: Ia00af427fda31867a19457b7ef30158b385639e6
2016-05-10vcl : Simplify vcl::Window initialisation and destructionArnaud Versini
Change-Id: Ie3a8435d0adff795645618deb2c3c3da813e54f3 Reviewed-on: https://gerrit.libreoffice.org/24681 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10convert WINDOWSTATE_STATE to scoped enumNoel Grandin
Change-Id: I5448c7e46042850f18970c7613ec5a37df57bce7
2016-05-10convert WINDOWSTATE_MASK to scoped enumNoel Grandin
Change-Id: Ic8259d81d8080c518aa07697e253a59cd6efaa4b
2016-05-10fix Windows buildNoel Grandin
Change-Id: Ib80cc10c259e26e997e3a548fbf267621c050e29
2016-05-10clang-tidy modernize-loop-convert sfx2Noel Grandin
Change-Id: Ief72064e2869945734215a7c67440adc6c1550c3 Reviewed-on: https://gerrit.libreoffice.org/24799 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10clang-tidy modernize-loop-convert scaddins to sdextNoel Grandin
Change-Id: I63ccc56df1a1de8bc443abb95e520246c457912f Reviewed-on: https://gerrit.libreoffice.org/24798 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Simplify code with ForEachNonNullTakeshi Abe
Change-Id: Id149ecee4fa7737b529f3a3a19bb4bb9ed778dcd Reviewed-on: https://gerrit.libreoffice.org/24778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-09tdf#89466: Handle no background and bitmap case also in sidebarKatarina Behrens
Change-Id: I9e36a7963cb3065b81c1ba25f983d722d5f30ed8 Reviewed-on: https://gerrit.libreoffice.org/24802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-09writerfilter: extract dispatch{destination,flag,symbol,value} from rtfdocimplMiklos Vajna
These were half of the lines of rtfdocumentimpl. Change-Id: I3f24cd5d23c91bf0d53b898266c187699ae6ee56 Reviewed-on: https://gerrit.libreoffice.org/24790 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-09tdf#38097 min numerator/denominator at least 1Laurent Balland-Poirier
In <number:fraction> attributes min-denominator-digits and min-numerator-digits should be at least 1. Gnumeric can create file with 0 values Change-Id: I08ef51c23ce686136f51277671bf630807353484 Reviewed-on: https://gerrit.libreoffice.org/24670 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-09tdf#88657 calculate denominator lengthLaurent Balland-Poirier
Get length of denominator which could be different from numerator length Change-Id: I9f5c10917185eb029d52efbc0f20be5f81c74d10 Reviewed-on: https://gerrit.libreoffice.org/24712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-09desktop: warning C4101 unreferenced local variableMichael Stahl
Change-Id: I6059dd33828e4d8034e0489068615e96bf5f2e02
2016-05-09tdf#98290 New shortcuts for fullscreen, spellcheck and options (Mac)Yousuf Philips
These shortcut keys are based on Apple's HIG Cmd + Comma - Preferences Cmd + Colon - Spellcheck Cmd + Ctrl + F - Fullscreen Also added a common preferences shortcut for Windows Change-Id: I7ee03ca6ffe52f5a802cade0c9b6245c9799e627 Reviewed-on: https://gerrit.libreoffice.org/22794 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-05-09LOK: drop identical invalidation notificationsAshod Nakashian
And drop duplicate GRAPHIC_SELECTION notifications. (cherry picked from commit 7cdfe080432f69c2247cc7ff28316b653bd654ff) Change-Id: I0c372efa9a58620e24cea219d82479cdc9dff359 Reviewed-on: https://gerrit.libreoffice.org/24771 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-09LOK: SAL_WARN for each removed event is unnecessaryAshod Nakashian
Change-Id: If5e4c7b8751ae4eeb278475fb00118e32c6bb565 Reviewed-on: https://gerrit.libreoffice.org/24730 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-09Don't change part on text documents to paint tilesAshod Nakashian
Change-Id: Icb5fb46cbc9d2f72c814cf9f1f166382493d403f Reviewed-on: https://gerrit.libreoffice.org/24702 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit aadab5f4a72e38ccc8bbe9b7811d2cdcaa00124c)
2016-05-09Allow painting for arbitrary partAshod Nakashian
Painting should not cause any state changes, but to paint a tile on a different part than the current has to change the document, which sends notifications to all clients. A new API, paintPartTile, allows for painting tiles on any part without sending change of part notifications. Furthermore, because we block notifications during this operation, no tile invalidation is issued due to changing of the part. One issue remains in the cases when the LO Core resets the cursor position internally and we resume editing after painting, the cursor might be at the top of the page. This needs fixing separately. Change-Id: If19bd1c90ecad4d5ed5e8d09513741b7994fa6e5 Reviewed-on: https://gerrit.libreoffice.org/24698 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-09Some LOK notifications are dropped if they are superseeded by later onesAshod Nakashian
Change-Id: I323e46a2a6c60b200b182b89199945f99a7f384a Reviewed-on: https://gerrit.libreoffice.org/24567 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit cf98799fff7ae999bd62cec6486c986bf44000cc)
2016-05-09std::tuple -> std::pairAshod Nakashian
Change-Id: I2f11436a5c9691c2a0aac3655bc2c543d1c3d684 Reviewed-on: https://gerrit.libreoffice.org/24566 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 8a6dab5da851f38a8ecef633e06e3cb2ac5e7849)
2016-05-09More LOK callback notification compressionAshod Nakashian
SET_PART, CELL_CURSOR, CELL_FORMULA, and CURSOR_VISIBLE are now deduplicated. Change-Id: I4c17307c6f8b7c68bdfe55b4e90da4d34c55d085 Reviewed-on: https://gerrit.libreoffice.org/24565 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit a9771e1f4d0d2602713983ab1f3e743784e9ae72)
2016-05-09Improve two informative messagesTor Lillqvist
Use 'enable/disable' terminology consistently: don't mix 'enable' and 'set' in the same phrase if they both actually refer to the same thing. Also, don't say that it is 'already set' when it is already 'disabled'. Change-Id: If4cea9845b47cdf678d5591f05ac08cc086c9a0b
2016-05-09fix windows build, ambiguous symbolNoel Grandin
Change-Id: Ib3a2419198a6e2b1ee5330f99bc526f2d63edd7c
2016-05-09Update the wmf filter to simplify object ownershipMark Page
Changed the GDI style structures to use inheritance, thus object deletion no longer requires a static_cast Used std::unique_ptr for GDI objects to enforce object ownership Modified the WMF Writer to use std::vector, instead of a raw pointer array when processing handles Change-Id: Ic635ff9d641427b901eb18468529ea6367859b53 Reviewed-on: https://gerrit.libreoffice.org/24634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-09convert OUTLINER_MODE to scoped enumNoel Grandin
Change-Id: I7ac45d7fbd5e77a105cbe942c6d4fd6cfc8ff909 Reviewed-on: https://gerrit.libreoffice.org/24789 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09fix windows and android buildNoel Grandin
Change-Id: I4644c1e5ac143efc6b1e75d041f71fe7d9156f0c
2016-05-09cid#1358836 reorganize to silence Resource leak in objectCaolán McNamara
Change-Id: I4cb51f537cf6b40748dd8902dc39362d8846ba22 Reviewed-on: https://gerrit.libreoffice.org/24708 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-14 11:41:18 +0000