summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-05-10Presumably missing break in switchStephan Bergmann
In fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import" the case SDRDRAG_CROOK fell through to the default branch, but which was irrelevant, as the default branch's if-branch would only hit if bCroner || bVertex, in which case the SDRDRAG_CROOK's if-branch would already have hit and returned. Then dc1fddc142ab438775e2c1bae4a0e148d263ce0d "INTEGRATION: CWS cropmaster2000_DEV300: #i83933# added interactive graphic cropping" moved the case SDRDRAG_CROP in between. Change-Id: I66939fc62416e0a442b02e674d90812ce76f3b2b
2016-05-10Presumably missing break in switchStephan Bergmann
Was like that at least since d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter to filter", but as clarified on IRC: <vmiklos> sberg: doesn't look intended, i think ESCHER_Prop_lineDashing and ESCHER_Prop_fNoLineDrawDash are supposed to be mutually exclusive. Change-Id: I5ea92e6bdc9800c4511ca041c0572d1f9ffca49c
2016-05-10Missing break in switchStephan Bergmann
First 749a0845500d69f99bf1901bab82361f67b5e4f6 "don't show area and line panel in pie chart Chart selection, tdf#94320" added the case OBJECTTYPE_DIAGRAM falling through to the default break case. Then 14237c1678167da725fee079532c4669264d697f "use trendline context for trendlines, tdf#94931, tdf#94934" added the case OBJECTTYPE_DATA_CURVE, OBJECTTYPE_DATA_AVERAGE_LINE block in between. Change-Id: I9d06b5054128c4a31381e33620f4a2b898e0e969
2016-05-10-Werror=empty-bodyStephan Bergmann
("suggest braces around empty body in an ‘else’ statement") Change-Id: I7c6de1ed2cc1c2cc39e2c8f530866c31ab038907
2016-05-10tdf#99589 tolower / toupper - dangerous to Turks ...Krishna Keshav
replaced tolower with to AsciiLowerCase() in lingucomponent/source/languageguessing/altstrfunc.cxx l10ntools/source/gL10nMem.cxx Change-Id: I1340da18b263a4a921e2e8d96c0f133fe300086e Reviewed-on: https://gerrit.libreoffice.org/24682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I0dd8f3c1d9330bc58cf52212c9752adf51444d3d
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I1f147c4a0ebc6895435722d8385131917f88ecb5
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Id0470b3e60a455bc3807f4fa5da98cf5f1877d00
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Id6e230d026184ab243e994a17515f2e5539d3646
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Ief09facecb6243815309a59e23a5673db5e1d94d
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I49c216ed6e1e401fcc2029c047d7a7feeb767b36
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I6df171debbf4940bf27898c3ff5d8597f437897f
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Iba1556d1918a336e376c0fda5e7e14b3e890d267
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I8fcd7bf2583c935e060a29e43c88614681d81d13
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I8a42f027d4970fe31c0e713d1402668499c8dda7
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I796ec3b79d7c26d9efe275b4232ae85cac80b578
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I646abf83b4dce8c92a3ba1c136d968bb9291dd83
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I005943a7c7bc4f8bfc647b2cf44f143a66a7e997
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Ieee43fce49b7f07d6b356e8c2e34e9e92b605957
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Ib0cb61ce63b065f6e2845ef7e8da0827556110ba
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I0dccdf984f4b171feab20e8400376cf8846ffe2e
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I07f247f003a5522e7d655f30f7c68d1b8f7225f2
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I041971ad00b6b2e41509fa6b877c0563748f1336
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I41dec58c163bdd33b71b3519fa0fd6eca72faae6
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Ib67f7cb71255a32810f09a6b7e528f024bbef9df
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Ic764a6499b8f5ecac62d326151b0957c53866e08
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I28bca2b15cb2d6f521efbcc27e93be2338500489
2016-05-10Add SAL_FALLTHROUGH to what looks like flex-generated codeStephan Bergmann
Change-Id: Icd980dbbdc8b55d76b7f8abe4dd1a9d7e475143d
2016-05-10Silence Clang -Wimplicit-fallthrough in gperf-generated codeStephan Bergmann
...in preparation of eventually enabling -Wimplicit-fallthrough for Clang. Change-Id: Idca352d011505e83dbe275cb19626c8b9d8560c8
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Note pull request for boost patchStephan Bergmann
Change-Id: I92a98bb196c9f6e7dfdca7008a34fb4fd3e10799
2016-05-10separate this piece of goo out into a standalone thingCaolán McNamara
no logic change Change-Id: Ib03a2516c9b3cf6bedf52760d8f7cb68cc70464f
2016-05-10Use BOOST_FALLTHROUGH in external codeStephan Bergmann
...in preparation of enabling Clang's -Wimplicit-fallthrough Change-Id: If64f9b18591b3cd2528adc6c2d6011d509d4afcd
2016-05-10mbErrors is never readStephan Bergmann
In the original 5624be5a3520a16d57724064e16df3722d728010 "CWS-TOOLING: integrate CWS graphite01" it used to be read in debug-only code that meanwhile got removed. (And getIntValue can now be a non-member function, as noted by loplugin:staticmethods.) Change-Id: I758268064181d44c90f5c4d1841fb09f4c532669
2016-05-10Harmless missing break in switchStephan Bergmann
mbErrors isn't read anywhere, anyway. Change-Id: Ieef912c046535c130b82d2d2e0536a1ec0446905
2016-05-10Harmless missing breaks in switchStephan Bergmann
The fallthrough will only happen if eCodeType is anything but NF_KEY_MMM..., in which case the following cases will fall through to the end of the switch, too. Change-Id: I2fea503a0ce919dad645e3749b2173676fda5373
2016-05-10Harmless missing break in switchStephan Bergmann
The fallthrough will only happen if !pDocShell. So if HAVE_FEATURE_SCRIPTING, the following case's if-branch is not entered, leading to break. And if !HAVE_FEATURE_SCRIPTING, it leads directly to the default-branch's break. Change-Id: Ia0ac8d849ea3c762893001bfb2c64acd9725dd92
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-10Updated corePeter
Project: help 603ab87d4a7356a1490a00fc62a7e2f691b5ece3 Cleaned up some English Change-Id: I5f81ef8381536aeca8eac8d409c75f20d4245786 Reviewed-on: https://gerrit.libreoffice.org/24796 Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk> Tested-by: Olivier Hallot <ohallot@collabora.co.uk>
2016-05-10Convert SAL_INVERT to scoped enumNoel Grandin
Change-Id: If9f725c791f9d01efba098caed8387f21862fa04 Reviewed-on: https://gerrit.libreoffice.org/24825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10No need to wrap SAL_WARN in DBG_UTILStephan Bergmann
Change-Id: I0d401f09cb504c89329a27533c2df30b59bb60ad
2016-05-10convert SAL_ROP to scoped enumNoel Grandin
Change-Id: I2c49ec843c0f95e8246cdf9d3185c11e81a3bde3 Reviewed-on: https://gerrit.libreoffice.org/24824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Convert SALOBJ_EVENT to scoped enumNoel Grandin
Change-Id: I41fcdbb2381008b99f6cb7cafb085d35f8db9374 Reviewed-on: https://gerrit.libreoffice.org/24828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10assert OpCodeMap and fallback-init maErrRefEike Rathke
Change-Id: I1e289c6891f3d0273104a909428a4aa0daeb738f
2016-05-10use passed rErrRef instead of obtaining resource stringEike Rathke
Change-Id: I96ae74d8d82468bebcc79cebebf86731685c446f
2016-05-10use passed rErrRef instead of obtaining resource stringEike Rathke
Change-Id: I3041b0a4f4427bbcbaf07e7a0694e9cfe5d10014
2016-05-10opengl: Check if texture is valid before asking for IdTomaž Vajngerl
Change-Id: I6482ca005df385d79bcd55f3b1db3559021ab371 Reviewed-on: https://gerrit.libreoffice.org/24835 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-05-10more OSX fixNoel Grandin
Change-Id: I585ff0105f00793a80e0b5fa25e7dd08fb2fc95f
2016-05-10more OSX fixNoel Grandin
Change-Id: Id9500cf86988614d9dfa04a52b73decd2a4855e0
2016-05-10tdf#96275 RTF import: fix anchor of shapes inside tablesMiklos Vajna
Table text is buffered, so buffer the shape import as well, otherwise the anchor will precede the buffered text -> incorrect anchor position. Change-Id: I527b898e2cd5fafaf122a20e11df66ba8d3185cf Reviewed-on: https://gerrit.libreoffice.org/24822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-14 09:10:46 +0000