summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-01-07aarch64 r18 is reserved at least on AndroidStephan Bergmann
<https://github.com/ARM-software/software-standards/blob/master/abi/aapcs64/ aapcs64.rst> states: "The role of register r18 is platform specific. If a platform ABI has need of a dedicated general purpose register to carry inter- procedural state (for example, the thread context) then it should use this register for that purpose. If the platform ABI has no such requirements, then it should use r18 as an additional temporary register." For a --host=aarch64-linux-android build, Clang warned > bridges/source/cpp_uno/gcc3_linux_aarch64/callvirtualfunction.cxx:39:9: error: inline asm clobber list contains reserved registers: X18 [-Werror,-Winline-asm] > "ldp x0, x1, [%[gpr_]]\n\t" > ^ > <inline asm>:1:1: note: instantiated into assembly here > ldp x0, x1, [x20] > ^ > bridges/source/cpp_uno/gcc3_linux_aarch64/callvirtualfunction.cxx:39:9: note: Reserved registers on the clobber list may not be preserved across the asm statement, and clobbering them may lead to undefined behaviour. > "ldp x0, x1, [%[gpr_]]\n\t" > ^ > <inline asm>:1:1: note: instantiated into assembly here > ldp x0, x1, [x20] > ^ and <https://github.com/llvm/llvm-project/commit/ 9c9c8b22d2ea150cc889232871b0c8303d3644d9> "Start reserving x18 by default on Android targets" shows that at least LLVM/Clang claims that the Android ABI reserves it (though it doesn't cite any sources for that). (If this bridges/source/cpp_uno/ implementation is used for other non-Linux OS like Fuchsia, we may need to extend the #if accordingly; see the above LLVM commit for which platforms it claims reserve the register.) Change-Id: I62a5210ddc4784eee2ab56ee134b9e195827b9dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86366 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-07Replace a CPPUNIT_ASSERT_EQUAL with a static_assertStephan Bergmann
Change-Id: I8382aa13eb9c65ae61fc0dbfe440df6718133c18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86352 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-07Paragraph Dialog Outline Numbering Tab updateandreas kainz
Change-Id: I29d349858b39149b228aa4f6b80eee39f7c6b3f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86318 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-07Paragraph Dialog Text Flow Page updateandreas kainz
Change-Id: I0e47f9abb2e20da8ae3aef1ee927cb286a88ee8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86319 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-07tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesOnur Yilmaz
Change-Id: Ie82a0e15f8c2ed3148277d88c0db8164b5b9393c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85960 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-07tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesMesut Çifci
Change-Id: I55e4028bfc39161f6734cc54721d49cd25e078f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86060 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-07tdf#129522 writerfilter: allow char shadow_NONE overridesJustin Luth
Exporting will take some extra work, so keeping that part separate for now. The unit test will come when exporting works. The same change was made for paragraph style-overrides in an earlier patch, and this patch depends on it for proper UNO processing. (commit 4ca73073a0d7c62b12a7354f76f8f80adc5d98c1) Change-Id: I5282a319e89be9a63dbd99e00e35fb2d176a631d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85869 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-01-07extract some common code from ImportContext classesNoel Grandin
which reduces code bloat, and lets us log when elements are ignored Change-Id: I5ca12bc1fcbfa3bea49ebde819fd80bd233a96a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-07tdf#129452 DOCX import: fix bottom border of merged columnSzabolcs Toth
Bottom border of a vertically merged column of a table was missing if the inside borders were turned off and the merge included the last cell of the column. This happened because the first cell (topmost) in a set of vertically merged cells determines the borders of the new merged cell, and the turned off inside borders were at the bottom in this case. Change-Id: I3d3defad18a1315117a554a36ad599eb46daffe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85988 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-07fix up TableEditPanelCaolán McNamara
Change-Id: Ibe1a461915d036caf41e761be6970bed9d03b795 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86347 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-07Resolves: tdf#129850 crash inserting tableCaolán McNamara
Change-Id: Ib35363320d7edb67daaadf15d1e0b8584909d84a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86346 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-07Fix typo in codeAndrea Gelmini
Change-Id: I768c5ae5a4c2c0b2f50a8eb541a5c7397c355345 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86206 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07expand out namespace macrosNoel Grandin
Change-Id: Ifbcffa0315d0505b919703b82fee842be5aa0296 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-07Fix typo in codeAndrea Gelmini
Change-Id: I1ba1b2e1f0568ee3874d171fe33686968e21a484 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86205 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-01-07Fix typo in codeAndrea Gelmini
Change-Id: I18fe1826646622a71a7d56acc63cbac01ffe4ead Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86204 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-01-07Fix typoAndrea Gelmini
Change-Id: I04c11c4dfcca3b27369a2b2b5fbbb65d5af45a61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86307 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07Fix typoAndrea Gelmini
Change-Id: Icccda9c310153e6e1d1696ab094afc3a894d4075 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86298 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07Fix typoAndrea Gelmini
Change-Id: I9646220221d3efe7bcd99253245a1044dbed7d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86299 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07Fix typoAndrea Gelmini
Change-Id: Ie2a863fa7975257510311249e40601d90b51aae9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86305 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07Fix typoAndrea Gelmini
Change-Id: I0cf1ab7a86fd3b9323f1b5d219b6943b2f61884c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86300 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07most has_tooltip uses are bogusCaolán McNamara
has_tooltip means to use "query-tooltip" to present a tooltip, not that the widget has a literal tooltip, the presence of which is sufficient to set the tooltip Change-Id: I49b35debd1bca1803464096fbc550eb50945509f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-07Fix typoAndrea Gelmini
Change-Id: Ic26a634c3f7cb089743f6d6d2a67e38f8104f724 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86302 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07Fix typoAndrea Gelmini
Change-Id: I0c62fbf27986f20388d6fb7f44f4e998657d791f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86301 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07Fix typoAndrea Gelmini
Change-Id: If2db5c423c10b4de1c03de1c1b98bb8f6d8a0a53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86339 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07Use virtual method instead of switch in parent classAdrien Ollier
Change-Id: I53129ed6b57eb13898a426de0a2ba72c7d6674de Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/83825 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-07Fix typoAndrea Gelmini
Change-Id: Id64bd59e579fa06313824e9662a15e096e6fddee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86304 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07tdf#124176: Use pragma once instead of include guardsAleyna Doğrucan
Change-Id: Ib2c93eb61d8d4c944a1b7de074fd0e9e48715ca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86232 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-07arrow in sidebar not getting reenabled on changing contextCaolán McNamara
possibly since... commit 5b77d17c4f1ca734babf962b45c1aa07bdca14e9 Date: Sat Jan 4 18:09:20 2020 +0000 sidebar: allow panels to lurk around instead of being disposed. Change-Id: I4d3085a1bd0ceb5f04dba3e49c801df05b795061 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86332 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-07halign 'Start'->'start'Caolán McNamara
Change-Id: Ia8547ffd08cc60ec8e6f791fcccaab35784de9aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-07tdf#77796 DOCX: import table style based cell paddingLászló Németh
Change-Id: Ib86ed45fe816d7e273539798cdebdbb95d575518 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86295 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-07Fix typoAndrea Gelmini
Change-Id: I16245a94dd17dbb158a1a1f0a7c33ffd7b1731f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86303 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07Fix typoAndrea Gelmini
Change-Id: I9ef83d4c094f2ff9761a1d0256fab9d40164cc04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86306 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07Fix Chart2ImportTest::testAxisTitlePositionDOCX test for 150% UI scalingMike Kaganski
On Windows, with 150% UI scaling, the four values for which tolerance were added are 10638, 7159, 389, and 6631 respectively. Change-Id: I4467cd465f55f9f6efe58c54c37cf8563bb42a30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85967 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-07tdf#42949 Fix IWYU warnings in sw/source/uibase/[a-g]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I07178531d1c1edbfcd1ec1feed0dbe96ed2627a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85793 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-07tdf#107604 Handle predefined table styles.Gülşah Köse
Handle table styles that we have just style-id and have not corresponding style defination in tableStyle.xml Change-Id: Id06f5508d5eb1330b5bac1634c520c3066c09139 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86068 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-01-07tdf#129845 vcl: avoid expensive system caching of trivial lines & polygonsMichael Meeks
Interestingly the cache map lookup is rather expensive; why: polyline output for some trivial impress edits: count # of polylines 2 2134 3 141 4 41 9 4 polypolygon output for some trivial impress edits: count # of polypolygons geometry. 3 54 all single polygon 4 583 ~all single 9 52 ~ all paired with a 4 node polygon 13 2 both single 32 22 all single Change-Id: I15c0053a84399eaf153b2119b2c28d1f168f16b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86314 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-07sw: add rendering for semi-transparent textMiklos Vajna
I considered passing the text color's alpha value down to the various vcl backends, but this would need changes everywhere (cairo, opengl, pdf export, etc). It's much easier to go via DrawTransparent(), that's how semi-transparent text in Draw/Impress already works. Change-Id: I96f15e6764c3c88ba67dd72dc8708414d7c6050c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86294 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-07tdf#129841: fix GetTextTableCursorPropertyMap cell background valuesMike Kaganski
... which were accidentally broken in 2003 in commit eba784710e92597282a2284b56dce3a45ac38776. Change-Id: I3dc96dff0a8935f927933bb3946528fb8ac9aed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86315 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-07Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 834cace28d1c82d4c9bf6dd123a545736a4362fc - tdf#106023 updating help pages for footnote and endnote settings - indicate that only special paragraph styles can be chosen for paragraph - update menu items - align text with tab Change-Id: Id508b424ed2b61b5b169e14ee4befb096008e959 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86286 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-01-06acc. check: move accessibility check strings to own fileTomaž Vajngerl
Change-Id: I455b6f77f75dd3190939c17bf5ffc362030efdbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86290 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-06acc. check: table split/merge - check for row span, simplifyTomaž Vajngerl
This extends table split/merge check to also check for row span and simplifies the code a bit by removing code duplication of adding a new accessibility issue for the table to the collecton. Change-Id: If3eb1fa05174f606767e170a61fd0f4af7567aba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86249 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-06acc. check: add a UI goto for issues with tablesTomaž Vajngerl
Change-Id: Ifa636ce7ee32495d81571754c29b1114f8b56cdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86247 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-06acc. check: check headings are in incremental orderTomaž Vajngerl
This adds an accessibility check for headings. Headings should be in increemntal order. This means for example that the document can't start with "Heading 2" without first having a "Heading 1", or to skip a heading - for example to go from "Heading 1" and next have "Heading 3", skipping "Heading 2". Change-Id: I6fd3189cc659ad0756cc950b7c0b83b3ec8abf84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86246 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-06Revert "sfx2: sidebar: new .uno commands to show and hide sidebars"Michael Meeks
This reverts commit b6f4d3b92789e972d9b079a5561723f3e73e07a6. These are now handled as LOK pseudo-uno commands internally, and seem unlikely to have worked. Retains a small change to SidebarDockingWindow.. Change-Id: I861f46f0c9b5cf39a5aa0a0de0fc2f33de800cb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86293 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-06tdf#129839: pass initialized shared_ptr to SwDoc::GetBoxAttrMike Kaganski
Regression after commit 1e2682235cded9a7cd90e55f0bfc60a1285e9a46 Change-Id: I40acc9e0ffdd292283381366a31eb6647b80324f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86291 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-06logerrit: support submitting private and wip changesIlmari Lauhakangas
Change-Id: I0ee3ac887e17b38b6a2c501bcf6a2132406f1d20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86273 Reviewed-by: Guilhem Moulin <guilhem@libreoffice.org> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-06Resolves: tdf#129518 make colorboxes max width at 1/3 avail spaceCaolán McNamara
Change-Id: I4eef1f108078bc05f7755b5befb18437c30638ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-06tdf#124176: Use pragma once instead of include guardsElzem Atay
Change-Id: I9f8637ba0bf34fa2a9f0778db42249775a75636a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86219 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-06sidebar: improve invalidation tracking for Panels.Michael Meeks
Only emit an invalidation on panels that change position. Ensure we invalidate the ScrollContainerWindow for updated separators. Emit a single vcl::Region for an invalidation rather than per panel. Change-Id: I5452791ac9a7d1a9b8604c7704d24641160c275b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86234 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86288 Tested-by: Jenkins
2020-01-06sidebar: allow panels to lurk around instead of being disposed.Michael Meeks
Creating and destroying sidebar panels is done remarkably often - on changes of context eg. The process is remarkably expensive - loading UI XML files, processing them etc. and is un-necessary. Instead let panels lurk around for future use - particularly in the Properties deck which gets the most thrash. This gives a big speedup particularly noticable on mobile where it could take several seconds to load switch between panels for eg. shape vs. slide properties when tapping to edit text. Change-Id: I497e77432c11bbd1e35a8a8716519cabc3730e61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86233 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86287 Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2024-08-03 08:47:33 +0000