summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-28loplugin:stringadd improve detectionNoel Grandin
if one side of the expression is a compile-time-constant, we don't need to worry about side-effects on the other side Change-Id: Iee71ea51b327ef244bf39f128f921ac325d74e2b Reviewed-on: https://gerrit.libreoffice.org/81589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-28cid#1455157: sw: Memory - illegal accesses (WRAPPER_ESCAPE)Michael Stahl
(regression from b522fc0646915d4da94df38dd249c88b28f25be7) Change-Id: I54f93ac16a2d4ddc687937d44c3aec450e59dd0e Reviewed-on: https://gerrit.libreoffice.org/81588 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-28jsdialogs: make possible to set .uno:BackColorSzymon Kłos
Change-Id: I2fd9a70b54f211dbfe9bb58102e17afd38516d5d Reviewed-on: https://gerrit.libreoffice.org/81587 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-28tdf#42949 Fix IWYU warnings in accessibility/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iddc1d33f5a520febf1bb317861acc2880595e7bf Reviewed-on: https://gerrit.libreoffice.org/81358 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-28external/boost: Adapt to std::allocator parts removed in C++20Stephan Bergmann
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0174r2.html#4.2> "Deprecating Vestigial Library Parts in C++17" deprecated, among others, std::allocator::rebind and std::allocator::allocate's hint parameter, and <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0619r4.html#3.9> "Reviewing Deprecated Facilities of C++17 for C++20" removed them completely. (And <https://gcc.gnu.org/git/?p=gcc.git;a=commit; h=954026a7a4e6a1affd1ac5db237ccd75a3316760> "Remove redundant std::allocator members for C++20" removed them from libstdc++ now for -std=c++2a.) The change to boost/bimap/detail/bimap_core.hpp was necessary in Library_pdfimport: > In file included from workdir/UnpackedTarball/boost/boost/bimap/bimap.hpp:61, > from external/boost/include/boost/bimap/bimap.hpp:30, > from sdext/source/pdfimport/inc/pdfiprocessor.hxx:49, > from sdext/source/pdfimport/pdfiadaptor.cxx:27: > workdir/UnpackedTarball/boost/boost/bimap/detail/bimap_core.hpp: In instantiation of ‘class boost::bimaps::detail::bimap_core<boost::bimaps::unordered_set_of<pdfi::GraphicsContext, pdfi::GraphicsContextHash>, boost::bimaps::unordered_set_of<int>, mpl_::na, mpl_::na, mpl_::na>’: > workdir/UnpackedTarball/boost/boost/bimap/bimap.hpp:133:7: required from ‘class boost::bimaps::bimap<boost::bimaps::unordered_set_of<pdfi::GraphicsContext, pdfi::GraphicsContextHash>, boost::bimaps::unordered_set_of<int> >’ > sdext/source/pdfimport/inc/pdfiprocessor.hxx:190:44: required from here > workdir/UnpackedTarball/boost/boost/bimap/detail/bimap_core.hpp:410:7: error: no class template named ‘rebind’ in ‘boost::bimaps::detail::manage_additional_parameters<mpl_::na, mpl_::na, mpl_::na>::case_NNN::allocator’ {aka ‘class std::allocator<void>’} > 410 | > core_type; > | ^~~~~~~~~ [...] The change to boost/format/alt_sstream_impl.hpp was necessary in ExternalProject_libpagemaker: > In file included from libpagemaker_utils.h:22, > from geometry.h:20, > from OutputShape.h:17, > from OutputShape.cpp:10: > external/boost/include/boost/cstdint.hpp:30:2: warning: #include_next is a GCC extension > 30 | #include_next <boost/cstdint.hpp> > | ^~~~~~~~~~~~ > In file included from workdir/UnpackedTarball/boost/boost/format/alt_sstream.hpp:174, > from workdir/UnpackedTarball/boost/boost/format/internals.hpp:24, > from workdir/UnpackedTarball/boost/boost/format.hpp:38, > from PMDExceptions.h:15, > from OutputShape.h:16, > from OutputShape.cpp:10: > workdir/UnpackedTarball/boost/boost/format/alt_sstream_impl.hpp: In instantiation of ‘boost::io::basic_altstringbuf<Ch, Tr, Alloc>::int_type boost::io::basic_altstringbuf<Ch, Tr, Alloc>::overflow(boost::io::basic_altstringbuf<Ch, Tr, Alloc>::int_type) [with Ch = char; Tr = std::char_traits<char>; Alloc = std::allocator<char>; boost::io::basic_altstringbuf<Ch, Tr, Alloc>::int_type = int]’: > workdir/UnpackedTarball/boost/boost/format/alt_sstream_impl.hpp:227:9: required from here > workdir/UnpackedTarball/boost/boost/format/alt_sstream_impl.hpp:261:45: error: no matching function for call to ‘std::allocator<char>::allocate(std::size_t&, char*)’ > 261 | newptr = alloc_.allocate(new_size, is_allocated_? oldptr : 0); > | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from gcc/trunk/inst/include/c++/10.0.0/memory:64, > from OutputShape.h:13, > from OutputShape.cpp:10: > gcc/trunk/inst/include/c++/10.0.0/bits/allocator.h:164:7: note: candidate: ‘constexpr _Tp* std::allocator< <template-parameter-1-1> >::allocate(std::size_t) [with _Tp = char; std::size_t = long unsigned int]’ > 164 | allocate(size_t __n) > | ^~~~~~~~ > gcc/trunk/inst/include/c++/10.0.0/bits/allocator.h:164:7: note: candidate expects 1 argument, 2 provided Change-Id: Id423f7597fe2e84e57df1d48a2ecc4d636c4a913 Reviewed-on: https://gerrit.libreoffice.org/81584 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-28external/breakpad: Adapt to std::allocator parts removed in C++20Stephan Bergmann
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0174r2.html#4.2> "Deprecating Vestigial Library Parts in C++17" deprecated, among others, std::allocator::pointer, and <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0619r4.html#3.9> "Reviewing Deprecated Facilities of C++17 for C++20" removed it completely. (And <https://gcc.gnu.org/git/?p=gcc.git;a=commit; h=954026a7a4e6a1affd1ac5db237ccd75a3316760> "Remove redundant std::allocator members for C++20" removed it from libstdc++ now for -std=c++2a.) The change to src/common/memory.h was necessary in Library_crashreport: > In file included from workdir/UnpackedTarball/breakpad/src/client/linux/dump_writer_common/thread_info.h:37, > from workdir/UnpackedTarball/breakpad/src/client/linux/minidump_writer/linux_dumper.h:51, > from workdir/UnpackedTarball/breakpad/src/client/linux/minidump_writer/minidump_writer.h:41, > from workdir/UnpackedTarball/breakpad/src/client/linux/handler/exception_handler.h:42, > from desktop/source/app/crashreport.cxx:29: > workdir/UnpackedTarball/breakpad/src/common/memory.h: In instantiation of ‘struct google_breakpad::PageStdAllocator<int>’: > gcc/trunk/inst/include/c++/10.0.0/bits/stl_vector.h:84:21: required from ‘struct std::__cxx1998::_Vector_base<int, google_breakpad::PageStdAllocator<int> >’ > gcc/trunk/inst/include/c++/10.0.0/bits/stl_vector.h:386:11: required from ‘class std::__cxx1998::vector<int, google_breakpad::PageStdAllocator<int> >’ > gcc/trunk/inst/include/c++/10.0.0/debug/vector:118:11: required from ‘class std::__debug::vector<int, google_breakpad::PageStdAllocator<int> >’ > workdir/UnpackedTarball/breakpad/src/common/memory.h:197:7: required from ‘class google_breakpad::wasteful_vector<int>’ > workdir/UnpackedTarball/breakpad/src/client/linux/minidump_writer/linux_dumper.h:187:26: required from here > workdir/UnpackedTarball/breakpad/src/common/memory.h:165:47: error: no type named ‘pointer’ in ‘class std::allocator<int>’ > 165 | typedef typename std::allocator<T>::pointer pointer; > | ^~~~~~~ Change-Id: Id7559456cc75311837aaa9f3a531f8820d5f593d Reviewed-on: https://gerrit.libreoffice.org/81585 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-28tdf#125191 Give object copies unique namesJim Raykowski
This patch makes a unique name for a copy of an object having a user given name. Change-Id: I14a7f45cc02962fc34a1532dd5db1cb9657b41d3 Reviewed-on: https://gerrit.libreoffice.org/77500 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-28sw: prefix members of SwTestItemMiklos Vajna
See tdf#94879 for motivation. Change-Id: Iddabca468db597791e11ff3ad4be68e14efc6680 Reviewed-on: https://gerrit.libreoffice.org/81583 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-28add some __attribute__ ((formatNoel Grandin
found by -Wsuggest-attribute=format Change-Id: Ib4430805ddebf4d90e07a3f9d06fd6d832c244a4 Reviewed-on: https://gerrit.libreoffice.org/81582 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-28jsdialogs: make possible to set .uno:FontColorSzymon Kłos
Change-Id: I5ece252d3b7e9dca7c97395c70be6ea4863d7545 Reviewed-on: https://gerrit.libreoffice.org/81498 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-28Improve the way %PRODUCTVERSION is expanded in 'tipoftheday'Christophe JAILLET
Expand %PRODUCTVERSION in a much cleaner way. Follow up to commit 0ed7f9dab2ec03e168f2013e57c21637f7700736 Change-Id: If3d03cba19f89849c930d6dc3f1e07a65115e4e0 Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-on: https://gerrit.libreoffice.org/77862 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-27tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScStyleObj. Change-Id: Ic4f2d69d0b569de9fe99c8af41370b0699f2ab1b Reviewed-on: https://gerrit.libreoffice.org/81556 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-10-27Add bin/lo-xlate-langEike Rathke
Change-Id: Idd280f3cf9cc0e1b63a6afea3b3dcbe3ed34ac14
2019-10-27tdf#128393 change sorting while thawedCaolán McNamara
Change-Id: I9670c1557e0b39f9dde1f068bb091b9459d89baa Reviewed-on: https://gerrit.libreoffice.org/81533 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-27bin/lo-xlate-lang: map szl -> upper_silesianRene Engelhard
Change-Id: I84bf5426fa50fbaa0287c3ce0553ba2ccdfd1102
2019-10-27tdf#45904 Move XNamed Java tests to C++Jens Carl
Move XNamed Java tests to C++ for ScStyleObj. Change-Id: Idaff7307d15ca2665005e866dff36a033aa91354 Reviewed-on: https://gerrit.libreoffice.org/81553 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-10-27Resolves: tdf#117715 Conditional format takes precedence; reverts tdf#93300Eike Rathke
Change-Id: I635ca58961ae5ae315bdd77c4fff9f3f41bebd15 Reviewed-on: https://gerrit.libreoffice.org/81550 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-10-26Colibre: tdf#127976, Fix icons in Navigator Writer master document moderizmut
- Fix for exit search icons - Update Manage Name icons in Calc Change-Id: I0302e710b65dda5ea094c7fb0899c242a34fdeb9 Reviewed-on: https://gerrit.libreoffice.org/81546 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-10-26Resolves: tdf#128403 Use ScPatternAttr::GetNumberFormat()Eike Rathke
... it does or will do the right thing. See also https://bugs.documentfoundation.org/show_bug.cgi?id=117715#c12 Change-Id: I4ecaa6be8b2358d4ea4d84655cde74dce5319c2a Reviewed-on: https://gerrit.libreoffice.org/81548 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2019-10-26Related: tdf#117715 tdf#128403 Couple ATTR_LANGUAGE_FORMAT ATTR_VALUE_FORMATEike Rathke
Do not obtain ATTR_VALUE_FORMAT from hard attribute and ATTR_LANGUAGE_FORMAT from conditional format. Though it doesn't matter in the bugs' cases it's wrong. ATTR_LANGUAGE_FORMAT belongs to the ATTR_VALUE_FORMAT if set. Change-Id: I9ec2d7523e22a40c3fe4a655fe9082ab6158c376 Reviewed-on: https://gerrit.libreoffice.org/81547 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-10-26Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add screenshot for Security option page Use kde5 breeze theme. Change-Id: I73c244be73793f1d8afb8906ef8152518c1f3e6a Reviewed-on: https://gerrit.libreoffice.org/81536 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-26ensure id is valid before useCaolán McNamara
Change-Id: Id0b5d07bbe3d2095858f9c3773d1acab3eac9636 Reviewed-on: https://gerrit.libreoffice.org/81532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-26Resolves: tdf#128359 Do nothing if Insert After can't be shifted to BeforeEike Rathke
Change-Id: I63bf24cda4d14857f9b5cf63a95d35b6438cead1 Reviewed-on: https://gerrit.libreoffice.org/81518 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-10-26Add unit test for adjacent formula-groups with...Dennis Francis
indirect intergroup dependency. Change-Id: If8b77116855806d0ba3cdcef8ff8aa17e581d9f9 Reviewed-on: https://gerrit.libreoffice.org/81491 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-10-26Fallback gracefully if intergroup dependencies found when...Dennis Francis
trying to do multi-formula-group threading. Do this like what we do for detecting formula-group cycles. This fixes the crash on the crashtest-document fdo31831-1.ods. Change-Id: I8115acc7dac39e12afb6fd7aafb9e7ce88d30ad4 Reviewed-on: https://gerrit.libreoffice.org/81490 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-10-26tdf#128285 Only update Navigator heading tracking if document has focusJim Raykowski
Change-Id: I8e4d9a7b80bdae32d83349db20058f2be62e02c1 Reviewed-on: https://gerrit.libreoffice.org/81539 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-26size some stringbuffer to prevent re-allocNoel Grandin
I started with 32 and kept doubling the size until the site did not need re-alloc, but clamped it at 512 (e.g. in emfio/). Change-Id: Ib7caf35a1b7e42b0e4ed8aa812493449e3eefc8f Reviewed-on: https://gerrit.libreoffice.org/81540 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-26tdf#127927 Character dialog update position tabandreas kainz
Change-Id: I336f7457ad92d505755abe8dca8bbc1ca813ce4c Reviewed-on: https://gerrit.libreoffice.org/81040 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-26 Breeze: tdf#127976, Fix icons in Navigator Writer master document moderizmut
- Fix for find search icons - Update Add Name and Manage Name icons in Calc - Fix blurred CHANGE CASE TO UPPER icons Change-Id: Ib0d21a592f636ebd192f1c5bfdb0e316edc0f403 Reviewed-on: https://gerrit.libreoffice.org/81541 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-10-26Update git submodulesMike Kaganski
* Update helpcontent2 from branch 'master' - Improve "Referencing Other Sheets" documentation Change-Id: Iceb396337a189958919811206dfcfdf8510a24a7 Reviewed-on: https://gerrit.libreoffice.org/79482 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-26tdf#128364 Navigator headings left arrow key behavior changeJim Raykowski
When in headings content navigation view root mode unselect entries before passing left arrow key on for handling. Change-Id: I671b27da98cb04ad8980234f44e7636f4239817c Reviewed-on: https://gerrit.libreoffice.org/81538 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-25lok: disable page break view for tiled rendering mode.Michael Meeks
Why ? dotted lines fail to join giving differences in the grid depending on render position, vcl's LineInfo has no offset to compensate (yet). Restore when vcl's LineInfo is better. Change-Id: I45803ee80c8fcefd17a37dc3fd93fbafd94fffd4 Reviewed-on: https://gerrit.libreoffice.org/81530 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-25lok: improve tilebench and add an unpleasant text rendering test case.Michael Meeks
Change-Id: I9e769cff6db794389bcef821c08ca1cd60173ab9 Reviewed-on: https://gerrit.libreoffice.org/81531 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-25Fix build in vclJulien Nabet
/home/julien/lo/libreoffice/vcl/unx/gtk3/a11y/gtk3atkwrapper.cxx: In function ‘AtkObject* atk_object_wrapper_new(const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>&, AtkObject*, AtkObject*)’: /home/julien/lo/libreoffice/vcl/unx/gtk3/a11y/gtk3atkwrapper.cxx:866:53: error: ‘XAccessibleContext2’ is not a member of ‘com::sun::star::accessibility’; did you mean ‘XAccessibleContext’? 866 | css::uno::Reference<css::accessibility::XAccessibleContext2> xContext2(xContext, css::uno::UNO_QUERY); | ^~~~~~~~~~~~~~~~~~~ | XAccessibleContext /home/julien/lo/libreoffice/vcl/unx/gtk3/a11y/gtk3atkwrapper.cxx:866:72: error: template argument 1 is invalid 866 | css::uno::Reference<css::accessibility::XAccessibleContext2> xContext2(xContext, css::uno::UNO_QUERY); | ^ /home/julien/lo/libreoffice/vcl/unx/gtk3/a11y/gtk3atkwrapper.cxx:866:113: error: expression list treated as compound expression in initializer [-fpermissive] 866 | css::uno::Reference<css::accessibility::XAccessibleContext2> xContext2(xContext, css::uno::UNO_QUERY); | ^ /home/julien/lo/libreoffice/vcl/unx/gtk3/a11y/gtk3atkwrapper.cxx:866:84: error: left operand of comma operator has no effect [-Werror=unused-value] 866 | css::uno::Reference<css::accessibility::XAccessibleContext2> xContext2(xContext, css::uno::UNO_QUERY); | ^~~~~~~~ /home/julien/lo/libreoffice/vcl/unx/gtk3/a11y/gtk3atkwrapper.cxx:867:27: error: request for member ‘is’ in ‘xContext2’, which is of non-class type ‘int’ 867 | if( xContext2.is() ) | ^~ /home/julien/lo/libreoffice/vcl/unx/gtk3/a11y/gtk3atkwrapper.cxx:869:59: error: base operand of ‘->’ is not a pointer 869 | OString aId = OUStringToOString( xContext2->getAccessibleId(), RTL_TEXTENCODING_UTF8); Due to https://cgit.freedesktop.org/libreoffice/core/commit/?id=07359ea21cf27e29d3e642d6ff1851155888a875 Change-Id: I61967a41f43a31199369e5c25e008259ca3786dc Reviewed-on: https://gerrit.libreoffice.org/81514 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-25sw ContinuousEndnotes: fix moving them to the previous pageMiklos Vajna
If you delete the first page of a document, the endnotes remained on an empty last page. Fix this. Change-Id: I70187c4c32490178366e024606926d3cebcaa680 Reviewed-on: https://gerrit.libreoffice.org/81512 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-25tdf#126324 Import custom date as custom XTextFieldTamas Bunth
Change-Id: I89f96490a47210e7daa3b21b2399e0dfe0cf3abf Reviewed-on: https://gerrit.libreoffice.org/81513 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-10-25sd: fix missing includeMiklos Vajna
Change-Id: I696268d5eb27c51a9058da354676feceba4813da
2019-10-25fix buildRene Engelhard
Change-Id: I494f2b6509ed42a80ad807b56f200832de407c31
2019-10-25svx: fix missing includeMiklos Vajna
Change-Id: I035d36adb611aaa1207430e16ea6c8613cacef59
2019-10-25Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix links for basic_2_python page Change-Id: I7ffd91ea10b22a5215a77be9639dd8d9c27c9ed0 Reviewed-on: https://gerrit.libreoffice.org/81509 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-25tdf#42949 Fix IWYU warning in include/vcl/window.hxxGabor Kelemen
The boost/property_tree/ptree.hpp added in commit 75b8db7fa7344a679d3c5dbdc8c5bd4228cdbc7c turns out to be rather expensive: it adds about 900 kB per compilation unit and window.hxx is included in about 2600 compilation units Replacing it with forward declaration header has reduced total includebloat from 26.1 Gb to about 22.7 Change-Id: I797608b54a62a5838c7a5d47355fb6bd736ad36c Reviewed-on: https://gerrit.libreoffice.org/81500 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-25speed-up shape import if shapes need z-order rearrangingKatarina Behrens
setting z-order individually on each shape and broadcasting is O(n^2) (remaining shapes also need reordering) and this is bad bad bad for performance Change-Id: Ic9c9137a097f6ff524192693910f221885f77cc4 Reviewed-on: https://gerrit.libreoffice.org/75055 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-25map gtk-add and gtk-remove iconsCaolán McNamara
Change-Id: I2c96ecbc4f8e8a45459d497c7e5183fec2e9f0cd Reviewed-on: https://gerrit.libreoffice.org/81502 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-25set second child to remaining sizeCaolán McNamara
Change-Id: I2fad36cb4cb866418dcf4514e2f23b9658a957ed Reviewed-on: https://gerrit.libreoffice.org/81501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-25ofz#18528 null derefCaolán McNamara
Change-Id: I3eff3f9524c73ac476018dc2d3c389dc7128c6b2 Reviewed-on: https://gerrit.libreoffice.org/81504 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-25remove unnecessary .uis 'require' on lib=LibreOfficeCaolán McNamara
Change-Id: I3d953f63bb3c97105de31bcdad26b3cf0d1322e6 Reviewed-on: https://gerrit.libreoffice.org/81493 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-25android: Fix problems with unwinding in the Online-based Android app.Jan Holesovsky
This partially reverts a7f6338875931d8afff55cb39ead8f6600af04cb. The problem is that with that approach, the problems with unwinding as described in 312eeeee42cb4a1e356943e17305555e41afc4ef were plaguing the Online-based Android app, leading to mysterious crashes with stack traces like: #00 pc 0005f2b6 /apex/com.android.runtime/lib/bionic/libc.so (abort+166) (BuildId: 68c87e04526a60689ecb5deb329804a0) #01 pc 05caaae7 /data/app/libreoffice.debug-fBEOIUwPHY3_k3eQid159Q==/lib/arm/liblo-native-code.so (BuildId: 1c3d0e6336ddfc3578e1c186944160252a750b8b) ... #06 pc 07452e43 /data/app/libreoffice.debug-fBEOIUwPHY3_k3eQid159Q==/lib/arm/liblo-native-code.so (BuildId: 1c3d0e6336ddfc3578e1c186944160252a750b8b) #07 pc 0005a37c /apex/com.android.runtime/lib/bionic/libc.so (__restore_rt) (BuildId: 68c87e04526a60689ecb5deb329804a0) #08 pc 0005f2b2 /apex/com.android.runtime/lib/bionic/libc.so (abort+162) (BuildId: 68c87e04526a60689ecb5deb329804a0) #09 pc 07565d3b /data/app/libreoffice.debug-fBEOIUwPHY3_k3eQid159Q==/lib/arm/liblo-native-code.so (BuildId: 1c3d0e6336ddfc3578e1c186944160252a750b8b) ... #11 pc 07565641 /data/app/libreoffice.debug-fBEOIUwPHY3_k3eQid159Q==/lib/arm/liblo-native-code.so (BuildId: 1c3d0e6336ddfc3578e1c186944160252a750b8b) #12 pc 0001e394 /apex/com.android.runtime/lib/bionic/libm.so (__gnu_Unwind_RaiseException+108) (BuildId: 0ee3a75927e0da4fa0fe29469ccf8b39) #13 pc 0001eee8 /apex/com.android.runtime/lib/bionic/libm.so (_Unwind_RaiseException+20) (BuildId: 0ee3a75927e0da4fa0fe29469ccf8b39) Change-Id: Ie4e7b20380c9104770229a8d30036ad76093283d Reviewed-on: https://gerrit.libreoffice.org/81485 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-10-25sc: rowcol: tdf#50916 convert filter/excel for the most partAron Budea
Change-Id: I8ae255de6fcd9d7fd379a48fb7e84adcbf7fa4ff TODO: pieces in frmbase.cxx, xestream.cxx and xistyle.cxx Reviewed-on: https://gerrit.libreoffice.org/81486 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-25Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - Wrong links & extra bookmarks Change-Id: I454e5ee23a17e48931dee2d51ad1639fb73ecba9 Reviewed-on: https://gerrit.libreoffice.org/81487 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-25Resolves: tdf#128218 Let RAND() return a scalar double instead of a 1x1 matrixEike Rathke
... even if in array context, for FunctionAccess.callFunction() compatibility. Change-Id: Iddfb462dd1b5812c94a2f2061c593b4479faef24 Reviewed-on: https://gerrit.libreoffice.org/81482 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins