summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-04-13Version 7.5.3.1, tag libreoffice-7.5.3.1libreoffice-7.5.3.1Christian Lohmaier
2023-04-13bump product version to 7.5.3.1Christian Lohmaier
Change-Id: I67e824e817fa7333583c03817aa936138b633f07
2023-04-13Branch libreoffice-7-5-3Christian Lohmaier
This is 'libreoffice-7-5-3' - the stable branch for the 7.5.3 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.5.x release, please use the 'libreoffice-7-5' branch. If you want to build something cool, unstable, and risky, use master.
2023-04-13Upgrade Harfbuzz to 7.1.0Taichi Haradaguchi
* Fixes CVE-2023-25193. * if Harfbuzz >= 7.0.0, uses hb_font_draw_glyph() instead of hb_font_get_glyph_shape(). * Update URL in README. Change-Id: Id234c2b459c40ddac340731b44889b104e03a1e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148759 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-04-13Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-5' to c81f321246e0339e53f9fb8099e26bf24014703c - update translations for 7.5.3 rc1 and force-fix errors using pocheck Change-Id: I960d8a8b6882e764da0b49bc55b0bbc9ce94698b
2023-04-13Related: tdf#153374 Don't release autoreleased attributeNamesPatrick Luby
Also, return an autoreleased empty array instead of a retained array. Change-Id: I5f494b301dbae859486d6bc4874112b714022b60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150307 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> (cherry picked from commit 127eacf630e1712fd5addcabed404b2d33752311) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150316 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-04-13tdf#154708 Preserve selection for repeating Shift-arrow on Japanese keyboardPatrick Luby
Skip the posting of SalEvent::ExtTextInput and SalEvent::EndExtTextInput events for private use area characters. Change-Id: I6fa5dedacefc5d9dd671f607786deb999f5e4c6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150248 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> (cherry picked from commit 1b06f35de68a555b85bceb5fc29d1a5f426f4bb7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150203 Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
2023-04-13tdf#154565 ignore unwanted crossing event from search to treeview on "enter"Caolán McNamara
i.e if the crossing was triggered ultimately by a key stroke which is likely from exiting the search box. This way we can avoid the problem that with hover-selection that after "enter" is used in the search box, selecting a matching row, then during teardown of the widget the box is hidden, and the generated crossing notification triggers unwanted selection of a different row under the mouse. If needs be this could be refined further to only happen for a specific key or other details of the triggering event Change-Id: I7e64fb5fa31a446b85016d86ecd314d13130d7b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149979 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-13tdf#154753 if substituting with OpenSymbol check if there for a recodeCaolán McNamara
entry for that font->OpenSymbol conversion. It might make sense to drop the conditionals and just use the result of ConvertChar::GetRecodeData if there are any, but keep close to what has worked historically. Change-Id: Idf9ee0f8068f1ff8e7f179ba5087763e44ade268 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150201 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-13tdf#154658: XML Form Document: Fields doesnt calculate any moreJulien Nabet
Regression from 73334560b2dd2d60ac58d2cc2b1a5295490b03e1 author Julien Nabet <serval2412@yahoo.fr> 2021-11-07 15:40:37 +0100 committer Julien Nabet <serval2412@yahoo.fr> 2021-11-07 21:58:53 +0100 commit 73334560b2dd2d60ac58d2cc2b1a5295490b03e1 (patch) tree b5bc4f69dd8ed455c78ea05ab1c5e2f3c25b909e parent 6be03ac71e0d4927612b4a57ead3d0b245c29c77 (diff) Replace some macros in forms part 16 A big thank you to Raal for having spotted this! Change-Id: Ib6f1878897b16b43df287702f82835824c1f766d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150174 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins (cherry picked from commit d02b05ba872bf877a62e62ebb48835d618eb1b28) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150151 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-13ScriptForge (SF_FileSystem) tdf#154462 2nd call of PickFile() failsJean-Pierre Ledure
Error happens in gen and gtk3 modes. Does not happen in kf5 mode. Linux only. Windows OK. Patch on master: https://git.libreoffice.org/core/commit/9c60996fc2a536803d016d6f60f879f8a1e49a54 Change-Id: I2f28b389d33a62af969e9d48e398fa220f99d347 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150297 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2023-04-12tdf#154771 sw: fix drag & drop moving of table columnsLászló Németh
Only first selected column was moved, the other ones were copied during drag & drop moving of table columns. Regression from commit 5e8aa259e48d5602b932353bb146ebb523982cf2 "tdf#146967 sw table: fix freezing in Hide Changes mode". Follow-up to commit 912336f3c85d9a631fa0ac0f270bab04b204f619 "tdf#154599 sw: fix crash at drag & drop table columns". Change-Id: I31ca5b3d6004ed53c11a951fa184b9db48f21041 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150280 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 49f80aedf3f2dff70aa410319e80e8622dfa31a1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150207 Tested-by: László Németh <nemeth@numbertext.org>
2023-04-11tdf#153923: In ReqIF case, avoid fake dl/dd used to emulate indentationMike Kaganski
Change-Id: Iac85350c8f52a39173a07131c67e7dc943aa140e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150229 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 3ce1616ea371e0efd317290bb4f943f319404800) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150200 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-11Fix heap-buffer-overflowStephan Bergmann
...during CppunitTest_sc_ucalc, after 40e3e9fd1c501cc1978d4370b6392701ccd42a71 "tdf#113027 - Allow cycling cell reference types including whitespaces", > ==5140==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x604000cfba74 at pc 0x7f36cb07ef6e bp 0x7ffd061d34d0 sp 0x7ffd061d34c8 > READ of size 2 at 0x604000cfba74 thread T0 > #0 0x7f36cb07ef6d in (anonymous namespace)::FindEndPosR1C1(char16_t const*, int, int) /sc/source/core/tool/reffind.cxx:91:13 > #1 0x7f36cb07cf0f in (anonymous namespace)::FindEndPos(char16_t const*, int, int, formula::FormulaGrammar::AddressConvention) /sc/source/core/tool/reffind.cxx:126:20 > #2 0x7f36cb07b029 in ScRefFinder::ToggleRel(int, int) /sc/source/core/tool/reffind.cxx:262:28 > #3 0x7f36c7b8482b in testTdf113027::TestBody() /sc/qa/unit/ucalc.cxx:467:13 > > 0x604000cfba74 is located 0 bytes to the right of 36-byte region [0x604000cfba50,0x604000cfba74) > allocated by thread T0 here: > #0 0x4b7c20 in malloc /home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_malloc_linux.cpp:145 > #1 0x7f371b927c59 in _rtl_uString* rtl::str::Alloc<_rtl_uString>(int) /sal/rtl/strtmpl.hxx:833:46 > #2 0x7f371b92640f in void rtl::str::newFromStr_WithLength<_rtl_uString, char>(_rtl_uString**, char const*, int, int) /sal/rtl/strtmpl.hxx:947:15 > #3 0x7f371b9797f0 in rtl_uString_newFromLiteral /sal/rtl/ustring.cxx:1252:5 > #4 0x7f36c7dab771 in rtl::OUString::OUString<char const [14]>(char const (&) [14], rtl::libreoffice_internal::ConstCharArrayDetector<char const [14], rtl::libreoffice_internal::Dummy>::Type) /include/rtl/ustring.hxx:365:13 > #5 0x7f36c7b843e8 in testTdf113027::TestBody() /sc/qa/unit/ucalc.cxx:462:31 (<https://ci.libreoffice.org/job/lo_ubsan/2739/>) Change-Id: Ie8d053cdb56bdf00bf21663b05521eca632ddfbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150219 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins (cherry picked from commit dc80c92a1e63fd88560fd77261b96f6c5be97273) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150199 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-11set Referer on loading IFramesCaolán McNamara
so tools, options, security, options, "block any links from document not..." applies to their contents. Change-Id: I04839aea6b07a4a76ac147a85045939ccd9c3c79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150225 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-11Related: tdf#154218 Use proper locale in SwUserFieldType::PutValue()Eike Rathke
The cast to sal_uInt16 actually called the overloaded DoubleToString(...,sal_uInt32) with the LanguageType value used as format key number. Change-Id: I74415ff5504369d437df8caab02ecb61eb853143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150186 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 5a6d03f656329263cc3be4ce0ea9a0ea2373606e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150198 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-10crashreporting: getUsedFontList() crashCaolán McNamara
e.g. https://crashreport.libreoffice.org/stats/crash_details/3a3c07aa-0f96-4efa-b55b-c3fe4e4b6ed8 ... Crash Reason EXCEPTION_ACCESS_VIOLATION_READ Crash Address 0x0 ... XMLFontAutoStylePool::getUsedFontList() xmloff\source\style\XMLFontAutoStylePool.cxx:334 XMLFontAutoStylePool::exportXML() xmloff\source\style\XMLFontAutoStylePool.cxx:408 Change-Id: I5d057b8e639260f6d00e731c3af7bab7203a8814 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150152 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-10tdf#154631: fix Export as gif ignores transparence of objectsJulien Nabet
As noel indicated in https://bugs.documentfoundation.org/show_bug.cgi?id=154631#c6 "GIF does not (as far as I can tell) support partial transparency, it only has full or none transparency. See specs linked from https://en.wikipedia.org/wiki/GIF" Change-Id: Ib110f344a6b8f0fdfd1355e6521d979b33548709 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150184 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 3ebe2e7170b093bfd1c417b5907f713df591654a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150195 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-08tdf#154695: use Chapter Numbering Rules to confirm that ToC needs tabsMike Kaganski
Indeed, this still can't handle it per-element, like Word does: the latter would omit both the number and the tab for headings without numbering. But at least the most common case should be handled better now. Change-Id: I0be5d61a5d2cbbf778ee88a11129a6e7655593ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150133 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit b6a5f16a9bf3227867bf46b88d012440138b6f24) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150142 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-08tdf#154599 sw: fix crash at drag & drop table columnsLászló Németh
New code path for (tracked) row deletion resulted broken column deletion, by deleting more columns at their drag & drop, than needed. Regression from commit 5e8aa259e48d5602b932353bb146ebb523982cf2 "tdf#146967 sw table: fix freezing in Hide Changes mode". Change-Id: Ib649f5b534a588d192d27757e30c8f81087beb0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150132 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 491e84eb7c6d92c44ab7fa62912452f7789bb8c8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150145
2023-04-08tdf#113027 - Allow cycling cell reference types including whitespacesAndreas Heinisch
A formula containing a remote reference to a sheet including a whitespace in its name does not correctly handle switching from relative to absolute cell references using the EXCEL R1C1 formular grammar. Change-Id: I3391f4e8f57993899b5e97f0a173b624b5ef0b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150109 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150130 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-07sd: fix crash in DrawViewShell::ExecCtrlXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/sd::DrawViewShell::ExecCtrl(SfxRequest%20&) I believe this crash is triggered with some basic code while slideshow is running. Anyway, if I delete the previous SlideShow::IsRunning(GetViewShellBase()) check, launch Impress and add a new slide, LibreOfice also crashes. Change-Id: Iba40f37485a4a6815729a1a26c380b6c3fdedfd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150097 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 6a1425c4c9595ed82629d846c9b69ed9942b2c0b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150079
2023-04-07tdf#89920 - Handle embedded newline in Calc's search cellAndreas Heinisch
Update short-circuited boolean expression so the least expensive subexpressions will be executed first Change-Id: I8c924e00e8de809f3e6df2828f8537185e71c18c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149891 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit 8fc316fb65e0d4b78ec881aa79f4184602b96f54) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150140 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-07Resolves: tdf#154680 don't mark an empty fontname as italic for "unknown"Caolán McNamara
its used for 'ambigious' rather than 'unknown' Change-Id: I1aeb2f825c5e611e0a943a6ce5f3ab58658701bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150136 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-07tdf#154629 inspector sidebar panel use-after-free on switch to print previewCaolán McNamara
Change-Id: I5489cd18213d82ae4174ca8d9d00f1da5aa1091d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150078 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-07Resolves: tdf#154582 Obtain English DisplayName before CompatibilityNameEike Rathke
... for Add-Ins from configuration. Change-Id: If13d692ca7550e69d2f6e3ff72747d17aee3e7f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149995 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit dcb50fe7444dd746ba4d3f8476026bb997a595b5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149976 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-07tdf#89920 - Handle embedded newline in Calc's search cellAndreas Heinisch
If the replaced string contains a newline after find and replace, insert an edit cell in order to handle an embedded line correctly regardless of the content in the source cell. Change-Id: Ic8a5fc80b85546897572a228511b319cd5a8b9aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148752 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149950
2023-04-07fix bug in WrappedRegressionCurvesProperty::setValueToSeriesNoel Grandin
ever since commit 1cd3e2038010cb37bda82d38dd058b793b7eec26 Author: Tomaž Vajngerl <quikee@gmail.com> Date: Sat Jun 29 18:43:16 2013 +0200 Multiple trendline removing and changing type support. Change-Id: Ibd24d0831932f25e60c05a00450d611e15875102 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149691 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2714b18cbaefb13131ae63396297cd57b564a3af) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149698 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-07tdf#149064 ensure interaction handler is present when transfering with webDAVJaume Pujantell
Change-Id: I7a31f708e6fe01f07c7187aacd4657b5c6156c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149722 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 50848b06ea58a147f5b89f057880266518ce79e7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149697 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-07tdf#154322 select the first entry of the current page by defaultCaolán McNamara
rather than default to nothing selected, if we switch pages and then back to page 1 this will be selected anyway, so start off that way Change-Id: Ia684a5e44b12c984df3920f18b34c99693a2702c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149428 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-07Related: tdf#153628 too many "Activate" calls with gtkCaolán McNamara
for container_focus_changed (as documented) we only want notifications for focus entering a child of the container and focus lost to some widget not in the container, not movement within the container has-toplevel-focus is sufficient for this for GtkWindow (GtkDialog) and we should omit the GtkContainer set-focus-child callback when using the GtkWindow has-toplevel-focus Change-Id: Id5e86b8035fd578b61c8869b91e6097b015ec411 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149517 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-07instdir/share/registry/res/registry_de.xcd is effectively emptyCaolán McNamara
I find with GNU Make 4.3 and find 4.9.0 I get a workdir/CustomTarget/postprocess/registry/registry_de.list with no entries, though my libreoffice-7.3 build has a populated one and this makefile is the same as in that version. Change-Id: I45ffb381c4c962cd80c3e07e7539d993f86101d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149394 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-07tdf#149805 tdf#151677 tdf#152217 tdf#154043 tdf#153458 tdf#153800 Revert ↵Michael Weghorn
"VCL expect ... correct frame size for native menubars" This reverts commit afc828b9833b7a612369e95606ba56d41ef2c369 Date: Sat May 28 23:47:21 2022 +0200 VCL expect correct frame size for native menubars ... and renove the wrong framesize hack in the Qt backend because it caused several regressions and unfortunately the commit also doesn't fix all of the bugs mentioned in its commit message (while some previous patch sets of the change did address more, yet had other issues, s.a. the discussion in the commit's Gerrit change [1]). While e.g. the drag and drop issues reported in tdf#153458 and tdf#153800 could be fixed by translating the event position using `mapToParent()` (as is done in `QtWidget::fillSalAbstractMouseEvent` with the above commit in place), I currently don't see how to address the other issues and the overall direction of the change is not fully clear to me at this point. (There are also other pending changes in the relation change still pending in Gerrit that would presumably need more work/analysis.) After all, it seems the best way forward to revert the commit for now. This also reverts the follow-up commit commit 25da92004038c03c0feedf373e8038e7ee3e0c37 Date: Thu Jul 21 11:33:02 2022 +0200 Make JunitTest_toolkit_unoapi_1 succeed again on macOS that fixed a test failure introduced by the above commit. Luckily, there seem to be no follow-up commits that depend on this and the commits can be reverted cleanly without the need to resolve any conflicts manually. This reverts commit 25da92004038c03c0feedf373e8038e7ee3e0c37. This reverts commit afc828b9833b7a612369e95606ba56d41ef2c369. [1] https://gerrit.libreoffice.org/c/core/+/135082 Change-Id: I4c099ad7de8cbbad10da391ede4770d8c748fbde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149495 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit f51b220b953ec71fb742f799fbe645a93cf3d944) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149699 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-07Resolves: tdf#154627 RANK() query value not in data must return errorEike Rathke
For all RANK(), RANK.EQ(), RANK.AVG(). Also, use #N/A NotAvailable instead of #VALUE! NoValue. This made it necessary to adapt sc/qa/unit/data/ods/functions.ods and result check that had a totally senseless query value with arbitrary results. Change-Id: If835b5ed49caf16a813b4ea897e1d7dd1aa02954 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150067 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 14874c539e0ae55c77d752fc6870367b6ebcad9a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150084 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-07tdf#154470 try moving the Show of the client to after the float positioningCaolán McNamara
Change-Id: I785120bdad1a3c3311aeca0c8ec5b8b014999872 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150108 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150116 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-07tdf#153887 Fraction number format: avoid 0/0Laurent Balland
If round value is an integer and there is no integer part in the number format, then nDiv was wrongly forced to 0. Add corresponding unit tests. Change-Id: Ib69393eca8f6c2bdda0eacfc83637ab0c971ff2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149118 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit dc9b8c31aaf72812dc205f610638098898a4cde7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150085 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-06tdf#148008: do not proceed after the marked rangeMike Kaganski
Implementation error in commit c008dc483f8c6840803983e7e351cec6fdd32070 ("Switch to using multi_type_vector for cell storage.", 2013-06-24). Change-Id: I1e946b3b816db3d24f79a10fe8aa0dfc673b2e4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149026 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 32b2d00853d049bacb60cfb40e732602da048c89) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149031 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-06tdf#152234 drawinglayer: PDF/UA export: fallback for unsupported formsMichael Stahl
veraPDF complains: Specification: ISO 14289-1:2014, Clause: 7.1, Test number: 3 Content shall be marked as Artifact or tagged as real content Form element can only be used for those form controls for which PDFWriterImpl can produce a Widget annotation; see createDefaultWidget(). For a label control, it's not editable so it's not a PDF widget. For an image button, it could be implemented in VCL but isn't currently. So a fallback is required in any case, "Figure" or "Div" can be used. Change-Id: I454030ff7c67a8a8101fcc59e945fe9dbc5f87a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150059 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 5ef4d326a06f9fc0aff36bd5cdcba1b7af8e03db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150094 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-06Resolves: tdf#154308 if start center frame exists, use it as dialog parentCaolán McNamara
At least for the case the document is launched from the StartCenter, put that StartCenter as the parent for any dialogs that may appear during typedetection, this avoids such dialogs not getting associated with the start center and going behind the dialog if the start center is clicked while the dialog was appearing. The start center is always recycled to become the next document if it exists, so its window is the window the final document would appear in if successful. Change-Id: I75a92ff424aa0b9d5d6b808e2f7f1766a80fa50c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149989 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-06use the same max size that libtiff defaults to for its own utilitiesCaolán McNamara
Change-Id: I67a769a6108fb8590d6304390a4f27ef95927c9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149882 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-06tdf#145147 DOCX import: fix hyperlink in group shapeTünde Tóth
Hyperlink inserted to shape lost, if the shape was inside a group shape. Test: ungroup the grouped shape and move the mouse over the shapes, or use Edit Hyperlink... in their context menu. Change-Id: I45d816f18a1e1bc1c442943b31c9e0ae7de199e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148552 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit b5a0fa42adf68b33970da93c2b04f935f72cffde) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149608 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-06tdf#152234 vcl,drawinglayer: PDF/UA export: produce Role for form controlsMichael Stahl
veraPDF complains: Specification: ISO 14289-1:2014, Clause: 7.18.4, Test number: 2 If the Form element omits a Role attribute (Table 348), it shall have only one child: an object reference (14.7.4.3) identifying the widget annotation per ISO 32000-1:2008, 14.8.4.5, Table 340. LO forms produce both page content in an MCID and an /Annot, so Role is needed. Change-Id: Ic231931a7c35d8da37ca76e02d97501edb43347c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149626 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 2a87a59a52ae26db5106f7d1f4346225d032b550) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150023 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-06vcl: PDF export: fix erroneous MCID produced for 1st pageMichael Stahl
PDFWriterImpl::beginStructureElementMCSeq() emits a spurious MCID definition outside of any stream, before the 1st page: /Document<</MCID 1>>BDC % PDFPage::emit 1 0 obj <</Type/Page/Parent... This is because SwPageFrame is translated to a Document StructElem in EnhancedPDFExportHelper, but PDFPage::emit is called at a later time than when the page content stream is produced, so this is just wrong; an MCID inside the page content stream is pointless because that's an object already anyway, so just suppress this. Looks like other applications don't produce Document currently. Change-Id: Ic2e30e4125c0e97c8e47330c7a247f74efc18f98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150017 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 22fd7ccb913c55db14adf736859fc9e0e7f00630) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149980 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-06oox: fix crash in lcl_GetGluePointId by removing unused codeXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/oox::drawingml::lcl_GetGluePointId Change-Id: I7737568b12a18a2195f24f023917d30dd838ea12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit aa1008e29bcfbee2397f72971d2de745fad8e98a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150076
2023-04-05Resolves: tdf#154218 Use proper locale for user field and set variableEike Rathke
This is a combination of 3 commits. Resolves: tdf#154218 Tie user field content value string to content locale ... instead of the format's locale. xChange-Id: I83aeaa1433486241626fafc1ab9b4e2b3802d3eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149909 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit ba6d84b854e1abd3e913423dbcfaf192f7ade7f2) Related: tdf#154218 Actually use the top format selected Choosing a format of Additional Formats replaces the listbox content with the format's category so the assumption that Text would be the first entry does not hold. For such format still Text was assumed and the input used as literal string, which defeated the actual value formatting capabilities and a possible formula interpretation for SwUserFieldType. xChange-Id: I199575469672a9f8bada2d2edde5036766977501 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149910 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 8c8457526a11fd03ed63a86ecdeeb270d5551049) Conflicts: sw/source/ui/fldui/fldvar.cxx Resolves: tdf#154218 Use the proper document's SwCalc locale for formula field ... instead of the format's locale to generate the expanded value string to be reinterpreted again. i.e. inherited by SwSetExpField used with Set variable. xChange-Id: I0bb545282a50032f2d8d2965020a36e3c5c8914e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149911 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 82ed010cd39351adcd4015e2bdd1591aa869cf18) Change-Id: I83aeaa1433486241626fafc1ab9b4e2b3802d3eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149936 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-05tdf#154486: Use known name when inserting the table into the documentMike Kaganski
... instead of assinging a unique name at insertion time, then changing to the final value. As discussed in commit 1dd71d79e15bd8098e7c17c8fcea3748592a902f (tdf#154486: use importer-local map to deduplicate table names, 2023-03-31), the lookup for a unique table name has an O(n^2) complexity, and can make loading of thousands tables impossible. This changes import time from 23 s to ~2.5 s, and the time now depends on the number of tables linearly (e.g., 200 000 tables load in ~45 s). Change-Id: I0f2b5e37db2d370bccbc8c3430f895c864d9a4c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149840 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 18e4c95a59809f4109f13934f2f072aee1cea000) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149874 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit b398c4b9f2e360a712884d69232228c8048a23b4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149961 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-05tdf#154486: use importer-local map to deduplicate table namesMike Kaganski
... instead of SwDoc::GetUniqueTableName. The latter is expensive with many tables, has O(n^2) complexity with rather large O, and in corner cases of thousands tables with no or duplicate names, is unacceptably slow. Changes the test case import time from 39 s to 23 s on my system. Change-Id: Ia461c860d56cbbfdcb25bacbb9cca4961ced885e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149817 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149960 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-05Fix typos in XML that broke three implementation elementsStephan Bergmann
The typos all originated with d2140a6320cd1cf4dea29b174cdb3bcb5261056b "i18npool: create instances with uno constructors", causing three intended constructor attributes to rather be plain character data. Which apparently went unnoticed until recently (see the TODOs resolved here that had been introduced with 456a146b9eb643655ae2bd336740e8c5536913aa "tdf#151971: Fix used implementation names of transliteration services"), in part because the Parser class in cppuhelper/source/servicemanager.cxx silently ignores any unexpected character data via xmlreader::XmlReader::Text::NONE.) Change-Id: Ia8fdbc09c67d10530b4d86dbbbde2b6b84038e66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150021 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 65710a8d0098752b1079680563a053c2770ec958) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149983 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-04move to libwebp 1.3.0 releaseCaolán McNamara
Change-Id: I88205be86e15d9878040958b96dc30043d9eb0b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150010
2023-04-04Related: ofz Use-of-uninitialized-valueCaolán McNamara
Change-Id: I2f6e726f713836295603bf7112371aa4aff2c7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144868 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150011
generated by cgit (git 2.34.1) at 2024-07-04 06:04:43 +0000