summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-06-07Fix uitest failureXisco Fauli
It doesn't break for me locally Change-Id: I61957fe4e7699937d17b74e8655efe2a6d1f6e6a Reviewed-on: https://gerrit.libreoffice.org/38502 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2017-06-07remove some more qpw depends for the momentCaolán McNamara
Change-Id: Ia4a24d946921ec460a8fce567806e69372dad80a
2017-06-07tdf#37859: Odb data copied to Calc showed wrong encoding in WindowsJulien Nabet
Blind fix since I don't have Windows. If it works, many thanks to: - Urmas (see https://bugs.documentfoundation.org/show_bug.cgi?id=37859#c16) - Himajin100000 (see https://bugs.documentfoundation.org/show_bug.cgi?id=37859#c35) Change-Id: I9fd84977eab8410ec022b6e34f1a636326eaf56a Reviewed-on: https://gerrit.libreoffice.org/38253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-07tdf#39468 Translate German comments/termsJens Carl
Translate German comments and terms in file sw/source/filter/html/htmlforw.cxx Change-Id: I5355b83c6068a7171fdac9d248c5fcf74b17e662 Reviewed-on: https://gerrit.libreoffice.org/38394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-07external/graphite: Avoid -fsanitize=pointer-overflowStephan Bergmann
...that was recently introduced into Clang trunk with <https://reviews.llvm.org/D33305> "[ubsan] Add a check for pointer overflow UB". Here, _code is of type instr*, dist is of type ptrdiff_t, and sizeof(instr) is something like 8. My first impulse was to cast the result of the division (done with arguments promoted to size_t) back to ptrdiff_t, but that wouldn't help: When dist is a relatively small negative number (like -3293184), the division expression will promote it to a large unsigned (size_t) value (like 0xFFFF'FFFF'FFCD'C000), but the result (in our case, 0x1FFF'FFFF'FFF9'B800) would be small enough to fit into ptrdiff_t as a positive value. So assume that sizeof(instr) fits into int and ensure the division is done on signed values. (At least CppunitTest_sc_subsequent_filters_test started to fail with "workdir/UnpackedTarball/graphite/src/inc/Code.h:165:15: runtime error: pointer index expression with base 0x7fb90a3b4df0 overflowed to 0x7fb90a0a0df0".) Change-Id: Ie6698e38d6abec80f2fa817c42ebf20618496109
2017-06-07Updated coreOlivier Hallot
Project: help 0e7fce65904349f4d016592a68979f26e62c5bdd Add screenshot to Pick-a-Color help page fix grammar Dialog -> window Change-Id: Ie258bff777a51772f32e72ea0616f03e1351a833 Reviewed-on: https://gerrit.libreoffice.org/38236 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-06-07EditEngine Creating SvXMLImportContext for ODFVarun Dhall
Change-Id: I4083658db6068122b423fe5ec7a568fa222b4e80 Reviewed-on: https://gerrit.libreoffice.org/38358 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-07EditEngine Renamed InsertText to PasteTextVarun Dhall
The multiple overloads of InsertText cause pain in debugging Change-Id: Icb5b40c23ae85e198d57f3054bc07a8c7eb05f55 Reviewed-on: https://gerrit.libreoffice.org/38286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-07EditEngine Implementing Paste for XML from clipboardVarun Dhall
Change-Id: Ia820a29bec8a6b102fb78cf325577b731a12c3c4 Reviewed-on: https://gerrit.libreoffice.org/38282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-07Related: tdf#108269 DOCM filter: reuse oox code for VBA preservationMiklos Vajna
With this, the project stream import is shared between DOCM and XLSM. Change-Id: I8fbffefc5acf28adea4875fa6bc4148a99b5ebef Reviewed-on: https://gerrit.libreoffice.org/38495 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-07Exporting EditEngine document into a buffer with ODF FilterVarun Dhall
Change-Id: Ib0304de5d873ac833dcc121235b8de494a1bb3bf Reviewed-on: https://gerrit.libreoffice.org/37999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-07Reformat an overly long lineEike Rathke
Change-Id: I884ba7f3029b00f31438690601da2b7f1a9b3acf
2017-06-07EditEngine Exporting flat XML from actual clipboardVarun Dhall
Allowing export of EditEngine document into flat XML from actual clipboard by modifying SotClipboardFormatId Change-Id: I9c7dfd3ca428d0fa355bd3dfb7bfa0f0e30dada6 Reviewed-on: https://gerrit.libreoffice.org/38226 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-07EditEngine: Added ODF_TEXT_FLAT copy for scVarun Dhall
Change-Id: I5e48a6e711f1f7bb5f22b69e2e7c364e4d6edb6b Reviewed-on: https://gerrit.libreoffice.org/38460 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-07fix some .src offsetsCaolán McNamara
Change-Id: I2e36ca50b2141d5d15bd387b38f15e43a9c78343 Reviewed-on: https://gerrit.libreoffice.org/38498 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-07tdf#39468 Translate German comments/terms sw/source/filter/html/htmltabw.cxxJens Carl
Change-Id: Ib2610e701f8c401aff06fb300d8bc13c434958cf Reviewed-on: https://gerrit.libreoffice.org/38486 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-06-07Fix @since tagStephan Bergmann
Change-Id: Ic8303d848a551ce1c0da824576a70e148ed3b08f
2017-06-07Keep list sortedStephan Bergmann
Change-Id: I4b09c9b2dd8d662a15267378d812013be42d8e69
2017-06-07Make use of OUString::startsWithIgnoreAsciiCase rest parameterStephan Bergmann
Change-Id: Id5d1df581307ea6eb4e3e634d14ed3dbbe914544
2017-06-07Make use of OUString::startsWith rest parameterStephan Bergmann
Change-Id: Ic743bfbf65533bd317e29c8e1482306603b65b0e
2017-06-07framework: cleanup xtypeprovider.hxx includesJochen Nitschke
LayoutManager uses macro impl from comphelper, so use declarations from comphelper too. Change-Id: I638492849742782d48c3bb5439c2255e72f9f694 Reviewed-on: https://gerrit.libreoffice.org/38496 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-07Replace vcl::SalLayout Release with destructorTamas Bunth
Replace SalLayout::Release() with normal destructor mechanism. Release() uses reference counting for the layout. But in practice, the reference counting variable is initialized in ctor and is not incremented elsewhere. So I removed the Release() method and replaced all the Release() calls with 'delete'. It will make easier the use of smart pointers and decrease the chance of memory leaks. Change-Id: Ia2e142dea10b87e232d5757d84778e62d87cf081 Reviewed-on: https://gerrit.libreoffice.org/38488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-07tdf#39468 Translate German comments/terms in sw/source/filter/html/swhtml.cxxJens Carl
Seventh set of translations. Change-Id: I3bfba60d8915f450f16ac2cecf4dd608a8434e2c Reviewed-on: https://gerrit.libreoffice.org/38487 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-06-07tdf#39468 translate German commentsThomas Beck
translated comments in htmlform.cxx and removed unneccessary comments and overused punctuation marks. Change-Id: Ie3327ccc0bb3963d0942676b011ab9dcdf078b91 Reviewed-on: https://gerrit.libreoffice.org/38493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-07tdf#108349: fix LanguageType conversions from UNO "short"Michael Stahl
The bugdoc uses LANGUAGE_USER_LATIN_VATICAN LanguageType(0x8076). The UNO API uses signed "short" for these in various interfaces, and so the LanguageType constructor complains about out-of-(short)-range values. Avoid this by deleting the problematic constructor, so that the places that currently call it with API parameters can be changed to first cast the parameter to unsigned. (Yes, we need to write "template<>" twice in a row. Don't ask me why, i just work here. sberg says we also need to omit the explict <short>.) Change-Id: I2443a89bc8d579504fc707ded3d145f9a625597a Reviewed-on: https://gerrit.libreoffice.org/38473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-07Remove gb_LinkTarget_add_generated_cxxobjectsStephan Bergmann
...in favor of gb_LinkTarget_add_generated_exception_objects. The former would have needed any flags to be passed in explicitly (but no call sites did), so e.g. StaticLibrary_graphite didn't have any debug information (when building with --enable-debug). I guess there is no downside to having C++ exception support enabled in these places, and using _add_generated_cxxobjects instead was likely an oversight in the first place (at least in the case of external/graphite/StaticLibrary_graphite.mk, it was that way ever since 1ceb47d96da9e7977c96241f49ad291ff0466970 "graphite: convert to gbuild", but for no apparent reason). Change-Id: I9986a6c5ec30a521095dbe5315e5ca649741a790
2017-06-07uitest: InsertBreak dialogXisco Fauli
Change-Id: Iab997ecedd11167cc079b3c5e3c4308383439448 Reviewed-on: https://gerrit.libreoffice.org/38468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2017-06-07iOS, add support for arm64jan Iversen
Added general support for arm64 Removed experimental/prototype from normal build Change-Id: I832256c72fbd408084bc802440343c874e7e6d28
2017-06-07iOS, clean up document types to support.jan Iversen
Icons removed, which will be unused Change-Id: Ibfd4be71ea3ae22bea8be61f7151312c5864429c
2017-06-07tdf#108039: check for nullptr in rtl_uString and OUStringMike Kaganski
rtl_[u]String_newConcat now checks allocation result to return early and avoid SIGSEGV. Other functions are not modified, to keep old behavior relying on allocation success and crashing early on OOM to avoid added overhead in performance-critical places. OUString operator+= now checks rtl_uString_newConcat result and throws std::bad_alloc on failure, to specifically address BASIC problem. It keeps strong exception guarantee of leaving this' state unaltered. Concatenation in BASIC now checks for bad string allocation (previously SIGSEGV was generated). Unit test included. Change-Id: I1513311d3d58eac43b2d2ec9a230e22dff0b4245 Reviewed-on: https://gerrit.libreoffice.org/37965 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-07Watermark: RTF import / exportSzymon Kłos
* "wzName" should contain shape name * MS Word watermark has text inside the "gtextUNICODE" (do not create additional shptxt) Change-Id: I7929ec83a9219d6087d36ccbf6d7e735acf63722 Reviewed-on: https://gerrit.libreoffice.org/38219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-07tdf#108123 RTF paste: fix asymmetric shape <-> table manager stackMiklos Vajna
Make sure that even if the text append stack is empty (and we return early) the table manager push/pop operations are in sync with the shape start/end, otherwise we'll have an empty table manager stack. That is a problem as writerfilter::dmapper::DomainMapper_Impl::getTableManager() assumes that it always has at least one element. Change-Id: I92b3381e820bc8eaeb351532a6ce8909490c0f30 Reviewed-on: https://gerrit.libreoffice.org/38490 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-07uitest: Combine all table tests in one fileXisco Fauli
Change-Id: Ief374a02eabed4587874cb6182742ae86c084d62 Reviewed-on: https://gerrit.libreoffice.org/38474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2017-06-07sal: use thread safe local static in getInternMutexJochen Nitschke
Change-Id: Iac7ca87e05228f3a2a187646496869a8b1bff602 Reviewed-on: https://gerrit.libreoffice.org/38436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-07tdf#98888: mediawiki inserts redundant emptylines in <ref>Julien Nabet
There's a newline in case of heading, table or bibliography following text:p ok but only if we're not in text:note node Change-Id: I71172751a51e29abdd770e758d27b1bc8f15cb0d Reviewed-on: https://gerrit.libreoffice.org/38470 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-07tdf#74177 writer: ignoring comment allows number recognitionJustin Luth
The presence of an annotation anchor was causing number recognition to fail in Writer's table cells. Formulas accessing the cell read a value of zero. Annotation anchors are only used in SW right now, so SVL didn't want the overhead in their code. So this wrapper function should be called first to cleanup SW specific things that interfere with number recognition. Specifically known to be needed in cellfml.cxx, but converted everywhere for consistency. The formula in older documents is not "fixed" during document loading since the table/formulas are not refreshed at load time. Only documents saved with incorrect results will notice this, and any cursor access inside the table will cause a refresh. Printing also causes a refresh (but not print preview or PDF export). So this patch only fixes document creation or modification, which should be adequate for this bug. Change-Id: Ib46f2b7899ae9a0fdc3aae5887bb2d61535d29f3 Reviewed-on: https://gerrit.libreoffice.org/32909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-06-07Updated coreKrunoslav Šebetić
Project: dictionaries c1631744a57759f139a94884191dd29facca795a Update Croatian dictionary to 2.1 Change-Id: I3a9e87d53caf3e5bfe3e4ef6f1096d7635ff6ff1 Reviewed-on: https://gerrit.libreoffice.org/36552 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-06-07Updated coreChristian Lohmaier
Project: translations 633cd820822ba89da7d410cf8bed009c2ffd3d47 update translations for 5.4.0 Beta2 and force-fix errors using pocheck Change-Id: I6d5e3a4c3d81bc5d1f7e324ddc4387b2228fdd3e
2017-06-07gpg4libre: add 'Start certificate manager' buttonKatarina Behrens
Change-Id: Ief3239fd1b3ff1f4e2e95e4413aa9f707f3dfb50 Reviewed-on: https://gerrit.libreoffice.org/36689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-07Perf-sc: tdf#100709 Use a "one and a half" alloc strategy for ScMarkArrayEike Rathke
ScMarkArray::SetMarkArea() before, Ir: 3 059 572 314 after, Ir: 1 195 743 815 ScDocShell::Load() before, Ir: 17 337 645 368 after, Ir: 15 497 093 406 Change-Id: I83959f0dfcf6480781a44b5cfc36242a5c35ebd4
2017-06-06make check on linux includes now uicheckMarkus Mohrhard
Change-Id: I4760fc80ca2ca4a2496cb1a8bf3c3d1348ee0e77 Reviewed-on: https://gerrit.libreoffice.org/38461 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-06something not right with qpwfuzzer depends, disable for nowCaolán McNamara
Change-Id: I0aadbd552d1ba4a64daddba5bfcb3d6ffe534488
2017-06-06coverity#1371243 Missing move assignment operatorCaolán McNamara
Change-Id: Idbd8b87d1336105cc34054277ae492077d86e8c9 Reviewed-on: https://gerrit.libreoffice.org/38453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-06first arg of ApplyBlockFrame is never nullCaolán McNamara
Change-Id: Ie65fce6041278c6758df266c4ef097a5758f75dd Reviewed-on: https://gerrit.libreoffice.org/38448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-06nullptr never passed to ApplyFrameAreaTabCaolán McNamara
Change-Id: Iece6c99b6414eb2701af61a64d0ff80f52a0379d
2017-06-06ucb: replace double checked locking patternsJochen Nitschke
with thread safe local statics and prefix statics Change-Id: Iaa7c9056847f75612d6cf6c6e44d3896fca734de Reviewed-on: https://gerrit.libreoffice.org/38433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-06Eliminate dynamic_cast<const SfxVoidItem*>, use SfxPoolItem::IsVoidItem()Eike Rathke
Change-Id: I09dafffd64dd107e802d016494d884f32363521a
2017-06-06Perf-sc: tdf#100709 SfxPoolItem::IsVoidItem() instead of dynamic_castEike Rathke
SfxItemSet::GetItemState() before, Ir: 4 048 231 416 after, Ir: 2 577 117 709 Change-Id: I26d8b91ad5d851011a670b38b7b98e5582c319cf
2017-06-06Partial start of separating the iterator out from FormulaTokenArrayTor Lillqvist
The plan is to drop the iterator functionality from FormulaTokenArray and instead use separate iterator objects. This will make parallelising code that uses these data structures easier. I call the new separate iterator class FormulaTokenArrayPlainIterator for now, feel free to come up with a better name. No change to what code actually gets run yet, so yeah, this adds "unused" code. Change-Id: Ie86f80529354174f0ce8bde1085a54bc6c5ac67b
2017-06-06iOS added all known document types.jan Iversen
Update Info.plist to contain the same document types as used for osX Change-Id: I3338ca0159c39ef8bd31466e3d9b9a73808b86b8