summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-06-15java: 'final static' to 'static final'Noel Grandin
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-15java: remove unnecessary threadingNoel Grandin
there is no point in spawning a thread to load a document and then waiting for the thread to finish Change-Id: Icd5d5452471b0a50a8e3525ab2b5f32a500ebdf4
2015-06-15Fix indentationStephan Bergmann
Change-Id: I687f7020284d86a880a0a5db31658f01edf8e850
2015-06-15Minor clean upStephan Bergmann
Change-Id: I8e4d123626b5ef750c3b266d1aa1c96e1944b080
2015-06-15Assume that nDPI should never be zero in ImplLogicToPixelStephan Bergmann
...(same as is already done in ImplPixelToLogic), and that eacbead4f5a4dc7c8db3d60c948e28c199aa2b10 "vcl: handle nDPI == 0 in ImplPixelToLogic()" was a misguided attempt at fixing symptoms of the problem fixed with 670100fcfbb39d3dbe4afdb27fbced26d7b14283 "Remove FastLoader optimization." Change-Id: Ia42c6c7c7026f3a0b71e79938b33c140fec0afa6
2015-06-15Fix VclPtr assignment operatorsStephan Bergmann
The original templated assignment operator would never have been used, as std::enable_if expects a bool value as first template argument. But it was also unnecessary anyway: (1) Assignment from VclPtr<reference_type> was (and is) covered by the implicitly defined copy assignment operator. (2) Assignment from naked reference_type* was covered by the user-supplied constructor from reference_type* to temporary, followed by (1); it is now covered directly by the user-supplied assignment operator from reference_type*. (3) Assignment from VclPtr<derived_type> was covered by the user-supplied, templated constructor from VclPtr<derived_type> to temporary, followed by (1); it is now covered directly by the user-supplied, templated assignment operator from VclPtr<derived_type>. (4) Assignment from naked derived_type* was (and is) covered by an implicit pointer up-cast, followed by (2). Change-Id: I3c7527feea72fdda76d911a42ae856c353b700b5
2015-06-15Related: tdf#87651 Swap buttons and align to the rightMaxim Monastirsky
Change-Id: I74d799f10d4a1d88256c683f913b8c639d2694c1
2015-06-15Fix commentMaxim Monastirsky
Change-Id: I9313a8d52ed25385cf4048bc3fe6dac4f542f9af
2015-06-15inline COMPHELPER_SERVICEDECL_ macroNoel Grandin
it was not adding any value Change-Id: I6a911aac81e883f9155ed0cf24bfb7904efb3f92
2015-06-15sw: avoid #include "../../uibase/inc/view.hxx"Miklos Vajna
Change-Id: If5b148e890cd7d165f9d2b533c04b2047ac6caea
2015-06-15sysui: drop dead assignmentsMiklos Vajna
Change-Id: I95748d5acc523a571c230e23dae3fd0d8ce089fa
2015-06-15sw: indentation fixesMiklos Vajna
Change-Id: I495c8bd4ee24832573cb56b6ffe4533263eb39f0
2015-06-15tdf#84832 RTF export: fix handling of custom table cell marginsMiklos Vajna
Change-Id: I3ed42ae4dc007c15d4649f57e1691534088549fc
2015-06-15vcl: avoid possible leaks in case of unexpected exceptionsTakeshi Abe
Change-Id: I285fcd1ce10bb97b4541d09a9a242bbd95f5c730 Reviewed-on: https://gerrit.libreoffice.org/16255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-15Add libjpeg detection message, so we do not just show external without contextTomáš Chvátal
Change-Id: Iee8e233ec7505eb397efb5a5a8d243ff4a0e6341 Reviewed-on: https://gerrit.libreoffice.org/16256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-15Fix typosAndrea Gelmini
Change-Id: Id05ea8cf8aed878bedfe73c274df3c67b64bad37 Reviewed-on: https://gerrit.libreoffice.org/16263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-15loplugin:vclwidgetsStephan Bergmann
Change-Id: Ib64f7585bf44bdaa6dd1101b97848baa1f121725
2015-06-15Remove unused macrosZolnai Tamás
Change-Id: I2f5e47a3c894238557d52139c2849a2bd5a066b6
2015-06-14tdf#91857 Reorganize impress's menu barYousuf Philips
Change-Id: I35d25b920bb5c195916500b1190e593143d62ab1 Reviewed-on: https://gerrit.libreoffice.org/16274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-14Don't let root run unopkg without --shared optionKatarina Behrens
with the exception of -h|--help. It only makes sense to run unopkg with root priviledges if adding, deleting etc. extensions system-wide for all users (i.e with --shared switch ). In all other cases it only messes up access rights to extensions, so prevent that. Furtheron, running LibO from the root account (and installing root-user-local extensions) is not a supported scenario. Change-Id: I2817f62ae0bb400cefed240e792873f563fbe76e Reviewed-on: https://gerrit.libreoffice.org/16250 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-06-14Make this string localizableZolnai Tamás
Change-Id: I074ae2866a67cf90637cd229c717aa999f718558
2015-06-14Paragraph related part of Background Tab is unused nowZolnai Tamás
For paragraphs Area Tab is used for setting background. Change-Id: I83859a1b2125374b81c084cfa45487a42adcd5a6
2015-06-14Search By Format: Background -> HighlightingZolnai Tamás
Change-Id: I58cda2c6f6f38cca3fe8fecf89722be09d43059b
2015-06-14Handle highlighting case inside SvxBackgroundPage classZolnai Tamás
... instead of converting attributes. Change-Id: I3e45c0641389a7b6bdecb5141646aa13ee5c0aa5
2015-06-14Options: Background -> HighlightingZolnai Tamás
Change-Id: Id65f748ab32e119465444d02fa6584752b514047
2015-06-14deb#788713: fix (fatal) perl deprecation in lo-xlate-langRene Engelhard
Change-Id: I82c63358d9400b2c8bd391a88bba18ffae52a14b
2015-06-14tdf#89830: Ambiguous naming of character backgroundZolnai Tamás
Use 'Highlighting' also on Character Dialog. Change-Id: Ie81d25651e5998a35b4e2646089b8f2c590cfb98
2015-06-14Transparency part of Background Tab is unused nowZolnai Tamás
It was used for frames, but on Frame Dialog Background Tab was replaced with Area Tab. Change-Id: I69774c7321a210094f6e139a5b3d4d5819947ceb
2015-06-14Remove unused OpenGLObjectZolnai Tamás
Change-Id: I5c4832bd076cc5f05f936ac0d6a80027344e40ff
2015-06-14Avoid duplicated attribute names in RID_ATTR_NAMESZolnai Tamás
It causes trouble to localiztation tools and also makes hard to distinguish these items on the UI. e.g. Edit -> Find & Replace -> Other options -> Attributes. Change-Id: Ie7a17e02947200a570b5e6209c8a99d1883a6860
2015-06-14Fix insertion and deletion in IndexedPropertyValuesContainerMatthew J. Francis
The cases for iterating to an element from the end (used for elements in the second half of the underlying array) had an off by one error causing the wrong elements to be inserted/removed Change-Id: Idcbf158cc31afaf02fce3f1975509edf6239d3ae Reviewed-on: https://gerrit.libreoffice.org/16073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-06-14Resolves: tdf#91393 autotext (etc) not fully drawnCaolán McNamara
the paint timer is activating after we ask gtk to size the window but before we/gtk get the ConfigureNotify that updates gtk knowledge of the size. So the gtk drawing calls are clipped to the previous ConfigureNotify size. So, lets try postponing paints if we have set a size but not received a configure notify yet I'll also revert e6a1956034c98204e30b0ca40330249d6f6f8155 in favour of this attempt Change-Id: If5e993f8e0e65053b59234fce0785398b93c1c46
2015-06-14surely we only care if *our* window is shown hereCaolán McNamara
Change-Id: Ia5bca11c0c24ed7ca301dbe15eca3dc684153ea8
2015-06-14cppcheck: redundantCondition [part2]Julien Nabet
Change-Id: I23e8a4834fa7858adb292ce0a4dfa5dab1ab5f00
2015-06-14cppcheck: redundantCondition [part1]Julien Nabet
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-14cppcheck: postfixOperatorJulien Nabet
Change-Id: Ia17bdf6e8f871d64add358822ea383236ecd6405
2015-06-14Typo: pyhton->pythonJulien Nabet
Change-Id: I16d99991b8b88753c593a5a1ab9e32a8e0264514
2015-06-13It's E_BEFORECLOSE not E_CLOSINGJulien Nabet
Change-Id: Ia53f9aa8bb3c7fd1dd5c0190624a667b65996ca2
2015-06-13Typo: E_HARDEXCETIONS->E_HARDEXCEPTIONSJulien Nabet
Change-Id: I482d8fdb549d2a9c79bb68bd910e761f61337fb6
2015-06-13Typo: corected->correctedJulien Nabet
Change-Id: I9a41d801b8807ed122a6737a924ba6792b449c45
2015-06-13TyposJulien Nabet
Change-Id: I0e74d800593245fa00013035c9498b77988b072b
2015-06-13tdf#91960 presentation causes Impress crashNoel Grandin
The SystenChildWindow in question is owned by ViewMediaShape Fixed ViewMediaShape to dispose the vcl objects it creates correctly. Also fix another crash in MediaWindowImpl child window correctly disposing its children. Change-Id: If4aebcb6e5824266c154416f7246d73c6cb3509c Reviewed-on: https://gerrit.libreoffice.org/16230 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-13Remove comment filenameAndrea Gelmini
This file was rm/mv on commit 47692bfc1275bfa24a7fb2627cc263142549d29d Change-Id: I141794aee5c57e345334af42fcea4eaa71709f1b Reviewed-on: https://gerrit.libreoffice.org/16259 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-06-13Fix typosAndrea Gelmini
Change-Id: Ifaa52b49b717d893846fc1e7ae4ac50735f824ac Reviewed-on: https://gerrit.libreoffice.org/16260 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-06-13do not access token data after token has been destroyedEike Rathke
Change-Id: I624e64745fd3874be3e1bd3df6bac18dfb17aebb
2015-06-13BASIC: Don't use SbiStringPool to pass SbiParser.Arnaud Versini
Change-Id: I15949e604285d804de1554d36acf36e8a407ebd9 Reviewed-on: https://gerrit.libreoffice.org/16137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2015-06-13no need to check for pShape hereAndras Timar
Change-Id: I6de2da7d2f17a14ddbe7e70651a416a01f49164b
2015-06-13amend commentAndras Timar
Change-Id: I45a452a7dbab35ab96c04336b35857f58a0af0c5
2015-06-13remove unused codeAndras Timar
Change-Id: If9b7870673a47b78457f6e22ee0cfa7e3a68372a
2015-06-13tdf#92000 save rectangle to DrawingML as a preset shapeAndras Timar
Change-Id: I8b39a210490759e9f548c195e516a26b94a8b3cb