summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-01-21Make TempFile destructor remove temp directory recursivelySamuel Mehrbrodt
Change-Id: Idcfa93ffe86112477ad81bcbf74b8e5b858423f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87080 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-01-21weld gallery panelCaolán McNamara
Change-Id: I4aebb3f90e9943044d106a507972c39434988f03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87003 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21scrollbar adjustment wrong if we clear and refill a SvtValueSetCaolán McNamara
like in the gallery Change-Id: Ic89579f2d2f7e322757d42b36d57126646cad7bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87106 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21unopkg: Improve error message displaySamuel Mehrbrodt
Change-Id: Ic842a3be82094557efde6cc22b11b6567c2ad85b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86519 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-01-21lok: disable ucbgio provider for Online.Michael Meeks
Of course, some lok apps may want the provider, but it creates unwanted threads causing problems with forkit in some cases. Change-Id: I7d19d629b3657780b52c3c753a4c8dcba6ae86b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87111 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-21vcl: close UNO streams with closeInput.Michael Meeks
We can end up with lingering XBufferedThreadedStreams from the package ZIP code otherwise. Change-Id: I2a489c975b6f460c38317cb0bb93c2aa7ccc383d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87099 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87112 Tested-by: Jenkins
2020-01-21tdf#103983 VML import: handle <v:textbox style="mso-fit-shape-to-text:t">Miklos Vajna
We used to always always set TextAutoGrowHeight to true, only do that when the matching VML attribute is detected, default to false. This helps the exporter, so it writes the correct markup on save of the bugdoc. Also adapt testGroupshapeChildRotation, which in practice tested the automatic height of the shape. The point of "auto" is that it changes as needed, hardcoding that value in a test is not a great idea. Rather test that the height is no longer automatic (there is no explicit markup in the file, and the default is false). Change-Id: Ie39408b7da53f4923a2ade503e520c704a86bcf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87104 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-21Drop empty eventhandler files from svx/Gabor Kelemen
Change-Id: I42e33999cbfc5a39bd79f2711c2df7ad13d14f1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86945 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-21use FastParser in SdXMLMasterStylesContextNoel Grandin
Change-Id: I9fb57f4bf97e3aa67bcdd55f5e98ebcddaaf9e4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87082 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-21use FastParser in XMLScriptContextNoel Grandin
Change-Id: I7c5f5b77a78307c556ee5718480346ed3dd159fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-21sidebar writer table spacing fixandreas kainz
Change-Id: I3dd805f69c9357e9f2b5d773e1a2842f44af5470 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87105 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-21Make dock/undock short cut work from sidebar tabbarJim Raykowski
Makes Shift+Ctrl+F10 short cut to dock/undock sidebar work from the sidebar tabbar Change-Id: Idd895e35e65f4cd66b7af16c39f5b0fd69fb5796 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85687 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-01-21Propagate warning error code from dBASE export, tdf#130020Eike Rathke
Long time existing code cleared all warnings set by the actual export routine. I could not figure out why this ever was done. It started short after the initial OOo import with commit 0ec1e9cbdfb4be18ea18b6b9be567d23bff5963f CommitDate: Fri Oct 27 18:00:10 2000 +0000 dBase export: don't set warning errorcodes that did not set warnings at the medium anymore without giving a rationale. Change-Id: I0f26d0644890c53557076ac7b99ffe7c8756a047 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87109 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-01-20Show accel key for sidebar dock/undock menu itemJim Raykowski
Change-Id: I7d9f9860fa94eeb4b8a379de8c3d3ddd5239a21d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85671 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-01-20PDF export: skip pointless downsampling for very small imagesMiklos Vajna
Regression from commit b6588bd7c831ce88a29131ca7ea8d3f3e082564e (Reduce image resolution by default in PDF Export, 2014-03-02) the problem is that in case you have small enough bitmaps, then these used to look OK at reasonable zoom levels, but now we intentionally scale down bitmaps by default. That makes little sense for tiny images, do this only for large ones. Change-Id: Iff15325b842b47d9285a7c0f83f402897498392d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87086 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-20calc sidebar alignment updateandreas kainz
Change-Id: Ia8d0771766ef1c59a3473e3bc70cea39bb4cf37e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87015 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-20Resolves: tdf#130093 some lwp file not loadingCaolán McNamara
Change-Id: I2be53792f0fadcf1ca0e99c8f9fab7305d0fcddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-20Fix wrong translation of commentEike Rathke
... and give it back the original meaning. Change-Id: I71cf8840c82eb2c1d1b07503748a9fac3daafd02
2020-01-20Resolves: tdf#130075 have to specify which column is the text columnCaolán McNamara
in this two column case Change-Id: Ia999a0540b2d0f7c03a54241c61bf4c2231b8460 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87090 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-20Resolves: tdf#130090 xEntry should be xIconEntryCaolán McNamara
copy and paste error apparently Change-Id: Ifdeb90ececc200211ce41c55f2826987666cd401 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87087 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-20tdf#129582 sw: fix copying of flys in header/footer in DOCX/RTF importMichael Stahl
The problem is that the exception for writerfilter in IsDestroyFrameAnchoredAtChar() and IsSelectFrameAnchoredAtPara() is wrong in the case when the header/footer content is copied via SwXText::copyText(); that is, previously the situation was that writerfilter relied on Delete not deleting such flys (for RemoveLastParagraph) but Copy copying them. (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5 and e75dd1fc992f168f24d66595265a978071cdd277) So restrict the writerfilter hack to delete; this causes a problem with ooxmlexport9 test testTdf100075: it has 2 flys anchored at the same paragraph; writerfilter will insert the content into the body and then convert to fly; when the 2nd one is converted it will copy the 1st fly and anchor it inside the 2nd fly but then unotext.cxx:1719 will reset its anchor to inside the body... Prevent this unwanted copy by relying on the new parameter bCopyText that was introduced in 04b2310aaa094794ceedaa1bb6ff1823a2d29d3e, but change things a bit so that the case that pass in the extra flag isn't the copyText() one that wants the *normal* selection semantics in writerfilter import, but the 2 known places that want the *exceptional* selection semantics in writerfilter import (hopefully there aren't more). This is not ideal and the various bool parameters to CopyRange() plus mbCopyIsMove plus mbIsRedlineMove should probably be consolidated into some flags enum passed to CopyRange(). Change-Id: I638c7fa7ad0b4ec149aa6a1485e32f2c8e29ff5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87072 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-20add get_row_area for TreeViewCaolán McNamara
Change-Id: I0fa8e3666f6731abb831d0ba62f128614eae261c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87048 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-20fix constants according to [MS-EMF] 2.1.10Andras Timar
Change-Id: I048eb097e9570f2ad2fecef5e725c98e36e6559e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87078 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-01-20tdf#129481 Combine outliner indent and spacing undosJim Raykowski
Makes one undo when indent or spacing attribute is applied to outliner Change-Id: I1aefff746022552dec96f7cf76a5cb9540c84fc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86903 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-01-20Use properly typed var to iterate over FPDF_GetPageCountStephan Bergmann
...which, according to <https://pdfium.patagames.com/help/html/ M_Patagames_Pdf_Pdfium_FPDF_GetPageCount.htm>, returns int. The code had oddly been like this since it was introduced with 9194f019afb0599d5e72476786fabfa996e07f20 "pdfium: Import PDF with unloaded images." Change-Id: If8aad3c0bfbecdedea9511cff17e125fb1938f90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87067 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-20Use properly typed vars to iterate over Size::Height(), Size::Width()Stephan Bergmann
The code had oddly been like this since it was introduced with 7cf2b5809f7137acc7a5eed9159042b3d748da01 "Cairo canvas fixes" (and then moved here with 32d8a32dcf85e2cee589ee19bc72b4abf73f9681 "move cairo surface code from canvas to BitmapTools"). Change-Id: I9140ca1bae71e784fc9c6f1a29de143a2d477dc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87066 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2020-01-20bEnable for UseSkia is reversedTomoyuki Kubota
Change-Id: I05f0601604ea1bc0d847ddee709c2d28c623b36b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87013 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-20workaround for Skia+Cairo text drawing exhausting GPU memoryLuboš Luňák
See the description in SkiaSalGraphicsImpl::postDraw(). Change-Id: Ia6b38741fcfe3f6b5f0a21051886c55ed5324c61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87062 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-20StoreUserCustomValues should be usedCaolán McNamara
Change-Id: I64d41d297c55d36fc14f16945fa1369be990aa3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87074 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-20return nullptr from CreateChildContext methods in subclassesNoel Grandin
the calling class handles this nicely, and also tells us when we are not handling some part of the XML file Change-Id: Ib64a704bc96bb4d6eff2d57116d62c9c15e25c6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87073 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-20remove outdated Skia TODO commentsLuboš Luňák
Change-Id: Ia9925a703a4adca41e056916d285c21e5de4898f
2020-01-20loplugin:unusedfieldsNoel Grandin
Change-Id: If130c8a4861998d7eafd2e9525592f3c811ec21c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ie5e90b3c834a1154ec49dc765a5031f6bdd35923 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87070 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-20clang-tidy modernize-concat-nested-namespace in drawinglayerNoel Grandin
Change-Id: If2644743ab0d9b78d42d1d2fe6fa22c83472d2c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87065 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-20fix Skia bitmap blendingLuboš Luňák
SkBlendMode::kSrc does not clear actual colors if the source is just an alpha channel. Change-Id: I3e012cac78d95bf6a7407f192c11194af5e72355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87061 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-20tweak Skia raster line drawingLuboš Luňák
At least according to visualbackendtest it works best with 0.25 offset, although it's still not perfect, but the test at least passes this way. Change-Id: I15fdc39c91399efaae41ce7c10635028faf0486d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87060 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-20Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to fb916278132a481a2fdd0bd8450a2bf7066d5581 - Mute L10n for 'text/plain' mime type Change-Id: I9ab85205b199706d630e74b578ebbcec69a3170b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87068 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-01-20only enable windows incremental linking for debug buildsNoel Grandin
not necessary for optimised builds Change-Id: I33e7ff372b8b2fd35d6d45b552aceda36aaeba95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87054 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-20tdf#128814 Make Writer Navigator context menus content specificJim Raykowski
Remove content type submenus and place submenu items in root menu Display Outline Level in Outline context menu only. Add Delete/Promote/Demote Chapter and Promote/Demote Level to Outline context menu. Add Rename... to Drawing Objects context menu. Change-Id: I39327d0ed02ab1ee88361e2d6a140ad118e069d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87053 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-20tdf#128849: Added svg version of the breeze dark icon set.Luca Carlon
Change-Id: I045d8acd5b42473b220f7c9bb96e2a87d6141727 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86590 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-01-20tdf#42949 Fix IWYU warnings in formula/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6cfd3036481b8f76da73e46ac2b4b4a879f98cee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86894 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-20sw: fix assert in ToX update on mw00_table_of_contents_templates.docMichael Stahl
... exported to RTF and re-imported: soffice.bin: sw/source/core/txtnode/thints.cxx:1295: bool SwTextNode::InsertHint(SwTextAttr*, SetAttrMode): Assertion `!pAttr->GetEnd() || (*pAttr->GetEnd() <= Len())' failed. The problem is that the text of a HandledTextToken is all whitespace and a hint from 0 to 1 is inserted because mNewPositions.back() is erroneously 1, no idea why it was doing that. (regression from e5345f62bf525b6258736f1ce11a61b5e638e0ff) Change-Id: I6ec290abe50c0f65a3244f0f0bb07e19741e878b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86996 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-20rewrite of Animation::Start using the STLAdrien Ollier
Change-Id: Ieca520db4e3ea754dd8574809e366db11c451c2d Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87031 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-20Split independent loop vars, giving them appropriate typesStephan Bergmann
...and thus avoiding an unnecessary explicit cast from sal_IntPtr to (potentially smaller) sal_uInt32 Change-Id: Id05769c1db1cd272c8c193361c8f39f01dbec948 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87050 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-20sw: prefix members of SwEndNoteInfo and SwFootnoteInfoMiklos Vajna
Change-Id: Ie952701e6cb65cb0d5789b4f98005872286a41ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87052 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-20Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 1479a6aead82592c081decd851f56ae5d2ec0a56 - Fix some assorted typos I found while translating Change-Id: Ic94ea839863347fac2d2565c5719dbb28d117d5e
2020-01-20tdf#129488 Fix Font size control enabled stateJim Raykowski
Set the enabled state of toolbox that contains the font size control to that of the font size control This patch was inspired by the code used to set the enabled state of the font name control in SvxFontNameToolBoxControl::statusChanged Change-Id: I50b7852e3cbb4c552fe8b38e7e6529b75e404ae0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86040 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-01-20use more FastParser in ORptFilterNoel Grandin
Change-Id: I517a26a3ea64d86a1f494e3b9ea52ee28604e0b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-20Simplify getting ISO 8601 date stringMike Kaganski
Change-Id: If381276990199e4459787ffea090f342241237f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87037 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-19calc cell alignment sizegroup updateandreas kainz
Change-Id: I0c63fb9a2c1d4f0cbcfd7a573a05c4fbf726ecb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87049 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
generated by cgit (git 2.34.1) at 2024-07-12 10:46:35 +0000