summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-09-14Fix buildprivate/juergen/TestsThorsten Behrens
Followup to b6310c1e403b80e2c6b87f2cfc1ab9132ecd90e0 Change-Id: I83b52168a6a05f9bcc05e10bc75b748010295368
2018-09-14tdf#119016 Editing a read-only section shall popup a dialogIlhan Yesil
While processing the key input, an additional if statement for the paste command (Ctrl+V) is added. Change-Id: If205589256855422ac93f8a5ed8a1ee394ca9310 Reviewed-on: https://gerrit.libreoffice.org/58360 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 66838c2418df4d016be0da0ef1c7e54934c03421) Reviewed-on: https://gerrit.libreoffice.org/60269 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-14kde5backend.cxx: Fix inverted logic leading to invalid writeMichael Weghorn
Only write to 'pFakeArgv[2]' when 'aDisplay' is NON-empty. Otherwise, the 'pFakeArgv' array only has size 2 and the write is invalid. (Found by valgrind while looking at another issue.) Change-Id: I58aff6d25c8647bc6ef346af8ac09b0b0fc030b8 Reviewed-on: https://gerrit.libreoffice.org/60476 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 2fdafe62ef3959ec34e05daf312088a8f0534d9a) Reviewed-on: https://gerrit.libreoffice.org/60486 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-13Fix duplicate string identifierSamuel Mehrbrodt
Change-Id: I42fc07ad591455afc635fef6eaf947a209709d0e
2018-09-12gdb pretty-printers: fix StringPrinterHelper for gdb 8.0Michael Stahl
Latest gdb release "lazy_string" validates the array size: Traceback (most recent call last): File "/work/lo/master/solenv/gdb/libreoffice/util/string.py", line 29, in to_string return self.make_string(data, self.encoding, len) File "/work/lo/master/solenv/gdb/libreoffice/util/string.py", line 66, in make_string return data.lazy_string(encoding, length) gdb.error: Length is larger than array size. rtl_uString has "sal_Unicode buffer[1];", which is a lie as the real size is the same as "length". Taking the address of "buffer" appears to avoid the exception. Change-Id: I85710b1adfae584ba09c8d517e9b49b290e79d8a (cherry picked from commit 205677c88cb01e2bbee278443867baed2c89e5fe)
2018-09-10sw: tdf#119742 fix null pointer in SetCursorInHdFtJuergen Funk
In SwWrtShell::ChangeHeaderOrFooter the ChgPageDesc destroys the frames of the header, that's why GetCurrFrame returns null later. Change-Id: I26915237c8b455a5b8ad0bbd5c2de38537dfef08 Reviewed-on: https://gerrit.libreoffice.org/60130 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 77d075facaf4fc8954666ad541ed14f75d964fba)
2018-09-10curl: fix CVE-2017-1000254 & CVE-2018-14618/1000120Thorsten Behrens
* still don't upgrade to new release, no idea how the new windows build system likes targeting Win XP which is still supported in 5.4 Change-Id: If9c235d2c3e1902f154cae570a9719945112fe33
2018-09-08Support buffering SystemDependent GraphicDataArmin Le Grand
Note: This is the backport to LO52bp version This is a first step to allow buffering of system dependent data, especially (but not only) for the system-dependent implementations of graphic output. For example, for B2DPolygon and Win output, it allows buffering the Gdiplus::GraphicsPath instead of re- creating it all the time. To support that, the change includes forwarding the current transformation to the renderers in SalGraphics. The current state in VCL is to transform all and everything to device coordinates at every single paint. I have currently started to do this for ::drawPolyLine implementations. The fallbacks for all systems will at the start of that method just transform the data to device coordinates, so all works as before. This may also be done for FilledPolygon paint in a later step, but most urgent is FatLine painting. An arrangement of shared_ptr/weak_ptr is used so that either the instance buffering (in the example B2DPolygon) or the instance managing it can delete it. The instance managing it currently uses a 1s Timer and a cycle-lifetime management, but that can be extended in the future to e.g. include size hints, too. The mechanism it designed to support multiple Data per buffering element, e.g. for B2DPolygon at the same time system-dependent instances of Gdiplus and Cairo can be buffered, but also PDF-data. This is achieved semi-automatic by using typeid(class).hash_code() as key for organization. The mechanism will be used for now at B2DPolygon, but is not limited to. There is already a similar but less general buffer (see GdiPlusBuffer) that can and will be converted to use this new mechanism. Added vcl/headless Cairo renderer to support given ObjectToDevice transformation (not to transform given B2DPolygon) Added support for CairoPath buffered at B2DPolygon, seems to work well. Need to do more tests Moved usage to templates suggested by Noel Grandin (Noel Grandin <noelgrandin@gmail.com>), thanks for these suggestions. Adapted Win usage to that, too. Converted Win-specific GdiPlus BitmapBuffer to new mechanism, works well. Checked, the manager holds now a mix of bitmap and path data under Win Added a cleanup mechanism to flush all buffered data at DeInitVCL() using flushAll() at SystemDependentDataBuffer Adapted Linux-versions of ::drawPolyLine to support PixelSnapHairline, for now in a simplified version that still allows buffering. This will also be used (and use buffering) for the Cairo-fallback in X11SalGraphics Change-Id: I88d7e438a20b96ddab7707050893bdd590c098c7 Reviewed-on: https://gerrit.libreoffice.org/59555 Tested-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-on: https://gerrit.libreoffice.org/60036 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-06tdf#119685 Fix infinite loop in gtk3_kde5 filepickerMichael Weghorn
Since 'string::find()' returns the position of the given character in the string and that was passed as the amount of characters to delete from the string, 'm_responseBuffer' would always be a string starting with a newline character afterwards, when this part of the code was reached. Subsequent calls to 'Gtk3KDE5FilePickerIpc::readResponseLine' therefore always returned an empty string and left 'm_responseBuffer' unchanged, resulting in the lambda function inside 'readResponse' in 'gtk3_kde5_filepicker_ipc.hxx' to loop infinitely. While at it, make a little more explicit that 'it' is of type 'size_t' here. Change-Id: I3b1c209f8307ab71465d9538a82616dff8656415 Reviewed-on: https://gerrit.libreoffice.org/60047 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 1f5698ba8b62e62999b0efb363916a91bdd54c94)
2018-09-04tdf#109188 Always load documents read-only in SwOneExampleFrameSamuel Mehrbrodt
Should be no problem since 38a3743e0c5d52f9386f74097fd512d3133fbbe3 Reviewed-on: https://gerrit.libreoffice.org/40140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit bde72cdae1e7e001d5089c5284672c976b8e43df) Conflicts: sw/source/uibase/utlui/unotools.cxx Change-Id: I0ce47bc2bdaa900559a16baf25305066977caa6d
2018-09-03tdf#118994 JAWS has no access to accessibility objectsIlhan Yesil
According to the MSDN, lParam must be cast to DWORD when examining WM_GETOBJECT messages on 64-bit Windows. The MSDN example also casts wParam, so in this solution, lParam and wParam are cast to the appropriate types sal_Int32 and sal_uInt32. Change-Id: I1edc00778c7da91d2baf5784e4c3f8c441e42eab Reviewed-on: https://gerrit.libreoffice.org/58312 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 200fafc341c9ac5cedb0e3e8a38fcc4e88fce77c) Reviewed-on: https://gerrit.libreoffice.org/59935 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-02presentation minimizer: report possible errorsVasily Melenchuk
In process bunch of different problems can occur, but they are not reported to user. IO errors are now shown with message dialog, other exceptions (if any) are passed to upper level. Reviewed-on: https://gerrit.libreoffice.org/58765 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Conflicts: sdext/source/minimizer/informationdialog.cxx sdext/source/minimizer/optimizerdialog.cxx Change-Id: I8ae141cf07d5da4c077be78463068cc9f020eba0 Reviewed-on: https://gerrit.libreoffice.org/59899 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-01tdf#115582 Correct coordinate usage for sc's ::ArrayArmin Le Grand
In ScOutputData::SetCellRotations() eventually existing CellRotations are added to the svx::frame::Array data that gets created for repaint. This used the wrong coordinate calculation, thus in some cases the repaint of rotated Cells failed. Reviewed-on: https://gerrit.libreoffice.org/53171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit 0185e65bcd73dbad2205a39369e1e06b33a2ca51) Reviewed-on: https://gerrit.libreoffice.org/54922 (cherry picked from commit 08e45e11a0e74cdb4a17ec29df9d03ad03b7f7c0) Conflicts: sc/source/ui/view/output.cxx Change-Id: Ib5df8576e8c9404d717d5dcc5662aa04b82cf959 Reviewed-on: https://gerrit.libreoffice.org/59874 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-31sw: fix inconsistent bookmark behavior around at-char/as-char anchored framesSerge Krot
Added fix for Change-Id: Ic1f173c85d3824afabb5b7ebf3a8594311eb9007 Reviewed-on: https://gerrit.libreoffice.org/46889 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> The problem was (the same condition of the bOnlyFrameStarts parameter was used during output of Start and End bookmarks): if (BkmType::Start == pPtr->nBkmType && !bOnlyFrameStarts) ... if (BkmType::End == pPtr->nBkmType && !bOnlyFrameStarts) ... Should be: if (BkmType::Start == pPtr->nBkmType && bOnlyFrameStarts) ... if (BkmType::End == pPtr->nBkmType && !bOnlyFrameStarts) ... I assume this was a simple copy-paste bug. Reviewed-on: https://gerrit.libreoffice.org/59556 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Conflicts: sw/source/core/unocore/unoportenum.cxx It looks like you may be committing a cherry-pick. If this is not correct, please remove the file .git/CHERRY_PICK_HEAD and try again. sw: fix inconsistent bookmark behavior around at-char/as-char anchored frames Added unit test for Added fix for Change-Id: Ic1f173c85d3824afabb5b7ebf3a8594311eb9007 Reviewed-on: https://gerrit.libreoffice.org/59828 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Conflicts: sw/qa/extras/uiwriter/uiwriter.cxx Changes to be committed: new file: sw/qa/extras/uiwriter/data/testInconsistentBookmark.ott modified: sw/qa/extras/uiwriter/uiwriter.cxx 38444587d00b96d52ff725dc7c5852e057bc6bd9 Reviewed-on: https://gerrit.libreoffice.org/59854 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Change-Id: I712a0dccc1638fed3b81c65628033a4dc06c1ca4
2018-08-29tdf#101856 Handle properties of nested bookmarksSerge Krot
Change-Id: I1a92d2001e58751c5bbe41f6480f4c46dcc8c9e7 Reviewed-on: https://gerrit.libreoffice.org/59704 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-29tdf119556 Sync "Use only paper size from printer preferences"Michael Weghorn
Since commit ee6dad51150fd53d19f882edfefa879e18f9897d, the "Use only paper size from printer settings" is shown at two places in the print dialog 1) in the "Options" tab 2) in the "Properties" -> "Paper" tab This makes the setting being correctly updated in the UI in 1) as well if changed in 2). The other way around was already working previously. Reviewed-on: https://gerrit.libreoffice.org/59581 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 571df3ede6f09c945c4cdfd37f34ef760b6b1af2) Conflicts: vcl/inc/printdlg.hxx vcl/uiconfig/ui/printdialog.ui Change-Id: I41d29a11b4e1695a4b2f676b8d7a9c01e4abde3e Reviewed-on: https://gerrit.libreoffice.org/59745 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-24tdf#116489 - fix ucb TaskManager deadlock.Michael Meeks
Change-Id: Ia362db52e7b078203964704569e1d54f053f2b57 Reviewed-on: https://gerrit.libreoffice.org/51544 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 5b1442ec1e6946ec3a3b9d8cfdd57ac1437d23ab)
2018-08-23lcms2: avoid updating msbuild files, simply check-in new versionThorsten Behrens
Change-Id: I54c3bf0e35b8969fe8237db64f66c3b8d12741f2
2018-08-23glew: avoid updating msbuild files, simply check-in new versionThorsten Behrens
Change-Id: Iae20b56f98d73fdc8dacde45796d158a84beb71e
2018-08-16Drop support for MSVC 2013David Ostrovsky
Reviewed-on: https://gerrit.libreoffice.org/22588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 84b36c704d73362d4d86dc9e9c0efa0625958347) Conflicts: configure.ac download.lst external/python33/ExternalPackage_python3.mk external/python33/ExternalProject_python3.mk external/python33/Module_python33.mk external/python33/UnpackedTarball_python3.mk external/python33/clang-cl.patch.0 Change-Id: Ibf47c9ff7b5fb098e284a58c547b61286264dd80
2018-08-15nss: upgrade to release 3.38Michael Stahl
Fixes CVE-2018-0495 and "the ASN.1 code". (Remove one hunk of nss-android.patch.1 that should be obsolete with the current Android toolchain baseline (but that hunk didn't exist in libreoffice-6-0 or older anyway).) Change-Id: I5516edec17b72f53acd2749e8840805eead077bc Reviewed-on: https://gerrit.libreoffice.org/58697 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 3ef76067bfa1f9f60ec3989bd6b40a5760137903) Reviewed-on: https://gerrit.libreoffice.org/58722 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit e4874f777048535650a2bb1ce875e1a6e3e4b7ef)
2018-08-15nss: Upgrade to release 3.31.1 and update patchesGautam Prajapati
This commit updates the NSS to release 3.31.1 and NSPR to 4.15. It also updates the external/nss/nss.patch and external/nss/nss-android.patch to incorporate the NSS source changes. Change-Id: Icdd933b67e717f8d91622cd5f6001e34e261b746 Reviewed-on: https://gerrit.libreoffice.org/41636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit c6df07f905cd9562132b06e44f90b0479b250f7a)
2018-08-15nss: try to remove nss.windowbuild.patch.0Michael Stahl
It's not obvious to me what problem this solves. Maybe the problem no longer exsists in the new upstream release? Change-Id: I16762e0024536afb821eac70c6ba3929d5b8927a Reviewed-on: https://gerrit.libreoffice.org/36798 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 489414f2395b6c8008ebcda7c37a150fd4ed7ad5)
2018-08-15xmlsecurity: nsscrypto_initialize: try to avoid profile migrationMichael Stahl
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.35_release_notes NSS 3.35 and later will automatically migrate migrate profiles from the old "dbm:" BDB format to the new "sql:" SQLite format. The new format can be read by NSS 3.12 and later, which is old enough that it can be assumed to be available. However LibreOffice still shouldn't migrate the profile on its own: LO typically uses a Mozilla Firefox or Thunderbird profile, and if it is a system Firefox with system NSS libraries, then it's probably a bad idea for LO to migrate the profile under Firefox's nose, particularly considering the "partial migration" scenario if the profile is password-protected. Try to avoid this by checking if the profile is the old format and explicitly using the "dbm:" prefix to prevent the migration. Change-Id: I06480522f830ce74e2fb7bf79fee84ad80979b82 Reviewed-on: https://gerrit.libreoffice.org/58756 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 61688aa1abd9db9adbb8dc5d5aacc6269b21fd27) Reviewed-on: https://gerrit.libreoffice.org/58974 (cherry picked from commit dc5474b2e2f361eec981c6955630dbb020442eae)
2018-08-14Disabled async/parallel chart loading for nowArmin Le Grand
Need to check deeper for circumstances leading to problems Change-Id: I58c9601008edc53c958d59d04a30d11bc0c1bba3 (cherry picked from commit be08f61d6f4121079c534af386139db23d0dd2c3)
2018-08-12tdf#119133: Fix initial file and folder selectionKatarina Behrens
what d7fc00e1f7ab7a44e6102a and 1af4ab72e2488515fcaede already does for kde5 Change-Id: I924bdc5cfd6a12ff7bdbeef36d606c03307cb99b Reviewed-on: https://gerrit.libreoffice.org/58832 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 87a4623a8dd5c9efed8335bb56145b9ea9dcce36) Reviewed-on: https://gerrit.libreoffice.org/58906 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-10"make debug=t" enables debuginfo againStephan Bergmann
...which had inadvertently been broken with 99db9f2295eb9a8b3288df9798a292b8d6e1b854 "Make --enable-symbols orthogonal to --enable-debug/-dbgutil" Change-Id: I3962aa8c67426f3aebc5ad746f7ac281c68d941a (cherry picked from commit 62c4a8aacf76771e97a8da35096e6ad69a11979a)
2018-08-10Get rid of odd ENABLE_SYMBOLS=FALSEStephan Bergmann
* None of the other ENABLE_* support anything but TRUE or empty. * Other checks for -n "$ENABLE_SYMBOLS" in configure.ac are confused by it. * solenv/gbuild/gbuild.help.txt talks about "If not empty", not mentioning "FALSE". * A missing (redundant) explicit --disable-symbols left gb_SYMBOL uninitialized (instead of setting it to $(false))---but without consequences, as all the places checking gb_SYMBOL explicitly check for $(true). Change-Id: Id004189de27a7936862dab3a5fd84d549c06af2b Reviewed-on: https://gerrit.libreoffice.org/27057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 436ee0989d1bc321886fac5a3507fc1d16650abd)
2018-08-10Resolves: tdf#112269 libwpd fixCaolán McNamara
Change-Id: I0d8d6887fa360c05d5f9e2a070410c77926b9ce1 Reviewed-on: https://gerrit.libreoffice.org/42056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 05da1c67e49a2d758799db735a826c4d292fea44)
2018-08-10use correct sizeDavid Tardon
(cherry picked from commit d1ae31a1fc49ec7a68b2a07c5e5e97d95b346ca9) Change-Id: I620ada9b209bb2084eccaa81385beb6306d6a3d0 Reviewed-on: https://gerrit.libreoffice.org/38827 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 54e7b46718bf2f47c7f55a93cfbb23681429ffc6)
2018-08-10curl: in 7.52.1, the parameter is documented as --with-libidn2,Michael Stahl
but actually it is --with-libidn (it's consistent in later versions). Change-Id: Ib24767974173e4c737fc10d9420e6dbad3440239
2018-08-10curl: disable protocols nobody needs in MSVC buildMichael Stahl
These are disabled via configure on other platforms. Change-Id: I4e27865396f3817ceb5645ab8589c21fdaa5afab (cherry picked from commit 152a1d279cbc81e7b5f076a2c4b20c12c6929ce6)
2018-08-10curl: disable more unnecessary stuffMichael Stahl
Only HTTP and FTP should be required. Add --without-libpsl --disable-ares --disable-rtsp --disable-smb, and --without-libidn was replaced with --without-libidn2. Change-Id: Icf6afc8bff4cc7ad7a5a95b0c3f9a345a7cf67a3 (cherry picked from commit 9fd26734d3cbbd9b58f4b08058a75063632f57d1)
2018-08-09Related: tdf#50613 use an own instance of ThreadPoolArmin Le Grand
Using the global ThreadPool (getSharedOptimalPool()) can lead to problems when more than one usage executes and one of them already calls waitUntilEmpty() what of course influences the other usage. Thus I added an own instance of ThreadPool for async loading of chart models in writer Change-Id: I4bea64af0d36e87081abec95c75574966d0fe5b9
2018-08-09sw: tdf#50613 fix async chart load handlingArmin Le Grand
Especially if synchronous loading is requested, an async worker is on the way and we would need to 'wait' for the data. Change-Id: I20f9938738c1b46bda6b9a7f5a761e82153aed3b
2018-08-09sw: tdf#50613 fix waitFinished into a loopArmin Le Grand
Change-Id: Ic8a720657c326d8d51bb3a73688b8f02b7096488
2018-08-09tdf#50613 add support to load charts asynchronouslyArmin Le Grand
Generating primitives for chart visualisation can be moved to a paralell executed task that loads the chart, thus speeding up initial visualization. This is not possible for e.g. PDF or print targets, only for edit visualization. On fallback, the replacement images of the charts are used which are metafiles and have less quality as primitives, but load quicker. Change-Id: I68caa9e1bec50832bce535b5f54633d53cdef037
2018-08-09tdf#50613 buffer OLE primitives for chartsArmin Le Grand
If OLE is a chart, buffer the primitives used for presentation as info at the SwOLEObj, after getting them the first time using the ChartHelper. Change-Id: I6d7486185f6eac450de9328d37ea800f424f351b
2018-08-06handle date autofilter entries correctly, tdf#106214Markus Mohrhard
Change-Id: I8fd2896c8998e79794a0ccaae1c2442caf8b89ac Reviewed-on: https://gerrit.libreoffice.org/35730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/58352 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-06add test for tdf#106214Markus Mohrhard
Change-Id: I9998aa40c3831a6033d4d61a6eab90d639ec5aa9 Reviewed-on: https://gerrit.libreoffice.org/35731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/58353 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-24cannot sign read-only files, so u+w the redistributablesChristian Lohmaier
Change-Id: I5290d2093555d00e7b7cd4e21098d54af58ee6b8 (cherry picked from commit 5e062501eb6c3abe5219777fd9267702689785c7)
2018-07-24canvas: error C2397: conversion from 'size_t' to 'BYTE' requires ...Michael Stahl
a narrowing conversion (at least other people's MSVC says so, mine doesn't complain) (cherry picked from commit f2d039f67743c7588df5cfd725915627b6efb0ba) Conflicts: canvas/source/directx/dx_canvasbitmap.cxx (unrelated en passant fix in 8fe0733b45c161a36fc92da488f9bf72ebfd3bbb) Change-Id: Ic87da76567778884b81361067075fd9325e2d276
2018-07-23use VS 2015 to target XP with the 7.1A SDKChristian Lohmaier
Change-Id: I527a524c282d4314e57c30cdd9eb89bff38443db
2018-07-23tdf#112928: don't use "magic statics" for 5.4 (fails on WinXP)Mike Kaganski
https://stackoverflow.com/questions/32517234/access-violation-on-static-initialization Change-Id: Ibda63c6307e6dc4ae1eec4b0c673a987f33bed94 Reviewed-on: https://gerrit.libreoffice.org/43721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-23Fix VS2015 build in the presence of newer SDKsThorsten Behrens
This broke e.g. when installing VS2017 alongside - following commits or partial commits from master are included: - Fix include and library paths for at least me (cherry picked from commit b076e8f673d1714ee8b6f991eb2ca299b6fa8949) Change-Id: I647ec1d0924ba4c743e4c16d2fa0a05014e0b2e3 - Adapt to Windows SDK 10.0.15063 (cherry picked from commit a4d1ed6ba2a81b4284cd360f44b6723bc9bfaf85) Change-Id: Ia403e4bde7b1abf7e2c9d9f084a05af2d1311617 - Part of 'Support MSVC 15.0' (cherry picked from commit b862cbdd345ec57c2595629ded6a3969e1e65d56) Change-Id: Id5783ac6a01612475ac2b62856a793337865d709 - Lets see if basing WINDOWS_SDK_BINDIR_NO_ARCH on WINDOWS_SDK_HOME works better (cherry picked from commit e8ffe54dec568332c301f8510f3186c04421b911) Change-Id: I13a369ba34b63392ec42333dbc1e538b49a24ca1 Change-Id: I13a369ba34b63392ec42333dbc1e538b59a24ca1 Reviewed-on: https://gerrit.libreoffice.org/57835 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-13Refresh linked OLE representation when OLE updatedArmin Le Grand
Change-Id: If949778779f1a91901412938d0b0298e1d7cfc3e Reviewed-on: https://gerrit.libreoffice.org/57357 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-10tdf#118063 Impress: Deselected spacing remained checkedIlhan Yesil
The state of the attributes for spacing are now read and set correctly. Change-Id: I661c00e247b55c64ea39c03db77dab9fa0775852 Reviewed-on: https://gerrit.libreoffice.org/55455 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 5b72382516d94bc27321461297ded92f8af8112d)
2018-07-05vcl: fix -Werror=shadowThorsten Behrens
Change-Id: If8897bc7e7a20961b2a325f20351ae9b6942563e
2018-07-05tdf#101856 sw: hidden bookmark portions in SwTextFormatter::NewTextPortion()Michael Stahl
All other hidden-text features already have a AUTOFMT hint or a TXTFIELD hint, so the SwAttrIter already creates new portions for them. The bookmarks aren't considered by SwTextFormatter currently, but SwScriptInfo already has all of the required info. Change-Id: I451ce331110aa58df8955e1a3ffa339e6f905b22 Reviewed-on: https://gerrit.libreoffice.org/56937 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-05gcc7: disable -Wdeprecated for dynamic excpt specsThorsten Behrens
gcc started to warn about c++11-deprecated dynamic exception specifications thusly: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated] so disable this on the branch instead of a massive backport. See https://en.cppreference.com/w/cpp/language/except_spec for a discussion; this is still perfectly correct c++ code. Change-Id: Iffbb82e4da24fb96fab57f233b8ebe41fbc850fa Reviewed-on: https://gerrit.libreoffice.org/56981 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>