summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-04-03Sketch of BinaryDataContainer swap out ...private/mmeeks/swapdatacontainerMichael Meeks
Change-Id: Ib7ca45afb8499460b1852461f7c11afca3f3cdfa
2023-04-03BinaryDataContainer: account for in-memory size of un-compressed image.Michael Meeks
Change-Id: Ia86d4dda706959bb58e941e65f2b2f7fffa8dc3d
2023-04-03clang-format noise to make porting to/from master easier.Michael Meeks
Change-Id: I0df08baa9504c09d8f850ce54670dfa9671220bb
2023-04-03jsdialog: enable and make async chart line prop dialogSzymon Kłos
Change-Id: I21817b21fe6d2ce0a6f6bd784c0e24fe35b17fec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149502 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-04-03tdf#154521 sw Navigator: fix selection change event of bookmarkLászló Németh
In Navigator, double click or enter on a bookmark name selects the bookmark in the text, but the triggered selectionChanged event didn't give access to the actual selection, but only to the start of the previous one. Note: newly enabled Navigator tree item "Bookmarks" is not stateless on some test platform, so adjust unit tests according to the (now) unknown index of the requested tree items. Change-Id: Iade4ea40c524a1eb14737669bb3d21f22b556c76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149895 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 117b1fcdf94eb7959240c09c544cb6754d8c7b44) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149880 Tested-by: László Németh <nemeth@numbertext.org>
2023-04-03tdf#154549: Make combining marks inherit the script of their baseKhaled Hosny
... regardless of the script of the mark itself. Change-Id: I15a5d8cb2e1d7b7a26316689ffa11c278d1f6365 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149925 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com> (cherry picked from commit b320a33c01e4b87d42c2f3828a1dfd88c386df67) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149884 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03tdf#154445 - Export all page styles even if they are not in useAndreas Heinisch
Change-Id: If0ca5ea97ad545058c6a70d223158a87bf9207ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149729 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit 8085a68be7604e7bd00004e0d9445be5e266ffbb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149735 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-03fix poppler buildTaichi Haradaguchi
* Update POPPLER_VERSION in poppler-config.patch.1 Change-Id: Iba770e6a3036a091925997025d4528f1d855da5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149794 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03[3.0] external/openssl: add patch for CVE-2023-0464Taichi Haradaguchi
this issue should be fixed in release 3.0.9 Severity: Low Security Advisary: https://www.openssl.org/news/secadv/20230322.txt Change-Id: I8d34acd72ac8eb7e9e83b241eb1235a93111884a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149609 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03Related: tdf#154005 sc ods fileopen: fix dropdown form control sizeBalazs Varga
Fixing the crashtesting assert/crash after the original change. Also a little clean-up. Change-Id: I35453fbc55b3d5d4064179e84755334c2d3a01ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149583 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> (cherry picked from commit 69cc8bdd5f9109804d912b52d5ee1040d6e1868f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149597 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-03Sync flatpak-manifest.in with FlathubStephan Bergmann
...including <https://github.com/flathub/org.libreoffice.LibreOffice/commit/85022d587be454efd482bcb9baf657d570cc7d06> "Update GVFS, Kerberos5, Apache Ant and OpenJDK Flathub Extension" Change-Id: I6b03adb5872958578b7b2e4bfe3e26bea8882213 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149679 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit cfe339efd5f306452bc78ae4121867dc9b07b95a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149613 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-03tdf#154115 use correct column for searchCaolán McNamara
Change-Id: Iaa390e63d269221b7273fe15362cfbdf20f235da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 1d2ad8e8823a8633534580d589270945f01f1ca1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149694 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03Resolves: tdf#154433 Correct {uk-UA} quotation mark charactersEike Rathke
Change-Id: Id5c251ee632d2da134ffbbb352844152f12c1f77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149654 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 2836aaeccee092d2e809839c5d6cc7656aa2e77b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149611 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03tdf#152234 vcl: PDF/UA export: StructElem<->Annot for form controlsMichael Stahl
veraPDF complains: Specification: ISO 14289-1:2014, Clause: 7.18.4, Test number: 1 A Widget annotation shall be nested within a Form tag per ISO 32000-1:2008, 14.8.4.5, Table 340. This is a little simpler than for Link and Screen annotations, because the form control StructElem and Annot are exported at the same time from VclMetafileProcessor2D::processControlPrimitive2D(). So PDFExtOutDevData can just make up the mapping on playback. Change-Id: Idacb84a3e414f45a2598ccb33b252205cb2bcde9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149556 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit d9031bd83ffe718a80da9ecbdbeb485e35fbabee) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149603 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03tdf#152234 drawinglayer,svx: PDF/UA export: add Alt text to form controlsMichael Stahl
Specification: ISO 14289-1:2014, Clause: 7.18.1, Test number: 3 A form field whose hidden flag is not set and whose rectangle is not outside the crop-box shall have a TU key present or all its Widget annotations shall have alternative descriptions (in the form of an Alt entry in the enclosing structure elements) Form controls are weird because they have an SdrObject with the usual name/title/description plus a property "HelpText" on the control itself which is already exported as "/TU" on the /Annot unless it's empty. Exporting the SdrObject properties via ObjectInfoPrimitive2D doesn't work as tragically that is only created for form controls when painting to the screen while PDF export takes a detour that needs special handling. Change-Id: Id96f7dd13f190ab439c099cd1f4acb70c1c9fdc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149554 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 002a6fee2fbd07c3f0cd1f1ddba39c691130727e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149602 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03tdf#153628 sw: fix locked spell checking in spelling dialogLászló Németh
Which resulted incomplete spell checking finished before checking the document. Regression from commit b484e5d9e0d22b794c2d1c73741191836158a4ad "use more SwPosition::Assign". Follow-up to commit 2780b026f912a103aea3f8dc19319b998d19a43a "tdf#152738 sw: fix lost SwPosition in spelling dialog" and commit 221d76260096b9e6b4c4479b1b89c95af8b05774 "simplify assignment". Change-Id: Ib66903596847016ddaf68da42813dd3a839adb59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149633 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 4fa0664acfd13111d96801bfd643d10ec838bd35) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149610
2023-04-03tdf#126632 tdf#152908 Resize the notebook bar on context changeJim Raykowski
For other than gtk vcl backend the tabbed compact toolbar tabs do not repaint correctly when the 'Table' tab is active and the cursor is move outside of the table. This patch adds a Resize after the context is set to make the tabs always show as expected. Change-Id: Iedf8a6eea52c3c55e9c1266b7aa79bc0f34deb22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149593 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit e0daa98a802cc1f84ceb0f306f5d15fecabd62c1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149599 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-03tdf#154296 Fix customize notebook bar regressionJim Raykowski
caused by commit e79741488cc740f49ebd4426c40b45e7139ff663 Change-Id: I04fe66124af831c73834b7f695458e1667198ddb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149470 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 48b7cf3182cc8fb0b728860f9cbb489390074101) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149600 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03libjpeg-turbo: upgrade to release 2.1.5.1Taichi Haradaguchi
Fixes a serious regression that 2.1.5 had.[1] [1] "Release 2.1.5.1 · libjpeg-turbo/libjpeg-turbo" <https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/2.1.5.1> Change-Id: I0586d735e17789482e0e8e667aafd2b5613a1232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149308 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03cid#1524497 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ic3f347b9a588bda459411f917be47cbfa442d3e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit bba53ddf3634bda503398ebd466484f85fa2d994) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149446 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03Resolves: tdf#154322 if entries are disabled while menu is active, update itCaolán McNamara
Change-Id: Id5cad5f2f4ac21db8675de16f1bc0ceeff39fe6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149427 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03tdf#154307 remove instead of hide these menu entriesCaolán McNamara
because on kf5 they are getting shown, which suggests a wider more generic bug on that variant, but use remove for this specific case because that's ok for this usage and works around the problem for now. Change-Id: Ib2bc316cc33894253a0b6335ae8643d0c8d78794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149304 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03Related: tdf#154205 avoid use of destroyed ViewShellCaolán McNamara
Change-Id: Ife553269e0cdeb331931a885a3dd4f87c1c3d9bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148940 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 12233f437e6299e6dcea3ee1490a80da2bef2372) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149501 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03Related: tdf#154205 skip Invalidating content a11y relations when closing docCaolán McNamara
Change-Id: If6dbc02f1ec22be9f020290572199f89548c76e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148939 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 67d353ff50712a036d04b1c0ffab68f2a21b5008) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149500 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03filter: PDF export dialog: always disable ReferenceXObject for PDF/UAMichael Stahl
7.20 XObjects Reference XObjects, as noted in ISO 32000-1:2008, 8.10.4, shall not be used in conforming PDF/UA files. Change-Id: I62a4b6b76a6cb1d14d4fd39fad90ec0323a481c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149261 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 089b9e21c7210df3e5ee312a06131ce410989cf7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149303 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03vcl: PDF/UA export: produce UF and Desc for embedded filesMichael Stahl
7.11 Embedded files The file specification dictionary for an embedded file shall contain the F and UF keys and should contain the Desc key (ISO 32000-1:2008, 7.11.3, Table 44.). Also write Alt text as hex/unicode string, not literal string. Change-Id: Id83597cc5ea645bd57c110514bafede433aee572 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149259 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit d41c3c820dad7c78bc57815e0f4a6999d125561d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149319 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03vcl,drawinglayer,svx,sw,sd: PDF/UA export: Annot StructElem for SdrMediaObjMichael Stahl
veraPDF complains: Specification: ISO 14289-1:2014, Clause: 7.18.1, Test number: 1 An annotation, excluding annotations of subtype Widget, Popup or Link, shall be nested within an Annot tag This is very similar to Link annotations, that is to say, extremely complicated to get it thought the convoluted PDF export code, with additional complication that the StructElem is produced by drawinglayer and the page annotation by sw. Put another map into PDFExtOutDevData where sw code puts stuff for the SdrObject that drawinglayer can find. The test had the problem that PDFObjectParser::parse() could not handle: <</Nums[ 0 [ 6 0 R ] 1 6 0 R ]>> Fix dropping the "1". Change-Id: If5bf7c552e26ebb7e631030b8aaecd4281e77acc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03vcl,sd,sw: PDF/UA export: add Alt text to SdrMediaObj media shapesMichael Stahl
7.18.6.2 Media clip data In the media clip data dictionary, the optional CT and Alt keys (ISO 32000-1:2008, 13.2.4.2, Table 274) are required. Change-Id: I147f1677f1bd0788c2269735688d329db15c0ead Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149007 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit e7d5e346677efeb7d7d14537a9151ea7a1a32809) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149106 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03sd: PDF export: produce annotations for shapes before painting shapesMichael Stahl
This is the same order as sw SwEnhancedPDFExportHelper and required to connect media shape Annot to its StructElem. Change-Id: I1d421e5d353261e32b28a0429cd73f156c692260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149060 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit fb93cf7e3f70cf711742c5b492d520d9d49c3c5e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149302 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03tdf#149485: Revert "tdf#142450 add code to store showing whitespace"Xisco Fauli
This reverts commit 5b07acbf3345918f450fccf7ee243ad5bcb3fd67. The reverted commit claims that "This option is stored at the document level like the other layout options." which is not true. The option is saved in the user profile, which makes other documents to look wrong. Reverting for now until it's implemented at document level as the commit suggests Change-Id: I2ae0daeb410090949f1b6cfc8245b711fe518216 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149541 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 3795729fd0f4bc4769d69b45d3536c7b01692b92) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149520 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03tdf#151722 restore use of localized font nameCaolán McNamara
basically disabled back with: commit cc93f06f93eeaaee5811588d90929ebc72bf9724 Date: Fri Apr 23 12:28:26 2010 +0200 #i111108# do not prefer fontconfig familyname because of i79878 to avoid stuff like "DejaVu Condensed" getting reported as "DejaVu" with a "Condensed" style. Rather than reopen that problem, just tweak analyzeSfntFamilyName to use the UI lang instead of the system lang as the preferred lang. Change-Id: I41f128d1a21397ff7880f34985c1553b890b4747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149542 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 45da2754222d1fd6ffb02636b8568b4ac6472979) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149519 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03update creditsChristian Lohmaier
Change-Id: Iea1190aa7e0b9d81a8cf73ebbafd318e73fca757 (cherry picked from commit 9469044db420f280bf60765e0d94bc7d94e6641e)
2023-04-03Revert "qa: call ProcessEventsToIdle inside dispatchCommand"Xisco Fauli
This reverts commit 1029afe2fa49a3a326ca529a68e99e2a7239a395. number of failures in CppunitTest_sc_uicalc has increased since this patch was backported. reverting it to find out for sure whether this introduced it or not Change-Id: I670412d9445aee5ca2d65f647a82b993682d088f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149518 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-03rhbz#2171265 Filter out all non *.rdb filesStephan Bergmann
In that rhbz issue ("Libreoffice cannot start"), it looks like some junk file named /usr/lib64/libreoffice/program/services/services.rdb;63ddcd86 caused soffice.bin to crash early, without any information (cf. a1faf14f74a62ea76141115538d7d30d90c9eeb6 "rhbz#2171265 Report fatal InitApplicationServiceManager failures more reliably"). So, following up on b8c7548527f5fc14fe8fcbe74a749c7e3c10d385 "ignore backup files in services/ directory to avoid debugging grief", extend the set of ignored files to anything starting with "." or not ending in ".rdb" (in any case). Change-Id: I154750465d2128b3ff6493f4ab606072dda61503 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149328 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit feb8b04a0ee86b0146a17393da220ae188babda8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149436 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-03rhbz#2171265 Report fatal InitApplicationServiceManager failures more reliablyStephan Bergmann
For example, when initialization of the UNO type manager failed, any code run between this SetBootstrapError and the HandleBootstrapErrors in Desktop::Main which would need the type manager (e.g., to set a css::uno::Any) would have caused a crash, so would have failed to print to std::cerr the sought-after css::uno::Exception message. The mis-initialized process would most definitely crash sooner or later anyway, so there's no harm in a controlled std::abort() here (if that is even reached, and the process doesn't already crash in HandleBootstrapErrors, after it has printed the relevant information to std::cerr). Change-Id: Ic5889aedec0908fa4b1e2966eb188508d0f92d26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149323 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit a1faf14f74a62ea76141115538d7d30d90c9eeb6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149440 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-03tdf#154319: fix TOC field codes parsingMike Kaganski
Change-Id: I734697f52df14ca5b316481df8a58fef72ab9571 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149254 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 76777c82fa4bb5080c135e2241c3f7122dcbb298) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149437 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-03tdf#153808 Fix numbering preview in dark modeRafael Lima
This patch fixes the color used for numbers and bullets in the preview of the Bullets and Numbering dialog in Impress. Currently the implementation causes the bullets and numbers to be rendered in white over a white background when using dark mode. The fix uses DOCCOLOR and FONTCOLOR to create the preview, instead of FieldColor and FieldTextColor. Change-Id: Icf41c5be59c67a2d68e3c520744276492e9baa59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147664 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 3a4b32c9e1dfc56d9b00e3720834d21c9095f629) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149435 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-03fix crash seen when experimenting with tdf#129547Caolán McNamara
Change-Id: I0b26a7f683f91d3307856f86c5a437fde1155451 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 936f2e6924e405433770b98f32a615508fd0670d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149434 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-03crashreporting: BitmapEx::operator=(BitmapEx const &) crashesCaolán McNamara
e.g. https://crashreport.libreoffice.org/stats/crash_details/b68d5267-16b1-4ee9-bd42-bdcecdb7043c this went wrong with: commit 91bc1e6a8c92a7c895f0ba9dcad9ac4d35f3f791 Date: Sat Jun 25 10:21:17 2022 +1000 vcl: extract function Animation::RenderNextFrameInAllRenderers() Change-Id: Iaccf12b251ffe06e24813c48ba3a169d0eaaa61c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76416 which substituted mnAnimCount with nAnimCount which is a subtle one char difference, but mnAnimCount is a different thing entirely than the (then local variable) nAnimCount. mnAnimCount is the count of animations active, not the number of animation frames in a specific animation. orig code was const size_t nAnimCount = maFrames.size(); so replace mnAnimCount here with maFrames.size() to get back to the original logic Change-Id: I11d1797eb0b9ef61addb3769d12d8364872071df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149442 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-03sw: check GetActiveView()Xisco Fauli
See https://crashreport.libreoffice.org/stats/signature/SwView::GetDocShell() Change-Id: I90ebbff5082f1f9cae7fa3b940cbb9796d6c6dd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149223 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149320
2023-04-02tdf#154318 elementary: Fix 5 Quarters Conditional Formatting Icon SetsRizal Muttaqin
Change-Id: I60d57891d460f795efd7e0151dc434f427251fee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149288 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org> (cherry picked from commit d79350a7653a96126dca901d2054574c23bb390e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149301
2023-04-02Revert "avmedia : use std::mutex instead of osl::Mutex"Michael Stahl
This reverts commit 477fa6c3cb92f578032dee60482718efdb8f44f2. MissingPluginInstaller requires a recursive lock: Thread 2 (Thread 0x7f8e73d69700 (LWP 29931)): 0 __lll_lock_wait () at /lib64/libpthread.so.0 ... 5 std::unique_lock<std::mutex>::lock() (this=0x7f8e73d65a88) at /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/std_mutex.h:267 6 std::unique_lock<std::mutex>::unique_lock(std::mutex&) (this=0x7f8e73d65a88, __m=...) at /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/std_mutex.h:197 7 avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller::detach(avmedia::gstreamer::Player const*) (this=0x7f8e644c6be0 <rtl::Static<avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller, avmedia::gstreamer::(anonymous namespace)::TheMissingPluginInstaller>::get()::instance>, source=0x75d2fa0) at avmedia/source/gstreamer/gstplayer.cxx:187 8 avmedia::gstreamer::Player::disposing() (this=0x75d2fa0) at avmedia/source/gstreamer/gstplayer.cxx:334 9 cppu::WeakComponentImplHelperBase::dispose() (this=0x75d2fa0) at cppuhelper/source/implbase.cxx:104 10 cppu::PartialWeakComponentImplHelper<com::sun::star::media::XPlayer, com::sun::star::lang::XServiceInfo>::dispose() (this=0x75d2fa0) at include/cppuhelper/compbase.hxx:90 11 cppu::WeakComponentImplHelperBase::release() (this=0x75d2fa0) at cppuhelper/source/implbase.cxx:79 13 rtl::Reference<avmedia::gstreamer::Player>::~Reference() (this=0x7f8e7c028f20) at include/rtl/ref.hxx:129 ... 21 std::__debug::set<rtl::Reference<avmedia::gstreamer::Player>, std::less<rtl::Reference<avmedia::gstreamer::Player> >, std::allocator<rtl::Reference<avmedia::gstreamer::Player> > >::clear() (this=0x7f8e644c6cd8 <rtl::Static<avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller, avmedia::gstreamer::(anonymous namespace)::TheMissingPluginInstaller>::get()::instance+248>) at /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/debug/set.h:426 22 avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller::report(rtl::Reference<avmedia::gstreamer::Player> const&, _GstMessage*) (this=0x7f8e644c6be0 <rtl::Static<avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller, avmedia::gstreamer::(anonymous namespace)::TheMissingPluginInstaller>::get()::instance>, source=..., message=0x7cdb400) at avmedia/source/gstreamer/gstplayer.cxx:156 23 avmedia::gstreamer::Player::processSyncMessage(_GstMessage*) (this=0x75abfe0, message=0x7cdb400) at avmedia/source/gstreamer/gstplayer.cxx:536 24 avmedia::gstreamer::pipeline_bus_sync_handler(_GstBus*, _GstMessage*, void*) (message=0x7cdb400, data=0x75abfe0) at avmedia/source/gstreamer/gstplayer.cxx:382 25 gst_bus_post () at /lib64/libgstreamer-1.0.so.0 Change-Id: Ia8e7fef4d4cee2dde7189702af6dddf883b6cceb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149233 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 621143588b3cb438baf27fb6893ab02e7b06f9dd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149297 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-04-02tdf#153255 DOCX import: fix footnote orderLászló Németh
Simple unit test for tdf#152203 allowed to create bad ordering algorithm by accident without noticing the problem, which caused problem for most of the DOCX files, where serialization in footnotes.xml doesn't follow the order of the footnotes. Regression from commit 9b39ce0e66acfe812e1d50e530dc2ccdef3e1357 "tdf#76260 DOCX import: fix slow footnote import". Follow-up to commit 09ae3c01940bbc25ffde51963683b04e3cb4bb6a "tdf#152203 DOCX import: fix mixed footnotes/endnotes". Change-Id: I0628d96e3b8ad4df38d26e9288b47d39b958c441 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149176 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 93a20c1d9c2f379906970bbe8a15905fc1a328bc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149242 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-02tdf#140762 tdf#152671 Make dock win visible before showing popupMichael Weghorn
The fact that the docking window got hidden (in `ImplPreparePopupMode`) and only shown again after starting popup mode for the containing floating window meant that the docking window and its children were still invisible when starting popup mode. Therefore, they would also not be considered/returned as accessible children when listeners are registered for accessible children in winaccessibility's `AccTopWindowListener::AddAllListeners`. As a consequence, no a11y events would be sent when they receive keyboard focus and they would not be announced by the NVDA screen reader. Make them visible again *before* starting popup mode for the floating window. This e.g. makes NVDA announce popups in the toolbar or the Calc autofilter dropdown. Change-Id: I6953e4b491db4708ba30fb98173d13391d6e0461 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148933 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit c379f1b978c3ad4578c130675c1e0a82c70823c0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148958 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-02curl: upgrade to release 8.0.1Michael Stahl
Apparently 8.0.0 had a serious regression. Change-Id: Icc761f5e5e01b5d9bebecc13f7cba608f5834f54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149204 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit e5005c76bd60a004f6025728e794ba3e4d0dfff1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149111 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-02tdf#154303 wina11y: Don't truncate 64-bit statesMichael Weghorn
commit 8d8e6c84e512c1a8b33aac75965b84481d1a1d13 Date: Sun Jul 3 20:29:28 2022 +0200 [API CHANGE] Drop css::accessibility::XAccessibleStateSet had introduced the use of a 64-bit integer with bit flags for the accessible states. However, `AccObjectWinManager::DecreaseState` and `AccObjectWinManager::IncreaseState` were still using unsigned short, resulting in truncation. As one result, the `AccessibleEventId::STATE_CHANGED` event with state `AccessibleStateType::VISIBLE` from `OAccessibleMenuBaseComponent::SetVisible` would no longer result in the `STATE_SYSTEM_INVISIBLE` being unset and thus the the JAWS screen reader would no longer announce the focused (but considered invisible) menu item. Fix this by switching the param for those two methods to sal_Int64 as well. Change-Id: I714573e2691e82c6287a4b83f872f87568e46495 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149255 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 2f206b84385ed62bb56982270dce57ad4dace472) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149294 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-02tdf#152406 Disable anti-jitter code for scroll wheel eventsPatrick Luby
After moving thousands of columns to the right via horizontal scroll wheel or trackpad swipe events, most vertical scroll wheel or trackpad swipe events will trigger the anti-jitter code because nScrollPos and nPrevDragPos will be equal and nDelta will be overriden and set to zero. So, only use the anti-jitter code for mouse drag events. Change-Id: I9a22b31e1e012a97a058ab36e040629a71f5d24f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149183 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d82a734c07b85cbd7861699b7fa6d3ebbb3122f2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149238
2023-04-02crashreporting: CreateEmbeddedObject might failCaolán McNamara
Change-Id: I0e1ccbea92343d18e5ff3a9af1f54ed5e0dd796b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149113 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-02tdf#154232 signal_drag_begin callback can delete current GtkTargetListCaolán McNamara
so fetch the up to date one on calling gtk_drag_begin_with_coordinates ==3221972== Invalid read of size 8 ==3221972== at 0x23F281DA: gtk_drag_begin_internal (gtkdnd.c:1801) ==3221972== by 0x23F2886F: gtk_drag_begin_with_coordinates (gtkdnd.c:1995) ==3221972== by 0x23845075: (anonymous namespace)::GtkInstanceWidget::signal_motion(_GdkEventMotion const*) (gtkinst.cxx:3139) ==3221972== by 0x23844F09: (anonymous namespace)::GtkInstanceWidget::signalMotion(_GtkWidget*, _GdkEventMotion*, void*) (gtkinst.cxx:3130) ==3221972== by 0x23C0FC56: _gtk_marshal_BOOLEAN__BOXED (gtkmarshalers.c:84) ==3221972== by 0x1378C05F: g_closure_invoke (gclosure.c:832) ==3221972== by 0x137B8F65: signal_emit_unlocked_R.isra.0 (gsignal.c:3796) ==3221972== by 0x137A8ED5: g_signal_emit_valist (gsignal.c:3559) ==3221972== by 0x137A96F2: g_signal_emit (gsignal.c:3606) ==3221972== by 0x23EF1073: gtk_widget_event_internal.part.0.lto_priv.0 (gtkwidget.c:7812) ==3221972== by 0x23D825AD: UnknownInlinedFun (gtkmain.c:2588) ==3221972== by 0x23D825AD: propagate_event.lto_priv.0 (gtkmain.c:2691) ==3221972== by 0x23D83320: UnknownInlinedFun (gtkmain.c:1921) ==3221972== by 0x23D83320: gtk_main_do_event (gtkmain.c:1691) ==3221972== Address 0x2c7d8070 is 0 bytes inside a block of size 16 free'd ==3221972== at 0x48460E4: free (vg_replace_malloc.c:884) ==3221972== by 0x1383388C: g_free (gmem.c:229) ==3221972== by 0x1384E093: g_slice_free1 (gslice.c:1185) ==3221972== by 0x23CD7A08: gtk_drag_source_set (gtkdragsource.c:162) ==3221972== by 0x23ED1EAB: gtk_tree_view_enable_model_drag_source (gtktreeview.c:14303) ==3221972== by 0x23877F41: (anonymous namespace)::GtkInstanceTreeView::drag_source_set(std::__debug::vector<_GtkTargetEntry, std::allocator<_GtkTargetEntry> > const&, GdkDragAction) (gtkinst.cxx:16279) ==3221972== by 0x238440B3: (anonymous namespace)::GtkInstanceWidget::do_enable_drag_source(rtl::Reference<TransferDataContainer> const&, unsigned char) (gtkinst.cxx:2707) ==3221972== by 0x23877E99: (anonymous namespace)::GtkInstanceTreeView::enable_drag_source(rtl::Reference<TransferDataContainer>&, unsigned char) (gtkinst.cxx:16270) ==3221972== by 0x36AAE6D2: SwContentTree::DragBeginHdl(bool&) (content.cxx:1227) ==3221972== by 0x36AAE2CE: SwContentTree::LinkStubDragBeginHdl(void*, bool&) (content.cxx:1180) ==3221972== by 0x238D38DA: Link<bool&, bool>::Call(bool&) const (link.hxx:111) ==3221972== by 0x23878D2D: (anonymous namespace)::GtkInstanceTreeView::do_signal_drag_begin(bool&) (gtkinst.cxx:16520) Change-Id: Idffa33c6a549bf17a92eb56760ddfb7d5424b7ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-02curl: upgrade to release 8.0.0Michael Stahl
Fixes CVE-2023-27535. Also hopefully fixes excessive storage consumption during build: o build: drop the use of XC_AMEND_DISTCLEAN [62] Change-Id: I8792e95bc7634ee496488e80fec5a1310b24a31c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149153 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit bbe0d0534abe6480c4502ce8fb543a736d3399d8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149105 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-05-08 03:27:18 +0000