summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-12-19wrap scoped enum around css::util::NumberFormatNoel Grandin
Change-Id: Icab5ded8bccdb95f79b3fa35ea164f47919c68fa Reviewed-on: https://gerrit.libreoffice.org/46339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-19Read some configuration items directlyStephan Bergmann
...removing them from SvtSaveOptions Change-Id: I922ec0f88872b1f2d99c6a55faad00143d944473 Reviewed-on: https://gerrit.libreoffice.org/46797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-19Remove unnecessary -Wunknown-pragmasStephan Bergmann
...which was added with 92dfa82d2d25f2acdee0a538bf15f1fac36c0ecf "adjust for upstreaming of warn_unused attribute" but appears to be unnecessary cargo-copy from bdb87236dcbc1187b15e1a457e130ff997b0949b "Fix pragma GCC diagnostic checks". Both old GCC (e.g., 4.8.5) and Clang (e.g., 3.4.2) emit a -Wattributes warning/error here by default. Change-Id: I2fd81ac411000c4b851a77de432bf14eb1bc0d61 Reviewed-on: https://gerrit.libreoffice.org/46796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-19tdf#114545 Enabling/Disabling Ok button depending on correct formattagezi
Change-Id: Iab3c4363dda0260d16c7167946044c39c21b863a Reviewed-on: https://gerrit.libreoffice.org/46790 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-19ofz#4689 avoid recurse to deathCaolán McNamara
Change-Id: Ie578a767cd8646c4e67c302a67b46ce1f1637122 Reviewed-on: https://gerrit.libreoffice.org/46772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-19Get rid of a dynamic_castTor Lillqvist
Add a virtual member function instead. This improves performance a bit. The time to load a specific pathological customer document dropped from 1min 53s to 1min 47s on my machine. Not hugely, but clearly. Change-Id: I1e59d601e9d0e14b6a756c6e0ad29ce2a1fce66d Reviewed-on: https://gerrit.libreoffice.org/46791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-12-19Add UI config option to enable/disable threadingDennis Francis
Change-Id: I7a83d80c0db233a48026d1254021b926f28002f3 Reviewed-on: https://gerrit.libreoffice.org/46782 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-19LOK: fix URL launching, so that Help buttons work.Michael Meeks
Change-Id: I9efe0173c35341043c3402042d9aa364a03e4fc5 Reviewed-on: https://gerrit.libreoffice.org/46419 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 2ccf578372cd77060abb6db520985165e779de3f)
2017-12-19lokdialog: Handle closing of modeless dialogs tooPranav Kant
Change-Id: I87ed60e940fad199b14a2e2179cc1f10008bfe93
2017-12-19lokdialog: Allow windows / dialogs in different languages.Jan Holesovsky
Change-Id: I9f32161981aed73e6d97696e5f976af276d1625a Reviewed-on: https://gerrit.libreoffice.org/46327 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/46775 Tested-by: Jenkins <ci@libreoffice.org>
2017-12-19Remove obsolete Clang <= 3.1 checksStephan Bergmann
...after fa7b7f73938e837af2765f8a03f07e404046877b "Document that Clang 3.4.2 is known to be too old" Change-Id: Ia9fc056b58c7674c8aa0e0bf6c079ecd56d06629 Reviewed-on: https://gerrit.libreoffice.org/46771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-19don't export category info to bubble charts, tdf#103988Markus Mohrhard
Change-Id: Ic2ecd959841172db3f4016b4a1ba667238c6c508 Reviewed-on: https://gerrit.libreoffice.org/46749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-12-19sal_uLong->sal_Int32 for SfxAcceleratorConfigPageCaolán McNamara
Change-Id: I2ec647b140c6be6c5cb6727873cca4cad16a664e Reviewed-on: https://gerrit.libreoffice.org/46701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-19uitest - writer "delete all comments"; move writer tests to sw/qa/uitestZdeněk Crhonek
Change-Id: Id7d6a2a413234b07df3f0f07184e7e33fec73633 Reviewed-on: https://gerrit.libreoffice.org/45985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-19tdf#91781 Round of improvements to Writer's menus for 6.0 (2)Yousuf Philips
Change-Id: Ic6baa344985963a48ba2a76c18cbf3001cbb4d11 Reviewed-on: https://gerrit.libreoffice.org/46756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-19Resolves: tdf#114539 only pop own parameters from stackEike Rathke
... and not another pending one.. Change-Id: Ief5c27ccfb0b4121f2ba019e0fb8770dabbf60cf
2017-12-19drop last CONTAINER_APPEND useCaolán McNamara
Change-Id: Ia4500cfef039100cf12bc8e8a8946395e26b6890 Reviewed-on: https://gerrit.libreoffice.org/46700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-19The Clang __float128 hack is already needed earlierStephan Bergmann
...when determining the -std= value, as that also includes <vector>. (And also note that the hack doesn't help with later libstdc++'s <algorithm>, anyway.) Change-Id: Id49b6be71e536369a9268060cb1e8ef3fbaab481 Reviewed-on: https://gerrit.libreoffice.org/46770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-19vcl: explicitly qualify ICU types with icu:: namespaceEike Rathke
It will be required by ICU 61 anyway, see https://ssl.icu-project.org/repos/icu/trunk/icu4c/readme.html#RecBuild Change-Id: Iecb30b903e9a67252147a8cc78c641621d763755
2017-12-19Don't leak SvtSaveOptions instance through ItemHolder1::holdConfigItemStephan Bergmann
...where ItemHolder1 apparently leaks the items ever since > commit ef2c49c9a5788e35249d8d5406a09c84ecd062ee > Author: Rüdiger Timm <rt@openoffice.org> > Date: Fri Nov 11 07:50:10 2005 +0000 > > INTEGRATION: CWS perform06 (1.6.60); FILE MERGED > 2005/11/07 13:32:40 as 1.6.60.2: #i56589# dont cache GlobalEventConfig() inside ItemHolder1^... combination of static pointer and WeakImplHelper cant not work > 2005/10/25 08:04:02 as 1.6.60.1: #i56589# hold config items alive till office die That started to cause problems when 78a6ce17f06fbe13b806fd563e85a4fe60d3bcfc "DELETEZ->std::unique_ptr in toolkit,unotools" now stopped to leak the global static std::unique_ptr<SvtLoadSaveOptions_Impl> pOptions; in unotools/source/config/saveopt.cxx when any SvtSaveOptions instances are leaked, so that at least PythonTest_pyuno_pytests_testcollections started to fail in ASan builds now when that global pOptions is destroyed at exit. I don't see a good reason for that ItemHolder1::holdConfigItem stuff here, so lets try and drop it from SvtSaveOptions at least. Change-Id: I6d44708fc4e2e5dfafaa9bfe8f3fa2f854ae0952 Reviewed-on: https://gerrit.libreoffice.org/46726 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-19ofz: Null-derefCaolán McNamara
Change-Id: I0194de1a136375f131c2a7c316e1a64435637e4e Reviewed-on: https://gerrit.libreoffice.org/46785 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-19tdf#114479 : Use the SvNumberFormatter from ScInterpreterContextDennis Francis
This fixes one of the crash mentioned in the bug report, during loading of the bug document. The crash being the assert failure in ScDocument::GetFormatTable(). Change-Id: Iffb8ede1416f34f0cd9852fa3f8d1f199406c013 Reviewed-on: https://gerrit.libreoffice.org/46549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-12-19Silence -Wunknown-attributes with Clang <= 3.6Stephan Bergmann
Change-Id: I2d1ec919da5b26b231598e01a52a1508c72ab815 Reviewed-on: https://gerrit.libreoffice.org/46765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-19loplugin:unusedmethodsNoel Grandin
Change-Id: I3ffd9142fed98e4df75c2c28f8a025be3e8eb803 Reviewed-on: https://gerrit.libreoffice.org/46687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19Explicitly qualify ICU types with icu:: namespaceEike Rathke
It will be required by ICU 61 anyway, see https://ssl.icu-project.org/repos/icu/trunk/icu4c/readme.html#RecBuild Change-Id: Ib7accd75a6e35932048d779cf7bf0a5a33f8ed0d Reviewed-on: https://gerrit.libreoffice.org/46741 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-19Explicitly qualify ICU types with icu:: namespaceEike Rathke
It will be required by ICU 61 anyway, see https://ssl.icu-project.org/repos/icu/trunk/icu4c/readme.html#RecBuild Change-Id: If7f1330550981fd28eb7eea6329f21e116291cca Reviewed-on: https://gerrit.libreoffice.org/46740 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-19Explicitly qualify ICU types with icu:: namespaceEike Rathke
It will be required by ICU 61 anyway, see https://ssl.icu-project.org/repos/icu/trunk/icu4c/readme.html#RecBuild Change-Id: Ia051e8e2aa64b0e32a7f16a2afebaef0e4ebf531 Reviewed-on: https://gerrit.libreoffice.org/46739 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-19Explicitly qualify ICU types with icu:: namespaceEike Rathke
It will be required by ICU 61 anyway, see https://ssl.icu-project.org/repos/icu/trunk/icu4c/readme.html#RecBuild Change-Id: I16b6bc8b8c49713f32424df5fc6db494df7b6892 Reviewed-on: https://gerrit.libreoffice.org/46738 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-19remove unused typedefsNoel Grandin
Change-Id: I6fd7a9fed3a80c91a3766fceefd43c5db0aa5275 Reviewed-on: https://gerrit.libreoffice.org/46763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19Updated coreOlivier Hallot
Project: help 9a20a71a42c6c3113b1e0c9d679565018474d2e4 tdf#92825 Update help pages for file menu for Writer and Draw Change-Id: I3af080fac087969129725360c41b75fff15f1856 Reviewed-on: https://gerrit.libreoffice.org/46755 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-19Updated coreOlivier Hallot
Project: help 60281fff05e466a706c1d18ec67e38f130a2a26d tdf#92825 Update Help page for Math File menu Change-Id: Id6a7332f65d1b55b749a762dd17322e9b22f6978 Reviewed-on: https://gerrit.libreoffice.org/46742 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-19Updated coreShinnok
Project: help 14c0b87b9fccf2bf053367da652e010af3d60752 Use quotes around positional args. Change-Id: I34daf14c83b83085ca5f8ef643e7418893da5924 Reviewed-on: https://gerrit.libreoffice.org/46696 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-19inline use-once typedefsNoel Grandin
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19lok: sc: missing header invalidation on undo an autofilter actionMarco Cecchetti
Change-Id: Ibfa7602221ed0c115ad469bd8a61e62baaff0bdf Reviewed-on: https://gerrit.libreoffice.org/46715 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-12-19loplugin:unusedfieldsNoel Grandin
Change-Id: I84a7bcb891548416f0e1f1b20059f9b20c890d4c Reviewed-on: https://gerrit.libreoffice.org/46686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19Correct the assertionMike Kaganski
The anchor node passed to SwDoc::MakeFlySection may be non-content node, e.g. a table node when a whole table is selected when inserting a frame. Thus assertion must take into account if the bCalledFromShell flag is true. Change-Id: I947ed9dfc4846a8c4fe430d80fb8286212e0b248 Reviewed-on: https://gerrit.libreoffice.org/46736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-19remove empty line from emoji.ulf added by mistakeLászló Németh
in commit 87ada8fe44c6caf21f1fd9a0f78aa2c26f1607f2 Change-Id: I33e17bc1625860370cf2d45832f77aff97100e94
2017-12-19ofz: recognize invalid and negative fractionsCaolán McNamara
Change-Id: Ie00a608a60a35bf333d63be54f21085ecf44347b Reviewed-on: https://gerrit.libreoffice.org/46725 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-19ofz: Null-derefCaolán McNamara
Change-Id: I9992191fe5b4cfd771cc36a61d0ebaa8a9e6e9db Reviewed-on: https://gerrit.libreoffice.org/46743 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-19remove a CONTAINER_APPEND useCaolán McNamara
Change-Id: I266a1741581a06a995c8cb012dcb18a32a38026d Reviewed-on: https://gerrit.libreoffice.org/46699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-19coverity#1426313 Unchecked return valueCaolán McNamara
Change-Id: Ic6eb7eec01ced2105144b123f8f9f8ecd25f6008 Reviewed-on: https://gerrit.libreoffice.org/46702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-19ofz: Null-derefCaolán McNamara
Change-Id: I7f59ff4d9db9c769b3ad4ad253160f5d41093f88 Reviewed-on: https://gerrit.libreoffice.org/46734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-19Add emojis of Unicode 7, 8, 9 and 10 to en-US autocorrectionLászló Németh
also fixing some old shortcodes. Testing the new emojis in an en-US document: :dove: → 🕊 :popcorn: → 🍿 :spock: → 🖖 :unicorn: → 🦄 Note: only translations are added to the autocorrection, so there won't be untranslated strings in a non-en-US autocorrection table. Change-Id: I2f519b52501dbeeff4de959e828387f2566bc54d Reviewed-on: https://gerrit.libreoffice.org/46754 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2017-12-19fix validation error in lineChart export, related tdf#57832Markus Mohrhard
Change-Id: I282a6f476830d688837a9731234aaba37a13de16 Reviewed-on: https://gerrit.libreoffice.org/46673 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-12-19tdf#113547 DOCX import: fix handling of stub numbering overridesMiklos Vajna
Regression from commit c72a1a74b5b1064fc9cdf9994b11fce26d866e26 (Related: tdf#112211 DOCX import: fix handling of missing first ind in <w:lvl>, 2017-09-19), now that a numbering level can have default properties, we need to differentiate between the case when the level has real properties or it has only default properties. Merging of properties is not necessary when the abstract numbering has properties, but the "override" has default properties only. Change-Id: Idbcbd0f66932514612e11fe82377f2b68ac9e403 Reviewed-on: https://gerrit.libreoffice.org/46751 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-19EPUB export, fixed layout: fix mm size of SVG pagesMiklos Vajna
The preferred map unit was pixel, but SVGExport::writeMtf() expects the map unit is always a logical one, given that it calls OutputDevice::LogicToLogic() for it. Change-Id: Id1f311eb14423a76a82886ca848c90ab48c6eb49 Reviewed-on: https://gerrit.libreoffice.org/46733 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-19Add emojis of Unicode 7, 8, 9 and 10László Németh
for translation of the new shortcodes, (also fixing a few older ones). Note: only translations are added to the autocorrection, so there won't be untranslated strings in a non-en-US autocorrection table. Change-Id: Iff1c6f1d693b8e877a699c79fc3cf81d60dc6318 Reviewed-on: https://gerrit.libreoffice.org/46753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2017-12-19Document that Clang 3.4.2 is known to be too oldStephan Bergmann
<https://lists.freedesktop.org/archives/libreoffice/2017-December/079107.html> "Clang baseline bump" Change-Id: I13b621be7614ce81777bf56ce52a68e36513be20 Reviewed-on: https://gerrit.libreoffice.org/46518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-19fix bug in IconChoiceDialog::disposeNoel Grandin
after commit 12bb4bc980863d4338725cf5a5dcaf3acbfddc09 convert HyperLinkPageType to scoped enum Change-Id: Icb1afcdea38f231bf9b7119eb4c1bedbf7494962 Reviewed-on: https://gerrit.libreoffice.org/46707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19svl: Fix possible memleak at deleting DdeServiceTakeshi Abe
Change-Id: Ie10d4199999c4331af29dee2a8d98132488caa6e Reviewed-on: https://gerrit.libreoffice.org/44909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>