summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-09-18cid#1486004 silence Uncaught exceptionCaolán McNamara
Change-Id: Id545530140c0f2ceeeaecfb0c03c94f296bdbb4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122297 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-18tdf#124176 - Use pragma once instead of include guardsChris Sherlock
I have a patch queued to be able to create a FontMetric from a PhysicalFontFace. Submitting this patch so I can hopefully one day land this patch. Change-Id: I69b980d76f3e104a1784e2bd630a710deb33f8f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122171 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-18vcl: add sal/config.h in preparation for patchChris Sherlock
The convention is that we need to add sal/config.h to the start of files. I have a patch queued to test PhysicalFontFamily and move it to vcl::font. Submitting patch to update the modelines in the files that I will change in that patch. Change-Id: I92275250bc5e12f7e6f7c0d4b6405d6a6e8de033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122179 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-18cid#1491946 and cid#1491949 deference before null checkNoel Grandin
after commit c7551e8a46e2f9f8142aa7921a0494221ae096e8 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Sep 16 10:36:48 2021 +0200 speedup CharacterClassificationImpl::toUpper Change-Id: If09857f89a4fa7de56831ea16d0b3ec8c50cfaf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-18vcl: create FontMetric from PhysicalFontFaceChris Sherlock
A FontMetric can be created from a PhysicalFontFace, so setup a constructor that takes a PhysicalFontFace object to instantiate the FontMetric. The OutputDevice functions GetDevFont() and GetDevFontCount() don't necessarily make much sense, so have changed GetDevFont() to GetFontMetricFromCollection() and GetDevFontCount() to GetFontFaceCollectionCount(). Change-Id: I1577679b949a49a7cf1248838786d0f5e84a5245 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121796 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-18Fix typoAndrea Gelmini
Change-Id: I7ea6c37c264a90ec6dffa62aceebae9d353f7b46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122265 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-18Fix typoAndrea Gelmini
Change-Id: I49c7165ecde8f652ed68ba8f8dbd9ccbf44b3756 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122266 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-18tdf#100086 wina11y: Return "fresh" IEnumVARIANT for get_accSelectionMichael Weghorn
Create a clone and reset the IEnumVariant returned in 'CMAccessible::get_accSelection' when multiple children are selected. It seems reasonable to assume that an 'IEnumVARIANT' retrieved by calling the 'IAccessible::get_accSelection' [1] method to get access to the selected children will start enumerating selected children at the beginning, not where enumeration left off with any previously retrieved 'IEnumVARIANT'. I came across this because a pending NVDA pull request to implement the announcement of multiple selected Calc cells mentions that "accSelection is broken in LibreOffice" [2]. NVDA uses 'IAccessible::get_accSelection' and then 'IEnumVARIANT::Next' to get the amount of currently selected cells. However, with the same underlying 'CMAccessible' object being used in subsequent attempts to retrieve the count of selected children and its 'm_lCurrent' member not being reset in between, this effectively meant that children considered when retrieving the selection the previous time were considered as "already having been taken into account" when (not) looping over the children to return in 'CEnumVariant::Next'. [1] https://docs.microsoft.com/en-us/windows/win32/api/oleacc/nf-oleacc-iaccessible-get_accselection [2] https://github.com/nvaccess/nvda/pull/12849/commits/b9f7ee1c2a8cbb9415545dc2562901881e27f11f Change-Id: I8e6b8bffaab010a0cfa7db8d43807e7520673d45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122268 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-18vcl: rename ImplDeviceFontList to PhysicalFontFaceCollection and testChris Sherlock
- renamed ImplDeviceFontList to PhysicalFontFaceCollection and moved to own header file - wrote unit test for PhysicalFontFaceCollection Note that this is part of a series of patches where I also move font files into the relevant font directories, and into the vcl::font namespace. Change-Id: I43669137bcd9a9b2a9417b2369a5cb1b93b93733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121663 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-09-18tdf#144349 Make Navigator global tree track sub-document sectionsJim Raykowski
Master document relies on the Navigator listing all the sub-documents. However there is no connection between the currently selected section (containing the sub-document) and the entry in the Navigator making it very hard to see what file needs to be edited. This patch highlights the corresponding item in the Navigator at the current cursor position in the document. Change-Id: Iee32d1db0e40e302bfff7a879d47a5632ce4ed43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122103 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-09-18vcl: add sal/config.h in preparation for patchChris Sherlock
The convention is that we need to add sal/config.h to the start of files. <chris_wot> mikekaganski do you want me to add sal/config.h to cxx files <chris_wot> as well as headers? <mikekaganski> chris_wot: rather ask sberg :) <@sberg> chris_wot, always, always as first include, by convention <chris_wot> thanks, I'll make sure I do this on any files I touch - if that's OK I have a patch queued to rename ImplDeviceFontList to PhysicalFontFaceCollection, which I am adding a test to. Submitting this patch so I can hopefully one day land this patch. Change-Id: I9d74f850745760774a9f8050023f584cf52dc070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122167 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-18tdf#124176 - Use pragma once instead of include guardsChris Sherlock
I have a patch queued to rename ImplDeviceFontList to PhysicalFontFaceCollection, which I am adding a test to. Submitting patch to update the include guards to pragma once Change-Id: I091817905599089edec1138eeee06ba3dacd6964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122225 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-17Use atomic::exchange when cleaning upMike Kaganski
Change-Id: I77b8093efba3f3dfe96f6e3a4f4bfcc8dd89ccff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122273 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-17tdf139131 - Sort page styles under Paragraph -> Text FlowAndreas Heinisch
Change-Id: I1bfe098ce9dd0c76c9a469f10e41f7d757e5e50b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122270 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-09-17create OnDemandCharClass cacheNoel Grandin
and use it in SvNumberFormatter for situations where we are rapidly switching locales (e.g. spreadsheet with alternating locales on adjacent rows) Change-Id: Ic35fdbbfbdc960673e91a37efed1d0e12c1a0751 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-17no need to allocate the cached items separately in the intl wrappersNoel Grandin
Change-Id: Ie62ab74e47af50cfa8fc5562fd0c32259282812e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122263 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-17clang-format ondemand.hxxNoel Grandin
Change-Id: I7fa1c0e5832ace0c97c93a9df808b73a3f0ffc36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122262 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-17no need to allocate CharClass separately in SvNumberFormatterNoel Grandin
Change-Id: I79b815567c59702c2d3fe7944bb2f16bacf0e472 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122252 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-17ofz#38652 Avoid timeout in html importCaolán McNamara
Change-Id: Ic2c3b71a96749d613a3a3339824b57eaae2b63ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122267 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-17no need to store a CharClass in SvXMLNumFmtExportNoel Grandin
we only use it at one site, and at that site we can use the CharClass inside the formatter whose locale we just updated. Spotted by erack. Change-Id: I049c6fc399e62cfe83f3ae396ea8d0e7497e673f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122250 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-09-17ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I65338d31b3b556b2ba96f592c2b12084dab87e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122261 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-17CppunitTest_sc_subsequent_filters_test: simplify codeXisco Fauli
Change-Id: I0019a40a34c48f59af72d73f1f83f2fc18602920 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122249 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-17ofz: Avoid timeoutCaolán McNamara
Change-Id: If2ba222d5e3cb2baa692487332d6cfc28d5be532 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-17gtk4: fill context menusCaolán McNamara
Change-Id: Ie59f569f8917dee730e79a3bea6c3e6161ae9fea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122241 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-17rather return ref from GetLocaleNoel Grandin
since we never return a nullptr. Change-Id: I459acd6a25b133da5fc8516aa5e1a982df80ae8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122242 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-17rather return ref from GetTransliterationNoel Grandin
since we never return a nullptr. Also add a new utility method to simplify the call sites that need to pick the right collator Change-Id: I0ecf3ad32a0bf22d9e760620524f41bc18b54fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122238 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-17rather return ref from GetCollatorNoel Grandin
since we never return a nullptr. Also add a new utility method to simplify the call sites that need to pick the right collator Change-Id: I5deb009cb5144fd182bbc6470ae30ea05e6979c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-17rather return ref from GetCalendarNoel Grandin
since we never return a nullptr Change-Id: I4cb4af99752818e323472a372330d1bc2a3df4f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-17rather return ref from getLocaleDataPtrNoel Grandin
since we never return a nullptr, and rename to reflect that Change-Id: I694b5198f663842d1362504d60e7191e450a08ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122224 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-17vcl: update vim modelines in preparation for new changeChris Sherlock
I have a patch queued to rename ImplDeviceFontList to PhysicalFontFaceCollection, which I am adding a test to. Submitting patch to update the modelines in the files that I will change in that patch. Change-Id: I3b0b022cbfa7b05dbfbb5c2d03f6d68128c0598f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122232 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-17Drop this unneeded indirectionMike Kaganski
Change-Id: I6b40642c7574a1863658854d206ed849517dbd0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122130 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-17Sorted the list except emojis.Marco Pinto
This will make it easier to update without inserting each word manually. Also added the two blank spaces on the start of each line. Change-Id: Ida85d28404aca759331d6089946be8dd970c79db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121414 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2021-09-17need optional headerCaolán McNamara
Change-Id: Ic6515a32c2bf2ed7d287c003df154727644598b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122239 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-17gtk4: guard vcl calls from gtkCaolán McNamara
Change-Id: Iff35ff96c5df987258979b388485af4f3d1f039e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-17tdf#143550 - use the term "gluepoints" consistentlyrocso
Change-Id: Id10dc2ef13f54a148a800003cc4bd88ca1a0056f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122233 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-09-17Update git submodulesrocso
* Update helpcontent2 from branch 'master' to ee13bc67bf0a292b19985923536924f5ab1abd0b - tdf#143550 - make gluepoints terminology consistent Change-Id: Ief999a09cfa9b862f24f708d2e41eff398af7372 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122231 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-09-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 04b0cb75e8e2fea295159d15a101ddf9f4fdb943 - Fix grammar Change-Id: I24b5891b3d11058189bfc5d80e91eb3d6a5e6f53 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122131 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-09-17Fix gtk4 build ('--enable-werror')Michael Weghorn
Fixes [CXX] vcl/unx/gtk4/transferableprovider.cxx In file included from vcl/unx/gtk4/salnativewidgets-gtk.cxx:10: vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:364:19: error: ‘gTreeViewWidget’ defined but not used [-Werror=unused-variable] 364 | static GtkWidget* gTreeViewWidget; | ^~~~~~~~~~~~~~~ vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:363:19: error: ‘gListBox’ defined but not used [-Werror=unused-variable] 363 | static GtkWidget* gListBox; | ^~~~~~~~ vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:362:19: error: ‘gComboBox’ defined but not used [-Werror=unused-variable] 362 | static GtkWidget* gComboBox; | ^~~~~~~~~ vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:355:19: error: ‘gSpinBox’ defined but not used [-Werror=unused-variable] 355 | static GtkWidget* gSpinBox; | ^~~~~~~~ cc1plus: all warnings being treated as errors make[1]: *** [solenv/gbuild/LinkTarget.mk:307: workdir/CxxObject/vcl/unx/gtk4/salnativewidgets-gtk.o] Error 1 make[1]: *** Waiting for unfinished jobs.... In file included from vcl/unx/gtk4/notifyinglayout.hxx:13, from vcl/unx/gtk4/gtkinst.cxx:14: vcl/unx/gtk4/../gtk3/gtkinst.cxx:4385:11: error: ‘static void {anonymous}::GtkInstanceWidget::LinkStubasync_drag_cancel(void*, void*)’ defined but not used [-Werror=unused-function] 4385 | IMPL_LINK(GtkInstanceWidget, async_drag_cancel, void*, arg, void) | ^~~~~~~~~~~~~~~~~ include/tools/link.hxx:45:13: note: in definition of macro ‘IMPL_LINK’ 45 | RetType Class::LinkStub##Member(void * instance, ArgType data) { \ | ^~~~~ cc1plus: all warnings being treated as errors make[1]: *** [solenv/gbuild/LinkTarget.mk:304: workdir/CxxObject/vcl/unx/gtk4/gtkinst.o] Error 1 make: *** [Makefile:288: build] Error 2 Change-Id: Id570c22aa66bf134fdc4dda31a0cf1f867f3653d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122235 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-17gtk4: get menus attached to menubuttons after load time workingCaolán McNamara
run update_action_group_from_popover_model on the newly attached menu Change-Id: If871dea4833c60efc5853de19031fc6e45544170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122198 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2021-09-17gtk4: listen to "toggled" so callbacks see get_menu_item_active of trueCaolán McNamara
Change-Id: I130ebbb6dad9c0f69667a1c95e97583183656710 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-17Fix calculation of alloca'ed memory sizeStephan Bergmann
...after 16d645e5b8f11b4ddb49a2b58bde388b28960abc "speedup Transliteration_body::transliterateImpl", which caused dynamic-stack-buffer-overflow (<https://ci.libreoffice.org/job/lo_ubsan/2137/), > ==4003==ERROR: AddressSanitizer: dynamic-stack-buffer-overflow on address 0x7fffe890f7d2 at pc 0x0000004b1c2d bp 0x7fffe890f490 sp 0x7fffe890ec40 > WRITE of size 2 at 0x7fffe890f7d2 thread T0 > #0 0x4b1c2c in __asan_memmove /home/tdf/lode/packages/llvm-llvmorg-9.0.1.src/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cc:30 > #1 0x2b8b4222ef65 in char16_t* std::__copy_move<false, true, std::random_access_iterator_tag>::__copy_m<char16_t>(char16_t const*, char16_t const*, char16_t*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_algobase.h:368:6 > #2 0x2b8b4222eec0 in char16_t* std::__copy_move_a<false, char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_algobase.h:385:14 > #3 0x2b8b4222d9be in char16_t* std::__copy_move_a2<false, char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_algobase.h:422:18 > #4 0x2b8b4222d2be in char16_t* std::copy<char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_algobase.h:454:15 > #5 0x2b8b4222cf43 in char16_t* std::__copy_n<char16_t const*, signed char, char16_t*>(char16_t const*, signed char, char16_t*, std::random_access_iterator_tag) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_algo.h:782:14 > #6 0x2b8b4222b495 in char16_t* std::copy_n<char16_t const*, signed char, char16_t*>(char16_t const*, signed char, char16_t*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_algo.h:806:14 > #7 0x2b8b42225872 in i18npool::Transliteration_body::transliterateImpl(rtl::OUString const&, int, int, com::sun::star::uno::Sequence<int>*) /i18npool/source/transliteration/transliteration_body.cxx:145:13 > #8 0x2b8b42236f35 in i18npool::transliteration_commonclass::transliterateString2String(rtl::OUString const&, int, int) /i18npool/source/transliteration/transliteration_commonclass.cxx:109:12 > #9 0x2b8b41fbc740 in i18npool::cclass_Unicode::toUpper(rtl::OUString const&, int, int, com::sun::star::lang::Locale const&) /i18npool/source/characterclassification/cclass_unicode.cxx:67:19 > #10 0x2b8b41fbc7b2 in non-virtual thunk to i18npool::cclass_Unicode::toUpper(rtl::OUString const&, int, int, com::sun::star::lang::Locale const&) /i18npool/source/characterclassification/cclass_unicode.cxx > #11 0x2b8b41ff1335 in i18npool::CharacterClassificationImpl::toUpper(rtl::OUString const&, int, int, com::sun::star::lang::Locale const&) /i18npool/source/characterclassification/characterclassificationImpl.cxx:47:63 [...] Change-Id: I5273e234c8921f635e31c414cb0e427ee8b04a95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122234 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2021-09-17Some more uses of rtl_math_(u)StringToDoubleStephan Bergmann
...to avoid construction of temporary O(U)Strings, in anticipation of using C++17 std::from_chars once that is available in all our baselines, similar to 99a1290b3f2c8584db0a33fe48adf93dccce3a92 "Use existing rtl_math_stringToDouble" Change-Id: Ib92504341c3ae9dd599f91725b0af5b7219a201d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122219 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-17tdf#140226: Make use of SfxPoolItems more typesafe by using StaticWhichCastBaran Aytas
Change-Id: Ideaf9ec500af7c3aecbb7086a123a3764cac54d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121956 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-09-17speedup toUpperCase when called in parallelNoel Grandin
by removing locking from CharClass, which means we need to make it an immutable class Since SharedStringPool in sc/ stores a pointer to the CharClass in use, we have to tweak SvtSysLocale so that the object does not change location. Change-Id: I2c62d354fa542ebc04e755ce5b9b9e2ddff76a64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122185 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-17use optional for some fields in ScGlobalNoel Grandin
Change-Id: I715b771a9c09b7bcc536ce114080e27d75c2e91c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122230 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-17Use OUString::unacquiredStephan Bergmann
Change-Id: I9264291ba55accbb07401e29499b99e9765b3f63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122220 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-17Some test-code simplifications, using starts/endsWith rest parameterStephan Bergmann
Change-Id: I3376ddc30e8ddc0e2dfc052ab47fe086108e015a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122221 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-17ensure that some basic geometry classes are trivially copyableLuboš Luňák
They in practice are, since they are just integers, but SwRect had explicit implementations of some functions that technically prevented SwRect from being considered trivially copyable, even though they were identical to default implementations. Change-Id: Ib5086dcd5279f3b4c0c530535c91524671cc6656 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122213 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-17rather return ref from getCharClassPtrNoel Grandin
since we never return a nullptr, and rename to reflect that Change-Id: I5b8f0aba6ce387bb0fe1ce6088ba2685d2ade7f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122209 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-17remove GetCharClassPtr from SvtSysLocaleNoel Grandin
we already have GetCharClass and we never return a nullptr Change-Id: I3cb79bc60be614c0474ecfdaad17991f2ecb6368 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122208 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-31 19:18:35 +0000