summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-03-19MCGR: Model data changes for ColorStepsArmin Le Grand (allotropia)
Added tooling replaceStart/EndColor to allow simple transition for code that does not immediately adapt to multi color gradients. Also added createColorStepsFromStartEndColor for the same purpose. Adapted XGradient to no longer have Start/EndColor at all, but only use ColorSteps. Adapted all usages of XGradient to no longer use Get/Set/Start/EndColor, but access the ColorSteps instead. Replaced quite some XGradient constructors that used XGradient() as Start/EndColor since this is already the default. Adapted ColorBlending to black AKA Start/EndIntens in XGradient to work now on all ColorSteps in the required linearly-scaled manner. UNO API changes: Added com::sun::star::awt::ColorStep as basic data element that holds a pair of Offset and Color. Added com::sun::star::awt::ColorStepSequence to handle an array of sorted entries. Added com::sun::star::awt::Gradient2 derived from com::sun::star::awt::Gradient, extended by the needed com::sun::star::awt::ColorStepSequence. Added MID_GRADIENT_COLORSTEPSEQUENCE to UNO API to provide access to ColorSteps directly. Adapted XFillGradientItem::QueryValue/PutValue to make use of new UNO API data structures. To do so, added tooling methods for data transition: - fillColorStepSequenceFromColorSteps - fillGradient2FromXGradient - fillColorStepsFromAny - fillXGradientFromAny and adapted - case '0' (all data) - MID_FILLGRADIENT - MID_GRADIENT_COLORSTEPSEQUENCE - MID_GRADIENT_START/ENDCOLOR to make use of these. Tested usage of these in the office. Renamed from GradientStep to GradientStop after discussions with members on the list to make this closer related to other norms/definitions. Also renamed classes and class members to better reflect to GradientStop, so grepping/finding will be easier (e.g. 'Color' just exists pretty often, but 'StopColor' is more precise). Changed the used UNO API class for reprsenting the Color to better reflect to ranges [0.0 .. 1.0] and usage of RGB. Change-Id: I1eeb3e97e81d6785967615d1ff256551fc3b882d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148849 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-03-19move getDataSeries inside chart2::DiagramNoel Grandin
Change-Id: Ie60d288dba9c8d006de03c80d3cfc7bf8f108782 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-19tdf#114441 - Convert use of sal_uLong to better integer types.Vinit Agarwal
In reportdesign/source/ui/dlg/Navigator.cxx Updated type of nPos at Line number 574 to int as it would be either 1 or 2 depending on the ternary evaluation Change-Id: If2bf75ddfb66b518fec109757f32dd6e4a8b77dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148600 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-03-18probably a good idea not to have two things called comphelper::UnoImplBaseCaolán McNamara
Change-Id: Ib2b4456c55bcb65fba1ec67739ba08b22a4fcae0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-18cid#1523394 Dereference after null checkCaolán McNamara
Change-Id: I1feeace608c11b653fce17020afe592de4317de9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149074 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-18move getDataSeriesGroups inside chart2::DiagramNoel Grandin
Change-Id: I776e07ad6dce63df9891ab6823811ad20a37e77c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149084 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-18Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 5ba7b847709a22714cb276d0bc9d12b7ea204d50 - remove extra space Change-Id: Ief6c4fa6381c15ebca3843d22f083f567ba663e9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149096 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2023-03-18tdf#130924 replace debugging fprintf calls with SAL_INFO/SAL_WARNektagoel12
Change-Id: I1893e130af2584c1d57c3e37ee3f3ff18c07c077 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148792 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-03-18move isCategory inside chart2::DiagramNoel Grandin
Change-Id: I568a573004c20d7bbf60a947b34a6a8223217b19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149083 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-18move getCategories/setCategories inside chart2::DiagramNoel Grandin
Change-Id: I7c6b4e92bb131cc3c6b5b4eedb3304128b8bd988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149082 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-18tdf#154242 Explanatory images of UI Chooser (.uno:ToolbarModeUI)Rizal Muttaqin
Change-Id: I4068522a866843ed19bdd0c44d5e018e7a51cf2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149077 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-03-18move isSupportingDateAxis inside chart2::DiagramNoel Grandin
Change-Id: I6c0d6d68c08cc66bff6666c6ff8189d2e7e24c39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149079 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-18cid#1523393 Uninitialized scalar fieldCaolán McNamara
Change-Id: If95378442e3be04abae3c9f6090d5b6904feee47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149073 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-18bridges: add whitespace to SAL_INFOIlmari Lauhakangas
Missed in 7a8ec6cddc9f37ba6ff1a98ad39702521c8fb36b Change-Id: I70b73873f20814d25c34f326a6552e72f57b3e28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149081 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-03-18Fix typoAndrea Gelmini
Change-Id: Ibaed9abff12438789841e3560416198d52d7647f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149075 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-18loplugin:stringadd use more O[U]StringCharNoel Grandin
Change-Id: I196e4539ad430a39415eff9d7170b33df7228230 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-18tdf#154235: Ignore underline metrics for all Liberation fontsKhaled Hosny
They all have bad metrics and we are better off synthesising metrics for them instead. Also simplify the exception list to only use family name. Change-Id: I9e13bc05bdf56a31e9805fcd348439d191ed3a3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149072 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2023-03-18Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 1950b38e185b4ced962e2bacde9ac4086b31257c - tdf#152605 revise "heading level"; update command names update command names for Edit Index, N# "heading level" -> "index level" refactor <h1>,<menuitem>,<relatedtopics>,remove <xml-lang> Change-Id: I3b4a00366bbfa7108716136ac5004c50aa9813e4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149022 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-03-17tdf#154214 redesign of Caption Options dialogSeth Chaiklin
Change-Id: I7cb9c8a01b8ae2482b7dbce976288df1b878b87c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148964 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-17tdf#154235: Fix underline position in PDF exportKhaled Hosny
Change-Id: I9a15646cc6a69ca7226f06ecc56a28fba3fa96db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149071 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2023-03-17Related: tdf#153842 {dsb-DE} remove confusing commentEike Rathke
The format is needed, even if not used / offered as default. Change-Id: Ifd4e5114a1d763a9a7ef69046949dfb7cf96ef84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149055 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-03-17tdf#153683: Refactor fixBaole Fang
Change-Id: I3358c99425edae92bde120eda4fd905552444eba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149034 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-17sw floattable: fix redline import from DOCXMiklos Vajna
The problem was that sw/qa/extras/ooxmlexport/data/tdf149388.docx contained redlines but those were not imported for split flys. This happened because split flys get imported directly in DomainMapperTableHandler::endTable(), and the redling handling for floating tables was only implemented in SectionPropertyMap::CloseSectionGroup() (where delayed floating tables are imported). Fix this by extracting the redline import code for floating tables into 2 functions and then calling those also from DomainMapperTableHandler::endTable(). Note that the !isExported() branch of the testcase looks like dead code, since we always run this code after an export. Change-Id: I860ee0168807077eb5ed33d79888f4cc1de9a717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149057 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-17tdf#148008: do not proceed after the marked rangeMike Kaganski
Implementation error in commit c008dc483f8c6840803983e7e351cec6fdd32070 ("Switch to using multi_type_vector for cell storage.", 2013-06-24). Change-Id: I1e946b3b816db3d24f79a10fe8aa0dfc673b2e4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149026 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-17sw: fix assert on tdf140219-2.odtMichael Stahl
itrpaint.cxx:421: void SwTextPainter::DrawTextLine: Assertion `!roTaggedParagraph' failed. The unexpected situation is that the SwTextFrame contains no numbering portions but only fly portions, and the follow SwTextFrame contains the numbering portion. Delay producing the numbering and paragraph structured elements until the numbering portions - it's the only way to create the list structure correctly. Unfortunately this means that the fly anchored on the paragraph won't be nested inside the paragraph structured element any more, because it's created later, but that seems rather difficult to do and the paint order in sw already prevents this from working for hell layer flys. (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd) Change-Id: I9b40b85edd6f4b9920beac5602a5d3a6d4de5dd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149058 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-17Move the variable into the scope where it's usedMike Kaganski
Change-Id: Ib49ba81686199eea045d9f4eca6c8978646694f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149027 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-17loplugin:rangedforcopy: Assume non-reference structured binding is intentionalStephan Bergmann
See pending <https://gerrit.libreoffice.org/c/core/+/149026> "tdf#148008: do not proceed after the marked range" for a use case. Change-Id: Ief7cbb215068b6f5428c16a72896ef5612204128 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149056 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-17move getChartTypeByIndex inside chart2::DiagramNoel Grandin
Change-Id: Idff60dbd7c1cdb8c60e7ac07ad3abe3c6b07e321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149050 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-17Related tdf#97551 - Fixes XHierarchicalNameAccess warningHeiko Tietze
Change-Id: I965568bfa57449d1227e7ed0967bc05a29edf85f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148998 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-03-17jsdialog: enabled paste special dialogPranam Lashkari
Change-Id: I20833a2d138208ad139d0a4c673f87a0f7eb8f5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148920 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 8665bd300f60a3934d9991a877097112edda325f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149015 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2023-03-17Related: tdf#153842 {hsb-DE} does not use AM/PMEike Rathke
Switch defaults and remove from 47 date+time edit format code. Change-Id: I4832c26490adcc369a2d88e524fded724d01e996 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149054 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-03-17Towards literal O[U]String types in C++20Stephan Bergmann
...(where destructors can be constexpr), making 21584b304b21bfe6b99b6f29018c6b754ea28fc0 "make OUString(OUStringLiteral) constructor constexpr" and 983c1146ac80c038feae653e8e3752a72171d6cb "actually make OString(OStringLiteral) constructor constexpr" actually useful and eventually removing the need for O[U]StringConstExpr again Change-Id: I55520c1d928758f61e92336206e0f14b6f12a711 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148978 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-17sc drawstyles: Move style commands to ScTabViewShellMaxim Monastirsky
For them to be available also when shapes are selected. This commit alone shouldn't cause any change in behavior. Change-Id: Ic038618fe8b450ef2c93a19efb2e27c41f6de0f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149047 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-03-17tdf#145538 Use range based for loopsanfanite396
Change-Id: I546bbcd6de02f9a31db6dcb34b4493bd165c0661 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148527 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-17tdf#151741 - BASIC Organizer: fill various URLs for librariesAndreas Heinisch
Otherwise, libraries cannot be renamed in the BASIC organizer. Change-Id: I6c78cdee12f8d6128acf68e889fca463ed782477 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148483 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-17tdf#132293 remove some unused imports from uitestsUday Sharma
Change-Id: I7a116345e479dd5344396e845ef840bc6b5a6c1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149003 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-03-17sw: fix crash on exporting forum-en-3524.odt to PDFMichael Stahl
It turns out that the m_bFootnoteNum flag is no guarantee that there is a SwFootnoteNumPortion, because if it has no width, it will be deleted in SwLineLayout::CalcLine(); the flag indicates that this is the frame which would contain the SwFootnoteNumPortion, which appears to be checked in SwTextFrame::Prepare(). (regression from commit 92f7d3bfedc71bb0a91cf77b0263633c9d0f8d14) Change-Id: I2f3ff70e6c2bb3379068b285cdd5fd52bc7cecf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149053 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-17sw floattable: unconditionally map <w:tblpPr> to SwFormatFlySplitMiklos Vajna
CppunitTest_sw_ooxmlexport8's testN816593 failed in the SW_FORCE_FLY_SPLIT=1 case because the re-import of the document merged two tables into one. The problem starts earlier, we didn't import the table with a <w:tblpPr> as a floating table, but we should. Fix the problem by never going via m_aPendingFloatingTables in the SW_FORCE_FLY_SPLIT=1 case, since that was only a workaround for layout limitations. This conditionally reverts commit 78d1f1c2835b9fae0f91ed771fc1d594c7817502 (fdo#68607 bnc#816593 DomainMapperTableHandler: don't always start a frame, 2013-09-03). Also add a SwModelTestBase::FlySplitGuard, so it's just a one-liner change to test the SW_FORCE_FLY_SPLIT=1 case from cppunit. The goal is to have this on by default once it's mature enough. Change-Id: I9d94a49f7a0c27dd43e8fd388867c65d6d25f2e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149044 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-17move getChartTypes inside chart2::DiagramNoel Grandin
Change-Id: I43fd96feb1e3d34a5f3327b2e6398ca4b5e9f928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-17store last five most recently used currencies in the currency toolbar drop-downDrGigioSan
Refactory Cause Currency must be added in the MRU list in SvxCurrencyToolBoxControl::execute method. Unfortunately in this point the only information available is the number format. It is not possibile to infer currency from number format (e.g: both USD and AUD use symbol $). Encapsulating currency data In order to solve the problem currency data is enacpsulated in a SvxCurrencyData struct. Added a vector of SvxCurrencyData to SvxCurrencyToolBoxControl. Static and non static call Former static SvxCurrencyToolBoxControl::GetCurrencySymbols has been preserved, as it is called by SvxNumberFormatShell. A new GetCurrencySymbols is used by the control. To avoid code duplication, both functions call a static private function inner_GetCurrencySymbols. MRU Currencies MRU currencies are stored in another member vector m_mru_curencies: During currencies vector population (inner_GetCurrencySymbols) a space is reserved on top of vector for mru currencies. A new method addMruCurrency updates m_currencies. This method is called in SvxCurrencyToolBoxControl::execute Change-Id: I6f86179efd1839e31b089e0086b6ddbdda358f31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148896 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-17use more concrete types in Diagram::moveSeriesNoel Grandin
Change-Id: Ic5bb7f36137afe112d1a542bd642355d996cf68c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149048 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-17Add a to_string() function to the code generated for UNO IDL constant groupsTor Lillqvist
If the inpt matches one of the constants exactly, the result is the name of that constant. If the input matches some combination of constant values that are single bits, the result is the sequence of the names of those constants joined with plus signs. For instance, if the IDL has: constants Constants { const byte BIT0 = 1; const byte BIT1 = 2; const byte BIT2 = 4; const byte BIT3 = 8; } The result of Constants::to_string(5) is "BIT0+BIT2", and the result of Constants::to_string(17) is "17". I am sure there are corner cases that aren't handled as would be intuitive, especially with types that include unsigned values. Correspondingly, the semantics of the generated to_string() functions is not formally defined. Also add a unit test for the new functionality. Change-Id: I14aa826d0989ac6dfe97dd5c09119b1601c65643 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148995 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-03-17related tdf#102261: consider ParaTabStopDefaultDistance in SvxRulerSarper Akdemir
If there's a paragraph scoped tab default distance defined, use that as the default tab distance in the SvxRuler instead of the document wide setting. Change-Id: I9b0e7d0db0b25aee08bd27948b2e462b4a4ee496 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148060 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>
2023-03-17move isSeriesMoveable inside chart2::DiagramNoel Grandin
Change-Id: I119552a4f1300eafc8b060f567777a74dc11772f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149038 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-17jsdialog: enable style dialog (writer)Pranam Lashkari
Change-Id: Iaf664deeac5c5887f20c9579881cd921868b652f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148794 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit ae69dc05d3de876dade4fa8a9b6f6f693cc7c865) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148973 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2023-03-17Avoid loplugin:unusedmember crash for templated offsetofStephan Bergmann
Change-Id: I6cbac308d2911a502381067398d72136ca2b5ae3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149045 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-17elide some temporary OUStringsNoel Grandin
where we are calling append(OUString::createFromAscii( and we can rather call appendAscii Change-Id: I2366b518fe6d8d2484b00bb831cb79fb49bc0293 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149043 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-17Colibre: tdf#126689 Jump Up & Jump Down This Level iconsRizal Muttaqin
Change-Id: Iebfbeecf43e139f39a70ca58bd3b30076856c4d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149042 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-03-17sw floattable, legacy: also consier fly position when deciding the bottomMiklos Vajna
The bugdoc has 2 rows: the 2nd row was split and the master row went to page 1 and the follow row went to page 2. Word positioned the entire row to page 2. The problem seems to be that the layout code wants a "deadline" (so it can grow the frame to that bottom position), but the deadline depends on the height: split flys need to fit the body frame, then they can have a vertical offset (resulting in an overlap between the bottom margin area & the fly frame), in case the fly frame is still inside the page area. This means that this deadline depends on the body height, the fly top and the fly height at the same time. (Or in other words: the overlap is only allowed if the fly would fit the body frame, but an additional vertical offset pushes it to the bottom margin area, with an unchanged height.) Solve this fly height <-> deadline circular dependency by first checking against the page size, using the current fly height; and then against the body height, using the assumed / future fly height (assuming that the fly will grow so its new height will match the deadline). This results in a construct where usually you can't grow outside the body area, but in some limited cases you can (till you only use the bottom margin area), but only in case you grow your top position as well, which is Word-compatible, but quite unusual at other places in Writer. With this, the original tdf#61594 bugdoc gets rendered correctly, once you opt in with SW_FORCE_FLY_SPLIT=1. Change-Id: I016df1bad79f4b09abc7e2b4fe9ea613355e3794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149039 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-17move isSupportingFloorAndWall inside chart2::DiagramNoel Grandin
Change-Id: Ibc05961b60cabcd3d7421116245713c217b40999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149037 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-23 15:20:50 +0000