summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-12-30atrflyin.cxx Modify no moreBjoern Michaelsen
the fragile tests depending on specific order of objects any a bit unfortunate ... Change-Id: Ib74ec2a69c95e6ca859d7c75796081ac889ac32d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107647 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-12-30elementary: tdf#139020 update color for icons with arrowRizal Muttaqin
Change-Id: I5b4200cc13e1a9ae504d137b4e262dd34e7bb5cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108494 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-30vcl: remove unneeded checkTomaž Vajngerl
Change-Id: I3da0449afe3d21581934278f9a6fe03c4e652214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108436 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-30Same SvStream reading fix as in commit [1] but for TypeSerializerTomaž Vajngerl
[1] 8c9a4ff511a3b1d84a7a6d08a1b153c07f164abb Explanation from the commit: "to avoid chasing weird problems where we read past the end of file, which leads to random data in the variable we read into. I expect a couple of possible regressions from this change (1) memory leaks caused by non-exception-safe memory handling. Of which there should not be much because we're pretty good about using smart pointer classes these days. (2) Broken files which used to load, will no longer do so. These will have to be debugged by putting a breakpoint on the SvStreamEOFException constructor, and examining the backtrace to see where we should be catching and ignoring the exception to make the code continue to handle such broken files." Change-Id: I6f9ba7599c208b4340e86014e326e9a0693cd528 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108257 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-30vcl: remove {Read,Write}ImpGraphic and ImplExportNative from GraphicTomaž Vajngerl
ReadImpGraphic and WriteImpGraphic have been reimplemented in the TypeSerializer some time ago, but the code has not yet been moved to use that class. This commits does that and changes all the code using those 2 methods and removes them. With this implemented in the TypeSerializer, it is easier to handle In addition it also removes ImplExportNative (and the method on the Graphic interface). This was really used only in one method, and it could be implemented in the mthod itself. Change-Id: I0982429d1c1d5ed7ef07627d87ed9a08df43f040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108256 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-30vcl: Fix isEmpty method in BinaryDataContainerTomaž Vajngerl
Change-Id: I638473841be92d46f4a6ab2bac1b6f63ef7982ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108450 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-30Clang-format saxwriterdante
Change-Id: I4793d81e2ba3405b9ed07a2c5547572ed7e0bee6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108425 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-30AppendRowSetValueString is used on a ValueListStephan Bergmann
(aka a vector<ORowSetValue>, so make it work on ORowSetValue. (This will avoid a bogus warning when extending loplugin:stringviewparam to operator +=.) Change-Id: I2c4bbb2f6b4c920f26038053f9c5d4607e8c3378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108454 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-30Drop some dubious .gitignore entriesStephan Bergmann
...that had been added with ea9915a550707dace8aaf8a5aab6c1c88918e8d5 "hush more kinds of file types" for unclear reason Change-Id: I3fef3df57480c0d2de384d0a60986d83b6a3e3c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108453 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-29Expand macro COMPAT_BODY in vclJulien Nabet
Change-Id: I598ba7a6f8c51958d8130448529d21073004aad6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108448 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-29external/firebird: Fix MSVC /Zc:strictStringsStephan Bergmann
> C:/lo/core/workdir/UnpackedTarball/firebird/src/auth/trusted/AuthSspi.cpp(112): error C2664: 'SECURITY_STATUS (SEC_CHAR *,SEC_CHAR *,unsigned long,void *,void *,SEC_GET_KEY_FN,void *,PCredHandle,PTimeStamp)': cannot convert argument 2 from 'const char [5]' to 'SEC_CHAR *' > C:/lo/core/workdir/UnpackedTarball/firebird/src/auth/trusted/AuthSspi.cpp(112): note: Conversion from string literal loses const qualifier (see /Zc:strictStrings) Not sure why this only started to hit my build now. Change-Id: Idea0a8a2abaafe17183323a31f29173bd71fbeec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-29Missing last para style when inserting text from odt file tdf#138879Georgy Litvinov
Change-Id: Ief235e98f3de02350b6403a1ea8ecf6361571789 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108285 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-29use new toRadians function in more placesNoel Grandin
Change-Id: Id9da8dadab277b62053071a59813d7a4bd38f345 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108432 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-29use SdrAngleItem for SID_ATTR_TRANSFORM_DELTA_ANGLENoel Grandin
as a precursor to introducing a strong_int type for hundredths of a degree Change-Id: I766f1c2f8c6d31ec1ea2f064293d70b30da0bc56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108431 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-29tdf#120749 XLSX: fix "begins/ends with" conditionalTibor Nagy
formatting when using "Given text" type and cell reference. Follow-up of commit 583e2bfba2d72ac8afe7261c23f380daf5486889 (tdf#139021 XLSX export: fix "contains" conditional formatting). Co-authored-by: Attila Szűcs (NISZ) Change-Id: Idf5d46469765454a11311bd6ec1d85c85b89e26f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108058 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-29loplugin:stringviewparam: operator +Stephan Bergmann
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-29tdf#138907 sw TitlePageDlg: fix round-trippingJustin Luth
This Format -> Title Pages dialog is completely broken, so I threw in lots of FIXME notes. At least for the case of just using the existing pages and setting them up as title/follow page, fix: 1.) the ability to round-trip page number restart if a numbering restart without a page style already existed. (Yes, this likely is an odd case of someone messing around. In any case, a page number restart REQUIRES a page style) make UITest_writer_tests5 UITEST_TEST_NAME=\ titlePageWizard.tdf138907.test_tdf138907 Change-Id: I544145e9f749f471b54fa6686242e93bc98f50be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108322 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-12-29Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to e5aeb1d6368a566f2c10920af77ede9042ac3e8a - tdf#139286 and tdf#137347 update slide sorting shortcut keys in Impress Mapping for Ctrl+Shift+End, Ctrl+Shift+Home, Ctrl+Shift+Arrow Up Ctrl+Shift+Arrow Down were changed in 5.1. This patch gives the correct commands for these keys and moves them to the Slide Sorter, where they apply. Also added "Slide Pane" to the Header, because the shortcut keys apply in both cases. Also some XML cleanup. Appears from LO 7.2. Change-Id: I4429c8eea580b29b901a5c579cda1e0b218dbf88 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108341 Tested-by: Jenkins Reviewed-by: V, Stuart Foote <vstuart.foote@utsa.edu> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-12-29external/cairo: Fix mask usage in image-compositorStephan Bergmann
Change-Id: Id3d8e4715e295290e07146ef06898b313ead57a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108449 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-29tdf#138779 do not call EndRun() in StartRuby()Mark Hung
and EndRuby(). Ruby is implemented as EQ field in RTF. The original run text become the ruby base text in this case. Calling EndRun() in StartRuby() might cause the run completed early and text attributes that hasn't be processed mistakenly applied to next run. This patch close the in EQ field command in EndRun, in case StartRuby has already inserted EQ field command. Change-Id: I3a755f235b79d11b7897f85ae3989cc3ac73b06a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108194 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2020-12-29drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for chart2 Change-Id: I069ab39ef2d84bd6fac2c0cc5ab9931176501235 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-29ofz#28931 Indirect-leakCaolán McNamara
Change-Id: I9ed9d7680cc036c5e6e00a2603bb100628210685 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108424 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-29lok: don't use focus window to request helpSzymon Kłos
Use clicked button instead - what leads to the correct window. If only focused window was taken into account sometimes it caused incorrect help link to be used. Change-Id: I645dc1ffa6a6d6d363ea5f9874fa830c441516c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107882 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108429 Tested-by: Jenkins
2020-12-29tdf#134881 sw table dlg: make column change %-proportionalJustin Luth
Apparently, there is a discrepancy in how the various help manuals describe this. What was actually happening was that the same amount was being changed on each column instead of the same percentage. That is really bad if there are small columns, and a large one is reduced. Plus it seemed like there were implementation problems anyway, especially when growing a column too much. This patch sets it to how the guide describes it. "Adjust columns proportionally results in all columns changing their widths by the same percentage when one is changed. For example, if you reduce by half the size of a column, the sizes of all the other columns will be halved." (July 2018 LibreOffice Writer Guide 6.0 page 282) Online help since 2013 simply says. "Adjust columns proportionally: If possible, change in column width will be equal for each column." https://bugs.documentfoundation.org/show_bug.cgi?id=42023 One situation I noticed but don't think it needs dealing with is if "from left" contains a value, then perhaps the table should not be allowed to take up the full width? It could grow to spill out past the edge of the page. (Problem already existed with previous solution.) Also, merged cells might cause some unexpected results, but that becomes a user problem to fix I say. I didn't think it would matter if I grew the table a couple of Twips larger than full width. If it is, then probably just reduce maxWidth by a twip for every two columns - or truncate instead of round. (And then I also need to account for theoretical columns that are "increased" to MINLAY size too.) Note that the table will NOT grow beyond 100% text width. However, if a table is already larger than 100% (which the UI makes difficult to do) at least an attempt to grow the columns will not cause them to shrink. They will just stay the same sime. make UITest_sw_table UITEST_TEST_NAME=\ tdf134881_colProportionalAdjust.tdf134881.test_tdf134881 Change-Id: Id57d80d9658b9ac1938189c75da0cbf309fc321a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107604 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-12-29jsdialog: step for spinfieldsSzymon Kłos
Change-Id: I35336dfcd9913a984b0a8894622d0785d4007bc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107884 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108419 Tested-by: Jenkins
2020-12-29Fix crash in SwXTextDocument::getSelection() method.Tamás Zolnai
pWrtShell was nullptr. This crash was triggered by an collaborative editing use case. Change-Id: Id64298b424f5ac4d96df97581c6fe3067e799eb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108417 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-12-29use Degree10 in SwRotationGrfNoel Grandin
(*) Fix SwRotationGrf::GetPresentation to return a more accurate string (*) Add utility functions sal_Int32 toDegree100(Degree10) double toRadians(Degree10) (*) Fix SwVirtFlyDrawObj::GetRotateAngle to return the angle in the units that svx expects (deg100) which was introduced in commit c2e30949e0fb7c6a73742450f646e0d8d59d5e4f Date: Wed Apr 10 15:13:53 2019 +0200 lok: writer: svg export transformed images and consequently we can remove the kludge from that commit in SdrMarkView::SetMarkHandlesForLOKit Change-Id: I1a8c5f3a417f887f85b92ae5464578e9ee251619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108406 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-29Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 90f2b391658858e1faa15f78c989225cc867d6b2 - tdf#107229 update and move template path location information ( shared/01/01020000.xhp ) This is the help page for File > Open. Changes only in the "template" section of that page, but kept the relevant information about LO checking whether a template has been modified, and what actions are necessary or possible when a template is modified or missing. Changes are: * change <note> (about template checking) to <paragraph> because the <h3> for this section indicates that the content is about templates, so no need to use a <note>. * combine the content of the note with another paragraph in this <h3> section which repeats the same idea. * changing from <note> to <paragraph> also removes having two <notes> next to each other. * Modify <note> about which paths are checked for templates from "negative" to "positive" formulation. - Remove general information about path locations for templates, which will be added to a new guide page about Managing Templates. A link to that page can then be added to this page. * Improve structuring of material, so that it is clear that a dialog box appears with choices to make. * update to <h1>,<h2>,<h3> ( shared/optionen/01010300.xhp ) * corrections and improvements to explanation about location of paths, including link to Wiki page with detailed information about location of "user profile" (Thanks to Mike Kaganski for this suggestion.) + add <variable> to <h1> + add <variable> to the sentence with link to Wiki page, so it can be reused in other pages that need to refer to location of user profile. * change "user" to "user profile" + add entry for Dictionaries * change "Graphics" to "Images" * move "Backups" and "My Documents" to correspond to positions in the Paths dialog box. + add <caseline> for MAC, to show correct directory paths + add explanation about internal paths and their location ( shared/optionen/01010301.xhp ) (Edit Paths) + add <relatedtopics> section and link to "Paths" ( shared/00/00000406.xhp ) + (autotext only) for the get access command Change-Id: If38b967bbfdb1a1cbc5b42b797cdde47832c6227 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107553 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-12-29jsdialog: update JSON on treeview modificationSzymon Kłos
Change-Id: Ibaf186768f9be0cb2dc893082590c851abae29b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107819 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108413 Tested-by: Jenkins
2020-12-29jsdialog: export alignment typeSzymon Kłos
Change-Id: I846f51d522fb0639b22148c73563b177d091178c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107589 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108412 Tested-by: Jenkins
2020-12-29elementary: tdf#139056 update color to follow upstream brandRizal Muttaqin
- Update several Impress icons (Custom Slide Show, AutoTransition, Start From First Slide, Start From Current Slide, Slide Show Settings, Rehearse Timings) - Update color for Cut, Title Page, Footnote, Standard Filter and Quit icons - Redesign Show Formatting, Goal Seek icons Change-Id: I94e2d5eac0df1b112930f096d3c47eccba03d5da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108398 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-29vcl: move local bitmap headers to inc/bitmap directoryChris Sherlock
Change-Id: I72cc28d4df8031e322daa50d79666cabcb6421a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108040 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-28Avoid calling memcpy with nullptrStephan Bergmann
...which can easily happen when default-constructed std::[u16]string_view are involved Change-Id: I2b11b3943ccaa5344cf9d1f4546d756bc4a2d10f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108414 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-28ofz#28733 Direct-leakCaolán McNamara
free xmlEntityPtr the way desret_xmlEntityPtr does in libxml's testapi.c Change-Id: Ia809413c3d4e7b13e799e6c1a57e8abe61bf218d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108415 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-28drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for dbaccess part b Change-Id: I31e7bd41923f8167db50da4701990ba20fc582de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108383 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-28jsdialog: export dialog idSzymon Kłos
Change-Id: I406d64ec8e19661ab258908e29245bc7da245b7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107558 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108408 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-28jsdialog: enable statistics dialogsSzymon Kłos
Change-Id: Ie139192755baf925a864e26e579503b68f6ac65b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107587 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108409 Tested-by: Jenkins
2020-12-28jsdialog: dump separator lineSzymon Kłos
Change-Id: I2c9954a7f0ec3df3652733af54ea4b0f84af25e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107520 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108407 Tested-by: Jenkins
2020-12-28Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to f1e2ee29e7eab68452fd345127a3d14ba0958c77 - Resolves: tdf#130170 update help on "new styles from selection" for "new styles from selection" section * grammatical correction and clarification of instructions + add variables to three instructions that are repeated in drag-and-drop. + add icon for Styles actions menu, which is mentioned in instruction for "drag-and-drop" section + use <embedvar> for instructions that are repeated from previous section. * In 2004, this help page was checked in with a note about drag-and-drop with frames. But there is no reason or need for a separate note. Simplified and improved the instructions for frames, and integrated them with the other styles. + added instructions about list styles - remove instruction about drag-and-drop for page styles, because it is not possible to drag-and-drop page styles. + Add mention about dialog box for naming the new style. + add mention that for table and page styles, the Styles action menu must be used. * rearrange order of <relatedtopics>, improve label on link to help on Styles sidebar, add link to "Styles - New Style from Selection" command, drop link to general page on "Templates and Style" to reduce clutter, and because links to that page are also found on other pages linked into <relatedtopics> * update to <h1>,<h2>,<menuitem> Change-Id: I769587b7bbf3cf667b1c35c6a17cceca04ca24f2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108002 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-12-28drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for sfx2 Change-Id: I7ecc3e4a11d036dfe5d2dd2f750b0182131f63b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-28ofz#28984 Direct-leakCaolán McNamara
Change-Id: Ic60a00a04339659604afdf2fdb15e9a7cc6ced04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108382 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-28ofz#28912 Direct-leak in PPTStyleSheet::PPTStyleSheetCaolán McNamara
Change-Id: If6ee82bab1937599ee2908f9c610c63e505189ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108267 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-28tdf#137033 improve save of cell anchored shapesRegina Henschel
Error was, that rotated or sheared shapes got wrong position or size on save and reload in some cases. These situations should be correct now: A) Hide or show row/col above or before shape. It uses snap rectangle now. Previous solution failed, if hidden row/col is after snap rectangle left/top and before logic rectangle left/top. B) Repair ScShapeTest::testTdf137576_LogicRectInDefaultMeasureline() which would not have failed. SetColHidden() does only set the information, but does not trigger recalculation itself. C) Add solution for case shape is anchored 'resize with cell' and hidden row/col is covered by the shape. D) In case custom shape is anchored 'resize with cell' and mirrored horizontal, the translation value is wrong. I have not found the reason yet. So I have added a solution here for writing the xml markup correctly. It should work with correct translation values too. In all cases the solution does not consider right-to-left sheets. RTL sheets are still ToDo's. Change-Id: Ia15a05b637d12d9798bbc8ffca52f606058deb87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108377 Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Tested-by: Regina Henschel <rb.henschel@t-online.de>
2020-12-28jsdialog: handle value change for spinfieldsSzymon Kłos
Change-Id: Ie9ef1017b959f5ef42abe6de4ac18e077d1ceb1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107446 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108397 Tested-by: Jenkins
2020-12-28jsdialog: dump buttonbox propertiesSzymon Kłos
Change-Id: I638169db902961cff58a415b009f7412cd8b274a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107449 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108395 Tested-by: Jenkins
2020-12-28jsdialog: export column merging property in gridSzymon Kłos
Change-Id: I660e7ae6b2cce41212aee37d23b37a0cb167a14c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107447 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108396 Tested-by: Jenkins
2020-12-28tdf#139021 XLSX export: fix "contains" conditional formattingTibor Nagy
when using "Given text" type with cell reference instead of fixed string. Note: fix also "notContainsText", and prepare the fix for "beginsWith", "endsWith" and "expression" type conditions. Follow-up of commit 0101975f8eac650bb87c4af81157cb33a6309e0e (tdf#122102 XLSX import: fix "contains" conditional formatting). Co-authored-by: Attila Szűcs (NISZ) Change-Id: I46d80946f2b6cfaa2a9fe2438fae20e8aa9d50f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108035 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-28tools: json: fix missing escaped charsHenry Castro
When client side tries to show the "Macro Security Warning" message dialog, it fails to parse the JSON objects Change-Id: Id73c291ddd9cf739d63d69f06094eacb7b43a2f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108287 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-28jsdialog: disable row activated on "select" actionHenry Castro
Unfortunately, when the "Macro Selector Dialog" is shown and issue the "select" action, it closes the dialog because the row activated trigger double click the macro selected. for moment comment the unexpected side effect Change-Id: Ibdfa09c444ee79376a9e2251e919f5f06dba577d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107964 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-28jsdialog: use "WindowPaint" event to updateHenry Castro
If the idle notifier is disabled instead it uses the "WindowPaint" when the model has changed to notify update status to client side. Anyway the "WindowPaint" is supposed to be asynchronous. Change-Id: I0bb99526c72510a97e3906340c1e9269478da8cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107916 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-11 20:51:11 +0000