summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-10-23Duplication of formula/token.hxx codeStephan Bergmann
...now that ScToken has dissolved into FormulaToken Change-Id: Idd28842125698fde62df7f70079f73105b918bc0
2014-10-23vcl: fixup outdev.hxx tab spacingChris Sherlock
Change-Id: I3ca1784b931dfc4f3dc42abe8f0af588fd6b8bd0
2014-10-23fdo#78214 - rename of '1.2 extended (compat mode)'Yousuf Philips
Change-Id: I2c0d14f8e015304489d2b199db620bf046758331 Reviewed-on: https://gerrit.libreoffice.org/12069 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-23kill OUTPATHNorbert Thiebaud
Change-Id: I91806c3a55905dfd1ae90a10bc890cc526ff3270 Reviewed-on: https://gerrit.libreoffice.org/11908 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-10-23Remove ScToken from the formula::FormulaToken hierarchyStephan Bergmann
...to keep UBSan from complaining about illegal downcasts from FormulaToken to ScToken (which were practically harmless, given that ScToken did not add any data members). Change-Id: I8fdc026eec363442cc4b720b71d65c972b4a4446
2014-10-23Turn ScToken::checkTextEqual into a free functionStephan Bergmann
Change-Id: I03daf7bb68ed33d9610b7ef19d3bd6c18dc8170f
2014-10-23Move virtual ScToken members up to FormulaTokenStephan Bergmann
Change-Id: I20eb3b44d540f459cd1902a7a3b6a5c867e5bc07
2014-10-23Make ScToken::GetSingleRef etc. return * instead of &Stephan Bergmann
...so that default implementations can return nullptr without further ado Change-Id: Idc8778fe868efa00b1de597a54aa07a2e6fa3bc0
2014-10-23Turn virtual ScToken::Dump into a single free function DumpTokenStephan Bergmann
Change-Id: I2c81f24a27ede9922ed8ff16cf0ea4af824e9e59
2014-10-23loplugin:saloverrideStephan Bergmann
Change-Id: I94f330d31f142bbeea2274597c855481cb311e0c
2014-10-23Turn static ScToken::ExtendRangeReference into free functionStephan Bergmann
...and rename to extendRangeReference to avoid confusion with formula::FormulaCompiler::ExtendRangeReference. Change-Id: Ifcad309c14e04a0e37c80ca44462da587387241d
2014-10-23Move FormulaToken::TextEqual overrides down into specific subclassesStephan Bergmann
Change-Id: I5f27054ef2f9fdc4d0be0afe91ad31d053976bcf
2014-10-23gcc4.7.3 complains about the assertsNoel Grandin
'error: comparison is always true due to limited range of data type' So just make the underlying type be 'signed int' Change-Id: Ibf4ff72d85d33e88b7506289c622d34773ca259a
2014-10-23sw: fix undefined casts of SwTxtInputFldMichael Stahl
... as reported by sberg via UBSan in CppunitTest_sw_mailmerge: > sw/source/core/txtnode/thints.cxx:3207:38: runtime error: downcast of address 0x000003cadcb0 which does not point to an object of type 'SwTxtAttrNesting' > 0x000003cadcb0: note: object is of type 'SwTxtInputFld' > #0 in SwpHints::TryInsertHint(SwTxtAttr*, SwTxtNode&, unsigned short) sw/source/core/txtnode/thints.cxx:3207:13 > #1 in SwTxtNode::InsertHint(SwTxtAttr*, unsigned short) sw/source/core/txtnode/thints.cxx:1583:25 > #2 in SwTxtNode::SetAttr(SfxItemSet const&, int, int, unsigned short) sw/source/core/txtnode/thints.cxx:1943:39 > #3 in SwRegHistory::InsertItems(SfxItemSet const&, int, int, unsigned short) sw/source/core/undo/rolbck.cxx:1390:28 > #4 in (anonymous namespace)::lcl_InsAttr(SwDoc*, SwPaM const&, SfxItemSet const&, unsigned short, SwUndoAttr*, bool) sw/source/core/doc/DocumentContentOperationsManager.cxx:1169:28 > #5 in sw::DocumentContentOperationsManager::InsertPoolItem(SwPaM const&, SfxPoolItem const&, unsigned short, bool) sw/source/core/doc/DocumentContentOperationsManager.cxx:3041:23 > #6 in SwXTextField::attach(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) sw/source/core/unocore/unofield.cxx:1966:13 > #7 in non-virtual thunk to SwXTextField::attach(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) sw/source/core/unocore/unofield.cxx:2061:1 The SwTxtInputFld is unusual because it's both a field and has a range; let's try to use virtual inheritance to inherit both from SwTxtFld and SwTxtAttrNesting. Sadly requires dynamic_cast everywhere. Change-Id: I69f834d2b78ef7cdaac1f554bd80711084efcd02
2014-10-22Reduce scopes and add some whitespaces.Kohei Yoshida
Conflicts: svx/source/svdraw/svdotxat.cxx Change-Id: Ie1c94a4c241352c580d2509529919806f01ed6c0
2014-10-22Describe text animation types.Kohei Yoshida
Change-Id: I4f878eff707e318fa80b7d3c19833bf724e4bcef
2014-10-22SetObjectItemSet() eventually calls NbcAdjustTextFrameWidthAndHeight().Kohei Yoshida
No need to call this (rather expensive) method twice. Change-Id: I4c0a54acd1da0b8504ae7eb96beda4a8531943c7
2014-10-22AdoptTextMinSize() calls NbcAdjustTextFrameWidthAndHeight() at the end.Kohei Yoshida
No need to call this again in the caller. Change-Id: Ib36853cf5a0720082275e0490b4443cd9e0bd007
2014-10-22Reduce scope level & Annotate the code a bit.Kohei Yoshida
Change-Id: I6ebf849243000920b1c1f7e67d2dc81fcee9e16b
2014-10-22Remove local variables that are no longer used.Kohei Yoshida
Armin removed their uses in 120e469d176026ceb59abbf74d2ad255323cbc9a. Conflicts: svx/source/svdraw/svdotxtr.cxx Change-Id: Id620466929ca3a66dd1c261e81aacd533a44cd76
2014-10-22Method descriptions.Kohei Yoshida
Change-Id: Iece61424e09fc36768889fde2c848ed2b0722701
2014-10-22Inlining make no sense for virtual functions.Kohei Yoshida
Change-Id: I6392eaceb0544b7faa9a0c726acf6619d971dbb7
2014-10-22GetSymName() not used.Kohei Yoshida
Change-Id: Ia369bf99a5e381a6f1f9c3d8a2499aa1780f04b8
2014-10-22GetNameAsString() identical to GetName(). Remove this and use GetName().Kohei Yoshida
Change-Id: I26dce2dd11792ee118e78d23d652a5feb0789830
2014-10-22( void ) -> ()Kohei Yoshida
Change-Id: I0d3d1d9ab5f7bc270c89a2a98d45ebea3cc37e02
2014-10-22Be sure to copy the cell text attributes values to and from clip.Kohei Yoshida
Otherwise we'd have to unnecessarily re-calculate the script types again which is not cheap... Change-Id: Ie589fb4a7e5ec9b5ef646dabea4e6bd0c0aca560
2014-10-22Set script type to latin for formula cells with numeric results.Kohei Yoshida
But only when the column contains only standard number format types. Change-Id: I83982d2e87f9776cf03754beaf183e35675be992
2014-10-22Exit early in case the column has no cell notes to copy to destination.Kohei Yoshida
Change-Id: Ifca77ccda7b2065b00ee29f29f377da599929843
2014-10-22Set latin script to numeric blocks of applicable columns.Kohei Yoshida
Change-Id: Ib81ef144f168fed38100127bd63f43ea5a835a13
2014-10-22Check for standard number format rather than just for 'General'.Kohei Yoshida
That's what the ods import filter does. Change-Id: Ibcd9a80a51785a448594d29a02283cca0ec53e95
2014-10-22Move this useful function to sc::NumFmtUtil.Kohei Yoshida
Change-Id: I7b42a4418408ee2c988c32e7f1adeee3dfe269c8
2014-10-22Try to determine whether or not a column has all 'General' number formatKohei Yoshida
during import. We'll then use this information to set script type to latin for all numeric cells in those columns rather than leaving the script type 'unknown'. Change-Id: I69eae1effc32c57290b0265bc6c87e58f51944b1
2014-10-22Move SetAttrEntries from ScDocument to ScDocumentImport.Kohei Yoshida
Since that method was really an optimization for xls(x) import code. Change-Id: Ie2530f5dc27411bd45d72440681689c6c7a8b10a
2014-10-22Update all script types in the marked ranges up-front.Kohei Yoshida
This is slightly faster than doing it on a as-needed basis. Change-Id: I7618f003f3c98ee894c3f1cf597681e4281cc6ab
2014-10-22Annotate FindEditCellsHandler.Kohei Yoshida
Change-Id: Ib49a7a3eccee62e5496f7f19824631866e072b6a
2014-10-22Store height array to RowHeightContext and reduce function arg counts.Kohei Yoshida
Change-Id: I09b79bc76ffc55e25c24bbfa8f000f4a46df0a1c
2014-10-22Set rotation reference directly via internal API.Kohei Yoshida
Note that the original code would first set the rotation reference value stored in the Xf, then later unconditionally overwrite it according to the border setting. The new code only ports the second part. Perhaps there was a bug in the original code.... Change-Id: I15b6839e9a58e8070a43db70e1a88b42ed99f2d8
2014-10-22Set cell style name to the document directly, bypassing the UNO API.Kohei Yoshida
Change-Id: I28decfdfd8248fb9b95416b9b269a4ffabcc6370
2014-10-22i#84172 RTF import: handle nested groups inside redlinesMiklos Vajna
The problem was that in case we had {\revised foo {bar}}, then we only started a redline before "foo", but we ended it twice: during handling of both "}". Make sure that the end of the redline is only handled by the second one. Change-Id: I41ab8b486e8615d3479fa0fadd6016476859b4b2
2014-10-22fdo#84844 Sidebar: Use SvxColorToolBoxControl for paragraph colorMaxim Monastirsky
Change-Id: I0231a52288ca9a8a2a5e5cdb13fdff772b989640
2014-10-22Related: fdo#84844 Support of Sidebar wide buttons in SvxColorToolBoxControlMaxim Monastirsky
The end goal is to convert the Sidebar to use SvxColorToolBoxControl, and get rid of the Sidebar specific color popup, so we don't need to maintain two popups. Change-Id: I42e5bcb611acae25f16dfe9623d19727fc39ea07
2014-10-22scp2: fix language codes for sr-Latn and ca-valenciaAndras Timar
Change-Id: I0fe5d3b305c5105e987fcae90f2733b373fecc73
2014-10-22Bin unused version.map fileTor Lillqvist
Change-Id: Ic0efcf61e43864d531721474540ec138033bffe6
2014-10-22WaE: overriding virtual function declaration not marked 'override'Tor Lillqvist
CppunitTest_configmgr_unit fails, though, so I did not uncomment it in Module_configmgr.mk. Presumably one would need to look in the old configmgr/qa/unit/makefile.mk to find out how to run it. Change-Id: Id368fd94076f873bfdd34f1829d6a009daa7fa84
2014-10-22WaE: Unreferenced function definitionTor Lillqvist
Change-Id: I3364da59679875c21691fa758578fd871e359956
2014-10-22Revert "PythonTest_dbaccess_python: don't modify source document"Michael Stahl
This reverts commit 29474c7a227050b16fc341bdf7df68112793a23d. Removing the lock file fails on Windows because it is opened; it ought be possible to close the document instead to clean up the lock file? Change-Id: I2c93fc893c62d6a267be9723761e5ed7577086a7
2014-10-22unusedcode: Remove Deflater::setLevelMatúš Kukan
Which makes bSetParams always false; remove that too, together with nLevel. Change-Id: I94a4ec14b2b2c498d749ef72c1b6b118bba37076
2014-10-22Match also "debug" lines (for instance from SAL_DEBUG)Tor Lillqvist
Change-Id: I2981a622205cca2dadfc6cb0007559b8270f3d5b
2014-10-22fdo#85324 Prioritize writerglobal8_template detectionMaxim Monastirsky
Change-Id: I0454b52dcfe1514f81ddfc97a4f9246d6d2571f7
2014-10-22framework, unotest: do not override UserInstallation from environmentMichael Stahl
The PythonTest_dbaccess_python may fail in incremental builds because of stale JVM path in workdir/unittest/user/config/javasettings_Linux_X86_64.xml so it's better to use the fresh UserInstallation that is already passed in from PythonTest.mk. To make that work, tolerate non-existing path in SubstitutePathVariables::SetPredefinedPathVariables() at least when running in the build environment, which is probably better than effectively running with "/" as UserInstallation anyway... This partially reverts commit 6dbb6275ebd1a4299099c3b6bc82ec4ee0e1fb86. Change-Id: I4d42d53c049056590662828360c4ce5a29af0f4b