summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-02-12use more UNLESS_MERGELIBSNoel Grandin
Change-Id: I351a9127fb26369d8f598b6d6519d7e490fa476b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-02-12Log uses of fundamental.override.iniStephan Bergmann
Change-Id: I36fa44b063a439edf5411a89f76ec342b1388351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162601 Tested-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> (cherry picked from commit 6d553405101090ef7a7ff5270e5ef32aa41bd9b3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163254 Tested-by: Jenkins
2024-02-12Introduce a fundamental.override.ini for bootstrap variablesStephan Bergmann
...that is looked for next to the application and, when present, overrides all the other ways of setting bootstrap variables. LibreOffice itself does not bring along such a fundamental.override.ini, but it can be convenient for an administrator to place one in the installation (which can then not be modified or overridden by end users). (For convenience, the naming of this ini-file starts to deviate from the old and rather pointless tradition of naming our ini-files *rc vs. *.ini on different platforms.) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162187 Tested-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> (cherry picked from commit f4d376e9a10a8c66f7f6ecfe6a1f4763c1927b52) Conflicts: sal/rtl/bootstrap.cxx Change-Id: I057cc67b1af1d806587c3a4dc0bc31c28e79d22b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163251 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-02-12create --enable-mergelibs=moreNoel Grandin
The existing --enable-mergelibs is in use by Linux distro people, who do not want any further mergeing because they want to be able to split libreoffice up into things like nogui, calc, writer, dbaccess, etc. So this work is to enable combining even more into libmerged for platforms like Windows and macOS and COOL, where we really want everything in one big lump of code. Change-Id: I4b268864955747d9859e16ebb569debbfc32fa78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162999 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-02-12tdf#125934 qt: Support module-specific window icons on WaylandMichael Weghorn
As discussed in QTBUG-77182 [1], Qt currently doesn't provide API to directly set the app_id for a single window/toplevel on Wayland, but the one set for the application is used when the window gets shown. Make use of that by temporarily setting the app's desktop file name and doing a hide/show cycle in `QtFrame::SetIcon` on Wayland. A big thanks for David Redondo for mentioning that possibility in QTBUG-77182! An alternative would be to use private Qt API and low-level wayland API to set the app_id directly, s. discussion in QTBUG-77182. [1] https://bugreports.qt.io/browse/QTBUG-77182 Change-Id: I2a93cd39756e2ebf55b91486927d73d3896245b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163249 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-02-12Fix IwyuFilter in bridgesGabor Kelemen
after commit b3fa6e6e65031f92d7f13b44f8422fe4aa07e2f9 Change-Id: I79e99d13d982f2190473904db4d63886c479b4f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163167 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-02-12tdf#159662 Add table alignment and left/right spacing to sidebar in WriterOliver Specht
Change-Id: I12d898f21ca8c7d581aaa1c587c5b6434a35f516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162769 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-02-12kf6: Add missing include path to fix buildMichael Weghorn
Many thanks to Andreas Sturmlechner for pointing this out on #libreoffice-dev on 2024-02-12: > [10:27] <asturm> michaelweghorn: I also had to apply a trivial > openmandriva patch to get it to build in the first place, > https://github.com/gentoo/gentoo/blob/master/app-office/libreoffice/files/libreoffice-24.2-kf6-buildfix.patch Change-Id: If86220e258336d84ffc30fd5da0f5d99dda59aff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163237 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-02-12Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 9e7c3f2c9147f60b6b9ba0a328951c094e133097 - DataSheet help correction Change-Id: I3570ad7818df85f2dda3bbe81ecea59c9f16527f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163182 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2024-02-12external/pdfium: Missing include (std::abs)Stephan Bergmann
Change-Id: Ia265f425cae86c671824ad355d6b91001c49adca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163236 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-02-12tdf#159666 Crash when table and line object are selected at the same timeNoel Grandin
before commit e3077168072452fb8f1c0a8afb2992877cb96d1c Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Jun 17 09:49:37 2021 +0200 loplugin:finalclasses the cast in const SdrEdgeObj* pEdge = static_cast<SdrEdgeObj*>(m_pObj); would incorrectly cast a SdrTableObj, but it happened to do nothing problematic. After the above commit, the vtable layout changed and it started crashing. Work around it by use dynamic_cast and ignoring objects that are not SdrEdgeObj. Change-Id: Ibe03d4935b8eeb182e037b1648d841e26fa23ed4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163242 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-02-12tdf#158440: sc: Add UItestXisco Fauli
Based on https://gerrit.libreoffice.org/c/core/+/163021/comments/ff5eb7d3_2426919e Change-Id: I579dce86775599dc215395b93b15bc9a2f510cb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163243 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-02-12tdf#145538 use range based for loopsKeldin Maldonado (KNM)
using range based for loops instead of index based to increase readability in codebase Change-Id: Ib8c3ec3796fce9228cee1d90beb924128b0dea3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162950 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-02-12tdf#158337 use std::erase instead of std::remove followed by erasevarshneydevansh
Change-Id: I36043cd3aa234f98bd0b7cc2868e9094976472b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163123 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Hossein <hossein@libreoffice.org>
2024-02-12Resolves tdf#158531 - Connector lines for Keep Ratio settingHeiko Tietze
Icons taken from https://thenounproject.com/icon/lock-89649/ and https://thenounproject.com/icon/unlock-89647/ (licensed PD) Change-Id: I7efd25e83726ced7dee4f876cf4bb4c8f54408df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160460 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-02-12tdf#133836 Autofilter allow adding up members to the current selectionSahil
Added a new checkbox [x] Lock, which if checked locks the current selection, and further items then can be added to that locked selection Change-Id: If8a5da308443458abfed59b303ee25feffa0aa6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159737 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-02-12make BufferedDecompositionPrimitive2D store a Primitive2DReference..Noel Grandin
.. instead of a Primitive2DContainer. The container very frequently contains only a single item, since the decomposition method often sticks only a single top-level node in there, so it turns out to be a net loss overall, memory consumption-wise. Also, if we return a single Primitive2DReference from a BufferedDecomposition, that maximises the sharing of data between the BufferedDecomposition objects at the bottom of the decomposed tree, and objects higher up. Change-Id: Iaf272e60e2997299cc35a1bd209c51b6b79e9a8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162976 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-02-12tdf#158983 writerfilter: RTF import: fix page breaks and shape anchorsMichael Stahl
Somehow, not sure why, the added import of \wrapdefault in commit 86c0f58b6f9f392865196606173d1b98a6897f32 caused the page break in fdo55504-1.rtf to get lost. The first problem is that there is a \sbknone before the first \sect - this should not have any effect before \sect because \sbk* affect the *previous* section break, but it's not an option to simply ignore it (even if it works for this bugdoc) because it may be that there is no \sectd after \sect and then it will have an effect for the later section. The problem was in handling \page: here the premature \sbknone caused a sectBreak() which ate the page break; ignore it here by checking m_bHadSect. The second problem then was that now all but the first shape were anchored on page 2. This was because RTFDocumentImpl::beforePopState() for \shape of the 1st shape called parBreak() and that set the bIsFirstParaInSection flag. This flag prevented DomainMapper::lcl_utext() in the "if (m_pImpl->isBreakDeferred(PAGE_BREAK)) if (GetSplitPgBreakAndParaMark())" branch from inserting another paragraph break that is necessary to preserve the already inserted shapes anchored to the 2nd paragraph on page 1. (This is how it works for the equivalent DOCX document, with settings.xml edited to add w:splitPgBreakAndParaMark and remove "compatibilityMode" etc. because Word 2013 doesn't set these correctly.) The consequence is that when the second SwTextNode is converted to a text frame, all the shape anchors move to the next paragraph, the one with the RES_BREAK on it. Fix this by limiting the parBreak() handling in RTFDocumentImpl::beforePopState() to when the shape is a SwGrfNode, which is the scenario in the commit 0d9132c5046e15540abc20e45d64080708626441 "fdo#47036 fix RTF import of shapes inside text frames at the start of the doc" - the testFdo47036 fails if the block is removed completely. This caused 2 test failures, but both cases look the same as in Word 2013 now: Test name: (anonymous namespace)::testTdf158826_extraCR::Load_Verify_Reload_Verify An uncaught exception of type com.sun.star.uno.RuntimeException - unsatisfied query for interface of type com.sun.star.text.XTextTable! rtfexport2.cxx:537:Assertion Test name: (anonymous namespace)::testFdo47495::Load_Verify_Reload_Verify equality assertion failed - Expected: 2 - Actual : 1 Change-Id: I43fa9431721650a6d748d1f4bda9aeaa7a9c6b45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163200 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-02-12ITEM: ItemPool Rework (I)Armin Le Grand (allotropia)
Driving forward the Item reworks I now take the ItemPool in focus: It now does not hold any items anymore and should be renamed to something like ItemInfoProvider/ItemHelper, since it's main purpose is to provide the Defaults for the Item functionality. There is that SfxItemInfo, only a struct and bundling SlotID and ItemFlags. There are also the DefaultItems, just handled as ptrs in an array. It is/was always error-prone to keep these in sync. Remember that it's also necessary for the order to not only being sorted but being increments of one with no gaps allowed in the WhichIDs to which the Items are bound. I now bundled that to a new class ItemInfo that joins WhichID, SlotID, ItemFlags and the default Item. This is a pure virtual base class, it comes in three derivations: (1) ItemInfoStatic: This is supposed to be global static and hosts the Item in a std::unique_ptr to ensure cleanup. It is designed to be constructed once during runtime and being shared globally. It allows the ItemPtr to be nullptr to mark as non-static (if initial static is not possible for some reason) but still offers the needed data. Most cases (95%+) are of that case. The contained Item is owned by that instance. The flag isStaticDefault() is set at the Item. (2) ItemInfoDynamic: This is supposed to be used for cases where the Item cannot be static: Mainly for SfxSetItem (that needs a Pool itself in the contained SfxItemSet, so lifetime is bound to that Pool), but other cases showed up in the transition. These instances live while the Pool lives and get destructed when the Pool goes down. Also uses std::unique_ptr for the Item instance for as much automated cleanup as possible, the contained Item is owned by that instance, the instance by the Pool. The flag isDynamicDefault() is set at the Item. (3) ItemInfoUser: This is used for UserDefaults that can be set for every ItemInfo entry to 'overshadow' the default from the 'outside'. It uses a regular Item and the central access methods implCreateItemEntry/ implCleanupItemEntry to manage the Item instance, thus works like a SfxPoolItemHolder. The Item instance can be globally shared and re-used even when the Pool goes down. Instances belong to the Pool and are cleaned up when the Pool goes down. This Item does not need any further flag to be set. The ItemInfos are organized using a class called ItemInfoPackage: This bundles groups of ItemInfoStatic to functional instances. There are derivations/ implementations of this e.g. for Writer ItemPool bundling all the needed defaults for Writer, similar for draw/impress, Calc and other usages. These ItemInfoPackage can be 'registered' at an ItemPool using it's method registerItemInfoPackage. This does all the needed stuff to setup that group of ItemInfos at the Pool (It even sets internal vars First/LastWhich, that info can just be derived from the buildup ItemInfo Ptrs). The ItemInfoPackage has methods 'size()' and 'getItemInfo(index) to allow looping over it and deliver the infos the Pool needs. The (forced, pure virtual) overloads of getItemInfo in the specific implementations check for the ItemPtr being nullptr and create a exclusive incarnation of ItemInfoDynamic for the Pool if needed, returning that. The Pool owns the ItemInfoDynamic incarnations and uses the ItemInfoStatic directly. On shutdown it cleans up the ItemInfoDynamic as needed. The ItemInfoUser is used by the Pool when a UserDefault is set/used: for SetUserDefaultItem, GetUserDefaultItem, ResetUserDefaultItem. It is not held in a 2nd list, but directly in the list of ItemInfo'ptrs: To keep track of this an unordered_map is used that helds the original ItemInfo associated with the WhichID. That way no two lookups (as before) are needed to get the current Pool's default for any WhichID. The derivations of ItemInfoPackage are encapsulated and just allow access to an ItemInfoPackage& with a single method as return value. All use a static local instance of a std::array<ItemInfoStatic, FIXED_SIZE> which constructs all ItemInfoStatic and the static Item instances - if already possible. Sometimes it is necessary to overload the constructor to set some static instances for Items later than the lib init. These are also just marked with nullptr as Item instance. Some need to overload getItemInfo to complete instances of ItemInfoStatic, if needed, or create and deliver instances of ItemInfoDynamic. The registerItemInfoPackage also offers a optional lambda callback: there were two cases where local data from the Pool was needed to incarnate the item - just add that to the call to registerItemInfoPackage if needed, see examples in the adapted code. For the re-use of Items this means that now in SfxItemSet/SfxPoolItemHolder *true* static Items can and will be used without RefCount directly and globally. This is also the case for dynamic Items, with the exception of differing Pools for SfxSetItems which cannot be done. Future: That design is already prepared to allow solving that Pool-chaining problem: currently there are master/sub-pools and all accesses have to traverse that structure before even doing anything. For the future the idea is more to 'compose' a Pool by registering ItemInfoPackages, e.g. for Writer pool you may start with SfxItemPool, register the writer-specific ItemInfoPackage, then the one for DrawingLayer (if needed) and the one for EditEngine. It should also be possible to get to smaller granularities of that packages. Ideas for new ones will emerge. We might also think about composing Pools which can e.g. run Writer and Chart, so allowing to use Chart *without* OLE stuff in Writer - just ideas... More changes: - Adapted all stuff, cleaned up old stuff/ definitions - Removed FreezeIdRanges, that can be done once per Pool on-demand (and cannot be forgotten to be called) - Merged XOutdevItemPool with SdrItemPool and offered a ItemInfoPackage which joins both needed sets of Items - All the cleanup hassle with Pools and defaults cleaned up - Adapted all access methods of the pool to use that new stuff. Pool chaining currently stays, but I use a central method 'getTargetPool' instead of recursive calling to get the correct Pool for the action Change-Id: I2b8d3d4c3cc80b1d0d0b3c0f4bd90d7656b4bab7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163157 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-02-12svx: prefix members of SdrHelpLineListMiklos Vajna
See tdf#94879 for motivation. Change-Id: I172aad9fe63589a6a6bbbce77173a6fe24291ae5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163235 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-02-12merge collator_data library into i18npoolNoel Grandin
they are both small libraries and this is one less library to dynamically link in at startup time Change-Id: I1b36ba1b11b9d69deea3fe0d91b512328d0a42a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163165 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-02-12tdf#159483 sc HTML paste: handle data-sheets-formula attributeMiklos Vajna
When a formula cell gets copied from google docs, the value of the <td> element only contains the formula result. This means once value cells and formula cells gets copied together, the pasted formula cell won't updated anymore when the input values change. Turns out there is a data-sheets-formula attribute on <td> that contains the formula, it seems it uses the R1C1 format. Fix the problem by extending ScHTMLLayoutParser::TableDataOn() to parse this attribute and set a formula on the target cell (rather than a value) if the formula is available. This required also extending ScEEImport a bit, since the HTML paste builds on top of the RTF one in Calc. Change-Id: I720df96ce74a5e865b7329d06f3b719551f31b96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163234 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-02-12editeng: make TextPortionList iterable with ranged forTomaž Vajngerl
Change-Id: Ifbddd99b5877c71ebbec064672b75877fe06ccd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163226 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-02-12editeng: move isEmpty impl. from ParaPortion to TextPortionListTomaž Vajngerl
Change-Id: Ib305963b1f5ffcef9122dd4353826cc9033810f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163225 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-02-12editeng: prefix members of ParaPortion & add some access methodsTomaž Vajngerl
Change-Id: I6be67530690d1d5ee1236d654dd65cc8545e95d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163224 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-02-11ofz#66222 Timeout, raise glyph cache size for fuzzingCaolán McNamara
Change-Id: I78517eaf366e855f6a10676e90662560b27a27fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163233 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-11cid#1559961 silence Free of address-of expressionCaolán McNamara
Change-Id: I853b16d84a865a915e6489f38db3737d0efe59e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163232 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-11Adapt to modified clang::PPCallbacks::InclusionDirectiveStephan Bergmann
...in LLVM 19 trunk <https://github.com/llvm/llvm-project/commit/da95d926f6fce4ed9707c77908ad96624268f134> "[clang][lex] Always pass suggested module to `InclusionDirective()` callback (#81061)" Change-Id: I85a4f60fb3e514d3372118da454402dff6ad45e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163229 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-02-11use --enable-mergelibs for the macos buildNoel Grandin
Change-Id: I4c3ce5247e42155d7c53c288ee68bacfa4db8103 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162876 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-02-11tdf#155218 sc: fix incorrect print areaTibor Nagy
In the print dialog, changes to the page orientation should not alter the print area that is defined by the page style. issue caused by commit I5e494a0714e398221bee00744d7e25c419a41df7 (tdf#155218 sc: fix different page orientation in print dialog) Change-Id: I44eb3b30df0e8a227743df334da35316f86a0679 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163231 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-02-11Fix quoting of [ ]Stephan Bergmann
Change-Id: I57c96fe9f72794abb4f49f63735c075a4647bd23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163228 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-02-11tdf#155710 handle conversion failures due to non-UTF8 stringsPatrick Luby
Windows and Linux paths can be passed as parameters to this function and those paths may not always be UTF8 encoded like macOS paths. Change-Id: I83f5ab491d3c0ddd938e512fbab3213af9ea16fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163223 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-02-11osl_get_system_random_data should return boolStephan Bergmann
Change-Id: I29535d3562fe1b8d05b8df1d6c9ab83e4ead0f74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163227 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-02-11tdf#54169: do not hide mnemonics in menu, when navigating using mouseMike Kaganski
Pressing Alt (or F10) by itself would activate/highlight the menu, and show mnemonics. But clicking such activated menu used to disable the mnemonics. This change fixes it, making sure that they keep displaying until closing the menu. Change-Id: I60f04e1474a8eb1322e5ac75f74b02d67dce9b73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163217 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-02-10perf: limit to max 1024 rows in cases where we originally allocated 1024 rowsCaolán McNamara
so everywhere before: commit a86c00414a43c5d87981ffae1018cb242c5e5e1d Date: Fri Jan 19 14:27:10 2024 +0200 cool#6893 reduce allocation in ScGridWindow::PaintTile where ScTableInfo was used with no args, pass true to indicate this is just a hint, and where it was originally passed an explicit number, pass false for "hint" When hint is true limit to max of 1024 rows, and the issue is visible in ScGridWindow::UpdateFormulaRange at https://github.com/CollaboraOnline/online/issues/6893#issuecomment-1921141048 CppunitTest_sc_uicalc contains some examples of these where hidden rows triggers the over allocs Change-Id: Iebe890c3ac967800b60150aaa71f7e845a021f60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162875 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit e4410bd37fc018c851b5ebf9cf011d59af6a2ad9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163016 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163060 Tested-by: Jenkins
2024-02-10cid#1559951 silence Use after freeCaolán McNamara
Change-Id: I3b64a77bfc8b305d73166eaa14d96301fa1aad05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163219 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-10cid#1591764 silence Double freeCaolán McNamara
Change-Id: I21af2580f35d716ed32d565f07f84b4bbfdd2507 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-10cid#1591787 silence Arguments in wrong orderCaolán McNamara
Change-Id: Iee6dba0a127a126bc47dcb5c98efa86274d79340 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163216 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-10tdf#54169: implement auto-accelerator feature on WindowsMike Kaganski
Change-Id: I219dfc0c8377628c10e5a19232d19260923bf614 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163215 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-02-10tdf#54169: revert "gtk is the only case auto-accel is true, and theMike Kaganski
... menubar is native gtk there" (commit 3fbae5dc7e7b200776bbc8a7c2a43e1e04f15a2b from 2021-08-05). This will be needed for auto-accel on Windows. Change-Id: Ie37de17e35658a0f7c748d3c9dd923dba954298c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163214 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-02-10Drop obsolete handling of wheel mouseMike Kaganski
Change-Id: I9958e69c953563285577f5cdea220371af4848d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163213 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-02-10Simplify a bitMike Kaganski
Use existing rtl_ustr_ascii_compareIgnoreAsciiCase, instead of inventing an own local comparison function. And standardize on WM_SETTINGCHANGE, which is the same as WM_WININICHANGE. Change-Id: Ifaf1f73066edf7d553174b529be5aa55179ae92e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163212 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-02-10tdf#156993 use correct count for ViewContactOfSdrPageRegina Henschel
The count is used as upper limit in a for-loop in ViewObjectContact::getPrimitive2DSequenceSubHierarchy(). That calls ViewContactOfSdrPage::GetViewContact(). With the wrong count the case 10 was not reached and thus the helplines were not drawn. Change-Id: If606bbb718b1f78a874862217d1e03b02287e848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163192 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-02-10Fix WASM TB following ace21b4b2537a3cf2301fca2ac6f78d0612e911fJulien Nabet
Change-Id: If881428bf69587ad9067378cde01caa87d56c1a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163211 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-02-10editeng: simplify and clean-up struct in for ImpEditEngTomaž Vajngerl
Change-Id: I8ca190f957e6bf15f6c0aa8b8e22a26e896a9374 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163198 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-02-10Fix typoAndrea Gelmini
Change-Id: I5c378f1df6ec8b09c09631b1a6848d68ce1cf95b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163209 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-02-10vcl: Enable sheet protection dialogHubert Figuière
Change-Id: Ib8e8209225d027472c1f2eef57839df5784acf30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163205 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 5c1c842863ee2a63ce69a75ef0820864864905f0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163174 Tested-by: Jenkins
2024-02-10tdf#159588: Query-GUI: LOWER isnt supported in Query-GUI if condition is LIKEJulien Nabet
Let's consider "SQL_TOKEN_LOWER" and "SQL_TOKEN_UPPER" as "string_function_1Argument" like "SQL_TOKEN_LCASE" and "SQL_TOKEN_UCASE" Change-Id: I288fd5f3d9e3d104345c73a060ba11d9701500a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163099 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-02-10tdf#141908: replace usage of sal_Int32 with colorsvarshneydevansh
Change-Id: I71d94239c155f41d4535c023ea3aa8f974fcf2da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163082 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-02-10qt: Set desktop file name without ".desktop" suffixMichael Weghorn
This fixes this warning when starting LO with the qt6 VCL plugin on Wayland (using a local qtbase dev build): > QGuiApplication::setDesktopFileName: the specified desktop file name ends with .desktop. > For compatibility reasons, the .desktop suffix will be removed. Please specify a desktop file name without .desktop suffix The icon is also still shown fine with qt5/kf5 (qtbase at 5.15.10+dfsg-6 from Debian testing). Change-Id: I0eca1b3767ff65653d5f6b3104550fb0d8aea293 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163204 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
generated by cgit (git 2.34.1) at 2024-12-29 10:47:15 +0000