summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-07-28crashtesting: fix ImplCalcMapResolution assertCaolán McNamara
seen on converting moz1297206-1.svg to odg Change-Id: I56c424eb76f55a52522d519a0faa6df30b017c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171142 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-28cid#1556624 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556622 COPY_INSTEAD_OF_MOVE cid#1556629 COPY_INSTEAD_OF_MOVE cid#1556632 COPY_INSTEAD_OF_MOVE cid#1556634 COPY_INSTEAD_OF_MOVE cid#1556642 COPY_INSTEAD_OF_MOVE cid#1556644 COPY_INSTEAD_OF_MOVE cid#1556663 COPY_INSTEAD_OF_MOVE cid#1556674 COPY_INSTEAD_OF_MOVE cid#1556682 COPY_INSTEAD_OF_MOVE cid#1556683 COPY_INSTEAD_OF_MOVE cid#1556685 COPY_INSTEAD_OF_MOVE cid#1556694 COPY_INSTEAD_OF_MOVE cid#1556708 COPY_INSTEAD_OF_MOVE cid#1556711 COPY_INSTEAD_OF_MOVE cid#1556712 COPY_INSTEAD_OF_MOVE cid#1556714 COPY_INSTEAD_OF_MOVE cid#1556719 COPY_INSTEAD_OF_MOVE cid#1556727 COPY_INSTEAD_OF_MOVE cid#1556744 COPY_INSTEAD_OF_MOVE cid#1556757 COPY_INSTEAD_OF_MOVE cid#1556782 COPY_INSTEAD_OF_MOVE cid#1556784 COPY_INSTEAD_OF_MOVE Change-Id: I5d5bc884cd7351a81c18b35aaf4e304256242988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171128 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-28cool#9082 - lok: cleanup WakeUpThread before forking, then re-start.Michael Meeks
It seems likely that this lingering briefly after various un-identified and tough to reproduce, longer running operations in calc - which is a big ScProgress user - caused problems with background save. Change-Id: I1d0ec56c759dff30c48c8562b6400b57be4a25b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168033 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168052 Tested-by: Jenkins
2024-07-28tdf#158510 Don't change the initial URL when using fallbackVladislav Tarakanov
The current aURL conversions in the file "unoshap4.cxx" result in the URL obtained when importing the file being replaced with a new one formed from the presentation directory and file name. As a result, the model changes and saving is requested even if no changes were made to the presentation. To fix this problem, we added saving the presentation directory URL into the context for transfer from SlideImpl to ViewMediaShape. Regression after: fe897b36aef28dfe175461c43614e22588fcfd84 Change-Id: Ifda8610d0a4874ffa17e759fd45ddbbd2f934c0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170528 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-28restore WakeUpThread::joinThreadCaolán McNamara
removed with: commit 4aa2cc878dae3b34b16ccacd9358fda5e6d6a197 loplugin:unusedmethods Change-Id: Ie6006defdfdab23aef0fa9d9b66b125862b760f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-28ofz#68339 TimeoutCaolán McNamara
ofz took the reduction in size limit to 256 bytes as a challenge so produced a hang with a 187 byte testcase Change-Id: Ia9a93e6fd846127be2f842949f4338e819432ebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171125 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-28sfx2, solenv, sw: fix issues found by Ruff linterIlmari Lauhakangas
Change-Id: Iab375e8c8aa4c4915f3c70a9ef6aede268e4619f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171138 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-28Resolves: tdf#160509 use BorderWindow client for dialog parentCaolán McNamara
the BorderWindow has no ultimate SystemWindow parent so dialogs using this as a parent end up automatically picking a parent of whatever happens to be in the foreground and not the intended associated frame Change-Id: I713e3c40b0cad934b978ba0b1b46a3c6064be24f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171104 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-28sd: fix issues found by Ruff linterIlmari Lauhakangas
Change-Id: I96dae5eca3bb493500ca1145e141371a5572e29e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171134 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-28tdf#68676 Fix textual data length sent to SQLBindColMike Kaganski
The problem was that using Access ODBC drivers, text fields couldn't be set after commit 5ed1415d1cf03a3d671ebd11582dfaa90f1168bd (tdf#68676, tdf#131238: implement and use Unicode ODBC functions on Windows). I had changed the length sent to the function from SQL_NTS into the actual string length; and that caused the problem. Restoring previous behavior. Change-Id: I9ea1f33f30505232a02d42e3182d5449fc8d8f34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171135 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-07-28Fix typoAndrea Gelmini
Change-Id: I7a135a47e5bdbbf37a08f7e876a0ed1d979d4c39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171131 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-07-28Remove duplicated includeAndrea Gelmini
Change-Id: Ic50852db74fd6e3b227875932b730e077efbe709 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171130 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-07-28tdf#162219: pass correct DecimalDigits value to SQLBindParameterMike Kaganski
... when setting DECIMAL / NUMERIC. Passing 'scale' from setObjectWithInfo to SQLBindParameter was wrong anyway: in setObjectWithInfo, the scale is needed if it converts the object 'x' to the requested format before sending to the database. In this case, it mismatched with the actual count of decimals in the string sent to ODBC: it could be "1" or "1.2"; but 'scale' is always equal to the scale of the parameter in the database (4 in the bugdoc), which resulted in the error returned by driver. Note that there is code that truncates excessive decimals - it is in OKeySet::impl_convertValue_throw, implemented for i#106772; it would be best to remove that code, and let the database do its magic: e.g., passing a string like "1.99999" to a DECIMAL(19,4) field in MS SQL Server would round it to 2, while our code truncates it to 1.9999. The ODBC driver can handle more digits itself. But that isn't in the scope here, and may need to tweak other database connectors. Change-Id: Ib50c6d78bfd0cbf5ecd59f46f300107076ec0037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171127 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-27sc: fix issues found by Ruff linterIlmari Lauhakangas
Change-Id: I6710db13549c42e9ae7231e0434a26b6357083e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171102 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-27odk, oox, pyuno: fix issues found by Ruff linterIlmari Lauhakangas
Change-Id: I79d56453877a10502768b522ca93da3990891c0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171098 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-27In embindtest, also test Any included in StructStephan Bergmann
Change-Id: Id268692c750873629c1ceaf232e1e61912164872 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171078 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-07-27tdf#162227: use strict order of evaluations accessing columnsMike Kaganski
ODBC SQLGetData requires that data must be retrieved in increasing column number order, unless the driver supports SQL_GD_ANY_ORDER extension (see https://learn.microsoft.com/en-us/sql/odbc/reference/syntax/sqlgetdata-function). We can't emplace_back(getString(4), getInt(5), ..., getString(12), getInt(17)), because MSVC would reorder calls into getInt(17) -> getString(12) -> ..., and then MS SQL Server ODBC driver will give error on access of column 12 after column 17. This partially reverts commit e8248b5e4b19df8ba469d1ca3a762960c1a053b5 "cid#1545222 COPY_INSTEAD_OF_MOVE", 2023-12-19. Change-Id: I9bf53086e526c886c4794af51a60e61d4cce89ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171097 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-07-27Change some string types to avoid unnecessary allocationsMike Kaganski
Change-Id: I45a12adb0d04ea2e048816203a6439692c2372b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171093 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-27comphelper, msicreator, odk: fix issues found by Ruff linterIlmari Lauhakangas
Change-Id: I5ef65baeb0100b9d70b5c59c1d5f6f43ab951a22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171092 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-27tdf#68676, tdf#131238: implement and use Unicode ODBC functions on WindowsMike Kaganski
It also prepares for using it on other platforms as well; the code is generic, and should work with 32-bit SQLWCHAR, too. But I can't test it, so it is not enabled on other platforms for now (see bUseWChar, which was moved to connectivity/source/inc/odbc/OTools.hxx). Change-Id: I29fe117910bbab62aba37e85dd27d65a742d28c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171081 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-27Update git submodulesIlmari Lauhakangas
* Update dictionaries from branch 'master' to 54a753654845ecd253d7af7693bbcfbc9d952716 - Fix issues found by Ruff linter Change-Id: I0517a69b52e9f5b3da2648e82e63bc35a48e3e99 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/171091 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-27cui, dbaccess, desktop, external, filter, librelogo: fix issues found byIlmari Lauhakangas
Ruff linter Change-Id: I34df4c10520406a2b9d2d8f3487f877698a324f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171090 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-27sw: use calcLayout() everywhereXisco Fauli
Change-Id: Ie03a3f13808456c831db10f2203fbfb84a50b999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171076 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-27tdf#162190 handle Command-wPatrick Luby
On macOS, Command-w should attempt to close the key window. Also, pressing Command-m would fail to close the key window due to the same cause as tdf#162010 if the resulting key event was an input method event. Change-Id: I0d90547d7a0833bcc18b36f6d888e1065e91ec57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171086 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins
2024-07-27HTML/ReqIF export: introduce RelativeOwnObjectURL filter optionMike Kaganski
When the use cases require use of absolute URLs at export (Options-> Load/Save->General, Save URLs relative to file system and Save URLs relative to internet), the fles generated from the document itself (e.g., images that aren't embedded into HTML/ReqIF itself) may still need to be referenced relatively. This introduces the export filter option, named RelativeOwnObjectURL, that overrides the general export settings specifically for these self-generated objects. Change-Id: I09aeb931db5712271a40c683370316783507775a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171083 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-27Related: tdf#159343 Handle TableRef separator in brackets for Function WizardEike Rathke
... not breaking to next argument of a function parameter. Change-Id: Ibc7a64c4ea64c415098a213f0ff3d96b8a9dd73c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171085 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2024-07-26Refactor ODBC functions code for clarityMike Kaganski
Change-Id: I5f3de97fc178b11c82655f65435c637fdff65e99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171080 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-07-26HTML/ReqIF export: make sure to close input tagsMike Kaganski
Change-Id: If550cb3765f6f3eb6fbf7425061c1cec90f5470f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171082 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-26Fix --with-package-format=emscriptenStephan Bergmann
For one, a dependency on gb_Postprocess_get_target,AllModulesButInstsetNative was missing, so copying from instdir might have kicked in too early, before the instdir files had been updated (e.g., in an incremental build). For another, in a from-scratch build, files like instdir/program/qt_soffice.html might not yet have been around, but I'm too dumb to get gbuild to do what I want here (i.e., copy files from instdir to workdir once the files are available in instdir and only if the files in instdir are newer than those in workdir). So just make this .PHONY and always copy all the files (in line with how other PKGFORMATs also always rebuild their artifacts, IIUC). Change-Id: I8b84677cdf867a2b66027ec4a4d781cd1fe623b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171077 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-07-26fix enabled-mergelibs-more buildNoel Grandin
DocumentToGraphicRenderer is needed by sw/qa/ unit tests now Change-Id: Idf1aac26afa0001a8affc846b78288a6b588a1f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171073 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-26CppunitTest_vcl_pdfexport2: simplify a bitXisco Fauli
TaggedPDF is enabled by default since 544d6d781b3c8aa108ced362d708693b5127f3d7 "tdf#39667 Enable tagged PDF by default" Only disable it when needed OTOH, using writer_pdf_Export as a FilterName works when exporting calc/impress/draw documents too Change-Id: I970406b8a87cad937c3023815e4f5caa9b4f7143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171069 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-07-26android, compilerplugins: fix issues found by Ruff linterIlmari Lauhakangas
Change-Id: Idab013bf2ff1f274a07911ec8b545cd26142139c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171050 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-26CppunitTest_sc_uicalc: Test pasting with return keyXisco Fauli
Initially this test was created to test tdf#161461 but it needs some tweaks in order to reproduce it See https://gerrit.libreoffice.org/c/core/+/169341/comment/7c8fc703_8d6797d5/ So at least add this test to test the paste with return key feature on Calc Change-Id: Ie3ae0975fa164fbf4c1d249649ab25cf0eeef0d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169341 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-07-26tdf#162087: sc_uicalc: Add unittestXisco Fauli
Change-Id: Iafac32e5bfd02665c75b109fa136ff9d700bc93c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171074 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-26ofz: ww2 "ClusterFuzz Unreproducible" resetCaolán McNamara
so reenable this and bump up min fuzz length Change-Id: Ic493e1a55899761f6bc88dc7f4b598a82dd00411 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-26tdf#139631: sw unit test: cut preceding space w/ redlineKira Tubo
Test to see if preceding space is cut when cutting a word with redline turned on. Without the fix from tdf#139631, the preceding space is not cut in certain situations. Change-Id: Ic815fd04ee50ce116a8552205c24e8422d734b1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171058 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-26sw: use SAL_RET_MAYBENULL in GetTableBox()Xisco Fauli
This could have caught tdf#162180 Change-Id: I71e86b402ae0c603d1c7ace209d55f5808b9ebe2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171054 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-26CppunitTest_vcl_pdfexport: simplify a bitXisco Fauli
TaggedPDF is enabled by default since 544d6d781b3c8aa108ced362d708693b5127f3d7 "tdf#39667 Enable tagged PDF by default" OTOH, using writer_pdf_Export as a FilterName works when exporting calc/impress/draw documents too Change-Id: I5dc0c9eedbb6716f1ef58ffd1faa16e9cc015f9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171070 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-26Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 80cfa06de7bb382c30ead55837378dcd568d2e30 - tdf#161883 Fix to IF Basic statement syntax diagram Change-Id: Idcd12d05cd424360cd29bbb7cd7ee73e766bef52 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171025 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-07-26fix in some missing SfxItemTypesNoel Grandin
Change-Id: I7dcb9768a8cd63200b8f8c50d8170e78ff5aeec2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171068 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-26Update git submodulesPierre F
* Update helpcontent2 from branch 'master' to 56220af4577d0f685ca40595f7f57254f92628c4 - adjust FACT. tdf#162044 Change-Id: I605283ca535de89fb4d7dbce9d9f7751301fc054 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170956 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-07-26tdf#162136: fix crash when formatting data series in Histogram chartJulien Nabet
Change-Id: Idc05b82363eca3066b291f05a7e05be4996d28a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171065 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-07-26Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 6d1d800bd75a27d84866b7e8931d0cb1e12dbdd3 - update translations for 24.8.0 rc2/master and force-fix errors using pocheck Change-Id: Ic1ff9c85e537794ed5410c93b09f5d8b1d8a1e9f
2024-07-26lok: join Webdav Ticker thread.Michael Meeks
Add 'startThreads' lok method for the few thread scenarios where we need to have a background thread running that cannot be started opportunistically. Also add that to the ThreadJoinable interface so we can get into UNO components' implementations to handle their worker threads easily. Implement joining and re-starting in WebDAV ucp too. Change-Id: I329ef9decb32b263197e4c03a0d54952985fdd0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167858 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170979 Tested-by: Jenkins
2024-07-26Fix build with Java 8Fridrich Štrba
Unlike later versions of Java, JDK 8 does not create the last directory segment pointed by the -d option, even if the other segments exist. So, create the "content" segment too and allow building with Java 8. Change-Id: Ie7ee75ca311270e02a3e1b6b5eeb28b5a1ccdad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169477 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-07-26Add --with-package-format=emscriptenStephan Bergmann
...to have $(WORKDIR)/installation/LibreOffice/emscripten populated with just the relevant files from $(INSTDIR). (This doesn't reuse the complicated CustomTarget_instsetoo_native/install used for other PKGFORMATs; as a special case, it uses a much simpler CustomTarget_instsetoo_native/emscripten-install.) Change-Id: I9c7509aadbc0e6e49ec95bf51c748c2ff9f778b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171066 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-07-26cid#1557746 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1557751 COPY_INSTEAD_OF_MOVE cid#1557771 COPY_INSTEAD_OF_MOVE cid#1557775 COPY_INSTEAD_OF_MOVE cid#1557786 COPY_INSTEAD_OF_MOVE cid#1557787 COPY_INSTEAD_OF_MOVE cid#1557790 COPY_INSTEAD_OF_MOVE cid#1557793 COPY_INSTEAD_OF_MOVE cid#1557794 COPY_INSTEAD_OF_MOVE Change-Id: I1b02b6eca303b1a08975ea8aae7c9dbefbada47f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171061 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-26Delegate match to main internal starts/endsWith*Mike Kaganski
This simplifies and deduplicates the code, and even where it was simple, it has an advantage that if a change in algorithm is decided, it is done in a single place. Change-Id: I9ec55a29c5f2b2c972ac81bf07c20fc0a52a2a8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171033 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-07-26cid#1607270 silence Overflowed integer argumentCaolán McNamara
lets see if this works instead. Change-Id: Ib0a5df7deed2972cfed7c3afbe5c65229c208f26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171056 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-26ofz#70674 Null-dereference READCaolán McNamara
xCursorTunnel.get() is a SvxUnoTextCursor in this case Change-Id: Iaa50a4895923bc1635dc69325203de7bfb77886b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-03 13:39:45 +0000