summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-11-10tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 94, 99 Change-Id: I406b94c79426cebbd4813a019389d0cac0616bbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175226 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-10tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 999, 1003 V1037 Two or more case-branches perform the same actions. Check lines: 1557, 1566, 1595 V1037 Two or more case-branches perform the same actions. Check lines: 2593, 2689 Change-Id: I0a3ab375e9e8c72802615108948c96808a2ec0b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175208 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-09cid#1607142 Overflowed constantCaolán McNamara
Change-Id: I840fbf1b472dbf0a41dc9032e4e75839dec8dc2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-09cid#1634585 Use of auto that causes a copyCaolán McNamara
and cid#1634580 Use of auto that causes a copy cid#1634578 Use of auto that causes a copy Change-Id: Iad2ec6285b1eb923f3f30e8b18ee577d53ca140b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176312 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-09cid#1634574 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1634579 COPY_INSTEAD_OF_MOVE cid#1634583 COPY_INSTEAD_OF_MOVE cid#1634586 COPY_INSTEAD_OF_MOVE Change-Id: I24f4f0edf90546fe89ebecf0652f27298b5dd2a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176311 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-09XTopWindowListener is unused hereMike Kaganski
Change-Id: Ib4c1464d709c41f019d1910000e71075c9f5e037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176310 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-09Use OInterfaceContainerHelper4 per listener class for type safetyMike Kaganski
Change-Id: I919fef7e981d2dbdd69eb3cce34b3236dd6ed7ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176309 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-09tdf#130857 qt weld: Add QtInstanceTreeView skeletonMichael Weghorn
Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09tdf#130857 qt weld: Implement QtInstanceWidget::get_approximate_digit_widthMichael Weghorn
Similar to how OutputDevice::approximate_digit_width, used by SalInstanceWidget::get_approximate_digit_width does it, get the width for all a text containing all of of the 10 digits and divide by 10 to get the average/approximate width of a digit. This method e.g. gets called by the print progress dialog. Change-Id: Ib1779a0a211f571c10714a291fed8f84ae5906ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176306 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-09tdf#130857 qt weld: Assert in unimplemented methodsMichael Weghorn
Trigger asserts in more currently not (yet) implemented methods, so anything missing becomes clear more easily when working on adding support for another dialog in the future, rather than some functionality just not working as expected. None of the newly added asserts was triggered in a quick test of opening all of the dialogs currently listed in QtInstanceBuilder::IsUIFileSupported. Change-Id: Iea0c7aa22744cd7652ca6cbc2fbb287bfeaa4ef7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176305 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09tdf#130857 qt weld: Implement QtInstanceWindow::presentMichael Weghorn
The gtk_window_present doc says: > Presents a window to the user. > > This may mean raising the window in the stacking order, unminimizing it, > moving it to the current desktop and/or giving it the keyboard > focus (possibly dependent on the user’s platform, window manager > and preferences). Therefore, call QWindow::requestActivate [2] for the Qt implementation of weld::Window::present. [1] https://docs.gtk.org/gtk4/method.Window.present.html [2] https://doc.qt.io/qt-6/qwindow.html#requestActivate Change-Id: I1c73dba1675523171a92c760836c6702a81f4c12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176303 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-09tdf#130857 qt weld: Signal container focus on window (de)activationMichael Weghorn
Set QtInstanceWindow as an event filter for it's QWidget, and call `signal_container_focus_changed` when receiving a QEvent::WindowActivate or QEvent::WindowDeactivate event. This code path got triggered as expected in a quick test switching between e.g. the "Help" -> "About" dialog and other windows in KDE Plasma using the Alt+Tab shortcut. The VCL implementation does something similar by handling VclEventId::WindowActivate and VclEventId::WindowDeactivate events, see SalInstanceContainer::HandleEventListener. For non-top-level containers, a different solution will probably be needed. For now, adjust the assert in QtInstanceContainer::connect_container_focus_changed to only trigger for non-QtInstanceWindow containers. And call the base class implementation, so that the handler is actually set for the QtInstanceWindow case. A potential solution for QtInstanceContainer might be to connect to the QApplication::focusChanged signal in QtInstanceContainer::connect_container_focus_changed and in the slot check whether exactly one of the old and new focus widgets has the container's widget in hierarchy. Change-Id: I945c8bf0999d93ae91cf25dcffd3fd3ce164d214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176302 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-09tdf#130857 qt weld: Support "LibreOffice Help Not Installed" dlgMichael Weghorn
Declare support for the "LibreOfficeDev Help Not Installed" dialog that shows when pressing F1 in a build that doesn't include the local help. This means that native Qt widgets are used for that dialog now when using the qt5 or qt6 VCL plugin and starting LO with environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set. Change-Id: I25254fd462b867a10e3ed6efc31d9b145466b0f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176299 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09tdf#130857 qt weld: Return actual msg dialog ret codeMichael Weghorn
If a synchronous message dialog is closed by means other than clicking a button, return the QDialog::exec response code in QtInstanceMessageDialog::run, comparable to what already happens in the async case (s. QtInstanceMessageDialog::dialogFinished) instead of always returning RET_CLOSE. This is relevant e.g. for the "LibreOfficeDev Help Not Installed" dialog that shows when pressing F1 in a build not including local help, which will be declared as supported in an upcoming commit. That dialog gets closed with a response code of RET_YES when the link button is clicked, see HelpManualMessage's DownloadClickHdl (in sfx2/source/appl/sfxhelp.cxx). Change-Id: Iaa1599dda618e61a5b19264f1984d570a45c6881 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176298 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-09tdf#130857 qt weld: Always set non-empty link targetMichael Weghorn
In QtHyperlinkLabel::update, always set a non-empty string for the link target, as otherwise the text in the QLabel will not be a clickable hyperlink, but just plain text. While that seems reasonable in general, this is problematic as the QtHyperlinkLabel is the widget used for QtInstanceLinkButton, and a weld::LinkButton should be clickable even if the link target is empty, as a custom signal handler can be set that doesn't make use of th URI anyway. Therefore, just set a single space character as the URI if the actual one is empty. This is relevant e.g. for the "LibreOfficeDev Help Not Installed" dialog that shows when pressing F1 in a build not including local help, which will be declared as supported in an upcoming commit. Change-Id: I1db4c405793109ae9af811d6dd08b1da37246271 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176297 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-09tdf#130857 qt weld: Extract setting label propsMichael Weghorn
Move logic to set "GtkLabel" properties on a QLabel to a new helper method QtBuilder::setLabelProperties and call it right after creating the QLabel for a "GtkLabel", and only for that case. This also prevents potentially overwriting the text of a QtHyperlinkLabel widget created for a "GtkLinkButton" object in a .ui file, as that class also derives from QLabel, but has specialized handling for setting the label text to be a hyperlink. Change-Id: I8bfcc31a503a1c9deec32bcd584e1a86c3dfff19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176296 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-09Make Multiplex do what it claimsMike Kaganski
Since the initial import, it used to only notify the first listener. I guess it was just an overlook of using 'if' instead of 'while' in the macro code, later flattened. Change-Id: If2b769e71f937271c004a7152da751b26a2e0f24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176293 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-09tdf#163812 sw: invalidate "Area" properties so sidebar updatesJustin Luth
Changes to the background fill were not being updated in Writer's sidebar, ever since the introduction in 5.3. Each of these invalidations can be observed to be necessary in the corresponding fill type and fill choice listboxes. It already worked in Draw, and I don't see anywhere this would be needed in Calc Change-Id: I42f94ee99036761ff69293bcbb44aeda61e1b321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176300 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-11-09Update git submodulesPierre F
* Update helpcontent2 from branch 'master' to b0473042ff89f94b04e9c7ebe0cfeb5750c2cc4b - tdf#143846 split LEFTB LENB MIDB RIGHTB Change-Id: I57be1c7ea1642ef84798fadc6dd204bbac4c994e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176069 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-08Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 7e9cbf3457ba40fdc2fbdfea743c2d8028e1f548 - tagalog Add swriter screenshots, remove unused Change-Id: Ibad461bf00df910a53c7ac618a67a6afaa6a9451 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176304 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-08Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 417ad040381dd1be6e8efa9e07ef22b2f578c7cf - Remove ddesktop screenshots (not used) Change-Id: Iab34bd0e181153be708b7e292dd8562877ae7f12 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176301 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-08gpgme: Upgrade to 1.24.0Xisco Fauli
* external/gpgmepp/gettid.patch fixes /opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: ./.libs/libgpgme.so: undefined reference to `gettid' * external/gpgmepp/strcasecmp.patch fixes libgpgme.lib(key.obj) : error LNK2019: unresolved external symbol _strcasecmp referenced in function __gpgme_key_append_name Downloaded from https://www.gnupg.org/ftp/gcrypt/gpgme/gpgme-1.24.0.tar.bz2 Change-Id: I2f2587f5157db7610d6ffaa84b49f9677ba1cc4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176160 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-08be conservative on allowed temp font namesCaolán McNamara
Change-Id: Iefdc1a8c9b4c7e8c08c84f747f8287ac3c419839 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176286 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-11-08cool#9992 lok doc sign, hash extract: initial getCommandValues('Signature')Miklos Vajna
The trouble with signing via ca/cert/key PEM files is that usually the CA is not trusted by the received of the signature. 3rd-party services are available to do generate trusted signatures, but then you need to share your document with them, which can be also problematic. A middle-ground here is to sign the hash of the document by a 3rd-party, something that's supported by e.g. <https://docs.eideasy.com/electronic-signatures/api-flow-with-file-hashes-pdf.html> (which itself aggregates a number of providers). As a first step, add LOK API to get what would be the signature time during signing -- but instead of actually signing, just return this information. Once the same is done with the doc hash, this is supposed to provide the same info than what the reference <https://github.com/eideasy/eideasy-external-pades-digital-signatures> app does. This is only a start: incrementally replace XCertificate with SignatureContext, which allows aborting the signing right before calling into NSS, and also later it'll allow injecting the PKCS#7 object we get from the 3rd-party. Change-Id: I108564f047fdb4fb796240c7d18a584cd9044313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176279 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-08tdf#163802 cui: Don't set temporary title for spelling dialogMichael Weghorn
The window title set using SpellingDialog::SetTitle_Impl was overwritten right away by the next call to `m_xDialog->set_title(...)`, so was never meant to be used in practice anyway. The // use this function to apply the correct image to be used... comment suggests that SpellingDialog::SetTitle_Impl also sets some image, which was actually the case when the code was initially introduced in commit d32b3a714fe55892bdead03502c5a9b0e77fa61d Author: Mathias Bauer <mba@openoffice.org> Date: Sat Oct 31 00:36:06 2009 +0100 #i106421#: move svx/source/cui to cui , but that's no longer the case since commit bc3c10b5ce88869871761000e9724bcad9a0d556 Author: Cédric Bosdonnat <cedric.bosdonnat@free.fr> Date: Sun Oct 23 07:35:06 2011 -0700 Grammar checking dialog: reworked how explanations are shown , so there's no more reason to call SpellingDialog::SetTitle_Impl before setting the actual title. Change-Id: I56d7478271b53a6ec033a8ead9b05d3eff6ad5b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176256 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-08Simplify using WeakImplHelper and OMultiTypeInterfaceContainerHelperVar4Mike Kaganski
Change-Id: Ib83b93d6055d3006eecdb25f1ccd7baf1251a40a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176284 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-08Update git submodulesXisco Fauli
* Update dictionaries from branch 'master' to d1696029d8923ae697cb2d6d4d7d69791b1943f2 - Upgrade Mongolian dictionary to 2024.11.08 Downloaded from https://github.com/bataak/dict-mn/archive/refs/tags/2024.11.08.zip Change-Id: I5f3159f2162690cfd5c7f48cf3793fdbd4e2a6e6 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/176291 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-08Update git submodulesBatmunkh Dorjgotov
* Update dictionaries from branch 'master' to e9052a7afc28c3f8ef24dcc8a29f59da6c3ac5e5 - Add license statement and update hyphenation rules Change-Id: Ie5fb948541f618a7ec3fc8bba1afdaa85bb2d707 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/164311 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-08Update git submodulesBatmunkh Dorjgotov
* Update dictionaries from branch 'master' to 40d2ad1687d5a8450eba9dc2f24ec8822d8af37c - Update Mongolian dictionary Change-Id: Ide7f5149abacc1c9c043a551c0a4771b03c9cec8 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/161705 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-08vcl: fix crash in findAnnotations()Miklos Vajna
Crashreport signature: > SIG Fatal signal received: SIGSEGV code: 1 for address: 0x0 > program/libmergedlo.so > vcl::ImportPDFUnloaded(rtl::OUString const&, std::vector<vcl::PDFGraphicResult, std::allocator<vcl::PDFGraphicResult> >&) > vcl/source/filter/ipdf/pdfread.cxx:335 > program/libsdlo.so > SdPdfFilter::Import() > sd/source/filter/pdf/sdpdffilter.cxx:55 > program/libsdlo.so > sd::DrawDocShell::ConvertFrom(SfxMedium&) > sd/source/ui/docshell/docshel4.cxx:502 (discriminator 2) > libmergedlo.so > SfxObjectShell::DoLoad(SfxMedium*) > sfx2/source/doc/objstor.cxx:786 I.e. in case we search for a marker image inside the annotation's object, then handle the image type without a bitmap the same as non-image types. Change-Id: I443b5f448ea4544183fb4ed0b457e85a45f51acc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176282 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-08loplugin:reftotemp in dbaccess..editengNoel Grandin
Change-Id: I51f5e47fb2fca37928ac58952a6a34b7351ca53c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176277 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-08tdf#162944 package: add test fileMichael Stahl
Change-Id: Ie689e8dff3405fc2a0da3791089d077db8bf59b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176288 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-11-08sidebar: move apply to all slides above repeat settingsSzymon Kłos
Button "apply to all slides" setups properties selected above to all the slides. Repeat options are common to the whole presentation. Let's move repeat section to the bottom so it is less confusing Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I19bb8d10c3969ceb033e2a6d26489999bb7451c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174357 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: vivek javiya <vivek.javiya@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176283 Tested-by: Jenkins
2024-11-08loplugin:reftotemp in codemaker..connectivityNoel Grandin
Change-Id: I9da2976410f7c4da8ab0d85150fc87f2b3df9e0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-08loplugin:reftotemp in cppcanvas..cuiNoel Grandin
Change-Id: I6c9ded2252462bcdeee6520bb7b7fa1752aa583b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176276 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-08tdf#155447 a11y: Add test for accessible IDs expected by OrcaMichael Weghorn
Add a new AccessibilityTools::getAccessibleObjectForId helper that can be used in a11y tests to identify an object by its accessible ID. Add a test that checks that the accessible ID of the spelling dialog matches what Orca's logic expects in order to identify it, and that more UI elements with expected accessible IDs exist. This is to prevent breaking Orca logic without noticing. Any changes affecting this test should be discussed with the Orca maintainer first. See the comment above the newly added test for more details and a link to the corresponding Orca commits. The new test initially only checks that objects with corresponding IDs exist, could be extended to verify more of their properties as needed. Logic for checking availability of a dictionary, needed for spell check was taken over from the existing tdf155705 test in sw/qa/extras/accessibility/tdf155705.cxx, whose sample doc is also used. Change-Id: I0c5629272a89a4a570e080e62e99b6c105369cf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176281 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-08tdf#155447 a11y: Set accessible ID that Orca expectsMichael Weghorn
Orca commit [1] commit 40a2d302eb52295433fd84e6c254a7dbe5108a24 Author: Joanmarie Diggs <jdiggs@igalia.com> Date: Thu Nov 7 14:15:07 2024 +0100 Spellcheck: Check for accessible id in more places Do the following case-insensitive checks: * If the object's accessible id starts with "suggestions" treat it as the suggestions list. * If the object's accessible id starts with "replacement" treat it as the object (likely entry) which contains the proposed replacement. * If the label's/widget's accessible id starts with "error" treat it as the container displaying the misspelled word. Note that the first of the three is based on what LO 25.2 currently exposes ("suggestionslb"). The other two are not in use yet, but adding them facilitates implementation in, and getting feedback from, apps and toolkits. Also modify the existing check for the window. We were doing an exact match on "SpellingDialog". Making that case insensitive and limiting to starts with "spelling" works with the current LO implementation and removes an implementation detail ("dialog"). introduced logic to identify more UI elements in the spelling dialog by their accessible ID. Adjust the GtkBuilder ID (which gets reported as accessible ID as well) of the drawing area that holds the misspelt text to match the expectations as mentioned in the commit message above. [1] https://gitlab.gnome.org/GNOME/orca/-/commit/40a2d302eb52295433fd84e6c254a7dbe5108a24 Change-Id: I0658de40a47e46a6b2451dfb4ee30d1457b9f9e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176280 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-08Refactor focus handling in `LevelHdl` and `SwTokenWindow`Darshan-upadhyay1110
- Added a new `LevelHdlImpl` method with a `bool bGrabFocus` argument. - Refactored `LevelHdl` to call `LevelHdlImpl` with `true`. - Adjusted `SwTokenWindow::SetActiveControl` and `SwTokenWindow::SetForm` to skip `GrabFocus` when the argument is `false`. - Ensured focus behavior remains unchanged except for the initial "ActivatePage". Change-Id: If2f43e43f94c3762acd93974550ff0d2d66c6c21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174423 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit dbb054045fae8605794c17aae052a9d588fe33fc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175996 Tested-by: Jenkins
2024-11-08cid#1555255 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556766 COPY_INSTEAD_OF_MOVE Change-Id: Ie11d0279ec775034ee8e5a14b0e57eaed110fda6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176265 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-08no need to take a copy of the getProcessComponentContext return valueNoel Grandin
we can just take a "const &". (found by running clang-tidy with the performance-unnecessary-copy-initialization warning) Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-08tdf#163803 oox: export fill on graphic objectJaume Pujantell
The fill contents of a graphic object are lost when saving a pptx. Change-Id: I055d778d4a92de18dfec59bd27c63a20c08b99f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176208 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit dfd8caa6c49bd33f549a37d6c0244e4cce8f16d8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176224 Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com> Tested-by: Jenkins
2024-11-08expat: upgrade to 2.6.4Xisco Fauli
Downloaded from https://github.com/libexpat/libexpat/releases/download/R_2_6_4/expat-2.6.4.tar.xz Change-Id: I9ae3b6e586847e8ba0439f1c42baa13a1e2cf427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176271 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-08remove dead codeNoel Grandin
since commit 9cef1d069a21cb821b1ef880da0358aa2a959a40 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Sep 12 13:32:21 2023 +0200 loplugin:unodispose in UnoControls Change-Id: I36b0bcdeb61dda176ac6778ef1116378d40531f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176264 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-08cid#1620539 Check of thread-shared field evades lock acquisitionCaolán McNamara
Change-Id: Ifd0008d8258b7fe9e72d40ae0384ff9f5e538190 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176268 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-08lok: disabled misc shape wipe non supported transitionJaviya Vivekkumar Dineshbhai
Change-Id: I1a2f67e20fb39a711a6da41ee1152499cf91c28a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176266 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-08Related: cid#1608068 Data race conditionCaolán McNamara
Change-Id: I10c6dd9c12c7558d1d71f39580b3fa470efe69e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-08loplugin:reftotemp in canvasNoel Grandin
Change-Id: I0a038cf32e05dab59b1cedcf06ecd38b48d76feb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176257 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-08cid#1608068 Data race conditionCaolán McNamara
Change-Id: Iec72c56e1d58cbcd6463aa98e8d99d6c469c9dd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176261 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-08cid#1608267 silence Overflowed constantCaolán McNamara
Change-Id: I10dfd5953e8f481c12111e2b541fece6aa2897e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176260 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-08cid#1634530 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Iae03c8a982659503d7f73dbabbcece7bdb9c8e55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176259 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-11 01:59:55 +0000