summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-09-11Use { ... } for grouping that does not need a sub-shellStephan Bergmann
...in case that makes ever so small a difference, esp. on Windows (where spawning processes is known to be expensinve; but note that at least Bash seems to not spawn a sub-shell anyway when what is enclosed in ( ... ) is just a simple single process, which is commonly the case for these cppunittester invocations) Change-Id: Ie9200270743754e02fbfdb2b17239e9873031dab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102407 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-11convert IMAP_FORMAT to scoped enumNoel Grandin
Change-Id: I58090ced672267614ade2e3e81e6264d01b77901 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102405 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-11xmloff: remove dead com.sun.star.comp.Draw.XMLContentExporterMiklos Vajna
And test com.sun.star.comp.Draw.XMLOasisContentExporter instead in JunitTest_xmloff_unoapi. Change-Id: I22bf816d08bcd04b277e461a5055883b730811b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102401 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-11tdf#136573 chart2: enable arrow keys in data labelTünde Tóth
moving to custom positions. Follow-up of commit c10d5854b5427ad1bfffc00e77a9306c99c78c63 (tdf#136430 Fix chart crash trying to move data labels with arrow keys.) Change-Id: I8833e14a7c9c8f7bdb758fc0eb97be38aee35b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102262 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-11tdf#136645: sw_odfexport: Add unittestXisco Fauli
Change-Id: I0ec82de4932f4200aeb7cf778bf93dd9d1c28eda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102402 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-10Replace sal_uLong with proper types in cuiMuhammet Kara
Change-Id: I0724105f0d058651d47e6d62bc20e497af37242f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102408 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-09-10Disambiguate UITest_sc_options and UITest_sw_optionsStephan Bergmann
...that were added with the same name UITest_options in 107af098311beafaadb343c5a3634389f56006a0 "uitest for bug tdf#117458" and ec914194382654aa4b0ad9973acc0eed15a4ab43 "add uitest for bug tdf#78133", respectively Change-Id: I31a967d2ce14f86d91951a836b694f360802c5a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102391 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-10tdf#136512 listen to style-updated on pEventWidget instead of toplevel...Caolán McNamara
m_pWindow to avoid infinite event loop under Linux Mint Mate 18.3 Change-Id: Iaeec4538c7a3c1d49042c4eeb6d30ffc6ab01af8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102400 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-10Revert "tdf#59674 Word export: set a tabstop at numbering IndentAt"Justin Luth
This reverts commit 5ad17c85dc93973c0cbb1d633b9eed144f0677de for the benefit of all mankind, and specifically tdf#136644. Reason for revert: LO's UI for this is totally messed up, so I want to completely get out of anything to do with numbering/bullets. It is inconsistent with how it handles default tab stops (delete all when none are shown and things act different), it doesn't always increment levels properly, and does all kinds of weird things. Change-Id: Ifaf8c3a7c9ac30b7103b82dd119cb4629f0b2578 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102415 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-09-10pango_attr_list_filter returns the removed attributesCaolán McNamara
Change-Id: I7d1dd208f11086ac605cf0dcc47edef67e3967a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102113 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-10label property missingCaolán McNamara
since... commit c4ea034beb2fa0f1e874a39391a9498bdd7c7aad Date: Tue Sep 1 16:43:20 2020 -0300 tdf#118148 Extended tips for HC2/swriter Change-Id: Ifa76663c52e880c9ab11ed0d32370405a77135f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102386 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-10turn off any idle scheduled layout on hard layoutCaolán McNamara
Change-Id: Iaccc043e4187b46135c017f05f6179d17564a735 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102389 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-10micro-optim we just want to remove all urls after m_nCurPos (sfx2)Julien Nabet
Change-Id: Ib27386baa81ee912ebb5112d721610c5fc3c708b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102287 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-10support attempting to set a foreground color for labels and textviewsCaolán McNamara
but try to discourage use of random colors Change-Id: I1a67956846b8bd056180b37547ca7d206970c0e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102014 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-10tdf#75280: "nFormat" should be "sal_uLong" instead of sal_uIntPtr (svx/imapdlg)Julien Nabet
Change-Id: I851837592b0bba0d3d29aa7edafa7787ab8da754 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102398 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-10Remove commented code since 2013 (svx/svdedtv1)Julien Nabet
More precisely since: d02f75a8c36705924ddd6a5921fe3012fafce812 author Oliver-Rainer Wittmann <orw@apache.org> 2013-04-10 08:20:16 +0000 committer Michael Meeks <michael.meeks@suse.com> 2013-05-20 11:33:10 +0100 commit d02f75a8c36705924ddd6a5921fe3012fafce812 (patch) tree 40da9f25714a77f5e9e17ef7bee81c33a1a11b4b parent d8d55787b81cdc955b73c8befa4ab608f46e32aa (diff) Resolves: #i121420# merge sidebar feature (cherry picked from commit 0a0a9b32aa5bf1ce2554ad37cbba3c7a105db2b5) Change-Id: If66ec1e1cd1aaab348dea6c4f85d52382956b0d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102397 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-09-10pTols is an array of sal_uInt8Julien Nabet
First it was sal_uIntPtr then it was first converted with: commit e75abe6e0a4ea250366bb29c0ece697e9b1b80a1 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Dec 12 09:33:14 2017 +0200 convert tolerance params to sal_uInt8 since their range is 0-255 Also drop pTols from ImplColReplaceParam, since it is always nullptr. then reverted with: commit 7accac097688832d8682a88a0176c3e1482ffade Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Fri Jan 5 11:12:54 2018 +0200 tdf#114837 FILEOPEN: Image is blank revert commit e75abe6e0a4ea250366bb29c0ece697e9b1b80a1 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Dec 12 09:33:14 2017 +0200 convert tolerance params to sal_uInt8 for now. but redone with: commit d03c46eba1bd1d3399ee3d4e6af1c9e16c2c1718 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jan 23 13:13:03 2020 +0000 weld SvxBmpMask Change-Id: Ied627a0c6b1c85bac8fd0cafc21ae1acceaf2bcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87281 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Change-Id: I3f38cdc2bd4ea35edea3d95489206a7e68971f42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102396 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-09-10Remove some DBG_UTIL debug codeStephan Bergmann
...that had originally started to get introduced with 159a4c3c75e3a7aecbf1656f3254331892098ba7 "tdf#84881: WiP: Fill in more fields of the TimeStampReq" saying: "Temporarily, dump the TimeStampReq object to a file for inspection in a DBG_UTIL build." (I came across this when wondering why such PDFWRITER.cms.data and PDFWRITER.hash.data files kept popping up in my source/build trees.) Change-Id: I28beabe912beb112e1c71c8e3b559e161b22849b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102393 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins
2020-09-10Fix extended tip contents after importOlivier Hallot
Change-Id: I440e70b51a75a19e18d5f5d4df24fb2402d239de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102385 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-10Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to db901dd0afc1029f3b9b801410de9ad75df05cb2 - Mute l10n translations of writer function names Change-Id: Idd8090fd202239b5f8be4523e7d442f84a761163 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/102387 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-10tdf#136645 FILEOPEN: ODT: Incorrect section sizeNoel Grandin
regression from commit 36914a8b3a07391d225bce593236d6fcf0cc61d2 (patch) use fastparser in XMLElementPropertyContext subclasses Change-Id: I31dc4ce73da88fbd2fbf0f5066c58ac8acfc2731 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102384 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-10Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 1e21cf1fa77421ab7abd52d55af1662a6890766e - CSS: Separate this rule out of the block Change-Id: I1c7ea2603fcbb8a6668cde831848246bb4d1c3a4
2020-09-10Related: tdf#131581 inhibit updates during other for_each variantsCaolán McNamara
Change-Id: I74789006815b0ae04cfe5084d60d639241062896 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102383 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-10Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 0b73d5eb91c2e1d1c179dccc9e81be0f0451c719 - Online help CSS: improve link colors so Olivier doesn’t hate me Change-Id: Ia03fdfe89ac578891458b19657486d398d4bc1b4
2020-09-10tdf#136238 speed up deleting large cross page tableNoel Grandin
Goes from more than 30s to less than 1s on my pc. We were getting stuck inside the loop in sw::UndoManager::AddUndoAction, because the RemoveOldestUndoAction was continually doing nothing because it was hitting the if ( IsInListAction() { assert(!"SfxUndoManager::RemoveOldestUndoActions: cannot remove a not-yet-closed list action!"); return; } code. Which means that there is some bug here, but I'm not sure what. We are deep inside the delete logic at that point, and it doesn't seem unreasonable to opportunistically delete some of the UNDO list at that point. So the real fix is just the conversion from a while loop to an if-check. Change-Id: Ie2707009dd6574b996421f67d952ab9fdaaaf6aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102378 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-10tdf#135950: sw: Add UItestXisco Fauli
I'm reusing the test for tdf#93068. We already have other tests where the Character dialog is used so a test only testing the dialog opens is recurrent Change-Id: I5b75be6a2b4ccef9a794be76f089a70ec0903665 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102369 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-10tdf#131581 inhibit updates during all_foreachCaolán McNamara
Change-Id: I8494b4c9175e427bfb89696d49c2da7607af37ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102371 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-10tdf#123355 DOCX import: fix cell range ABOVE, BELOW,László Németh
LEFT and RIGHT by converting them to Writer cell ranges. These ranges start at the first cell above/below/right/left (including empty cells or cells with text content!) and end at the end of the first value cell range. If there is no value cell range, they end at the table border. Note: In MSO, table functions COUNT(), AVERAGE() etc. use non-value cells, as zero with ABOVE, BELOW, LEFT and RIGHT, but skip them using A1:A10 like range names. Change-Id: I906f27ecccaa8ded5460cd861ef8808000722860 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102320 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-10tdf#53431 tdf#136535 sc: fix Fill Cells with AutofilterAttila Szűcs
Sheet->Fill Cells on a selected range duplicated or removed the AutoFilter button, when the range contained that, by copying cell properties. Apply RefreshAutoFilter() after the fill to repair this. Note: this refresh is not slow, because it depends only on the number of columns, see ATTR_MERGE_FLAG attribute of the columns. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I95d394c5432d22805a761b76219f656fad3feae1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102173 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-10crashtesting: assert the condition making tdf122894-1.doc crashCaolán McNamara
sometimes it doesn't happen to crash, but its always dereferencing a deleted frame Change-Id: I056808398c97c5de12542c6c342e7d9d7e5195d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-10tdf#135950 crash in format->character with selected text in tableCaolán McNamara
Change-Id: I66e36a638d040d2a38ac234383d6f314a2ff4d88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102368 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-10tdf#75280: Convert some inappropriate use of sal_uIntPtr (+sal_uLong) (vcl)Julien Nabet
Change-Id: I8708cb825fbfe8de201a2025b7f988a1db9302ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102361 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-10crashtesting ooo97840-2.odt assert in SvXMLAttrCollection::AddAttrNoel Grandin
because of empty namespace and prefix Change-Id: I5710e15c38fa5d22ca2dc7c875c2d9b1076fa93d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102365 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-10Adapt solenv/flatpak-manifest.in to eaf4f6d3b1e64bc7b057e70cffe0bda0ed42c49fStephan Bergmann
..."update Skia to chrome/m86 snapshot" Change-Id: I3c1cc7a357a89d7763513f92bca5771d56b17884 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102352 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-10svidl: Don't mention removed propertiesMaxim Monastirsky
Get/Set were removed in ccbed01b40c9bc4421943ebe1fe818d43aadcc7d ("remove unused GET/SET/STATUSBARCONFIG in .SDI files"). Nested methods were removed in 20f33eb7c5ebf2611008f6173da870bd0d1693fc ("svidl: Remove nested method support"). Change-Id: Ice03e63dc5f54365099bcaff3ba379cf691709bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102346 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-10detect if a cell still needs interpreting after Interpret()Luboš Luňák
https://bugs.documentfoundation.org/attachment.cgi?id=51878 after hard-recalc asserts because of not having cell dependencies non-dirty for threaded calculation. This is because Interpret() actually sometimes returns without computing a value for the cell, e.g. when it backs out because of a need to do iteration. This is handled when Interpret() is called from InterpretTail(), but ScDependantsCalculator does not handle this and considers all cells interpreted, unless it detected a problem. We've already fixed a number of such bugs, and given that there are still problematic corner cases after all this time, add code simply detecting this generic problem and avoiding threading in that case, with a SAL_WARN. This does not fix the problem itself, but at least now it's handled. Change-Id: I2f454b577f6516d2ce008005dbfbeb554e18d811 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102156 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-10blacklist amd driver with vulkan version <= 2.0.49 (tdf#136553)Luboš Luňák
It's from 2018 and there are newer versions available (although maybe not for older Windows versions). Change-Id: Ib3e8973c90b6ef9eee160cd2436978741150a2f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102290 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-10Flatpack: update to mdds 1.7.0Julien Nabet
Change-Id: I441768999a005f99cad19b7a5e68809214e9ee10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102354 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-09-10tdf#119931 fix a11y warnings in cui/uiconfig/ui/aboutdialog.uiGabor Kelemen
Images and long descriptions are display-only Change-Id: I4b0031ae6f94bb2edaaaf90039a39170bfb27a62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100349 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-09-10Guard against lone mnemonic prefix at end of keyStephan Bergmann
For --with-lang=am, CppunitTest_sw_dialogs_test hit > cppunittester: include/rtl/ustring.hxx:764: sal_Unicode rtl::OUString::operator[](sal_Int32) const: Assertion `index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())' failed. at > #4 0x00007fffcff543df in rtl::OUString::operator[](int) const (this=0x7ffff3538f40, index=2) at include/rtl/ustring.hxx:764 > #5 0x00007fffd0381b24 in MnemonicGenerator::ImplFindMnemonic(rtl::OUString const&) (this=0x7ffff371c820, rKey="በ_") at vcl/source/window/mnemonic.cxx:67 > #6 0x00007fffd038210c in MnemonicGenerator::RegisterMnemonic(rtl::OUString const&) (this=0x7ffff371c820, rKey="በ_") at vcl/source/window/mnemonic.cxx:89 > #7 0x00007fffb244fa77 in (anonymous namespace)::GtkInstanceBuilder::GenerateMissingMnemonics() (this=0x611000133840) at vcl/unx/gtk3/gtk3gtkinst.cxx:15799 > #8 0x00007fffb2431811 in (anonymous namespace)::GtkInstanceBuilder::GtkInstanceBuilder(_GtkWidget*, rtl::OUString const&, rtl::OUString const&, SystemChildWindow*) (this=0x611000133840, pParent=0x625000260460 [GtkBox], rUIRoot="file:///.../instdir/share/config/soffice.cfg/", rUIFile="modules/swriter/ui/frmtypepage.ui", pInterimGlue=0x0) at vcl/unx/gtk3/gtk3gtkinst.cxx:15784 > #9 0x00007fffb243001a in GtkInstance::CreateBuilder(weld::Widget*, rtl::OUString const&, rtl::OUString const&) (this=0x614000005a40, pParent=0x61700001ef18, rUIRoot="file:///.../instdir/share/config/soffice.cfg/", rUIFile="modules/swriter/ui/frmtypepage.ui") at vcl/unx/gtk3/gtk3gtkinst.cxx:16333 [...] apparently caused by > #. ytvmN > #: sw/uiconfig/swriter/ui/frmtypepage.ui:617 > msgctxt "frmtypepage|horibyft" > msgid "b_y" > msgstr "በ_" in translations/source/am/sw/messages.po Change-Id: Ie02ed94d159d957984fb3cd91ed6608a6148a570 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102356 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-10Update one mention of pdfium-4137.tar.bz2Stephan Bergmann
...left behind by 4488be8a9279be0bd0aebd476589a49d2b95da6e "external: update pdfium to 4203" Change-Id: I5e092f6351281c99a5a3f8b6865d5166805a5c46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102351 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-10cid#1466656 silence Logically dead codeCaolán McNamara
Change-Id: Id49181f71390ff6768ce6bc5734f8166e1a310b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102293 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-10Update Flatpak to org.freedesktop.Platform//20.08Stephan Bergmann
...see <https://github.com/flathub/org.libreoffice.LibreOffice/issues/129> "Update runtime to 20.08" Change-Id: I3eb60e7c020857209f30cbed24c60f6a0627f938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102353 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-10tdf#132293 remove unused imports from .py files under sc/qa/uitest/autofilterIlkyu Ju
I used pyflakes to check for any unused imports in python scripts under 'sc/qa/uitest/autofilter' directory, and then removed all the unused import statements. After the change, running pyflakes should not give warnings on unused imports. (FYI--The original scope of the issue tdf#132293 focused on removing unused imports only; therefore, other issues, such as warnings on unused local variables, still exist.) Change-Id: I5d512b99eb18dd0fc8e566a3244dbd6f264e0dd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100385 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-10Remove the useless Export sdi propertyMaxim Monastirsky
Maybe I'm missing something, but its usage - "if ( !GetExport() && !GetHidden() )" seems like expects it to be true and false at the same time. Anyway, there's no diff in workdir/SdiTarget after this change, so should be safe to remove. Change-Id: I6db508ff40c05dc828ffa91bb41a37c17b697503 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102345 Tested-by: Jenkins Tested-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-09-10sdnew.sdi file appears to be unusedMaxim Monastirsky
Change-Id: Ie6ef55fdae47e74ba528b704feb382a64094a563 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102344 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-09-10Remove some obsolete commentsMaxim Monastirsky
Change-Id: I80aa3a42818795168e9188cda3ceeff706254d89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102157 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-09-10remove image_position top from GtkButtonandreas kainz
Change-Id: Ib7a8eb77b31a8abb08be501b1e0ce8d480f163c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102340 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-09-10page_increment improvementandreas kainz
Change-Id: I2d8e00e563146b05e97c49f83dc0c12efde8e24f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102339 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-09-10check page_increment and step_increment valuesandreas kainz
Change-Id: I492077e203c6c1b5878f06917952197cad45365d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102342 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-29 21:40:43 +0000