summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-07-21tdf#99609 a11y: Implement retrieving selected rows in tab list boxMichael Weghorn
With this in place, the index of the selected row in the Expert Configuration dialog can e.g. be seen in Accerciser using this in its Python console with the table object selected in the tree view of the a11y objects: In [1]: table = acc.queryTable() In [2]: table.getSelectedRows() Out[2]: [12] Change-Id: I2f07e73552ef12989acab461b33c3e41d9195490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154713 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-07-21tdf#99609 a11y: Use GetEntryOnPos in more places in tab list boxMichael Weghorn
As described in more detail for the case in Change-Id I35f7280d2c386a9a8e04e636ebf34850a733c84a ("tdf#99609 a11y: Announce the correct entry in tab list box"), `GetEntryOnPos` is the method that returns the correct entry when passing the row index (when there are also non-visible dummy entries) and that commit also mentioned: > There are more uses of `GetEntry` that will be > looked at separately. These two uses in `SvHeaderTabListBox::GetCurrRow` and `SvHeaderTabListBox::IsCellCheckBox` are also using a row index, so it looks to me like they should also be using `GetEntryOnPos`. Change-Id: I1170063d760c020ad543fb458cac99a10e37c9a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154710 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-07-21tdf#99609 a11y: Fix bound rect reporting for tab list boxMichael Weghorn
As described in more detail for the case in Change-Id I35f7280d2c386a9a8e04e636ebf34850a733c84a ("tdf#99609 a11y: Announce the correct entry in tab list box"), this also needs to use `SvTabListBox::GetEntryOnPos` for the correct entry to be used. With this in place, Accerciser now highlights the correct entry when clicking on the corresponding object in its treeview of LO's a11y hierarchy. Change-Id: I850247cd384a6a9bb909f51b39c4743548ec1105 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154689 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-07-21tdf#99609 a11y: Fix reporting selection in tab list tableMichael Weghorn
The previous calculation of row and column index in `AccessibleTabListBoxTable::getSelectedAccessibleChild` based on the selection index was wrong, so fix that. Only increase the the loop variable `nRow` in `AccessibleTabListBoxTable::implGetSelRow` at the end of the loop, since the comparison still needs to use the original value. (Index starts at 0. Trying to retrieve the first selected child at index 0 would otherwise fail, and always return the fallback value of row index 0, making NVDA always announce the first row as selected instead of the actually selected one. The issue could also be observed with Accerciser and the qt6 VCL plugin. With the "org.openoffice.LDAP" row selected in the dialog, and the table object selected in Accerciser's treeview of the a11y hierarchy, the cells in the first row ("org.openoffice.VCL") would always be returned when querying the selection using the AT-SPI Selection interface: In [1]: sel = acc.querySelection() In [2]: sel.nSelectedChildren Out[2]: 4 In [3]: sel.getSelectedChild(0).name Out[3]: 'org.openoffice.VCL' This works as expected now with this fix in place: In [4]: sel = acc.querySelection() In [5]: sel.nSelectedChildren Out[5]: 4 In [6]: sel.getSelectedChild(0).name Out[6]: 'org.openoffice.LDAP' With this fix in place, NVDA now properly announces the currently focused row in the Expert Configuration dialog (i.e. both, the focused cell first, and then the whole row as selection). Change-Id: I394027695616b17f7290136d8ee10c06a0282e80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154688 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-07-21tdf#99609 a11y: Announce the correct entry in tab list boxMichael Weghorn
The tree view in in the Expert Configuration dialog has a lot of "<dummy>" entries to implement creating entries on demand when expanding an entry (see `SalInstanceTreeView`). While these are not visible in the user interface, these have the effect that calling `SvTreeListBox::GetEntry` with the row index does not actually return the correct entry, but an entry further down in the tree view if there are non-expanded nodes (as is the case e.g. right after opening the Expert Configuration dialog, without having done any search). Use `SvTabListBox::GetEntryOnPos` that does exactly what is needed and returns the correct entry. With this in place, Orca with the qt6 VCL plugin now correctly announces the focused entry in the Expert Configuration dialog. NVDA on Windows now also announces the focused entry correctly at first. It then still always incorrectly announces the first row as selected, but that's another issue that will be addressed separately. This fixes the remaining issue about the selected/focused states not being reported correctly mentioned in Change-Id I6b532bfd6c3f437e44b3d67da8a5cc5f77b562d2 ("tdf#99609 a11y: Handle focused state for cells in tab list box"): > This at least makes the focused state being reported > properly for the first item ("org.openoffice.VCL") > in the Expoert Configuration dialog, but others still happen to not > have the focused state set properly when moving there with the arrow > down key, so there seems to be another issue somewhere. There are more uses of `GetEntry` that will be looked at separately. (Whether the dummy entries in the tree view should be exposed as cells of the table on the accessibility layer, as it is now, is another question, but leave it like that for now. With gtk3, which uses native Gtk widgets instead, the dummy entries are not exposed, which seems reasonable.) Change-Id: I35f7280d2c386a9a8e04e636ebf34850a733c84a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154687 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-07-21tdf#99609 a11y: Handle focused state for cells in tab list boxMichael Weghorn
Report the focusable state for cells in the tab list box, and the focused state when the row is selected and child focus is on the table or a child. Not properly reporting the focused state would e.g. prevent Orca from announcing the newly focused row in the Expert Configuration dialog when using the qt6 VCL plugin. (It already worked fine with gtk3 because that one is using native Gtk widgets.) This at least makes the focused state being reported properly for the first item ("org.openoffice.VCL") in the Expoert Configuration dialog, but others still happen to not have the focused state set properly when moving there with the arrow down key, so there seems to be another issue somewhere. pyatspi script that prints state change events: #!/usr/bin/python3 import pyatspi def listener(e): try: if e.host_application.name != 'soffice' and e.host_application.name != 'soffice.bin': return except: return print(e) pyatspi.Registry.registerEventListener(listener, 'object:state-changed') pyatspi.Registry.start() Sample output when moving between entries in the table (only "org.openoffice.VCL") has focused state set. object:state-changed:focused(1, 0, [table | ]) source: [table | ] host_application: [application | soffice.bin] sender: [application | soffice.bin] object:state-changed:focused(1, 0, [table | ]) source: [table | ] host_application: [application | soffice.bin] sender: [application | soffice.bin] object:state-changed:focused(0, 0, [table cell | org.openoffice.Inet]) source: [table cell | org.openoffice.Inet] host_application: [application | soffice.bin] sender: [application | soffice.bin] object:state-changed:focused(1, 0, [table cell | org.openoffice.VCL]) source: [table cell | org.openoffice.VCL] host_application: [application | soffice.bin] sender: [application | soffice.bin] object:state-changed:focused(0, 0, [table cell | org.openoffice.Inet]) source: [table cell | org.openoffice.Inet] host_application: [application | soffice.bin] sender: [application | soffice.bin] object:state-changed:focused(0, 0, [table cell | org.openoffice.LDAP]) source: [table cell | org.openoffice.LDAP] host_application: [application | soffice.bin] sender: [application | soffice.bin] object:state-changed:focused(0, 0, [table cell | org.openoffice.Setup]) source: [table cell | org.openoffice.Setup] host_application: [application | soffice.bin] sender: [application | soffice.bin] Change-Id: I6b532bfd6c3f437e44b3d67da8a5cc5f77b562d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154671 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-07-21tdf#99609 a11y: Set proper parent for cells in tab list boxMichael Weghorn
The a11y tree was broken: While the table has the cells as children, the cells did not have the table set as parent, but the table's header. Since the IAccessibleTableCell implementation in winaccessibility relies on the table being set as the parent, this wouldn't work when moving around within the tree view in the Expert Configuration dialog. Fix this by setting the table as parent. The issue could also be observed with the qt6 VCL plugin on Linux and Accerciser. With the table selected in Accerciser's tree view of the a11y hierarchy, the incorrect hierarchy could be seen using this in Accerciser's IPython console. In [8]: acc.childCount Out[8]: 48 In [9]: acc.get_child_at_index(4).name Out[9]: 'Migration' In [10]: acc.get_child_at_index(4).parent == acc Out[10]: False In [11]: acc.get_child_at_index(4).parent.childCount Out[11]: 4 With the fix in place, the table's child's parent is now the table again as expected: In [13]: acc.childCount Out[13]: 48 In [14]: acc.get_child_at_index(4).name Out[14]: 'Migration' In [15]: acc.get_child_at_index(4).parent == acc Out[15]: True In [16]: acc.get_child_at_index(4).parent.childCount Out[16]: 48 NVDA on Windows now announces *something* when moving between rows in the Expert Configuration dialog, but it's not the correct row yet. (That looks like another issue in winaccessibility code that needs to be fixed separately.) Change-Id: I400fa9811bb297ea7fd1accb0970811cdf11a119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154670 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-07-21tdf#154955 svx: PDF/UA export: tag SdrObjGroup properlyMichael Stahl
ISO 14289-1:2014, 7.3 Graphics Graphics that possess semantic value only in combination with other graphics shall be tagged with a single Figure tag for each group. Also produce the missing alt-text. Change-Id: I78e802d8e17a29c2d19fcf3a7ec9961f8f04e391 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154684 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-21tdf#50725: sd: add new configuration option DragThresholdPixelsSarper Akdemir
Adds new expert configuration option DragThresholdPixels for Impress and Draw under Misc/DragThresholdPixels. Also bumps up the previous hardcoded default value from 2 to 6. Assuming this value was set when 640x480 resolution was the most common resolution, currently scaling the hardcoded default by 3 makes sense. (eg. GTK uses 8 pixels as the default) Change-Id: I35c0eed3ce477685c759f517471ce0bdc8315864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154379 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-07-21Update git submodulesAndreas Heinisch
* Update helpcontent2 from branch 'master' to 1c52b29e3858fd600a651635d4d4172a4a5d04d9 - tdf#155148 - Reflect the fact that CDbl/Csng is locale dependent Change-Id: I67374217490e3016c20065bf39118de8106549a5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154695 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-07-21Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 0a11014c12d12432e66be19775a44761a8282599 - tdf#149888 Create HID target for Math's main help page This patch creates the target STARMATH_HID_SMA_MAIN_HELP for the main help page of the Math module, which is necessary for a related patch that redirects F1 in the initial window state for the main help page. Change-Id: Ic0a12fc036769355c708e326abd41e607ed06ff0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154692 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-07-21Sync ScriptForge pt.po translationRafael Lima
Change-Id: I67075b3ae5e57b8924e12770d835a83513147da3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154536 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2023-07-21Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to e639a07cb41318324867952f5ef0d81dbda54236 - tdf#151695 Improve documentation on setting PYTHONPATH Change-Id: I7bfb2feea3d76bde6c762073df680d4023c481e4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154610 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2023-07-21loplugin:redundantcast small improvementNoel Grandin
Change-Id: I2c96b367138b94d6178a3c4a0f83049f13a04f82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154679 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-21Assume that all modern X servers have a unified display areaNoel Grandin
Change-Id: I704e6147085b2eca7fc6fd93261aced3e04b2fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154667 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-21Assume that, if we have X11, it supports XineramaNoel Grandin
By now, Xinerama is old enough that we can use the X11 server supports it Change-Id: Ida95902916697808c611a53274b1f0299fd298b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154666 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-21Fix typoAndrea Gelmini
Change-Id: I37e5692fc75089fc889116f86fcb0846be1ba1b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154563 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-21Fix typoAndrea Gelmini
Change-Id: Ied624a73804f99a63b71f9088d6179ad2d93cef6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154564 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-21Removed executable bits on xml fileAndrea Gelmini
Change-Id: I594bcf47eedcb2ee6964ea48f3a4bdffdb0734c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154682 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-21Fix typoAndrea Gelmini
Change-Id: I56dedfc5eb14df5578f0a14a7a47f73d09c23884 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154686 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-21Remove officecfg/util/sanity.xsl check of no valueStephan Bergmann
.xcs <desc> is merely glorified comment syntax by now, and the check had caused unnecessary grief in 3c41b32562d5ccdd306000484c5b16245b2b4a4f "tdf#156308: Restore use of /org.openoffice.Office.Recovery/AutoSave" Change-Id: I1c44836e497e4066766033ffac9b9c39a8f007be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154672 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-07-21tdf#155374 Icons for PageNumberWizardRizal Muttaqin
Change-Id: Iedea46b31a36c7d1d2a3ab539c3ada0b029293c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154675 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-07-21tdf#152992: for Impress/Draw add horizontal hit tolerance for quick text editSarper Akdemir
Implements horizontal hit tolerance for quick text edit in Impress & Draw making it more forgiving. Previously it was required to click exactly on the glyph to get a direct text cursor. Refactors hittestprocessor2d so that it now supports pseudo per axis hit tolerance. i.e. underlying isInEpsilonRange hit check is still the same utilizing the larger tolerance of the two per axis tolerance, but the preliminary check that uses aPolygonRange.grow() and later aPolygonRange.isInside() now filters hit misses out with respect to the per axis hit tolerance. Utilizes hittestprocessor2d's new per axis tolerance to introduce hit tolerance for quick text edit, making it similar to TextEdit mode hit tolerance which only has horizontal tolerance. Fixes wrong use of BoundRect hit to determine text frame border hits. Which previously only made sense for TextFrame borders, and was mostly useless for shapes with text inside. Change-Id: I749e63752da05b01270bfcab2632c41879a848ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154640 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-07-21Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 8dcfe198356b4be518c2de4beb2c2fa92716fed7 - tdf#155884 Fix "Navigate By" target in help Change-Id: Iba81e9b7186ba0803043068694e35f909d833c86 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154625 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-07-21tdf#139306 Incorrect nDecPlaces value after clampingVladislav Tarakanov
nDecPlaces clamping diap changed from +-20 to +-309 and buffer is resized for new value Change-Id: Icb2130891598cf02623bbf5bd0273edab529d124 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153815 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-07-20tdf#156361 use slow blending path if alpha mask blending is diabledPatrick Luby
SkiaSalGraphicsImpl::blendBitmap() fails unexpectedly in the following cases so return false and use the non-Skia alpha mask blending code: - Unexpected white areas when running a slideshow or printing: https://bugs.documentfoundation.org/attachment.cgi?id=188447 - Unexpected scaling of bitmap and/or alpha mask when exporting to PDF: https://bugs.documentfoundation.org/attachment.cgi?id=188498 Change-Id: I13ae613f24bff4cd018110a08ed70559a1714687 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154678 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-07-20tdf#141102 related: Improve names of menu items used to fold andJim Raykowski
unfold outline content including sub level outline content Change-Id: I686b3acdec910a7b6ae11b498eea3e4c01b6ada8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154558 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-07-20tdf#156378 Open function help page on F1 in the Functions sidebarRafael Lima
With this patch, when the user opens the Functions sidebar, select an entry and presses F1, the help page about the selected function will be shown. Change-Id: I37eecc4e325cee7f25ddb1cd81098ca318ce6518 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154617 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-07-20tdf#150302 Fix FontworkSameLetterHeights button in DrawMatt K
This change fixes the Font Work Bar SameLetterHeights button at the bottom of Draw when opening a file without a FontWorkSameLetterHeights property initialied in the XML of the file. The change now applies a default property value which allows the button to properly work and switch the boolean value of property which can then be saved in the XML of the file. Also added a unit test which checks for the correct property value after toggling the button 2 times. The command to run the new unit test is: make CppunitTest_svx_unit CPPUNIT_TEST_NAME=testTdf150302 Change-Id: Id55eaedb625139f0071cdca5f628a0766afab0fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154402 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-07-20Revert "tdf#149401 show "Restart LibreOffice" dialog changing AutoRecovery"Justin Luth
This reverts 7.4 commit 18cc891483fef63ad168273658a30bff72b87a95. The bits are no longer used because all options in this dialog apply immediately, thanks to tdf#65509 and even more so tdf#156308 (which are API changes that won't be backported - so 24.2+ only). I didn't see any other option in this dialog that could have benefitted from a restart request, and the scope of this dialog is rather small, so no value in ignoring the dead code. Change-Id: I3f40421af079fd42c10d6862949279328ef5583b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154669 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-20Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 3e6ed0152d5a8f824a4e1a3066caef1e0ad1be85 - (related) tdf#68565 add "Place backup in same folder as document" option + add new option and description * move position of three options to align with dialog (no content changes for i10n) Change-Id: I99fa9a3ba58dea844cf94dd2653f9aefb4f3d4e0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154468 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-07-20tdf#154990 vcl: PDF export: incorrect checks of annotation struct parentsMichael Stahl
The first form annotation is missing /StructParent. The invalid value is -1, not 0. Typically 0 is the index of the MCIDs entry (m_aMCIDParents) in the ParentTree /Nums, but if there is not a single MCID in the document, this is omitted and 0 may be a valid annotation then. Change-Id: I9885d176eae272d98000f9d9f0ffae82558c0ea0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154668 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-20Added searching and filtering features to certificate chooser dialogTokieSan
Added a new search box in the certificate chooser dialog, introduced local caching for certificates to allow instantaneous filtering and searching. Modified viewing signatures function to allow searching functionality. Change-Id: I361a47da7bd5d24efcbfc17065935851db951c44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154630 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-07-20tdf#143148 Use pragma once in swsahil
Change-Id: Ibb1fc8d8419dd4e1c805134fab3ee91476e5c5ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154662 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-07-20tdf#143148 Use pragma once in vclsahil
Change-Id: I4cf05114c7568d6c7b7ddba1b3c4a862d7a24dce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154656 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-07-20tdf#65509 autosave: apply UserAutoSave without restartingJustin Luth
Now that I know there is a config listener running in AutoRecovery, listen for the config change and apply it immediately instead of requesting the user to do a restart. Change-Id: I69912c0e95c04cc1a5e680d5e8c59b15e94efb05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154664 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-20Simplify a bit by removing a redundant conditionJulien Nabet
line 627 already contains: if( nMaxDigit > nDigitPos ) so here we know that nMaxDigit >= nDigitPos Change-Id: Ia7ed69e19a6567a5947edaa57f687bf97476a616 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154661 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-20split GetWindowExtentsRelative asunderNoel Grandin
sometimes it returns a relative position, sometimes an absolute position. Rather have two different methods with names that match what they return. Change-Id: Ie1e73c6be1c797fd59934c96866d1fef1f972b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-20simplify the operation of ImplGetWindowExtentsRelativeNoel Grandin
instead of inlining OutputToAbsoluteScreenPixel Change-Id: I4914392e6dfb5c1ace7041642fecbaa084cf7626 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154652 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-20remove dead code in ImplDrawFloatwinBorderNoel Grandin
Change-Id: I4f71d7dbf3ae3fbc139f770084dbdea4cbf9b848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154651 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-20no need to return a mutable ref from ImplGetItemEdgeClipRectNoel Grandin
and risk updating internal site. Luckily, all of the current callers are making a local copy Change-Id: I8b85d087ef934b1bb32f5a902a4fbf08659b7511 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154650 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-20tdf#156308 autosave: re-listening to config, no restart requestsJustin Luth
The reason the restart request was added was because of the broken config. Now that the config is correct again, the listener notices the enable change and turns AutoSave on/off immediately. So there is no need to prompt the user to restart after modifying the setting in Tools - Options. Change-Id: I0c775964ce5d9f860b0ce320db86d8db7226a489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154663 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-20tdf#86630 sw page number wizard: add to notebookbar layout tabJustin Luth
I think putting this in layout makes the most sense, since Title page is already there, and these are all page style tasks. The other possible location is Insert. Title page is here also. I'd suggest putting it under Title page, and moving Fields above Section Change-Id: I6f432af3726b44b4fb7554fc73e343959cfe2d0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151398 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-07-19tdf#156372 sw: Stop adding GetLower to every cell in header tableSatya
The code was doubling the lower spacing of the last paragraph in every cell of the table. This change is to not add the space when in tables, since that was intended to only apply to the last paragraph in the header. make CppunitTest_sw_ooxmlexport19 CPPUNIT_TEST_NAME=testTdf156372 Change-Id: Ia8c2b31e3e56302735e858c39f80cc35e190af6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154643 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-19Use correct configurationMike Kaganski
I introduced it in commit 79113484cacb630f93f87c483b6c5d97c47b8728 by mistake, when rebased on 3c41b32562d5ccdd306000484c5b16245b2b4a4f. Change-Id: Ia3ba91cda9e54d9434b6d79bf78afd13f2b20d5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154619 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-19tdf#153115 sw: fix yet another FindPrvNxtFrameNode() issueMichael Stahl
In the SwUndoTextToTable for the middle cell it happens that there is no frame remaining in the cell frame and SwNodes::FindPrvNxtFrameNode() erroneously returns a frame from inside the preceding cell, so it creates the frame in the wrong cell. (regression from commit faf2d9e2cb13c3750ac359338f8f31fc1afce368) Change-Id: I2e4f460541e20dda23c1fafb6d63c023dae9b152 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154654 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-19tdf#153115 sw: SwDoc::TextToTable(), first remove all redlinesMichael Stahl
The problem is that there are redlines that overlap the created table cell nodes. For the writerfilter-import-API TextToTable() that was solved by splitting the redlines, but that would take a lot of effort here as it's not known ahead of time where the cells start and end, so just get rid of the redlines. Another issue is that the temporary SwPaM in DocumentRedlineManager::AcceptRedline() caused ~SwIndexReg() assert. (reportedly regression from commit 471212d464f54054f7419ef1890267d0def852d9) Change-Id: I6b211b6c8e5c7e4bdab1dac858707d7d7fd85029 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154655 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-19ScriptForge (FormDocument) fix tdf#156356 Variable not definedJean-Pierre Ledure
Change-Id: I4bbd4b05ca42ccde4b83eb55a1f1ae80ebca9680 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154592 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2023-07-19add IndexHint -1 for 2 commitEvent methods in accessibilityJulien Nabet
Change-Id: I3a2d4e0935d48e8d7ff57745dc05aa3e85bd0bdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154590 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-19sw: Add test for continuous section breaks not adding page breaksParis Oplopoios
Change-Id: I1dbaa0075ff33012c7cc94f1aa82dd992dd0e680 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154588 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-09 07:20:37 +0000