summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-06-17find-unneeded-includes: show command line in case of IWYU error messagesGabor Kelemen
In case of non self contained files IYYU gives only error messages. Prepare for that and print the failing command for further investigation. Change-Id: I744338ab14d4a6cba5e02f842ff74b156c5178a4 Reviewed-on: https://gerrit.libreoffice.org/74111 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-17loplugin:logexceptionnicely in shell..sotNoel Grandin
Change-Id: I2ae0c0ac06f32ef91951aa4f7c98b5706178f841 Reviewed-on: https://gerrit.libreoffice.org/74115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-17loplugin:logexceptionnicely in sfx2Noel Grandin
Change-Id: Ia638b94a7859c5dddca82111e7cbe753d7dde631 Reviewed-on: https://gerrit.libreoffice.org/74114 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-17loplugin:logexceptionnicely in scripting..sdextNoel Grandin
Change-Id: Ib08f41bb0bed494e7ed00f5bae92eae2b8e80d93 Reviewed-on: https://gerrit.libreoffice.org/74113 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-17tdf#45904 Move XShapeDescriptor Java test to C++Jens Carl
Move XShapeDescriptor Java test to C++ for ScShapeObj. Change-Id: I2d530ea73c6f25e36665db0bd65f734e509d97a6 Reviewed-on: https://gerrit.libreoffice.org/74139 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-17Only call comphelper::getProcessComponentContext() onceMike Kaganski
Also remove useless initialization of eApp right before assigning a value to it. Change-Id: Ie52a280e2b8514870256ba0b7cdd52bd1532c3ac Reviewed-on: https://gerrit.libreoffice.org/74137 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-17android: Unregistering in runLoop() is important even on Android.Jan Holesovsky
Otherwise we get crashes in online Kit when attempting to shutdown reasonably cleanly and the poll kicks in. Change-Id: I9a1744b42fec9f8ffddc6094773bda943caedf2a Reviewed-on: https://gerrit.libreoffice.org/74064 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-16Reload Notebookbar, when customization is being done.Sumit Chauhan
This patch is related to notebookbar customization tab. When one clicks the widget checkbox , to preview the real-time changes one need to call this ReloadNotebookBar() method . Change-Id: I3d6314e4b8220a8744331246639acadea941252f Reviewed-on: https://gerrit.libreoffice.org/73750 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-06-16tdf#105799 Fix vector use bugJim Raykowski
Change-Id: Ibf2b5314584725a10e11fe83e9fef5c710e421c4 Reviewed-on: https://gerrit.libreoffice.org/73937 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-06-16tdf#121486: Correct scale of broken fonts on WindowsKhaled Hosny
Some fonts have negative tmAveCharWidth which makes no sense (fonts can't have negative glyph width, so the average can't be negative) and it would cause our code to apply negative scale to the glyphs of these fonts making them drawn on the flipped horizontally. Fix this by using the absolute value so it is always positive. Change-Id: I731e7aad80dae734847679a1b08c6ac78111e16c Reviewed-on: https://gerrit.libreoffice.org/74109 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2019-06-16crashtesting: failure on export to odt of ooo33851-1.sxwCaolán McNamara
since... commit 79d58ee14da8fbf636fb087453834abb7173d3fc Date: Sun May 12 16:07:58 2019 +0300 Simplify Sequence iterations in xmloff/source/{style..xforms} Use range-based loops or replace with comphelper or STL functions Change-Id: I0e00ea30a45d0ba3aa00fcb20b80fdc4931fe14d Reviewed-on: https://gerrit.libreoffice.org/74116 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-16tdf#92083 Move Color bar item from View->Toolbars Roman Kuznetsov
to View menu in Draw/Impress Change-Id: Ie25d34b07d381775274a79e4a0b71e7a96eb6119 Reviewed-on: https://gerrit.libreoffice.org/74024 Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com> Tested-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2019-06-16loplugin:logexceptionnicely in filter..frameworkNoel Grandin
Change-Id: I8cf70ee278c641767e3fcfcfd151d99d791b3468 Reviewed-on: https://gerrit.libreoffice.org/74098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-16tdf#117857 fix to work "add Korean Ruby script"DaeHyun Sung
fix to work "add Korean Ruby script" on "Hangul-Hanja" Conversion dialog UI. add "group" property of the GtkRadioButton object "simpleconversion" Change-Id: I0ca3028a84c1c8386640fd97d9ed1fb5635c8423 Reviewed-on: https://gerrit.libreoffice.org/74105 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-06-16Add predefined targets to auto redactionMuhammet Kara
Change-Id: Ib8cf8b50944667d6a87a5cafb6995ad195699358 Reviewed-on: https://gerrit.libreoffice.org/74092 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-15Removed duplicated includeAndrea Gelmini
Change-Id: I9054caf8ae1ed5833399de1f749c82ac367b5dd9 Reviewed-on: https://gerrit.libreoffice.org/74106 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-15loplugin:logexceptionnicely in scNoel Grandin
Change-Id: Icaa476206312a5f81896f59fa8109448a8ea8963 Reviewed-on: https://gerrit.libreoffice.org/74101 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-15loplugin:logexceptionnicely in package..reportdesignNoel Grandin
Change-Id: Ib5438d346fa95299848aaf2144e54f5551c0a906 Reviewed-on: https://gerrit.libreoffice.org/74100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-15loplugin:logexceptionnicely in linguistic..ooxNoel Grandin
Change-Id: I3f96494f5fecb2f1011578b768198c1204147202 Reviewed-on: https://gerrit.libreoffice.org/74099 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-15sifr: Rename icon toolsmacroedit to basicideappearJens Carl
The icon isn't needed at two places anymore and it's a follow up of daba09df247c09db715ca86a6b78365e49bfe034, which removed the menu entry toolsmacroedit. Also clean the links.txt file. Change-Id: If9a8a85733fb7994d22e31c2a591b1e4943e16a0 Reviewed-on: https://gerrit.libreoffice.org/74012 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-15breeze: Rename icon toolsmacroedit to basicideappearJens Carl
The icon isn't needed at two places anymore and it's follow-up of daba09df247c09db715ca86a6b78365e49bfe034, which remove the menu entry toolsmacroedit. Also clean the links.txt file. Change-Id: I0275b66d37297cb0c1996654a8ea16bcd31f3d17 Reviewed-on: https://gerrit.libreoffice.org/74011 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#125891 Add Help for "harpoon" math attributes Add new svg icons refactor svg for better rendering Increase size of svg displayed in Help page Contents for harpoon and wideharpoon attibutes Change-Id: I5967fdf21270be88d1179bf130cfdc0ea1f2ee39 Reviewed-on: https://gerrit.libreoffice.org/73998 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-06-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#113131 Clarify Next Style for paragraphs. Change-Id: If83c6c65cced2a8623a7192f9bd1dbe1981f56df Reviewed-on: https://gerrit.libreoffice.org/73981 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-06-15tdf#125934 Qt5 set the desktop file nameJan-Marek Glogowski
This is a preliminary fix, so LO on Wayland has an application icon at all. As the result, the start center icon will appear as the application icon on Wayland for all windows. For the proper, per QWindow fix, we need some QtCore and QtWayland changes, to allow setting the appId per QWindow and eventually a Waylnad XDG shell spec update, to officially allow a top level window to change its appId. Change-Id: Icefcfc992836e0c657237984d7d88561b26b06a2 Reviewed-on: https://gerrit.libreoffice.org/74097 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-15Fix typoAndrea Gelmini
Change-Id: I834039e8030857e1069bbadb9c7ef85664702168 Reviewed-on: https://gerrit.libreoffice.org/74094 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-15Fix typoAndrea Gelmini
Change-Id: I27a00608a5dba9fc467c61d5919233972b293811 Reviewed-on: https://gerrit.libreoffice.org/74093 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-15loplugin:logexceptionnicely in editeng..extensionsNoel Grandin
Change-Id: I50b9d7e92ef057c985d0d6e76dfeb62591d404f6 Reviewed-on: https://gerrit.libreoffice.org/74047 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-15loplugin:logexceptionnicely in desktopNoel Grandin
Change-Id: I19f70b0e9d1ca2bbcd2595af24f2e15766d14b33 Reviewed-on: https://gerrit.libreoffice.org/74046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-15loplugin:logexceptionnicely in dbaccessNoel Grandin
Change-Id: I2d702b699c2e61dbb363eff671bb43d4ddbf8ee3 Reviewed-on: https://gerrit.libreoffice.org/74045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-15loplugin:logexceptionnicely in cuiNoel Grandin
Change-Id: I0a3186b7f6d28725aff0e73d8f2cc4d5bc259a92 Reviewed-on: https://gerrit.libreoffice.org/74044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-15Qt5 move and init static m_ActiveDragSourceJan-Marek Glogowski
Change-Id: Iab82151b8d1a8281c9999983b9de5f35dfb0442e Reviewed-on: https://gerrit.libreoffice.org/74013 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-15check-elf-dynamic-objects: Update 'qt5whitelist'Michael Weghorn
This needs 'libgobject-2.0.so.0' and 'libxcb.so.1' as well now, since a6201725d760cbce832d4de029b418bb7334df6a ("Don't link avmediagst with gtk3 and qt5") and 77a3c443d35c7d966217f02ea9189cb1819c7828 ("tdf#125921 Qt5 set WM_CLASS for top level windows"). Change-Id: I453cede879eda8470a45c48f789a0419866fcb79 Reviewed-on: https://gerrit.libreoffice.org/74085 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-06-15Avoid -fsanitize=float-divide-by-zeroStephan Bergmann
...when loading xls/tdf117254-4.xls as obtained by bin/get-bugzilla-attachments-by-mimetype (i.e., the attachment at <https://bugs.documentfoundation.org/show_bug.cgi?id=117254#c5>): > chart2/source/tools/PolynomialRegressionCurveCalculator.cxx:189:32: runtime error: division by zero > #0 in chart::PolynomialRegressionCurveCalculator::recalculateRegression(com::sun::star::uno::Sequence<double> const&, com::sun::star::uno::Sequence<double> const&) at chart2/source/tools/PolynomialRegressionCurveCalculator.cxx:189:32 > #1 in chart::VSeriesPlotter::createRegressionCurvesShapes(chart::VDataSeries const&, com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, bool) at chart2/source/view/charttypes/VSeriesPlotter.cxx:1343:22 > #2 in chart::AreaChart::impl_createSeriesShapes() at chart2/source/view/charttypes/AreaChart.cxx:539:17 > #3 in chart::AreaChart::createShapes() at chart2/source/view/charttypes/AreaChart.cxx:965:5 > #4 in chart::ChartView::impl_createDiagramAndContent(chart::CreateShapeParam2D const&, com::sun::star::awt::Size const&) at chart2/source/view/main/ChartView.cxx:1608:25 > #5 in chart::ChartView::createShapes2D(com::sun::star::awt::Size const&) at chart2/source/view/main/ChartView.cxx:3037:41 > #6 in chart::ChartView::createShapes() at chart2/source/view/main/ChartView.cxx:2506:5 [...] Leaving aRSquared initialized to 0.0 when the divisor is zero is in line with the code prior to 00cb825ab3f16a94f1e8311ba0c24f72588e788e "fdo#75538 R^2 calculation for trendline similar to LINEST function" and with the recent nearby change f44d14e5f3909a4271034ba02da92ed2dee7b89c "Avoid -fsanitize=float-divide-by-zero". Change-Id: If2c17ad178788982729f647b4c695d3788fad500 Reviewed-on: https://gerrit.libreoffice.org/74068 Tested-by: Jenkins Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-15fix copy/paste mistake in TOOLS_INFO_EXCEPTIONNoel Grandin
Change-Id: I209efe41639eeff215b876cb1da5c9a8252f4b55 Reviewed-on: https://gerrit.libreoffice.org/74042 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-15Fix typoAndrea Gelmini
Change-Id: I16f502fd3365f8db330c4228e44924c03ef227c1 Reviewed-on: https://gerrit.libreoffice.org/74077 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-15Fix typoAndrea Gelmini
Change-Id: Ic0b38891daf699f232a7dbc1378e30c53289d067 Reviewed-on: https://gerrit.libreoffice.org/74076 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-15Fix typoAndrea Gelmini
Change-Id: I0ce4ed9eec22de1f96a42b4b907a753478ca9805 Reviewed-on: https://gerrit.libreoffice.org/74079 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-15Fix typoAndrea Gelmini
Change-Id: I55458141b212c0c2ed4b67d773a5cee6ff10cc18 Reviewed-on: https://gerrit.libreoffice.org/74078 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-15tdf#125921 Qt5 set WM_CLASS for top level windowsJan-Marek Glogowski
Uses the same naming then the gtk3 backend, i.e. "libreoffice" for the instance name and different class names for the module windows, like "libreoffice-writer". These names are referenced in the desktop files a StartupWMClass and for example used to pin an app to the task bar. Change-Id: Ic9b8890536f6413ab59d2e0da866e2280ab3181a Reviewed-on: https://gerrit.libreoffice.org/74014 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-15tdf#125748 Only execute frame interactions in presentation modeSamuel Mehrbrodt
Executing interactions while in edit mode makes editing very hard since you can only hardly select the frame without executing the interaction. Change-Id: I102dac0ff840a914bd6e21ddb047b2df5e278c6f Reviewed-on: https://gerrit.libreoffice.org/73640 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-06-14Resolves: tdf#124251 do not treat internal "URI" as real path URIEike Rathke
Change-Id: I754704b0a979e8449b7ec799cbda58b14ab17098 Reviewed-on: https://gerrit.libreoffice.org/74067 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-06-14tdf#88287 Change toolbars attributes in DrawRoman Kuznetsov
The tooltip for .uno:LineToolbox changed to 'Curves and Polygons' The toolbar title of linesbar.xml changed to 'Curves and Polygons' The Arrows toolbar (arrowsbar.xml) removed from View > Toolbars The toolbar title of arrowsbar.xml changed to 'Lines and Arrows' Change-Id: Ic97c7a11f071a4f424a341e297423dba2ddc345a Reviewed-on: https://gerrit.libreoffice.org/69335 Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com> Tested-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2019-06-14tdf#125774 Remove double call SvTreeListBox::Select for non-gtk backendsGülşah Köse
Change-Id: Ic8238d91f1cddb8fe627fafb0587751de308f6ac Reviewed-on: https://gerrit.libreoffice.org/73747 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-06-14Avoid -fsanitize=float-divide-by-zeroStephan Bergmann
...as happens with `--convert-to pdf xls/rhbz499466-2.xls` with xls/rhbz499466-2.xls as obtained by bin/get-bugzilla-attachments-by-mimetype (i.e., the attachment at <https://bugzilla.redhat.com/show_bug.cgi?id=499466#c1>): > chart2/source/tools/PolynomialRegressionCurveCalculator.cxx:73:14: runtime error: division by zero > #0 in chart::PolynomialRegressionCurveCalculator::recalculateRegression(com::sun::star::uno::Sequence<double> const&, com::sun::star::uno::Sequence<double> const&) at chart2/source/tools/PolynomialRegressionCurveCalculator.cxx:73:14 > #1 in chart::VSeriesPlotter::createRegressionCurvesShapes(chart::VDataSeries const&, com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, bool) at chart2/source/view/charttypes/VSeriesPlotter.cxx:1341:22 > #2 in chart::AreaChart::impl_createSeriesShapes() at chart2/source/view/charttypes/AreaChart.cxx:539:17 > #3 in chart::AreaChart::createShapes() at chart2/source/view/charttypes/AreaChart.cxx:965:5 > #4 in chart::ChartView::impl_createDiagramAndContent(chart::CreateShapeParam2D const&, com::sun::star::awt::Size const&) at chart2/source/view/main/ChartView.cxx:1608:25 > #5 in chart::ChartView::createShapes2D(com::sun::star::awt::Size const&) at chart2/source/view/main/ChartView.cxx:3037:41 [...] Change-Id: I1ef70aa90256a5fcc84151d869d8ffc6acfbbb0e Reviewed-on: https://gerrit.libreoffice.org/74055 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-14mpViewWindow is always null nowCaolán McNamara
Change-Id: I4ede367b79943b222d3607bcf8fe3468f1bc8395 Reviewed-on: https://gerrit.libreoffice.org/74053 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-14remove some unused includesCaolán McNamara
Change-Id: I1a3512fd7fd50379ecd25389a894c2a3aadb7edb Reviewed-on: https://gerrit.libreoffice.org/74035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-14lok: avoid locking table when ScSpecialFilterDlg is destroyedHenry Castro
ScSpecialFilterDlg by default does not lock the table, but in tiled rendering case, switching sheets are locked when the dialog is closed Thanks Michael Meeks for debugging Change-Id: Ifa32fd63085f3e082b97ad0313dff7b826b95d2e Reviewed-on: https://gerrit.libreoffice.org/72074 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit c5457de07e9d6e6a202f577067cf2a0f904bfcd0) Reviewed-on: https://gerrit.libreoffice.org/72096 Tested-by: Jenkins
2019-06-14Transition sidebar: Apply the transition duration right away.Jan Holesovsky
In the desktop version, the value that is entered there always ends up applied. In the Online, there was a scenario when it did not: enter a value and switch slide by clicking the slide sorter. There is no harm to apply the value right away when the user edits, because in the desktop version, there was no way to avoid applying the value anyway. Change-Id: I519423d60f682735aeb1d471b3397ff9671c15fd Reviewed-on: https://gerrit.libreoffice.org/72924 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins
2019-06-14Use utl::TextSearch in the auto redaction processMuhammet Kara
* Add support for: * Case sensitive and insensitive text search * Regex search (always case sensitive) regarless of the choice * Multiple occurences of the same target on a single TEXTARRAY Change-Id: I580059f77286e8c4226cafdd1eb9472f8e1a9a9d Reviewed-on: https://gerrit.libreoffice.org/74049 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-14KDE5 move screensafer inhibiting code into Qt5Jan-Marek Glogowski
There will presumably be more X11 specific code later to implement some "fix" for tdf#119202. Moving the screensafer inhibitor is rather uncontroversial in comparion, so start with it and use it to carry the matching configure.ac changes. A little "nightmare" are all the clashing X11 / Qt type undefs, but I couldn't find a better solution while the inhibitor continues to include the X11 headers in it's header. Change-Id: I55c89c76726d30a890178488484e954207267e89 Reviewed-on: https://gerrit.libreoffice.org/74015 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
generated by cgit (git 2.34.1) at 2024-12-29 01:04:24 +0000