summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-10-10we throw away the original of the cloneCaolán McNamara
so we can take ownership of the original instead Change-Id: I2399aa77b22e606008a5aed2bc73361e13b68455 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-10ofz#23492 the only user of this ctor throws away the original of the cloneCaolán McNamara
so we can take ownership of the original instead Change-Id: I26fd4303a3b205df309f91bfa5bcddbbc41dfd7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104173 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-10ofz#23505 31 seconds -> 12 secondsCaolán McNamara
Change-Id: Ib26f03bb308e4b96a0647ca3a81288b6cce5a767 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104133 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-10cid#1467975 Logically dead codeCaolán McNamara
Change-Id: I6d226c696fd6100c61f7233d42d17f1858fe66d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-10cid#1467976 Dereference after null checkCaolán McNamara
Change-Id: I84a4cc6b26bd40888d7fca6a1974a8720a6179f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104170 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-10cid#1467974 Dereference before null checkCaolán McNamara
Change-Id: Ic612cb420934764c42cca08d09915bdc8332cb2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-10Resolves: tdf#137370 Re-enable UI translated standard cell style namesEike Rathke
Regression from style rework commit 7b0aed617f1e57335837cf56ef2d222a96f8270d CommitDate: Wed Sep 28 11:42:56 2016 +0000 Remove old cell styles from calc to commit 06f319937187f76ee402d53b3baa78c391c2af19 CommitDate: Sun Oct 2 13:51:26 2016 +0000 tdf#90937 Add a set of cell styles to calc Change-Id: I34dddb3ca3e54e3da5db112e1f9bcc8437fbda77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104141 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-10-10ofz#21753 avoid unproductive timeoutCaolán McNamara
Change-Id: I7ce4471e68cf0e36a1951c4d4e318d6389eff8c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104134 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-10tdf#129935 improve accelerator key choices for Edit Fields dialogSeth Chaiklin
- original problem was that OK and Format had same accelerator key 'o' - changed other "doubled" accelerator keys - added accelerator key for 'Level' in Document Field - make consistency across the different Edit dialogs. Change-Id: I55e166a907714bcf451e9e060ded3c08d84abf61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104148 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-10-10tdf#87963: Add percentage value to new calculated compressed image sizeDaniel
Change-Id: I8e9029c2fee2a42501e580737a453ad3f90eac1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104138 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-10Improve example python code in scripting.Kevin Suo
* Modified the code to be more pythonic. * If "len(theString) == 0", then "not theString" evaluates to True. * "theString[0].isupper()" and "theString[1].isupper()" can be combined. * Remove unused imported string module * Wrap long lines * run autopep8 to prettify * ... Change-Id: Ic8aaa0728a43936cd4c6e1ed590e01ba8f0fbf5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104136 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-10-10tdf#132289 missing styles when inserting file with listSerge Krot
Change-Id: I444997a6cc55cfe287f4c610f538f2f54803646c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104085 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-10-10Replace list by vectorJulien Nabet
Change-Id: I890653de84250e66258bde1baa22e1e2cb5b20ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104139 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-10-09Added optional parameter Enabled for uno:SpellOnlineMert Tumer
Change-Id: I3578b0a002ea2cdcc7893972607f26732ce545ea Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103982 Tested-by: Jenkins
2020-10-09Fix typoAndrea Gelmini
Change-Id: I25b9d697de27d9d4222a0e0e59f28f8a3457b469 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104075 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-10-09inherit OStringTransferable from TransferDataContainerCaolán McNamara
so it can be used as an argument to weld: :CustomWeld::SetDragDataTransferrable Change-Id: Ibb58be6871a8719504d33d02bf7104213105be99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09Fix typoAndrea Gelmini
Change-Id: If4d4a00e8804dfb6a82476a549520c1db29fca10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104042 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-10-09Removed executable bits on odt fileAndrea Gelmini
Change-Id: Ia63a23313b46b728d87ce0f13cbe7aed592e557c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104026 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-10-09CppunitTest_sw_layoutwriter: split this into twoMiklos Vajna
Fixes: C:\lo\master\sw\qa\extras\layout\layout.cxx : fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj Change-Id: Iae6d872ba0c0283bcff3971df8a6bab1122a073c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104121 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-09EditView->GetWindow()->GetClipboard() is the same as GetSystemClipboard()Caolán McNamara
so we don't really need the intermediate vcl::Window to get that Change-Id: I5fa449e46c2226f0fb84f2e230e328c4da5472ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104125 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09EditView may not have a WindowCaolán McNamara
Change-Id: I0b1a87bab8fbabd24962efd6d42e12a2c922de54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104124 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09tdf#136955 DOCX import: fix shape paragraph marginsLászló Németh
based on bad style inheritance, in the case of not first paragraphs of shapes. Regression from commit dc0300eac3b755bc207cd1fe87217f4ebaeb9f58 (tdf#118521 DOCX import: fix paragraph margin from paragraph style), revealing the problematic m_sCurrentParaStyleName, see also commit 8920d865ee148518bf71f71ce1866b24cc17c07e for more information. Follow-up of commit c04ee66c7cfeb725d637b0f9ec3e3b1f8776bfe9 (tdf#134784 DOCX import: fix shape paragraph margins). Change-Id: I4feab19fc58653d829d7a1ae8da3e3ce4fb3e2c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104116 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-09Enable building for WSL (Linux) on WSLTor Lillqvist
Change-Id: I47a81a730735ff8c315a57a78c418da2b771e838 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104123 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-10-09Revert "tdf#136728 : sw_uiwriter: Add unittest"Stephan Bergmann
This reverts commit 1da5f05be97b2cf4fa59adff6a77bdb70927202b. It not only failed on Windows (for reasons that have apparently been left unidentified and been worked around with a #if !defined(_WIN32) // FIXME: For some reason, jenkins win build hangs here instead), but also caused CppunitTest_sw_uiwriter to livelock with an ever growing > [...] > warn:vcl.schedule:1999952:1999952:vcl/source/app/svapp.cxx:469: ProcessEventsToIdle: 197000 > warn:vcl.schedule:1999952:1999952:vcl/source/app/svapp.cxx:469: ProcessEventsToIdle: 198000 > warn:vcl.schedule:1999952:1999952:vcl/source/app/svapp.cxx:469: ProcessEventsToIdle: 199000 > warn:vcl.schedule:1999952:1999952:vcl/source/app/svapp.cxx:469: ProcessEventsToIdle: 200000 > warn:vcl.schedule:1999952:1999952:vcl/source/app/svapp.cxx:469: ProcessEventsToIdle: 201000 > warn:vcl.schedule:1999952:1999952:vcl/source/app/svapp.cxx:469: ProcessEventsToIdle: 202000 > warn:vcl.schedule:1999952:1999952:vcl/source/app/svapp.cxx:469: ProcessEventsToIdle: 203000 > warn:vcl.schedule:1999952:1999952:vcl/source/app/svapp.cxx:469: ProcessEventsToIdle: 204000 > warn:vcl.schedule:1999952:1999952:vcl/source/app/svapp.cxx:469: ProcessEventsToIdle: 205000 > warn:vcl.schedule:1999952:1999952:vcl/source/app/svapp.cxx:469: ProcessEventsToIdle: 206000 > warn:vcl.schedule:1999952:1999952:vcl/source/app/svapp.cxx:469: ProcessEventsToIdle: 207000 > warn:vcl.schedule:1999952:1999952:vcl/source/app/svapp.cxx:469: ProcessEventsToIdle: 208000 > [...] in (slow) Linux ASan+UBSan builds, see the comments at <https://gerrit.libreoffice.org/c/core/+/103774/ 5#message-06686b4d0405e60dd1841e67d32e5e1bd1e37b2b> and <https://gerrit.libreoffice.org/c/core/+/103774/5 #message-83d13c67c69236f3f6eb889410b22c8eaef37123> "tdf#136728 : sw_uiwriter: Add unittest". So until the underlying issue has been identified and solved, temporarily remove the test again to get builds unstuck. Change-Id: I98ad59f5db7b744cadc5051c8e7daf79542a1787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103986 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-09Adapt solenv/gdb/ to old PythonStephan Bergmann
After 4a899a5f8a72ea29a6919316afe3627de9f33e95 "Fix Python deprecation warnings"e.g. <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/70542/console> started to complain > Traceback (most recent call last): > File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/instdir/program/libuno_sal.so.3-gdb.py", line 23, in <module> > module = importlib.import_module('libreoffice.' + mod) > File "/usr/lib64/python2.7/importlib/__init__.py", line 37, in import_module > __import__(name) > File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/solenv/gdb/libreoffice/sal.py", line 14, in <module> > from libreoffice.util import printing > File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/solenv/gdb/libreoffice/util/printing.py", line 10, in <module> > from collections.abc import Mapping > ImportError: No module named abc etc. when lode's bin/kill-wrapper calls gdb to obtain backtraces of hung processes. Change-Id: I4fe6c6fa97bbb455a071dd28e5c1ab33f2337a0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104119 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-09Split off REAL_BUILD_CC_FLAGS from REAL_BUILD_CCStephan Bergmann
...same as is done with REAL_CC and REAL_CC_FLAGS in solenv/gbuild/platform/com_MSC_class.mk. Otherwise, my clang-cl build (where CC and those REAL*_CC vars derived from it contains the executable plus a bunch of command line arguments) would fail in ExternalProject_libgpg-error with > Error: could not create process ""C:/llvm/inst/bin/clang.exe --driver-mode=cl -FIIntrin.h -fmsc-version=1927 -Qunused-arguments --target=x86_64-pc-windows-mscv -fansi-escape-codes -fcolor-diagnostics -ferror-limit=0" -nologo -EHsc -MDd -Gy -Ob1 -Oxs -Oy- -IC:/lo-clang/core/include -IC:/PROGRA~2/WI3CF2~1/10/Include/10.0.18362.0/ucrt -IC:/PROGRA~2/WI3CF2~1/10/include -IC:/PROGRA~2/MIB055~1/2019/COMMUN~1/VC/Tools/MSVC/1427~1.291/Include -IC:/PROGRA~2/WI3CF2~1/10/Include/10.0.18362.0/um -IC:/PROGRA~2/WI3CF2~1/10/Include/10.0.18362.0/shared -IC:/java/ADOPTO~1.NET/x64/JDK-15~1/include/win32 -IC:/java/ADOPTO~1.NET/x64/JDK-15~1/include -Zi -FS -I. -I. -Femkheader.exe ./mkheader.c -link -debug -LIBPATH:. -LIBPATH:C:/java/ADOPTO~1.NET/x64/JDK-15~1/lib -LIBPATH:C:/PROGRA~2/MIB055~1/2019/COMMUN~1/VC/Tools/MSVC/1427~1.291/lib/x64 -LIBPATH:C:/PROGRA~2/WI3CF2~1/10/lib/x64 -LIBPATH:C:/PROGRA~2/WI3CF2~1/10/lib/10.0.18362.0/um/x64 -LIBPATH:C:/PROGRA~2/WI3CF2~1/10/lib/10.0.18362.0/ucrt/x64 -LIBPATH:C:/PROGRA~2/WI3CF2~1/NETFXSDK/4.8//Lib/um/x64": 2 Change-Id: I7246377874d89d3c0c9bf1c7951d29b7e3ae674a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104118 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-09ofz: Invalid-enum-valueCaolán McNamara
Change-Id: I31cbefcc7a759a266a34d30bd950d707feedcdfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104117 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09tdf#130314 fix incorrect logic in last commitMark Hung
Previous commit ( ac76f9e8ad8b ) contains a logical mistake. Change && to || there. Change-Id: Id982ce6f22b0022316b564029f813da9072b71e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104089 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2020-10-09ofz: Invalid-enum-valueCaolán McNamara
extend commit 9d1c8e66f7020fa0150b23bd450e514f848bd20b Date: Tue Apr 5 12:35:54 2016 +0200 UBSan: Restrict BorderWidthType values to valid range on input to the other assignment to m_eRightType Change-Id: I712a16974e25d3cc48ecfc223a84264ef4bf1642 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104107 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09Be more verbose why gcc-wrapper could not create processStephan Bergmann
Change-Id: I34f4209f1b830060a22ae38c05fe8a8e771c8f41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104111 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-09ofz: Invalid-enum-valueCaolán McNamara
Change-Id: Ia02e2decc29e0ad9e1eab0cad121b086bf8c07c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09ofz: Invalid-enum-valueCaolán McNamara
Change-Id: I0e96e3f9efb82aedbe9c580b0798bb9b6a7abe5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104106 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09ofz: Invalid-enum-valueCaolán McNamara
on examining the oss-fuzz stats I see this one as... "Created: Dec 15, 2019", "Reliably Reproduces: YES", but no bug auto-filed for it Change-Id: I1ddd61db2f2317827c00d601d0db513c4511f018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104105 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09ofz: Invalid-enum-valueCaolán McNamara
Change-Id: Ib604edbb62b5d6e7caa5aa444ee6d64611b9cf60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104110 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09ofz: Invalid-enum-valueCaolán McNamara
Change-Id: Ic1408ba7cf776dbf4923b8c9cef50bbd7fe94bdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104108 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09cid#1467972 silence Unchecked return valueCaolán McNamara
Change-Id: If00d4124fd2320dc793426c708367074eab52c6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104103 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09cid#1467971 Uninitialized scalar fieldCaolán McNamara
Change-Id: I3995a0113046591c136b4b2d2945416e41fe4f0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104102 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-0932bpp SKIA_USE_BITMAP32 bitmaps always need kPremul_SkAlphaTypeLuboš Luňák
I'm not sure if kOpaque_SkAlphaType would guarantee 255 in the alpha, so better be safe. This should be a rare case anyway. Change-Id: Iadec97a83621403a56f62ac07e238d8e98a3a905 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104090 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-09Clean-up: Initialized a variable to something.Attila Szűcs
To make sure it will have a legal value, even in cases when it won't be used. Without it, code analysing tools may idetify it as an issue. Change-Id: Ied6e6c8ca496aa9d61eeca0c45b2c6cec40c9156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104091 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-09tdf#99810 DOCX export: fix lost arrow shapeRegényi Balázs
by saving connector shape as shape element wps:wps instead of the invalid wps:cxnSp. Co-author-by: Szabolcs Tóth Change-Id: I0ed435eff8e4284f04f71f8fa8c1dc4cfbee5af9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104032 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-09Allow CXX_X86_BINARY to be passed into autogen.sh againStephan Bergmann
...after 114ed73a7ba56e013e6d7f886798915fb20c0946 "WIN drop --enable-64bit to select Windows target" had broken a6c22d4e086957b743a135163c71ac233062619e "Allow CXX_X86_BINARY to be passed into autogen.sh" (and see the commit message of the latter commit for how this is used by builds with clang-cl) Change-Id: I7247e41a77d4f65ccae4e0ee522792646068e7b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104101 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-09tdf#133037 OOXML shape import: camera rotation along ZDaniel Arato (NISZ)
Instead of implementing proper OOXML 3D rotation (which would be an entirely new feature if I understand correctly), I merely interpret attribute "rev" of the rotation element a:camera/a:rot as a directive to rotate the entire shape the usual 2D way. That is already implemented and works well. This isn't the same thing Word does, but it might be good enough for now. This is kind of a mock solution, but it will be very easy to revert if it turns out to cause problems. Note: the export worked well previously, too (moreover, reloading the first LO export fixed the import). Change-Id: I2a99c119880bbed1c5b6430c4638cfbd10b7ac06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103627 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-09tdf#134978 Chart OOXML Import: fix pie chart label custom positionTünde Tóth
Follow-up of commit dff7a46fb46d1fa2a3ad674ee493ae2d59150fe3 (tdf#130032 Chart OOXML Import: fix data label custom position). Change-Id: Iaaf4ae654ac0c1b4896a53be6034e6c027412df0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102981 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-09vcl: PDFiumLibrary: add PDFiumDocument::getFileVersion()Miklos Vajna
Allows not exposing the underlying FPDF_DOCUMENT in PDFiumDocument. Change-Id: Icff455af406405aff9099e950c26ce824517b57a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104097 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-09tdf#134286: fix pre-commit hook to make hooks.allownonascii workShiro Kawai
Even if hooks.allownonascii is set to true, the current code compares "true\n" vs "true" and always rejects committing. Change-Id: I75494f149db2537ad54230dd684f5dac9b43c8b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97213 Tested-by: Takeshi Abe <tabe@fixedpoint.jp> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2020-10-09tdf#137205 sc: autofill date sequences in merged cellsAttila Szűcs
Improve FillAnalyse to discover and continue linear sequences of dates with the only differences of months or years in merged cells by skipping the empty overlapped cells of the merged area. Follow-up of commit Ib431e8968f5d71e321b0e57cfb173534a0f5da31 (tdf#88782 sc: autofill number sequences in merged cells) Co-authored-by: Tibor Nagy (NISZ) Change-Id: I1e37efd34858f53691bf867ebefc2fe26e39e676 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103967 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-08Don't needlessly convert to sal_Int32 instead of longStephan Bergmann
...(where the tools::Rectangle ctor takes arguments of type long), as that caused CppunitTest_sc_jumbosheets_test ScFiltersTest::testTdf134392 to fail now with UBSan with float-cast-overflow at > svx/source/sdr/overlay/overlaymanager.cxx:294:44: runtime error: 7.22475e+09 is outside the range of representable values of type 'int' > #0 in sdr::overlay::OverlayManager::RangeToInvalidateRectangle(basegfx::B2DRange const&) const at svx/source/sdr/overlay/overlaymanager.cxx:294:44 (instdir/program/libsvxcorelo.so +0x5477e54) > #1 in sdr::overlay::OverlayManager::invalidateRange(basegfx::B2DRange const&) at svx/source/sdr/overlay/overlaymanager.cxx:314:55 (instdir/program/libsvxcorelo.so +0x5478773) > #2 in sdr::overlay::OverlayManager::impApplyRemoveActions(sdr::overlay::OverlayObject&) at svx/source/sdr/overlay/overlaymanager.cxx:186:13 (instdir/program/libsvxcorelo.so +0x5475566) > #3 in sdr::overlay::OverlayManager::~OverlayManager() at svx/source/sdr/overlay/overlaymanager.cxx:224:21 (instdir/program/libsvxcorelo.so +0x547627c) > #4 in sdr::overlay::OverlayManagerBuffered::~OverlayManagerBuffered() at svx/source/sdr/overlay/overlaymanagerbuffered.cxx:377:9 (instdir/program/libsvxcorelo.so +0x5423e27) > #5 in sdr::overlay::OverlayManagerBuffered::~OverlayManagerBuffered() at svx/source/sdr/overlay/overlaymanagerbuffered.cxx:368:9 (instdir/program/libsvxcorelo.so +0x5423ebb) > #6 in salhelper::SimpleReferenceObject::release() at include/salhelper/simplereferenceobject.hxx:72:49 (instdir/program/libsvxcorelo.so +0x4b748a8) > #7 in rtl::Reference<sdr::overlay::OverlayManager>::clear() at include/rtl/ref.hxx:180:19 (instdir/program/libsvxcorelo.so +0x56c643e) > #8 in SdrPaintWindow::~SdrPaintWindow() at svx/source/svdraw/sdrpaintwindow.cxx:251:22 (instdir/program/libsvxcorelo.so +0x56c3419) > #9 in std::default_delete<SdrPaintWindow>::operator()(SdrPaintWindow*) const at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/unique_ptr.h:85:2 (instdir/program/libsvxcorelo.so +0x64932ff) > #10 in std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> >::~unique_ptr() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/unique_ptr.h:361:4 (instdir/program/libsvxcorelo.so +0x647f81f) > #11 in void std::destroy_at<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> > >(std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> >*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/stl_construct.h:88:15 (instdir/program/libsvxcorelo.so +0x6487c73) > #12 in void std::allocator_traits<std::allocator<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> > > >::destroy<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> > >(std::allocator<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> > >&, std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> >*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/alloc_traits.h:533:4 (instdir/program/libsvxcorelo.so +0x648fb80) > #13 in std::__cxx1998::vector<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> >, std::allocator<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> > > >::_M_erase(__gnu_cxx::__normal_iterator<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> >*, std::__cxx1998::vector<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> >, std::allocator<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> > > > >) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/vector.tcc:177:7 (instdir/program/libsvxcorelo.so +0x648ea5f) > #14 in std::__cxx1998::vector<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> >, std::allocator<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> > > >::erase(__gnu_cxx::__normal_iterator<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> > const*, std::__cxx1998::vector<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> >, std::allocator<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> > > > >) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/stl_vector.h:1431:16 (instdir/program/libsvxcorelo.so +0x648dea0) > #15 in std::__debug::vector<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> >, std::allocator<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> > > >::erase(__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> > const*, std::__cxx1998::vector<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> >, std::allocator<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> > > > >, std::__debug::vector<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> >, std::allocator<std::unique_ptr<SdrPaintWindow, std::default_delete<SdrPaintWindow> > > >, std::random_access_iterator_tag>) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/debug/vector:675:32 (instdir/program/libsvxcorelo.so +0x647dc34) > #16 in SdrPaintView::DeletePaintWindow(SdrPaintWindow&) at svx/source/svdraw/svdpntv.cxx:83:24 (instdir/program/libsvxcorelo.so +0x645cf57) > #17 in SdrPaintView::DeleteWindowFromPaintView(OutputDevice*) at svx/source/svdraw/svdpntv.cxx:404:9 (instdir/program/libsvxcorelo.so +0x64682ca) > #18 in SdrObjEditView::DeleteWindowFromPaintView(OutputDevice*) at svx/source/svdraw/svdedxv.cxx:2324:22 (instdir/program/libsvxcorelo.so +0x59aac14) > #19 in FmFormView::DeleteWindowFromPaintView(OutputDevice*) at svx/source/form/fmview.cxx:196:14 (instdir/program/libsvxcorelo.so +0x7a55634) > #20 in ScTabView::~ScTabView() at sc/source/ui/view/tabview5.cxx:187:28 (instdir/program/libsclo.so +0x1429430f) > #21 in ScViewFunc::~ScViewFunc() at sc/source/ui/view/viewfunc.cxx:100:1 (instdir/program/libsclo.so +0x14657aeb) > #22 in ScDBFunc::~ScDBFunc() at sc/source/ui/view/dbfunc.cxx:49:1 (instdir/program/libsclo.so +0x13a72262) > #23 in ScTabViewShell::~ScTabViewShell() at sc/source/ui/view/tabvwsh4.cxx:1794:1 (instdir/program/libsclo.so +0x14314d5b) > #24 in ScTabViewShell::~ScTabViewShell() at sc/source/ui/view/tabvwsh4.cxx:1743:1 (instdir/program/libsclo.so +0x143150fb) > #25 in SfxViewFrame::ReleaseObjectShell_Impl() at sfx2/source/view/viewfrm.cxx:1113:9 (instdir/program/libsfxlo.so +0x5b8ee8c) > #26 in SfxViewFrame::~SfxViewFrame() at sfx2/source/view/viewfrm.cxx:1647:5 (instdir/program/libsfxlo.so +0x5ba8d5a) > #27 in SfxViewFrame::~SfxViewFrame() at sfx2/source/view/viewfrm.cxx:1641:1 (instdir/program/libsfxlo.so +0x5baa88b) > #28 in SfxViewFrame::Close() at sfx2/source/view/viewfrm.cxx:1165:5 (instdir/program/libsfxlo.so +0x5b9256d) > #29 in SfxFrame::DoClose_Impl() at sfx2/source/view/frame.cxx:142:35 (instdir/program/libsfxlo.so +0x5a190e1) > #30 in SfxBaseController::dispose() at sfx2/source/view/sfxbasecontroller.cxx:982:28 (instdir/program/libsfxlo.so +0x5b181ce) > #31 in (anonymous namespace)::XFrameImpl::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) at framework/source/services/frame.cxx:1492:33 (instdir/program/libfwklo.so +0x2c4a8de) > #32 in (anonymous namespace)::XFrameImpl::close(unsigned char) at framework/source/services/frame.cxx:1699:12 (instdir/program/libfwklo.so +0x2c55b57) > #33 in SfxFrame::DoClose() at sfx2/source/view/frame.cxx:108:29 (instdir/program/libsfxlo.so +0x5a163b8) > #34 in SfxViewFrame::Notify(SfxBroadcaster&, SfxHint const&) at sfx2/source/view/viewfrm.cxx:1519:28 (instdir/program/libsfxlo.so +0x5ba0b74) > #35 in SfxBroadcaster::Broadcast(SfxHint const&) at svl/source/notify/SfxBroadcaster.cxx:49:24 (instdir/program/libsvllo.so +0x17ef9c4) > #36 in (anonymous namespace)::SfxModelListener_Impl::notifyClosing(com::sun::star::lang::EventObject const&) at sfx2/source/doc/objxtor.cxx:146:12 (instdir/program/libsfxlo.so +0x515538b) > #37 in SfxBaseModel::close(unsigned char) at sfx2/source/doc/sfxbasemodel.cxx:1439:76 (instdir/program/libsfxlo.so +0x5285e3c) > #38 in SfxBaseModel::dispose() at sfx2/source/doc/sfxbasemodel.cxx:716:13 (instdir/program/libsfxlo.so +0x5266b5f) > #39 in ScFiltersTest::tearDown() at sc/qa/unit/jumbosheets-test.cxx:141:74 (workdir/LinkTarget/CppunitTest/libtest_sc_jumbosheets_test.so +0x7bc6b) This appears to date back to 88879a0d12fba95825b7f99f348094039ba3e029 "INTEGRATION: CWS aw051 (1.3.188); FILE MERGED: 2007/05/29 14:12:36 aw 1.3.188.1: #i77674#" > --- a/svx/source/sdr/overlay/overlaymanager.cxx > +++ b/svx/source/sdr/overlay/overlaymanager.cxx > @@ -264,12 +264,11 @@ namespace sdr > { > if(OUTDEV_WINDOW == getOutputDevice().GetOutDevType()) > { > - // transform to rectangle > - const basegfx::B2DPoint aMinimum(rRange.getMinimum()); > - const basegfx::B2DPoint aMaximum(rRange.getMaximum()); > + // #i77674# transform to rectangle. Use floor/ceil to get all covered > + // discrete pixels, see #i75163# and OverlayManagerBuffered::invalidateRange > const Rectangle aInvalidateRectangle( > - FRound(aMinimum.getX()), FRound(aMinimum.getY()), > - FRound(aMaximum.getX()), FRound(aMaximum.getY())); > + (sal_Int32)floor(rRange.getMinX()), (sal_Int32)floor(rRange.getMinY()), > + (sal_Int32)ceil(rRange.getMaxX()), (sal_Int32)ceil(rRange.getMaxY())); > > // simply invalidate > ((Window&)getOutputDevice()).Invalidate(aInvalidateRectangle, INVALIDATE_NOERASE); but which probably used sal_Int32 instead of long for no particular reason. Change-Id: I29459ab6c5cd06cc7d786b239221343f8de5170c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104096 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-08tdf#136964 Writer Navigator: Use same Headings expanded statesJim Raykowski
for Headings content navigation view and All content navigation view. Change-Id: I21fae6f0b6c0c67dd89a58fb6a5694475238e66c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103742 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-10-08don't scroll to the cursor on gaining focusCaolán McNamara
an alternative option is to set the cursor to the start line when inserting text into the multiline calc editview Change-Id: Id0da81e35bedc282839514bf981a5a6377e1a89c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104095 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-08use sal_Int32 for style-sheet indexNoel Grandin
instead of a mix of unsigned and sal_uInt16. Change-Id: Ice56d58d22856daa6645577610368ba19a849176 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104076 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-06 11:49:26 +0000