summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-12-12sw floattable: fix split of anchor text in 2nd half of the paragraphMiklos Vajna
If you go to the anchor text of the floating table and you press enter in the second half of the anchor text, you get a layout loop. The reason for this: an invariant around split text frames were violated, later resulting in a layout loop. The rule is that in case you have a split frame, then there can't be a frame for a new text node between the two split frames. So no new text frame for an other node after the master anchor of the fly; no new text frame for an other node before the follow anchor of the fly. Fix the problem by improving SwTextNode::SplitContentNode() to check if this is an anchor for a split fly: if so, always insert the new text frame after the follow anchor of the fly, which doesn't break the above invariant. The layout loop is fixed, but the text in the follow anchor of the fly still has a bad position, that still needs fixing. Also currently testSplitFlyMoveMaster enforces that split at the para start inserts a paragraph before the floating table, so leave that case unchanged for now. Change-Id: I77962a354e297d2e9957edcce9bf140f2c72fc6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160608 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-12-12Make some SvGlobalName ctors constexprMike Kaganski
Change-Id: Idacca005723b995061dc1df06f98bd584cbfd675 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160606 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-12sw: document SwFrame::Paste()Miklos Vajna
It was clear we want to insert a frame, but which frame is to be inserted and if that will be before or after the non-parent frame was far from clear. Document this based on how it's implemented in SwContentFrame::Paste() and SwFrame::InsertBefore(). Change-Id: I3eea471f9feecb35e20910e1869f5db1406d7c43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160603 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-12tdf#111969 sw: acknowledge that last half-character is in selectionJustin Luth
Wow, wrong since initial import and no one has touched it yet. This is not obscure code - it is called on most right mouse clicks and various other places. Kinda scary to make a change here... This unit test is copied from testCreateTextRangeByPixelPosition. Hopefully this pixel code is stable enough for unit tests... m_bPosMatchesBounds was introduced with commit cc63f3f550be4c8fe22cc8c6ff874812eefae20e Author: Vladimir Glazounov on Thu Apr 17 09:08:37 2003 +0000 make CppunitTest_sw_uiwriter3 \ CPPUNIT_TEST_NAME=testTdf111969_lastHalfcharOfSelection Change-Id: Ia2bcb93e390d14c9b4c1ab8a7059c41ed1b92429 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160442 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-12tdf#158548 vcl: Require mouse over listbox to mouse-wheel through entriesMichael Weghorn
As described in tdf#158548, it's unexpected that listbox/ combobox entries change when using the mouse wheel while the listbox/combobox has keyboard focus, but the mouse cursor is positioned somewhere else Therefore, only do that for the VCL ListBox when the mouse cursor is currently positioned above it, which also matches what e.g. native Qt applications do. (When using the gtk3 VCL plugin that uses a native GtkComboBox, nothing changes on scroll independent of the position.) Change-Id: I8a69628471c1cd4258194627b95145d6b8fb686a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160459 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-12android lint: Drop unused image resourcesMichael Weghorn
Drop unused image resources that lint warns about, e.g.: <issue id="UnusedResources" message="The resource `R.drawable.action_search` appears to be unused"> <location file="res/drawable-hdpi/action_search.png"/> </issue> Change-Id: I69422d485fc324245fd562fd75b016862b29c2a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160490 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-12android lint: Drop extra closing XML tagMichael Weghorn
This was accidently added in commit a21e7a76d745750dcea14bc6311e4f1766c3fa45 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Nov 9 10:24:13 2023 +0100 android a11y: Add content labels and now reported by lint: <issue id="ExtraText" message="Unexpected text found in layout file: &quot;/>&quot;" errorLine1=" />" errorLine2=" ~~"> <location file="res/layout/toolbar_bottom.xml" line="481" column="13"/> </issue> Change-Id: If4a17c4cd10450c2f5e13ead88a7511684ab9956 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160469 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-12sc: Unify GetColumnDataAron Budea
This added ColumnData: a15c02effa654da06e9695b5e4c0c595f851a878 This added GetColumnData: 1c53f5b6647dcffa57012990d342b21eaff19888 Both functions are the same, one is const, other is non-const. Change-Id: I8ed214290c7ee8d9e22bd466f9ada95b40300e34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160601 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-11Step 3 of removing cargo-cult pragma pack around rtl_[u]StringStephan Bergmann
see 8ae3ae4bf75fdd0aaa132c956d9da029baa3adc6 "Step 1 of removing cargo-cult pragma pack around rtl_[u]String" Change-Id: If6c2ea0ab2e7e61cdbc880d7b27d2af7f816e66d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158568 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11Only run test dependent on MS Paint OLE class, if Paint is installedMike Kaganski
Nowadays, MS Paint is optional component distributed through MS Store (https://www.microsoft.com/store/productId/9PCFS5B6T72H); it may be absent on some systems, resulting in tests relying on it failing. [build CUT] embeddedobj_msole [_RUN_____] testSaveOnThread::TestBody warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:207: Loaded object has no cached size! warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:232: OleEmbeddedObject::getVisualAreaSize: GetExtent() failed: com.sun.star.embed.UnreachableStateException message: "Class not registered Bitmap Image at C:/lo/core/embeddedobj/source/msole/olecomponent.cxx:904" context: class OleComponent warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olecomponent.cxx:1142: OleComponent::GetCachedExtent: GetExtent() failed warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:257: OleEmbeddedObject::getVisualAreaSize: GetCachedExtent() failed: com.sun.star.lang.IllegalArgumentException message: "at C:/lo/core/embeddedobj/source/msole/olecomponent.cxx:1143" ArgumentPosition: 0 warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olecomponent.cxx:1160: OleComponent::GetRecommendedExtent: GetExtent() failed warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:271: OleEmbeddedObject::getVisualAreaSize: GetRecommendedExtent() failed: com.sun.star.lang.IllegalArgumentException message: "at C:/lo/core/embeddedobj/source/msole/olecomponent.cxx:1161" ArgumentPosition: 0 warn:svtools.misc:123152:104988:svtools/source/misc/embedhlp.cxx:554: EmbeddedObjectRef::GetSize: no visual area size warn:svtools.misc:123152:104988:svtools/source/misc/embedhlp.cxx:573: EmbeddedObjectRef::GetSize: empty size, defaulting to 5x5cm warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:207: Loaded object has no cached size! warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:232: OleEmbeddedObject::getVisualAreaSize: GetExtent() failed: com.sun.star.embed.UnreachableStateException message: "Class not registered Bitmap Image at C:/lo/core/embeddedobj/source/msole/olecomponent.cxx:904" context: class OleComponent warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olecomponent.cxx:1142: OleComponent::GetCachedExtent: GetExtent() failed warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:257: OleEmbeddedObject::getVisualAreaSize: GetCachedExtent() failed: com.sun.star.lang.IllegalArgumentException message: "at C:/lo/core/embeddedobj/source/msole/olecomponent.cxx:1143" ArgumentPosition: 0 warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olecomponent.cxx:1160: OleComponent::GetRecommendedExtent: GetExtent() failed warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:271: OleEmbeddedObject::getVisualAreaSize: GetRecommendedExtent() failed: com.sun.star.lang.IllegalArgumentException message: "at C:/lo/core/embeddedobj/source/msole/olecomponent.cxx:1161" ArgumentPosition: 0 warn:svtools.misc:123152:104988:svtools/source/misc/embedhlp.cxx:554: EmbeddedObjectRef::GetSize: no visual area size warn:svtools.misc:123152:104988:svtools/source/misc/embedhlp.cxx:573: EmbeddedObjectRef::GetSize: empty size, defaulting to 5x5cm C:/lo/core/test/source/xmltesttools.cxx:171:testSaveOnThread::TestBody equality assertion failed - Expected: 0.1665in - Actual : 1.9685in - In <>, attribute 'visible-area-width' of '//style:graphic-properties' incorrect value. Check the class registration, and exit early if needed. It is unclear if we should do something specific with MS Paint objects on Windows, when MS Paint is absent, as we do on Linux; this is just a quick workaround. Similar checks might be needed in other tests. Change-Id: I4d99bc3b13d84da53bdb5aa6259083a68ccc8871 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160597 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-11Move Android buildfeature config to build.gradleThorsten Behrens
Old gradle.properties entry was deprecated in 8.0: - https://cs.android.com/android-studio/platform/tools/base/+/0bc1c23297760643b03e8cfd8acc52c007a99cd6 Change-Id: Ia34379e8112cc2c316be229e7719c2ce1b695576 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160602 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-11Fail when explicit --enable-ccache cannot be honoredStephan Bergmann
Change-Id: I2b638dad3e3a1f3d7044997061a8597b44067a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160600 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11tdf#105844 offapi,package,sfx2,xmlsecurity: add AEAD w/ AES GCMMichael Stahl
... and use it in the new experimental ODF encryption mode. https://www.w3.org/TR/xmlenc-core1/#sec-AES-GCM Unfortunately it turned out that NSS PK11_CipherOp() does not work with CKM_AES_GCM because it is initialized with "context->multi = PR_FALSE" in sftk_CryptInit(), so the one-step functions PK11_Encrypt() and PK11_Decrypt() have to be used. NSS 3.52 also changed a parameter struct definition - see https://fedoraproject.org/wiki/Changes/NssGCMParams - which is not a problem for RHEL or SUSE system NSS since those are rebased, but it is likely a problem for less well maintained Ubuntu LTS, so use the old struct definition which evidently still works with NSS 3.94. NSS 3.52 also added a new PK11_AEADOp() API but it looks like this doesn't support incremental encryption either. Change-Id: Ibd4a672db74b65b1218926ba35ff8d2f70444c7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160505 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-11android lint: Add API level check for EXTRA_INITIAL_URIMichael Weghorn
`DocumentsContract.EXTRA_INITIAL_URI` was added in API level 26, so only set it conditionally when that API level is avaible. Change-Id: I6783e89f50354c017968b74cc45fb1a3b6faab83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160468 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-12-11-Wimplicit-function-declarationStephan Bergmann
> workdir/UnpackedTarball/zlib/gzlib.c:242:9: error: call to undeclared function 'lseek'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > 242 | LSEEK(state->fd, 0, SEEK_END); /* so gzoffset() is correct */ > | ^ etc., as causing an error now by default with Clang 18 trunk Change-Id: Ic19c5710357a1f65046b5a225c6a181c3046938c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160554 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11tdf#108505 rtfexport: avoid mis-inheriting field char settingsJustin Luth
The field result fully defines its own character properties, so it should not inherit any "parent" properties from the field. My test file didn't show any problems with DOCX or DOC, and reading through the code I didn't notice anything that looked wrong. Both are very different from RTF syntax, and it didn't look like they did anything "special" for this situation, so nothing to copy from... This whole area of field properties looks very hacky, but it seems pretty clear that OutputTextNode loops through OutAttr's run properties for each of start/sep/end for fields. OutAttr picks up all of the direct formatting, so nothing should be "missing", and therefore a \plain character reset should be appropriate. The good news is that MS Word 2010 imported both the bad and the good export just like we do. make CppunitTest_sw_rtfexport6 \ CPPUNIT_TEST_NAME=testTdf108505_fieldCharFormat2 Change-Id: I713c071dfcd40117bfff03d152718eb5d847327e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160375 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-11tdf#158473 - UI: Part 55 - Unify lockdown behavior of Options dialogBalazs Varga
for Calc - Grid Page. Change-Id: Ic29e06c2f1a5e71e1b6236c321cfcb4b1afc39f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160564 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-11Reuse GetContentPart instead of duplicating itSamuel Mehrbrodt
Change-Id: I99790638b2de0df548875c6841c1dd46032894d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160567 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-11Fix typoAndrea Gelmini
Change-Id: I628574420b9ac84f6f249002236d8970e348f0b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160590 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-11curl: upgrade to release 8.5.0Michael Stahl
Fixes CVE-2023-46218 (cookies apparently used by libcmis) Change-Id: I6f903ab63589d3318c0cc7d47f5183f7ae55f52b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160592 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-11cid#1545577 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1545679 COPY_INSTEAD_OF_MOVE cid#1545691 COPY_INSTEAD_OF_MOVE cid#1545697 COPY_INSTEAD_OF_MOVE cid#1545711 COPY_INSTEAD_OF_MOVE cid#1545730 COPY_INSTEAD_OF_MOVE Change-Id: Ic0777a8ba532b00b021ffed81243505fbb7250f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160568 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-11macrowarnmedium: Save with newer GladeSamuel Mehrbrodt
Change-Id: Ida8f4be081fb3b695a6c87354b2862ec103bd432 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160565 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-11-Werror,-Wdeprecated-declarationsStephan Bergmann
> compilerplugins/clang/pluginhandler.cxx:67:71: error: 'getName' is deprecated: Use FileEntryRef::getName() instead. [-Werror,-Wdeprecated-declarations] > 67 | compiler.getASTContext().getSourceManager().getMainFileID())->getName()); > | ^ > ~/llvm/inst/include/clang/Basic/FileEntry.h:331:3: note: 'getName' has been explicitly marked deprecated here > 331 | LLVM_DEPRECATED("Use FileEntryRef::getName() instead.", "") > | ^ > ~/llvm/inst/include/llvm/Support/Compiler.h:155:50: note: expanded from macro 'LLVM_DEPRECATED' > 155 | #define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX))) > | ^ > compilerplugins/clang/pluginhandler.cxx:355:35: error: 'getName' is deprecated: Use FileEntryRef::getName() instead. [-Werror,-Wdeprecated-declarations] > 355 | StringRef const name = e->getName(); > | ^ > ~/llvm/inst/include/clang/Basic/FileEntry.h:331:3: note: 'getName' has been explicitly marked deprecated here > 331 | LLVM_DEPRECATED("Use FileEntryRef::getName() instead.", "") > | ^ > ~/llvm/inst/include/llvm/Support/Compiler.h:155:50: note: expanded from macro 'LLVM_DEPRECATED' > 155 | #define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX))) > | ^ since <https://github.com/llvm/llvm-project/commit/d1f86c3d03b7549eb0153c62550ef0f513ff50e8> "[clang] NFC: Deprecate `FileEntry::getName()` (#68157)" on LLVM 18 trunk. (clang::SourceManager::getFileEntryRefForID exists since <https://github.com/llvm/llvm-project/commit/4dc5573acc0d2e7c59d8bac2543eb25cb4b32984> "Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations" towards Clang 10, even when it changed its return type from Optional<FileEntryRef> to OptionalFileEntryRef along the way.) Change-Id: Ie37ba20c18f5ec33bab9ca2a96a9bcf722558c7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160561 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11symbolstore: update to python3Xisco Fauli
Otherwise, it fails on new AlmaLinux 8 baseline rm -fr /home/buildslave/build/workdir/symbols/ mkdir -p /home/buildslave/build/workdir/symbols/ /home/buildslave/source/libo-core/bin/symbolstore.py /home/buildslave/build/workdir/UnpackedTarball/breakpad/src/tools/linux/dump_syms/dump_syms /home/buildslave/build/workdir/symbols/ /home/buildslave/build/instdir/program/* /usr/bin/env: 'python': No such file or directory make: *** [Makefile:478: symbols] Error 127 Change-Id: I27a57a24a2f4bc7067041b2d4045ae0844e22d55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160113 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-12-11tdf#158421 use correct awt:Gradient2 in Chart listsArmin Le Grand (allotropia)
Change-Id: I5fa02c2660d59981f540cde8bd6eaaaaddb30e65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160463 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-12-113D SW-Renderer: Add functionality to balance quality/speedArmin Le Grand (allotropia)
For this purpose allow reduced 3D quality in some circumstances and make a compromize between quality and speed. This is balanced between those two targets, fine-tuning/experimenting can be done with some static local values if needed. Change-Id: Ib00b6e9c3c3ff165d82ff12d23bf15196f0a0ee0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160467 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-12-11svx: prefix members of SdrDragStatMiklos Vajna
See tdf#94879 for motivation. Change-Id: Ie3870e511a95c8b2862424cf538cebb0f5fce5dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160558 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-12-11tdf#158472 - UI: Part 54 - Unify lockdown behavior of Options dialogBalazs Varga
for Calc - Print Page. Change-Id: Ie5ee611552185662f4a1081415a2c6493cf58301 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160502 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-11Resave with newer Glade versionBalazs Varga
Change-Id: Ic95805c397b7a6e71d80d0f0c976e9c432238b2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160501 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-11tdf#158471 - UI: Part 53 - Unify lockdown behavior of Options dialogBalazs Varga
for Calc - Compatibility Page. Change-Id: I43780c8b29de42a765b1d1110dbfe90efb173b4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160499 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-11external/clucene: operation between different enumeration typesStephan Bergmann
> workdir/UnpackedTarball/clucene/src/core/CLucene/index/FieldsReader.cpp:233:58: error: invalid bitwise operation between different enumeration types ('lucene::document::Field::Store' and 'lucene::document::Field::Index') > 233 | f = _CLNEW LazyField(this, fi->name, Field::STORE_YES | getIndexType(fi, tokenize) | getTermVectorType(fi), length, pointer); > | ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18 trunk since <https://github.com/llvm/llvm-project/commit/1cbd52f791d3f088246526c0801634edb65cee31> "[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on Enumerations (#73105)" Change-Id: I2d48298bc64e05271ee5c33255d7d57fed6221cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160549 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11external/libetonyek: operation between different enumeration typesStephan Bergmann
> IWORKDiscardContext.cpp:85:30: error: invalid bitwise operation between different enumeration types ('libetonyek::IWORKToken::Namespace' and 'libetonyek::IWORKToken::(unnamed enum at ./IWORKToken.h:25:1)') > 85 | case IWORKToken::NS_URI_SF | IWORKToken::bezier : > | ~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~ etc. as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18 trunk since <https://github.com/llvm/llvm-project/commit/1cbd52f791d3f088246526c0801634edb65cee31> "[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on Enumerations (#73105)" Change-Id: I28bfd1f90df048acea23d9fddd2010bcb537b251 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160553 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11external/libwps: operation between different enumeration typesStephan Bergmann
> MSWrite.cpp:1424:63: error: invalid arithmetic between different enumeration types ('MSWriteParserInternal::BitmapFileHeaderOffset' and 'MSWriteParserInternal::BitmapInfoHeaderV2Offset') > 1424 | unsigned offset = MSWriteParserInternal::BM_FILE_STRUCT_SIZE + MSWriteParserInternal::BM_INFO_V2_STRUCT_SIZE + colors * unsigned(sizeof(MSWriteParserInternal::BitmapPalette)); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ etc. as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18 trunk since <https://github.com/llvm/llvm-project/commit/1cbd52f791d3f088246526c0801634edb65cee31> "[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on Enumerations (#73105)" Change-Id: I6307978bc39e0f965144e0df3ac9a28eb817fe10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160552 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11external/libebook: operation between different enumeration typesStephan Bergmann
> EBOOKDocument.cpp:150:37: error: invalid bitwise operation between different enumeration types ('libebook::EBOOKHTMLToken::(unnamed enum at ./EBOOKHTMLToken.h:21:1)' and 'libebook::EBOOKHTMLToken::Namespace') > 150 | if ((EBOOKHTMLToken::html | EBOOKHTMLToken::NS_html) == getHTMLTokenId(name, uri)) > | ~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~ etc. as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18 trunk since <https://github.com/llvm/llvm-project/commit/1cbd52f791d3f088246526c0801634edb65cee31> "[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on Enumerations (#73105)" Change-Id: I799932d0dffec5e9345f29e14a2ee3f9a2add133 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160551 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11external/graphite: operation between different enumeration typesStephan Bergmann
> workdir/UnpackedTarball/graphite/src/Pass.cpp:197:92: error: invalid arithmetic between different enumeration types ('status_t' and 'graphite2::errors') > 197 | || e.test(m_cPConstraint.status() != Code::loaded, m_cPConstraint.status() + E_CODEFAILURE)) > | ~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~ etc. as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18 trunk since <https://github.com/llvm/llvm-project/commit/1cbd52f791d3f088246526c0801634edb65cee31> "[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on Enumerations (#73105)" Change-Id: I34b2743d46b8f46b1f39b2af812f95876e4b9e38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160550 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11Clean up SvStream API a bitMike Kaganski
Change-Id: Ic9847185e8f551eeb05715902374d7a9a9032f60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160546 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-11tdf#117651 Fix AutoCorrect crash for italic, strike, bold, and underlineMatt K
This change fixes correction of indices when autocorrecting for one of the categories of bold, italic, strike, or underline. Previously, the code would hit a debug assert when selecting "Apply" because of incorrect indices into the string being autocorrected. Change-Id: I5484c589ff43cd2fc78332cdc0d63e74cdc8e256 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160547 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-11tdf#117651 Fix AutoCorrect support for italic, strike, bold, and underlineMatt K
The previous change for italic had a "break" for "/", but it turns out that code path is hit when trying to "Apply" with slashes around some text, so we just move the "break" inside the check for French language handling. Note that trying "Apply" with this change will crash on a debug build -- there is another fix for that problem in a subsequent change. Change-Id: I4bd76505b3fdfc9f5660eb6ae4a5c5c23e9672ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160529 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-10Resave with newer Glade versionBalazs Varga
Change-Id: I080b742ae6dcfa8a67ee90c7b611736121355806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160498 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-10cid#1545789 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1545791 COPY_INSTEAD_OF_MOVE cid#1545800 COPY_INSTEAD_OF_MOVE cid#1545806 COPY_INSTEAD_OF_MOVE cid#1545817 COPY_INSTEAD_OF_MOVE cid#1545832 COPY_INSTEAD_OF_MOVE cid#1545834 COPY_INSTEAD_OF_MOVE cid#1545841 COPY_INSTEAD_OF_MOVE cid#1545848 COPY_INSTEAD_OF_MOVE cid#1545852 COPY_INSTEAD_OF_MOVE cid#1545854 COPY_INSTEAD_OF_MOVE cid#1545864 COPY_INSTEAD_OF_MOVE cid#1545875 COPY_INSTEAD_OF_MOVE cid#1545882 COPY_INSTEAD_OF_MOVE cid#1545900 COPY_INSTEAD_OF_MOVE cid#1545901 COPY_INSTEAD_OF_MOVE cid#1545908 COPY_INSTEAD_OF_MOVE cid#1545921 COPY_INSTEAD_OF_MOVE cid#1546054 COPY_INSTEAD_OF_MOVE cid#1546145 COPY_INSTEAD_OF_MOVE cid#1546146 COPY_INSTEAD_OF_MOVE Change-Id: I8b23d0457cb293aa0e33593131224c1cdd1d8eb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160545 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-10tdf#140401 check if attribute is a nullptrPatrick Luby
Change-Id: Ie6e33fc1dca525553bb4237204666835d335b13f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160524 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-10Update Portuguese translation of ScriptForgeRafael Lima
Change-Id: Ic16b782d63e84581134f2238454aa9599819f146 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160359 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2023-12-10tdf#158469 - UI: Part 51 - Unify lockdown behavior of Options dialogBalazs Varga
for Calc - Sort Lists Page. Change-Id: I857b49caf8fa6823ae2582212885b317a34ff1df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160494 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-10Resave with newer Glade versionBalazs Varga
Change-Id: Ibf9a565587a5af02f6cb8ba9194e25d2f5b66c8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160493 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-10tdf#158470 - UI: Part 52 - Unify lockdown behavior of Options dialogBalazs Varga
for Calc - Changes Page. Change-Id: I2d352915b2804411f0bbee62c967de77ad4bbba7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160496 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-10Resave with newer Glade versionBalazs Varga
Change-Id: I6bb6dbfe977987e592b87abc5e1f0f3dc4b789cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160495 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-10tdf#158467 - UI: Part 50 - Unify lockdown behavior of Options dialogBalazs Varga
for Calc - Calculate Page. Change-Id: Ibe728e2ffc122879ee66abb88927be355d41348a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160462 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-10cid#1545177 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1545179 COPY_INSTEAD_OF_MOVE cid#1545187 COPY_INSTEAD_OF_MOVE cid#1545188 COPY_INSTEAD_OF_MOVE cid#1545189 COPY_INSTEAD_OF_MOVE cid#1545196 COPY_INSTEAD_OF_MOVE cid#1545197 COPY_INSTEAD_OF_MOVE cid#1545204 COPY_INSTEAD_OF_MOVE cid#1545223 COPY_INSTEAD_OF_MOVE cid#1545236 COPY_INSTEAD_OF_MOVE cid#1545239 COPY_INSTEAD_OF_MOVE cid#1545253 COPY_INSTEAD_OF_MOVE cid#1545274 COPY_INSTEAD_OF_MOVE cid#1545286 COPY_INSTEAD_OF_MOVE cid#1545309 COPY_INSTEAD_OF_MOVE cid#1545311 COPY_INSTEAD_OF_MOVE cid#1545345 COPY_INSTEAD_OF_MOVE cid#1545358 COPY_INSTEAD_OF_MOVE cid#1545361 COPY_INSTEAD_OF_MOVE cid#1545365 COPY_INSTEAD_OF_MOVE cid#1545367 COPY_INSTEAD_OF_MOVE cid#1545372 COPY_INSTEAD_OF_MOVE cid#1545373 COPY_INSTEAD_OF_MOVE cid#1545377 COPY_INSTEAD_OF_MOVE cid#1545392 COPY_INSTEAD_OF_MOVE cid#1545399 COPY_INSTEAD_OF_MOVE cid#1545404 COPY_INSTEAD_OF_MOVE cid#1545408 COPY_INSTEAD_OF_MOVE cid#1545430 COPY_INSTEAD_OF_MOVE cid#1545439 COPY_INSTEAD_OF_MOVE cid#1545449 COPY_INSTEAD_OF_MOVE Change-Id: I3afe836a0bbc8bd70937035e60eb020435e413d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160539 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-10tdf#158250 Blueprint Plans template: update imagesLaurent Balland
Contribution from Jérôme Bouat Replace pictures with grey level and indexed colours Change-Id: I5e253af65529d45b3c9ed2e30f6e2f018cbe03e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160532 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-12-10tdf#158250 Yellow Idea template: replace picturesLaurent Balland
Contribution from Jérôme Bouat Replace pictures with grey level Change-Id: I933b20ad7b06d60e8039caaf8ce777bb52ce4225 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160534 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
generated by cgit (git 2.34.1) at 2025-01-28 19:37:12 +0000