summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-09-07apply ui-rulesCaolán McNamara
Change-Id: I5acc6cfe5488f8aa92ecaafa0ebdc50f2ad9758e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07we don't use urgency-hint or want any gravity hintsCaolán McNamara
Change-Id: I86255f9ba018aab7db654d91bf49043fcd4cb057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139590 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07add truncate-multiline for consistency with vcl and all the othersCaolán McNamara
Change-Id: I7ccc294308d487ce2443699a946753290344a92d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139589 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07vcl: convert ImplGetEmphasisMark() to EmphasisMark classChris Sherlock
It makes more sense for an emphasis mark to be an object that can be queried, than it is for it to be a function with lots of output parameters. I have added a unit test, note that for now something doesn't seem right with polypolygon equality checks (test fails, but the disc is generated the same way) so not testing the shape creation. Change-Id: I7597603419b69639b8d9764afdb68e266da7a56b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122601 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-09-07gtk4: caps-lock-warning is gone as a propertyCaolán McNamara
Change-Id: I66aac55f0ebb381bc2f9f1fffbdb887d4a016005 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139588 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07every other .ui is version="3.20"Caolán McNamara
Change-Id: Ifc45b74e06069855021b7c963a3e5c83c8eacfcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139587 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07Use exactly two comparisons in froundMike Kaganski
It is used extensively in drawinglayer; the typical path for values inside sal_Int32 range used three comparisons. Change-Id: Iafb09f06a746bb53a41585be4a5b1a701fa38057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139555 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-07Related: tdf#122737 A hack to keep backing window opaque on context destructionMike Kaganski
Also this incidentally improves OpenGL frame rate, which could decrease the problem visibility (but indeed, this is not a proper fix). Change-Id: If1d0eec78cad14548a51be7da76f16a3ecfcddb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139581 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-07sd: rename WriteAnimationNodeAudio to MediaMiklos Vajna
Because XAudio means both video and audio, see <https://gerrit.libreoffice.org/c/core/+/139265/comments/479934b4_978756a7>. Change-Id: I4d631d55ec1694c11e24c65b0826771c87457cdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139579 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-07use o3tl::span in SvXMLItemMapEntriesNoel Grandin
which means we don't need to calculate the size of the map at construction Change-Id: I295defd7c4609b22a994928f6442fadadd9df66d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139543 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07convert PreviewMode to scoped enumNoel Grandin
Change-Id: I36d6153e5bc65311ec5708839e640cf104b3f035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139546 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07tdf#150569 Modify hardcoded dates to extend the range of accepted datesjucasaca
Replaces date range limits to allow entry of dates between 1/1/0001 and 31/12/9999, which is the normal date range in most database manager May need some discussion Change-Id: Ide8dfc64663d2ef2a66d8b7e1af3ef8ed3bb0af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138845 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07tdf#150666 sw: allow to delete tracked table row insertionsLászló Németh
It was not possible to delete tracked table row insertions, if only those were selected, or if they were own insertions. Regression from commit 95213407dfcbf34056037d60243ff915340d1a2e "tdf#146622 sw crash fix: don't delete already deleted rows". Change-Id: Idd3bc78bca1c76bceba63cf339c6d8c73f8f9508 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139575 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-09-07convert ElementOpenMode to scoped enumNoel Grandin
Change-Id: Ib1b714c377ce0d4935ba5ead68163d69fa091cfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139545 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07ONavigator doesn't need a pimplNoel Grandin
it is module private Change-Id: I21779fe8ac50aa4602e4c3d7798d0ced1ddab066 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139541 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07ofz#50118 TimeoutCaolán McNamara
Change-Id: Idf0669d62b8bb6d21a6b5ad22f698449bb66e531 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07sw: clean up DocxAttributeOutput::EndContentControl()Miklos Vajna
This always felt dirty, and seems it's no longer needed. Remove the fly frame condition before somebody starts depending on it. Change-Id: Id286ab37981fd1890ca88bf5a17cb78876bcd2ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139574 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-07ConvertToBitmapEx slightly too bright if transparency involvedArmin Le Grand (allotropia)
Stumbled about this error when working on re-designing the blend primitives for shapes. Using convertToBitmapEx is the base for these (also for the UNO API conversion from Primitives to BitmapEx). Use a VirtualDevice in the Alpha-mode now to solve it. This creates the needed alpha channel 'in parallel'. It is not cheaper though since the VDev in that mode internally uses two VDevs, so ressoure-wise it's more expensive, speed-wise pretty much the same (the former two-path rendering created content & alpha separately in two runs). The former method always created the correct Alpha, but when transparent geometry is involved, the created content was blended against white (COL_WHITE) due to the starting conditions of the content creation. There are more ways than using a VirtualDevice in the Alpha-mode, to do this correctly, but this is the most simple for now - and I was persuaded by the following argument: Due to hoping to be able to render to RGBA in the future anyways there is no need to experiment trying to do the correct thing using an expanded version of the former method. Change-Id: I23e005f9c3723059e2b88660fede09aa83844b38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139272 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-09-07SvXMLItemMapEntries does not need an implNoel Grandin
it is module private Change-Id: Iaceb84b6868fe1450eab748f34f131a3867d38cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139542 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07filter: remove no longer needed back-compat of the svg presentation engineMiklos Vajna
This was added in commit 4063dcdc7305177b167bd20b009b1dfede8b25ec (Revert naming back to lool to fix break with LibreOffice Online, 2022-08-26), to give consumers of that API time to switch from the product name to the API name. Now this patch removes the product name, only on master. Change-Id: I27e2fd03c8ca646ffb0e0df541b7f94bd9ad3516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139551 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-07OXReportControllerObserver does not need a pimplNoel Grandin
it is module private Change-Id: I50bd06aa1b75d7561aee788c69c0482c6293db16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139540 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07convert ObjectType to scoped enumNoel Grandin
Change-Id: I1c103aebe02a41ed4fa59a72950cb55d3c6c93d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139544 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-07tdf#150604 Writer Navigator: Make delete shortcut key delete IndexesJim Raykowski
Change-Id: I651159794790972b430c9a420d6eaa1ed77e5718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139550 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-09-07CppunitTest_sw_ooxmlencryption: remove not needed mustTestImportOf()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. All the tests in this suite are docx files, so this was an unnecessary override. Change-Id: I519599abd5081ec68c9603befbb16794dd5696b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139532 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-09-07Resolves: tdf#150829 Broadcast missing ScAreasChanged hint on sheet copy UndoEike Rathke
Change-Id: I354b1e395079067cd4cc9299501b3936dea00cd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139538 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-07tdf#147646 Auto numbering is wrong when the row has split/merged cells.Satya
The fix is to,walk through the paragraphs in the cells that are vertically merged(PROP_VERTICAL_MERGE)and remove the numbering rules property from underlying text of those paragraph properties of a cell. Note that,there was a similar bug for DOC files,and it was fixed with tdf#49102,we need to provide a seperate fix for DOCX files as the DOCX filter is different than DOC. Change-Id: Ia1cc22cbc04448a11ae0d136519681d9363e2828 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139401 Tested-by: Jenkins Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-07Use XCharacterClassification::getCharacterType() instead of getStringType()Eike Rathke
Change-Id: I0bbd196a8691fb72a1f091af8825df749bfc7cb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139535 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-07Always enquote ColRowName (label) as SingleQuotedEike Rathke
It's anyway required by ODFF and also in UI prevents confusion between defined names and labels of the same name. Change-Id: Iba03f15f1f778132696101507e61cc0ef8de6c6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139533 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-06Add note to XCharacterClassification::getStringType() about meaninglessnessEike Rathke
Given how it works that's almost deprecated, almost.. Change-Id: Ife2fe012db5568e4646b98b0ba55df8418069062 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139534 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-06svx: set vars to initial values in constructor init for SdrTextObjTomaž Vajngerl
Change-Id: Id3fb342a4273b617ac2975bff3dd79159ab8df75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139531 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-09-06svx: fix description of SdrTextObjTomaž Vajngerl
bTextFrame is now mbTextFrame and the type is changed to bool, so no more sal_True and sal_False. Change-Id: I55572df1b717444bdcc9ae875856bc9f9bb2674f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139530 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-09-06svx: remove "using namespace *" in tablemodel.cxxTomaž Vajngerl
UNO types are clearer when written from com::sun::star as root namespace. Change-Id: I9e063a904ecbdf471c9ca295a2f0c5bd727b9711 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139529 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-09-06Removed executable permission on fileAndrea Gelmini
Change-Id: Ie9097527d66cdb6ce5c616dcaaf5e2eafd282733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139481 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-06cid#1500385 rearrange to make clearer what actually happensCaolán McNamara
Change-Id: Ibdd70300b5081b5ad054fed5db65fc3c8cc4c3cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139523 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-06cid#1500509 silence Out-of-bounds accessCaolán McNamara
Change-Id: I6f23c74f5e69610f1f3bf387467796f20ad4515a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139522 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-06cid#1500538 Big parameter passed by valueCaolán McNamara
Change-Id: I4d432026d260c6bbda183a7849a83ed3f0a6a27c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139521 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-06cid#1500594 Explicit null dereferencedCaolán McNamara
since commit 5480d9237af1cf25ac464bf49ba364a757fcf6f5 Date: Sun Jan 24 22:17:49 2021 -0900 tdf#114567 tdf#138934 Hyperlink-Target in Doc Headings expand/collapse lets make a copy of the iterator Change-Id: I855c58377871d7fb55ea676ebac48c0abc67e98c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139519 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-06Simplify SalSysObj(Child)WndProcWMike Kaganski
Change-Id: I578410db327c98cde5e6e2a9f802e4de5b64a539 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139492 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-06This can't be null after the null handler aboveMike Kaganski
Change-Id: I70c0d28fe5d817fbdbc9ad499e4e6e729f81399a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139510 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-06tdf#150682 - bad shortcut in french langageNoel Grandin
the = key is } on a french keyboard, so remap the ctrl-alt-= shortcuts to ctrl-alt-} which means the user gets to keep pressing keys in roughly the same physical location for this action, regardless of keyboard Change-Id: I03e251dacc1c19e543182a44ae23fde2a57cfa45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139474 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-06desktop : use a std::mutex instead of a osl::MutexArnaud VERSINI
Change-Id: I149af335196eaa31cbd11965e1656c3dfe7431ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139440 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-06sc : remove useless lock and init in cellkeytranslatorArnaud VERSINI
Change-Id: Ibad2dfb721e4df390ddaf955a8b7fcdf676773e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139447 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-06tdf#150756 - Assertion when opening report for editingNoel Grandin
regression from commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu May 27 10:27:46 2021 +0200 ref-count SdrObject this logic is not meant to kick in for reportdesigner. If this commit causes further regressions, and we need to reinstate some form of this logic, it should be conditional on a flag which is deliberately set by the modules (probably only sd) which actually need it. And the flag should be an explicit "I want to kill attached UNO shapes when the page changes" rather than being conditional on some other condition which is, at best, only tangentially related. Change-Id: Ibc09149ab4ff88fde8d1bd1e0545e255ccdba50a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-06check impress/calc IFrame "FrameURL" targetCaolán McNamara
similar to commit c7450d0b9d02c64ae3da467d329040787039767e Date: Tue Aug 30 17:01:08 2022 +0100 check IFrame "FrameURL" target Change-Id: Ibf28c29acb4476830431d02772f3ecd4b23a6a27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139480 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-06sw HTML import: fix height of OLE objs when it is missing and width is relativeMiklos Vajna
In case an OLE object's fallback bitmap had a width=100% size but no explicit height, we used to set the OLE object's size to a fixed value, based on the bitmap's pixel size. Falling back to the pixel size based on the current DPI is sensible if there is no height specified, but browsers keep the aspect ratio when only width or height is specified and we didn't. Fix the problem by explicitly checking for the "one axis has percent size, the other is unset" scenario in SwHTMLParser::InsertEmbed() and then handling the new SwFormatFrameSize::SYNCED value in SwHTMLParser::SetFixSize(). Note that SetFixSize() is not used for bitmaps (only for OLE objects), so that codepath may still need a similar fix. Change-Id: I9f70307edbfbb06e228494fb5c04e7381ed8e5cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139526 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-06cid#1500587 silence Dereference before null checkCaolán McNamara
Change-Id: I3672d8266b339f06d5c75285fb9582f331a07c95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139518 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-06cid#1500607 silence bogus Use after freeCaolán McNamara
Change-Id: Ibcb52aad5d47635e7096025d5b31de1b81503ae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139517 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-06cid#1509195 silence Explicit null dereferencedCaolán McNamara
Change-Id: I9a7cbdb0e2cc4a5624d78dbb88c7f5dacc68f309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139516 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-06cid#1509284 DMI: Dubious method invocationCaolán McNamara
Change-Id: I1fd1f710ae2a6b8ebc9506a56d522006509fc935 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139515 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-06cid#1509199 silence Constant expression resultCaolán McNamara
rename IsEqualData -> HasSameData Change-Id: I6294c847c284888e5537e04dc4f84314586c4b85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139514 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-20 14:02:03 +0000