summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-02-16SfxViewShell::GetViewFrame never returns null, change to a referenceCaolán McNamara
various null checks can be seen to be redundant and removed Change-Id: Icf49c1de4b0302795d2769a370af3abceaad0221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-16Avoid storing a redundant reference that may become danglingMike Kaganski
It would be dangling after ScPoolHelper::SourceDocumentGone. The pointer to the document is stored in the pool, anyway. Change-Id: I10f8f2808b8dc895f85a92f7bcf4dc44516c44a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147148 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-16Add comment about using WASM exceptionsTor Lillqvist
Change-Id: I402bf56b89b3a18f854331915f827f7512fb05e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147152 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-02-16Fix typoAndrea Gelmini
Change-Id: I120fe327539bad62cc2489a73af7ccd343ceca8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147140 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-02-16Improve testLocalizedPropertyStephan Bergmann
c3bd52f81bf733a0b9b0560794a54b2ac1e0f444 "Use the (first segment of the) original locale value for the workaround again" had stated: "The added test code unfortunately doesn't actually test this piece of code, and somewhat unexpectedly receives the "default" value from the empty string locale default, rather than the "en-US" value from the higher precedence "en-US" locale default, because `aFallbacks` happens to contain an empty string, so we already leave Access::getChild early in the 'Find the best match using the LanguageTag fallback mechanism, excluding the original tag' block." But, of course, the relevant code can well be tested after all, using a localized property that does not have a default no-xml:lang value. (And add a TODO comment about the unexpected "default" vs. "en-US" in the original test code, in case the LanguageTag::getFallbackStrings behavior ever changes and the test starts to fail.) Change-Id: I526a830a5929b6b5ad17ba57af5943954b07b86a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147137 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-16set visibility of classes in mergelib+asan caseAndras Timar
Change-Id: I2eb80d0b3002f174deea0d8657cb0cdbdec5be8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147144 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-02-16This bool is redundantMike Kaganski
Change-Id: I4bc59f88cff3d28b44735b75058c4619b90e8b7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147139 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-16SfxViewShell never takes a null SfxViewFrame*Caolán McNamara
Change-Id: I36f3a5c77a7fb2d3cf267184e403e6cd24dbd70b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-16sw floattable: limit vertical position for the follows of split flysMiklos Vajna
The bugdoc has 2 pages and the 2nd page had a fly frame with an unexpected vertical shift towards the bottom. The problem is that the floattable has a vertical offset defined, but Word only handles that on the first page of the split table, not on later pages. This makes sense: we split the table to multiple pages so that the content fits, an additional offset on follow pages would result in a lot of additional pages. Fix the problem by adjusting SwToContentAnchoredObjectPosition::CalcPosition(), so that the vertical offset is only applied on master flys, not on follow flys. This implicitly means that the behavior is unchanged for non-split flys, since those always have a first page, which is nicely consistent. Change-Id: I8c86cd2df6868cc5c1a10dfec359f3e02f5c1102 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147141 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-02-16use std::condition_variable for oslConditionNoel Grandin
which is both faster (because we don't need to allocate a pthread condition) and simpler Change-Id: I0a98432b5106c1c2b8e8ed97cbd779ef2b0c9e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146996 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-16osl::Mutex->std::mutex in ChartViewNoel Grandin
Change-Id: I74974a8e11885e0bb4773b56858a69816fd1ac41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-16tdf#72955 - Modified Bibliography entry dialog to work inside bibl. tableVojtěch Doležal
Change-Id: I5d4072e136eb321f92973ca8e3cd749e4ce06bd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147001 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-02-16Fix issue where comment replies would not get a para id on roundtripParis Oplopoios
Also adjusted the test file to account for this Change-Id: I34f1d9d3a77f91396dd733785eb5b7853289508a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147034 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-02-16no need to lock when accessing m_pInstance hereNoel Grandin
as noted by mkaganski, this field is valid until the object destructs, so no need to take a lock Change-Id: Id0b9a1a26391d4e971bd0b37b9d6e1b1a20e163a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-16Drop 'using namespace ::std' in dirs [u-x]*Gabor Kelemen
Change-Id: I8c044369826b00241496cfc7ba2463e507c0d1a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147077 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-02-16Drop 'using namespace ::std' in dirs s*Gabor Kelemen
Change-Id: If3119a1f2274aac0bf70576458e3adb4505a2a45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147076 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-02-16osl::Mutex->std::mutex in FSStorageNoel Grandin
Change-Id: I62980bec76425980804368ba009ffaeb6bef800a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-16osl::Mutex->std::mutex in UcbLockBytesNoel Grandin
Change-Id: Ia84af116b705299ff4b9070f145e149c1a8a2c47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147101 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-16osl::Mutex->std::mutex in SwDrawModellListener_ImplNoel Grandin
Change-Id: I150ac67a3f053046a6d6a7cd79323fa4595078c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147105 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-16sw: fix undo comment of FN_UPDATE_TEXT_FORMFIELDSMiklos Vajna
It's updates, not an insert. One has to dispatch .uno:TextFormFields to see this in action. Change-Id: I3049fa34110731e15082a0163de4b08e83c76098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147109 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-02-16osl::Mutex->std::mutex in ucb::ucp::ext::DataSupplierNoel Grandin
Change-Id: Id195c7cb676d4c7e0741adeb31f4b1a9854e8230 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-16osl::Mutex->std::mutex in SwXDocumentIndex::ImplNoel Grandin
Change-Id: Iaaa57af9bb298f4495b4a51d3553c55a63c5b069 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147099 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-16osl::Mutex->std::mutex in ChartViewNoel Grandin
Change-Id: Iebb2d1352b76108e803605dc856407ce2484e5a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-16osl::Mutex->std::mutex in GtkSalDataNoel Grandin
Change-Id: I86fdee3310715256a76f2b6560d27d3302402ab9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147102 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-15Use the (first segment of the) original locale value for the workaround againStephan Bergmann
cf7c9599e776eba8e14614cecb528d3da5778190 "Make comphelper/configuration.hxx work for localized properties", which had originally introduced this code, had been careful to ensure that the > assert( > !locale.isEmpty() && locale.indexOf('-') == -1 && > locale.indexOf('_') == -1); would always hold here (it had already removed all trailing "-..." and "_..." segments, but had made sure to stop before `locale`, which is known to initially be no non-empty, would have become empty, by treating a leading "-" or "_" not as a segment delimiter, but rather as a first segment). dfc28be2487c13be36a90efd778b8d8f179c589d "configmgr: Use a proper LanguageTag-based locale fallback mechanism" had changed that, instead setting `locale` to some value obtained from `LanguageTag::getFallbackStrings`, which might or might not satisfy the assert. But there was no good reason for that part of dfc28be2487c13be36a90efd778b8d8f179c589d in the first place: The workaround (as explained in the leading code comment) was meant to be carried out with the first segment of the original `locale` value, not with some fallback value. So put back here the computation of that first segment of the original `locale` value. (And drop the misleading empty line that dfc28be2487c13be36a90efd778b8d8f179c589d had, for no good reason, introduced between the workaround's leading code comment and its actual code.) However, it turns out that there was one flaw in cf7c9599e776eba8e14614cecb528d3da5778190: When the original `locale` starts with "-" or "_", the resulting `locale` representing the first segment will be "-" or "_", so the `locale.indexOf('-') == -1 && locale.indexOf('_') == -1` part of the assert would be false. But that wouldn't be an issue for the following code (the only issue would be if `locale` had become empty, in which case the `name2.startsWiht(locale)` check would trivially become true, and that for loop would erroneously pick the child with the empty `name2`), and that part of the assert had merely been there to reinforce that `locale` had indeed been stripped down to the first segment. A correct version of the assert would have used `locale.indexOf('-', 1) == -1 && locale.indexOf('_', 1) == -1` instead, but as the code now makes it obvious anyway that `locale` has been cut down here to the first segment, we can just as well simplify the assert to just the `!locale.isEmpty()` part. (The added test code unfortunately doesn't actually test this piece of code, and somewhat unexpectedly receives the "default" value from the empty string locale default, rather than the "en-US" value from the higher precedence "en-US" locale default, because `aFallbacks` happens to contain an empty string, so we already leave Access::getChild early in the "Find the best match using the LanguageTag fallback mechanism, excluding the original tag" block.) Change-Id: Ib92e714c9db4879be058529ec905e631df975424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147113 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-15Add unit tests for zh-Hans and zh-Hant mapping and fallbacksEike Rathke
Change-Id: I99db25676e38a85639f4f2fb09b7fc42cc6f8755 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147111 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-02-15dont use RES_MSG_{BEGIN,END} outside hintids.hxxBjoern Michaelsen
Change-Id: Iee08120ec4ebfd39f03a949f4a759eaa415ca894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147029 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2023-02-15check GetFEShell()Xisco Fauli
Similar to 24889135773204c6e3002dcb417c75ff1a99ccd0 "check GetEditShell()" These two crash reports might be related: - https://crashreport.libreoffice.org/stats/signature/SwView::GetDocShell() - https://crashreport.libreoffice.org/stats/signature/SwFEShell::UpdateTableStyleFormatting(SwTableNode%20*,bool,rtl::OUString%20const%20*) Change-Id: I7ce286f7be933b34af270abd11a4c9c4c58fe4a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147097 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-15Add extended tip to fontwork dialogOlivier Hallot
* Extracted from help page shared/guide/fontwork.xhp The <ahelp visibility="hidden"> tag is actually content for extended tips in ui dialogs. Contents is not displayed in Help page (honoring visibility). Change-Id: Iaf97c16bf8dfd8d9a08825f551cb0ea9e59f71bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147107 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-02-15Bump Glade release for fontworkgallerydialogOlivier Hallot
Change-Id: I2ad31d3f232c7060469edced1cc7e9ea70a0d583 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147106 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-02-15Add a rudimentary test for localized propertiesStephan Bergmann
Change-Id: I9abe06e6f1f2b6b39cbbf07043dd9c5062ff0460 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147108 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-15Remove unused configmgr/qa/unit/urebootstrap.iniStephan Bergmann
...left behind by 6a370f580aaf060004536dfc8ca877c9a2114c66 "configmgr: remove unused old dmake file" Change-Id: I9209b672f0b3242f6801935722b3108ef692787a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147096 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-15tdf#153613 writerfilter: anchors ignore prior run with page breakJustin Luth
Although an image that is INLINE with the text DOES move to the following page when it is preceded by a w:br, an anchored image does not (when it is the last property in the paragraph). make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153613_inlineAfterPgBreak I also tested with <w:t>x<</w:t> following the anchor and it already works correctly. make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak2 I also tested with <w:splitPgBreakAndParaMark/> and it already works correctly. make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak3 Change-Id: Ibf9c0d38c4dfe56db4e05416a40e3b7881693b17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147032 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-02-15clean up SwRefMarkFieldUpdate a bitBjoern Michaelsen
- remove SwRefMarkFieldUpdate: * it has only one unused field * replace with a plain SwPtrMsgPoolItem - hint constness: * SwUndoFieldFromDoc: make ctor arg hint const * DocumentFieldsManager: make UpdateField arg hint const * however, seeing this hint is: a/ constructed on the stack, but b/ stored as pointer in undo likely it would be best to remove it altogether. For now, make it at least static, so that there is no use after free. Change-Id: Ica51a2a2ce19e1938c3a367e9b4a9e01bbb75374 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147030 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2023-02-15Drop 'using namespace ::std' in dirs [e-p]*Gabor Kelemen
Change-Id: Ibe6a2f662f5721c594d28a8e0d7340d0f3cffe95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147075 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-02-15Drop 'using namespace ::std' in dirs b* c*Gabor Kelemen
Change-Id: I59392ee7aa71c219e475a09da67a868cfdd14b41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147074 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2023-02-15Update git submodulesSophia Schroeder
* Update helpcontent2 from branch 'master' to eb05d16166e7bdaf119b434c9d613d3d88676762 - Emphasize "OK" Change-Id: I598f51cded8f8687de89898f89489835abcddca0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147068 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-02-15move image into the .ui fileCaolán McNamara
Change-Id: I5dad1bd0bcdbedf20d27109ca08109a1a2a6234b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147085 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-15tdf#153633 color description in chart colors options always blackCaolán McNamara
even in dark mode. There are some other visual glitches here, just erase the rendercontext before drawing to it. Change-Id: I487375614c654124e116c3e9f28d78bf7f87da4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147087 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-15tdf#147258 DOCX import: fix bad char format w/ inline <w:sdt> and data bindingMiklos Vajna
The bugdoc had an inline SDT in placeholder mode, where the placeholder had a char style to define a red text color. This red color is not in Word, but it was in Writer. This went wrong with commit de90c192cb8f1f03a4028493d8bfe9a127a76b2a (sw content controls, plain text: enable DOCX filter with data binding, 2022-09-19), because previously we didn't map <w:sdt> to Writer content controls for plain text with data binding. Fix the problem by resetting the char style back to default when the value of the content control comes from data binding. Interestingly office.com renders the document the way Writer did previously, but let's try to match what desktop Word does, that's probably the reference for DOCX files. Change-Id: I7eccdb843d5ab63ccf573644c61832e2ef7dae14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147088 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-02-15Resolves: tdf#30920 don't terminate app on closing license frameCaolán McNamara
when there is a backing window (start center) also open Change-Id: I64051467ac90ee321b7fc54cb96775c5a1e8d3a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147078 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-15resave with latest gladeCaolán McNamara
Change-Id: Ib1cbf1869fd7b1633178e56a47977050457640f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-15list icons in .hlst files otherwise they might not get packed into iconsetCaolán McNamara
Change-Id: I64cb4b4f12189f402334fff185d8fdf0db4e4536 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147083 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-15move the sc_additionsdialog.png into the .uiCaolán McNamara
the mechanism for determining that an image is in use in order to not pack unused icons only scans .ui and .hlst files, not all source code, so this was fragile Change-Id: Ic06c6a451cff3def8547b3ab085be70f6870054e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147080 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-15resave with latest gladeCaolán McNamara
Change-Id: I7c581b16b819b623dab667abab56fc1559129651 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147079 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-15MCGR: Add GradientSteps to GeoTexSvxGradientArmin Le Grand (allotropia)
Move GradientSteps data to GeoTexSvxGradient and adapt interfaces. Also move tooling to more isolated place in gradienttools in basegfx. Keep everything still compatible, the work will be now to adapt all six different derivations of GeoTexSvxGradient to make use of the evtl. given GradientSteps. Change-Id: Iaa212763c603d46de0a94b1b203b979bb7ce359d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147050 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-02-15Make a few warning messages a bit more usefulTor Lillqvist
Change-Id: Ie533e76532f2ee6477cce8042d958d36bf9ebb9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147082 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-02-15Add paraIdParent to LOK notification attributesParis Oplopoios
paraIdParent has to do with which comments are replies to other comments which differs from the parent attribute which has to do with which comments are in the same thread with other comments Change-Id: I27feba55eadeeff22d409f69d8df976ad85e0ba6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147021 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-02-15tdf#153444: sc_subsequent_filters_test: Add unittestXisco Fauli
Change-Id: I9b58c396f18764e1821f7d5063bba5559bfbf021 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147043 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-15tdf#146260: sc: Add UItestXisco Fauli
Change-Id: I1ff644745344cb847fd0b4c7b20551ad189cb383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147081 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>