summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-09-08sw_ooxmlexport15: DECLARE_OOXMLIMPORT_TEST -> DECLARE_OOXMLEXPORT_TESTXisco Fauli
and move one test to sw_uiwriter. It fits more there Change-Id: I335b83936f9570d18fe14be860cbc4818eaf0007 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102246 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-08sw_ooxmlexport14: DECLARE_OOXMLIMPORT_TEST -> DECLARE_OOXMLEXPORT_TESTXisco Fauli
and if the test fails, move it to sw_ooxmlimport2 Change-Id: I2fb18f9cef40ba502ee4d719de543b5e78cd31d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102241 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-08sw_ooxmlexport13: DECLARE_OOXMLIMPORT_TEST -> DECLARE_OOXMLEXPORT_TESTXisco Fauli
Change-Id: I423bb88ed8820323313429dfc2a4aa23cd7e789b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102244 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-08sw_ooxmlexport10: DECLARE_OOXMLIMPORT_TEST -> DECLARE_OOXMLEXPORT_TESTXisco Fauli
Change-Id: I06b2f9e4d4b7ec8592b3a882be064484c51b2112 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102245 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-08sw_ooxmlexport6: DECLARE_OOXMLIMPORT_TEST -> DECLARE_OOXMLEXPORT_TESTXisco Fauli
Change-Id: Id5ef4973f4eb93d89b590cd4e5afe87c9f706d76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102243 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-08tdf#136112 Unit test for Date() Basic functionAlain Romedenne
Change-Id: Id6660627e766c6dcd107c3ee483bacb046cae7bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102123 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-08tdf#130445 Use actual icon sizeMaxim Monastirsky
maImageSize was always 0x0, unless the image list was first loaded from a correctly saved file. Just drop it, and use the actual size of the first icon of the list. Change-Id: Ifcda130ed1acdde7ce53dda6f4e1b3636be2bb03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102224 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-09-08Follow the rules when building for the App StoreTor Lillqvist
Apple does enforce that CFBundleVersion and CFBundleShortVersionString consist of three integers. So make sure that is the case when building for the App Store. (We infer that when using --enable-macosx-sandbox we are building for the App Store. So far that is true.) Change-Id: I677b28f65aa9be9466811a982023e0932dce0893 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102237 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-09-08Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to e1165b2f11d933a273f13631e400f9ad5980d134 - tdf#136510 New Writer table functions PRODUCT, ABS. PRODUCT, ABS, COUNT, SIGN Change-Id: I14d33cbb101ee7146bc54d73121805c883dfe7bc Reviewed-on: https://gerrit.libreoffice.org/c/help/+/102248 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-08tdf#134477 add VclMessageType::Other to indicate image-less generic InfoBoxCaolán McNamara
Change-Id: I76e86bf4d82b33771ea2900517712be57ae7f03d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102232 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-08Add reference to spec to the commentMike Kaganski
Change-Id: I5085c1530fd0aacf31e775aac81d98cc1f88bd87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102131 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-08Fix typos in commentsStephan Bergmann
Change-Id: I8a8108ae970613559a68d996dddcee485ddc052f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102235 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-08tdf#125099: sc_subsequent_filters_test: Add unittestXisco Fauli
Change-Id: Ie63b0c9c6d2228fc9a4a9b1e084df2ada0a1f951 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102233 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-08tdf#127932 fix wrong page number in print progressJuergen Funk
- in ctor, reset start pages to non-inflated value after size calculation - update label, _then_ progress in setProgress() Change-Id: I66576e339de814922512b68167e6c0a9b1025378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102031 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-09-08cid#1186122 Big parameter passed by valueCaolán McNamara
Change-Id: Ifbc7129280a172407997c56aaab41c33433f99a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102230 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-08cid#1466647 Resource leakCaolán McNamara
and cid#1466652 Resource leak cid#1466655 Resource leak cid#1466662 Resource leak Change-Id: I0f1bc254519dd79442493890dfdff3c1f9ce87d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102229 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-08Check range before accessing Calc sort userlistThorsten Behrens
Change-Id: Ib5078dc4ce3f85be9b42320b60ef6fc40b684cb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102140 Tested-by: Jenkins Tested-by: Serge Krot <Serge.Krot@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-09-08tdf#95640 XLSX: import/export of custom sort listsSerge Krot
Change-Id: If5ffef39770bf7abd6e75e8de998d4a2b4749a0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97399 Tested-by: Jenkins Tested-by: Serge Krot <Serge.Krot@cib.de> Reviewed-by: Serge Krot <Serge.Krot@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-09-08cid#1466654 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ic8760df2b5ddbe281aa8e6c21a79eb5675274650 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102228 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-08tdf#136468 Added a new check for objects and nodes.Stefanenko
Floating objects with text create problems with reading order A new check for floating text field inserted into checkObject function and into node-checking mechanism. Change-Id: Ice97d8a3e24de21ee6c6d2b0a6f89c348f665c8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101994 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-09-08try harder to not duplicate large memory usage in SkiaSalBitmapLuboš Luňák
This is an extension of a9f68d9d9ae8d7c8f79152055795044993b252ea. Try also to drop the image if converting back to buffer, and also try to do the same with the alpha image if the conversion is simple. Change-Id: I88f6f9d37a1e527c2d6c083ee9744959571534ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102209 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-08conserve memory used by SkiaSalBitmap buffers also for 32bit buildsLuboš Luňák
Since 32bit builds have limited address space, so with large images they can come more easily under memory pressure. Change-Id: Ie63baceaa4a0f8bed137e85fa8951bd714c6b31c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102208 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-08make SkiaSalBitmap debug also log bit count and palette presenceLuboš Luňák
Change-Id: I68143ae7ed1c55b035999ea5babec6e1b3aa72d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102210 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-08longer watchdog timeouts for debug Skia buildLuboš Luňák
Skia runs internal checks, which occassionally actually may take a bit. Also abort() in dbgutil build already in case the watchdog disables Skia, to make finding these easier. Change-Id: I9ed09c57414e056de20a561b6945cba930edd37b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102096 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-08prefer 8bit bitmap masks to 1bpp masksLuboš Luňák
Similarly to df9f0e3cc57fb69ee38918b25ed91d97d1972685, 8bpp bitmaps are faster. Change-Id: Ied2dffd7987e1e1ab3f6b1e5d1d64fe140023320 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102207 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-08tdf#136545 use pre-existing cairo_surfaceCaolán McNamara
for the cairo-canvas case which has a surface for the drawable already created. Vaving two of them, one via cairo_xlib_surface_create and one via cairo_xlib_surface_create_with_xrender_format both alive at the same time seems understandably unreliable. This aligns the gen+X11 case closer to the gtk3 case wrt the situation of tdf#127529 Change-Id: I411649ee36fa944b77c4b09f940a059f507be2cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-08tdf#120547: sw_ooxmlimport2: Add unittestXisco Fauli
Change-Id: Ic3ec35740236feb62889584ef24c3d6e5a84cac4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102190 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-08tdf#135149 sw: fix deleting textbox of as-char shapesMiklos Vajna
Regression from 7596e26fd259ce5445212949403e7cd32303b2bd (Add SwTextBoxHelper::findShapes, 2014-06-24), the problem was that in case the shape is as-char anchored, then DeleteSelection() returns false, and so the textboxes of the deleted shapes are not deleted. There is no real reason why deletion should be conditional on the DeleteSelection() result, so just move it outside that block, so textboxes are always deleted. Change-Id: Ib3bd444e9e96f9de0f68a9162ab39255ec5a6807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102198 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-08Remove some unused const variablesStephan Bergmann
Change-Id: Ida4f482c6477d73728c49302af19a4c9e73a9aae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102203 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-08fix crashtest ooo53770-1.odtNoel Grandin
Change-Id: I0a3a63e8c4146c2f8a9ac6593774e6e4d9f5b8ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102201 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-08tdf#34759 fix media player pausing when pressing time sliderMartin van Zijl
Change-Id: I196549f168d67895510a239640c492cfc421fb07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97644 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-08starmath: stop change to caret pos graph when moving after braceLuke Dixon
Currently, the code that moves the cursor after the brace changes the current caret pos instead of moving to the next pos. Because of this, we end up with one missing graph pos and a duplicate graph pos. This can be seen by moving to the end of a brace body, pressing the key for the closing brace and then pressing left and right to move in and out of the brace. This fix uses the existing code that sets the cursor position to the next element in the graph instead of changing the cursor pos directly. It also marks the caret pos as const to suggest not changing the caret pos inside a graph entry. Change-Id: I5492e54f1bddbfc90036f29698982fd8696f5e88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-08Remove some unused const variablesStephan Bergmann
Change-Id: Ib27249e9d4c9c7669a2766ec501e02652199c670 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102202 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-08Simplify PDFWriterImpl::appendLiteralStringEncrypt, taking std::string_viewStephan Bergmann
Change-Id: If2a0a9abbc8951ce64b89659f455edd280893860 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102205 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-08Simplify GetVendorNameFromId, returning std::string_viewStephan Bergmann
Change-Id: Ida709a432a1892494a767da3979afdc3ee4477b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102206 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-08Use PRODUCTNAME_WITHOUT_SPACES for SDKDIRNAMETor Lillqvist
Change-Id: I2e3e45ffba563dc1b13b3b66346debd9690d0abe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102211 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-09-08tdf#108673 XLSX: Don't export invalid sheet references in cell validationSerge Krot
Change-Id: Id9d88f5e34f3017516f693505df4c3ce82b1890f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98479 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-09-07tdf#136471: Applying a spell checker suggestion adds the result ..Tamás Zolnai
also to the autocorrect replacement list Change-Id: I68d055fd55ffae210fff59ada1b925cdf7b34fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102193 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-09-07loplugin:singlevalfieldsNoel Grandin
Change-Id: Ib3c8dc4e98ca46026ec9a8171bae4066bcec7b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102176 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-07tdf#136323 qt5: Remember accessible objectMichael Weghorn
'QAccessibleCache::insert' from the Qt library has a 'Q_ASSERT' checking that the corresponding 'QObject' for which the 'QAccessibleInterface' provides information is actually the same as the object passed as a parameter: QAccessible::Id QAccessibleCache::insert(QObject *object, QAccessibleInterface *iface) const { // ... QObject *obj = iface->object(); -> Q_ASSERT(object == obj); However, 'Qt5AccessibleWidget::object' so far was always returning 'nullptr', triggering this assert when using a Qt version not built with 'QT_NO_DEBUG'. To fix this, remember and return the object as needed. Change-Id: I4015b4c37aa8a073b02465df580a7235884e6cf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102196 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-09-07Fix typoAndrea Gelmini
Change-Id: Ie584ee9bece01ea92f5cc9f21a402ae9e8319710 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102189 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-07Make the OUString ctors taking raw sal_Unicode pointer/non-const array explicitStephan Bergmann
...and in turn add OUString::operator = and OUString::operator += overloads that take a std::u16string_view. Without making the ctors explicit, the operator overloads would have caused ambiguities when called with raw sal_Unicode pointers/non-const arrays, as those can convert to both OUString and to std::u16string_view. But the std::u16string_view operator overloads will generally be useful when changing OUStringLiteral similarly to 4b9e440c51be3e40326bc90c33ae69885bfb51e4 "Turn OStringLiteral into a consteval'ed, static-refcound rtl_String", at which point many existing uses of OUStringLiteral will be replaced with uses of std::u16string_view. Implementing this change turned up a need for an operator = overload for OUStringNumber, which has thus been added. No such need turned up for a corresponding operator += overload, but which can easily be added when the need arises. It also revealed that the operator == overloads between an OUString and a raw sal_Unicode pointer/non-const array were implemented rather inefficiently, creating a temporary OUString from the raw argument. Those have been improved. Preceding commits have already taken care of many dubious or simply unnecessary implicit uses of the now-explicit OUString ctors. This commit makes explicit the few remaining reasonable uses. (And in some cases needed to change variable initialization syntax from using parentheses to using curly braces, to avoid the most vexing parse issue. And needed to explicitly add OUString ctors from char16 const[2] string literal lvalues in a conditional expression in writerfilter/source/ooxml/OOXMLFastContextHandler.cxx that are only necessary because MSVC apparently still insists on doing array-to-pointer decay there.) All of this only affects LIBO_INTERNAL_ONLY. Change-Id: I7ce31162e9be1c3ff3c0bd184a34b535ec56be9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102098 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-07SVG export: fix failure on trying to read graphic of a 3D shapeMiklos Vajna
Regression from commit 8fc1b60f62c213a0476f3acc9f89cd5eccbf335d (sw SVG export: try to reuse original bitmap data for JPG and PNG bitmaps, 2020-02-27), which generalized the code that tries to get the original bitmap of shapes for performance reasons. Originally this worked with SdrGrafObj, but now we try every XShape which has a Graphic property. Add the missing check, so shapes without a graphic property just miss the fast path, but doesn't fail the entire SVG export. Change-Id: I6b20083110f3269337b9df6a23bd193cc6f7d13b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102187 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-07loplugin:constantparamNoel Grandin
Change-Id: I83722d99fa0d5919a7e878d32311dbb6de1c6714 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102175 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-07loplugin:unusedfieldsNoel Grandin
Change-Id: Id1b1c07ddcacca8eef8af71890d9392f29b6be6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102172 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-07loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I596ef2603560f521386e273b6f0fb2f672db56d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102171 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-07Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 14a72851d401d86cf9fd72a5e139ab87eb0f47d1 - update translations for master and force-fix errors using pocheck Change-Id: I95203f89a4148dd4f91a2a438c5c9811ac2dbe44
2020-09-07tdf#135949 writerfilter: don't bRemove if anchoredObjectsJustin Luth
Surprised it took so long to find an example of an anchored object on the empty paragraph. I considered making a more useful function, but I didn't want to return a pointer, and my skills and understanding aren't good enough to intelligently return an empty vector reference, so I just left it as I first created it. It seems a bit silly to make a bool function just for this, but nothing returns anything that I wanted to use. So I just made a perfect-fit function for my unique need here. I would have preferred to create a potentially re-useable and flexible function... Change-Id: I8c2527403cd8059223d4bc610b10243656b1db3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102060 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-07fix warning of OutputDevice::Push calls != OutputDevice::Pop callsCaolán McNamara
Change-Id: I8f6a3756d48b1727f9ac64c2e162be148e1c61d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-07Android: re-enable pdfiumMiklos Vajna
This was disabled by accident at some stage, the original commit b6f9eeb9b5c0e29ca655185dc299ebd4a2c092d7 (external: bundle pdfium, 2017-02-08) did have Android enabled back then. Change-Id: Ia875ba6c663d74e6c9061f4ffe814bc124431abe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102155 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-31 22:54:33 +0000