summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-29weld fpicker clusterCaolán McNamara
Change-Id: I6566263809ff0032388a0b56571f0cf7428058d7 Reviewed-on: https://gerrit.libreoffice.org/81334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29Remove unused XMouseMotionListener from PresenterControllerSamuel Mehrbrodt
Change-Id: I0b29f3dc300f71b13bc5c7844f1bcf34591dba19 Reviewed-on: https://gerrit.libreoffice.org/81651 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-29loplugin:finalclasses filter..frameworkNoel Grandin
Change-Id: Ic4d0a2946c925035d60defc4d25caea05535adbc Reviewed-on: https://gerrit.libreoffice.org/81654 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29this help case doesn't arise anymoreCaolán McNamara
Change-Id: I844f3b310e74652e3b310053a1254e06045c4506 Reviewed-on: https://gerrit.libreoffice.org/80334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix wrong/obsolete embeds Change-Id: I59e5a18c403caef79b1f08a8575c310faa724f08 Reviewed-on: https://gerrit.libreoffice.org/81659 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-29Remove unused XFocusListener from PresenterControllerSamuel Mehrbrodt
Change-Id: If953ae5cbe74d918d435c9f90189a9f228181ccc Reviewed-on: https://gerrit.libreoffice.org/81650 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-29loplugin:finalclasses in editengNoel Grandin
Change-Id: Ie9da2c57fa9cd355dc5826cf5afd1c5b84cd22d7 Reviewed-on: https://gerrit.libreoffice.org/81648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29Remove unused XMouseMotionListener from PresenterButtonSamuel Mehrbrodt
Change-Id: I2ee99fa24fa949aedcd8d94fff68449441b9da6d Reviewed-on: https://gerrit.libreoffice.org/81646 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-29Remove unused XWindowListener from PresenterButtonSamuel Mehrbrodt
Change-Id: I98da5679e108f3684243ce4cca03ad54b9fee84a Reviewed-on: https://gerrit.libreoffice.org/81645 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-29loplugin:finalclasses in drawinglayerNoel Grandin
Change-Id: I24e5187f603f66ef87f10a1b197907c5b869cfd1 Reviewed-on: https://gerrit.libreoffice.org/81644 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29cid#1453992 Dereference after null checkCaolán McNamara
presumably pInputHdl cannot be null Change-Id: If7fe7b43a23c5d917a18b09f46226c5b8e6009a1 Reviewed-on: https://gerrit.libreoffice.org/81626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29Resolves: tdf#128410 wrong size request for dialogCaolán McNamara
Change-Id: I880b00680723c7f8bac52dedc9aa7a1a6ba49e52 Reviewed-on: https://gerrit.libreoffice.org/81627 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29Related: cid#1448329 call GetSbData() just onceCaolán McNamara
rather than every time its result it needed to deconvolute this a layer Change-Id: I1a611ed2bd74e682501cf8cbd64a5e285ec1c7e9 Reviewed-on: https://gerrit.libreoffice.org/81628 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29cid#1448471 Wrapper object use after freeCaolán McNamara
Change-Id: I4a6f31491f857280623302569afa982b37c16e89 Reviewed-on: https://gerrit.libreoffice.org/81629 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29cid#1455158 Explicit null dereferencedCaolán McNamara
Change-Id: Icdf6dd9bee5f917a6a6b26b3d80c0502a656948b Reviewed-on: https://gerrit.libreoffice.org/81625 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29loplugin:finalclasses fix checkNoel Grandin
need to check after we generate the inherited-from set, not before Change-Id: Ic66deeb680f4a2505d66f99872ac7a5bc263cda9 Reviewed-on: https://gerrit.libreoffice.org/81636 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29tdf#104017 DOC export: be less aggressive with merging page stylesMiklos Vajna
Regression from commit 7146d8bcd96f844dc0239a5b29a6b36c3cb5a2cc (MSWordExportBase::OutputSectionBreaks: avoid fake section breaks, 2014-07-28), the problem was that we merged two separate page styles just because they were similar. This resulted in merging two independent tables into a single one. Fix the problem by merging the first and follow page style only in case the first page style is RES_POOLPAGE_FIRST, this resolves the current problem and keeps the original problem fixed, too. (Long-term, a better fix would be to not split the page styles in writerfilter/, similar to how the DOC import doesn't do that anymore: and then the merging can be avoided unconditionally.) Change-Id: I357f1337cb0abc7fa1d88aa44ff87b4b464af81c Reviewed-on: https://gerrit.libreoffice.org/81630 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-29Adapt commentStephan Bergmann
external/icu/clang-cl.patch has been dropped by 398e1e6ae83999eea8fb8c845190667695ac115f "Upgrade to ICU 64.2" Change-Id: Ic1ab2b02820cc15f9b14bdaab4554e1da5234623 Reviewed-on: https://gerrit.libreoffice.org/81638 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-29loplugin:finalclasses in connectivityNoel Grandin
Change-Id: I8f85331338247d4b144c5d5487c2fb59c5237dff Reviewed-on: https://gerrit.libreoffice.org/81637 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29remove XclRoot::GetDocRefNoel Grandin
duplicate of GetDoc Change-Id: I4b4d261684cbff4513a797b9b5af76f11737b980 Reviewed-on: https://gerrit.libreoffice.org/81635 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29external/icu: Fix UBSan nullptr-with-nonzero-offsetStephan Bergmann
...(new with Clang 10 trunk), as seen during ExternalProject_icu: > rbutil.c:49:67: runtime error: applying non-zero offset 1 to null pointer > #0 in get_basename at workdir/UnpackedTarball/icu/source/tools/genrb/rbutil.c:49:67 > #1 in make_res_filename(char const*, char const*, char const*, UErrorCode&) at workdir/UnpackedTarball/icu/source/tools/genrb/genrb.cpp:768:5 > #2 in processFile(char const*, char const*, char const*, char const*, char const*, SRBRoot*, signed char, UErrorCode&) at workdir/UnpackedTarball/icu/source/tools/genrb/genrb.cpp:695:14 > #3 in main at workdir/UnpackedTarball/icu/source/tools/genrb/genrb.cpp:527:9 > rbutil.c:54:67: runtime error: applying non-zero offset 1 to null pointer > #0 in get_basename at workdir/UnpackedTarball/icu/source/tools/genrb/rbutil.c:54:67 > #1 in make_res_filename(char const*, char const*, char const*, UErrorCode&) at workdir/UnpackedTarball/icu/source/tools/genrb/genrb.cpp:768:5 > #2 in processFile(char const*, char const*, char const*, char const*, char const*, SRBRoot*, signed char, UErrorCode&) at workdir/UnpackedTarball/icu/source/tools/genrb/genrb.cpp:695:14 > #3 in main at workdir/UnpackedTarball/icu/source/tools/genrb/genrb.cpp:527:9 (uprv_strrchr appears to be plain strrchr, see workdir/UnpackedTarball/icu/source/common/cstring.h, so returns null for "not found", and in both of the fixed places, the following if(lastSlash>filename) was apparently meant to filter out cases where uprv_strrchr returned null.) Change-Id: I32b3a72955d33d73fa4295cf5f91a69fd270efeb Reviewed-on: https://gerrit.libreoffice.org/81613 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-29loplugin:finalclass in comphelperNoel Grandin
Change-Id: Ic64151191e46dff81c0a5cb8377f89e1e4afb269 Reviewed-on: https://gerrit.libreoffice.org/81624 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add screenshot for New Doc hyperlink help page Use kde5 breeze theme Change-Id: Ida64f6ea49f5f381ae61aa52195a592138d7636e Reviewed-on: https://gerrit.libreoffice.org/81633 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-29tdf#108202: Correct Draw page naming in insert pages, and page naming dialogsMuhammet Kara
Change-Id: I2485bc29d6286cc30436fa9ecfb29e724578db41 Reviewed-on: https://gerrit.libreoffice.org/81631 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-10-28Android: document one SDK version that worksMiklos Vajna
configure.ac doesn't check for any version as far as I see, add what works for me at the moment. Change-Id: If8b28e2a5d4bf4aea4325038ddf416a43f904db4 Reviewed-on: https://gerrit.libreoffice.org/81621 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-28loplugin:finalclasses in avmedia..basicNoel Grandin
Change-Id: Ia54364237149fac38e6ebcc5fcf9933d0ccf5984 Reviewed-on: https://gerrit.libreoffice.org/81619 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-28loplugin:finalclasses look for classes with virtual membersNoel Grandin
where making them final gives the compiler freedom to de-virtualise some calls Change-Id: I5755a41c42d9f23af58b873efae37a1d240fbd89 Reviewed-on: https://gerrit.libreoffice.org/81618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-28headless: optimize DrawWaveLine / drawPixel.Michael Meeks
ImplDrawWaveLine - used to render colored lines under mis-spelled and/or grammatically interesting sections uses (for better or worse) 'drawPixel' to draw the line. Implementing drawPixel with a tiny B2DPolyPolygon is easy reading but triggers the unbelievably expensive SystemDependentDataHolder paths as well as some big chunks of logic for very large numbers of pixels (if you have lots of mis-spelling this can make typing visibly slower.). Change-Id: Ie6ad513e27f820bcad5030579428374c8d22fb3d Reviewed-on: https://gerrit.libreoffice.org/81622 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-28cid#1448338 silence Untrusted value as argumentCaolán McNamara
Change-Id: I8adc878b3ddb11940f5aadd6cf3d1738eaebbce2 Reviewed-on: https://gerrit.libreoffice.org/81609 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add screenhshot for Hyperink Mail help page Use kde5 breeze theme Change-Id: I9976779b3a6455c42a4a70c68060982ad35de3e2 Reviewed-on: https://gerrit.libreoffice.org/81617 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add screenshot for hyperlink internet help page Use kde5 breeze theme Change-Id: I138474c651c198754871cac87fec399f8ff9e368 Reviewed-on: https://gerrit.libreoffice.org/81614 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add screeshot for Hyperlink Doc page Use kde5 breeze theme Change-Id: I96b8e60f0ab5459c0c57ac0c187bb6f5e0840cd6 Reviewed-on: https://gerrit.libreoffice.org/81601 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add screenhot in Font effects Help page Use kde5 breeze theme Change-Id: I3e8d7cc5358f4811c74af9675382a7acca9aa808 Reviewed-on: https://gerrit.libreoffice.org/81595 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-28svl: HTMLParser: stop inserting control character garbage into WriterMichael Stahl
E.g. rhbz433940-1.html contains literal ^G characters that are inserted as-is into SwTextNodes. This now triggers assert about CH_TXT_ATR_FIELDSTART in SwSubFont::GetTextSize_() that was added in 19a559b0ec9b806519c405651d6d2b2e14712b4a. Change-Id: I6aa7de41a04069e15b40865fd57894dae0fc10db Reviewed-on: https://gerrit.libreoffice.org/81606 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2019-10-28Related: tdf#125038 DOCX import: fix unexpected MERGEFIELD result inside IFMiklos Vajna
The problem is that DOCX supports nesting MERGEFIELD fields inside IF fields, while SwHiddenTextField only supports a single string as a condition. This means in case there are MERGEFIELD fields inside the IF field, those fields will be inserted to the doc model before the IF field, exposing their value, while Word only uses their value during the evaluation of the IF expression. Fix the problem by inspecting the parent field command before setting the MERGEFIELD result. Change-Id: Ieca098f16f756bab5d23f219fa4ca30d077d4bb7 Reviewed-on: https://gerrit.libreoffice.org/81615 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-28Upgrade to ICU 64.2Eike Rathke
As an interim step to upgrade to ICU 65.1 Adds new scripts and Unicode blocks from Unicode 12. Change-Id: Idc4a6b29ffb04bcb424522fcbd29a8db0428c056 Reviewed-on: https://gerrit.libreoffice.org/81611 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-10-28Related tdf#117790: Caption order, caption positions for Lithuanian languageJulien Nabet
I used Stephan's comment, see: https://bugs.documentfoundation.org/show_bug.cgi?id=117790#c7 Modestas Rimkus' comment, see: https://bugs.documentfoundation.org/show_bug.cgi?id=117790#c11 Change-Id: Icec673426a47f4308c2810c5e1beed1011c13374 Reviewed-on: https://gerrit.libreoffice.org/81612 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-28tdf#128418 Fix crash in print previewSamuel Mehrbrodt
Change-Id: I2a8c5511563ac3205722d63f22cde472a8aaddde Reviewed-on: https://gerrit.libreoffice.org/81610 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-28Blind fix for Android build ('unsigned int' vs. 'unsigned long')Stephan Bergmann
Change-Id: I04de54231abb8b34c93cbcb96c21cae78d90bfd4 Reviewed-on: https://gerrit.libreoffice.org/81608 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-28jsdialogs: allow to use transparent highlightSzymon Kłos
Change-Id: Ib19dbbf3c13afd20bee47226704887f899c99b5d Reviewed-on: https://gerrit.libreoffice.org/81597 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-28related tdf#99602 writerfilter TODO: subscript - use CharStyle fontsizeJustin Luth
GetAnyProperty was missing a check for character style properties. This patch depends on commit 875793d841165aaaaefa2c34b855e8f0f8a8c214 related tdf#99602 writerfilter TODO: subscript - use ParaStyle fontsize and on commit 5e97d1a57717f8dbf69b987d2bda8616972eec52 NFC writerfilter: preparation for adding CharProps to GetAnyProperty Change-Id: I4e28589917e41fa545d5aab05f97a67502486136 Reviewed-on: https://gerrit.libreoffice.org/80216 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-28tdf#121441 improve DOCX footnote importJan-Marek Glogowski
ODF represents footnotes by using a fixed string for the label (text:note-citation) and a flexible body (text:note-body) for the representation in the footnote area. The only formatting of the footnote reference is done by changing the character class assigned to the anchor (which is the text range of the label in the text). For most of the setting, the footnote area label just follows the footnote body character formatting. OTOH MS Word has no such "restrictions". It handles the label just as concated, formated text runs with the same style. On top of it, DOCX completely splits the reference from the footnote area part, including its own label, which can easily result in completely different labels for the footnote and the reference, as I happened to repoduce for my test documents. At this point it's quite obvious that for any complex footnotes, LibreOffice won't be able to represent them. IMHO ODF should offer the same flexibility for the label and the body and allow all the normal formatting in the label. I'm not sure that getting footnote area and reference label out of sync is a good idea. So this patch tries to improve the situation in the current constraints set by ODF. 1. It imports all runs of the whole custom DOCX footnote label. 2. If any run contains a symbol, switches the font of the whole label to the referenced symbol font. 3. Completely ignores the label of the footnote area and overrides the font of the footnote area label with the font of the reference. Other problems I found while testing this code: 1. LO edit field correctly gets the font and character set, but displays empty glyphs. So no real way to edit the label. 2. Normally the font of the footnote area label would follow the footnote font. This doesn't work anymore when the font is overridden for the label. Setting the whole font of the label to Symbol doesn't seem like a good solution either. 3. You can't mix multiple fonts, or even symbols and letters, as you can just select one font for the label. 4. You can't change the footnote are label font at all and since it doesn't follow the footnote area anymore, there is basically no way to change it. Change-Id: Iafa16936be81e1866c610ebf0f71ab15e74dd059 Reviewed-on: https://gerrit.libreoffice.org/81370 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-10-28jsdialogs: fix .uno:BackColor commandSzymon Kłos
Change-Id: I628067afa4c3a8d28c5c3635c4e5e46f9febdf94 Reviewed-on: https://gerrit.libreoffice.org/81602 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-28jsdialogs: make possible to set .uno:BackgroundColor in WriterSzymon Kłos
Change-Id: Ifd6a63683ddf36a3c1e8babd9c030ae5f051ed00 Reviewed-on: https://gerrit.libreoffice.org/81596 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-28Completely remove lambda capture that is unusedStephan Bergmann
...since 6d6fad522a2cd6a2959ea774969a86288f5a3cb7 "Introduce OStringChar" (and had needlessly been kept alive with ce3badb157c58941608f878a7de98c7739e30aec "compilerplugins: fix -Werror,-Wunused-lambda-capture") Change-Id: Ie34ef1197f97ecab5b8f30741f1e2c4b3a9db594 Reviewed-on: https://gerrit.libreoffice.org/81591 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-28Fix build with poppler-0.82Rasmus Thomsen
Change-Id: I3b6b3faea7986f3e5a6ae4790580d03bc9c955fc Reviewed-on: https://gerrit.libreoffice.org/81545 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-28loplugin:stringadd improve detectionNoel Grandin
if one side of the expression is a compile-time-constant, we don't need to worry about side-effects on the other side Change-Id: Iee71ea51b327ef244bf39f128f921ac325d74e2b Reviewed-on: https://gerrit.libreoffice.org/81589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-28cid#1455157: sw: Memory - illegal accesses (WRAPPER_ESCAPE)Michael Stahl
(regression from b522fc0646915d4da94df38dd249c88b28f25be7) Change-Id: I54f93ac16a2d4ddc687937d44c3aec450e59dd0e Reviewed-on: https://gerrit.libreoffice.org/81588 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-28jsdialogs: make possible to set .uno:BackColorSzymon Kłos
Change-Id: I2fd9a70b54f211dbfe9bb58102e17afd38516d5d Reviewed-on: https://gerrit.libreoffice.org/81587 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-28tdf#42949 Fix IWYU warnings in accessibility/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iddc1d33f5a520febf1bb317861acc2880595e7bf Reviewed-on: https://gerrit.libreoffice.org/81358 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2024-12-29 18:15:16 +0000