summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-12-18loplugin:duplicate-definesNoel Grandin
looks like these were left behind when the associated *Item classes were moved from svx to editeng Change-Id: I09bf48396e18a9f1a6dddb65618affc782777c25 Reviewed-on: https://gerrit.libreoffice.org/85341 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18sw RTF export: don't mark these members as constMiklos Vajna
As the destructor wants to std::move() these members, and that only has an effect if the member is not const. Simiarly in writerfilter/, there the const prevents the implicit std::move() on return. Change-Id: I42ce393da9033abbd028bd5b83f15f69d34e254d Reviewed-on: https://gerrit.libreoffice.org/85336 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-18Fix debug build after 7732444c5d4e79ae0218932afe85bcc4b56a00a4Mike Kaganski
UnitTypeToString was defined static in emfphelperdata.cxx, and was absent in any header included in emfpfont.cxx, so it's unclear how could it pass all the build tests. Change-Id: I87f966d3cde5d04ab3d364ee0d583adbdc2cc2c0 Reviewed-on: https://gerrit.libreoffice.org/85355 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-18Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics)Noel Grandin
Change-Id: I522c42d1fe97de2b1a8a629c97cf68e11006a328 Reviewed-on: https://gerrit.libreoffice.org/85327 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18Colibre icon remove symbolic link from colibre-svg iconsandreas kainz
Change-Id: I993ab3fb57bedaf6c6c1c1946c52eeab7c622acb Reviewed-on: https://gerrit.libreoffice.org/85345 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-18loplugin:duplicate-definesNoel Grandin
not used outside the .cxxx file, so move them there Change-Id: I1043d58bfa849c67a572d53c4cc60fc7e227d508 Reviewed-on: https://gerrit.libreoffice.org/85337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18Remove unused exception imports from updatefeed.cxxAlex Henrie
This reverts commit 1e73a1bfab8abe658e2864ae1512737e489dfb0f. Change-Id: I5f3c62ffafd3e15b62227766e15a944c76d11978 Reviewed-on: https://gerrit.libreoffice.org/84294 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18writerperfect[libwps,tdf#128673]: use the inFilter option in headless mode...alonso
Change-Id: I494360ddb55e39e09edf03aaf0bf6a01dc432f83 Reviewed-on: https://gerrit.libreoffice.org/82595 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18loplugin:duplicate-definesNoel Grandin
already defined in pivotrow_curs.h, so just delete this one Change-Id: I1c60bef657a8312cad29ede09c4f6925f0f0e15c Reviewed-on: https://gerrit.libreoffice.org/85340 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18loplugin:duplicate-definesNoel Grandin
this one is shared between multiple cxx files, so remove the local one Change-Id: I9f6d06db04febd1bae616b4f87543066b1212f0f Reviewed-on: https://gerrit.libreoffice.org/85339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18loplugin:duplicate-definesNoel Grandin
already defined inside the .cxx file, so just delete the one in the .hxx file Change-Id: I2b8eb1dde1365276ef0cddb89d6016348708f5e6 Reviewed-on: https://gerrit.libreoffice.org/85338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics)Noel Grandin
Change-Id: I34f801d1d56868b89027f10e0567004f1b8a4cc7 Reviewed-on: https://gerrit.libreoffice.org/85331 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics)Noel Grandin
Change-Id: Ib0965f57cb929a220fc9df381abdca654985c9de Reviewed-on: https://gerrit.libreoffice.org/85330 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics)Noel Grandin
Change-Id: Ie3e099a6561c22646f07dab418f1a2f8123f1449 Reviewed-on: https://gerrit.libreoffice.org/85329 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics)Noel Grandin
which does not seem to have been doing anything useful here anyway, not since commit 730399de90add4e35da9754a8f7525b443237026 Date: Wed Jul 18 11:16:06 2007 +0000 INTEGRATION: CWS unomacli64 (1.6.50); FILE MERGED 2007/06/20 10:29:46 kr 1.6.50.1: fixed: #i78284# Change-Id: I57345a08c333953a66b3a5f3be1fe9a2f1f092ef Reviewed-on: https://gerrit.libreoffice.org/85328 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18tdf#127294 Remove spaces; follow design guidelines for tips-of-the-daySeth Chaiklin
- converted to design guidelines all quotes all menus items apostrophe (U+2019) em-dash (U+2014) minus (U+2212) expanded contractions - Corrected spelling and grammar mistakes. - Simplified wording in some tips - tried to clarify uri explanation in relation to help Change-Id: Ic9984fdc09813d2b43324a104d5c30420671c6b9 Reviewed-on: https://gerrit.libreoffice.org/85228 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-18Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Fix repetition Change-Id: I133f5d6d70a39d2ccd90f4a16d579c0e3225108e Reviewed-on: https://gerrit.libreoffice.org/85349 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-18tdf#129459 drawinglayer: fill shapes with solid color brushChris Sherlock
EMF+ shapes were not filling when the brush style is a solid color. This patch fixes this issue. Change-Id: I6a2b12e514af9a85f50198dceee642fac8df2f1b Reviewed-on: https://gerrit.libreoffice.org/85343 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-12-18drawinglayer: improve logging for fontsChris Sherlock
Change-Id: I5b430360894dc1738445820679ceaf09edfeef55 Reviewed-on: https://gerrit.libreoffice.org/84840 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-12-18Resolves: tdf#129396 Refresh shared formula group area listeners upon shiftingEike Rathke
Regression from commit 47230a036fe35b9a7a7c0609232849fcbb51efcc CommitDate: Thu Feb 5 11:52:51 2015 +0100 Resolves: tdf#88792 do not hold a ScFormulaCell** in group area listener where previously the listener position's column was taken from the group's remembered top formula cell (then updated) position, which holding the cell was wrong in other cases. Change-Id: Ida1503daa7cbda2b41459ff5d63652a6febd91e0 Reviewed-on: https://gerrit.libreoffice.org/85347 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-12-18vcl: sfx2: LOK: Support per-view popup windowsAshod Nakashian
While we do support multiple views, there is only one state for popup/floating windows, that also includes the dialogs open and related windows/data. This adds support to allow each view to have its own popups and state, thus allowing multiple users to interact with the dialogs independently of one another. (cherry picked from commit b50c341a53911f1d725947a4d8d3d2f782c94079) Change-Id: I3786a561ca6ca113ad12425bdb491e5a30bd1a28 Reviewed-on: https://gerrit.libreoffice.org/82440 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/85221 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-17ofz#18534 sw: WW8 import: avoid creating redlines that overlap...Michael Stahl
...with fieldmarks, as the editing operations already do. This was triggering ~SwIndexReg assert when creating this redline: $4 = "     \b\nfür \a\003     \b\nKlasse \a\003     \b\t\tSchuljahr \a\003     \b\t\a\003  \b. Halbjahr\nLeistungsbeurteilung lt. Konferenzbeschluss vom " Change-Id: I904be93e044c4b98bb8c806357ed061692303c7a Reviewed-on: https://gerrit.libreoffice.org/85149 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-17unfold the gtk-related inline we don't need anymoreCaolán McNamara
Change-Id: I9b5ef4cc4e00649c4609bb576c01ce2ea15e4fdd Reviewed-on: https://gerrit.libreoffice.org/85309 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-17Cosmetic documentation fixesStephan Bergmann
consolidate on "Linux", "macOS", "Unix-like systems", "Windows", "Xcode" Change-Id: I448adee41cd557544b9c717ce7663c6fd08a7270 Reviewed-on: https://gerrit.libreoffice.org/85332 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Maintenance in Fontwork Help page Change-Id: I08c5008881d44e54a8ae2d014cf0c254f9e8b190 Reviewed-on: https://gerrit.libreoffice.org/85310 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Mute L10n in some embedvar cases Change-Id: Ib9078cfec42e652a41417d3ca977818434961945 Reviewed-on: https://gerrit.libreoffice.org/85334 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-17Fix typo in codeAndrea Gelmini
Change-Id: I32f99d6dbdaa52f53bd630b611d13decf110fd75 Reviewed-on: https://gerrit.libreoffice.org/85318 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-12-17sw reqif-xhtml export: add a new RTFOLEMimeType parameterMiklos Vajna
This is similar to commit e0f20211a8048a87b078aa4cf0f28c0c847487ad (sw reqif-xhtml import: add a new AllowedRTFOLEMimeTypes parameter, 2019-12-16), except that was for the import and this is for the import. The situation was similar, SfxBaseModel::impl_store() still had the custom store parameters, but later functions lost it, so at the end OutHTML_FrameFormatOLENodeGrf() in the sw HTML export could not respect it. Fix the problem in a similar way, so the SfxMedium instance created for the duration of the export provides the custom options via SfxMedium::GetArgs(). Change-Id: I71d2c7920f42d98133f345703cfdfd50f0e8550c Reviewed-on: https://gerrit.libreoffice.org/85321 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-12-17Make disabled PDF import tests compile againStephan Bergmann
...if they were enabled, see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2019-December/084003.html> "sd: disable pdf import tests" Change-Id: Ic52972e60ea411baab0f7b0ed0ec6b6057a95e06 Reviewed-on: https://gerrit.libreoffice.org/85238 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-17Removed duplicated includeAndrea Gelmini
Change-Id: Iaa0b6006b53b2f20f9eb6e86f081211bf60d19bf Reviewed-on: https://gerrit.libreoffice.org/85311 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-17Fix typoAndrea Gelmini
Change-Id: Id8deb01adb8111850f317bdbfc363f507c54a7dd Reviewed-on: https://gerrit.libreoffice.org/85315 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-17Fix typoAndrea Gelmini
Change-Id: I08800becb25f04bb30577185259b290f9cc783e3 Reviewed-on: https://gerrit.libreoffice.org/85319 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-17Fix typoAndrea Gelmini
Change-Id: I6326523b8c93b1eeaf03d91bf0370dd98eeb02d9 Reviewed-on: https://gerrit.libreoffice.org/85312 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-17Fix typosAndrea Gelmini
Change-Id: I54554165cc0df1b1f7902e467f0ba6480f4882e3 Reviewed-on: https://gerrit.libreoffice.org/85313 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-17Fix typosAndrea Gelmini
Change-Id: I363cd336389865a9aae3a5d7eb9bbbb2919a3bd9 Reviewed-on: https://gerrit.libreoffice.org/85316 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-17Fix typosAndrea Gelmini
Change-Id: I2671a0faf78d8ece27aaa88082a60f19197e929f Reviewed-on: https://gerrit.libreoffice.org/85314 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-17Fix typoAndrea Gelmini
Change-Id: I64a13c892a5ae8b2c7e9614212be60d9a4300632 Reviewed-on: https://gerrit.libreoffice.org/85317 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-17tdf#112202,tdf#112201 sw: add testMichael Stahl
Let's check via the layout which headers are used. Change-Id: I9fe30192db609d391921930c0e535daf8062e30a Reviewed-on: https://gerrit.libreoffice.org/85305 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2019-12-17Tweak configure to allow Windows builds using VC++ Build ToolsStepas Toliautas
Since Visual Studio 2017 Microsoft offers Build Tools installer package which comes with MSVC++ compiler and can include most toolchains and libraries, but does not require Visual Studio IDE installation. This patch asks vswhere.exe to use path to Build Tools as compiler path (in case Visual Studio path is not found) and lowers 'devenv' detection error to warning with an explanation. Identical build is produced in both cases, and even IDE integration (creation of sln/vsproj) works as usual. Change-Id: I6176d10cc6ea2091c353eb40d13913d8adb8f85d Reviewed-on: https://gerrit.libreoffice.org/85245 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-17tdf#129435: Fix menu referenceXisco Fauli
Regression from 81f01259dfe29b7ee73c42d3b44934d6fc973cd8 Change-Id: Ibeb094d7dfd998322acf88bdc38fe1f15d524e78 Reviewed-on: https://gerrit.libreoffice.org/85306 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-17tdf#112201 writerfilter: try to apply continuous section page style...Michael Stahl
... on the last node of the previous section. This works for this particular document, but it's quite dubious that it will work in the general case; feel free to revert this if it causes problems. Change-Id: Ia03d41a1127df505c4e9da7131323b70d88a285f Reviewed-on: https://gerrit.libreoffice.org/85294 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-12-17tdf#112201 writerfilter: continuous sections:Michael Stahl
always replace break with follow-page-style, not first-page-style. It looks like Word ignores <w:titlePg> on continuous section breaks, unless it's the first section, which was already handled by code above. Change-Id: If7c0fe96a1789f64f1943ece453db3dbc284ca48 Reviewed-on: https://gerrit.libreoffice.org/85293 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-12-17loplugin:duplicate-definesNoel Grandin
seems to be a search/replace error in commit f08faa70ccaa3bbf335b7b2ddff02a9f37efe125 Date: Tue Apr 25 19:21:42 2017 +0100 fix attempt to load converted bitmap resource uses from vcl Change-Id: I882904652c9ecdfc28322cd7b5d05d3507090f2f Reviewed-on: https://gerrit.libreoffice.org/85297 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-17No need to leak ImplRepositoryStephan Bergmann
...after 919689ac876eb051f01a09ef67e8140efaa3df32 "Remove unused preliminary entries from ImplRepository::m_aStore again" makes sure ImplRepository::m_aStore doesn't accumulate references to UNO objects, which would only have been destroyed upon exit, at which point that would easily have caused various issues. Change-Id: I6338a1ff46d72c137d619eabd8facca794028324 Reviewed-on: https://gerrit.libreoffice.org/85296 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-17tdf#112989 reduce export to PDF timeNoel Grandin
reduces the time from 33s to 24s for me Change-Id: Ia70e1c4220ebedf0b686ed76c5704efa551591fe Reviewed-on: https://gerrit.libreoffice.org/85281 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-17Fix various Clang and loplugin warnings in --with-webdav=serf codeStephan Bergmann
Change-Id: I9390d9242b1ea4413ce01bff9002929e55c1617c Reviewed-on: https://gerrit.libreoffice.org/85277 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-17make approximate_char_width private and use approximate_digit_widthCaolán McNamara
Change-Id: I063cb5b9823d374014fd2c8129eba53384b96870 Reviewed-on: https://gerrit.libreoffice.org/85273 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-17Avoid false positive lopluign:vclwidgets warningStephan Bergmann
...about calling delete for a std::atomic<T*>. It ultimately turned out that I didn't need such a std::atomic<T*> variable after all, but it can't hurt to have this fix for loplugin:vclwidgets anyway. Change-Id: I2ca058e9c39efa6c5386e6a320bed4bf8ab5f5d5 Reviewed-on: https://gerrit.libreoffice.org/85266 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-17Convert some defines to constexprMike Kaganski
Change-Id: I78d119857b80d223d6fa8228cee4c0be829627c4 Reviewed-on: https://gerrit.libreoffice.org/85267 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-17tdf#129311 don't allow temporary trusted certsJan-Marek Glogowski
This simply skips the DocumentMacroConfirmationRequest, if the macro security level (MSL) is *High* and the list of trusted authors is read-only. For the MSL *Medium*, the check box of the dialog is hidden with read-only trusted authors. Change-Id: If6c08e4fdbf200e778d181370cc73fd947cecff5 Reviewed-on: https://gerrit.libreoffice.org/84887 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
generated by cgit (git 2.34.1) at 2025-01-01 15:33:48 +0000