summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-12-19tdf#124176: Use pragma once instead of include guardsMesut Çifci
Change-Id: I377809c01053ebaf2fe004478e144509adbbdd1f Reviewed-on: https://gerrit.libreoffice.org/85416 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-19tdf#75806: use actual string leading characters for correct precondition matchMike Kaganski
Having an arbitrary prepended character prevents e.g. matching start of a word for search continuation. Trimming the string to the start of the search breaks correct look-behind assertion matching (e.g. for regexes like `(?<!abc)abc`). As Michael Stahl suggested, we should use actual preceding characters instead of the arbitraty prefix. Let's use up to 100 preceding characters in the hope that this would be fast enough, and yet cover 99.999% of useful assertions. When the search string does not start with a look-behind assertion, use up to 3 preceding characters (to account for UTF-16 surrogate pairs). Change-Id: Ie19238ac792116c1d52fb2454d3142e35b6ed379 Reviewed-on: https://gerrit.libreoffice.org/85382 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-19tdf#124176: Use pragma once instead of include guardsTolunay Dündar
Change-Id: I47be8a0488b7ff7ce176f10aaf90b8be6913cc8a Reviewed-on: https://gerrit.libreoffice.org/85412 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-19tdf#124176: Use pragma once instead of include guardsYusuf Keten
Change-Id: Id65f17c9785e9db3eecfb1fba6902a04906077e5 Reviewed-on: https://gerrit.libreoffice.org/85428 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-19lok: send "EMPTY" if the rect is empty for cell selection or fillTomaž Vajngerl
It can happen that the selection or auto-fill rectangles are empty and if that's the case then we need to send "EMPTY" string and not the content of an empty rectangle (0, 0, -32768, -32768). This can happen for CELL_SELECTION_AREA or CELL_AUTO_FILL_AREA in calc. Change-Id: I9a60e3907a2ab8b0e0fd1a2ff81137fba6c8e9a3 Reviewed-on: https://gerrit.libreoffice.org/85441 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-19tdf#124176: Use pragma once instead of include guardsOnur Yilmaz
Change-Id: I2f58499164254eab1d2f628b3b64710e1d2efbeb Reviewed-on: https://gerrit.libreoffice.org/85415 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-19sw lok: disable Edit Contour button in image sidebarMiklos Vajna
This can be enabled when the underlying dialog is OK under LOK. Change-Id: Id74d20de55e77842d707e345b2193ca9113594e8 Reviewed-on: https://gerrit.libreoffice.org/85435 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-12-18tdf#124176: Use pragma once instead of include guardsDesmin Alpaslan
Change-Id: Ib14b28a9508b28460a6063f7ddd322869823b49a Reviewed-on: https://gerrit.libreoffice.org/85413 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18tdf#128995: Special case for single variable regression...Deena Francis
like in LINEST implementation in Calc. Use a straightforward regression solver in this case, so that it is easier to handle the numerical error in the intercept term using ::rtl::math::approxSub(). Change-Id: I627c0c48e377cac5385a85050c4f472ee963f3d6 Reviewed-on: https://gerrit.libreoffice.org/85222 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-18Link duplicate icons instead of including a copyJan-Marek Glogowski
The respective SVG and PNG versions have the same md5sums, so just list them in the linking file. Change-Id: I479b7d40980707bbba169171dd9279a62080561e Reviewed-on: https://gerrit.libreoffice.org/85394 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-18tdf#124176: Use pragma once instead of include guardsKemal Ayhan
Change-Id: I8f8641d41a3c394c494d0e5f6cd5a06949e22fa6 Reviewed-on: https://gerrit.libreoffice.org/85410 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18Unit test insert with shared formula group shift, tdf#129396Eike Rathke
Change-Id: I99ab71f6fba4eb9f83fe8c262a6549a236ccf1ec Reviewed-on: https://gerrit.libreoffice.org/85422 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-12-18tdf#125949 Check hardware acceleration on slideshow.Gülşah Köse
Follow up commit for 8eb2d2972583b909a249f5b0f22a9b1fbf533d24 Allows animation if hardware acceleration disabled. Change-Id: I7997936435134e36e2bf3d3d54ff1bf157cb205c Reviewed-on: https://gerrit.libreoffice.org/85380 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-12-18only 'null' case is known to be pngCaolán McNamara
Change-Id: I449eb008a34ee1d9f4df748f6e48d2cb62651bef Reviewed-on: https://gerrit.libreoffice.org/85409 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-18reset mxContentArea in disposeCaolán McNamara
Change-Id: I24769a214e4cb546a28202d801256e0514c874cd Reviewed-on: https://gerrit.libreoffice.org/85404 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-18tdf#124176: Use pragma once instead of include guardsYusuf Keten
Change-Id: I1f6d66a0d4a06338671579e9be2dbdc5cd673d50 Reviewed-on: https://gerrit.libreoffice.org/85411 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Typos and more Change-Id: I19c74d02a138299bad88b5e9d7c01a101c381717 Reviewed-on: https://gerrit.libreoffice.org/85390 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-18sal_Char->char in connectivityNoel Grandin
Change-Id: Ie32cbef9b03d69044c401f79bc737cde6dd0ed5d Reviewed-on: https://gerrit.libreoffice.org/85396 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18sal_Char->char in comphelperNoel Grandin
Change-Id: I63488463f2255a013cb80a9318d22207cb0ed532 Reviewed-on: https://gerrit.libreoffice.org/85395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18tdf#35570 Writer: drag and drop rows/columns without overwritingLászló Németh
cells of the target table. Instead, paste rows above or columns before in the case of enhanced table selection (clicking in front of the copied rows or columns) or in the case of wholly selected tables. At moving (without pressing Ctrl during drag and drop), remove the originally selected rows or columns instead of emptying them. Change-Id: I4072d51fa8e8ae9a5b9d57f43643eadcad712597 Reviewed-on: https://gerrit.libreoffice.org/85375 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-12-18Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - Missing prepositions Change-Id: I1774899feb35b39f10d8cc3cb8dfdef06f76a66f Reviewed-on: https://gerrit.libreoffice.org/83198 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-18Fix typoAndrea Gelmini
Change-Id: Ia721484c9c39d62e939bb3f5628c8dcaa89d5603 Reviewed-on: https://gerrit.libreoffice.org/85417 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-18tdf#124176: Use pragma once instead of include guardsMuhammet Kara
Change-Id: I3df73c321efa7fa3e8a87608c3c7189f7d839ac8 Reviewed-on: https://gerrit.libreoffice.org/85384 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18Remove "--clean" option from autogen.shStepas Toliautas
autogen.sh seems to be used as a preprocessor for configure script, so it has only a few options itself. However, "--clean" option, which is even documented in script's help message, now touches only two items in repository (on Windows): autom4te.cache folder, which is refreshed during autogen.sh run anyway, and install-sh script, which is NOT regenerated afterwards. So using --clean actually breaks configuration setup. Please check if anyone still uses --clean for its original purpose and remove this feature or automate install-sh regeneration. Change-Id: Ic3991ea4e53cea5ad07696f9b75acf9176eb7ce1 Reviewed-on: https://gerrit.libreoffice.org/85247 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-12-18Silence -Werror,-WuninitializedStephan Bergmann
...as seen with "Android (5220042 based on r346389c) clang version 8.0.7 (https://android.googlesource.com/toolchain/clang b55f2d4ebfd35bf643d27dbca1bb228957008617) (https://android.googlesource.com/toolchain/llvm 3c393fe7a7e13b0fba4ac75a01aa683d7a5b11cd) (based on LLVM 8.0.7svn)", warning about functionIndex, vtableOffset, and indirectRet being used "uninitialized" (but which is as intended, carrying over the values those registers have upon entry to the function) Change-Id: I443fe2e8bf7c25a5bd2bfd99c245d430be65f445 Reviewed-on: https://gerrit.libreoffice.org/85400 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-18tdf#127481: reset active cell reference during table copyStepas Toliautas
During cloning of 1x1 table, SdrTableObjImpl.mxActiveCell reference is set incorrectly, keeping an address of a temporary cell. I clear that reference so it gets assigned to a cell of a new table on first request. An alternative is to find the position of an active cell in source table and set it to a corresponding cell in cloned table (after call to new TableModel()), but I have no opinion on whether newly-cloned table should have active cell marker, and the assignment seems to work in some other fashion for multi-cell tables. So I just zero-init temp object, which should be done anyway. Change-Id: I965b7afbfedf2e57262d3388be1d045687521eee Reviewed-on: https://gerrit.libreoffice.org/85275 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-12-18sal_Char->char in dbaccessNoel Grandin
Change-Id: I6cce128843d88bc453d171b2584ecf0dfffd1044 Reviewed-on: https://gerrit.libreoffice.org/85398 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18sal_Char->char in cppcanvas..cuiNoel Grandin
Change-Id: I7e9fa7011f1e0bf143f86055718c772caebf8ee6 Reviewed-on: https://gerrit.libreoffice.org/85397 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18load images by explicit typeNoel Grandin
speed ups dialog load time a little (10%) Change-Id: Id64c50c27ffc5971049313a3b9105e4e36fc0b69 Reviewed-on: https://gerrit.libreoffice.org/85388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18Resolves: tdf#129444 relabel the insert bibliography entry sectionsCaolán McNamara
following Mihkel Tõnnov suggestions of... << The two section headers, "Entry" (old) and "Layout" (new in 6.4) no longer match their sections: 1) "Entry" has only two sub-items now, the radio buttons for choosing between "From bibliography database" and "From document content". 2) "Layout" has three sub-items: Short name (dropdown), Author, Title. It would be logical to name that one "Entry", and rename the first header (current "Entry") to "Bibliography source" or similar, as it now is header only for the upper part of the dialog, not the whole dialog anymore. >> and << If their header becomes "Bibliography Source", then I think the "From" should be dropped from them: "Bibliography database" and "Document content". >> Change-Id: I35f566defb02f3931507543536c534564bfbd2f4 Reviewed-on: https://gerrit.libreoffice.org/85270 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-18Reduce indentationSamuel Mehrbrodt
Change-Id: I056016bac5d08a85f9664e31bcaee01c2dd9e6e0 Reviewed-on: https://gerrit.libreoffice.org/85391 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-18unused supressionCaolán McNamara
Change-Id: I0e58eacbf28d4c52e096f26d3f472560b22f286e Reviewed-on: https://gerrit.libreoffice.org/85393 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-18reduce temporary OUString creationNoel Grandin
speeds up dialog load time a little (5%) Change-Id: Ia4e5f1973bb6f06b2b5ec6a251e4ad07fc3636d2 Reviewed-on: https://gerrit.libreoffice.org/85389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18lok: vcl: fix multiple floatwin removal case more robustly.Michael Meeks
Instead of this over-clever approach of recursively removing items which can easily fail, build a list, then iterate it in-line while disabling recursion. also includes: lok: vcl: fix multiple floatwin removal case. We need to progress in our while loop to remove children, even if they are currently not in popup-mode; fixes infinite loop with two popups present concurrently. Change-Id: Ic7b7f8e13a466d254abe53b77bc166c6a89fa8c3 Reviewed-on: https://gerrit.libreoffice.org/85368 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-18tdf#128671: Rely on unwind.h, declare what's missing from cxxabi.hStephan Bergmann
...for gcc3_linux_aarch64, similar to what 128deeae81a6f802bfb79b8f0fa8c4b10729f7db "cxxabi.h is not specific to GCC" et al did for gcc3_linux_x86-64 Change-Id: Iee9980842c0e5f6f49642407339a67e865f8be9c Reviewed-on: https://gerrit.libreoffice.org/85344 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-18tools: define DbgTestSolarMutex() unconditionallyMiklos Vajna
See the discussion at <https://gerrit.libreoffice.org/#/c/58170/>, and this came up on IRC today again. The above change broke the invariant that you can mix product and debug (but not dbgutil) builds. Restore this, without mandating dbgutil for the solar mutex assert code, which is useful for plain debug builds as well. Change-Id: I1f8bdb114b129fc4f39f186ba917e35e346a16b5 Reviewed-on: https://gerrit.libreoffice.org/85369 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-18sal_Char->char in canvas..codemakerNoel Grandin
Change-Id: Iaf46b42a17bc00da0f86daeafea7b5346c4a6360 Reviewed-on: https://gerrit.libreoffice.org/85372 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18Fix typos concerning the __cxa_exception checkStephan Bergmann
...introduced with 069506bcb0ee4005b01c22095ed427b96b553c98 "Use config_cxxabi.h to check for __cxa_eh_globals, __cxa_exception", but which appear to have been harmless as (a) the checked-for __cxxabiv1::__cxa_exceptions never existed in cxxabi.h, and (b) lack of __cxxabiv1::__cxa_exception in cxxabi.h happened to conincide with !HAVE_CXXABI_H_CXA_EH_GLOBALS Change-Id: I13f8a2b3cf0f03f2bc96cf053d2b571860055978 Reviewed-on: https://gerrit.libreoffice.org/85373 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-18Fix instructions for setting up the SDKStephan Bergmann
(see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2019-December/084013.html> "Beginner's question about installing Libreoffice SDK") Change-Id: Iea0c394ec052587cdf4ba2a6a7ab38f4214ccbf0 Reviewed-on: https://gerrit.libreoffice.org/85374 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-18Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics),Stephan Bergmann
...redux, after 8473ac2e27efff3ec902a358896a669ce05f047a "Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics)" had done the same in parallel but forgot to remove some now-unnecessary parts: There appears to be no good reason to control the lifecycle of the VtableFactory instance via dso_init/exit, instead of via a plain static local variable. This removes the need for the Windows DllMain functions. They also called DisableThreadLibraryCalls, which disables the DLL_THREAD_ATTACH and DLL_THREAD_DETACH notifications for the respective DllMain. Lets assume that this was only done (as an optimization) because there had to be a user-provided DllMain, and that it was not in itself a reason to have a user-provided DllMain. (Most other DllMain across the code base that call DisableThreadLibraryCalls also do something else. The only DllMain that only calls DisableThreadLibraryCalls is the one in shell/source/win32/shlxthandler/ooofilt/ooofilt.cxx, introduced with 3fbfb21e298ba506c50733d4aaefc7550bca2fe4 "INTEGRATION: CWS desktintgr02".) Change-Id: I696e1c8d49060853c1a2c24f67469f6adfea6801 Reviewed-on: https://gerrit.libreoffice.org/85367 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-18sal_Char->char in avmedia..basicNoel Grandin
Change-Id: Ied1331d979539ef1183da64c55351b57d24f4a4f Reviewed-on: https://gerrit.libreoffice.org/85371 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18tdf#128683 Add More Options button to Table section in Writer's SidebarRoman Kuznetsov
Change-Id: I057f7853fafcf8aa33611adae969b12fda6405b7 Reviewed-on: https://gerrit.libreoffice.org/84972 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2019-12-18tdf#42949 Fix IWYU warnings in sfx2/source/appl/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id8d2d6f739ac3b039d4afe7d1b65119b9eb614a5 Reviewed-on: https://gerrit.libreoffice.org/84674 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-18Fix typoAndrea Gelmini
Change-Id: Ic1daa649bbe73f2237f4e83e85cda88ba041e1f3 Reviewed-on: https://gerrit.libreoffice.org/85365 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-18Fix typoAndrea Gelmini
Change-Id: I2bebd1ea9e8bd7815f6a0fccf5a87af68c84fbb7 Reviewed-on: https://gerrit.libreoffice.org/85364 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-18tdf#119227 fix freeze when copying a large bulleted listNoel Grandin
freeze goes from 5 seconds to about 1 second for me (1) used unordered_map instead of map (2) don't create temporary SfxItemSet's just to check equality Change-Id: I17939adb9ffd53bc56339d7a62ef217ade26de36 Reviewed-on: https://gerrit.libreoffice.org/85298 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics),Stephan Bergmann
...redux, after 51e7a590976f664deb0a386d23b66bee38ea5687 "Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics)" had done the same in parallel but forgot to remove some now-unnecessary parts Change-Id: I6c9d80c28b673ffb178d4f3cbd097b7d90891344 Reviewed-on: https://gerrit.libreoffice.org/85356 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-18loplugin:duplicate-definesNoel Grandin
these are already defined in include/svx/charmap.hxx, which is the superclass header, so that looks like the better place to keep Change-Id: I313a6a910e061360846cab4f84b0f47c98778aae Reviewed-on: https://gerrit.libreoffice.org/85342 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18drop ellipsize on 'and'Caolán McNamara
Change-Id: I60377bf94c2c7c360bb56e0cd85df3d7dabe61e9 Reviewed-on: https://gerrit.libreoffice.org/85323 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-18use o3tl::optional rather than boost::optionalNoel Grandin
Change-Id: Ia02e4c37935445e35e806964570fa900e3981463 Reviewed-on: https://gerrit.libreoffice.org/85357 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-12-29 17:05:57 +0000